Uh oh!
There was an error while loading. Please reload this page.
Chained Server Fn Syntax, ServerFn Middleware - #2513
Conversation
ssijak
commented
Oct 15, 2024
Let's goooo 🚀 |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
| path: babel.NodePath<t.CallExpression>, | ||
| opts: ParseAstOptions, | ||
| ) { | ||
| // const firstArg = path.node.arguments[0] |
Uh oh!
There was an error while loading. Please reload this page.
| { | ||
| name: 'custom-hot-update-client', | ||
| handleHotUpdate(ctx) { | ||
| console.log('server hot', ctx) |
…uter into server-fn-middleware
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
| loader: ({ params: { _splat } }) => getDocument(_splat!), | ||
| loader: ({ params: { _splat } }) => | ||
| getDocument({ | ||
| data: _splat!, |
There was a problem hiding this comment.
Is there a reason why the _splat param needs to be asserted here as NOT undefined?
Unless, is the splat route also expected to be matched when a not is in the "notFound" status? This wouldn't make sense to me, since if we hit a "notFound" the router should grab the nearest notFoundComponent by default (or the root route's notFoundComponent based on the router's setting).
There was a problem hiding this comment.
I think we could probably ensure it's at least a string, even if it's empty
# Conflicts: # docs/framework/react/start/getting-started.md # examples/react/search-validator-adapters/package.json # packages/arktype-adapter/package.json # packages/react-router/src/fileRoute.ts # packages/react-router/src/route.ts # packages/start-vite-plugin/package.json # packages/start/src/config/index.ts # packages/valibot-adapter/package.json # packages/zod-adapter/package.json # pnpm-lock.yaml
…uter into server-fn-middleware
except the search-validator-adapters example, everything else builds fine
ttsirkia
commented
Nov 17, 2024
This PR included a new Middleware Guide page for Start. It is visible as a link in Server Functions page but not in the main contents menu. Should it also be visible there? |
tannerlinsley
commented
Nov 17, 2024
Fixed. |
ttsirkia
commented
Nov 17, 2024
Great, thanks! |
thebuilder
commented
Nov 19, 2024
This PR silently changes the package name of adapters between two patch versions ( -import { zodSearchValidator } from '@tanstack/router-zod-adapter';+import { zodValidator } from '@tanstack/zod-adapter';After bumping dependencies, the types for Why isn't something like this marked as a breaking change, but just thrown into a huge PR with no description? The damage is done, but could you at least:
|
schiller-manuel
commented
Nov 19, 2024
@thebuilder |
No description provided.