fix(solid-router): make HeadContent work for client navigation - #3616

Merged
schiller-manuel merged 7 commits into
TanStack:mainfrom
birkskyum:add-solidjs/meta-to-solid-router
Mar 1, 2025
Merged

fix(solid-router): make HeadContent work for client navigation#3616
schiller-manuel merged 7 commits into
TanStack:mainfrom
birkskyum:add-solidjs/meta-to-solid-router

Conversation

@birkskyum

@birkskyumbirkskyum commented Mar 1, 2025•
edited
Loading

Copy link
Copy Markdown
Member

Picking solid-router relevant changes from commit by @brenelz , that fixes assets handler in solid-router by using @solidjs/meta.

With this, the head tags like the title will update on client navigation.

The changes in this PR that affect most files are merely repetitions of:

  • bumping solid 1.9.4 -> 1.9.5
  • inserting <HeadContent> in the root route
  • removing <title> from the index.html

Includes an automated test for solid-router corresponding to

@nx-cloud

nx-cloudBot commented Mar 1, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

View your CI Pipeline Execution ↗ for commit dec50f8.

CommandStatusDurationResult
nx affected --targets=test:eslint,test:unit,tes...✅ Succeeded4m 47sView ↗
nx run-many --target=build --exclude=examples/*...✅ Succeeded1m 57sView ↗

☁️ Nx Cloud last updated this comment at 2025-03-01 05:06:52 UTC

@birkskyumbirkskyum changed the title chore(solid-router): fix HeadContentfix(solid-router): make HeadContent work for client navigationMar 1, 2025
@pkg-pr-new

pkg-pr-newBot commented Mar 1, 2025•
edited
Loading

Copy link
Copy Markdown

Open in Stackblitz

More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/@tanstack/arktype-adapter@3616

@tanstack/create-router

npm i https://pkg.pr.new/@tanstack/create-router@3616

@tanstack/create-start

npm i https://pkg.pr.new/@tanstack/create-start@3616

@tanstack/directive-functions-plugin

npm i https://pkg.pr.new/@tanstack/directive-functions-plugin@3616

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@3616

@tanstack/history

npm i https://pkg.pr.new/@tanstack/history@3616

@tanstack/react-router

npm i https://pkg.pr.new/@tanstack/react-router@3616

@tanstack/react-start

npm i https://pkg.pr.new/@tanstack/react-start@3616

@tanstack/react-router-with-query

npm i https://pkg.pr.new/@tanstack/react-router-with-query@3616

@tanstack/react-start-api-routes

npm i https://pkg.pr.new/@tanstack/react-start-api-routes@3616

@tanstack/react-start-client

npm i https://pkg.pr.new/@tanstack/react-start-client@3616

@tanstack/react-start-config

npm i https://pkg.pr.new/@tanstack/react-start-config@3616

@tanstack/react-start-plugin

npm i https://pkg.pr.new/@tanstack/react-start-plugin@3616

@tanstack/react-start-router-manifest

npm i https://pkg.pr.new/@tanstack/react-start-router-manifest@3616

@tanstack/react-start-server

npm i https://pkg.pr.new/@tanstack/react-start-server@3616

@tanstack/react-start-server-functions-client

npm i https://pkg.pr.new/@tanstack/react-start-server-functions-client@3616

@tanstack/react-start-server-functions-fetcher

npm i https://pkg.pr.new/@tanstack/react-start-server-functions-fetcher@3616

@tanstack/react-start-server-functions-handler

npm i https://pkg.pr.new/@tanstack/react-start-server-functions-handler@3616

@tanstack/react-start-server-functions-ssr

npm i https://pkg.pr.new/@tanstack/react-start-server-functions-ssr@3616

@tanstack/router-cli

npm i https://pkg.pr.new/@tanstack/router-cli@3616

@tanstack/router-core

npm i https://pkg.pr.new/@tanstack/router-core@3616

@tanstack/router-devtools

npm i https://pkg.pr.new/@tanstack/router-devtools@3616

@tanstack/router-generator

npm i https://pkg.pr.new/@tanstack/router-generator@3616

@tanstack/router-plugin

npm i https://pkg.pr.new/@tanstack/router-plugin@3616

@tanstack/router-utils

npm i https://pkg.pr.new/@tanstack/router-utils@3616

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/@tanstack/router-vite-plugin@3616

@tanstack/server-functions-plugin

npm i https://pkg.pr.new/@tanstack/server-functions-plugin@3616

@tanstack/solid-router

npm i https://pkg.pr.new/@tanstack/solid-router@3616

@tanstack/start

npm i https://pkg.pr.new/@tanstack/start@3616

@tanstack/start-config

npm i https://pkg.pr.new/@tanstack/start-config@3616

@tanstack/start-server-functions-server

npm i https://pkg.pr.new/@tanstack/start-server-functions-server@3616

@tanstack/valibot-adapter

npm i https://pkg.pr.new/@tanstack/valibot-adapter@3616

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/@tanstack/virtual-file-routes@3616

@tanstack/zod-adapter

npm i https://pkg.pr.new/@tanstack/zod-adapter@3616

commit: dec50f8

@birkskyumbirkskyum mentioned this pull request Mar 1, 2025
Merged
10 tasks
@schiller-manuel
schiller-manuel merged commit 409cdf1 into TanStack:mainMar 1, 2025
schiller-manuel pushed a commit that referenced this pull request Mar 1, 2025
@birkskyum@autofix-ci
@brenelz@XiNiHaBrenley Dueck
SolidJS driver for TanStack Start (#3522)
e2ac863
This PR introduce support for Solid to be used with TanStack Start.
There are several ongoing refactors that can influence the timing of
when it's most feasible to merge this.
### Status (build and run e2e/solid-start/basic)
- [X] SSR
- [x] API Routes
- [x] Server Functions
- [x] HMR
- [x] Streaming (/stream route)
- [X] Timely hydration
### Ongoing refactors
Refactor to make router packages (aka. client-only features) more
agnostic:
- #3552
- #3540
- #3538
- #3171
Refactor to make start packages (aka. server features) more agnostic:
- #3546 - #3563 - #3565 ### Upstream changes to solid-router
- #3592
- #3591
- #3589
- #3616 ### Passing E2E test suites
- [x] basic
- [x] website
- [x] scroll-restoration
- [x] server-functions
---------
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: Brenley Dueck <brenleydueck@gmail.com>
Co-authored-by: Iha Shin <me@xiniha.dev>
Co-authored-by: Brenley Dueck <brenley@crowdbotics.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

package: solid-router

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@birkskyum@schiller-manuel
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
fix(solid-router): make HeadContent work for client navigation - #3616
Merged
schiller-manuel merged 7 commits into
TanStack:mainfrom 
birkskyum:add-solidjs/meta-to-solid-router
Mar 1, 2025
Merged
fix(solid-router): make HeadContent work for client navigation#3616
schiller-manuel merged 7 commits into
TanStack:mainfrom 
birkskyum:add-solidjs/meta-to-solid-router
Conversation
@birkskyum
@birkskyumbirkskyum
commented
Mar 1, 2025•

edited

Loading

Copy link


Copy Markdown

Member
Picking solid-router relevant changes from commit by @brenelz , that fixes assets handler in solid-router by using @solidjs/meta.
With this, the head tags like the title will update on client navigation.
The changes in this PR that affect most files are merely repetitions of:
  • bumping solid 1.9.4 -> 1.9.5
  • inserting <HeadContent> in the root route
  • removing <title> from the index.html
Includes an automated test for solid-router corresponding to
@nx-cloud
nx-cloudBot
commented
Mar 1, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
View your CI Pipeline Execution ↗ for commit dec50f8.
CommandStatusDurationResult
nx affected --targets=test:eslint,test:unit,tes...✅ Succeeded4m 47sView ↗
nx run-many --target=build --exclude=examples/*...✅ Succeeded1m 57sView ↗
☁️ Nx Cloud last updated this comment at 2025-03-01 05:06:52 UTC
@birkskyumbirkskyum
changed the title
chore(solid-router): fix HeadContentfix(solid-router): make HeadContent work for client navigationMar 1, 2025
@pkg-pr-new
pkg-pr-newBot
commented
Mar 1, 2025•

edited

Loading

Copy link


Copy Markdown

Open in Stackblitz
More templates
@tanstack/arktype-adapter
npm i https://pkg.pr.new/@tanstack/arktype-adapter@3616

@tanstack/create-router
npm i https://pkg.pr.new/@tanstack/create-router@3616

@tanstack/create-start
npm i https://pkg.pr.new/@tanstack/create-start@3616

@tanstack/directive-functions-plugin
npm i https://pkg.pr.new/@tanstack/directive-functions-plugin@3616

@tanstack/eslint-plugin-router
npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@3616

@tanstack/history
npm i https://pkg.pr.new/@tanstack/history@3616

@tanstack/react-router
npm i https://pkg.pr.new/@tanstack/react-router@3616

@tanstack/react-start
npm i https://pkg.pr.new/@tanstack/react-start@3616

@tanstack/react-router-with-query
npm i https://pkg.pr.new/@tanstack/react-router-with-query@3616

@tanstack/react-start-api-routes
npm i https://pkg.pr.new/@tanstack/react-start-api-routes@3616

@tanstack/react-start-client
npm i https://pkg.pr.new/@tanstack/react-start-client@3616

@tanstack/react-start-config
npm i https://pkg.pr.new/@tanstack/react-start-config@3616

@tanstack/react-start-plugin
npm i https://pkg.pr.new/@tanstack/react-start-plugin@3616

@tanstack/react-start-router-manifest
npm i https://pkg.pr.new/@tanstack/react-start-router-manifest@3616

@tanstack/react-start-server
npm i https://pkg.pr.new/@tanstack/react-start-server@3616

@tanstack/react-start-server-functions-client
npm i https://pkg.pr.new/@tanstack/react-start-server-functions-client@3616

@tanstack/react-start-server-functions-fetcher
npm i https://pkg.pr.new/@tanstack/react-start-server-functions-fetcher@3616

@tanstack/react-start-server-functions-handler
npm i https://pkg.pr.new/@tanstack/react-start-server-functions-handler@3616

@tanstack/react-start-server-functions-ssr
npm i https://pkg.pr.new/@tanstack/react-start-server-functions-ssr@3616

@tanstack/router-cli
npm i https://pkg.pr.new/@tanstack/router-cli@3616

@tanstack/router-core
npm i https://pkg.pr.new/@tanstack/router-core@3616

@tanstack/router-devtools
npm i https://pkg.pr.new/@tanstack/router-devtools@3616

@tanstack/router-generator
npm i https://pkg.pr.new/@tanstack/router-generator@3616

@tanstack/router-plugin
npm i https://pkg.pr.new/@tanstack/router-plugin@3616

@tanstack/router-utils
npm i https://pkg.pr.new/@tanstack/router-utils@3616

@tanstack/router-vite-plugin
npm i https://pkg.pr.new/@tanstack/router-vite-plugin@3616

@tanstack/server-functions-plugin
npm i https://pkg.pr.new/@tanstack/server-functions-plugin@3616

@tanstack/solid-router
npm i https://pkg.pr.new/@tanstack/solid-router@3616

@tanstack/start
npm i https://pkg.pr.new/@tanstack/start@3616

@tanstack/start-config
npm i https://pkg.pr.new/@tanstack/start-config@3616

@tanstack/start-server-functions-server
npm i https://pkg.pr.new/@tanstack/start-server-functions-server@3616

@tanstack/valibot-adapter
npm i https://pkg.pr.new/@tanstack/valibot-adapter@3616

@tanstack/virtual-file-routes
npm i https://pkg.pr.new/@tanstack/virtual-file-routes@3616

@tanstack/zod-adapter
npm i https://pkg.pr.new/@tanstack/zod-adapter@3616

commit: dec50f8
@birkskyumbirkskyum
mentioned this pull request
Mar 1, 2025
 Merged

10 tasks
@schiller-manuel
schiller-manuel
merged commit 409cdf1
into
TanStack:mainMar 1, 2025
schiller-manuel pushed a commit
that referenced
this pull request
Mar 1, 2025
@birkskyum@autofix-ci
@brenelz@XiNiHaBrenley Dueck
SolidJS driver for TanStack Start (#3522)
e2ac863
This PR introduce support for Solid to be used with TanStack Start.
There are several ongoing refactors that can influence the timing of
when it's most feasible to merge this.
### Status (build and run e2e/solid-start/basic)
- [X] SSR
- [x] API Routes
- [x] Server Functions
- [x] HMR
- [x] Streaming (/stream route)
- [X] Timely hydration
### Ongoing refactors
Refactor to make router packages (aka. client-only features) more
agnostic:
- #3552
- #3540
- #3538
- #3171
Refactor to make start packages (aka. server features) more agnostic:
- #3546 - #3563 - #3565 ### Upstream changes to solid-router
- #3592
- #3591
- #3589
- #3616 ### Passing E2E test suites
- [x] basic
- [x] website
- [x] scroll-restoration
- [x] server-functions
---------
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: Brenley Dueck <brenleydueck@gmail.com>
Co-authored-by: Iha Shin <me@xiniha.dev>
Co-authored-by: Brenley Dueck <brenley@crowdbotics.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

package: solid-router

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@birkskyum@schiller-manuel

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
fix(solid-router): make HeadContent work for client navigation - #3616
Merged
schiller-manuel merged 7 commits into
TanStack:mainfrom 
birkskyum:add-solidjs/meta-to-solid-router
Mar 1, 2025
Merged
fix(solid-router): make HeadContent work for client navigation#3616
schiller-manuel merged 7 commits into
TanStack:mainfrom 
birkskyum:add-solidjs/meta-to-solid-router
Conversation
@birkskyum
@birkskyumbirkskyum
commented
Mar 1, 2025•

edited

Loading

Copy link


Copy Markdown

Member
Picking solid-router relevant changes from commit by @brenelz , that fixes assets handler in solid-router by using @solidjs/meta.
With this, the head tags like the title will update on client navigation.
The changes in this PR that affect most files are merely repetitions of:
  • bumping solid 1.9.4 -> 1.9.5
  • inserting <HeadContent> in the root route
  • removing <title> from the index.html
Includes an automated test for solid-router corresponding to
@nx-cloud
nx-cloudBot
commented
Mar 1, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
View your CI Pipeline Execution ↗ for commit dec50f8.
CommandStatusDurationResult
nx affected --targets=test:eslint,test:unit,tes...✅ Succeeded4m 47sView ↗
nx run-many --target=build --exclude=examples/*...✅ Succeeded1m 57sView ↗
☁️ Nx Cloud last updated this comment at 2025-03-01 05:06:52 UTC
@birkskyumbirkskyum
changed the title
chore(solid-router): fix HeadContentfix(solid-router): make HeadContent work for client navigationMar 1, 2025
@pkg-pr-new
pkg-pr-newBot
commented
Mar 1, 2025•

edited

Loading

Copy link


Copy Markdown

Open in Stackblitz
More templates
@tanstack/arktype-adapter
npm i https://pkg.pr.new/@tanstack/arktype-adapter@3616

@tanstack/create-router
npm i https://pkg.pr.new/@tanstack/create-router@3616

@tanstack/create-start
npm i https://pkg.pr.new/@tanstack/create-start@3616

@tanstack/directive-functions-plugin
npm i https://pkg.pr.new/@tanstack/directive-functions-plugin@3616

@tanstack/eslint-plugin-router
npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@3616

@tanstack/history
npm i https://pkg.pr.new/@tanstack/history@3616

@tanstack/react-router
npm i https://pkg.pr.new/@tanstack/react-router@3616

@tanstack/react-start
npm i https://pkg.pr.new/@tanstack/react-start@3616

@tanstack/react-router-with-query
npm i https://pkg.pr.new/@tanstack/react-router-with-query@3616

@tanstack/react-start-api-routes
npm i https://pkg.pr.new/@tanstack/react-start-api-routes@3616

@tanstack/react-start-client
npm i https://pkg.pr.new/@tanstack/react-start-client@3616

@tanstack/react-start-config
npm i https://pkg.pr.new/@tanstack/react-start-config@3616

@tanstack/react-start-plugin
npm i https://pkg.pr.new/@tanstack/react-start-plugin@3616

@tanstack/react-start-router-manifest
npm i https://pkg.pr.new/@tanstack/react-start-router-manifest@3616

@tanstack/react-start-server
npm i https://pkg.pr.new/@tanstack/react-start-server@3616

@tanstack/react-start-server-functions-client
npm i https://pkg.pr.new/@tanstack/react-start-server-functions-client@3616

@tanstack/react-start-server-functions-fetcher
npm i https://pkg.pr.new/@tanstack/react-start-server-functions-fetcher@3616

@tanstack/react-start-server-functions-handler
npm i https://pkg.pr.new/@tanstack/react-start-server-functions-handler@3616

@tanstack/react-start-server-functions-ssr
npm i https://pkg.pr.new/@tanstack/react-start-server-functions-ssr@3616

@tanstack/router-cli
npm i https://pkg.pr.new/@tanstack/router-cli@3616

@tanstack/router-core
npm i https://pkg.pr.new/@tanstack/router-core@3616

@tanstack/router-devtools
npm i https://pkg.pr.new/@tanstack/router-devtools@3616

@tanstack/router-generator
npm i https://pkg.pr.new/@tanstack/router-generator@3616

@tanstack/router-plugin
npm i https://pkg.pr.new/@tanstack/router-plugin@3616

@tanstack/router-utils
npm i https://pkg.pr.new/@tanstack/router-utils@3616

@tanstack/router-vite-plugin
npm i https://pkg.pr.new/@tanstack/router-vite-plugin@3616

@tanstack/server-functions-plugin
npm i https://pkg.pr.new/@tanstack/server-functions-plugin@3616

@tanstack/solid-router
npm i https://pkg.pr.new/@tanstack/solid-router@3616

@tanstack/start
npm i https://pkg.pr.new/@tanstack/start@3616

@tanstack/start-config
npm i https://pkg.pr.new/@tanstack/start-config@3616

@tanstack/start-server-functions-server
npm i https://pkg.pr.new/@tanstack/start-server-functions-server@3616

@tanstack/valibot-adapter
npm i https://pkg.pr.new/@tanstack/valibot-adapter@3616

@tanstack/virtual-file-routes
npm i https://pkg.pr.new/@tanstack/virtual-file-routes@3616

@tanstack/zod-adapter
npm i https://pkg.pr.new/@tanstack/zod-adapter@3616

commit: dec50f8
@birkskyumbirkskyum
mentioned this pull request
Mar 1, 2025
 Merged

10 tasks
@schiller-manuel
schiller-manuel
merged commit 409cdf1
into
TanStack:mainMar 1, 2025
schiller-manuel pushed a commit
that referenced
this pull request
Mar 1, 2025
@birkskyum@autofix-ci
@brenelz@XiNiHaBrenley Dueck
SolidJS driver for TanStack Start (#3522)
e2ac863
This PR introduce support for Solid to be used with TanStack Start.
There are several ongoing refactors that can influence the timing of
when it's most feasible to merge this.
### Status (build and run e2e/solid-start/basic)
- [X] SSR
- [x] API Routes
- [x] Server Functions
- [x] HMR
- [x] Streaming (/stream route)
- [X] Timely hydration
### Ongoing refactors
Refactor to make router packages (aka. client-only features) more
agnostic:
- #3552
- #3540
- #3538
- #3171
Refactor to make start packages (aka. server features) more agnostic:
- #3546 - #3563 - #3565 ### Upstream changes to solid-router
- #3592
- #3591
- #3589
- #3616 ### Passing E2E test suites
- [x] basic
- [x] website
- [x] scroll-restoration
- [x] server-functions
---------
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: Brenley Dueck <brenleydueck@gmail.com>
Co-authored-by: Iha Shin <me@xiniha.dev>
Co-authored-by: Brenley Dueck <brenley@crowdbotics.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

package: solid-router

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@birkskyum@schiller-manuel

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
fix(solid-router): make HeadContent work for client navigation - #3616
Merged
schiller-manuel merged 7 commits into
TanStack:mainfrom 
birkskyum:add-solidjs/meta-to-solid-router
Mar 1, 2025
Merged
fix(solid-router): make HeadContent work for client navigation#3616
schiller-manuel merged 7 commits into
TanStack:mainfrom 
birkskyum:add-solidjs/meta-to-solid-router
Conversation
@birkskyum
@birkskyumbirkskyum
commented
Mar 1, 2025•

edited

Loading

Copy link


Copy Markdown

Member
Picking solid-router relevant changes from commit by @brenelz , that fixes assets handler in solid-router by using @solidjs/meta.
With this, the head tags like the title will update on client navigation.
The changes in this PR that affect most files are merely repetitions of:
  • bumping solid 1.9.4 -> 1.9.5
  • inserting <HeadContent> in the root route
  • removing <title> from the index.html
Includes an automated test for solid-router corresponding to
@nx-cloud
nx-cloudBot
commented
Mar 1, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
View your CI Pipeline Execution ↗ for commit dec50f8.
CommandStatusDurationResult
nx affected --targets=test:eslint,test:unit,tes...✅ Succeeded4m 47sView ↗
nx run-many --target=build --exclude=examples/*...✅ Succeeded1m 57sView ↗
☁️ Nx Cloud last updated this comment at 2025-03-01 05:06:52 UTC
@birkskyumbirkskyum
changed the title
chore(solid-router): fix HeadContentfix(solid-router): make HeadContent work for client navigationMar 1, 2025
@pkg-pr-new
pkg-pr-newBot
commented
Mar 1, 2025•

edited

Loading

Copy link


Copy Markdown

Open in Stackblitz
More templates
@tanstack/arktype-adapter
npm i https://pkg.pr.new/@tanstack/arktype-adapter@3616

@tanstack/create-router
npm i https://pkg.pr.new/@tanstack/create-router@3616

@tanstack/create-start
npm i https://pkg.pr.new/@tanstack/create-start@3616

@tanstack/directive-functions-plugin
npm i https://pkg.pr.new/@tanstack/directive-functions-plugin@3616

@tanstack/eslint-plugin-router
npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@3616

@tanstack/history
npm i https://pkg.pr.new/@tanstack/history@3616

@tanstack/react-router
npm i https://pkg.pr.new/@tanstack/react-router@3616

@tanstack/react-start
npm i https://pkg.pr.new/@tanstack/react-start@3616

@tanstack/react-router-with-query
npm i https://pkg.pr.new/@tanstack/react-router-with-query@3616

@tanstack/react-start-api-routes
npm i https://pkg.pr.new/@tanstack/react-start-api-routes@3616

@tanstack/react-start-client
npm i https://pkg.pr.new/@tanstack/react-start-client@3616

@tanstack/react-start-config
npm i https://pkg.pr.new/@tanstack/react-start-config@3616

@tanstack/react-start-plugin
npm i https://pkg.pr.new/@tanstack/react-start-plugin@3616

@tanstack/react-start-router-manifest
npm i https://pkg.pr.new/@tanstack/react-start-router-manifest@3616

@tanstack/react-start-server
npm i https://pkg.pr.new/@tanstack/react-start-server@3616

@tanstack/react-start-server-functions-client
npm i https://pkg.pr.new/@tanstack/react-start-server-functions-client@3616

@tanstack/react-start-server-functions-fetcher
npm i https://pkg.pr.new/@tanstack/react-start-server-functions-fetcher@3616

@tanstack/react-start-server-functions-handler
npm i https://pkg.pr.new/@tanstack/react-start-server-functions-handler@3616

@tanstack/react-start-server-functions-ssr
npm i https://pkg.pr.new/@tanstack/react-start-server-functions-ssr@3616

@tanstack/router-cli
npm i https://pkg.pr.new/@tanstack/router-cli@3616

@tanstack/router-core
npm i https://pkg.pr.new/@tanstack/router-core@3616

@tanstack/router-devtools
npm i https://pkg.pr.new/@tanstack/router-devtools@3616

@tanstack/router-generator
npm i https://pkg.pr.new/@tanstack/router-generator@3616

@tanstack/router-plugin
npm i https://pkg.pr.new/@tanstack/router-plugin@3616

@tanstack/router-utils
npm i https://pkg.pr.new/@tanstack/router-utils@3616

@tanstack/router-vite-plugin
npm i https://pkg.pr.new/@tanstack/router-vite-plugin@3616

@tanstack/server-functions-plugin
npm i https://pkg.pr.new/@tanstack/server-functions-plugin@3616

@tanstack/solid-router
npm i https://pkg.pr.new/@tanstack/solid-router@3616

@tanstack/start
npm i https://pkg.pr.new/@tanstack/start@3616

@tanstack/start-config
npm i https://pkg.pr.new/@tanstack/start-config@3616

@tanstack/start-server-functions-server
npm i https://pkg.pr.new/@tanstack/start-server-functions-server@3616

@tanstack/valibot-adapter
npm i https://pkg.pr.new/@tanstack/valibot-adapter@3616

@tanstack/virtual-file-routes
npm i https://pkg.pr.new/@tanstack/virtual-file-routes@3616

@tanstack/zod-adapter
npm i https://pkg.pr.new/@tanstack/zod-adapter@3616

commit: dec50f8
@birkskyumbirkskyum
mentioned this pull request
Mar 1, 2025
 Merged

10 tasks
@schiller-manuel
schiller-manuel
merged commit 409cdf1
into
TanStack:mainMar 1, 2025
schiller-manuel pushed a commit
that referenced
this pull request
Mar 1, 2025
@birkskyum@autofix-ci
@brenelz@XiNiHaBrenley Dueck
SolidJS driver for TanStack Start (#3522)
e2ac863
This PR introduce support for Solid to be used with TanStack Start.
There are several ongoing refactors that can influence the timing of
when it's most feasible to merge this.
### Status (build and run e2e/solid-start/basic)
- [X] SSR
- [x] API Routes
- [x] Server Functions
- [x] HMR
- [x] Streaming (/stream route)
- [X] Timely hydration
### Ongoing refactors
Refactor to make router packages (aka. client-only features) more
agnostic:
- #3552
- #3540
- #3538
- #3171
Refactor to make start packages (aka. server features) more agnostic:
- #3546 - #3563 - #3565 ### Upstream changes to solid-router
- #3592
- #3591
- #3589
- #3616 ### Passing E2E test suites
- [x] basic
- [x] website
- [x] scroll-restoration
- [x] server-functions
---------
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: Brenley Dueck <brenleydueck@gmail.com>
Co-authored-by: Iha Shin <me@xiniha.dev>
Co-authored-by: Brenley Dueck <brenley@crowdbotics.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

package: solid-router

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@birkskyum@schiller-manuel

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
fix(solid-router): make HeadContent work for client navigation - #3616
Merged
schiller-manuel merged 7 commits into
TanStack:mainfrom 
birkskyum:add-solidjs/meta-to-solid-router
Mar 1, 2025
Merged
fix(solid-router): make HeadContent work for client navigation#3616
schiller-manuel merged 7 commits into
TanStack:mainfrom 
birkskyum:add-solidjs/meta-to-solid-router
Conversation
@birkskyum
@birkskyumbirkskyum
commented
Mar 1, 2025•

edited

Loading

Copy link


Copy Markdown

Member
Picking solid-router relevant changes from commit by @brenelz , that fixes assets handler in solid-router by using @solidjs/meta.
With this, the head tags like the title will update on client navigation.
The changes in this PR that affect most files are merely repetitions of:
  • bumping solid 1.9.4 -> 1.9.5
  • inserting <HeadContent> in the root route
  • removing <title> from the index.html
Includes an automated test for solid-router corresponding to
@nx-cloud
nx-cloudBot
commented
Mar 1, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
View your CI Pipeline Execution ↗ for commit dec50f8.
CommandStatusDurationResult
nx affected --targets=test:eslint,test:unit,tes...✅ Succeeded4m 47sView ↗
nx run-many --target=build --exclude=examples/*...✅ Succeeded1m 57sView ↗
☁️ Nx Cloud last updated this comment at 2025-03-01 05:06:52 UTC
@birkskyumbirkskyum
changed the title
chore(solid-router): fix HeadContentfix(solid-router): make HeadContent work for client navigationMar 1, 2025
@pkg-pr-new
pkg-pr-newBot
commented
Mar 1, 2025•

edited

Loading

Copy link


Copy Markdown

Open in Stackblitz
More templates
@tanstack/arktype-adapter
npm i https://pkg.pr.new/@tanstack/arktype-adapter@3616

@tanstack/create-router
npm i https://pkg.pr.new/@tanstack/create-router@3616

@tanstack/create-start
npm i https://pkg.pr.new/@tanstack/create-start@3616

@tanstack/directive-functions-plugin
npm i https://pkg.pr.new/@tanstack/directive-functions-plugin@3616

@tanstack/eslint-plugin-router
npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@3616

@tanstack/history
npm i https://pkg.pr.new/@tanstack/history@3616

@tanstack/react-router
npm i https://pkg.pr.new/@tanstack/react-router@3616

@tanstack/react-start
npm i https://pkg.pr.new/@tanstack/react-start@3616

@tanstack/react-router-with-query
npm i https://pkg.pr.new/@tanstack/react-router-with-query@3616

@tanstack/react-start-api-routes
npm i https://pkg.pr.new/@tanstack/react-start-api-routes@3616

@tanstack/react-start-client
npm i https://pkg.pr.new/@tanstack/react-start-client@3616

@tanstack/react-start-config
npm i https://pkg.pr.new/@tanstack/react-start-config@3616

@tanstack/react-start-plugin
npm i https://pkg.pr.new/@tanstack/react-start-plugin@3616

@tanstack/react-start-router-manifest
npm i https://pkg.pr.new/@tanstack/react-start-router-manifest@3616

@tanstack/react-start-server
npm i https://pkg.pr.new/@tanstack/react-start-server@3616

@tanstack/react-start-server-functions-client
npm i https://pkg.pr.new/@tanstack/react-start-server-functions-client@3616

@tanstack/react-start-server-functions-fetcher
npm i https://pkg.pr.new/@tanstack/react-start-server-functions-fetcher@3616

@tanstack/react-start-server-functions-handler
npm i https://pkg.pr.new/@tanstack/react-start-server-functions-handler@3616

@tanstack/react-start-server-functions-ssr
npm i https://pkg.pr.new/@tanstack/react-start-server-functions-ssr@3616

@tanstack/router-cli
npm i https://pkg.pr.new/@tanstack/router-cli@3616

@tanstack/router-core
npm i https://pkg.pr.new/@tanstack/router-core@3616

@tanstack/router-devtools
npm i https://pkg.pr.new/@tanstack/router-devtools@3616

@tanstack/router-generator
npm i https://pkg.pr.new/@tanstack/router-generator@3616

@tanstack/router-plugin
npm i https://pkg.pr.new/@tanstack/router-plugin@3616

@tanstack/router-utils
npm i https://pkg.pr.new/@tanstack/router-utils@3616

@tanstack/router-vite-plugin
npm i https://pkg.pr.new/@tanstack/router-vite-plugin@3616

@tanstack/server-functions-plugin
npm i https://pkg.pr.new/@tanstack/server-functions-plugin@3616

@tanstack/solid-router
npm i https://pkg.pr.new/@tanstack/solid-router@3616

@tanstack/start
npm i https://pkg.pr.new/@tanstack/start@3616

@tanstack/start-config
npm i https://pkg.pr.new/@tanstack/start-config@3616

@tanstack/start-server-functions-server
npm i https://pkg.pr.new/@tanstack/start-server-functions-server@3616

@tanstack/valibot-adapter
npm i https://pkg.pr.new/@tanstack/valibot-adapter@3616

@tanstack/virtual-file-routes
npm i https://pkg.pr.new/@tanstack/virtual-file-routes@3616

@tanstack/zod-adapter
npm i https://pkg.pr.new/@tanstack/zod-adapter@3616

commit: dec50f8
@birkskyumbirkskyum
mentioned this pull request
Mar 1, 2025
 Merged

10 tasks
@schiller-manuel
schiller-manuel
merged commit 409cdf1
into
TanStack:mainMar 1, 2025
schiller-manuel pushed a commit
that referenced
this pull request
Mar 1, 2025
@birkskyum@autofix-ci
@brenelz@XiNiHaBrenley Dueck
SolidJS driver for TanStack Start (#3522)
e2ac863
This PR introduce support for Solid to be used with TanStack Start.
There are several ongoing refactors that can influence the timing of
when it's most feasible to merge this.
### Status (build and run e2e/solid-start/basic)
- [X] SSR
- [x] API Routes
- [x] Server Functions
- [x] HMR
- [x] Streaming (/stream route)
- [X] Timely hydration
### Ongoing refactors
Refactor to make router packages (aka. client-only features) more
agnostic:
- #3552
- #3540
- #3538
- #3171
Refactor to make start packages (aka. server features) more agnostic:
- #3546 - #3563 - #3565 ### Upstream changes to solid-router
- #3592
- #3591
- #3589
- #3616 ### Passing E2E test suites
- [x] basic
- [x] website
- [x] scroll-restoration
- [x] server-functions
---------
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: Brenley Dueck <brenleydueck@gmail.com>
Co-authored-by: Iha Shin <me@xiniha.dev>
Co-authored-by: Brenley Dueck <brenley@crowdbotics.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

package: solid-router

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@birkskyum@schiller-manuel

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
fix(solid-router): make HeadContent work for client navigation - #3616
Merged
schiller-manuel merged 7 commits into
TanStack:mainfrom 
birkskyum:add-solidjs/meta-to-solid-router
Mar 1, 2025
Merged
fix(solid-router): make HeadContent work for client navigation#3616
schiller-manuel merged 7 commits into
TanStack:mainfrom 
birkskyum:add-solidjs/meta-to-solid-router
Conversation
@birkskyum
@birkskyumbirkskyum
commented
Mar 1, 2025•

edited

Loading

Copy link


Copy Markdown

Member
Picking solid-router relevant changes from commit by @brenelz , that fixes assets handler in solid-router by using @solidjs/meta.
With this, the head tags like the title will update on client navigation.
The changes in this PR that affect most files are merely repetitions of:
  • bumping solid 1.9.4 -> 1.9.5
  • inserting <HeadContent> in the root route
  • removing <title> from the index.html
Includes an automated test for solid-router corresponding to
@nx-cloud
nx-cloudBot
commented
Mar 1, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
View your CI Pipeline Execution ↗ for commit dec50f8.
CommandStatusDurationResult
nx affected --targets=test:eslint,test:unit,tes...✅ Succeeded4m 47sView ↗
nx run-many --target=build --exclude=examples/*...✅ Succeeded1m 57sView ↗
☁️ Nx Cloud last updated this comment at 2025-03-01 05:06:52 UTC
@birkskyumbirkskyum
changed the title
chore(solid-router): fix HeadContentfix(solid-router): make HeadContent work for client navigationMar 1, 2025
@pkg-pr-new
pkg-pr-newBot
commented
Mar 1, 2025•

edited

Loading

Copy link


Copy Markdown

Open in Stackblitz
More templates
@tanstack/arktype-adapter
npm i https://pkg.pr.new/@tanstack/arktype-adapter@3616

@tanstack/create-router
npm i https://pkg.pr.new/@tanstack/create-router@3616

@tanstack/create-start
npm i https://pkg.pr.new/@tanstack/create-start@3616

@tanstack/directive-functions-plugin
npm i https://pkg.pr.new/@tanstack/directive-functions-plugin@3616

@tanstack/eslint-plugin-router
npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@3616

@tanstack/history
npm i https://pkg.pr.new/@tanstack/history@3616

@tanstack/react-router
npm i https://pkg.pr.new/@tanstack/react-router@3616

@tanstack/react-start
npm i https://pkg.pr.new/@tanstack/react-start@3616

@tanstack/react-router-with-query
npm i https://pkg.pr.new/@tanstack/react-router-with-query@3616

@tanstack/react-start-api-routes
npm i https://pkg.pr.new/@tanstack/react-start-api-routes@3616

@tanstack/react-start-client
npm i https://pkg.pr.new/@tanstack/react-start-client@3616

@tanstack/react-start-config
npm i https://pkg.pr.new/@tanstack/react-start-config@3616

@tanstack/react-start-plugin
npm i https://pkg.pr.new/@tanstack/react-start-plugin@3616

@tanstack/react-start-router-manifest
npm i https://pkg.pr.new/@tanstack/react-start-router-manifest@3616

@tanstack/react-start-server
npm i https://pkg.pr.new/@tanstack/react-start-server@3616

@tanstack/react-start-server-functions-client
npm i https://pkg.pr.new/@tanstack/react-start-server-functions-client@3616

@tanstack/react-start-server-functions-fetcher
npm i https://pkg.pr.new/@tanstack/react-start-server-functions-fetcher@3616

@tanstack/react-start-server-functions-handler
npm i https://pkg.pr.new/@tanstack/react-start-server-functions-handler@3616

@tanstack/react-start-server-functions-ssr
npm i https://pkg.pr.new/@tanstack/react-start-server-functions-ssr@3616

@tanstack/router-cli
npm i https://pkg.pr.new/@tanstack/router-cli@3616

@tanstack/router-core
npm i https://pkg.pr.new/@tanstack/router-core@3616

@tanstack/router-devtools
npm i https://pkg.pr.new/@tanstack/router-devtools@3616

@tanstack/router-generator
npm i https://pkg.pr.new/@tanstack/router-generator@3616

@tanstack/router-plugin
npm i https://pkg.pr.new/@tanstack/router-plugin@3616

@tanstack/router-utils
npm i https://pkg.pr.new/@tanstack/router-utils@3616

@tanstack/router-vite-plugin
npm i https://pkg.pr.new/@tanstack/router-vite-plugin@3616

@tanstack/server-functions-plugin
npm i https://pkg.pr.new/@tanstack/server-functions-plugin@3616

@tanstack/solid-router
npm i https://pkg.pr.new/@tanstack/solid-router@3616

@tanstack/start
npm i https://pkg.pr.new/@tanstack/start@3616

@tanstack/start-config
npm i https://pkg.pr.new/@tanstack/start-config@3616

@tanstack/start-server-functions-server
npm i https://pkg.pr.new/@tanstack/start-server-functions-server@3616

@tanstack/valibot-adapter
npm i https://pkg.pr.new/@tanstack/valibot-adapter@3616

@tanstack/virtual-file-routes
npm i https://pkg.pr.new/@tanstack/virtual-file-routes@3616

@tanstack/zod-adapter
npm i https://pkg.pr.new/@tanstack/zod-adapter@3616

commit: dec50f8
@birkskyumbirkskyum
mentioned this pull request
Mar 1, 2025
 Merged

10 tasks
@schiller-manuel
schiller-manuel
merged commit 409cdf1
into
TanStack:mainMar 1, 2025
schiller-manuel pushed a commit
that referenced
this pull request
Mar 1, 2025
@birkskyum@autofix-ci
@brenelz@XiNiHaBrenley Dueck
SolidJS driver for TanStack Start (#3522)
e2ac863
This PR introduce support for Solid to be used with TanStack Start.
There are several ongoing refactors that can influence the timing of
when it's most feasible to merge this.
### Status (build and run e2e/solid-start/basic)
- [X] SSR
- [x] API Routes
- [x] Server Functions
- [x] HMR
- [x] Streaming (/stream route)
- [X] Timely hydration
### Ongoing refactors
Refactor to make router packages (aka. client-only features) more
agnostic:
- #3552
- #3540
- #3538
- #3171
Refactor to make start packages (aka. server features) more agnostic:
- #3546 - #3563 - #3565 ### Upstream changes to solid-router
- #3592
- #3591
- #3589
- #3616 ### Passing E2E test suites
- [x] basic
- [x] website
- [x] scroll-restoration
- [x] server-functions
---------
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: Brenley Dueck <brenleydueck@gmail.com>
Co-authored-by: Iha Shin <me@xiniha.dev>
Co-authored-by: Brenley Dueck <brenley@crowdbotics.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

package: solid-router

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@birkskyum@schiller-manuel

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
fix(solid-router): make HeadContent work for client navigation - #3616
Merged
schiller-manuel merged 7 commits into
TanStack:mainfrom 
birkskyum:add-solidjs/meta-to-solid-router
Mar 1, 2025
Merged
fix(solid-router): make HeadContent work for client navigation#3616
schiller-manuel merged 7 commits into
TanStack:mainfrom 
birkskyum:add-solidjs/meta-to-solid-router
Conversation
@birkskyum
@birkskyumbirkskyum
commented
Mar 1, 2025•

edited

Loading

Copy link


Copy Markdown

Member
Picking solid-router relevant changes from commit by @brenelz , that fixes assets handler in solid-router by using @solidjs/meta.
With this, the head tags like the title will update on client navigation.
The changes in this PR that affect most files are merely repetitions of:
  • bumping solid 1.9.4 -> 1.9.5
  • inserting <HeadContent> in the root route
  • removing <title> from the index.html
Includes an automated test for solid-router corresponding to
@nx-cloud
nx-cloudBot
commented
Mar 1, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
View your CI Pipeline Execution ↗ for commit dec50f8.
CommandStatusDurationResult
nx affected --targets=test:eslint,test:unit,tes...✅ Succeeded4m 47sView ↗
nx run-many --target=build --exclude=examples/*...✅ Succeeded1m 57sView ↗
☁️ Nx Cloud last updated this comment at 2025-03-01 05:06:52 UTC
@birkskyumbirkskyum
changed the title
chore(solid-router): fix HeadContentfix(solid-router): make HeadContent work for client navigationMar 1, 2025
@pkg-pr-new
pkg-pr-newBot
commented
Mar 1, 2025•

edited

Loading

Copy link


Copy Markdown

Open in Stackblitz
More templates
@tanstack/arktype-adapter
npm i https://pkg.pr.new/@tanstack/arktype-adapter@3616

@tanstack/create-router
npm i https://pkg.pr.new/@tanstack/create-router@3616

@tanstack/create-start
npm i https://pkg.pr.new/@tanstack/create-start@3616

@tanstack/directive-functions-plugin
npm i https://pkg.pr.new/@tanstack/directive-functions-plugin@3616

@tanstack/eslint-plugin-router
npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@3616

@tanstack/history
npm i https://pkg.pr.new/@tanstack/history@3616

@tanstack/react-router
npm i https://pkg.pr.new/@tanstack/react-router@3616

@tanstack/react-start
npm i https://pkg.pr.new/@tanstack/react-start@3616

@tanstack/react-router-with-query
npm i https://pkg.pr.new/@tanstack/react-router-with-query@3616

@tanstack/react-start-api-routes
npm i https://pkg.pr.new/@tanstack/react-start-api-routes@3616

@tanstack/react-start-client
npm i https://pkg.pr.new/@tanstack/react-start-client@3616

@tanstack/react-start-config
npm i https://pkg.pr.new/@tanstack/react-start-config@3616

@tanstack/react-start-plugin
npm i https://pkg.pr.new/@tanstack/react-start-plugin@3616

@tanstack/react-start-router-manifest
npm i https://pkg.pr.new/@tanstack/react-start-router-manifest@3616

@tanstack/react-start-server
npm i https://pkg.pr.new/@tanstack/react-start-server@3616

@tanstack/react-start-server-functions-client
npm i https://pkg.pr.new/@tanstack/react-start-server-functions-client@3616

@tanstack/react-start-server-functions-fetcher
npm i https://pkg.pr.new/@tanstack/react-start-server-functions-fetcher@3616

@tanstack/react-start-server-functions-handler
npm i https://pkg.pr.new/@tanstack/react-start-server-functions-handler@3616

@tanstack/react-start-server-functions-ssr
npm i https://pkg.pr.new/@tanstack/react-start-server-functions-ssr@3616

@tanstack/router-cli
npm i https://pkg.pr.new/@tanstack/router-cli@3616

@tanstack/router-core
npm i https://pkg.pr.new/@tanstack/router-core@3616

@tanstack/router-devtools
npm i https://pkg.pr.new/@tanstack/router-devtools@3616

@tanstack/router-generator
npm i https://pkg.pr.new/@tanstack/router-generator@3616

@tanstack/router-plugin
npm i https://pkg.pr.new/@tanstack/router-plugin@3616

@tanstack/router-utils
npm i https://pkg.pr.new/@tanstack/router-utils@3616

@tanstack/router-vite-plugin
npm i https://pkg.pr.new/@tanstack/router-vite-plugin@3616

@tanstack/server-functions-plugin
npm i https://pkg.pr.new/@tanstack/server-functions-plugin@3616

@tanstack/solid-router
npm i https://pkg.pr.new/@tanstack/solid-router@3616

@tanstack/start
npm i https://pkg.pr.new/@tanstack/start@3616

@tanstack/start-config
npm i https://pkg.pr.new/@tanstack/start-config@3616

@tanstack/start-server-functions-server
npm i https://pkg.pr.new/@tanstack/start-server-functions-server@3616

@tanstack/valibot-adapter
npm i https://pkg.pr.new/@tanstack/valibot-adapter@3616

@tanstack/virtual-file-routes
npm i https://pkg.pr.new/@tanstack/virtual-file-routes@3616

@tanstack/zod-adapter
npm i https://pkg.pr.new/@tanstack/zod-adapter@3616

commit: dec50f8
@birkskyumbirkskyum
mentioned this pull request
Mar 1, 2025
 Merged

10 tasks
@schiller-manuel
schiller-manuel
merged commit 409cdf1
into
TanStack:mainMar 1, 2025
schiller-manuel pushed a commit
that referenced
this pull request
Mar 1, 2025
@birkskyum@autofix-ci
@brenelz@XiNiHaBrenley Dueck
SolidJS driver for TanStack Start (#3522)
e2ac863
This PR introduce support for Solid to be used with TanStack Start.
There are several ongoing refactors that can influence the timing of
when it's most feasible to merge this.
### Status (build and run e2e/solid-start/basic)
- [X] SSR
- [x] API Routes
- [x] Server Functions
- [x] HMR
- [x] Streaming (/stream route)
- [X] Timely hydration
### Ongoing refactors
Refactor to make router packages (aka. client-only features) more
agnostic:
- #3552
- #3540
- #3538
- #3171
Refactor to make start packages (aka. server features) more agnostic:
- #3546 - #3563 - #3565 ### Upstream changes to solid-router
- #3592
- #3591
- #3589
- #3616 ### Passing E2E test suites
- [x] basic
- [x] website
- [x] scroll-restoration
- [x] server-functions
---------
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: Brenley Dueck <brenleydueck@gmail.com>
Co-authored-by: Iha Shin <me@xiniha.dev>
Co-authored-by: Brenley Dueck <brenley@crowdbotics.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

package: solid-router

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@birkskyum@schiller-manuel

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
fix(solid-router): make HeadContent work for client navigation - #3616
Merged
schiller-manuel merged 7 commits into
TanStack:mainfrom 
birkskyum:add-solidjs/meta-to-solid-router
Mar 1, 2025
Merged
fix(solid-router): make HeadContent work for client navigation#3616
schiller-manuel merged 7 commits into
TanStack:mainfrom 
birkskyum:add-solidjs/meta-to-solid-router
Conversation
@birkskyum
@birkskyumbirkskyum
commented
Mar 1, 2025•

edited

Loading

Copy link


Copy Markdown

Member
Picking solid-router relevant changes from commit by @brenelz , that fixes assets handler in solid-router by using @solidjs/meta.
With this, the head tags like the title will update on client navigation.
The changes in this PR that affect most files are merely repetitions of:
  • bumping solid 1.9.4 -> 1.9.5
  • inserting <HeadContent> in the root route
  • removing <title> from the index.html
Includes an automated test for solid-router corresponding to
@nx-cloud
nx-cloudBot
commented
Mar 1, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
View your CI Pipeline Execution ↗ for commit dec50f8.
CommandStatusDurationResult
nx affected --targets=test:eslint,test:unit,tes...✅ Succeeded4m 47sView ↗
nx run-many --target=build --exclude=examples/*...✅ Succeeded1m 57sView ↗
☁️ Nx Cloud last updated this comment at 2025-03-01 05:06:52 UTC
@birkskyumbirkskyum
changed the title
chore(solid-router): fix HeadContentfix(solid-router): make HeadContent work for client navigationMar 1, 2025
@pkg-pr-new
pkg-pr-newBot
commented
Mar 1, 2025•

edited

Loading

Copy link


Copy Markdown

Open in Stackblitz
More templates
@tanstack/arktype-adapter
npm i https://pkg.pr.new/@tanstack/arktype-adapter@3616

@tanstack/create-router
npm i https://pkg.pr.new/@tanstack/create-router@3616

@tanstack/create-start
npm i https://pkg.pr.new/@tanstack/create-start@3616

@tanstack/directive-functions-plugin
npm i https://pkg.pr.new/@tanstack/directive-functions-plugin@3616

@tanstack/eslint-plugin-router
npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@3616

@tanstack/history
npm i https://pkg.pr.new/@tanstack/history@3616

@tanstack/react-router
npm i https://pkg.pr.new/@tanstack/react-router@3616

@tanstack/react-start
npm i https://pkg.pr.new/@tanstack/react-start@3616

@tanstack/react-router-with-query
npm i https://pkg.pr.new/@tanstack/react-router-with-query@3616

@tanstack/react-start-api-routes
npm i https://pkg.pr.new/@tanstack/react-start-api-routes@3616

@tanstack/react-start-client
npm i https://pkg.pr.new/@tanstack/react-start-client@3616

@tanstack/react-start-config
npm i https://pkg.pr.new/@tanstack/react-start-config@3616

@tanstack/react-start-plugin
npm i https://pkg.pr.new/@tanstack/react-start-plugin@3616

@tanstack/react-start-router-manifest
npm i https://pkg.pr.new/@tanstack/react-start-router-manifest@3616

@tanstack/react-start-server
npm i https://pkg.pr.new/@tanstack/react-start-server@3616

@tanstack/react-start-server-functions-client
npm i https://pkg.pr.new/@tanstack/react-start-server-functions-client@3616

@tanstack/react-start-server-functions-fetcher
npm i https://pkg.pr.new/@tanstack/react-start-server-functions-fetcher@3616

@tanstack/react-start-server-functions-handler
npm i https://pkg.pr.new/@tanstack/react-start-server-functions-handler@3616

@tanstack/react-start-server-functions-ssr
npm i https://pkg.pr.new/@tanstack/react-start-server-functions-ssr@3616

@tanstack/router-cli
npm i https://pkg.pr.new/@tanstack/router-cli@3616

@tanstack/router-core
npm i https://pkg.pr.new/@tanstack/router-core@3616

@tanstack/router-devtools
npm i https://pkg.pr.new/@tanstack/router-devtools@3616

@tanstack/router-generator
npm i https://pkg.pr.new/@tanstack/router-generator@3616

@tanstack/router-plugin
npm i https://pkg.pr.new/@tanstack/router-plugin@3616

@tanstack/router-utils
npm i https://pkg.pr.new/@tanstack/router-utils@3616

@tanstack/router-vite-plugin
npm i https://pkg.pr.new/@tanstack/router-vite-plugin@3616

@tanstack/server-functions-plugin
npm i https://pkg.pr.new/@tanstack/server-functions-plugin@3616

@tanstack/solid-router
npm i https://pkg.pr.new/@tanstack/solid-router@3616

@tanstack/start
npm i https://pkg.pr.new/@tanstack/start@3616

@tanstack/start-config
npm i https://pkg.pr.new/@tanstack/start-config@3616

@tanstack/start-server-functions-server
npm i https://pkg.pr.new/@tanstack/start-server-functions-server@3616

@tanstack/valibot-adapter
npm i https://pkg.pr.new/@tanstack/valibot-adapter@3616

@tanstack/virtual-file-routes
npm i https://pkg.pr.new/@tanstack/virtual-file-routes@3616

@tanstack/zod-adapter
npm i https://pkg.pr.new/@tanstack/zod-adapter@3616

commit: dec50f8
@birkskyumbirkskyum
mentioned this pull request
Mar 1, 2025
 Merged

10 tasks
@schiller-manuel
schiller-manuel
merged commit 409cdf1
into
TanStack:mainMar 1, 2025
schiller-manuel pushed a commit
that referenced
this pull request
Mar 1, 2025
@birkskyum@autofix-ci
@brenelz@XiNiHaBrenley Dueck
SolidJS driver for TanStack Start (#3522)
e2ac863
This PR introduce support for Solid to be used with TanStack Start.
There are several ongoing refactors that can influence the timing of
when it's most feasible to merge this.
### Status (build and run e2e/solid-start/basic)
- [X] SSR
- [x] API Routes
- [x] Server Functions
- [x] HMR
- [x] Streaming (/stream route)
- [X] Timely hydration
### Ongoing refactors
Refactor to make router packages (aka. client-only features) more
agnostic:
- #3552
- #3540
- #3538
- #3171
Refactor to make start packages (aka. server features) more agnostic:
- #3546 - #3563 - #3565 ### Upstream changes to solid-router
- #3592
- #3591
- #3589
- #3616 ### Passing E2E test suites
- [x] basic
- [x] website
- [x] scroll-restoration
- [x] server-functions
---------
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: Brenley Dueck <brenleydueck@gmail.com>
Co-authored-by: Iha Shin <me@xiniha.dev>
Co-authored-by: Brenley Dueck <brenley@crowdbotics.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

package: solid-router

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@birkskyum@schiller-manuel