Skip to content

feat: add support for shouldThrow in RouteApi - #3642

Draft
schiller-manuel wants to merge 1 commit into
mainfrom
shouldThrow-RouteAPI
Draft

feat: add support for shouldThrow in RouteApi#3642
schiller-manuel wants to merge 1 commit into
mainfrom
shouldThrow-RouteAPI

Conversation

@schiller-manuel

@schiller-manuel schiller-manuel commented Mar 3, 2025

Copy link
Copy Markdown
Collaborator

resolves #3482

WIP
needs runtime tests

@nx-cloud

nx-cloud Bot commented Mar 3, 2025

Copy link
Copy Markdown
Contributor

View your CI Pipeline Execution ↗ for commit c983854.

Command Status Duration Result
nx affected --targets=test:eslint,test:unit,tes... ❌ Failed 4m 42s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 1m 29s View ↗

☁️ Nx Cloud last updated this comment at 2025-03-03 00:25:56 UTC

@pkg-pr-new

pkg-pr-new Bot commented Mar 3, 2025

Copy link
Copy Markdown

Open in Stackblitz

More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/arktype-adapter@3642

@tanstack/create-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/create-router@3642

@tanstack/create-start

npm i https://pkg.pr.new/TanStack/router/@tanstack/create-start@3642

@tanstack/directive-functions-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/directive-functions-plugin@3642

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/eslint-plugin-router@3642

@tanstack/history

npm i https://pkg.pr.new/TanStack/router/@tanstack/history@3642

@tanstack/react-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router@3642

@tanstack/react-router-with-query

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router-with-query@3642

@tanstack/react-start-api-routes

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-api-routes@3642

@tanstack/react-start

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start@3642

@tanstack/react-start-client

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-client@3642

@tanstack/react-start-config

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-config@3642

@tanstack/react-start-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-plugin@3642

@tanstack/react-start-router-manifest

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-router-manifest@3642

@tanstack/react-start-server

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-server@3642

@tanstack/react-start-server-functions-client

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-server-functions-client@3642

@tanstack/react-start-server-functions-fetcher

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-server-functions-fetcher@3642

@tanstack/react-start-server-functions-handler

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-server-functions-handler@3642

@tanstack/react-start-server-functions-ssr

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-server-functions-ssr@3642

@tanstack/router-cli

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-cli@3642

@tanstack/router-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-core@3642

@tanstack/router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-devtools@3642

@tanstack/router-generator

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-generator@3642

@tanstack/router-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-plugin@3642

@tanstack/router-utils

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-utils@3642

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-vite-plugin@3642

@tanstack/server-functions-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/server-functions-plugin@3642

@tanstack/solid-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router@3642

@tanstack/solid-start

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start@3642

@tanstack/solid-start-api-routes

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-api-routes@3642

@tanstack/solid-start-client

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-client@3642

@tanstack/solid-start-config

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-config@3642

@tanstack/solid-start-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-plugin@3642

@tanstack/solid-start-router-manifest

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-router-manifest@3642

@tanstack/solid-start-server

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-server@3642

@tanstack/solid-start-server-functions-client

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-server-functions-client@3642

@tanstack/solid-start-server-functions-fetcher

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-server-functions-fetcher@3642

@tanstack/solid-start-server-functions-handler

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-server-functions-handler@3642

@tanstack/solid-start-server-functions-ssr

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-server-functions-ssr@3642

@tanstack/start

npm i https://pkg.pr.new/TanStack/router/@tanstack/start@3642

@tanstack/start-config

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-config@3642

@tanstack/valibot-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/valibot-adapter@3642

@tanstack/start-server-functions-server

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-server-functions-server@3642

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/TanStack/router/@tanstack/virtual-file-routes@3642

@tanstack/zod-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/zod-adapter@3642

commit: c983854

@LadyBluenotes

Copy link
Copy Markdown
Member

@schiller-manuel did you still want this in? I think it’s close. It would need a rebase, the runtime coverage noted in the draft, and a decision on whether we should fix the same route-bound API in Solid and Vue at the same time.

If you need me to take it over, just lmk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

shouldThrow option for useParams not working

3 participants