Skip to content

feat(router-core): allow disabling scroll restoration for specific containers - #4059

Closed
schiller-manuel wants to merge 1 commit into
mainfrom
disable-scroll-restoration-specific-containers
Closed

feat(router-core): allow disabling scroll restoration for specific containers#4059
schiller-manuel wants to merge 1 commit into
mainfrom
disable-scroll-restoration-specific-containers

Conversation

@schiller-manuel

Copy link
Copy Markdown
Collaborator

No description provided.

@nx-cloud

nx-cloudBot commented Apr 27, 2025

Copy link
Copy Markdown
Contributor

View your CI Pipeline Execution ↗ for commit b727f46.

CommandStatusDurationResult
nx affected --targets=test:eslint,test:unit,tes...✅ Succeeded5m 12sView ↗
nx run-many --target=build --exclude=examples/*...✅ Succeeded2m 1sView ↗

☁️ Nx Cloud last updated this comment at 2025-04-27 20:16:28 UTC

@pkg-pr-new

Copy link
Copy Markdown
More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/arktype-adapter@4059

@tanstack/directive-functions-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/directive-functions-plugin@4059

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/eslint-plugin-router@4059

@tanstack/history

npm i https://pkg.pr.new/TanStack/router/@tanstack/history@4059

@tanstack/react-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router@4059

@tanstack/react-router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router-devtools@4059

@tanstack/react-router-with-query

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router-with-query@4059

@tanstack/react-start-client

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-client@4059

@tanstack/react-start

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start@4059

@tanstack/react-start-config

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-config@4059

@tanstack/react-start-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-plugin@4059

@tanstack/react-start-router-manifest

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-router-manifest@4059

@tanstack/react-start-server

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-server@4059

@tanstack/router-cli

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-cli@4059

@tanstack/router-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-core@4059

@tanstack/router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-devtools@4059

@tanstack/router-devtools-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-devtools-core@4059

@tanstack/router-generator

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-generator@4059

@tanstack/router-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-plugin@4059

@tanstack/router-utils

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-utils@4059

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-vite-plugin@4059

@tanstack/server-functions-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/server-functions-plugin@4059

@tanstack/solid-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router@4059

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router-devtools@4059

@tanstack/solid-start

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start@4059

@tanstack/solid-start-client

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-client@4059

@tanstack/solid-start-config

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-config@4059

@tanstack/solid-start-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-plugin@4059

@tanstack/solid-start-router-manifest

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-router-manifest@4059

@tanstack/solid-start-server

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-server@4059

@tanstack/start

npm i https://pkg.pr.new/TanStack/router/@tanstack/start@4059

@tanstack/start-api-routes

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-api-routes@4059

@tanstack/start-client-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-client-core@4059

@tanstack/start-config

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-config@4059

@tanstack/start-server-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-server-core@4059

@tanstack/start-server-functions-client

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-server-functions-client@4059

@tanstack/start-server-functions-fetcher

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-server-functions-fetcher@4059

@tanstack/start-server-functions-handler

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-server-functions-handler@4059

@tanstack/start-server-functions-server

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-server-functions-server@4059

@tanstack/start-server-functions-ssr

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-server-functions-ssr@4059

@tanstack/valibot-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/valibot-adapter@4059

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/TanStack/router/@tanstack/virtual-file-routes@4059

@tanstack/zod-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/zod-adapter@4059

commit: b727f46

@SeanCassiereSeanCassiere left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add some end-to-end tests (in e2e/react-router/scroll-restoration-sandbox-vite and e2e/solid-router/scroll-restoration-sandbox-vite)?

Something that tests this behaviour.

@SeanCassiereSeanCassiere changed the title feat: allow to disable scroll restoration for specific containersfeat(router-core): allow disabling scroll restoration for specific containersApr 28, 2025
@LadyBluenotes

Copy link
Copy Markdown
Member

This was fixed in bc811688fd.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentationEverything documentation relatedpackage: router-core

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@schiller-manuel@LadyBluenotes@SeanCassiere