Skip to content

fix: remove solid-js dependency from react-router-devtools - #4376

Merged
SeanCassiere merged 1 commit into
TanStack:mainfrom
jlucaso1:remove-unused-solid-dep
Jun 11, 2025
Merged

fix: remove solid-js dependency from react-router-devtools#4376
SeanCassiere merged 1 commit into
TanStack:mainfrom
jlucaso1:remove-unused-solid-dep

Conversation

@jlucaso1

@jlucaso1jlucaso1 commented Jun 11, 2025

Copy link
Copy Markdown
Contributor

We don't need to depend on solid-js to import JSX types in react-router-devtools package

@nx-cloud

nx-cloudBot commented Jun 11, 2025

Copy link
Copy Markdown
Contributor

View your CI Pipeline Execution ↗ for commit d9f7b1f.

CommandStatusDurationResult
nx affected --targets=test:eslint,test:unit,tes...✅ Succeeded2m 21sView ↗
nx run-many --target=build --exclude=examples/*...✅ Succeeded11sView ↗

☁️ Nx Cloud last updated this comment at 2025-06-11 22:33:40 UTC

@pkg-pr-new

Copy link
Copy Markdown
More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/arktype-adapter@4376

@tanstack/directive-functions-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/directive-functions-plugin@4376

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/eslint-plugin-router@4376

@tanstack/history

npm i https://pkg.pr.new/TanStack/router/@tanstack/history@4376

@tanstack/react-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router@4376

@tanstack/react-router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router-devtools@4376

@tanstack/react-router-with-query

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router-with-query@4376

@tanstack/react-start

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start@4376

@tanstack/react-start-client

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-client@4376

@tanstack/react-start-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-plugin@4376

@tanstack/react-start-server

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-server@4376

@tanstack/router-cli

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-cli@4376

@tanstack/router-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-core@4376

@tanstack/router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-devtools@4376

@tanstack/router-devtools-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-devtools-core@4376

@tanstack/router-generator

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-generator@4376

@tanstack/router-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-plugin@4376

@tanstack/router-utils

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-utils@4376

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-vite-plugin@4376

@tanstack/server-functions-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/server-functions-plugin@4376

@tanstack/solid-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router@4376

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router-devtools@4376

@tanstack/solid-start

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start@4376

@tanstack/solid-start-client

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-client@4376

@tanstack/solid-start-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-plugin@4376

@tanstack/solid-start-server

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-server@4376

@tanstack/start-client-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-client-core@4376

@tanstack/start-plugin-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-plugin-core@4376

@tanstack/start-server-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-server-core@4376

@tanstack/start-server-functions-client

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-server-functions-client@4376

@tanstack/start-server-functions-fetcher

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-server-functions-fetcher@4376

@tanstack/start-server-functions-server

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-server-functions-server@4376

@tanstack/valibot-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/valibot-adapter@4376

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/TanStack/router/@tanstack/virtual-file-routes@4376

@tanstack/zod-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/zod-adapter@4376

commit: d9f7b1f

@SeanCassiere
SeanCassiere merged commit b2fa955 into TanStack:mainJun 11, 2025
@luixo

Copy link
Copy Markdown

I'm not using solid js and got the same error with @tanstack/react-router-devtools being v1.121.5.
Seem like @tanstack/router-devtools-core is still dependant on solid-js package internally.

@brenelz

Copy link
Copy Markdown
Contributor

Do we need to revert this? @luixo

@jlucaso1

Copy link
Copy Markdown
ContributorAuthor

Maybe just move the solid-js dep to be an normal dependency instead an development?
https://github.com/TanStack/router/blob/main/packages/router-devtools-core/package.json

@Gregory-Gerard

Copy link
Copy Markdown

On a completely fresh project using Yarn, the project fails to start because solid-js isn’t installed. With NPM, which installs peer dependencies, this problem doesn’t occur.

✘ [ERROR] Could not resolve "solid-js"

Repro: https://stackblitz.com/edit/tanstack-router-ws9cx1ym

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@jlucaso1@luixo@brenelz@Gregory-Gerard@SeanCassiere