Uh oh!
There was an error while loading. Please reload this page.
fix: remove debug log - #4604
Merged
Merged
Conversation
Contributor
View your CI Pipeline Execution ↗ for commit e08e4a7
☁️ Nx Cloud last updated this comment at |
More templates
@tanstack/arktype-adapter@tanstack/directive-functions-plugin@tanstack/eslint-plugin-router@tanstack/history@tanstack/react-router@tanstack/react-router-devtools@tanstack/react-router-with-query@tanstack/react-start@tanstack/react-start-client@tanstack/react-start-plugin@tanstack/react-start-server@tanstack/router-cli@tanstack/router-core@tanstack/router-devtools@tanstack/router-devtools-core@tanstack/router-generator@tanstack/router-plugin@tanstack/router-utils@tanstack/router-vite-plugin@tanstack/server-functions-plugin@tanstack/solid-router@tanstack/solid-router-devtools@tanstack/solid-start@tanstack/solid-start-client@tanstack/solid-start-plugin@tanstack/solid-start-server@tanstack/start-client-core@tanstack/start-plugin-core@tanstack/start-server-core@tanstack/start-server-functions-client@tanstack/start-server-functions-fetcher@tanstack/start-server-functions-server@tanstack/valibot-adapter@tanstack/virtual-file-routes@tanstack/zod-adaptercommit: |
viclafouch
commented
Jul 11, 2025
I think it would be nice to have an option to enable/disable instead of removing it completly. |
ContributorAuthor
Actually after #4600 merge there is no logs at all. Should it be implemented to optionally enable them? @schiller-manuel |
schiller-manuel
commented
Jul 11, 2025
Collaborator
let's just remove the remaining stuff like you did |
kusiewicz
commented
Jul 11, 2025
ContributorAuthor
@schiller-manuel - after removing this code |
schiller-manuel
commented
Jul 11, 2025
Collaborator
@kusiewicz absolutely! |
kusiewicz
commented
Jul 11, 2025
ContributorAuthor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
several people asked about it on discord, sometimes it is annoying to wade through these logs
#4600 needed to be merged first