fix(solid-router): skip URL parsing for safe 'to' props by Sheraff · Pull Request #6453 · TanStack/router

Sheraff · 2026-01-22T12:36:41Z

Same as #6442 but for solid-router

Summary by CodeRabbit

Bug Fixes

Fixed handling of internal navigation links to correctly distinguish them from external links, ensuring reliable routing behavior for safe internal routes.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

nx-cloud · 2026-01-22T12:37:07Z

View your CI Pipeline Execution ↗ for commit 6b28d99

Command	Status	Duration	Result
`nx affected --targets=test:eslint,test:unit,tes...`	✅ Succeeded	9m 18s	View ↗
`nx run-many --target=build --exclude=examples/*...`	✅ Succeeded	1m 44s	View ↗

☁️ Nx Cloud last updated this comment at 2026-01-22 12:47:00 UTC

coderabbitai · 2026-01-22T12:37:09Z

📝 Walkthrough

Walkthrough

The change refines external link detection in solid-router's link handling by introducing an early exit for internal "safe" links (those starting with "/" but not "//"). URL parsing and protocol validation now operate on the refined to variable, preventing safe internal navigations from undergoing external link checks.

Changes

Cohort / File(s)	Summary
Link External Detection `packages/solid-router/src/link.tsx`	Added early return for internal links starting with "/" (excluding "//"). Adjusted URL construction and dangerous protocol checks to use local `to` variable. Updated warning message and return statement references from options object to `to` variable.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~35 minutes

Possibly related PRs

fix(router-core): skip URL parsing for safe 'to' props #6442 — Implements identical short-circuit logic for string "to" values starting with "/" to bypass external URL parsing and validation in link handling.
fix: compare rewritten url to decide if server needs to redirect #6072 — Modifies link handling in the same file, adjusting how href values are read and processed during link detection.

Suggested labels

package: solid-router

Suggested reviewers

schiller-manuel
nlynzaad

Poem

🐰 A path that starts with just one slash,
No need to parse—we skip the hash!
Internal routes now safe and true,
The router hops to routes anew! 🌿

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the main change: skipping URL parsing for safe 'to' props in solid-router, which aligns with the actual modifications in the link.tsx file.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

📝 Generate docstrings

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

pkg-pr-new · 2026-01-22T12:40:23Z

More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/arktype-adapter@6453

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/eslint-plugin-router@6453

@tanstack/history

npm i https://pkg.pr.new/TanStack/router/@tanstack/history@6453

@tanstack/nitro-v2-vite-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/nitro-v2-vite-plugin@6453

@tanstack/react-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router@6453

@tanstack/react-router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router-devtools@6453

@tanstack/react-router-ssr-query

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router-ssr-query@6453

@tanstack/react-start

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start@6453

@tanstack/react-start-client

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-client@6453

@tanstack/react-start-server

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-server@6453

@tanstack/router-cli

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-cli@6453

@tanstack/router-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-core@6453

@tanstack/router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-devtools@6453

@tanstack/router-devtools-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-devtools-core@6453

@tanstack/router-generator

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-generator@6453

@tanstack/router-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-plugin@6453

@tanstack/router-ssr-query-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-ssr-query-core@6453

@tanstack/router-utils

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-utils@6453

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-vite-plugin@6453

@tanstack/solid-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router@6453

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router-devtools@6453

@tanstack/solid-router-ssr-query

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router-ssr-query@6453

@tanstack/solid-start

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start@6453

@tanstack/solid-start-client

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-client@6453

@tanstack/solid-start-server

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-server@6453

@tanstack/start-client-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-client-core@6453

@tanstack/start-fn-stubs

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-fn-stubs@6453

@tanstack/start-plugin-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-plugin-core@6453

@tanstack/start-server-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-server-core@6453

@tanstack/start-static-server-functions

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-static-server-functions@6453

@tanstack/start-storage-context

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-storage-context@6453

@tanstack/valibot-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/valibot-adapter@6453

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/TanStack/router/@tanstack/virtual-file-routes@6453

@tanstack/vue-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/vue-router@6453

@tanstack/vue-router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/vue-router-devtools@6453

@tanstack/vue-router-ssr-query

npm i https://pkg.pr.new/TanStack/router/@tanstack/vue-router-ssr-query@6453

@tanstack/vue-start

npm i https://pkg.pr.new/TanStack/router/@tanstack/vue-start@6453

@tanstack/vue-start-client

npm i https://pkg.pr.new/TanStack/router/@tanstack/vue-start-client@6453

@tanstack/vue-start-server

npm i https://pkg.pr.new/TanStack/router/@tanstack/vue-start-server@6453

@tanstack/zod-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/zod-adapter@6453

commit: 6b28d99

fix(solid-router): skip URL parsing for safe 'to' props
6b28d99

github-actionsBot added the package: solid-router label Jan 22, 2026

birkskyum approved these changes Jan 22, 2026
View reviewed changes

Sheraff merged commit ef3486c into mainJan 22, 2026
6 checks passed

Sheraff deleted the refactor-solid-router-skip-url-parsing-for-safe-internal-to branch January 22, 2026 17:04

coderabbitaiBot mentioned this pull request Jan 28, 2026
feat(router-core, react-router, solid-router, vue-router): isDangerousProtocol uses customizable allowlist #6542
Merged

This was referenced Jul 26, 2026
feat(web): migrate frontend from Astro to TanStack Start (SolidJS) jackbisceglia/dotheyplaytoday#84
Closed
feat: getting started macro-inc/macro#5226
Merged

Navigation Menu

Uh oh!

Uh oh!

fix(solid-router): skip URL parsing for safe 'to' props - #6453

fix(solid-router): skip URL parsing for safe 'to' props#6453
Sheraff merged 1 commit into
mainfrom
refactor-solid-router-skip-url-parsing-for-safe-internal-to

Sheraff commented Jan 22, 2026•
edited by coderabbitai Bot
Loading

Uh oh!

nx-cloudBot commented Jan 22, 2026•
edited
Loading

Uh oh!

coderabbitaiBot commented Jan 22, 2026•
edited
Loading

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested labels

Suggested reviewers

Poem

Uh oh!

pkg-pr-newBot commented Jan 22, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Uh oh!

Conversation

Sheraff commented Jan 22, 2026• edited by coderabbitai BotLoading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Bug Fixes

Uh oh!

nx-cloudBot commented Jan 22, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitaiBot commented Jan 22, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested labels

Suggested reviewers

Poem

Uh oh!

pkg-pr-newBot commented Jan 22, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Sheraff commented Jan 22, 2026•
edited by coderabbitai Bot
Loading

nx-cloudBot commented Jan 22, 2026•
edited
Loading

coderabbitaiBot commented Jan 22, 2026•
edited
Loading