test(router-core): buildLocation unit tests by Sheraff · Pull Request #6507 · TanStack/router

Sheraff · 2026-01-25T15:28:24Z

Summary by CodeRabbit

Tests
- Added a comprehensive test suite covering route parameter parsing and delivery across single and multi-route branches, cross-route transitions, and mixed parse/no-parse scenarios.
- Validates search, hash, and state behaviors (preserve/merge/override), relative path resolution and basepath interactions, optional/splat parameter edge cases, and the full location output structure under complex navigation combinations.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

coderabbitai · 2026-01-25T15:28:46Z

📝 Walkthrough

Walkthrough

Adds a comprehensive test suite for RouterCore.buildLocation verifying param parsing/accumulation across route branches, propagation of parsed and raw params during navigations, search/hash/state handling, relative/basepath resolution, and various edge cases to validate the full location object structure.

Changes

Cohort / File(s)	Summary
RouterCore buildLocation test suite `packages/router-core/tests/build-location.test.ts`	New extensive test file (covers many scenarios) validating: param parse/accumulation across single and multi-route branches; prev param propagation across route transitions; mixed parse/no-parse behavior; search/hash/state handling (object/function/boolean/preserve/merge/clear); relative path and basepath resolution; optional/splat param edge cases; final location object fields and _fromLocation overrides.

Sequence Diagram(s)

(omitted — changes are test additions only)

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

#4981: Refactors buildLocation implementation and param merging behavior; directly related to the tested behaviors.
#6506: Alters buildLocation handling of param parsing/stringification and prev params, overlapping with these tests.
#5797: Introduces pendingBuiltLocation and changes buildLocation prioritization, impacting the same function this test suite targets.

Suggested reviewers

schiller-manuel
SeanCassiere

Poem

🐰
I hop through routes both near and far,
Parsing params beneath each star,
Search, hash, and state I gently bind,
Building locations, clear in mind,
Tests keep my trails neatly aligned!

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'test(router-core): buildLocation unit tests' clearly and accurately describes the changeset, which adds comprehensive unit tests for RouterCore.buildLocation.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

📝 Generate docstrings

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

nx-cloud · 2026-01-25T15:28:51Z

View your CI Pipeline Execution ↗ for commit 9363539

Command	Status	Duration	Result
`nx affected --targets=test:eslint,test:unit,tes...`	✅ Succeeded	1m 5s	View ↗
`nx run-many --target=build --exclude=examples/*...`	✅ Succeeded	1s	View ↗

☁️ Nx Cloud last updated this comment at 2026-01-25 16:36:50 UTC

pkg-pr-new · 2026-01-25T15:32:05Z

More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/arktype-adapter@6507

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/eslint-plugin-router@6507

@tanstack/history

npm i https://pkg.pr.new/TanStack/router/@tanstack/history@6507

@tanstack/nitro-v2-vite-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/nitro-v2-vite-plugin@6507

@tanstack/react-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router@6507

@tanstack/react-router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router-devtools@6507

@tanstack/react-router-ssr-query

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router-ssr-query@6507

@tanstack/react-start

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start@6507

@tanstack/react-start-client

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-client@6507

@tanstack/react-start-server

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-server@6507

@tanstack/router-cli

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-cli@6507

@tanstack/router-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-core@6507

@tanstack/router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-devtools@6507

@tanstack/router-devtools-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-devtools-core@6507

@tanstack/router-generator

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-generator@6507

@tanstack/router-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-plugin@6507

@tanstack/router-ssr-query-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-ssr-query-core@6507

@tanstack/router-utils

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-utils@6507

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-vite-plugin@6507

@tanstack/solid-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router@6507

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router-devtools@6507

@tanstack/solid-router-ssr-query

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router-ssr-query@6507

@tanstack/solid-start

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start@6507

@tanstack/solid-start-client

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-client@6507

@tanstack/solid-start-server

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-server@6507

@tanstack/start-client-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-client-core@6507

@tanstack/start-fn-stubs

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-fn-stubs@6507

@tanstack/start-plugin-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-plugin-core@6507

@tanstack/start-server-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-server-core@6507

@tanstack/start-static-server-functions

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-static-server-functions@6507

@tanstack/start-storage-context

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-storage-context@6507

@tanstack/valibot-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/valibot-adapter@6507

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/TanStack/router/@tanstack/virtual-file-routes@6507

@tanstack/vue-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/vue-router@6507

@tanstack/vue-router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/vue-router-devtools@6507

@tanstack/vue-router-ssr-query

npm i https://pkg.pr.new/TanStack/router/@tanstack/vue-router-ssr-query@6507

@tanstack/vue-start

npm i https://pkg.pr.new/TanStack/router/@tanstack/vue-start@6507

@tanstack/vue-start-client

npm i https://pkg.pr.new/TanStack/router/@tanstack/vue-start-client@6507

@tanstack/vue-start-server

npm i https://pkg.pr.new/TanStack/router/@tanstack/vue-start-server@6507

@tanstack/zod-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/zod-adapter@6507

commit: 9363539

test(router-core): buildLocation unit tests
fa5e6c0

github-actionsBot added the package: router-core label Jan 25, 2026

more tests
9363539

Sheraff merged commit e59c800 into mainJan 25, 2026
6 checks passed

Sheraff deleted the test-router-core-build-location branch January 25, 2026 16:54

coderabbitaiBot mentioned this pull request Jan 25, 2026
refactor(router-core): remove dead code in buildLocation left over from reverting match snapshots #6510
Merged

coderabbitaiBot mentioned this pull request Feb 14, 2026
fix(router-core): buildLocation should interpolatePath w/ stringified params for skipRouteOnParseError routes #6491
Closed

This was referenced Feb 18, 2026
Fix: include leading # in location hash #6693
Closed
refactor(router-core): remove unnecessary interpolatePath() in buildLocation #6721
Merged

Navigation Menu

Uh oh!

Uh oh!

test(router-core): buildLocation unit tests - #6507

test(router-core): buildLocation unit tests#6507
Sheraff merged 2 commits into
mainfrom
test-router-core-build-location

Sheraff commented Jan 25, 2026•
edited by coderabbitai Bot
Loading

Uh oh!

coderabbitaiBot commented Jan 25, 2026•
edited
Loading

Walkthrough

Changes

Sequence Diagram(s)

Estimated code review effort

Possibly related PRs

Suggested reviewers

Poem

Uh oh!

nx-cloudBot commented Jan 25, 2026•
edited
Loading

Uh oh!

pkg-pr-newBot commented Jan 25, 2026•
edited
Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Uh oh!

Conversation

Sheraff commented Jan 25, 2026• edited by coderabbitai BotLoading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitaiBot commented Jan 25, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Estimated code review effort

Possibly related PRs

Suggested reviewers

Poem

Uh oh!

nx-cloudBot commented Jan 25, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pkg-pr-newBot commented Jan 25, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Sheraff commented Jan 25, 2026•
edited by coderabbitai Bot
Loading

coderabbitaiBot commented Jan 25, 2026•
edited
Loading

nx-cloudBot commented Jan 25, 2026•
edited
Loading

pkg-pr-newBot commented Jan 25, 2026•
edited
Loading