fix(router-core): don't set isServer if NODE_ENV test by schiller-manuel · Pull Request #6727 · TanStack/router

schiller-manuel · 2026-02-21T21:40:58Z

Summary by CodeRabbit

Bug Fixes
- Server-side detection now correctly returns undefined in test environments instead of always returning a fixed value, improving test accuracy.

coderabbitai · 2026-02-21T21:41:20Z

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

The isServer export in packages/router-core/src/isServer/server.ts is modified from a constant boolean to a conditional value that evaluates to true in non-test environments and undefined when NODE_ENV is 'test', introducing environment-aware behavior.

Changes

Cohort / File(s)	Summary
Environment-aware isServer detection `packages/router-core/src/isServer/server.ts`	Changed isServer from a fixed boolean constant to a conditional expression that returns `true` or `undefined` based on NODE_ENV, enabling test-specific behavior.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

fix: avoid destructuring internal server property in interpolatePath #6580: Related change to server/isServer logic in packages/router-core that modifies how interpolatePath handles the server property.

Suggested reviewers

Sheraff

Poem

🐰 A little bunny hops with glee,
Testing truthfully, setting servers free!
When NODE_ENV says "test," undefined flows,
But truth remains where production goes. ✨

✨ Finishing Touches

📝 Generate docstrings (stacked PR)
📝 Generate docstrings (commit on current branch)

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch isServer-test-undefined

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

nx-cloud · 2026-02-21T21:41:28Z

View your CI Pipeline Execution ↗ for commit cc299f7

Command	Status	Duration	Result
`nx run tanstack-router-e2e-bundle-size:build --...`	✅ Succeeded	1m 25s	View ↗

☁️ Nx Cloud last updated this comment at 2026-02-21 21:58:21 UTC

github-actions · 2026-02-21T21:44:42Z

Bundle Size Benchmarks

Commit: a21eab71136a
Measured at: 2026-02-21T21:44:29.663Z
Baseline source: history:996e18284413
Dashboard: bundle-size history

Scenario	Current (gzip)	Delta vs baseline	Raw	Brotli	Trend
`react-router.minimal`	86.76 KiB	0 B (0.00%)	272.72 KiB	75.41 KiB	▅▅▅
`react-router.full`	89.85 KiB	0 B (0.00%)	283.19 KiB	78.06 KiB	▅▅▅
`solid-router.minimal`	36.04 KiB	0 B (0.00%)	107.87 KiB	32.43 KiB	▅▅▅
`solid-router.full`	40.39 KiB	0 B (0.00%)	120.96 KiB	36.25 KiB	▅▅▅
`vue-router.minimal`	51.90 KiB	0 B (0.00%)	147.86 KiB	46.62 KiB	▅▅▅
`vue-router.full`	56.76 KiB	0 B (0.00%)	163.47 KiB	50.98 KiB	▅▅▅
`react-start.minimal`	99.25 KiB	0 B (0.00%)	311.71 KiB	85.93 KiB	▅▅▅
`react-start.full`	102.66 KiB	0 B (0.00%)	321.63 KiB	88.71 KiB	▅▅▅
`solid-start.minimal`	48.28 KiB	0 B (0.00%)	145.30 KiB	42.70 KiB	▅▅▅
`solid-start.full`	53.76 KiB	0 B (0.00%)	161.25 KiB	47.34 KiB	▅▅▅

Trend sparkline is historical gzip bytes ending with this PR measurement; lower is better.

pkg-pr-new · 2026-02-21T21:46:02Z

More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/arktype-adapter@6727

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/eslint-plugin-router@6727

@tanstack/history

npm i https://pkg.pr.new/TanStack/router/@tanstack/history@6727

@tanstack/nitro-v2-vite-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/nitro-v2-vite-plugin@6727

@tanstack/react-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router@6727

@tanstack/react-router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router-devtools@6727

@tanstack/react-router-ssr-query

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router-ssr-query@6727

@tanstack/react-start

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start@6727

@tanstack/react-start-client

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-client@6727

@tanstack/react-start-server

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-server@6727

@tanstack/router-cli

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-cli@6727

@tanstack/router-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-core@6727

@tanstack/router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-devtools@6727

@tanstack/router-devtools-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-devtools-core@6727

@tanstack/router-generator

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-generator@6727

@tanstack/router-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-plugin@6727

@tanstack/router-ssr-query-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-ssr-query-core@6727

@tanstack/router-utils

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-utils@6727

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-vite-plugin@6727

@tanstack/solid-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router@6727

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router-devtools@6727

@tanstack/solid-router-ssr-query

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router-ssr-query@6727

@tanstack/solid-start

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start@6727

@tanstack/solid-start-client

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-client@6727

@tanstack/solid-start-server

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-server@6727

@tanstack/start-client-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-client-core@6727

@tanstack/start-fn-stubs

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-fn-stubs@6727

@tanstack/start-plugin-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-plugin-core@6727

@tanstack/start-server-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-server-core@6727

@tanstack/start-static-server-functions

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-static-server-functions@6727

@tanstack/start-storage-context

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-storage-context@6727

@tanstack/valibot-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/valibot-adapter@6727

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/TanStack/router/@tanstack/virtual-file-routes@6727

@tanstack/vue-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/vue-router@6727

@tanstack/vue-router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/vue-router-devtools@6727

@tanstack/vue-router-ssr-query

npm i https://pkg.pr.new/TanStack/router/@tanstack/vue-router-ssr-query@6727

@tanstack/vue-start

npm i https://pkg.pr.new/TanStack/router/@tanstack/vue-start@6727

@tanstack/vue-start-client

npm i https://pkg.pr.new/TanStack/router/@tanstack/vue-start-client@6727

@tanstack/vue-start-server

npm i https://pkg.pr.new/TanStack/router/@tanstack/vue-start-server@6727

@tanstack/zod-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/zod-adapter@6727

commit: cc299f7

fix(router-core): don't set isServer if NODE_ENV test
c727c73

github-actionsBot added the package: router-core label Feb 21, 2026

ci: apply automated fixes
cc299f7

schiller-manuel mentioned this pull request Feb 21, 2026
fix(router-core): don't set isServer if NODE_ENV test #6576
Closed

schiller-manuel merged commit fdb8d2e into mainFeb 21, 2026
7 of 8 checks passed

schiller-manuel deleted the isServer-test-undefined branch February 21, 2026 21:47

Navigation Menu

Uh oh!

Uh oh!

fix(router-core): don't set isServer if NODE_ENV test - #6727

fix(router-core): don't set isServer if NODE_ENV test#6727
schiller-manuel merged 2 commits into
mainfrom
isServer-test-undefined

schiller-manuel commented Feb 21, 2026•
edited by coderabbitai Bot
Loading

Uh oh!

coderabbitaiBot commented Feb 21, 2026•
edited
Loading

Review failed

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested reviewers

Poem

Uh oh!

nx-cloudBot commented Feb 21, 2026•
edited
Loading

Uh oh!

github-actionsBot commented Feb 21, 2026

Uh oh!

pkg-pr-newBot commented Feb 21, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Uh oh!

Conversation

schiller-manuel commented Feb 21, 2026• edited by coderabbitai BotLoading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitaiBot commented Feb 21, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review failed

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested reviewers

Poem

Uh oh!

nx-cloudBot commented Feb 21, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actionsBot commented Feb 21, 2026

Bundle Size Benchmarks

Uh oh!

pkg-pr-newBot commented Feb 21, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

schiller-manuel commented Feb 21, 2026•
edited by coderabbitai Bot
Loading

coderabbitaiBot commented Feb 21, 2026•
edited
Loading

nx-cloudBot commented Feb 21, 2026•
edited
Loading