Skip to content

ci: remove fork guard from bundle-size PR comment step - #6728

Merged
Sheraff merged 1 commit into
mainfrom
codex/6726-bundle-size-no-fork-guard
Feb 21, 2026
Merged

ci: remove fork guard from bundle-size PR comment step#6728
Sheraff merged 1 commit into
mainfrom
codex/6726-bundle-size-no-fork-guard

Conversation

@Sheraff

@SheraffSheraff commented Feb 21, 2026

Copy link
Copy Markdown
Collaborator

Removes the guard from the bundle-size workflow so PR comments run for forked PRs too.

Summary by CodeRabbit

  • Chores
    • Updated CI/CD workflow automation for improved consistency in pull request processing.

@coderabbitai

coderabbitaiBot commented Feb 21, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉


📝 Walkthrough

Walkthrough

A GitHub Actions workflow conditional was removed from the bundle-size workflow, allowing the Upsert Sticky PR Comment step to execute unconditionally instead of being guarded against fork pull requests.

Changes

Cohort / File(s)Summary
GitHub Actions Workflow
.github/workflows/bundle-size.yml
Removed conditional guard from Upsert Sticky PR Comment step, eliminating the fork-check gate that previously prevented execution on forked repositories.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A gate once guarded, now set free,
The sticky comment flows to thee,
Fork or main, no more the test—
Your workflow runs at its behest! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title accurately describes the main change: removing a fork guard from the bundle-size PR comment step, which matches the file modification in .github/workflows/bundle-size.yml.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch codex/6726-bundle-size-no-fork-guard

Comment @coderabbitai help to get the list of available commands and usage tips.

@nx-cloud

nx-cloudBot commented Feb 21, 2026

Copy link
Copy Markdown
Contributor

View your CI Pipeline Execution ↗ for commit 46d2a4d

CommandStatusDurationResult
nx run tanstack-router-e2e-bundle-size:build --...✅ Succeeded1m 25sView ↗

☁️ Nx Cloud last updated this comment at 2026-02-21 21:48:04 UTC

@pkg-pr-new

Copy link
Copy Markdown
More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/arktype-adapter@6728

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/eslint-plugin-router@6728

@tanstack/history

npm i https://pkg.pr.new/TanStack/router/@tanstack/history@6728

@tanstack/nitro-v2-vite-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/nitro-v2-vite-plugin@6728

@tanstack/react-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router@6728

@tanstack/react-router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router-devtools@6728

@tanstack/react-router-ssr-query

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router-ssr-query@6728

@tanstack/react-start

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start@6728

@tanstack/react-start-client

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-client@6728

@tanstack/react-start-server

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-server@6728

@tanstack/router-cli

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-cli@6728

@tanstack/router-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-core@6728

@tanstack/router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-devtools@6728

@tanstack/router-devtools-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-devtools-core@6728

@tanstack/router-generator

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-generator@6728

@tanstack/router-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-plugin@6728

@tanstack/router-ssr-query-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-ssr-query-core@6728

@tanstack/router-utils

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-utils@6728

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-vite-plugin@6728

@tanstack/solid-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router@6728

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router-devtools@6728

@tanstack/solid-router-ssr-query

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router-ssr-query@6728

@tanstack/solid-start

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start@6728

@tanstack/solid-start-client

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-client@6728

@tanstack/solid-start-server

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-server@6728

@tanstack/start-client-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-client-core@6728

@tanstack/start-fn-stubs

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-fn-stubs@6728

@tanstack/start-plugin-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-plugin-core@6728

@tanstack/start-server-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-server-core@6728

@tanstack/start-static-server-functions

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-static-server-functions@6728

@tanstack/start-storage-context

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-storage-context@6728

@tanstack/valibot-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/valibot-adapter@6728

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/TanStack/router/@tanstack/virtual-file-routes@6728

@tanstack/vue-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/vue-router@6728

@tanstack/vue-router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/vue-router-devtools@6728

@tanstack/vue-router-ssr-query

npm i https://pkg.pr.new/TanStack/router/@tanstack/vue-router-ssr-query@6728

@tanstack/vue-start

npm i https://pkg.pr.new/TanStack/router/@tanstack/vue-start@6728

@tanstack/vue-start-client

npm i https://pkg.pr.new/TanStack/router/@tanstack/vue-start-client@6728

@tanstack/vue-start-server

npm i https://pkg.pr.new/TanStack/router/@tanstack/vue-start-server@6728

@tanstack/zod-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/zod-adapter@6728

commit: 46d2a4d

@github-actions

Copy link
Copy Markdown
Contributor

Bundle Size Benchmarks

  • Commit: 334aa070ce01
  • Measured at: 2026-02-21T21:47:10.408Z
  • Baseline source: history:996e18284413
  • Dashboard: bundle-size history
ScenarioCurrent (gzip)Delta vs baselineRawBrotliTrend
react-router.minimal86.76 KiB0 B (0.00%)272.72 KiB75.41 KiB▅▅▅
react-router.full89.85 KiB0 B (0.00%)283.19 KiB78.06 KiB▅▅▅
solid-router.minimal36.04 KiB0 B (0.00%)107.87 KiB32.43 KiB▅▅▅
solid-router.full40.39 KiB0 B (0.00%)120.96 KiB36.25 KiB▅▅▅
vue-router.minimal51.90 KiB0 B (0.00%)147.86 KiB46.62 KiB▅▅▅
vue-router.full56.76 KiB0 B (0.00%)163.47 KiB50.98 KiB▅▅▅
react-start.minimal99.25 KiB0 B (0.00%)311.71 KiB85.93 KiB▅▅▅
react-start.full102.66 KiB0 B (0.00%)321.63 KiB88.71 KiB▅▅▅
solid-start.minimal48.28 KiB0 B (0.00%)145.30 KiB42.70 KiB▅▅▅
solid-start.full53.76 KiB0 B (0.00%)161.25 KiB47.34 KiB▅▅▅

Trend sparkline is historical gzip bytes ending with this PR measurement; lower is better.

@Sheraff
Sheraff merged commit 41528ea into mainFeb 21, 2026
8 checks passed
@Sheraff
Sheraff deleted the codex/6726-bundle-size-no-fork-guard branch February 21, 2026 21:56
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@Sheraff