Uh oh!
There was an error while loading. Please reload this page.
chore: cleanup unused exports - #6735
Conversation
📝 WalkthroughWalkthroughThis PR removes several public API exports across the TanStack Router packages, including TSR_DEFERRED_PROMISE, defaultSerializeError, matchContext, useLayoutEffect utilities, and various helpers like componentTypes and headersInitToObject. The public API surface is narrowed across react-router, solid-router, vue-router, and router-core packages, along with cleanup in e2e bundle-size test scenarios. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Comment |
View your CI Pipeline Execution ↗ for commit 02dda60
☁️ Nx Cloud last updated this comment at |
Bundle Size Benchmarks
Trend sparkline is historical gzip bytes ending with this PR measurement; lower is better. |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
packages/router-core/src/index.ts (1)
448-448: Public API trim — please ensure release notes/migration mention executeRewriteOutput removal.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@packages/router-core/src/index.ts` at line 448, The public export currently re-exports composeRewrites and executeRewriteInput but the review notes that executeRewriteOutput was removed from the public API; update the package's public API surface to reflect this change by removing any remaining re-exports or references to executeRewriteOutput (check files/exports referencing executeRewriteOutput and the export statement that includes composeRewrites/executeRewriteInput), and add a brief migration note in the release notes explaining that executeRewriteOutput was removed and how consumers should migrate (e.g., use executeRewriteInput or composeRewrites instead).
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@packages/router-core/src/index.ts`:
- Line 448: The public export currently re-exports composeRewrites and
executeRewriteInput but the review notes that executeRewriteOutput was removed
from the public API; update the package's public API surface to reflect this
change by removing any remaining re-exports or references to
executeRewriteOutput (check files/exports referencing executeRewriteOutput and
the export statement that includes composeRewrites/executeRewriteInput), and add
a brief migration note in the release notes explaining that executeRewriteOutput
was removed and how consumers should migrate (e.g., use executeRewriteInput or
composeRewrites instead).
Uh oh!
There was an error while loading. Please reload this page.
Summary by CodeRabbit
Release Notes