feat: throwOnError for preloadRoute - #7031

Draft
schiller-manuel wants to merge 1 commit into
mainfrom
feat-throwOnError
Draft

feat: throwOnError for preloadRoute#7031
schiller-manuel wants to merge 1 commit into
mainfrom
feat-throwOnError

Conversation

@schiller-manuel

@schiller-manuelschiller-manuel commented Mar 24, 2026•
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Collaborator

prompted by #7002

Summary by CodeRabbit

  • New Features

    • Added optional throwOnError flag to control preload route error handling. When enabled, errors encountered during preload are thrown immediately. When disabled, errors continue to be logged and handled gracefully as before.

  • Tests

    • Added comprehensive test coverage validating preload error behavior with standard errors, notFound results, and redirect outcomes using the new flag.

@coderabbitai

coderabbitaiBot commented Mar 24, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor
📝 Walkthrough

Walkthrough

This pull request adds a new optional throwOnError flag to control error propagation during route preloading. When enabled, errors encountered in beforeLoad hooks and loaders are thrown directly instead of being captured silently. The flag is threaded through the route loading pipeline and integrated with corresponding test coverage.

Changes

Cohort / File(s)Summary
Route Loading Error Handling
packages/router-core/src/load-matches.ts, packages/router-core/src/router.ts		Added throwOnError?: boolean flag to control whether errors during preload are thrown vs captured. Updated loadMatches to conditionally throw errors and modified PreloadRouteFn to pass the flag through the loading pipeline with updated catch logic in preloadRoute.
Test Coverage
packages/router-core/tests/load.test.ts		Added comprehensive test cases for throwOnError behavior, covering regular errors, notFound() results, and redirects in both beforeLoad and loader hooks during preload execution.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Poem

🐰 A flag for the future, throwOnError hops in,
No silent swallowing—let errors spin!
Preload rejects with truth, not hidden sorrow,
The router learns to fail—and fail better tomorrow. 🌟

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check nameStatusExplanation
Title check✅ PassedThe title directly and concisely describes the main feature being added: a throwOnError option for the preloadRoute functionality.
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat-throwOnError

Comment @coderabbitai help to get the list of available commands and usage tips.

@nx-cloud

nx-cloudBot commented Mar 24, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

🤖 Nx Cloud AI Fix Eligible

An automatically generated fix could have helped fix failing tasks for this run, but Self-healing CI is disabled for this workspace. Visit workspace settings to enable it and get automatic fixes in future runs.

To disable these notifications, a workspace admin can disable them in workspace settings.

View your CI Pipeline Execution ↗ for commit baa1c16

CommandStatusDurationResult
nx affected --targets=test:eslint,test:unit,tes...❌ Failed9m 46sView ↗
nx run-many --target=build --exclude=examples/*...✅ Succeeded1m 44sView ↗

☁️ Nx Cloud last updated this comment at 2026-03-24 23:36:19 UTC

@github-actions

github-actionsBot commented Mar 24, 2026

Copy link
Copy Markdown
Contributor

🚀 Changeset Version Preview

No changeset entries found. Merging this PR will not cause a version bump for any packages.

@schiller-manuel
schiller-manuel marked this pull request as draft March 24, 2026 23:26
@github-actions

github-actionsBot commented Mar 24, 2026

Copy link
Copy Markdown
Contributor

Bundle Size Benchmarks

  • Commit: 77ad7925d4a6
  • Measured at: 2026-03-24T23:27:27.667Z
  • Baseline source: history:ed9c43df7ab8
  • Dashboard: bundle-size history
ScenarioCurrent (gzip)Delta vs baselineRawBrotliTrend
react-router.minimal88.10 KiB+55 B (+0.06%)277.82 KiB76.47 KiB████▃▃▃▃▃▁▁▂
react-router.full91.33 KiB+57 B (+0.06%)288.81 KiB79.21 KiB████▂▂▃▃▃▁▁▂
solid-router.minimal35.73 KiB+61 B (+0.17%)107.84 KiB32.09 KiB████▃▃▃▃▃▁▁▂
solid-router.full40.13 KiB+55 B (+0.13%)121.23 KiB35.94 KiB████▂▂▃▃▃▁▁▂
vue-router.minimal53.84 KiB+65 B (+0.12%)154.75 KiB48.27 KiB████▁▁▁▁▁▁▁▂
vue-router.full58.71 KiB+67 B (+0.11%)170.23 KiB52.49 KiB████▁▁▃▃▃▃▃▄
react-start.minimal102.45 KiB+49 B (+0.05%)325.84 KiB88.52 KiB████▁▁▃▃▃▁▁▂
react-start.full105.88 KiB+53 B (+0.05%)336.15 KiB91.41 KiB████▁▁▃▃▃▁▁▂
solid-start.minimal49.80 KiB+62 B (+0.12%)154.02 KiB43.87 KiB████▃▃▃▃▃▁▁▂
solid-start.full55.28 KiB+63 B (+0.11%)170.12 KiB48.53 KiB████▂▂▃▃▃▁▁▂

Trend sparkline is historical gzip bytes ending with this PR measurement; lower is better.

@pkg-pr-new

pkg-pr-newBot commented Mar 24, 2026

Copy link
Copy Markdown
More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/@tanstack/arktype-adapter@7031

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@7031

@tanstack/history

npm i https://pkg.pr.new/@tanstack/history@7031

@tanstack/nitro-v2-vite-plugin

npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@7031

@tanstack/react-router

npm i https://pkg.pr.new/@tanstack/react-router@7031

@tanstack/react-router-devtools

npm i https://pkg.pr.new/@tanstack/react-router-devtools@7031

@tanstack/react-router-ssr-query

npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@7031

@tanstack/react-start

npm i https://pkg.pr.new/@tanstack/react-start@7031

@tanstack/react-start-client

npm i https://pkg.pr.new/@tanstack/react-start-client@7031

@tanstack/react-start-server

npm i https://pkg.pr.new/@tanstack/react-start-server@7031

@tanstack/router-cli

npm i https://pkg.pr.new/@tanstack/router-cli@7031

@tanstack/router-core

npm i https://pkg.pr.new/@tanstack/router-core@7031

@tanstack/router-devtools

npm i https://pkg.pr.new/@tanstack/router-devtools@7031

@tanstack/router-devtools-core

npm i https://pkg.pr.new/@tanstack/router-devtools-core@7031

@tanstack/router-generator

npm i https://pkg.pr.new/@tanstack/router-generator@7031

@tanstack/router-plugin

npm i https://pkg.pr.new/@tanstack/router-plugin@7031

@tanstack/router-ssr-query-core

npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@7031

@tanstack/router-utils

npm i https://pkg.pr.new/@tanstack/router-utils@7031

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/@tanstack/router-vite-plugin@7031

@tanstack/solid-router

npm i https://pkg.pr.new/@tanstack/solid-router@7031

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/@tanstack/solid-router-devtools@7031

@tanstack/solid-router-ssr-query

npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@7031

@tanstack/solid-start

npm i https://pkg.pr.new/@tanstack/solid-start@7031

@tanstack/solid-start-client

npm i https://pkg.pr.new/@tanstack/solid-start-client@7031

@tanstack/solid-start-server

npm i https://pkg.pr.new/@tanstack/solid-start-server@7031

@tanstack/start-client-core

npm i https://pkg.pr.new/@tanstack/start-client-core@7031

@tanstack/start-fn-stubs

npm i https://pkg.pr.new/@tanstack/start-fn-stubs@7031

@tanstack/start-plugin-core

npm i https://pkg.pr.new/@tanstack/start-plugin-core@7031

@tanstack/start-server-core

npm i https://pkg.pr.new/@tanstack/start-server-core@7031

@tanstack/start-static-server-functions

npm i https://pkg.pr.new/@tanstack/start-static-server-functions@7031

@tanstack/start-storage-context

npm i https://pkg.pr.new/@tanstack/start-storage-context@7031

@tanstack/valibot-adapter

npm i https://pkg.pr.new/@tanstack/valibot-adapter@7031

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/@tanstack/virtual-file-routes@7031

@tanstack/vue-router

npm i https://pkg.pr.new/@tanstack/vue-router@7031

@tanstack/vue-router-devtools

npm i https://pkg.pr.new/@tanstack/vue-router-devtools@7031

@tanstack/vue-router-ssr-query

npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@7031

@tanstack/vue-start

npm i https://pkg.pr.new/@tanstack/vue-start@7031

@tanstack/vue-start-client

npm i https://pkg.pr.new/@tanstack/vue-start-client@7031

@tanstack/vue-start-server

npm i https://pkg.pr.new/@tanstack/vue-start-server@7031

@tanstack/zod-adapter

npm i https://pkg.pr.new/@tanstack/zod-adapter@7031

commit: baa1c16

@codspeed-hq

codspeed-hqBot commented Mar 24, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 6 untouched benchmarks

Comparing feat-throwOnError (baa1c16) with main (ed9c43d)1

Open in CodSpeed

Footnotes

  1. No successful run was found on main (77ad792) during the generation of this report, so ed9c43d was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

@Nandan1996

Nandan1996 commented Mar 28, 2026

Copy link
Copy Markdown

Hi @schiller-manuel
should have added this comment on PR itself. can you take a look at this comment. when loaders run in async mode, the error might get swallowed as well.

#7002 (reply in thread)

@schiller-manuel

schiller-manuel commented Mar 28, 2026

Copy link
Copy Markdown
CollaboratorAuthor

probably needs another optional param to force sync preloading

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SheraffSheraffAwaiting requested review from Sheraff

Assignees

No one assigned

Labels

package: router-core

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@schiller-manuel@Nandan1996
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
feat: throwOnError for preloadRoute - #7031
Draft
schiller-manuel wants to merge 1 commit into
mainfrom 
feat-throwOnError
Draft
feat: throwOnError for preloadRoute#7031
schiller-manuel wants to merge 1 commit into
mainfrom 
feat-throwOnError
Conversation
@schiller-manuel
@schiller-manuelschiller-manuel
commented
Mar 24, 2026•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Collaborator
prompted by #7002
Summary by CodeRabbit
  • New Features
    • Added optional throwOnError flag to control preload route error handling. When enabled, errors encountered during preload are thrown immediately. When disabled, errors continue to be logged and handled gracefully as before.
  • Tests
    • Added comprehensive test coverage validating preload error behavior with standard errors, notFound results, and redirect outcomes using the new flag.
@coderabbitai
coderabbitaiBot
commented
Mar 24, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
📝 Walkthrough
Walkthrough
This pull request adds a new optional throwOnError flag to control error propagation during route preloading. When enabled, errors encountered in beforeLoad hooks and loaders are thrown directly instead of being captured silently. The flag is threaded through the route loading pipeline and integrated with corresponding test coverage.
Changes
Cohort / File(s)Summary
Route Loading Error Handling
packages/router-core/src/load-matches.ts, packages/router-core/src/router.ts		Added throwOnError?: boolean flag to control whether errors during preload are thrown vs captured. Updated loadMatches to conditionally throw errors and modified PreloadRouteFn to pass the flag through the loading pipeline with updated catch logic in preloadRoute.
Test Coverage
packages/router-core/tests/load.test.ts		Added comprehensive test cases for throwOnError behavior, covering regular errors, notFound() results, and redirects in both beforeLoad and loader hooks during preload execution.
Estimated code review effort
🎯 3 (Moderate) | ⏱️ ~25 minutes
Poem
🐰 A flag for the future, throwOnError hops in,

No silent swallowing—let errors spin!

Preload rejects with truth, not hidden sorrow,

The router learns to fail—and fail better tomorrow. 🌟
🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check nameStatusExplanation
Title check✅ PassedThe title directly and concisely describes the main feature being added: a throwOnError option for the preloadRoute functionality.
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
✨ Finishing Touches
📝 Generate docstrings
  •  Create stacked PR
  •  Commit on current branch
🧪 Generate unit tests (beta)
  •  Create PR with unit tests
  •  Commit unit tests in branch feat-throwOnError
Comment @coderabbitai help to get the list of available commands and usage tips.
@nx-cloud
nx-cloudBot
commented
Mar 24, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
 🤖 Nx Cloud AI Fix Eligible
An automatically generated fix could have helped fix failing tasks for this run, but Self-healing CI is disabled for this workspace. Visit workspace settings to enable it and get automatic fixes in future runs.
To disable these notifications, a workspace admin can disable them in workspace settings.
View your CI Pipeline Execution ↗ for commit baa1c16
CommandStatusDurationResult
nx affected --targets=test:eslint,test:unit,tes...❌ Failed9m 46sView ↗
nx run-many --target=build --exclude=examples/*...✅ Succeeded1m 44sView ↗
☁️ Nx Cloud last updated this comment at 2026-03-24 23:36:19 UTC
@github-actions
github-actionsBot
commented
Mar 24, 2026

Copy link


Copy Markdown

Contributor
🚀 Changeset Version Preview
No changeset entries found. Merging this PR will not cause a version bump for any packages.
@schiller-manuel
schiller-manuel
marked this pull request as draft
March 24, 2026 23:26
@github-actions
github-actionsBot
commented
Mar 24, 2026

Copy link


Copy Markdown

Contributor
Bundle Size Benchmarks
  • Commit: 77ad7925d4a6
  • Measured at: 2026-03-24T23:27:27.667Z
  • Baseline source: history:ed9c43df7ab8
  • Dashboard: bundle-size history
ScenarioCurrent (gzip)Delta vs baselineRawBrotliTrend
react-router.minimal88.10 KiB+55 B (+0.06%)277.82 KiB76.47 KiB████▃▃▃▃▃▁▁▂
react-router.full91.33 KiB+57 B (+0.06%)288.81 KiB79.21 KiB████▂▂▃▃▃▁▁▂
solid-router.minimal35.73 KiB+61 B (+0.17%)107.84 KiB32.09 KiB████▃▃▃▃▃▁▁▂
solid-router.full40.13 KiB+55 B (+0.13%)121.23 KiB35.94 KiB████▂▂▃▃▃▁▁▂
vue-router.minimal53.84 KiB+65 B (+0.12%)154.75 KiB48.27 KiB████▁▁▁▁▁▁▁▂
vue-router.full58.71 KiB+67 B (+0.11%)170.23 KiB52.49 KiB████▁▁▃▃▃▃▃▄
react-start.minimal102.45 KiB+49 B (+0.05%)325.84 KiB88.52 KiB████▁▁▃▃▃▁▁▂
react-start.full105.88 KiB+53 B (+0.05%)336.15 KiB91.41 KiB████▁▁▃▃▃▁▁▂
solid-start.minimal49.80 KiB+62 B (+0.12%)154.02 KiB43.87 KiB████▃▃▃▃▃▁▁▂
solid-start.full55.28 KiB+63 B (+0.11%)170.12 KiB48.53 KiB████▂▂▃▃▃▁▁▂
Trend sparkline is historical gzip bytes ending with this PR measurement; lower is better.
@pkg-pr-new
pkg-pr-newBot
commented
Mar 24, 2026

Copy link


Copy Markdown

More templates
@tanstack/arktype-adapter
npm i https://pkg.pr.new/@tanstack/arktype-adapter@7031

@tanstack/eslint-plugin-router
npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@7031

@tanstack/history
npm i https://pkg.pr.new/@tanstack/history@7031

@tanstack/nitro-v2-vite-plugin
npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@7031

@tanstack/react-router
npm i https://pkg.pr.new/@tanstack/react-router@7031

@tanstack/react-router-devtools
npm i https://pkg.pr.new/@tanstack/react-router-devtools@7031

@tanstack/react-router-ssr-query
npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@7031

@tanstack/react-start
npm i https://pkg.pr.new/@tanstack/react-start@7031

@tanstack/react-start-client
npm i https://pkg.pr.new/@tanstack/react-start-client@7031

@tanstack/react-start-server
npm i https://pkg.pr.new/@tanstack/react-start-server@7031

@tanstack/router-cli
npm i https://pkg.pr.new/@tanstack/router-cli@7031

@tanstack/router-core
npm i https://pkg.pr.new/@tanstack/router-core@7031

@tanstack/router-devtools
npm i https://pkg.pr.new/@tanstack/router-devtools@7031

@tanstack/router-devtools-core
npm i https://pkg.pr.new/@tanstack/router-devtools-core@7031

@tanstack/router-generator
npm i https://pkg.pr.new/@tanstack/router-generator@7031

@tanstack/router-plugin
npm i https://pkg.pr.new/@tanstack/router-plugin@7031

@tanstack/router-ssr-query-core
npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@7031

@tanstack/router-utils
npm i https://pkg.pr.new/@tanstack/router-utils@7031

@tanstack/router-vite-plugin
npm i https://pkg.pr.new/@tanstack/router-vite-plugin@7031

@tanstack/solid-router
npm i https://pkg.pr.new/@tanstack/solid-router@7031

@tanstack/solid-router-devtools
npm i https://pkg.pr.new/@tanstack/solid-router-devtools@7031

@tanstack/solid-router-ssr-query
npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@7031

@tanstack/solid-start
npm i https://pkg.pr.new/@tanstack/solid-start@7031

@tanstack/solid-start-client
npm i https://pkg.pr.new/@tanstack/solid-start-client@7031

@tanstack/solid-start-server
npm i https://pkg.pr.new/@tanstack/solid-start-server@7031

@tanstack/start-client-core
npm i https://pkg.pr.new/@tanstack/start-client-core@7031

@tanstack/start-fn-stubs
npm i https://pkg.pr.new/@tanstack/start-fn-stubs@7031

@tanstack/start-plugin-core
npm i https://pkg.pr.new/@tanstack/start-plugin-core@7031

@tanstack/start-server-core
npm i https://pkg.pr.new/@tanstack/start-server-core@7031

@tanstack/start-static-server-functions
npm i https://pkg.pr.new/@tanstack/start-static-server-functions@7031

@tanstack/start-storage-context
npm i https://pkg.pr.new/@tanstack/start-storage-context@7031

@tanstack/valibot-adapter
npm i https://pkg.pr.new/@tanstack/valibot-adapter@7031

@tanstack/virtual-file-routes
npm i https://pkg.pr.new/@tanstack/virtual-file-routes@7031

@tanstack/vue-router
npm i https://pkg.pr.new/@tanstack/vue-router@7031

@tanstack/vue-router-devtools
npm i https://pkg.pr.new/@tanstack/vue-router-devtools@7031

@tanstack/vue-router-ssr-query
npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@7031

@tanstack/vue-start
npm i https://pkg.pr.new/@tanstack/vue-start@7031

@tanstack/vue-start-client
npm i https://pkg.pr.new/@tanstack/vue-start-client@7031

@tanstack/vue-start-server
npm i https://pkg.pr.new/@tanstack/vue-start-server@7031

@tanstack/zod-adapter
npm i https://pkg.pr.new/@tanstack/zod-adapter@7031

commit: baa1c16
@codspeed-hq
codspeed-hqBot
commented
Mar 24, 2026

Copy link


Copy Markdown

Merging this PR will not alter performance
✅ 6 untouched benchmarks
Comparing feat-throwOnError (baa1c16) with main (ed9c43d)1
Open in CodSpeed
Footnotes
  1. No successful run was found on main (77ad792) during the generation of this report, so ed9c43d was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩
@Nandan1996
Nandan1996
commented
Mar 28, 2026

Copy link


Copy Markdown

Hi @schiller-manuel

should have added this comment on PR itself. can you take a look at this comment. when loaders run in async mode, the error might get swallowed as well.
#7002 (reply in thread)
@schiller-manuel
schiller-manuel
commented
Mar 28, 2026

Copy link


Copy Markdown

CollaboratorAuthor
probably needs another optional param to force sync preloading
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@SheraffSheraffAwaiting requested review from Sheraff

Assignees


No one assigned


Labels

package: router-core

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@schiller-manuel@Nandan1996

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
feat: throwOnError for preloadRoute - #7031
Draft
schiller-manuel wants to merge 1 commit into
mainfrom 
feat-throwOnError
Draft
feat: throwOnError for preloadRoute#7031
schiller-manuel wants to merge 1 commit into
mainfrom 
feat-throwOnError
Conversation
@schiller-manuel
@schiller-manuelschiller-manuel
commented
Mar 24, 2026•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Collaborator
prompted by #7002
Summary by CodeRabbit
  • New Features
    • Added optional throwOnError flag to control preload route error handling. When enabled, errors encountered during preload are thrown immediately. When disabled, errors continue to be logged and handled gracefully as before.
  • Tests
    • Added comprehensive test coverage validating preload error behavior with standard errors, notFound results, and redirect outcomes using the new flag.
@coderabbitai
coderabbitaiBot
commented
Mar 24, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
📝 Walkthrough
Walkthrough
This pull request adds a new optional throwOnError flag to control error propagation during route preloading. When enabled, errors encountered in beforeLoad hooks and loaders are thrown directly instead of being captured silently. The flag is threaded through the route loading pipeline and integrated with corresponding test coverage.
Changes
Cohort / File(s)Summary
Route Loading Error Handling
packages/router-core/src/load-matches.ts, packages/router-core/src/router.ts		Added throwOnError?: boolean flag to control whether errors during preload are thrown vs captured. Updated loadMatches to conditionally throw errors and modified PreloadRouteFn to pass the flag through the loading pipeline with updated catch logic in preloadRoute.
Test Coverage
packages/router-core/tests/load.test.ts		Added comprehensive test cases for throwOnError behavior, covering regular errors, notFound() results, and redirects in both beforeLoad and loader hooks during preload execution.
Estimated code review effort
🎯 3 (Moderate) | ⏱️ ~25 minutes
Poem
🐰 A flag for the future, throwOnError hops in,

No silent swallowing—let errors spin!

Preload rejects with truth, not hidden sorrow,

The router learns to fail—and fail better tomorrow. 🌟
🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check nameStatusExplanation
Title check✅ PassedThe title directly and concisely describes the main feature being added: a throwOnError option for the preloadRoute functionality.
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
✨ Finishing Touches
📝 Generate docstrings
  •  Create stacked PR
  •  Commit on current branch
🧪 Generate unit tests (beta)
  •  Create PR with unit tests
  •  Commit unit tests in branch feat-throwOnError
Comment @coderabbitai help to get the list of available commands and usage tips.
@nx-cloud
nx-cloudBot
commented
Mar 24, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
 🤖 Nx Cloud AI Fix Eligible
An automatically generated fix could have helped fix failing tasks for this run, but Self-healing CI is disabled for this workspace. Visit workspace settings to enable it and get automatic fixes in future runs.
To disable these notifications, a workspace admin can disable them in workspace settings.
View your CI Pipeline Execution ↗ for commit baa1c16
CommandStatusDurationResult
nx affected --targets=test:eslint,test:unit,tes...❌ Failed9m 46sView ↗
nx run-many --target=build --exclude=examples/*...✅ Succeeded1m 44sView ↗
☁️ Nx Cloud last updated this comment at 2026-03-24 23:36:19 UTC
@github-actions
github-actionsBot
commented
Mar 24, 2026

Copy link


Copy Markdown

Contributor
🚀 Changeset Version Preview
No changeset entries found. Merging this PR will not cause a version bump for any packages.
@schiller-manuel
schiller-manuel
marked this pull request as draft
March 24, 2026 23:26
@github-actions
github-actionsBot
commented
Mar 24, 2026

Copy link


Copy Markdown

Contributor
Bundle Size Benchmarks
  • Commit: 77ad7925d4a6
  • Measured at: 2026-03-24T23:27:27.667Z
  • Baseline source: history:ed9c43df7ab8
  • Dashboard: bundle-size history
ScenarioCurrent (gzip)Delta vs baselineRawBrotliTrend
react-router.minimal88.10 KiB+55 B (+0.06%)277.82 KiB76.47 KiB████▃▃▃▃▃▁▁▂
react-router.full91.33 KiB+57 B (+0.06%)288.81 KiB79.21 KiB████▂▂▃▃▃▁▁▂
solid-router.minimal35.73 KiB+61 B (+0.17%)107.84 KiB32.09 KiB████▃▃▃▃▃▁▁▂
solid-router.full40.13 KiB+55 B (+0.13%)121.23 KiB35.94 KiB████▂▂▃▃▃▁▁▂
vue-router.minimal53.84 KiB+65 B (+0.12%)154.75 KiB48.27 KiB████▁▁▁▁▁▁▁▂
vue-router.full58.71 KiB+67 B (+0.11%)170.23 KiB52.49 KiB████▁▁▃▃▃▃▃▄
react-start.minimal102.45 KiB+49 B (+0.05%)325.84 KiB88.52 KiB████▁▁▃▃▃▁▁▂
react-start.full105.88 KiB+53 B (+0.05%)336.15 KiB91.41 KiB████▁▁▃▃▃▁▁▂
solid-start.minimal49.80 KiB+62 B (+0.12%)154.02 KiB43.87 KiB████▃▃▃▃▃▁▁▂
solid-start.full55.28 KiB+63 B (+0.11%)170.12 KiB48.53 KiB████▂▂▃▃▃▁▁▂
Trend sparkline is historical gzip bytes ending with this PR measurement; lower is better.
@pkg-pr-new
pkg-pr-newBot
commented
Mar 24, 2026

Copy link


Copy Markdown

More templates
@tanstack/arktype-adapter
npm i https://pkg.pr.new/@tanstack/arktype-adapter@7031

@tanstack/eslint-plugin-router
npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@7031

@tanstack/history
npm i https://pkg.pr.new/@tanstack/history@7031

@tanstack/nitro-v2-vite-plugin
npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@7031

@tanstack/react-router
npm i https://pkg.pr.new/@tanstack/react-router@7031

@tanstack/react-router-devtools
npm i https://pkg.pr.new/@tanstack/react-router-devtools@7031

@tanstack/react-router-ssr-query
npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@7031

@tanstack/react-start
npm i https://pkg.pr.new/@tanstack/react-start@7031

@tanstack/react-start-client
npm i https://pkg.pr.new/@tanstack/react-start-client@7031

@tanstack/react-start-server
npm i https://pkg.pr.new/@tanstack/react-start-server@7031

@tanstack/router-cli
npm i https://pkg.pr.new/@tanstack/router-cli@7031

@tanstack/router-core
npm i https://pkg.pr.new/@tanstack/router-core@7031

@tanstack/router-devtools
npm i https://pkg.pr.new/@tanstack/router-devtools@7031

@tanstack/router-devtools-core
npm i https://pkg.pr.new/@tanstack/router-devtools-core@7031

@tanstack/router-generator
npm i https://pkg.pr.new/@tanstack/router-generator@7031

@tanstack/router-plugin
npm i https://pkg.pr.new/@tanstack/router-plugin@7031

@tanstack/router-ssr-query-core
npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@7031

@tanstack/router-utils
npm i https://pkg.pr.new/@tanstack/router-utils@7031

@tanstack/router-vite-plugin
npm i https://pkg.pr.new/@tanstack/router-vite-plugin@7031

@tanstack/solid-router
npm i https://pkg.pr.new/@tanstack/solid-router@7031

@tanstack/solid-router-devtools
npm i https://pkg.pr.new/@tanstack/solid-router-devtools@7031

@tanstack/solid-router-ssr-query
npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@7031

@tanstack/solid-start
npm i https://pkg.pr.new/@tanstack/solid-start@7031

@tanstack/solid-start-client
npm i https://pkg.pr.new/@tanstack/solid-start-client@7031

@tanstack/solid-start-server
npm i https://pkg.pr.new/@tanstack/solid-start-server@7031

@tanstack/start-client-core
npm i https://pkg.pr.new/@tanstack/start-client-core@7031

@tanstack/start-fn-stubs
npm i https://pkg.pr.new/@tanstack/start-fn-stubs@7031

@tanstack/start-plugin-core
npm i https://pkg.pr.new/@tanstack/start-plugin-core@7031

@tanstack/start-server-core
npm i https://pkg.pr.new/@tanstack/start-server-core@7031

@tanstack/start-static-server-functions
npm i https://pkg.pr.new/@tanstack/start-static-server-functions@7031

@tanstack/start-storage-context
npm i https://pkg.pr.new/@tanstack/start-storage-context@7031

@tanstack/valibot-adapter
npm i https://pkg.pr.new/@tanstack/valibot-adapter@7031

@tanstack/virtual-file-routes
npm i https://pkg.pr.new/@tanstack/virtual-file-routes@7031

@tanstack/vue-router
npm i https://pkg.pr.new/@tanstack/vue-router@7031

@tanstack/vue-router-devtools
npm i https://pkg.pr.new/@tanstack/vue-router-devtools@7031

@tanstack/vue-router-ssr-query
npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@7031

@tanstack/vue-start
npm i https://pkg.pr.new/@tanstack/vue-start@7031

@tanstack/vue-start-client
npm i https://pkg.pr.new/@tanstack/vue-start-client@7031

@tanstack/vue-start-server
npm i https://pkg.pr.new/@tanstack/vue-start-server@7031

@tanstack/zod-adapter
npm i https://pkg.pr.new/@tanstack/zod-adapter@7031

commit: baa1c16
@codspeed-hq
codspeed-hqBot
commented
Mar 24, 2026

Copy link


Copy Markdown

Merging this PR will not alter performance
✅ 6 untouched benchmarks
Comparing feat-throwOnError (baa1c16) with main (ed9c43d)1
Open in CodSpeed
Footnotes
  1. No successful run was found on main (77ad792) during the generation of this report, so ed9c43d was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩
@Nandan1996
Nandan1996
commented
Mar 28, 2026

Copy link


Copy Markdown

Hi @schiller-manuel

should have added this comment on PR itself. can you take a look at this comment. when loaders run in async mode, the error might get swallowed as well.
#7002 (reply in thread)
@schiller-manuel
schiller-manuel
commented
Mar 28, 2026

Copy link


Copy Markdown

CollaboratorAuthor
probably needs another optional param to force sync preloading
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@SheraffSheraffAwaiting requested review from Sheraff

Assignees


No one assigned


Labels

package: router-core

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@schiller-manuel@Nandan1996

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
feat: throwOnError for preloadRoute - #7031
Draft
schiller-manuel wants to merge 1 commit into
mainfrom 
feat-throwOnError
Draft
feat: throwOnError for preloadRoute#7031
schiller-manuel wants to merge 1 commit into
mainfrom 
feat-throwOnError
Conversation
@schiller-manuel
@schiller-manuelschiller-manuel
commented
Mar 24, 2026•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Collaborator
prompted by #7002
Summary by CodeRabbit
  • New Features
    • Added optional throwOnError flag to control preload route error handling. When enabled, errors encountered during preload are thrown immediately. When disabled, errors continue to be logged and handled gracefully as before.
  • Tests
    • Added comprehensive test coverage validating preload error behavior with standard errors, notFound results, and redirect outcomes using the new flag.
@coderabbitai
coderabbitaiBot
commented
Mar 24, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
📝 Walkthrough
Walkthrough
This pull request adds a new optional throwOnError flag to control error propagation during route preloading. When enabled, errors encountered in beforeLoad hooks and loaders are thrown directly instead of being captured silently. The flag is threaded through the route loading pipeline and integrated with corresponding test coverage.
Changes
Cohort / File(s)Summary
Route Loading Error Handling
packages/router-core/src/load-matches.ts, packages/router-core/src/router.ts		Added throwOnError?: boolean flag to control whether errors during preload are thrown vs captured. Updated loadMatches to conditionally throw errors and modified PreloadRouteFn to pass the flag through the loading pipeline with updated catch logic in preloadRoute.
Test Coverage
packages/router-core/tests/load.test.ts		Added comprehensive test cases for throwOnError behavior, covering regular errors, notFound() results, and redirects in both beforeLoad and loader hooks during preload execution.
Estimated code review effort
🎯 3 (Moderate) | ⏱️ ~25 minutes
Poem
🐰 A flag for the future, throwOnError hops in,

No silent swallowing—let errors spin!

Preload rejects with truth, not hidden sorrow,

The router learns to fail—and fail better tomorrow. 🌟
🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check nameStatusExplanation
Title check✅ PassedThe title directly and concisely describes the main feature being added: a throwOnError option for the preloadRoute functionality.
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
✨ Finishing Touches
📝 Generate docstrings
  •  Create stacked PR
  •  Commit on current branch
🧪 Generate unit tests (beta)
  •  Create PR with unit tests
  •  Commit unit tests in branch feat-throwOnError
Comment @coderabbitai help to get the list of available commands and usage tips.
@nx-cloud
nx-cloudBot
commented
Mar 24, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
 🤖 Nx Cloud AI Fix Eligible
An automatically generated fix could have helped fix failing tasks for this run, but Self-healing CI is disabled for this workspace. Visit workspace settings to enable it and get automatic fixes in future runs.
To disable these notifications, a workspace admin can disable them in workspace settings.
View your CI Pipeline Execution ↗ for commit baa1c16
CommandStatusDurationResult
nx affected --targets=test:eslint,test:unit,tes...❌ Failed9m 46sView ↗
nx run-many --target=build --exclude=examples/*...✅ Succeeded1m 44sView ↗
☁️ Nx Cloud last updated this comment at 2026-03-24 23:36:19 UTC
@github-actions
github-actionsBot
commented
Mar 24, 2026

Copy link


Copy Markdown

Contributor
🚀 Changeset Version Preview
No changeset entries found. Merging this PR will not cause a version bump for any packages.
@schiller-manuel
schiller-manuel
marked this pull request as draft
March 24, 2026 23:26
@github-actions
github-actionsBot
commented
Mar 24, 2026

Copy link


Copy Markdown

Contributor
Bundle Size Benchmarks
  • Commit: 77ad7925d4a6
  • Measured at: 2026-03-24T23:27:27.667Z
  • Baseline source: history:ed9c43df7ab8
  • Dashboard: bundle-size history
ScenarioCurrent (gzip)Delta vs baselineRawBrotliTrend
react-router.minimal88.10 KiB+55 B (+0.06%)277.82 KiB76.47 KiB████▃▃▃▃▃▁▁▂
react-router.full91.33 KiB+57 B (+0.06%)288.81 KiB79.21 KiB████▂▂▃▃▃▁▁▂
solid-router.minimal35.73 KiB+61 B (+0.17%)107.84 KiB32.09 KiB████▃▃▃▃▃▁▁▂
solid-router.full40.13 KiB+55 B (+0.13%)121.23 KiB35.94 KiB████▂▂▃▃▃▁▁▂
vue-router.minimal53.84 KiB+65 B (+0.12%)154.75 KiB48.27 KiB████▁▁▁▁▁▁▁▂
vue-router.full58.71 KiB+67 B (+0.11%)170.23 KiB52.49 KiB████▁▁▃▃▃▃▃▄
react-start.minimal102.45 KiB+49 B (+0.05%)325.84 KiB88.52 KiB████▁▁▃▃▃▁▁▂
react-start.full105.88 KiB+53 B (+0.05%)336.15 KiB91.41 KiB████▁▁▃▃▃▁▁▂
solid-start.minimal49.80 KiB+62 B (+0.12%)154.02 KiB43.87 KiB████▃▃▃▃▃▁▁▂
solid-start.full55.28 KiB+63 B (+0.11%)170.12 KiB48.53 KiB████▂▂▃▃▃▁▁▂
Trend sparkline is historical gzip bytes ending with this PR measurement; lower is better.
@pkg-pr-new
pkg-pr-newBot
commented
Mar 24, 2026

Copy link


Copy Markdown

More templates
@tanstack/arktype-adapter
npm i https://pkg.pr.new/@tanstack/arktype-adapter@7031

@tanstack/eslint-plugin-router
npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@7031

@tanstack/history
npm i https://pkg.pr.new/@tanstack/history@7031

@tanstack/nitro-v2-vite-plugin
npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@7031

@tanstack/react-router
npm i https://pkg.pr.new/@tanstack/react-router@7031

@tanstack/react-router-devtools
npm i https://pkg.pr.new/@tanstack/react-router-devtools@7031

@tanstack/react-router-ssr-query
npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@7031

@tanstack/react-start
npm i https://pkg.pr.new/@tanstack/react-start@7031

@tanstack/react-start-client
npm i https://pkg.pr.new/@tanstack/react-start-client@7031

@tanstack/react-start-server
npm i https://pkg.pr.new/@tanstack/react-start-server@7031

@tanstack/router-cli
npm i https://pkg.pr.new/@tanstack/router-cli@7031

@tanstack/router-core
npm i https://pkg.pr.new/@tanstack/router-core@7031

@tanstack/router-devtools
npm i https://pkg.pr.new/@tanstack/router-devtools@7031

@tanstack/router-devtools-core
npm i https://pkg.pr.new/@tanstack/router-devtools-core@7031

@tanstack/router-generator
npm i https://pkg.pr.new/@tanstack/router-generator@7031

@tanstack/router-plugin
npm i https://pkg.pr.new/@tanstack/router-plugin@7031

@tanstack/router-ssr-query-core
npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@7031

@tanstack/router-utils
npm i https://pkg.pr.new/@tanstack/router-utils@7031

@tanstack/router-vite-plugin
npm i https://pkg.pr.new/@tanstack/router-vite-plugin@7031

@tanstack/solid-router
npm i https://pkg.pr.new/@tanstack/solid-router@7031

@tanstack/solid-router-devtools
npm i https://pkg.pr.new/@tanstack/solid-router-devtools@7031

@tanstack/solid-router-ssr-query
npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@7031

@tanstack/solid-start
npm i https://pkg.pr.new/@tanstack/solid-start@7031

@tanstack/solid-start-client
npm i https://pkg.pr.new/@tanstack/solid-start-client@7031

@tanstack/solid-start-server
npm i https://pkg.pr.new/@tanstack/solid-start-server@7031

@tanstack/start-client-core
npm i https://pkg.pr.new/@tanstack/start-client-core@7031

@tanstack/start-fn-stubs
npm i https://pkg.pr.new/@tanstack/start-fn-stubs@7031

@tanstack/start-plugin-core
npm i https://pkg.pr.new/@tanstack/start-plugin-core@7031

@tanstack/start-server-core
npm i https://pkg.pr.new/@tanstack/start-server-core@7031

@tanstack/start-static-server-functions
npm i https://pkg.pr.new/@tanstack/start-static-server-functions@7031

@tanstack/start-storage-context
npm i https://pkg.pr.new/@tanstack/start-storage-context@7031

@tanstack/valibot-adapter
npm i https://pkg.pr.new/@tanstack/valibot-adapter@7031

@tanstack/virtual-file-routes
npm i https://pkg.pr.new/@tanstack/virtual-file-routes@7031

@tanstack/vue-router
npm i https://pkg.pr.new/@tanstack/vue-router@7031

@tanstack/vue-router-devtools
npm i https://pkg.pr.new/@tanstack/vue-router-devtools@7031

@tanstack/vue-router-ssr-query
npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@7031

@tanstack/vue-start
npm i https://pkg.pr.new/@tanstack/vue-start@7031

@tanstack/vue-start-client
npm i https://pkg.pr.new/@tanstack/vue-start-client@7031

@tanstack/vue-start-server
npm i https://pkg.pr.new/@tanstack/vue-start-server@7031

@tanstack/zod-adapter
npm i https://pkg.pr.new/@tanstack/zod-adapter@7031

commit: baa1c16
@codspeed-hq
codspeed-hqBot
commented
Mar 24, 2026

Copy link


Copy Markdown

Merging this PR will not alter performance
✅ 6 untouched benchmarks
Comparing feat-throwOnError (baa1c16) with main (ed9c43d)1
Open in CodSpeed
Footnotes
  1. No successful run was found on main (77ad792) during the generation of this report, so ed9c43d was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩
@Nandan1996
Nandan1996
commented
Mar 28, 2026

Copy link


Copy Markdown

Hi @schiller-manuel

should have added this comment on PR itself. can you take a look at this comment. when loaders run in async mode, the error might get swallowed as well.
#7002 (reply in thread)
@schiller-manuel
schiller-manuel
commented
Mar 28, 2026

Copy link


Copy Markdown

CollaboratorAuthor
probably needs another optional param to force sync preloading
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@SheraffSheraffAwaiting requested review from Sheraff

Assignees


No one assigned


Labels

package: router-core

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@schiller-manuel@Nandan1996

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
feat: throwOnError for preloadRoute - #7031
Draft
schiller-manuel wants to merge 1 commit into
mainfrom 
feat-throwOnError
Draft
feat: throwOnError for preloadRoute#7031
schiller-manuel wants to merge 1 commit into
mainfrom 
feat-throwOnError
Conversation
@schiller-manuel
@schiller-manuelschiller-manuel
commented
Mar 24, 2026•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Collaborator
prompted by #7002
Summary by CodeRabbit
  • New Features
    • Added optional throwOnError flag to control preload route error handling. When enabled, errors encountered during preload are thrown immediately. When disabled, errors continue to be logged and handled gracefully as before.
  • Tests
    • Added comprehensive test coverage validating preload error behavior with standard errors, notFound results, and redirect outcomes using the new flag.
@coderabbitai
coderabbitaiBot
commented
Mar 24, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
📝 Walkthrough
Walkthrough
This pull request adds a new optional throwOnError flag to control error propagation during route preloading. When enabled, errors encountered in beforeLoad hooks and loaders are thrown directly instead of being captured silently. The flag is threaded through the route loading pipeline and integrated with corresponding test coverage.
Changes
Cohort / File(s)Summary
Route Loading Error Handling
packages/router-core/src/load-matches.ts, packages/router-core/src/router.ts		Added throwOnError?: boolean flag to control whether errors during preload are thrown vs captured. Updated loadMatches to conditionally throw errors and modified PreloadRouteFn to pass the flag through the loading pipeline with updated catch logic in preloadRoute.
Test Coverage
packages/router-core/tests/load.test.ts		Added comprehensive test cases for throwOnError behavior, covering regular errors, notFound() results, and redirects in both beforeLoad and loader hooks during preload execution.
Estimated code review effort
🎯 3 (Moderate) | ⏱️ ~25 minutes
Poem
🐰 A flag for the future, throwOnError hops in,

No silent swallowing—let errors spin!

Preload rejects with truth, not hidden sorrow,

The router learns to fail—and fail better tomorrow. 🌟
🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check nameStatusExplanation
Title check✅ PassedThe title directly and concisely describes the main feature being added: a throwOnError option for the preloadRoute functionality.
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
✨ Finishing Touches
📝 Generate docstrings
  •  Create stacked PR
  •  Commit on current branch
🧪 Generate unit tests (beta)
  •  Create PR with unit tests
  •  Commit unit tests in branch feat-throwOnError
Comment @coderabbitai help to get the list of available commands and usage tips.
@nx-cloud
nx-cloudBot
commented
Mar 24, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
 🤖 Nx Cloud AI Fix Eligible
An automatically generated fix could have helped fix failing tasks for this run, but Self-healing CI is disabled for this workspace. Visit workspace settings to enable it and get automatic fixes in future runs.
To disable these notifications, a workspace admin can disable them in workspace settings.
View your CI Pipeline Execution ↗ for commit baa1c16
CommandStatusDurationResult
nx affected --targets=test:eslint,test:unit,tes...❌ Failed9m 46sView ↗
nx run-many --target=build --exclude=examples/*...✅ Succeeded1m 44sView ↗
☁️ Nx Cloud last updated this comment at 2026-03-24 23:36:19 UTC
@github-actions
github-actionsBot
commented
Mar 24, 2026

Copy link


Copy Markdown

Contributor
🚀 Changeset Version Preview
No changeset entries found. Merging this PR will not cause a version bump for any packages.
@schiller-manuel
schiller-manuel
marked this pull request as draft
March 24, 2026 23:26
@github-actions
github-actionsBot
commented
Mar 24, 2026

Copy link


Copy Markdown

Contributor
Bundle Size Benchmarks
  • Commit: 77ad7925d4a6
  • Measured at: 2026-03-24T23:27:27.667Z
  • Baseline source: history:ed9c43df7ab8
  • Dashboard: bundle-size history
ScenarioCurrent (gzip)Delta vs baselineRawBrotliTrend
react-router.minimal88.10 KiB+55 B (+0.06%)277.82 KiB76.47 KiB████▃▃▃▃▃▁▁▂
react-router.full91.33 KiB+57 B (+0.06%)288.81 KiB79.21 KiB████▂▂▃▃▃▁▁▂
solid-router.minimal35.73 KiB+61 B (+0.17%)107.84 KiB32.09 KiB████▃▃▃▃▃▁▁▂
solid-router.full40.13 KiB+55 B (+0.13%)121.23 KiB35.94 KiB████▂▂▃▃▃▁▁▂
vue-router.minimal53.84 KiB+65 B (+0.12%)154.75 KiB48.27 KiB████▁▁▁▁▁▁▁▂
vue-router.full58.71 KiB+67 B (+0.11%)170.23 KiB52.49 KiB████▁▁▃▃▃▃▃▄
react-start.minimal102.45 KiB+49 B (+0.05%)325.84 KiB88.52 KiB████▁▁▃▃▃▁▁▂
react-start.full105.88 KiB+53 B (+0.05%)336.15 KiB91.41 KiB████▁▁▃▃▃▁▁▂
solid-start.minimal49.80 KiB+62 B (+0.12%)154.02 KiB43.87 KiB████▃▃▃▃▃▁▁▂
solid-start.full55.28 KiB+63 B (+0.11%)170.12 KiB48.53 KiB████▂▂▃▃▃▁▁▂
Trend sparkline is historical gzip bytes ending with this PR measurement; lower is better.
@pkg-pr-new
pkg-pr-newBot
commented
Mar 24, 2026

Copy link


Copy Markdown

More templates
@tanstack/arktype-adapter
npm i https://pkg.pr.new/@tanstack/arktype-adapter@7031

@tanstack/eslint-plugin-router
npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@7031

@tanstack/history
npm i https://pkg.pr.new/@tanstack/history@7031

@tanstack/nitro-v2-vite-plugin
npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@7031

@tanstack/react-router
npm i https://pkg.pr.new/@tanstack/react-router@7031

@tanstack/react-router-devtools
npm i https://pkg.pr.new/@tanstack/react-router-devtools@7031

@tanstack/react-router-ssr-query
npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@7031

@tanstack/react-start
npm i https://pkg.pr.new/@tanstack/react-start@7031

@tanstack/react-start-client
npm i https://pkg.pr.new/@tanstack/react-start-client@7031

@tanstack/react-start-server
npm i https://pkg.pr.new/@tanstack/react-start-server@7031

@tanstack/router-cli
npm i https://pkg.pr.new/@tanstack/router-cli@7031

@tanstack/router-core
npm i https://pkg.pr.new/@tanstack/router-core@7031

@tanstack/router-devtools
npm i https://pkg.pr.new/@tanstack/router-devtools@7031

@tanstack/router-devtools-core
npm i https://pkg.pr.new/@tanstack/router-devtools-core@7031

@tanstack/router-generator
npm i https://pkg.pr.new/@tanstack/router-generator@7031

@tanstack/router-plugin
npm i https://pkg.pr.new/@tanstack/router-plugin@7031

@tanstack/router-ssr-query-core
npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@7031

@tanstack/router-utils
npm i https://pkg.pr.new/@tanstack/router-utils@7031

@tanstack/router-vite-plugin
npm i https://pkg.pr.new/@tanstack/router-vite-plugin@7031

@tanstack/solid-router
npm i https://pkg.pr.new/@tanstack/solid-router@7031

@tanstack/solid-router-devtools
npm i https://pkg.pr.new/@tanstack/solid-router-devtools@7031

@tanstack/solid-router-ssr-query
npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@7031

@tanstack/solid-start
npm i https://pkg.pr.new/@tanstack/solid-start@7031

@tanstack/solid-start-client
npm i https://pkg.pr.new/@tanstack/solid-start-client@7031

@tanstack/solid-start-server
npm i https://pkg.pr.new/@tanstack/solid-start-server@7031

@tanstack/start-client-core
npm i https://pkg.pr.new/@tanstack/start-client-core@7031

@tanstack/start-fn-stubs
npm i https://pkg.pr.new/@tanstack/start-fn-stubs@7031

@tanstack/start-plugin-core
npm i https://pkg.pr.new/@tanstack/start-plugin-core@7031

@tanstack/start-server-core
npm i https://pkg.pr.new/@tanstack/start-server-core@7031

@tanstack/start-static-server-functions
npm i https://pkg.pr.new/@tanstack/start-static-server-functions@7031

@tanstack/start-storage-context
npm i https://pkg.pr.new/@tanstack/start-storage-context@7031

@tanstack/valibot-adapter
npm i https://pkg.pr.new/@tanstack/valibot-adapter@7031

@tanstack/virtual-file-routes
npm i https://pkg.pr.new/@tanstack/virtual-file-routes@7031

@tanstack/vue-router
npm i https://pkg.pr.new/@tanstack/vue-router@7031

@tanstack/vue-router-devtools
npm i https://pkg.pr.new/@tanstack/vue-router-devtools@7031

@tanstack/vue-router-ssr-query
npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@7031

@tanstack/vue-start
npm i https://pkg.pr.new/@tanstack/vue-start@7031

@tanstack/vue-start-client
npm i https://pkg.pr.new/@tanstack/vue-start-client@7031

@tanstack/vue-start-server
npm i https://pkg.pr.new/@tanstack/vue-start-server@7031

@tanstack/zod-adapter
npm i https://pkg.pr.new/@tanstack/zod-adapter@7031

commit: baa1c16
@codspeed-hq
codspeed-hqBot
commented
Mar 24, 2026

Copy link


Copy Markdown

Merging this PR will not alter performance
✅ 6 untouched benchmarks
Comparing feat-throwOnError (baa1c16) with main (ed9c43d)1
Open in CodSpeed
Footnotes
  1. No successful run was found on main (77ad792) during the generation of this report, so ed9c43d was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩
@Nandan1996
Nandan1996
commented
Mar 28, 2026

Copy link


Copy Markdown

Hi @schiller-manuel

should have added this comment on PR itself. can you take a look at this comment. when loaders run in async mode, the error might get swallowed as well.
#7002 (reply in thread)
@schiller-manuel
schiller-manuel
commented
Mar 28, 2026

Copy link


Copy Markdown

CollaboratorAuthor
probably needs another optional param to force sync preloading
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@SheraffSheraffAwaiting requested review from Sheraff

Assignees


No one assigned


Labels

package: router-core

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@schiller-manuel@Nandan1996

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
feat: throwOnError for preloadRoute - #7031
Draft
schiller-manuel wants to merge 1 commit into
mainfrom 
feat-throwOnError
Draft
feat: throwOnError for preloadRoute#7031
schiller-manuel wants to merge 1 commit into
mainfrom 
feat-throwOnError
Conversation
@schiller-manuel
@schiller-manuelschiller-manuel
commented
Mar 24, 2026•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Collaborator
prompted by #7002
Summary by CodeRabbit
  • New Features
    • Added optional throwOnError flag to control preload route error handling. When enabled, errors encountered during preload are thrown immediately. When disabled, errors continue to be logged and handled gracefully as before.
  • Tests
    • Added comprehensive test coverage validating preload error behavior with standard errors, notFound results, and redirect outcomes using the new flag.
@coderabbitai
coderabbitaiBot
commented
Mar 24, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
📝 Walkthrough
Walkthrough
This pull request adds a new optional throwOnError flag to control error propagation during route preloading. When enabled, errors encountered in beforeLoad hooks and loaders are thrown directly instead of being captured silently. The flag is threaded through the route loading pipeline and integrated with corresponding test coverage.
Changes
Cohort / File(s)Summary
Route Loading Error Handling
packages/router-core/src/load-matches.ts, packages/router-core/src/router.ts		Added throwOnError?: boolean flag to control whether errors during preload are thrown vs captured. Updated loadMatches to conditionally throw errors and modified PreloadRouteFn to pass the flag through the loading pipeline with updated catch logic in preloadRoute.
Test Coverage
packages/router-core/tests/load.test.ts		Added comprehensive test cases for throwOnError behavior, covering regular errors, notFound() results, and redirects in both beforeLoad and loader hooks during preload execution.
Estimated code review effort
🎯 3 (Moderate) | ⏱️ ~25 minutes
Poem
🐰 A flag for the future, throwOnError hops in,

No silent swallowing—let errors spin!

Preload rejects with truth, not hidden sorrow,

The router learns to fail—and fail better tomorrow. 🌟
🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check nameStatusExplanation
Title check✅ PassedThe title directly and concisely describes the main feature being added: a throwOnError option for the preloadRoute functionality.
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
✨ Finishing Touches
📝 Generate docstrings
  •  Create stacked PR
  •  Commit on current branch
🧪 Generate unit tests (beta)
  •  Create PR with unit tests
  •  Commit unit tests in branch feat-throwOnError
Comment @coderabbitai help to get the list of available commands and usage tips.
@nx-cloud
nx-cloudBot
commented
Mar 24, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
 🤖 Nx Cloud AI Fix Eligible
An automatically generated fix could have helped fix failing tasks for this run, but Self-healing CI is disabled for this workspace. Visit workspace settings to enable it and get automatic fixes in future runs.
To disable these notifications, a workspace admin can disable them in workspace settings.
View your CI Pipeline Execution ↗ for commit baa1c16
CommandStatusDurationResult
nx affected --targets=test:eslint,test:unit,tes...❌ Failed9m 46sView ↗
nx run-many --target=build --exclude=examples/*...✅ Succeeded1m 44sView ↗
☁️ Nx Cloud last updated this comment at 2026-03-24 23:36:19 UTC
@github-actions
github-actionsBot
commented
Mar 24, 2026

Copy link


Copy Markdown

Contributor
🚀 Changeset Version Preview
No changeset entries found. Merging this PR will not cause a version bump for any packages.
@schiller-manuel
schiller-manuel
marked this pull request as draft
March 24, 2026 23:26
@github-actions
github-actionsBot
commented
Mar 24, 2026

Copy link


Copy Markdown

Contributor
Bundle Size Benchmarks
  • Commit: 77ad7925d4a6
  • Measured at: 2026-03-24T23:27:27.667Z
  • Baseline source: history:ed9c43df7ab8
  • Dashboard: bundle-size history
ScenarioCurrent (gzip)Delta vs baselineRawBrotliTrend
react-router.minimal88.10 KiB+55 B (+0.06%)277.82 KiB76.47 KiB████▃▃▃▃▃▁▁▂
react-router.full91.33 KiB+57 B (+0.06%)288.81 KiB79.21 KiB████▂▂▃▃▃▁▁▂
solid-router.minimal35.73 KiB+61 B (+0.17%)107.84 KiB32.09 KiB████▃▃▃▃▃▁▁▂
solid-router.full40.13 KiB+55 B (+0.13%)121.23 KiB35.94 KiB████▂▂▃▃▃▁▁▂
vue-router.minimal53.84 KiB+65 B (+0.12%)154.75 KiB48.27 KiB████▁▁▁▁▁▁▁▂
vue-router.full58.71 KiB+67 B (+0.11%)170.23 KiB52.49 KiB████▁▁▃▃▃▃▃▄
react-start.minimal102.45 KiB+49 B (+0.05%)325.84 KiB88.52 KiB████▁▁▃▃▃▁▁▂
react-start.full105.88 KiB+53 B (+0.05%)336.15 KiB91.41 KiB████▁▁▃▃▃▁▁▂
solid-start.minimal49.80 KiB+62 B (+0.12%)154.02 KiB43.87 KiB████▃▃▃▃▃▁▁▂
solid-start.full55.28 KiB+63 B (+0.11%)170.12 KiB48.53 KiB████▂▂▃▃▃▁▁▂
Trend sparkline is historical gzip bytes ending with this PR measurement; lower is better.
@pkg-pr-new
pkg-pr-newBot
commented
Mar 24, 2026

Copy link


Copy Markdown

More templates
@tanstack/arktype-adapter
npm i https://pkg.pr.new/@tanstack/arktype-adapter@7031

@tanstack/eslint-plugin-router
npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@7031

@tanstack/history
npm i https://pkg.pr.new/@tanstack/history@7031

@tanstack/nitro-v2-vite-plugin
npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@7031

@tanstack/react-router
npm i https://pkg.pr.new/@tanstack/react-router@7031

@tanstack/react-router-devtools
npm i https://pkg.pr.new/@tanstack/react-router-devtools@7031

@tanstack/react-router-ssr-query
npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@7031

@tanstack/react-start
npm i https://pkg.pr.new/@tanstack/react-start@7031

@tanstack/react-start-client
npm i https://pkg.pr.new/@tanstack/react-start-client@7031

@tanstack/react-start-server
npm i https://pkg.pr.new/@tanstack/react-start-server@7031

@tanstack/router-cli
npm i https://pkg.pr.new/@tanstack/router-cli@7031

@tanstack/router-core
npm i https://pkg.pr.new/@tanstack/router-core@7031

@tanstack/router-devtools
npm i https://pkg.pr.new/@tanstack/router-devtools@7031

@tanstack/router-devtools-core
npm i https://pkg.pr.new/@tanstack/router-devtools-core@7031

@tanstack/router-generator
npm i https://pkg.pr.new/@tanstack/router-generator@7031

@tanstack/router-plugin
npm i https://pkg.pr.new/@tanstack/router-plugin@7031

@tanstack/router-ssr-query-core
npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@7031

@tanstack/router-utils
npm i https://pkg.pr.new/@tanstack/router-utils@7031

@tanstack/router-vite-plugin
npm i https://pkg.pr.new/@tanstack/router-vite-plugin@7031

@tanstack/solid-router
npm i https://pkg.pr.new/@tanstack/solid-router@7031

@tanstack/solid-router-devtools
npm i https://pkg.pr.new/@tanstack/solid-router-devtools@7031

@tanstack/solid-router-ssr-query
npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@7031

@tanstack/solid-start
npm i https://pkg.pr.new/@tanstack/solid-start@7031

@tanstack/solid-start-client
npm i https://pkg.pr.new/@tanstack/solid-start-client@7031

@tanstack/solid-start-server
npm i https://pkg.pr.new/@tanstack/solid-start-server@7031

@tanstack/start-client-core
npm i https://pkg.pr.new/@tanstack/start-client-core@7031

@tanstack/start-fn-stubs
npm i https://pkg.pr.new/@tanstack/start-fn-stubs@7031

@tanstack/start-plugin-core
npm i https://pkg.pr.new/@tanstack/start-plugin-core@7031

@tanstack/start-server-core
npm i https://pkg.pr.new/@tanstack/start-server-core@7031

@tanstack/start-static-server-functions
npm i https://pkg.pr.new/@tanstack/start-static-server-functions@7031

@tanstack/start-storage-context
npm i https://pkg.pr.new/@tanstack/start-storage-context@7031

@tanstack/valibot-adapter
npm i https://pkg.pr.new/@tanstack/valibot-adapter@7031

@tanstack/virtual-file-routes
npm i https://pkg.pr.new/@tanstack/virtual-file-routes@7031

@tanstack/vue-router
npm i https://pkg.pr.new/@tanstack/vue-router@7031

@tanstack/vue-router-devtools
npm i https://pkg.pr.new/@tanstack/vue-router-devtools@7031

@tanstack/vue-router-ssr-query
npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@7031

@tanstack/vue-start
npm i https://pkg.pr.new/@tanstack/vue-start@7031

@tanstack/vue-start-client
npm i https://pkg.pr.new/@tanstack/vue-start-client@7031

@tanstack/vue-start-server
npm i https://pkg.pr.new/@tanstack/vue-start-server@7031

@tanstack/zod-adapter
npm i https://pkg.pr.new/@tanstack/zod-adapter@7031

commit: baa1c16
@codspeed-hq
codspeed-hqBot
commented
Mar 24, 2026

Copy link


Copy Markdown

Merging this PR will not alter performance
✅ 6 untouched benchmarks
Comparing feat-throwOnError (baa1c16) with main (ed9c43d)1
Open in CodSpeed
Footnotes
  1. No successful run was found on main (77ad792) during the generation of this report, so ed9c43d was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩
@Nandan1996
Nandan1996
commented
Mar 28, 2026

Copy link


Copy Markdown

Hi @schiller-manuel

should have added this comment on PR itself. can you take a look at this comment. when loaders run in async mode, the error might get swallowed as well.
#7002 (reply in thread)
@schiller-manuel
schiller-manuel
commented
Mar 28, 2026

Copy link


Copy Markdown

CollaboratorAuthor
probably needs another optional param to force sync preloading
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@SheraffSheraffAwaiting requested review from Sheraff

Assignees


No one assigned


Labels

package: router-core

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@schiller-manuel@Nandan1996

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
feat: throwOnError for preloadRoute - #7031
Draft
schiller-manuel wants to merge 1 commit into
mainfrom 
feat-throwOnError
Draft
feat: throwOnError for preloadRoute#7031
schiller-manuel wants to merge 1 commit into
mainfrom 
feat-throwOnError
Conversation
@schiller-manuel
@schiller-manuelschiller-manuel
commented
Mar 24, 2026•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Collaborator
prompted by #7002
Summary by CodeRabbit
  • New Features
    • Added optional throwOnError flag to control preload route error handling. When enabled, errors encountered during preload are thrown immediately. When disabled, errors continue to be logged and handled gracefully as before.
  • Tests
    • Added comprehensive test coverage validating preload error behavior with standard errors, notFound results, and redirect outcomes using the new flag.
@coderabbitai
coderabbitaiBot
commented
Mar 24, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
📝 Walkthrough
Walkthrough
This pull request adds a new optional throwOnError flag to control error propagation during route preloading. When enabled, errors encountered in beforeLoad hooks and loaders are thrown directly instead of being captured silently. The flag is threaded through the route loading pipeline and integrated with corresponding test coverage.
Changes
Cohort / File(s)Summary
Route Loading Error Handling
packages/router-core/src/load-matches.ts, packages/router-core/src/router.ts		Added throwOnError?: boolean flag to control whether errors during preload are thrown vs captured. Updated loadMatches to conditionally throw errors and modified PreloadRouteFn to pass the flag through the loading pipeline with updated catch logic in preloadRoute.
Test Coverage
packages/router-core/tests/load.test.ts		Added comprehensive test cases for throwOnError behavior, covering regular errors, notFound() results, and redirects in both beforeLoad and loader hooks during preload execution.
Estimated code review effort
🎯 3 (Moderate) | ⏱️ ~25 minutes
Poem
🐰 A flag for the future, throwOnError hops in,

No silent swallowing—let errors spin!

Preload rejects with truth, not hidden sorrow,

The router learns to fail—and fail better tomorrow. 🌟
🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check nameStatusExplanation
Title check✅ PassedThe title directly and concisely describes the main feature being added: a throwOnError option for the preloadRoute functionality.
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
✨ Finishing Touches
📝 Generate docstrings
  •  Create stacked PR
  •  Commit on current branch
🧪 Generate unit tests (beta)
  •  Create PR with unit tests
  •  Commit unit tests in branch feat-throwOnError
Comment @coderabbitai help to get the list of available commands and usage tips.
@nx-cloud
nx-cloudBot
commented
Mar 24, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
 🤖 Nx Cloud AI Fix Eligible
An automatically generated fix could have helped fix failing tasks for this run, but Self-healing CI is disabled for this workspace. Visit workspace settings to enable it and get automatic fixes in future runs.
To disable these notifications, a workspace admin can disable them in workspace settings.
View your CI Pipeline Execution ↗ for commit baa1c16
CommandStatusDurationResult
nx affected --targets=test:eslint,test:unit,tes...❌ Failed9m 46sView ↗
nx run-many --target=build --exclude=examples/*...✅ Succeeded1m 44sView ↗
☁️ Nx Cloud last updated this comment at 2026-03-24 23:36:19 UTC
@github-actions
github-actionsBot
commented
Mar 24, 2026

Copy link


Copy Markdown

Contributor
🚀 Changeset Version Preview
No changeset entries found. Merging this PR will not cause a version bump for any packages.
@schiller-manuel
schiller-manuel
marked this pull request as draft
March 24, 2026 23:26
@github-actions
github-actionsBot
commented
Mar 24, 2026

Copy link


Copy Markdown

Contributor
Bundle Size Benchmarks
  • Commit: 77ad7925d4a6
  • Measured at: 2026-03-24T23:27:27.667Z
  • Baseline source: history:ed9c43df7ab8
  • Dashboard: bundle-size history
ScenarioCurrent (gzip)Delta vs baselineRawBrotliTrend
react-router.minimal88.10 KiB+55 B (+0.06%)277.82 KiB76.47 KiB████▃▃▃▃▃▁▁▂
react-router.full91.33 KiB+57 B (+0.06%)288.81 KiB79.21 KiB████▂▂▃▃▃▁▁▂
solid-router.minimal35.73 KiB+61 B (+0.17%)107.84 KiB32.09 KiB████▃▃▃▃▃▁▁▂
solid-router.full40.13 KiB+55 B (+0.13%)121.23 KiB35.94 KiB████▂▂▃▃▃▁▁▂
vue-router.minimal53.84 KiB+65 B (+0.12%)154.75 KiB48.27 KiB████▁▁▁▁▁▁▁▂
vue-router.full58.71 KiB+67 B (+0.11%)170.23 KiB52.49 KiB████▁▁▃▃▃▃▃▄
react-start.minimal102.45 KiB+49 B (+0.05%)325.84 KiB88.52 KiB████▁▁▃▃▃▁▁▂
react-start.full105.88 KiB+53 B (+0.05%)336.15 KiB91.41 KiB████▁▁▃▃▃▁▁▂
solid-start.minimal49.80 KiB+62 B (+0.12%)154.02 KiB43.87 KiB████▃▃▃▃▃▁▁▂
solid-start.full55.28 KiB+63 B (+0.11%)170.12 KiB48.53 KiB████▂▂▃▃▃▁▁▂
Trend sparkline is historical gzip bytes ending with this PR measurement; lower is better.
@pkg-pr-new
pkg-pr-newBot
commented
Mar 24, 2026

Copy link


Copy Markdown

More templates
@tanstack/arktype-adapter
npm i https://pkg.pr.new/@tanstack/arktype-adapter@7031

@tanstack/eslint-plugin-router
npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@7031

@tanstack/history
npm i https://pkg.pr.new/@tanstack/history@7031

@tanstack/nitro-v2-vite-plugin
npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@7031

@tanstack/react-router
npm i https://pkg.pr.new/@tanstack/react-router@7031

@tanstack/react-router-devtools
npm i https://pkg.pr.new/@tanstack/react-router-devtools@7031

@tanstack/react-router-ssr-query
npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@7031

@tanstack/react-start
npm i https://pkg.pr.new/@tanstack/react-start@7031

@tanstack/react-start-client
npm i https://pkg.pr.new/@tanstack/react-start-client@7031

@tanstack/react-start-server
npm i https://pkg.pr.new/@tanstack/react-start-server@7031

@tanstack/router-cli
npm i https://pkg.pr.new/@tanstack/router-cli@7031

@tanstack/router-core
npm i https://pkg.pr.new/@tanstack/router-core@7031

@tanstack/router-devtools
npm i https://pkg.pr.new/@tanstack/router-devtools@7031

@tanstack/router-devtools-core
npm i https://pkg.pr.new/@tanstack/router-devtools-core@7031

@tanstack/router-generator
npm i https://pkg.pr.new/@tanstack/router-generator@7031

@tanstack/router-plugin
npm i https://pkg.pr.new/@tanstack/router-plugin@7031

@tanstack/router-ssr-query-core
npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@7031

@tanstack/router-utils
npm i https://pkg.pr.new/@tanstack/router-utils@7031

@tanstack/router-vite-plugin
npm i https://pkg.pr.new/@tanstack/router-vite-plugin@7031

@tanstack/solid-router
npm i https://pkg.pr.new/@tanstack/solid-router@7031

@tanstack/solid-router-devtools
npm i https://pkg.pr.new/@tanstack/solid-router-devtools@7031

@tanstack/solid-router-ssr-query
npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@7031

@tanstack/solid-start
npm i https://pkg.pr.new/@tanstack/solid-start@7031

@tanstack/solid-start-client
npm i https://pkg.pr.new/@tanstack/solid-start-client@7031

@tanstack/solid-start-server
npm i https://pkg.pr.new/@tanstack/solid-start-server@7031

@tanstack/start-client-core
npm i https://pkg.pr.new/@tanstack/start-client-core@7031

@tanstack/start-fn-stubs
npm i https://pkg.pr.new/@tanstack/start-fn-stubs@7031

@tanstack/start-plugin-core
npm i https://pkg.pr.new/@tanstack/start-plugin-core@7031

@tanstack/start-server-core
npm i https://pkg.pr.new/@tanstack/start-server-core@7031

@tanstack/start-static-server-functions
npm i https://pkg.pr.new/@tanstack/start-static-server-functions@7031

@tanstack/start-storage-context
npm i https://pkg.pr.new/@tanstack/start-storage-context@7031

@tanstack/valibot-adapter
npm i https://pkg.pr.new/@tanstack/valibot-adapter@7031

@tanstack/virtual-file-routes
npm i https://pkg.pr.new/@tanstack/virtual-file-routes@7031

@tanstack/vue-router
npm i https://pkg.pr.new/@tanstack/vue-router@7031

@tanstack/vue-router-devtools
npm i https://pkg.pr.new/@tanstack/vue-router-devtools@7031

@tanstack/vue-router-ssr-query
npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@7031

@tanstack/vue-start
npm i https://pkg.pr.new/@tanstack/vue-start@7031

@tanstack/vue-start-client
npm i https://pkg.pr.new/@tanstack/vue-start-client@7031

@tanstack/vue-start-server
npm i https://pkg.pr.new/@tanstack/vue-start-server@7031

@tanstack/zod-adapter
npm i https://pkg.pr.new/@tanstack/zod-adapter@7031

commit: baa1c16
@codspeed-hq
codspeed-hqBot
commented
Mar 24, 2026

Copy link


Copy Markdown

Merging this PR will not alter performance
✅ 6 untouched benchmarks
Comparing feat-throwOnError (baa1c16) with main (ed9c43d)1
Open in CodSpeed
Footnotes
  1. No successful run was found on main (77ad792) during the generation of this report, so ed9c43d was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩
@Nandan1996
Nandan1996
commented
Mar 28, 2026

Copy link


Copy Markdown

Hi @schiller-manuel

should have added this comment on PR itself. can you take a look at this comment. when loaders run in async mode, the error might get swallowed as well.
#7002 (reply in thread)
@schiller-manuel
schiller-manuel
commented
Mar 28, 2026

Copy link


Copy Markdown

CollaboratorAuthor
probably needs another optional param to force sync preloading
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@SheraffSheraffAwaiting requested review from Sheraff

Assignees


No one assigned


Labels

package: router-core

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@schiller-manuel@Nandan1996

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
feat: throwOnError for preloadRoute - #7031
Draft
schiller-manuel wants to merge 1 commit into
mainfrom 
feat-throwOnError
Draft
feat: throwOnError for preloadRoute#7031
schiller-manuel wants to merge 1 commit into
mainfrom 
feat-throwOnError
Conversation
@schiller-manuel
@schiller-manuelschiller-manuel
commented
Mar 24, 2026•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Collaborator
prompted by #7002
Summary by CodeRabbit
  • New Features
    • Added optional throwOnError flag to control preload route error handling. When enabled, errors encountered during preload are thrown immediately. When disabled, errors continue to be logged and handled gracefully as before.
  • Tests
    • Added comprehensive test coverage validating preload error behavior with standard errors, notFound results, and redirect outcomes using the new flag.
@coderabbitai
coderabbitaiBot
commented
Mar 24, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
📝 Walkthrough
Walkthrough
This pull request adds a new optional throwOnError flag to control error propagation during route preloading. When enabled, errors encountered in beforeLoad hooks and loaders are thrown directly instead of being captured silently. The flag is threaded through the route loading pipeline and integrated with corresponding test coverage.
Changes
Cohort / File(s)Summary
Route Loading Error Handling
packages/router-core/src/load-matches.ts, packages/router-core/src/router.ts		Added throwOnError?: boolean flag to control whether errors during preload are thrown vs captured. Updated loadMatches to conditionally throw errors and modified PreloadRouteFn to pass the flag through the loading pipeline with updated catch logic in preloadRoute.
Test Coverage
packages/router-core/tests/load.test.ts		Added comprehensive test cases for throwOnError behavior, covering regular errors, notFound() results, and redirects in both beforeLoad and loader hooks during preload execution.
Estimated code review effort
🎯 3 (Moderate) | ⏱️ ~25 minutes
Poem
🐰 A flag for the future, throwOnError hops in,

No silent swallowing—let errors spin!

Preload rejects with truth, not hidden sorrow,

The router learns to fail—and fail better tomorrow. 🌟
🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check nameStatusExplanation
Title check✅ PassedThe title directly and concisely describes the main feature being added: a throwOnError option for the preloadRoute functionality.
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
✨ Finishing Touches
📝 Generate docstrings
  •  Create stacked PR
  •  Commit on current branch
🧪 Generate unit tests (beta)
  •  Create PR with unit tests
  •  Commit unit tests in branch feat-throwOnError
Comment @coderabbitai help to get the list of available commands and usage tips.
@nx-cloud
nx-cloudBot
commented
Mar 24, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
 🤖 Nx Cloud AI Fix Eligible
An automatically generated fix could have helped fix failing tasks for this run, but Self-healing CI is disabled for this workspace. Visit workspace settings to enable it and get automatic fixes in future runs.
To disable these notifications, a workspace admin can disable them in workspace settings.
View your CI Pipeline Execution ↗ for commit baa1c16
CommandStatusDurationResult
nx affected --targets=test:eslint,test:unit,tes...❌ Failed9m 46sView ↗
nx run-many --target=build --exclude=examples/*...✅ Succeeded1m 44sView ↗
☁️ Nx Cloud last updated this comment at 2026-03-24 23:36:19 UTC
@github-actions
github-actionsBot
commented
Mar 24, 2026

Copy link


Copy Markdown

Contributor
🚀 Changeset Version Preview
No changeset entries found. Merging this PR will not cause a version bump for any packages.
@schiller-manuel
schiller-manuel
marked this pull request as draft
March 24, 2026 23:26
@github-actions
github-actionsBot
commented
Mar 24, 2026

Copy link


Copy Markdown

Contributor
Bundle Size Benchmarks
  • Commit: 77ad7925d4a6
  • Measured at: 2026-03-24T23:27:27.667Z
  • Baseline source: history:ed9c43df7ab8
  • Dashboard: bundle-size history
ScenarioCurrent (gzip)Delta vs baselineRawBrotliTrend
react-router.minimal88.10 KiB+55 B (+0.06%)277.82 KiB76.47 KiB████▃▃▃▃▃▁▁▂
react-router.full91.33 KiB+57 B (+0.06%)288.81 KiB79.21 KiB████▂▂▃▃▃▁▁▂
solid-router.minimal35.73 KiB+61 B (+0.17%)107.84 KiB32.09 KiB████▃▃▃▃▃▁▁▂
solid-router.full40.13 KiB+55 B (+0.13%)121.23 KiB35.94 KiB████▂▂▃▃▃▁▁▂
vue-router.minimal53.84 KiB+65 B (+0.12%)154.75 KiB48.27 KiB████▁▁▁▁▁▁▁▂
vue-router.full58.71 KiB+67 B (+0.11%)170.23 KiB52.49 KiB████▁▁▃▃▃▃▃▄
react-start.minimal102.45 KiB+49 B (+0.05%)325.84 KiB88.52 KiB████▁▁▃▃▃▁▁▂
react-start.full105.88 KiB+53 B (+0.05%)336.15 KiB91.41 KiB████▁▁▃▃▃▁▁▂
solid-start.minimal49.80 KiB+62 B (+0.12%)154.02 KiB43.87 KiB████▃▃▃▃▃▁▁▂
solid-start.full55.28 KiB+63 B (+0.11%)170.12 KiB48.53 KiB████▂▂▃▃▃▁▁▂
Trend sparkline is historical gzip bytes ending with this PR measurement; lower is better.
@pkg-pr-new
pkg-pr-newBot
commented
Mar 24, 2026

Copy link


Copy Markdown

More templates
@tanstack/arktype-adapter
npm i https://pkg.pr.new/@tanstack/arktype-adapter@7031

@tanstack/eslint-plugin-router
npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@7031

@tanstack/history
npm i https://pkg.pr.new/@tanstack/history@7031

@tanstack/nitro-v2-vite-plugin
npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@7031

@tanstack/react-router
npm i https://pkg.pr.new/@tanstack/react-router@7031

@tanstack/react-router-devtools
npm i https://pkg.pr.new/@tanstack/react-router-devtools@7031

@tanstack/react-router-ssr-query
npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@7031

@tanstack/react-start
npm i https://pkg.pr.new/@tanstack/react-start@7031

@tanstack/react-start-client
npm i https://pkg.pr.new/@tanstack/react-start-client@7031

@tanstack/react-start-server
npm i https://pkg.pr.new/@tanstack/react-start-server@7031

@tanstack/router-cli
npm i https://pkg.pr.new/@tanstack/router-cli@7031

@tanstack/router-core
npm i https://pkg.pr.new/@tanstack/router-core@7031

@tanstack/router-devtools
npm i https://pkg.pr.new/@tanstack/router-devtools@7031

@tanstack/router-devtools-core
npm i https://pkg.pr.new/@tanstack/router-devtools-core@7031

@tanstack/router-generator
npm i https://pkg.pr.new/@tanstack/router-generator@7031

@tanstack/router-plugin
npm i https://pkg.pr.new/@tanstack/router-plugin@7031

@tanstack/router-ssr-query-core
npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@7031

@tanstack/router-utils
npm i https://pkg.pr.new/@tanstack/router-utils@7031

@tanstack/router-vite-plugin
npm i https://pkg.pr.new/@tanstack/router-vite-plugin@7031

@tanstack/solid-router
npm i https://pkg.pr.new/@tanstack/solid-router@7031

@tanstack/solid-router-devtools
npm i https://pkg.pr.new/@tanstack/solid-router-devtools@7031

@tanstack/solid-router-ssr-query
npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@7031

@tanstack/solid-start
npm i https://pkg.pr.new/@tanstack/solid-start@7031

@tanstack/solid-start-client
npm i https://pkg.pr.new/@tanstack/solid-start-client@7031

@tanstack/solid-start-server
npm i https://pkg.pr.new/@tanstack/solid-start-server@7031

@tanstack/start-client-core
npm i https://pkg.pr.new/@tanstack/start-client-core@7031

@tanstack/start-fn-stubs
npm i https://pkg.pr.new/@tanstack/start-fn-stubs@7031

@tanstack/start-plugin-core
npm i https://pkg.pr.new/@tanstack/start-plugin-core@7031

@tanstack/start-server-core
npm i https://pkg.pr.new/@tanstack/start-server-core@7031

@tanstack/start-static-server-functions
npm i https://pkg.pr.new/@tanstack/start-static-server-functions@7031

@tanstack/start-storage-context
npm i https://pkg.pr.new/@tanstack/start-storage-context@7031

@tanstack/valibot-adapter
npm i https://pkg.pr.new/@tanstack/valibot-adapter@7031

@tanstack/virtual-file-routes
npm i https://pkg.pr.new/@tanstack/virtual-file-routes@7031

@tanstack/vue-router
npm i https://pkg.pr.new/@tanstack/vue-router@7031

@tanstack/vue-router-devtools
npm i https://pkg.pr.new/@tanstack/vue-router-devtools@7031

@tanstack/vue-router-ssr-query
npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@7031

@tanstack/vue-start
npm i https://pkg.pr.new/@tanstack/vue-start@7031

@tanstack/vue-start-client
npm i https://pkg.pr.new/@tanstack/vue-start-client@7031

@tanstack/vue-start-server
npm i https://pkg.pr.new/@tanstack/vue-start-server@7031

@tanstack/zod-adapter
npm i https://pkg.pr.new/@tanstack/zod-adapter@7031

commit: baa1c16
@codspeed-hq
codspeed-hqBot
commented
Mar 24, 2026

Copy link


Copy Markdown

Merging this PR will not alter performance
✅ 6 untouched benchmarks
Comparing feat-throwOnError (baa1c16) with main (ed9c43d)1
Open in CodSpeed
Footnotes
  1. No successful run was found on main (77ad792) during the generation of this report, so ed9c43d was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩
@Nandan1996
Nandan1996
commented
Mar 28, 2026

Copy link


Copy Markdown

Hi @schiller-manuel

should have added this comment on PR itself. can you take a look at this comment. when loaders run in async mode, the error might get swallowed as well.
#7002 (reply in thread)
@schiller-manuel
schiller-manuel
commented
Mar 28, 2026

Copy link


Copy Markdown

CollaboratorAuthor
probably needs another optional param to force sync preloading
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@SheraffSheraffAwaiting requested review from Sheraff

Assignees


No one assigned


Labels

package: router-core

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@schiller-manuel@Nandan1996