perf: optimize and test rewrite

[schiller-manuel]

Summary by CodeRabbit

• Tests

  • Added comprehensive test coverage for basepath rewriting and rewrite composition, including path restoration and case-handling validation.

• Refactor

  • Simplified basepath normalization logic and removed duplicated documentation.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: d0512992-4c70-4a31-ab1d-a366ea9b6ced

📥 Commits

Reviewing files that changed from the base of the PR and between 254cb88 and 090570f.

📒 Files selected for processing (2)

• packages/router-core/src/rewrite.ts
• packages/router-core/tests/rewrite.test.ts

---

📝 Walkthrough

Walkthrough

This PR refactors basepath rewriting logic to simplify case-sensitivity handling, removes duplicate doc-comments, and introduces comprehensive test coverage for rewrite helper functions including rewriteBasepath and composeRewrites.

Changes

Basepath rewriting refactor and tests

Layer / File(s)	Summary
Basepath normalization simplification packages/router-core/src/rewrite.ts	rewriteBasepath now derives the slash-suffixed variant directly from the normalized checkBasepath, eliminating separate conditional lowercasing. Three duplicate doc-comment lines are removed above composeRewrites, executeRewriteInput, and executeRewriteOutput.
Rewrite helpers test suite packages/router-core/tests/rewrite.test.ts	New Vitest suite validates that rewriteBasepath strips/restores basepath, handles root URLs, performs case-insensitive matching while preserving suffix casing, and that composeRewrites applies rewrites in correct order with proper url.pathname mutations.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Poem

🐰 A simpler basepath shines so bright,
Case-folding logic done just right,
Duplicate comments cleared away,
Tests ensure the code won't stray,
Router's foundation finds new might! 🚀

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'perf: optimize and test rewrite' accurately describes the main changes: simplifying the rewriteBasepath implementation for performance and adding comprehensive test coverage for rewrite functions.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch perf-rewrite

Warning

Review ran into problems

🔥 Problems

Stopped waiting for pipeline failures after 30000ms. One of your pipelines takes longer than our 30000ms fetch window to run, so review may not consider pipeline-failure results for inline comments if any failures occurred after the fetch window. Increase the timeout if you want to wait longer or run a @coderabbit review after the pipeline has finished.

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

🚀 Changeset Version Preview

No changeset entries found. Merging this PR will not cause a version bump for any packages.

[nx-cloud]

View your CI Pipeline Execution ↗ for commit 090570f

Command	Status	Duration	Result
nx affected --targets=test:eslint,test:unit,tes...	❌ Failed	8m 18s	View ↗
nx run-many --target=build --exclude=examples/*...	✅ Succeeded	2m 16s	View ↗

---

☁️ Nx Cloud last updated this comment at 2026-05-20 20:24:54 UTC

[github-actions]

Bundle Size Benchmarks

• Commit: dc63bb528635
• Measured at: 2026-05-20T20:14:16.046Z
• Baseline source: history:254cb8834ed1
• Dashboard: bundle-size history

Scenario	Current (gzip)	Delta vs baseline	Initial gzip	Raw	Brotli	Trend
react-router.minimal	87.32 KiB	-2 B (-0.00%)	87.19 KiB	274.17 KiB	75.91 KiB	███████████▁
react-router.full	90.86 KiB	+10 B (+0.01%)	90.73 KiB	285.68 KiB	78.94 KiB	▁▁▁▁▁▁▁▁▁▁▁█
solid-router.minimal	35.56 KiB	-2 B (-0.01%)	35.44 KiB	106.48 KiB	31.93 KiB	▁▁▁▁▁▁▁▁███▇
solid-router.full	40.27 KiB	+2 B (+0.00%)	40.14 KiB	120.69 KiB	36.19 KiB	▁▁▁▁▁▁▁▁▃▃▃█
vue-router.minimal	53.32 KiB	-10 B (-0.02%)	53.19 KiB	151.61 KiB	47.91 KiB	███████████▁
vue-router.full	58.44 KiB	-3 B (-0.01%)	58.31 KiB	167.79 KiB	52.36 KiB	███████████▁
react-start.minimal	102.01 KiB	-2 B (-0.00%)	101.88 KiB	322.62 KiB	88.15 KiB	▁▁▂▂▂▂▂▂███▆
react-start.deferred-hydration	103.08 KiB	0 B (0.00%)	102.20 KiB	324.26 KiB	89.20 KiB	▅▅▅
react-start.full	105.45 KiB	-1 B (-0.00%)	105.31 KiB	332.95 KiB	91.12 KiB	▃▃▁▁▁▁▁▁███▇
react-start.rsbuild.minimal	99.63 KiB	-6 B (-0.01%)	99.46 KiB	317.08 KiB	85.58 KiB	▆▆█████████▁
react-start.rsbuild.full	102.93 KiB	-4 B (-0.00%)	102.76 KiB	327.51 KiB	88.50 KiB	▅▅█████████▁
solid-start.minimal	49.68 KiB	-3 B (-0.01%)	49.56 KiB	152.61 KiB	43.87 KiB	▁▁▁▁▁▁▁▁███▇
solid-start.deferred-hydration	53.80 KiB	-7 B (-0.01%)	50.45 KiB	161.15 KiB	47.71 KiB	███▁
solid-start.full	55.45 KiB	-7 B (-0.01%)	55.33 KiB	169.51 KiB	48.75 KiB	▁▁▂▂▂▂▂▂███▆

Current gzip tracks all emitted client JS chunks. Initial gzip tracks only the entry/import graph. Trend sparkline is historical current gzip ending with this PR measurement; lower is better.

[pkg-pr-new]

More templates

• tanstack-router-react-example-authenticated-routes
• tanstack-router-react-example-authenticated-routes-firebase
• tanstack-router-react-example-basic
• tanstack-router-react-example-basic-default-search-params
• tanstack-router-react-example-basic-devtools-panel
• tanstack-router-react-example-basic-file-based
• tanstack-router-react-example-basic-non-nested-devtools
• tanstack-router-react-example-react-query
• tanstack-router-react-example-basic-react-query-file-based
• tanstack-router-react-example-basic-ssr-file-based
• tanstack-router-react-example-basic-ssr-streaming-file-based
• tanstack-router-react-example-basic-virtual-file-based
• tanstack-router-react-example-basic-virtual-inside-file-based
• tanstack-router-react-example-deferred-data
• tanstack-router-i18n-paraglide
• tanstack-router-react-example-kitchen-sink
• tanstack-router-react-example-kitchen-sink-file-based
• tanstack-router-react-example-kitchen-sink-react-query
• tanstack-router-react-example-kitchen-sink-react-query-file-based
• tanstack-router-react-example-large-file-based
• tanstack-router-react-example-location-masking
• tanstack-router-react-example-navigation-blocking
• tanstack-router-react-example-quickstart
• tanstack-router-react-example-quickstart-esbuild-file-based
• tanstack-router-react-example-quickstart-file-based
• tanstack-router-react-example-quickstart-rspack-file-based
• tanstack-router-react-example-quickstart-webpack-file-based
• router-monorepo-react-query
• router-mono-simple
• router-mono-simple-lazy
• tanstack-router-react-example-scroll-restoration
• tanstack-search-validator-adapters
• tanstack-start-example-bare
• tanstack-start-example-basic
• tanstack-start-example-basic-auth
• tanstack-router-react-example-basic-authjs
• tanstack-start-example-basic-cloudflare
• tanstack-start-example-basic-react-query
• tanstack-start-example-basic-static
• tanstack-start-bun-hosting
• tanstack-start-example-clerk-basic
• tanstack-start-example-convex-trellaux
• tanstack-start-example-counter
• tanstack-start-i18n-paraglide
• tanstack-start-example-large
• tanstack-start-example-material-ui
• tanstack-start-example-rscs
• tanstack-start-streaming-data-from-server-functions
• tanstack-start-example-supabase-basic
• tanstack-start-tailwind-v4
• tanstack-start-example-trellaux
• tanstack-start-example-workos
• tanstack-router-react-example-view-transitions
• tanstack-router-react-example-with-framer-motion
• tanstack-router-react-example-with-trpc
• tanstack-router-react-example-with-trpc-react-query
• tanstack-router-solid-example-authenticated-routes
• tanstack-router-solid-example-authenticated-routes-firebase
• tanstack-router-solid-example-basic
• tanstack-router-solid-example-basic-default-search-params
• tanstack-router-solid-example-basic-devtools-panel
• tanstack-router-solid-example-basic-file-based
• tanstack-router-solid-example-basic-non-nested-devtools
• tanstack-router-solid-example-basic-solid-query
• tanstack-router-solid-example-basic-solid-query-file-based
• tanstack-router-solid-example-basic-ssr-file-based
• tanstack-router-solid-example-basic-ssr-streaming-file-based
• tanstack-router-solid-example-basic-virtual-file-based
• tanstack-router-solid-example-basic-virtual-inside-file-based
• tanstack-router-solid-example-deferred-data
• tanstack-router-solid-i18n-paraglide
• tanstack-router-solid-example-kitchen-sink
• tanstack-router-solid-example-kitchen-sink-file-based
• tanstack-router-solid-example-kitchen-sink-solid-query
• tanstack-router-solid-example-kitchen-sink-solid-query-file-based
• tanstack-router-solid-example-large-file-based
• tanstack-router-solid-example-location-masking
• tanstack-router-solid-example-navigation-blocking
• tanstack-router-solid-example-quickstart
• tanstack-router-solid-example-quickstart-esbuild-file-based
• tanstack-router-solid-example-quickstart-file-based
• tanstack-router-solid-example-quickstart-rspack-file-based
• tanstack-router-solid-example-quickstart-webpack-file-based
• @tanstack/router-solid-mono-simple
• router-solid-mono-simple-lazy
• router-solid-monorepo-solid-query
• tanstack-router-solid-example-scroll-restoration
• tanstack-solid-router-search-validator-adapters
• tanstack-solid-start-example-basic
• tanstack-solid-start-example-basic-auth
• tanstack-solid-start-example-basic-authjs
• tanstack-solid-start-example-basic-cloudflare
• tanstack-solid-start-example-basic-netlify
• tanstack-solid-start-example-basic-nitro
• tanstack-start-example-basic-solid-query
• tanstack-solid-start-example-basic-static
• tanstack-solid-start-bun-hosting
• tanstack-solid-start-example-convex-better-auth
• tanstack-solid-start-example-counter
• tanstack-solid-start-i18n-paraglide
• tanstack-solid-start-example-large
• tanstack-solid-start-streaming-data-from-server-functions
• tanstack-solid-start-example-supabase-basic
• tanstack-solid-start-tailwind-v4
• tanstack-router-solid-example-view-transitions
• tanstack-router-solid-example-with-framer-motion
• tanstack-router-solid-example-with-trpc
• tanstack-router-vue-example-basic-jsx
• tanstack-router-vue-example-basic-file-based-jsx
• tanstack-router-vue-example-basic-file-based-sfc

@tanstack/arktype-adapter

npm i https://pkg.pr.new/@tanstack/arktype-adapter@7448

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@7448

@tanstack/eslint-plugin-start

npm i https://pkg.pr.new/@tanstack/eslint-plugin-start@7448

@tanstack/history

npm i https://pkg.pr.new/@tanstack/history@7448

@tanstack/nitro-v2-vite-plugin

npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@7448

@tanstack/react-router

npm i https://pkg.pr.new/@tanstack/react-router@7448

@tanstack/react-router-devtools

npm i https://pkg.pr.new/@tanstack/react-router-devtools@7448

@tanstack/react-router-ssr-query

npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@7448

@tanstack/react-start

npm i https://pkg.pr.new/@tanstack/react-start@7448

@tanstack/react-start-client

npm i https://pkg.pr.new/@tanstack/react-start-client@7448

@tanstack/react-start-rsc

npm i https://pkg.pr.new/@tanstack/react-start-rsc@7448

@tanstack/react-start-server

npm i https://pkg.pr.new/@tanstack/react-start-server@7448

@tanstack/router-cli

npm i https://pkg.pr.new/@tanstack/router-cli@7448

@tanstack/router-core

npm i https://pkg.pr.new/@tanstack/router-core@7448

@tanstack/router-devtools

npm i https://pkg.pr.new/@tanstack/router-devtools@7448

@tanstack/router-devtools-core

npm i https://pkg.pr.new/@tanstack/router-devtools-core@7448

@tanstack/router-generator

npm i https://pkg.pr.new/@tanstack/router-generator@7448

@tanstack/router-plugin

npm i https://pkg.pr.new/@tanstack/router-plugin@7448

@tanstack/router-ssr-query-core

npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@7448

@tanstack/router-utils

npm i https://pkg.pr.new/@tanstack/router-utils@7448

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/@tanstack/router-vite-plugin@7448

@tanstack/solid-router

npm i https://pkg.pr.new/@tanstack/solid-router@7448

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/@tanstack/solid-router-devtools@7448

@tanstack/solid-router-ssr-query

npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@7448

@tanstack/solid-start

npm i https://pkg.pr.new/@tanstack/solid-start@7448

@tanstack/solid-start-client

npm i https://pkg.pr.new/@tanstack/solid-start-client@7448

@tanstack/solid-start-server

npm i https://pkg.pr.new/@tanstack/solid-start-server@7448

@tanstack/start-client-core

npm i https://pkg.pr.new/@tanstack/start-client-core@7448

@tanstack/start-fn-stubs

npm i https://pkg.pr.new/@tanstack/start-fn-stubs@7448

@tanstack/start-plugin-core

npm i https://pkg.pr.new/@tanstack/start-plugin-core@7448

@tanstack/start-server-core

npm i https://pkg.pr.new/@tanstack/start-server-core@7448

@tanstack/start-static-server-functions

npm i https://pkg.pr.new/@tanstack/start-static-server-functions@7448

@tanstack/start-storage-context

npm i https://pkg.pr.new/@tanstack/start-storage-context@7448

@tanstack/valibot-adapter

npm i https://pkg.pr.new/@tanstack/valibot-adapter@7448

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/@tanstack/virtual-file-routes@7448

@tanstack/vue-router

npm i https://pkg.pr.new/@tanstack/vue-router@7448

@tanstack/vue-router-devtools

npm i https://pkg.pr.new/@tanstack/vue-router-devtools@7448

@tanstack/vue-router-ssr-query

npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@7448

@tanstack/vue-start

npm i https://pkg.pr.new/@tanstack/vue-start@7448

@tanstack/vue-start-client

npm i https://pkg.pr.new/@tanstack/vue-start-client@7448

@tanstack/vue-start-server

npm i https://pkg.pr.new/@tanstack/vue-start-server@7448

@tanstack/zod-adapter

npm i https://pkg.pr.new/@tanstack/zod-adapter@7448

commit: 090570f

[nx-cloud]

Nx Cloud has identified a possible root cause for your failed CI:

We investigated this failure and determined it is unrelated to the PR's changes. The Chromium headless shell crashed with a signal 11 (General Protection Fault) at the OS level — a browser infrastructure issue, not an application code regression. We recommend simply re-running the pipeline in a healthy environment.

No code changes were suggested for this issue.

Trigger a rerun:

View detailed reasoning on Nx Cloud ↗

_{🎓 Learn more about Self-Healing CI on nx.dev}

[codspeed-hq]

Merging this PR will not alter performance

✅ 5 untouched benchmarks
⏩ 1 skipped benchmark¹

---

_{Comparing perf-rewrite (090570f) with main (254cb88)}

Footnotes

1. 1 benchmark was skipped, so the baseline result was used instead. If it was deleted from the codebase, click here and archive it to remove it from the performance reports. ↩