Create file routes directly - #7970

Merged
Sheraff merged 5 commits into
mainfrom
codex/direct-create-file-route
Aug 6, 2026
Merged

Create file routes directly#7970
Sheraff merged 5 commits into
mainfrom
codex/direct-create-file-route

Conversation

@Sheraff

@SheraffSheraff commented Aug 5, 2026•
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Collaborator

What

  • have createFileRoute create the route directly in React, Solid, and Vue
  • keep the deprecated FileRoute class and its warning behavior intact
  • preserve isRoot = false for file routes
  • add mirrored factory/class behavior tests for all three frameworks

Why

The public factory only instantiated FileRoute to reuse its createRoute field while suppressing the class's deprecation warning. Creating the route directly removes that unnecessary class path from normal file-route bundles without changing the deprecated API.

Bundle impact

Prior isolated prototype measurements from the same main base:

  • react-router.minimal: -117 B raw, -40 B gzip, -20 B Brotli
  • solid-router.minimal: -117 B raw, -38 B gzip, +4 B Brotli

Measured for this PR head against the same base:

  • vue-router.minimal: -113 B raw, -49 B gzip, -42 B Brotli

Validation

  • React and Vue focused file-route unit tests
  • Solid full client/server unit suite (840 passed, 1 skipped; server suite 3 passed)
  • React, Solid, and Vue type tests
  • React, Solid, and Vue ESLint (0 errors; existing warnings only)
  • React, Solid, and Vue production builds

Summary by CodeRabbit

  • Bug Fixes

    • File-based route creation no longer produces an unexpected deprecation warning.
    • Routes created through the standard file-route API are correctly treated as non-root routes.
    • Direct use of the deprecated route API continues to display its warning.

  • Tests

    • Added coverage confirming route behavior and warning differences across React, Solid, and Vue integrations.

@coderabbitai

coderabbitaiBot commented Aug 5, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 9603c18d-53a1-46d1-b9d2-725ddfb0c08e

📥 Commits

Reviewing files that changed from the base of the PR and between d34c25f and abf9767.

📒 Files selected for processing (4)
  • .changeset/easy-zoos-greet.md
  • packages/react-router/src/fileRoute.ts
  • packages/solid-router/src/fileRoute.ts
  • packages/vue-router/src/fileRoute.ts
🚧 Files skipped from review as they are similar to previous changes (1)
  • packages/solid-router/src/fileRoute.ts
📝 Walkthrough

Walkthrough

createFileRoute now calls the shared route factory directly in the React, Solid, and Vue routers. It marks routes as non-root without warning. Direct FileRoute construction retains its deprecation warning. Tests cover both behaviors.

Changes

File route factory behavior

Layer / File(s)Summary
Direct shared factory integration
packages/{react,solid,vue}-router/src/fileRoute.ts, .changeset/easy-zoos-greet.md		createFileRoute uses the shared route factory and sets isRoot to false. The changeset marks patch releases for the three router packages.
Factory and warning behavior tests
packages/{react,solid,vue}-router/tests/fileRoute.test.ts		Tests verify non-root routes, warning suppression for createFileRoute, warning retention for direct FileRoute usage, and mock cleanup.

Estimated code review effort: 3 (Moderate) | ~20 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly and concisely describes the main change: creating file routes directly.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/direct-create-file-route

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actionsBot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

🚀 Changeset Version Preview

5 package(s) bumped directly, 18 bumped as dependents.

🟩 Patch bumps

PackageVersionReason
@tanstack/react-router1.170.20 → 1.170.21Changeset
@tanstack/router-core1.171.17 → 1.171.18Changeset
@tanstack/solid-router1.170.20 → 1.170.21Changeset
@tanstack/start-server-core1.169.20 → 1.169.21Changeset
@tanstack/vue-router1.170.19 → 1.170.20Changeset
@tanstack/react-start1.168.37 → 1.168.38Dependent
@tanstack/react-start-client1.168.18 → 1.168.19Dependent
@tanstack/react-start-rsc0.1.36 → 0.1.37Dependent
@tanstack/react-start-server1.167.25 → 1.167.26Dependent
@tanstack/router-cli1.167.23 → 1.167.24Dependent
@tanstack/router-generator1.167.23 → 1.167.24Dependent
@tanstack/router-plugin1.168.25 → 1.168.26Dependent
@tanstack/router-vite-plugin1.167.25 → 1.167.26Dependent
@tanstack/solid-start1.168.36 → 1.168.37Dependent
@tanstack/solid-start-client1.168.18 → 1.168.19Dependent
@tanstack/solid-start-server1.167.25 → 1.167.26Dependent
@tanstack/start-client-core1.170.16 → 1.170.17Dependent
@tanstack/start-plugin-core1.171.28 → 1.171.29Dependent
@tanstack/start-static-server-functions1.167.21 → 1.167.22Dependent
@tanstack/start-storage-context1.167.19 → 1.167.20Dependent
@tanstack/vue-start1.168.35 → 1.168.36Dependent
@tanstack/vue-start-client1.167.21 → 1.167.22Dependent
@tanstack/vue-start-server1.167.25 → 1.167.26Dependent

@nx-cloud

nx-cloudBot commented Aug 5, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

View your CI Pipeline Execution ↗ for commit abf9767

CommandStatusDurationResult
nx affected --targets=test:eslint,test:unit,tes...✅ Succeeded10m 30sView ↗
nx run-many --target=build --exclude=examples/*...✅ Succeeded1m 29sView ↗

☁️ Nx Cloud last updated this comment at 2026-08-06 11:13:14 UTC

@pkg-pr-new

pkg-pr-newBot commented Aug 5, 2026•
edited
Loading

Copy link
Copy Markdown
More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/@tanstack/arktype-adapter@7970

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@7970

@tanstack/eslint-plugin-start

npm i https://pkg.pr.new/@tanstack/eslint-plugin-start@7970

@tanstack/history

npm i https://pkg.pr.new/@tanstack/history@7970

@tanstack/nitro-v2-vite-plugin

npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@7970

@tanstack/react-router

npm i https://pkg.pr.new/@tanstack/react-router@7970

@tanstack/react-router-devtools

npm i https://pkg.pr.new/@tanstack/react-router-devtools@7970

@tanstack/react-router-ssr-query

npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@7970

@tanstack/react-start

npm i https://pkg.pr.new/@tanstack/react-start@7970

@tanstack/react-start-client

npm i https://pkg.pr.new/@tanstack/react-start-client@7970

@tanstack/react-start-rsc

npm i https://pkg.pr.new/@tanstack/react-start-rsc@7970

@tanstack/react-start-server

npm i https://pkg.pr.new/@tanstack/react-start-server@7970

@tanstack/router-cli

npm i https://pkg.pr.new/@tanstack/router-cli@7970

@tanstack/router-core

npm i https://pkg.pr.new/@tanstack/router-core@7970

@tanstack/router-devtools

npm i https://pkg.pr.new/@tanstack/router-devtools@7970

@tanstack/router-devtools-core

npm i https://pkg.pr.new/@tanstack/router-devtools-core@7970

@tanstack/router-generator

npm i https://pkg.pr.new/@tanstack/router-generator@7970

@tanstack/router-plugin

npm i https://pkg.pr.new/@tanstack/router-plugin@7970

@tanstack/router-ssr-query-core

npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@7970

@tanstack/router-utils

npm i https://pkg.pr.new/@tanstack/router-utils@7970

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/@tanstack/router-vite-plugin@7970

@tanstack/solid-router

npm i https://pkg.pr.new/@tanstack/solid-router@7970

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/@tanstack/solid-router-devtools@7970

@tanstack/solid-router-ssr-query

npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@7970

@tanstack/solid-start

npm i https://pkg.pr.new/@tanstack/solid-start@7970

@tanstack/solid-start-client

npm i https://pkg.pr.new/@tanstack/solid-start-client@7970

@tanstack/solid-start-server

npm i https://pkg.pr.new/@tanstack/solid-start-server@7970

@tanstack/start-client-core

npm i https://pkg.pr.new/@tanstack/start-client-core@7970

@tanstack/start-fn-stubs

npm i https://pkg.pr.new/@tanstack/start-fn-stubs@7970

@tanstack/start-plugin-core

npm i https://pkg.pr.new/@tanstack/start-plugin-core@7970

@tanstack/start-server-core

npm i https://pkg.pr.new/@tanstack/start-server-core@7970

@tanstack/start-static-server-functions

npm i https://pkg.pr.new/@tanstack/start-static-server-functions@7970

@tanstack/start-storage-context

npm i https://pkg.pr.new/@tanstack/start-storage-context@7970

@tanstack/valibot-adapter

npm i https://pkg.pr.new/@tanstack/valibot-adapter@7970

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/@tanstack/virtual-file-routes@7970

@tanstack/vue-router

npm i https://pkg.pr.new/@tanstack/vue-router@7970

@tanstack/vue-router-devtools

npm i https://pkg.pr.new/@tanstack/vue-router-devtools@7970

@tanstack/vue-router-ssr-query

npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@7970

@tanstack/vue-start

npm i https://pkg.pr.new/@tanstack/vue-start@7970

@tanstack/vue-start-client

npm i https://pkg.pr.new/@tanstack/vue-start-client@7970

@tanstack/vue-start-server

npm i https://pkg.pr.new/@tanstack/vue-start-server@7970

@tanstack/zod-adapter

npm i https://pkg.pr.new/@tanstack/zod-adapter@7970

commit: abf9767

@github-actions

github-actionsBot commented Aug 5, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

Bundle Size Benchmarks

  • Commit: c86f13a34b9a
  • Measured at: 2026-08-06T11:04:12.144Z
  • Baseline source: history:697ebb6ddbd4
  • Dashboard: bundle-size history

The following scenarios have bundle-size changes compared with the baseline:

ScenarioCurrent (gzip)Delta vs baselineInitial gzipRawBrotliTrend
react-router.minimal87.07 KiB-45 B (-0.05%)86.93 KiB269.02 KiB75.83 KiB████▂▂▂▂▂▁▂▁
react-router.full90.85 KiB-45 B (-0.05%)90.72 KiB280.97 KiB79.09 KiB████▃▃▃▃▃▂▂▁
solid-router.minimal34.76 KiB-38 B (-0.11%)34.63 KiB99.85 KiB31.33 KiB████▂▂▂▂▂▁▁▁
solid-router.full39.85 KiB-46 B (-0.11%)39.73 KiB115.03 KiB35.88 KiB████▂▂▂▂▂▁▁▁
vue-router.minimal52.05 KiB-48 B (-0.09%)51.92 KiB143.01 KiB46.83 KiB████▂▂▂▂▂▁▁▁
vue-router.full58.01 KiB-45 B (-0.08%)57.88 KiB161.68 KiB52.08 KiB████▂▂▂▂▂▁▁▁
react-start.minimal100.55 KiB-45 B (-0.04%)100.42 KiB312.17 KiB87.40 KiB███████▁▁▁▁▁
react-start.deferred-hydration101.29 KiB-47 B (-0.05%)100.44 KiB313.54 KiB87.99 KiB███████▁▁▁▁▁
react-start.full103.88 KiB-42 B (-0.04%)103.74 KiB322.12 KiB90.17 KiB███████▁▁▁▁▁
react-start.rsbuild.minimal100.21 KiB-30 B (-0.03%)100.04 KiB316.67 KiB86.35 KiB▁▁▁▁▂▂▂█████
react-start.rsbuild.minimal-iife100.61 KiB-36 B (-0.03%)100.44 KiB317.60 KiB86.75 KiB▁▁▁▁▂▂▂████▇
react-start.rsbuild.full103.52 KiB-46 B (-0.04%)103.35 KiB326.76 KiB89.11 KiB▁▁▁▁▃▃▃████▇
solid-start.minimal48.15 KiB-30 B (-0.06%)48.02 KiB141.99 KiB42.80 KiB███████▁▁▁▁▁
solid-start.deferred-hydration51.41 KiB-30 B (-0.06%)48.08 KiB150.03 KiB45.82 KiB███████▁▁▁▁▁
solid-start.full53.38 KiB-49 B (-0.09%)53.25 KiB157.72 KiB47.34 KiB████▆▆▆▁▁▁▁▁
vue-start.minimal68.94 KiB-36 B (-0.05%)68.81 KiB195.01 KiB61.33 KiB████▆▆▆▁▁▁▁▁
vue-start.full72.90 KiB-34 B (-0.05%)72.77 KiB207.51 KiB64.80 KiB████▆▆▆▁▁▁▁▁

Current gzip tracks all emitted client JS chunks. Initial gzip tracks only the entry/import graph. Trend sparkline is historical current gzip ending with this PR measurement; lower is better.

@codspeed-hq

codspeed-hqBot commented Aug 5, 2026•
edited
Loading

Copy link
Copy Markdown

Merging this PR will regress 0 benchmarks

⚠️Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 4 improved benchmarks
❌ 5 (👁 5) regressed benchmarks
✅ 171 untouched benchmarks

Performance Changes

ModeBenchmarkBASEHEADEfficiency
⚡Memorymem server server-fn-churn (vue)4,147.3 KB264.3 KB×16
⚡Memorymem server error-paths unmatched (vue)2,142.1 KB479 KB×4.5
⚡Memorymem server error-paths redirect (solid)388 KB283.1 KB+37.06%
⚡Memorymem client navigation-churn (vue)1.3 MB1.2 MB+3.81%
👁Simulationssr server-fn during document ssr (react)62.9 ms66.6 ms-5.62%
👁Memorymem server error-paths redirect (vue)338.6 KB422.4 KB-19.84%
👁Memorymem server error-paths not-found (react)277.7 KB287.1 KB-3.27%
👁Memorymem server error-paths unmatched (react)317.5 KB668.3 KB-52.49%
👁Memorymem server peak-large-page (react)1.7 MB2.2 MB-21.95%

Tip

Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.

Comparing codex/direct-create-file-route (abf9767) with main (697ebb6)

Open in CodSpeed

@Sheraff
Sheraff marked this pull request as ready for review August 6, 2026 06:59
coderabbitai[bot]
coderabbitaiBot reviewed Aug 6, 2026
View reviewed changes

@coderabbitaicoderabbitaiBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/react-router/src/fileRoute.ts`:
- Around line 60-65: Preserve the typed factory contract in createFileRoute by
replacing the wrapper’s options?: any and return createRoute as any with a
FileRoute<...>['createRoute']-compatible type, using one shared typed helper if
appropriate and retaining any unavoidable cast at a documented boundary. Apply
the same correction at packages/react-router/src/fileRoute.ts:60-65,
packages/solid-router/src/fileRoute.ts:49-54, and
packages/vue-router/src/fileRoute.ts:49-54; all three createRoute wrappers
require the change.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 14ac885f-fffc-41b1-807c-d6c3c7992d83

📥 Commits

Reviewing files that changed from the base of the PR and between 697ebb6 and d34c25f.

📒 Files selected for processing (6)
  • packages/react-router/src/fileRoute.ts
  • packages/react-router/tests/fileRoute.test.ts
  • packages/solid-router/src/fileRoute.ts
  • packages/solid-router/tests/fileRoute.test.ts
  • packages/vue-router/src/fileRoute.ts
  • packages/vue-router/tests/fileRoute.test.ts

Comment threadpackages/react-router/src/fileRoute.ts Outdated
@Sheraff
Sheraff merged commit 2435885 into mainAug 6, 2026
26 checks passed
@Sheraff
Sheraff deleted the codex/direct-create-file-route branch August 6, 2026 11:38
@github-actionsgithub-actionsBot mentioned this pull request Aug 6, 2026
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitaicoderabbitai[bot]coderabbitai[bot] left review comments

Assignees

No one assigned

Labels

package: react-routerpackage: solid-routerpackage: vue-router

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Sheraff
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Create file routes directly - #7970
Merged
Sheraff merged 5 commits into
mainfrom 
codex/direct-create-file-route
Aug 6, 2026
Merged
Create file routes directly#7970
Sheraff merged 5 commits into
mainfrom 
codex/direct-create-file-route
Conversation
@Sheraff
@SheraffSheraff
commented
Aug 5, 2026•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Collaborator
What
  • have createFileRoute create the route directly in React, Solid, and Vue
  • keep the deprecated FileRoute class and its warning behavior intact
  • preserve isRoot = false for file routes
  • add mirrored factory/class behavior tests for all three frameworks
Why
The public factory only instantiated FileRoute to reuse its createRoute field while suppressing the class's deprecation warning. Creating the route directly removes that unnecessary class path from normal file-route bundles without changing the deprecated API.
Bundle impact
Prior isolated prototype measurements from the same main base:
  • react-router.minimal: -117 B raw, -40 B gzip, -20 B Brotli
  • solid-router.minimal: -117 B raw, -38 B gzip, +4 B Brotli
Measured for this PR head against the same base:
  • vue-router.minimal: -113 B raw, -49 B gzip, -42 B Brotli
Validation
  • React and Vue focused file-route unit tests
  • Solid full client/server unit suite (840 passed, 1 skipped; server suite 3 passed)
  • React, Solid, and Vue type tests
  • React, Solid, and Vue ESLint (0 errors; existing warnings only)
  • React, Solid, and Vue production builds
Summary by CodeRabbit
  • Bug Fixes
    • File-based route creation no longer produces an unexpected deprecation warning.
    • Routes created through the standard file-route API are correctly treated as non-root routes.
    • Direct use of the deprecated route API continues to display its warning.
  • Tests
    • Added coverage confirming route behavior and warning differences across React, Solid, and Vue integrations.
@coderabbitai
coderabbitaiBot
commented
Aug 5, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Review Change Stack
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 9603c18d-53a1-46d1-b9d2-725ddfb0c08e
📥 Commits
Reviewing files that changed from the base of the PR and between d34c25f and abf9767.
📒 Files selected for processing (4)
  • .changeset/easy-zoos-greet.md
  • packages/react-router/src/fileRoute.ts
  • packages/solid-router/src/fileRoute.ts
  • packages/vue-router/src/fileRoute.ts
🚧 Files skipped from review as they are similar to previous changes (1)
  • packages/solid-router/src/fileRoute.ts
📝 Walkthrough
Walkthrough
createFileRoute now calls the shared route factory directly in the React, Solid, and Vue routers. It marks routes as non-root without warning. Direct FileRoute construction retains its deprecation warning. Tests cover both behaviors.
Changes
File route factory behavior
Layer / File(s)Summary
Direct shared factory integration
packages/{react,solid,vue}-router/src/fileRoute.ts, .changeset/easy-zoos-greet.md		createFileRoute uses the shared route factory and sets isRoot to false. The changeset marks patch releases for the three router packages.
Factory and warning behavior tests
packages/{react,solid,vue}-router/tests/fileRoute.test.ts		Tests verify non-root routes, warning suppression for createFileRoute, warning retention for direct FileRoute usage, and mock cleanup.
Estimated code review effort: 3 (Moderate) | ~20 minutes
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly and concisely describes the main change: creating file routes directly.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  •  Create stacked PR
  •  Commit on current branch
🧪 Generate unit tests (beta)
  •  Create PR with unit tests
  •  Commit unit tests in branch codex/direct-create-file-route
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands.
@github-actions
github-actionsBot
commented
Aug 5, 2026

Copy link


Copy Markdown

Contributor
🚀 Changeset Version Preview
5 package(s) bumped directly, 18 bumped as dependents.
🟩 Patch bumps
PackageVersionReason
@tanstack/react-router1.170.20 → 1.170.21Changeset
@tanstack/router-core1.171.17 → 1.171.18Changeset
@tanstack/solid-router1.170.20 → 1.170.21Changeset
@tanstack/start-server-core1.169.20 → 1.169.21Changeset
@tanstack/vue-router1.170.19 → 1.170.20Changeset
@tanstack/react-start1.168.37 → 1.168.38Dependent
@tanstack/react-start-client1.168.18 → 1.168.19Dependent
@tanstack/react-start-rsc0.1.36 → 0.1.37Dependent
@tanstack/react-start-server1.167.25 → 1.167.26Dependent
@tanstack/router-cli1.167.23 → 1.167.24Dependent
@tanstack/router-generator1.167.23 → 1.167.24Dependent
@tanstack/router-plugin1.168.25 → 1.168.26Dependent
@tanstack/router-vite-plugin1.167.25 → 1.167.26Dependent
@tanstack/solid-start1.168.36 → 1.168.37Dependent
@tanstack/solid-start-client1.168.18 → 1.168.19Dependent
@tanstack/solid-start-server1.167.25 → 1.167.26Dependent
@tanstack/start-client-core1.170.16 → 1.170.17Dependent
@tanstack/start-plugin-core1.171.28 → 1.171.29Dependent
@tanstack/start-static-server-functions1.167.21 → 1.167.22Dependent
@tanstack/start-storage-context1.167.19 → 1.167.20Dependent
@tanstack/vue-start1.168.35 → 1.168.36Dependent
@tanstack/vue-start-client1.167.21 → 1.167.22Dependent
@tanstack/vue-start-server1.167.25 → 1.167.26Dependent
@nx-cloud
nx-cloudBot
commented
Aug 5, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
View your CI Pipeline Execution ↗ for commit abf9767
CommandStatusDurationResult
nx affected --targets=test:eslint,test:unit,tes...✅ Succeeded10m 30sView ↗
nx run-many --target=build --exclude=examples/*...✅ Succeeded1m 29sView ↗
☁️ Nx Cloud last updated this comment at 2026-08-06 11:13:14 UTC
@pkg-pr-new
pkg-pr-newBot
commented
Aug 5, 2026•

edited

Loading

Copy link


Copy Markdown

More templates
@tanstack/arktype-adapter
npm i https://pkg.pr.new/@tanstack/arktype-adapter@7970

@tanstack/eslint-plugin-router
npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@7970

@tanstack/eslint-plugin-start
npm i https://pkg.pr.new/@tanstack/eslint-plugin-start@7970

@tanstack/history
npm i https://pkg.pr.new/@tanstack/history@7970

@tanstack/nitro-v2-vite-plugin
npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@7970

@tanstack/react-router
npm i https://pkg.pr.new/@tanstack/react-router@7970

@tanstack/react-router-devtools
npm i https://pkg.pr.new/@tanstack/react-router-devtools@7970

@tanstack/react-router-ssr-query
npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@7970

@tanstack/react-start
npm i https://pkg.pr.new/@tanstack/react-start@7970

@tanstack/react-start-client
npm i https://pkg.pr.new/@tanstack/react-start-client@7970

@tanstack/react-start-rsc
npm i https://pkg.pr.new/@tanstack/react-start-rsc@7970

@tanstack/react-start-server
npm i https://pkg.pr.new/@tanstack/react-start-server@7970

@tanstack/router-cli
npm i https://pkg.pr.new/@tanstack/router-cli@7970

@tanstack/router-core
npm i https://pkg.pr.new/@tanstack/router-core@7970

@tanstack/router-devtools
npm i https://pkg.pr.new/@tanstack/router-devtools@7970

@tanstack/router-devtools-core
npm i https://pkg.pr.new/@tanstack/router-devtools-core@7970

@tanstack/router-generator
npm i https://pkg.pr.new/@tanstack/router-generator@7970

@tanstack/router-plugin
npm i https://pkg.pr.new/@tanstack/router-plugin@7970

@tanstack/router-ssr-query-core
npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@7970

@tanstack/router-utils
npm i https://pkg.pr.new/@tanstack/router-utils@7970

@tanstack/router-vite-plugin
npm i https://pkg.pr.new/@tanstack/router-vite-plugin@7970

@tanstack/solid-router
npm i https://pkg.pr.new/@tanstack/solid-router@7970

@tanstack/solid-router-devtools
npm i https://pkg.pr.new/@tanstack/solid-router-devtools@7970

@tanstack/solid-router-ssr-query
npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@7970

@tanstack/solid-start
npm i https://pkg.pr.new/@tanstack/solid-start@7970

@tanstack/solid-start-client
npm i https://pkg.pr.new/@tanstack/solid-start-client@7970

@tanstack/solid-start-server
npm i https://pkg.pr.new/@tanstack/solid-start-server@7970

@tanstack/start-client-core
npm i https://pkg.pr.new/@tanstack/start-client-core@7970

@tanstack/start-fn-stubs
npm i https://pkg.pr.new/@tanstack/start-fn-stubs@7970

@tanstack/start-plugin-core
npm i https://pkg.pr.new/@tanstack/start-plugin-core@7970

@tanstack/start-server-core
npm i https://pkg.pr.new/@tanstack/start-server-core@7970

@tanstack/start-static-server-functions
npm i https://pkg.pr.new/@tanstack/start-static-server-functions@7970

@tanstack/start-storage-context
npm i https://pkg.pr.new/@tanstack/start-storage-context@7970

@tanstack/valibot-adapter
npm i https://pkg.pr.new/@tanstack/valibot-adapter@7970

@tanstack/virtual-file-routes
npm i https://pkg.pr.new/@tanstack/virtual-file-routes@7970

@tanstack/vue-router
npm i https://pkg.pr.new/@tanstack/vue-router@7970

@tanstack/vue-router-devtools
npm i https://pkg.pr.new/@tanstack/vue-router-devtools@7970

@tanstack/vue-router-ssr-query
npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@7970

@tanstack/vue-start
npm i https://pkg.pr.new/@tanstack/vue-start@7970

@tanstack/vue-start-client
npm i https://pkg.pr.new/@tanstack/vue-start-client@7970

@tanstack/vue-start-server
npm i https://pkg.pr.new/@tanstack/vue-start-server@7970

@tanstack/zod-adapter
npm i https://pkg.pr.new/@tanstack/zod-adapter@7970

commit: abf9767
@github-actions
github-actionsBot
commented
Aug 5, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Bundle Size Benchmarks
  • Commit: c86f13a34b9a
  • Measured at: 2026-08-06T11:04:12.144Z
  • Baseline source: history:697ebb6ddbd4
  • Dashboard: bundle-size history
The following scenarios have bundle-size changes compared with the baseline:
ScenarioCurrent (gzip)Delta vs baselineInitial gzipRawBrotliTrend
react-router.minimal87.07 KiB-45 B (-0.05%)86.93 KiB269.02 KiB75.83 KiB████▂▂▂▂▂▁▂▁
react-router.full90.85 KiB-45 B (-0.05%)90.72 KiB280.97 KiB79.09 KiB████▃▃▃▃▃▂▂▁
solid-router.minimal34.76 KiB-38 B (-0.11%)34.63 KiB99.85 KiB31.33 KiB████▂▂▂▂▂▁▁▁
solid-router.full39.85 KiB-46 B (-0.11%)39.73 KiB115.03 KiB35.88 KiB████▂▂▂▂▂▁▁▁
vue-router.minimal52.05 KiB-48 B (-0.09%)51.92 KiB143.01 KiB46.83 KiB████▂▂▂▂▂▁▁▁
vue-router.full58.01 KiB-45 B (-0.08%)57.88 KiB161.68 KiB52.08 KiB████▂▂▂▂▂▁▁▁
react-start.minimal100.55 KiB-45 B (-0.04%)100.42 KiB312.17 KiB87.40 KiB███████▁▁▁▁▁
react-start.deferred-hydration101.29 KiB-47 B (-0.05%)100.44 KiB313.54 KiB87.99 KiB███████▁▁▁▁▁
react-start.full103.88 KiB-42 B (-0.04%)103.74 KiB322.12 KiB90.17 KiB███████▁▁▁▁▁
react-start.rsbuild.minimal100.21 KiB-30 B (-0.03%)100.04 KiB316.67 KiB86.35 KiB▁▁▁▁▂▂▂█████
react-start.rsbuild.minimal-iife100.61 KiB-36 B (-0.03%)100.44 KiB317.60 KiB86.75 KiB▁▁▁▁▂▂▂████▇
react-start.rsbuild.full103.52 KiB-46 B (-0.04%)103.35 KiB326.76 KiB89.11 KiB▁▁▁▁▃▃▃████▇
solid-start.minimal48.15 KiB-30 B (-0.06%)48.02 KiB141.99 KiB42.80 KiB███████▁▁▁▁▁
solid-start.deferred-hydration51.41 KiB-30 B (-0.06%)48.08 KiB150.03 KiB45.82 KiB███████▁▁▁▁▁
solid-start.full53.38 KiB-49 B (-0.09%)53.25 KiB157.72 KiB47.34 KiB████▆▆▆▁▁▁▁▁
vue-start.minimal68.94 KiB-36 B (-0.05%)68.81 KiB195.01 KiB61.33 KiB████▆▆▆▁▁▁▁▁
vue-start.full72.90 KiB-34 B (-0.05%)72.77 KiB207.51 KiB64.80 KiB████▆▆▆▁▁▁▁▁
Current gzip tracks all emitted client JS chunks. Initial gzip tracks only the entry/import graph. Trend sparkline is historical current gzip ending with this PR measurement; lower is better.
@codspeed-hq
codspeed-hqBot
commented
Aug 5, 2026•

edited

Loading

Copy link


Copy Markdown

Merging this PR will regress 0 benchmarks
⚠️Different runtime environments detected
Some benchmarks with significant performance changes were compared across different runtime environments,

which may affect the accuracy of the results.
Open the report in CodSpeed to investigate
⚡ 4 improved benchmarks
❌ 5 (👁 5) regressed benchmarks
✅ 171 untouched benchmarks
Performance Changes
ModeBenchmarkBASEHEADEfficiency
⚡Memorymem server server-fn-churn (vue)4,147.3 KB264.3 KB×16
⚡Memorymem server error-paths unmatched (vue)2,142.1 KB479 KB×4.5
⚡Memorymem server error-paths redirect (solid)388 KB283.1 KB+37.06%
⚡Memorymem client navigation-churn (vue)1.3 MB1.2 MB+3.81%
👁Simulationssr server-fn during document ssr (react)62.9 ms66.6 ms-5.62%
👁Memorymem server error-paths redirect (vue)338.6 KB422.4 KB-19.84%
👁Memorymem server error-paths not-found (react)277.7 KB287.1 KB-3.27%
👁Memorymem server error-paths unmatched (react)317.5 KB668.3 KB-52.49%
👁Memorymem server peak-large-page (react)1.7 MB2.2 MB-21.95%
Tip
Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.
Comparing codex/direct-create-file-route (abf9767) with main (697ebb6)
Open in CodSpeed
@Sheraff
Sheraff
marked this pull request as ready for review
August 6, 2026 06:59
coderabbitai[bot]
coderabbitaiBot
reviewed
Aug 6, 2026
View reviewed changes
@coderabbitaicoderabbitaiBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/react-router/src/fileRoute.ts`:
- Around line 60-65: Preserve the typed factory contract in createFileRoute by
replacing the wrapper’s options?: any and return createRoute as any with a
FileRoute<...>['createRoute']-compatible type, using one shared typed helper if
appropriate and retaining any unavoidable cast at a documented boundary. Apply
the same correction at packages/react-router/src/fileRoute.ts:60-65,
packages/solid-router/src/fileRoute.ts:49-54, and
packages/vue-router/src/fileRoute.ts:49-54; all three createRoute wrappers
require the change.

🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
  •  Push a commit to this branch (recommended)
  •  Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 14ac885f-fffc-41b1-807c-d6c3c7992d83
📥 Commits
Reviewing files that changed from the base of the PR and between 697ebb6 and d34c25f.
📒 Files selected for processing (6)
  • packages/react-router/src/fileRoute.ts
  • packages/react-router/tests/fileRoute.test.ts
  • packages/solid-router/src/fileRoute.ts
  • packages/solid-router/tests/fileRoute.test.ts
  • packages/vue-router/src/fileRoute.ts
  • packages/vue-router/tests/fileRoute.test.ts
Comment threadpackages/react-router/src/fileRoute.ts
Outdated

@Sheraff
Sheraff
merged commit 2435885
into
mainAug 6, 2026

26 checks passed

@Sheraff
Sheraff
deleted the

codex/direct-create-file-route

branch
August 6, 2026 11:38
@github-actionsgithub-actionsBot
mentioned this pull request
Aug 6, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@coderabbitaicoderabbitai[bot]coderabbitai[bot] left review comments

Assignees


No one assigned


Labels

package: react-routerpackage: solid-routerpackage: vue-router

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@Sheraff

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Create file routes directly - #7970
Merged
Sheraff merged 5 commits into
mainfrom 
codex/direct-create-file-route
Aug 6, 2026
Merged
Create file routes directly#7970
Sheraff merged 5 commits into
mainfrom 
codex/direct-create-file-route
Conversation
@Sheraff
@SheraffSheraff
commented
Aug 5, 2026•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Collaborator
What
  • have createFileRoute create the route directly in React, Solid, and Vue
  • keep the deprecated FileRoute class and its warning behavior intact
  • preserve isRoot = false for file routes
  • add mirrored factory/class behavior tests for all three frameworks
Why
The public factory only instantiated FileRoute to reuse its createRoute field while suppressing the class's deprecation warning. Creating the route directly removes that unnecessary class path from normal file-route bundles without changing the deprecated API.
Bundle impact
Prior isolated prototype measurements from the same main base:
  • react-router.minimal: -117 B raw, -40 B gzip, -20 B Brotli
  • solid-router.minimal: -117 B raw, -38 B gzip, +4 B Brotli
Measured for this PR head against the same base:
  • vue-router.minimal: -113 B raw, -49 B gzip, -42 B Brotli
Validation
  • React and Vue focused file-route unit tests
  • Solid full client/server unit suite (840 passed, 1 skipped; server suite 3 passed)
  • React, Solid, and Vue type tests
  • React, Solid, and Vue ESLint (0 errors; existing warnings only)
  • React, Solid, and Vue production builds
Summary by CodeRabbit
  • Bug Fixes
    • File-based route creation no longer produces an unexpected deprecation warning.
    • Routes created through the standard file-route API are correctly treated as non-root routes.
    • Direct use of the deprecated route API continues to display its warning.
  • Tests
    • Added coverage confirming route behavior and warning differences across React, Solid, and Vue integrations.
@coderabbitai
coderabbitaiBot
commented
Aug 5, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Review Change Stack
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 9603c18d-53a1-46d1-b9d2-725ddfb0c08e
📥 Commits
Reviewing files that changed from the base of the PR and between d34c25f and abf9767.
📒 Files selected for processing (4)
  • .changeset/easy-zoos-greet.md
  • packages/react-router/src/fileRoute.ts
  • packages/solid-router/src/fileRoute.ts
  • packages/vue-router/src/fileRoute.ts
🚧 Files skipped from review as they are similar to previous changes (1)
  • packages/solid-router/src/fileRoute.ts
📝 Walkthrough
Walkthrough
createFileRoute now calls the shared route factory directly in the React, Solid, and Vue routers. It marks routes as non-root without warning. Direct FileRoute construction retains its deprecation warning. Tests cover both behaviors.
Changes
File route factory behavior
Layer / File(s)Summary
Direct shared factory integration
packages/{react,solid,vue}-router/src/fileRoute.ts, .changeset/easy-zoos-greet.md		createFileRoute uses the shared route factory and sets isRoot to false. The changeset marks patch releases for the three router packages.
Factory and warning behavior tests
packages/{react,solid,vue}-router/tests/fileRoute.test.ts		Tests verify non-root routes, warning suppression for createFileRoute, warning retention for direct FileRoute usage, and mock cleanup.
Estimated code review effort: 3 (Moderate) | ~20 minutes
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly and concisely describes the main change: creating file routes directly.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  •  Create stacked PR
  •  Commit on current branch
🧪 Generate unit tests (beta)
  •  Create PR with unit tests
  •  Commit unit tests in branch codex/direct-create-file-route
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands.
@github-actions
github-actionsBot
commented
Aug 5, 2026

Copy link


Copy Markdown

Contributor
🚀 Changeset Version Preview
5 package(s) bumped directly, 18 bumped as dependents.
🟩 Patch bumps
PackageVersionReason
@tanstack/react-router1.170.20 → 1.170.21Changeset
@tanstack/router-core1.171.17 → 1.171.18Changeset
@tanstack/solid-router1.170.20 → 1.170.21Changeset
@tanstack/start-server-core1.169.20 → 1.169.21Changeset
@tanstack/vue-router1.170.19 → 1.170.20Changeset
@tanstack/react-start1.168.37 → 1.168.38Dependent
@tanstack/react-start-client1.168.18 → 1.168.19Dependent
@tanstack/react-start-rsc0.1.36 → 0.1.37Dependent
@tanstack/react-start-server1.167.25 → 1.167.26Dependent
@tanstack/router-cli1.167.23 → 1.167.24Dependent
@tanstack/router-generator1.167.23 → 1.167.24Dependent
@tanstack/router-plugin1.168.25 → 1.168.26Dependent
@tanstack/router-vite-plugin1.167.25 → 1.167.26Dependent
@tanstack/solid-start1.168.36 → 1.168.37Dependent
@tanstack/solid-start-client1.168.18 → 1.168.19Dependent
@tanstack/solid-start-server1.167.25 → 1.167.26Dependent
@tanstack/start-client-core1.170.16 → 1.170.17Dependent
@tanstack/start-plugin-core1.171.28 → 1.171.29Dependent
@tanstack/start-static-server-functions1.167.21 → 1.167.22Dependent
@tanstack/start-storage-context1.167.19 → 1.167.20Dependent
@tanstack/vue-start1.168.35 → 1.168.36Dependent
@tanstack/vue-start-client1.167.21 → 1.167.22Dependent
@tanstack/vue-start-server1.167.25 → 1.167.26Dependent
@nx-cloud
nx-cloudBot
commented
Aug 5, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
View your CI Pipeline Execution ↗ for commit abf9767
CommandStatusDurationResult
nx affected --targets=test:eslint,test:unit,tes...✅ Succeeded10m 30sView ↗
nx run-many --target=build --exclude=examples/*...✅ Succeeded1m 29sView ↗
☁️ Nx Cloud last updated this comment at 2026-08-06 11:13:14 UTC
@pkg-pr-new
pkg-pr-newBot
commented
Aug 5, 2026•

edited

Loading

Copy link


Copy Markdown

More templates
@tanstack/arktype-adapter
npm i https://pkg.pr.new/@tanstack/arktype-adapter@7970

@tanstack/eslint-plugin-router
npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@7970

@tanstack/eslint-plugin-start
npm i https://pkg.pr.new/@tanstack/eslint-plugin-start@7970

@tanstack/history
npm i https://pkg.pr.new/@tanstack/history@7970

@tanstack/nitro-v2-vite-plugin
npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@7970

@tanstack/react-router
npm i https://pkg.pr.new/@tanstack/react-router@7970

@tanstack/react-router-devtools
npm i https://pkg.pr.new/@tanstack/react-router-devtools@7970

@tanstack/react-router-ssr-query
npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@7970

@tanstack/react-start
npm i https://pkg.pr.new/@tanstack/react-start@7970

@tanstack/react-start-client
npm i https://pkg.pr.new/@tanstack/react-start-client@7970

@tanstack/react-start-rsc
npm i https://pkg.pr.new/@tanstack/react-start-rsc@7970

@tanstack/react-start-server
npm i https://pkg.pr.new/@tanstack/react-start-server@7970

@tanstack/router-cli
npm i https://pkg.pr.new/@tanstack/router-cli@7970

@tanstack/router-core
npm i https://pkg.pr.new/@tanstack/router-core@7970

@tanstack/router-devtools
npm i https://pkg.pr.new/@tanstack/router-devtools@7970

@tanstack/router-devtools-core
npm i https://pkg.pr.new/@tanstack/router-devtools-core@7970

@tanstack/router-generator
npm i https://pkg.pr.new/@tanstack/router-generator@7970

@tanstack/router-plugin
npm i https://pkg.pr.new/@tanstack/router-plugin@7970

@tanstack/router-ssr-query-core
npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@7970

@tanstack/router-utils
npm i https://pkg.pr.new/@tanstack/router-utils@7970

@tanstack/router-vite-plugin
npm i https://pkg.pr.new/@tanstack/router-vite-plugin@7970

@tanstack/solid-router
npm i https://pkg.pr.new/@tanstack/solid-router@7970

@tanstack/solid-router-devtools
npm i https://pkg.pr.new/@tanstack/solid-router-devtools@7970

@tanstack/solid-router-ssr-query
npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@7970

@tanstack/solid-start
npm i https://pkg.pr.new/@tanstack/solid-start@7970

@tanstack/solid-start-client
npm i https://pkg.pr.new/@tanstack/solid-start-client@7970

@tanstack/solid-start-server
npm i https://pkg.pr.new/@tanstack/solid-start-server@7970

@tanstack/start-client-core
npm i https://pkg.pr.new/@tanstack/start-client-core@7970

@tanstack/start-fn-stubs
npm i https://pkg.pr.new/@tanstack/start-fn-stubs@7970

@tanstack/start-plugin-core
npm i https://pkg.pr.new/@tanstack/start-plugin-core@7970

@tanstack/start-server-core
npm i https://pkg.pr.new/@tanstack/start-server-core@7970

@tanstack/start-static-server-functions
npm i https://pkg.pr.new/@tanstack/start-static-server-functions@7970

@tanstack/start-storage-context
npm i https://pkg.pr.new/@tanstack/start-storage-context@7970

@tanstack/valibot-adapter
npm i https://pkg.pr.new/@tanstack/valibot-adapter@7970

@tanstack/virtual-file-routes
npm i https://pkg.pr.new/@tanstack/virtual-file-routes@7970

@tanstack/vue-router
npm i https://pkg.pr.new/@tanstack/vue-router@7970

@tanstack/vue-router-devtools
npm i https://pkg.pr.new/@tanstack/vue-router-devtools@7970

@tanstack/vue-router-ssr-query
npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@7970

@tanstack/vue-start
npm i https://pkg.pr.new/@tanstack/vue-start@7970

@tanstack/vue-start-client
npm i https://pkg.pr.new/@tanstack/vue-start-client@7970

@tanstack/vue-start-server
npm i https://pkg.pr.new/@tanstack/vue-start-server@7970

@tanstack/zod-adapter
npm i https://pkg.pr.new/@tanstack/zod-adapter@7970

commit: abf9767
@github-actions
github-actionsBot
commented
Aug 5, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Bundle Size Benchmarks
  • Commit: c86f13a34b9a
  • Measured at: 2026-08-06T11:04:12.144Z
  • Baseline source: history:697ebb6ddbd4
  • Dashboard: bundle-size history
The following scenarios have bundle-size changes compared with the baseline:
ScenarioCurrent (gzip)Delta vs baselineInitial gzipRawBrotliTrend
react-router.minimal87.07 KiB-45 B (-0.05%)86.93 KiB269.02 KiB75.83 KiB████▂▂▂▂▂▁▂▁
react-router.full90.85 KiB-45 B (-0.05%)90.72 KiB280.97 KiB79.09 KiB████▃▃▃▃▃▂▂▁
solid-router.minimal34.76 KiB-38 B (-0.11%)34.63 KiB99.85 KiB31.33 KiB████▂▂▂▂▂▁▁▁
solid-router.full39.85 KiB-46 B (-0.11%)39.73 KiB115.03 KiB35.88 KiB████▂▂▂▂▂▁▁▁
vue-router.minimal52.05 KiB-48 B (-0.09%)51.92 KiB143.01 KiB46.83 KiB████▂▂▂▂▂▁▁▁
vue-router.full58.01 KiB-45 B (-0.08%)57.88 KiB161.68 KiB52.08 KiB████▂▂▂▂▂▁▁▁
react-start.minimal100.55 KiB-45 B (-0.04%)100.42 KiB312.17 KiB87.40 KiB███████▁▁▁▁▁
react-start.deferred-hydration101.29 KiB-47 B (-0.05%)100.44 KiB313.54 KiB87.99 KiB███████▁▁▁▁▁
react-start.full103.88 KiB-42 B (-0.04%)103.74 KiB322.12 KiB90.17 KiB███████▁▁▁▁▁
react-start.rsbuild.minimal100.21 KiB-30 B (-0.03%)100.04 KiB316.67 KiB86.35 KiB▁▁▁▁▂▂▂█████
react-start.rsbuild.minimal-iife100.61 KiB-36 B (-0.03%)100.44 KiB317.60 KiB86.75 KiB▁▁▁▁▂▂▂████▇
react-start.rsbuild.full103.52 KiB-46 B (-0.04%)103.35 KiB326.76 KiB89.11 KiB▁▁▁▁▃▃▃████▇
solid-start.minimal48.15 KiB-30 B (-0.06%)48.02 KiB141.99 KiB42.80 KiB███████▁▁▁▁▁
solid-start.deferred-hydration51.41 KiB-30 B (-0.06%)48.08 KiB150.03 KiB45.82 KiB███████▁▁▁▁▁
solid-start.full53.38 KiB-49 B (-0.09%)53.25 KiB157.72 KiB47.34 KiB████▆▆▆▁▁▁▁▁
vue-start.minimal68.94 KiB-36 B (-0.05%)68.81 KiB195.01 KiB61.33 KiB████▆▆▆▁▁▁▁▁
vue-start.full72.90 KiB-34 B (-0.05%)72.77 KiB207.51 KiB64.80 KiB████▆▆▆▁▁▁▁▁
Current gzip tracks all emitted client JS chunks. Initial gzip tracks only the entry/import graph. Trend sparkline is historical current gzip ending with this PR measurement; lower is better.
@codspeed-hq
codspeed-hqBot
commented
Aug 5, 2026•

edited

Loading

Copy link


Copy Markdown

Merging this PR will regress 0 benchmarks
⚠️Different runtime environments detected
Some benchmarks with significant performance changes were compared across different runtime environments,

which may affect the accuracy of the results.
Open the report in CodSpeed to investigate
⚡ 4 improved benchmarks
❌ 5 (👁 5) regressed benchmarks
✅ 171 untouched benchmarks
Performance Changes
ModeBenchmarkBASEHEADEfficiency
⚡Memorymem server server-fn-churn (vue)4,147.3 KB264.3 KB×16
⚡Memorymem server error-paths unmatched (vue)2,142.1 KB479 KB×4.5
⚡Memorymem server error-paths redirect (solid)388 KB283.1 KB+37.06%
⚡Memorymem client navigation-churn (vue)1.3 MB1.2 MB+3.81%
👁Simulationssr server-fn during document ssr (react)62.9 ms66.6 ms-5.62%
👁Memorymem server error-paths redirect (vue)338.6 KB422.4 KB-19.84%
👁Memorymem server error-paths not-found (react)277.7 KB287.1 KB-3.27%
👁Memorymem server error-paths unmatched (react)317.5 KB668.3 KB-52.49%
👁Memorymem server peak-large-page (react)1.7 MB2.2 MB-21.95%
Tip
Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.
Comparing codex/direct-create-file-route (abf9767) with main (697ebb6)
Open in CodSpeed
@Sheraff
Sheraff
marked this pull request as ready for review
August 6, 2026 06:59
coderabbitai[bot]
coderabbitaiBot
reviewed
Aug 6, 2026
View reviewed changes
@coderabbitaicoderabbitaiBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/react-router/src/fileRoute.ts`:
- Around line 60-65: Preserve the typed factory contract in createFileRoute by
replacing the wrapper’s options?: any and return createRoute as any with a
FileRoute<...>['createRoute']-compatible type, using one shared typed helper if
appropriate and retaining any unavoidable cast at a documented boundary. Apply
the same correction at packages/react-router/src/fileRoute.ts:60-65,
packages/solid-router/src/fileRoute.ts:49-54, and
packages/vue-router/src/fileRoute.ts:49-54; all three createRoute wrappers
require the change.

🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
  •  Push a commit to this branch (recommended)
  •  Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 14ac885f-fffc-41b1-807c-d6c3c7992d83
📥 Commits
Reviewing files that changed from the base of the PR and between 697ebb6 and d34c25f.
📒 Files selected for processing (6)
  • packages/react-router/src/fileRoute.ts
  • packages/react-router/tests/fileRoute.test.ts
  • packages/solid-router/src/fileRoute.ts
  • packages/solid-router/tests/fileRoute.test.ts
  • packages/vue-router/src/fileRoute.ts
  • packages/vue-router/tests/fileRoute.test.ts
Comment threadpackages/react-router/src/fileRoute.ts
Outdated

@Sheraff
Sheraff
merged commit 2435885
into
mainAug 6, 2026

26 checks passed

@Sheraff
Sheraff
deleted the

codex/direct-create-file-route

branch
August 6, 2026 11:38
@github-actionsgithub-actionsBot
mentioned this pull request
Aug 6, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@coderabbitaicoderabbitai[bot]coderabbitai[bot] left review comments

Assignees


No one assigned


Labels

package: react-routerpackage: solid-routerpackage: vue-router

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@Sheraff

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Create file routes directly - #7970
Merged
Sheraff merged 5 commits into
mainfrom 
codex/direct-create-file-route
Aug 6, 2026
Merged
Create file routes directly#7970
Sheraff merged 5 commits into
mainfrom 
codex/direct-create-file-route
Conversation
@Sheraff
@SheraffSheraff
commented
Aug 5, 2026•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Collaborator
What
  • have createFileRoute create the route directly in React, Solid, and Vue
  • keep the deprecated FileRoute class and its warning behavior intact
  • preserve isRoot = false for file routes
  • add mirrored factory/class behavior tests for all three frameworks
Why
The public factory only instantiated FileRoute to reuse its createRoute field while suppressing the class's deprecation warning. Creating the route directly removes that unnecessary class path from normal file-route bundles without changing the deprecated API.
Bundle impact
Prior isolated prototype measurements from the same main base:
  • react-router.minimal: -117 B raw, -40 B gzip, -20 B Brotli
  • solid-router.minimal: -117 B raw, -38 B gzip, +4 B Brotli
Measured for this PR head against the same base:
  • vue-router.minimal: -113 B raw, -49 B gzip, -42 B Brotli
Validation
  • React and Vue focused file-route unit tests
  • Solid full client/server unit suite (840 passed, 1 skipped; server suite 3 passed)
  • React, Solid, and Vue type tests
  • React, Solid, and Vue ESLint (0 errors; existing warnings only)
  • React, Solid, and Vue production builds
Summary by CodeRabbit
  • Bug Fixes
    • File-based route creation no longer produces an unexpected deprecation warning.
    • Routes created through the standard file-route API are correctly treated as non-root routes.
    • Direct use of the deprecated route API continues to display its warning.
  • Tests
    • Added coverage confirming route behavior and warning differences across React, Solid, and Vue integrations.
@coderabbitai
coderabbitaiBot
commented
Aug 5, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Review Change Stack
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 9603c18d-53a1-46d1-b9d2-725ddfb0c08e
📥 Commits
Reviewing files that changed from the base of the PR and between d34c25f and abf9767.
📒 Files selected for processing (4)
  • .changeset/easy-zoos-greet.md
  • packages/react-router/src/fileRoute.ts
  • packages/solid-router/src/fileRoute.ts
  • packages/vue-router/src/fileRoute.ts
🚧 Files skipped from review as they are similar to previous changes (1)
  • packages/solid-router/src/fileRoute.ts
📝 Walkthrough
Walkthrough
createFileRoute now calls the shared route factory directly in the React, Solid, and Vue routers. It marks routes as non-root without warning. Direct FileRoute construction retains its deprecation warning. Tests cover both behaviors.
Changes
File route factory behavior
Layer / File(s)Summary
Direct shared factory integration
packages/{react,solid,vue}-router/src/fileRoute.ts, .changeset/easy-zoos-greet.md		createFileRoute uses the shared route factory and sets isRoot to false. The changeset marks patch releases for the three router packages.
Factory and warning behavior tests
packages/{react,solid,vue}-router/tests/fileRoute.test.ts		Tests verify non-root routes, warning suppression for createFileRoute, warning retention for direct FileRoute usage, and mock cleanup.
Estimated code review effort: 3 (Moderate) | ~20 minutes
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly and concisely describes the main change: creating file routes directly.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  •  Create stacked PR
  •  Commit on current branch
🧪 Generate unit tests (beta)
  •  Create PR with unit tests
  •  Commit unit tests in branch codex/direct-create-file-route
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands.
@github-actions
github-actionsBot
commented
Aug 5, 2026

Copy link


Copy Markdown

Contributor
🚀 Changeset Version Preview
5 package(s) bumped directly, 18 bumped as dependents.
🟩 Patch bumps
PackageVersionReason
@tanstack/react-router1.170.20 → 1.170.21Changeset
@tanstack/router-core1.171.17 → 1.171.18Changeset
@tanstack/solid-router1.170.20 → 1.170.21Changeset
@tanstack/start-server-core1.169.20 → 1.169.21Changeset
@tanstack/vue-router1.170.19 → 1.170.20Changeset
@tanstack/react-start1.168.37 → 1.168.38Dependent
@tanstack/react-start-client1.168.18 → 1.168.19Dependent
@tanstack/react-start-rsc0.1.36 → 0.1.37Dependent
@tanstack/react-start-server1.167.25 → 1.167.26Dependent
@tanstack/router-cli1.167.23 → 1.167.24Dependent
@tanstack/router-generator1.167.23 → 1.167.24Dependent
@tanstack/router-plugin1.168.25 → 1.168.26Dependent
@tanstack/router-vite-plugin1.167.25 → 1.167.26Dependent
@tanstack/solid-start1.168.36 → 1.168.37Dependent
@tanstack/solid-start-client1.168.18 → 1.168.19Dependent
@tanstack/solid-start-server1.167.25 → 1.167.26Dependent
@tanstack/start-client-core1.170.16 → 1.170.17Dependent
@tanstack/start-plugin-core1.171.28 → 1.171.29Dependent
@tanstack/start-static-server-functions1.167.21 → 1.167.22Dependent
@tanstack/start-storage-context1.167.19 → 1.167.20Dependent
@tanstack/vue-start1.168.35 → 1.168.36Dependent
@tanstack/vue-start-client1.167.21 → 1.167.22Dependent
@tanstack/vue-start-server1.167.25 → 1.167.26Dependent
@nx-cloud
nx-cloudBot
commented
Aug 5, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
View your CI Pipeline Execution ↗ for commit abf9767
CommandStatusDurationResult
nx affected --targets=test:eslint,test:unit,tes...✅ Succeeded10m 30sView ↗
nx run-many --target=build --exclude=examples/*...✅ Succeeded1m 29sView ↗
☁️ Nx Cloud last updated this comment at 2026-08-06 11:13:14 UTC
@pkg-pr-new
pkg-pr-newBot
commented
Aug 5, 2026•

edited

Loading

Copy link


Copy Markdown

More templates
@tanstack/arktype-adapter
npm i https://pkg.pr.new/@tanstack/arktype-adapter@7970

@tanstack/eslint-plugin-router
npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@7970

@tanstack/eslint-plugin-start
npm i https://pkg.pr.new/@tanstack/eslint-plugin-start@7970

@tanstack/history
npm i https://pkg.pr.new/@tanstack/history@7970

@tanstack/nitro-v2-vite-plugin
npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@7970

@tanstack/react-router
npm i https://pkg.pr.new/@tanstack/react-router@7970

@tanstack/react-router-devtools
npm i https://pkg.pr.new/@tanstack/react-router-devtools@7970

@tanstack/react-router-ssr-query
npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@7970

@tanstack/react-start
npm i https://pkg.pr.new/@tanstack/react-start@7970

@tanstack/react-start-client
npm i https://pkg.pr.new/@tanstack/react-start-client@7970

@tanstack/react-start-rsc
npm i https://pkg.pr.new/@tanstack/react-start-rsc@7970

@tanstack/react-start-server
npm i https://pkg.pr.new/@tanstack/react-start-server@7970

@tanstack/router-cli
npm i https://pkg.pr.new/@tanstack/router-cli@7970

@tanstack/router-core
npm i https://pkg.pr.new/@tanstack/router-core@7970

@tanstack/router-devtools
npm i https://pkg.pr.new/@tanstack/router-devtools@7970

@tanstack/router-devtools-core
npm i https://pkg.pr.new/@tanstack/router-devtools-core@7970

@tanstack/router-generator
npm i https://pkg.pr.new/@tanstack/router-generator@7970

@tanstack/router-plugin
npm i https://pkg.pr.new/@tanstack/router-plugin@7970

@tanstack/router-ssr-query-core
npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@7970

@tanstack/router-utils
npm i https://pkg.pr.new/@tanstack/router-utils@7970

@tanstack/router-vite-plugin
npm i https://pkg.pr.new/@tanstack/router-vite-plugin@7970

@tanstack/solid-router
npm i https://pkg.pr.new/@tanstack/solid-router@7970

@tanstack/solid-router-devtools
npm i https://pkg.pr.new/@tanstack/solid-router-devtools@7970

@tanstack/solid-router-ssr-query
npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@7970

@tanstack/solid-start
npm i https://pkg.pr.new/@tanstack/solid-start@7970

@tanstack/solid-start-client
npm i https://pkg.pr.new/@tanstack/solid-start-client@7970

@tanstack/solid-start-server
npm i https://pkg.pr.new/@tanstack/solid-start-server@7970

@tanstack/start-client-core
npm i https://pkg.pr.new/@tanstack/start-client-core@7970

@tanstack/start-fn-stubs
npm i https://pkg.pr.new/@tanstack/start-fn-stubs@7970

@tanstack/start-plugin-core
npm i https://pkg.pr.new/@tanstack/start-plugin-core@7970

@tanstack/start-server-core
npm i https://pkg.pr.new/@tanstack/start-server-core@7970

@tanstack/start-static-server-functions
npm i https://pkg.pr.new/@tanstack/start-static-server-functions@7970

@tanstack/start-storage-context
npm i https://pkg.pr.new/@tanstack/start-storage-context@7970

@tanstack/valibot-adapter
npm i https://pkg.pr.new/@tanstack/valibot-adapter@7970

@tanstack/virtual-file-routes
npm i https://pkg.pr.new/@tanstack/virtual-file-routes@7970

@tanstack/vue-router
npm i https://pkg.pr.new/@tanstack/vue-router@7970

@tanstack/vue-router-devtools
npm i https://pkg.pr.new/@tanstack/vue-router-devtools@7970

@tanstack/vue-router-ssr-query
npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@7970

@tanstack/vue-start
npm i https://pkg.pr.new/@tanstack/vue-start@7970

@tanstack/vue-start-client
npm i https://pkg.pr.new/@tanstack/vue-start-client@7970

@tanstack/vue-start-server
npm i https://pkg.pr.new/@tanstack/vue-start-server@7970

@tanstack/zod-adapter
npm i https://pkg.pr.new/@tanstack/zod-adapter@7970

commit: abf9767
@github-actions
github-actionsBot
commented
Aug 5, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Bundle Size Benchmarks
  • Commit: c86f13a34b9a
  • Measured at: 2026-08-06T11:04:12.144Z
  • Baseline source: history:697ebb6ddbd4
  • Dashboard: bundle-size history
The following scenarios have bundle-size changes compared with the baseline:
ScenarioCurrent (gzip)Delta vs baselineInitial gzipRawBrotliTrend
react-router.minimal87.07 KiB-45 B (-0.05%)86.93 KiB269.02 KiB75.83 KiB████▂▂▂▂▂▁▂▁
react-router.full90.85 KiB-45 B (-0.05%)90.72 KiB280.97 KiB79.09 KiB████▃▃▃▃▃▂▂▁
solid-router.minimal34.76 KiB-38 B (-0.11%)34.63 KiB99.85 KiB31.33 KiB████▂▂▂▂▂▁▁▁
solid-router.full39.85 KiB-46 B (-0.11%)39.73 KiB115.03 KiB35.88 KiB████▂▂▂▂▂▁▁▁
vue-router.minimal52.05 KiB-48 B (-0.09%)51.92 KiB143.01 KiB46.83 KiB████▂▂▂▂▂▁▁▁
vue-router.full58.01 KiB-45 B (-0.08%)57.88 KiB161.68 KiB52.08 KiB████▂▂▂▂▂▁▁▁
react-start.minimal100.55 KiB-45 B (-0.04%)100.42 KiB312.17 KiB87.40 KiB███████▁▁▁▁▁
react-start.deferred-hydration101.29 KiB-47 B (-0.05%)100.44 KiB313.54 KiB87.99 KiB███████▁▁▁▁▁
react-start.full103.88 KiB-42 B (-0.04%)103.74 KiB322.12 KiB90.17 KiB███████▁▁▁▁▁
react-start.rsbuild.minimal100.21 KiB-30 B (-0.03%)100.04 KiB316.67 KiB86.35 KiB▁▁▁▁▂▂▂█████
react-start.rsbuild.minimal-iife100.61 KiB-36 B (-0.03%)100.44 KiB317.60 KiB86.75 KiB▁▁▁▁▂▂▂████▇
react-start.rsbuild.full103.52 KiB-46 B (-0.04%)103.35 KiB326.76 KiB89.11 KiB▁▁▁▁▃▃▃████▇
solid-start.minimal48.15 KiB-30 B (-0.06%)48.02 KiB141.99 KiB42.80 KiB███████▁▁▁▁▁
solid-start.deferred-hydration51.41 KiB-30 B (-0.06%)48.08 KiB150.03 KiB45.82 KiB███████▁▁▁▁▁
solid-start.full53.38 KiB-49 B (-0.09%)53.25 KiB157.72 KiB47.34 KiB████▆▆▆▁▁▁▁▁
vue-start.minimal68.94 KiB-36 B (-0.05%)68.81 KiB195.01 KiB61.33 KiB████▆▆▆▁▁▁▁▁
vue-start.full72.90 KiB-34 B (-0.05%)72.77 KiB207.51 KiB64.80 KiB████▆▆▆▁▁▁▁▁
Current gzip tracks all emitted client JS chunks. Initial gzip tracks only the entry/import graph. Trend sparkline is historical current gzip ending with this PR measurement; lower is better.
@codspeed-hq
codspeed-hqBot
commented
Aug 5, 2026•

edited

Loading

Copy link


Copy Markdown

Merging this PR will regress 0 benchmarks
⚠️Different runtime environments detected
Some benchmarks with significant performance changes were compared across different runtime environments,

which may affect the accuracy of the results.
Open the report in CodSpeed to investigate
⚡ 4 improved benchmarks
❌ 5 (👁 5) regressed benchmarks
✅ 171 untouched benchmarks
Performance Changes
ModeBenchmarkBASEHEADEfficiency
⚡Memorymem server server-fn-churn (vue)4,147.3 KB264.3 KB×16
⚡Memorymem server error-paths unmatched (vue)2,142.1 KB479 KB×4.5
⚡Memorymem server error-paths redirect (solid)388 KB283.1 KB+37.06%
⚡Memorymem client navigation-churn (vue)1.3 MB1.2 MB+3.81%
👁Simulationssr server-fn during document ssr (react)62.9 ms66.6 ms-5.62%
👁Memorymem server error-paths redirect (vue)338.6 KB422.4 KB-19.84%
👁Memorymem server error-paths not-found (react)277.7 KB287.1 KB-3.27%
👁Memorymem server error-paths unmatched (react)317.5 KB668.3 KB-52.49%
👁Memorymem server peak-large-page (react)1.7 MB2.2 MB-21.95%
Tip
Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.
Comparing codex/direct-create-file-route (abf9767) with main (697ebb6)
Open in CodSpeed
@Sheraff
Sheraff
marked this pull request as ready for review
August 6, 2026 06:59
coderabbitai[bot]
coderabbitaiBot
reviewed
Aug 6, 2026
View reviewed changes
@coderabbitaicoderabbitaiBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/react-router/src/fileRoute.ts`:
- Around line 60-65: Preserve the typed factory contract in createFileRoute by
replacing the wrapper’s options?: any and return createRoute as any with a
FileRoute<...>['createRoute']-compatible type, using one shared typed helper if
appropriate and retaining any unavoidable cast at a documented boundary. Apply
the same correction at packages/react-router/src/fileRoute.ts:60-65,
packages/solid-router/src/fileRoute.ts:49-54, and
packages/vue-router/src/fileRoute.ts:49-54; all three createRoute wrappers
require the change.

🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
  •  Push a commit to this branch (recommended)
  •  Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 14ac885f-fffc-41b1-807c-d6c3c7992d83
📥 Commits
Reviewing files that changed from the base of the PR and between 697ebb6 and d34c25f.
📒 Files selected for processing (6)
  • packages/react-router/src/fileRoute.ts
  • packages/react-router/tests/fileRoute.test.ts
  • packages/solid-router/src/fileRoute.ts
  • packages/solid-router/tests/fileRoute.test.ts
  • packages/vue-router/src/fileRoute.ts
  • packages/vue-router/tests/fileRoute.test.ts
Comment threadpackages/react-router/src/fileRoute.ts
Outdated

@Sheraff
Sheraff
merged commit 2435885
into
mainAug 6, 2026

26 checks passed

@Sheraff
Sheraff
deleted the

codex/direct-create-file-route

branch
August 6, 2026 11:38
@github-actionsgithub-actionsBot
mentioned this pull request
Aug 6, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@coderabbitaicoderabbitai[bot]coderabbitai[bot] left review comments

Assignees


No one assigned


Labels

package: react-routerpackage: solid-routerpackage: vue-router

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@Sheraff

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Create file routes directly - #7970
Merged
Sheraff merged 5 commits into
mainfrom 
codex/direct-create-file-route
Aug 6, 2026
Merged
Create file routes directly#7970
Sheraff merged 5 commits into
mainfrom 
codex/direct-create-file-route
Conversation
@Sheraff
@SheraffSheraff
commented
Aug 5, 2026•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Collaborator
What
  • have createFileRoute create the route directly in React, Solid, and Vue
  • keep the deprecated FileRoute class and its warning behavior intact
  • preserve isRoot = false for file routes
  • add mirrored factory/class behavior tests for all three frameworks
Why
The public factory only instantiated FileRoute to reuse its createRoute field while suppressing the class's deprecation warning. Creating the route directly removes that unnecessary class path from normal file-route bundles without changing the deprecated API.
Bundle impact
Prior isolated prototype measurements from the same main base:
  • react-router.minimal: -117 B raw, -40 B gzip, -20 B Brotli
  • solid-router.minimal: -117 B raw, -38 B gzip, +4 B Brotli
Measured for this PR head against the same base:
  • vue-router.minimal: -113 B raw, -49 B gzip, -42 B Brotli
Validation
  • React and Vue focused file-route unit tests
  • Solid full client/server unit suite (840 passed, 1 skipped; server suite 3 passed)
  • React, Solid, and Vue type tests
  • React, Solid, and Vue ESLint (0 errors; existing warnings only)
  • React, Solid, and Vue production builds
Summary by CodeRabbit
  • Bug Fixes
    • File-based route creation no longer produces an unexpected deprecation warning.
    • Routes created through the standard file-route API are correctly treated as non-root routes.
    • Direct use of the deprecated route API continues to display its warning.
  • Tests
    • Added coverage confirming route behavior and warning differences across React, Solid, and Vue integrations.
@coderabbitai
coderabbitaiBot
commented
Aug 5, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Review Change Stack
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 9603c18d-53a1-46d1-b9d2-725ddfb0c08e
📥 Commits
Reviewing files that changed from the base of the PR and between d34c25f and abf9767.
📒 Files selected for processing (4)
  • .changeset/easy-zoos-greet.md
  • packages/react-router/src/fileRoute.ts
  • packages/solid-router/src/fileRoute.ts
  • packages/vue-router/src/fileRoute.ts
🚧 Files skipped from review as they are similar to previous changes (1)
  • packages/solid-router/src/fileRoute.ts
📝 Walkthrough
Walkthrough
createFileRoute now calls the shared route factory directly in the React, Solid, and Vue routers. It marks routes as non-root without warning. Direct FileRoute construction retains its deprecation warning. Tests cover both behaviors.
Changes
File route factory behavior
Layer / File(s)Summary
Direct shared factory integration
packages/{react,solid,vue}-router/src/fileRoute.ts, .changeset/easy-zoos-greet.md		createFileRoute uses the shared route factory and sets isRoot to false. The changeset marks patch releases for the three router packages.
Factory and warning behavior tests
packages/{react,solid,vue}-router/tests/fileRoute.test.ts		Tests verify non-root routes, warning suppression for createFileRoute, warning retention for direct FileRoute usage, and mock cleanup.
Estimated code review effort: 3 (Moderate) | ~20 minutes
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly and concisely describes the main change: creating file routes directly.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  •  Create stacked PR
  •  Commit on current branch
🧪 Generate unit tests (beta)
  •  Create PR with unit tests
  •  Commit unit tests in branch codex/direct-create-file-route
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands.
@github-actions
github-actionsBot
commented
Aug 5, 2026

Copy link


Copy Markdown

Contributor
🚀 Changeset Version Preview
5 package(s) bumped directly, 18 bumped as dependents.
🟩 Patch bumps
PackageVersionReason
@tanstack/react-router1.170.20 → 1.170.21Changeset
@tanstack/router-core1.171.17 → 1.171.18Changeset
@tanstack/solid-router1.170.20 → 1.170.21Changeset
@tanstack/start-server-core1.169.20 → 1.169.21Changeset
@tanstack/vue-router1.170.19 → 1.170.20Changeset
@tanstack/react-start1.168.37 → 1.168.38Dependent
@tanstack/react-start-client1.168.18 → 1.168.19Dependent
@tanstack/react-start-rsc0.1.36 → 0.1.37Dependent
@tanstack/react-start-server1.167.25 → 1.167.26Dependent
@tanstack/router-cli1.167.23 → 1.167.24Dependent
@tanstack/router-generator1.167.23 → 1.167.24Dependent
@tanstack/router-plugin1.168.25 → 1.168.26Dependent
@tanstack/router-vite-plugin1.167.25 → 1.167.26Dependent
@tanstack/solid-start1.168.36 → 1.168.37Dependent
@tanstack/solid-start-client1.168.18 → 1.168.19Dependent
@tanstack/solid-start-server1.167.25 → 1.167.26Dependent
@tanstack/start-client-core1.170.16 → 1.170.17Dependent
@tanstack/start-plugin-core1.171.28 → 1.171.29Dependent
@tanstack/start-static-server-functions1.167.21 → 1.167.22Dependent
@tanstack/start-storage-context1.167.19 → 1.167.20Dependent
@tanstack/vue-start1.168.35 → 1.168.36Dependent
@tanstack/vue-start-client1.167.21 → 1.167.22Dependent
@tanstack/vue-start-server1.167.25 → 1.167.26Dependent
@nx-cloud
nx-cloudBot
commented
Aug 5, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
View your CI Pipeline Execution ↗ for commit abf9767
CommandStatusDurationResult
nx affected --targets=test:eslint,test:unit,tes...✅ Succeeded10m 30sView ↗
nx run-many --target=build --exclude=examples/*...✅ Succeeded1m 29sView ↗
☁️ Nx Cloud last updated this comment at 2026-08-06 11:13:14 UTC
@pkg-pr-new
pkg-pr-newBot
commented
Aug 5, 2026•

edited

Loading

Copy link


Copy Markdown

More templates
@tanstack/arktype-adapter
npm i https://pkg.pr.new/@tanstack/arktype-adapter@7970

@tanstack/eslint-plugin-router
npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@7970

@tanstack/eslint-plugin-start
npm i https://pkg.pr.new/@tanstack/eslint-plugin-start@7970

@tanstack/history
npm i https://pkg.pr.new/@tanstack/history@7970

@tanstack/nitro-v2-vite-plugin
npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@7970

@tanstack/react-router
npm i https://pkg.pr.new/@tanstack/react-router@7970

@tanstack/react-router-devtools
npm i https://pkg.pr.new/@tanstack/react-router-devtools@7970

@tanstack/react-router-ssr-query
npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@7970

@tanstack/react-start
npm i https://pkg.pr.new/@tanstack/react-start@7970

@tanstack/react-start-client
npm i https://pkg.pr.new/@tanstack/react-start-client@7970

@tanstack/react-start-rsc
npm i https://pkg.pr.new/@tanstack/react-start-rsc@7970

@tanstack/react-start-server
npm i https://pkg.pr.new/@tanstack/react-start-server@7970

@tanstack/router-cli
npm i https://pkg.pr.new/@tanstack/router-cli@7970

@tanstack/router-core
npm i https://pkg.pr.new/@tanstack/router-core@7970

@tanstack/router-devtools
npm i https://pkg.pr.new/@tanstack/router-devtools@7970

@tanstack/router-devtools-core
npm i https://pkg.pr.new/@tanstack/router-devtools-core@7970

@tanstack/router-generator
npm i https://pkg.pr.new/@tanstack/router-generator@7970

@tanstack/router-plugin
npm i https://pkg.pr.new/@tanstack/router-plugin@7970

@tanstack/router-ssr-query-core
npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@7970

@tanstack/router-utils
npm i https://pkg.pr.new/@tanstack/router-utils@7970

@tanstack/router-vite-plugin
npm i https://pkg.pr.new/@tanstack/router-vite-plugin@7970

@tanstack/solid-router
npm i https://pkg.pr.new/@tanstack/solid-router@7970

@tanstack/solid-router-devtools
npm i https://pkg.pr.new/@tanstack/solid-router-devtools@7970

@tanstack/solid-router-ssr-query
npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@7970

@tanstack/solid-start
npm i https://pkg.pr.new/@tanstack/solid-start@7970

@tanstack/solid-start-client
npm i https://pkg.pr.new/@tanstack/solid-start-client@7970

@tanstack/solid-start-server
npm i https://pkg.pr.new/@tanstack/solid-start-server@7970

@tanstack/start-client-core
npm i https://pkg.pr.new/@tanstack/start-client-core@7970

@tanstack/start-fn-stubs
npm i https://pkg.pr.new/@tanstack/start-fn-stubs@7970

@tanstack/start-plugin-core
npm i https://pkg.pr.new/@tanstack/start-plugin-core@7970

@tanstack/start-server-core
npm i https://pkg.pr.new/@tanstack/start-server-core@7970

@tanstack/start-static-server-functions
npm i https://pkg.pr.new/@tanstack/start-static-server-functions@7970

@tanstack/start-storage-context
npm i https://pkg.pr.new/@tanstack/start-storage-context@7970

@tanstack/valibot-adapter
npm i https://pkg.pr.new/@tanstack/valibot-adapter@7970

@tanstack/virtual-file-routes
npm i https://pkg.pr.new/@tanstack/virtual-file-routes@7970

@tanstack/vue-router
npm i https://pkg.pr.new/@tanstack/vue-router@7970

@tanstack/vue-router-devtools
npm i https://pkg.pr.new/@tanstack/vue-router-devtools@7970

@tanstack/vue-router-ssr-query
npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@7970

@tanstack/vue-start
npm i https://pkg.pr.new/@tanstack/vue-start@7970

@tanstack/vue-start-client
npm i https://pkg.pr.new/@tanstack/vue-start-client@7970

@tanstack/vue-start-server
npm i https://pkg.pr.new/@tanstack/vue-start-server@7970

@tanstack/zod-adapter
npm i https://pkg.pr.new/@tanstack/zod-adapter@7970

commit: abf9767
@github-actions
github-actionsBot
commented
Aug 5, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Bundle Size Benchmarks
  • Commit: c86f13a34b9a
  • Measured at: 2026-08-06T11:04:12.144Z
  • Baseline source: history:697ebb6ddbd4
  • Dashboard: bundle-size history
The following scenarios have bundle-size changes compared with the baseline:
ScenarioCurrent (gzip)Delta vs baselineInitial gzipRawBrotliTrend
react-router.minimal87.07 KiB-45 B (-0.05%)86.93 KiB269.02 KiB75.83 KiB████▂▂▂▂▂▁▂▁
react-router.full90.85 KiB-45 B (-0.05%)90.72 KiB280.97 KiB79.09 KiB████▃▃▃▃▃▂▂▁
solid-router.minimal34.76 KiB-38 B (-0.11%)34.63 KiB99.85 KiB31.33 KiB████▂▂▂▂▂▁▁▁
solid-router.full39.85 KiB-46 B (-0.11%)39.73 KiB115.03 KiB35.88 KiB████▂▂▂▂▂▁▁▁
vue-router.minimal52.05 KiB-48 B (-0.09%)51.92 KiB143.01 KiB46.83 KiB████▂▂▂▂▂▁▁▁
vue-router.full58.01 KiB-45 B (-0.08%)57.88 KiB161.68 KiB52.08 KiB████▂▂▂▂▂▁▁▁
react-start.minimal100.55 KiB-45 B (-0.04%)100.42 KiB312.17 KiB87.40 KiB███████▁▁▁▁▁
react-start.deferred-hydration101.29 KiB-47 B (-0.05%)100.44 KiB313.54 KiB87.99 KiB███████▁▁▁▁▁
react-start.full103.88 KiB-42 B (-0.04%)103.74 KiB322.12 KiB90.17 KiB███████▁▁▁▁▁
react-start.rsbuild.minimal100.21 KiB-30 B (-0.03%)100.04 KiB316.67 KiB86.35 KiB▁▁▁▁▂▂▂█████
react-start.rsbuild.minimal-iife100.61 KiB-36 B (-0.03%)100.44 KiB317.60 KiB86.75 KiB▁▁▁▁▂▂▂████▇
react-start.rsbuild.full103.52 KiB-46 B (-0.04%)103.35 KiB326.76 KiB89.11 KiB▁▁▁▁▃▃▃████▇
solid-start.minimal48.15 KiB-30 B (-0.06%)48.02 KiB141.99 KiB42.80 KiB███████▁▁▁▁▁
solid-start.deferred-hydration51.41 KiB-30 B (-0.06%)48.08 KiB150.03 KiB45.82 KiB███████▁▁▁▁▁
solid-start.full53.38 KiB-49 B (-0.09%)53.25 KiB157.72 KiB47.34 KiB████▆▆▆▁▁▁▁▁
vue-start.minimal68.94 KiB-36 B (-0.05%)68.81 KiB195.01 KiB61.33 KiB████▆▆▆▁▁▁▁▁
vue-start.full72.90 KiB-34 B (-0.05%)72.77 KiB207.51 KiB64.80 KiB████▆▆▆▁▁▁▁▁
Current gzip tracks all emitted client JS chunks. Initial gzip tracks only the entry/import graph. Trend sparkline is historical current gzip ending with this PR measurement; lower is better.
@codspeed-hq
codspeed-hqBot
commented
Aug 5, 2026•

edited

Loading

Copy link


Copy Markdown

Merging this PR will regress 0 benchmarks
⚠️Different runtime environments detected
Some benchmarks with significant performance changes were compared across different runtime environments,

which may affect the accuracy of the results.
Open the report in CodSpeed to investigate
⚡ 4 improved benchmarks
❌ 5 (👁 5) regressed benchmarks
✅ 171 untouched benchmarks
Performance Changes
ModeBenchmarkBASEHEADEfficiency
⚡Memorymem server server-fn-churn (vue)4,147.3 KB264.3 KB×16
⚡Memorymem server error-paths unmatched (vue)2,142.1 KB479 KB×4.5
⚡Memorymem server error-paths redirect (solid)388 KB283.1 KB+37.06%
⚡Memorymem client navigation-churn (vue)1.3 MB1.2 MB+3.81%
👁Simulationssr server-fn during document ssr (react)62.9 ms66.6 ms-5.62%
👁Memorymem server error-paths redirect (vue)338.6 KB422.4 KB-19.84%
👁Memorymem server error-paths not-found (react)277.7 KB287.1 KB-3.27%
👁Memorymem server error-paths unmatched (react)317.5 KB668.3 KB-52.49%
👁Memorymem server peak-large-page (react)1.7 MB2.2 MB-21.95%
Tip
Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.
Comparing codex/direct-create-file-route (abf9767) with main (697ebb6)
Open in CodSpeed
@Sheraff
Sheraff
marked this pull request as ready for review
August 6, 2026 06:59
coderabbitai[bot]
coderabbitaiBot
reviewed
Aug 6, 2026
View reviewed changes
@coderabbitaicoderabbitaiBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/react-router/src/fileRoute.ts`:
- Around line 60-65: Preserve the typed factory contract in createFileRoute by
replacing the wrapper’s options?: any and return createRoute as any with a
FileRoute<...>['createRoute']-compatible type, using one shared typed helper if
appropriate and retaining any unavoidable cast at a documented boundary. Apply
the same correction at packages/react-router/src/fileRoute.ts:60-65,
packages/solid-router/src/fileRoute.ts:49-54, and
packages/vue-router/src/fileRoute.ts:49-54; all three createRoute wrappers
require the change.

🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
  •  Push a commit to this branch (recommended)
  •  Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 14ac885f-fffc-41b1-807c-d6c3c7992d83
📥 Commits
Reviewing files that changed from the base of the PR and between 697ebb6 and d34c25f.
📒 Files selected for processing (6)
  • packages/react-router/src/fileRoute.ts
  • packages/react-router/tests/fileRoute.test.ts
  • packages/solid-router/src/fileRoute.ts
  • packages/solid-router/tests/fileRoute.test.ts
  • packages/vue-router/src/fileRoute.ts
  • packages/vue-router/tests/fileRoute.test.ts
Comment threadpackages/react-router/src/fileRoute.ts
Outdated

@Sheraff
Sheraff
merged commit 2435885
into
mainAug 6, 2026

26 checks passed

@Sheraff
Sheraff
deleted the

codex/direct-create-file-route

branch
August 6, 2026 11:38
@github-actionsgithub-actionsBot
mentioned this pull request
Aug 6, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@coderabbitaicoderabbitai[bot]coderabbitai[bot] left review comments

Assignees


No one assigned


Labels

package: react-routerpackage: solid-routerpackage: vue-router

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@Sheraff

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Create file routes directly - #7970
Merged
Sheraff merged 5 commits into
mainfrom 
codex/direct-create-file-route
Aug 6, 2026
Merged
Create file routes directly#7970
Sheraff merged 5 commits into
mainfrom 
codex/direct-create-file-route
Conversation
@Sheraff
@SheraffSheraff
commented
Aug 5, 2026•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Collaborator
What
  • have createFileRoute create the route directly in React, Solid, and Vue
  • keep the deprecated FileRoute class and its warning behavior intact
  • preserve isRoot = false for file routes
  • add mirrored factory/class behavior tests for all three frameworks
Why
The public factory only instantiated FileRoute to reuse its createRoute field while suppressing the class's deprecation warning. Creating the route directly removes that unnecessary class path from normal file-route bundles without changing the deprecated API.
Bundle impact
Prior isolated prototype measurements from the same main base:
  • react-router.minimal: -117 B raw, -40 B gzip, -20 B Brotli
  • solid-router.minimal: -117 B raw, -38 B gzip, +4 B Brotli
Measured for this PR head against the same base:
  • vue-router.minimal: -113 B raw, -49 B gzip, -42 B Brotli
Validation
  • React and Vue focused file-route unit tests
  • Solid full client/server unit suite (840 passed, 1 skipped; server suite 3 passed)
  • React, Solid, and Vue type tests
  • React, Solid, and Vue ESLint (0 errors; existing warnings only)
  • React, Solid, and Vue production builds
Summary by CodeRabbit
  • Bug Fixes
    • File-based route creation no longer produces an unexpected deprecation warning.
    • Routes created through the standard file-route API are correctly treated as non-root routes.
    • Direct use of the deprecated route API continues to display its warning.
  • Tests
    • Added coverage confirming route behavior and warning differences across React, Solid, and Vue integrations.
@coderabbitai
coderabbitaiBot
commented
Aug 5, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Review Change Stack
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 9603c18d-53a1-46d1-b9d2-725ddfb0c08e
📥 Commits
Reviewing files that changed from the base of the PR and between d34c25f and abf9767.
📒 Files selected for processing (4)
  • .changeset/easy-zoos-greet.md
  • packages/react-router/src/fileRoute.ts
  • packages/solid-router/src/fileRoute.ts
  • packages/vue-router/src/fileRoute.ts
🚧 Files skipped from review as they are similar to previous changes (1)
  • packages/solid-router/src/fileRoute.ts
📝 Walkthrough
Walkthrough
createFileRoute now calls the shared route factory directly in the React, Solid, and Vue routers. It marks routes as non-root without warning. Direct FileRoute construction retains its deprecation warning. Tests cover both behaviors.
Changes
File route factory behavior
Layer / File(s)Summary
Direct shared factory integration
packages/{react,solid,vue}-router/src/fileRoute.ts, .changeset/easy-zoos-greet.md		createFileRoute uses the shared route factory and sets isRoot to false. The changeset marks patch releases for the three router packages.
Factory and warning behavior tests
packages/{react,solid,vue}-router/tests/fileRoute.test.ts		Tests verify non-root routes, warning suppression for createFileRoute, warning retention for direct FileRoute usage, and mock cleanup.
Estimated code review effort: 3 (Moderate) | ~20 minutes
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly and concisely describes the main change: creating file routes directly.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  •  Create stacked PR
  •  Commit on current branch
🧪 Generate unit tests (beta)
  •  Create PR with unit tests
  •  Commit unit tests in branch codex/direct-create-file-route
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands.
@github-actions
github-actionsBot
commented
Aug 5, 2026

Copy link


Copy Markdown

Contributor
🚀 Changeset Version Preview
5 package(s) bumped directly, 18 bumped as dependents.
🟩 Patch bumps
PackageVersionReason
@tanstack/react-router1.170.20 → 1.170.21Changeset
@tanstack/router-core1.171.17 → 1.171.18Changeset
@tanstack/solid-router1.170.20 → 1.170.21Changeset
@tanstack/start-server-core1.169.20 → 1.169.21Changeset
@tanstack/vue-router1.170.19 → 1.170.20Changeset
@tanstack/react-start1.168.37 → 1.168.38Dependent
@tanstack/react-start-client1.168.18 → 1.168.19Dependent
@tanstack/react-start-rsc0.1.36 → 0.1.37Dependent
@tanstack/react-start-server1.167.25 → 1.167.26Dependent
@tanstack/router-cli1.167.23 → 1.167.24Dependent
@tanstack/router-generator1.167.23 → 1.167.24Dependent
@tanstack/router-plugin1.168.25 → 1.168.26Dependent
@tanstack/router-vite-plugin1.167.25 → 1.167.26Dependent
@tanstack/solid-start1.168.36 → 1.168.37Dependent
@tanstack/solid-start-client1.168.18 → 1.168.19Dependent
@tanstack/solid-start-server1.167.25 → 1.167.26Dependent
@tanstack/start-client-core1.170.16 → 1.170.17Dependent
@tanstack/start-plugin-core1.171.28 → 1.171.29Dependent
@tanstack/start-static-server-functions1.167.21 → 1.167.22Dependent
@tanstack/start-storage-context1.167.19 → 1.167.20Dependent
@tanstack/vue-start1.168.35 → 1.168.36Dependent
@tanstack/vue-start-client1.167.21 → 1.167.22Dependent
@tanstack/vue-start-server1.167.25 → 1.167.26Dependent
@nx-cloud
nx-cloudBot
commented
Aug 5, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
View your CI Pipeline Execution ↗ for commit abf9767
CommandStatusDurationResult
nx affected --targets=test:eslint,test:unit,tes...✅ Succeeded10m 30sView ↗
nx run-many --target=build --exclude=examples/*...✅ Succeeded1m 29sView ↗
☁️ Nx Cloud last updated this comment at 2026-08-06 11:13:14 UTC
@pkg-pr-new
pkg-pr-newBot
commented
Aug 5, 2026•

edited

Loading

Copy link


Copy Markdown

More templates
@tanstack/arktype-adapter
npm i https://pkg.pr.new/@tanstack/arktype-adapter@7970

@tanstack/eslint-plugin-router
npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@7970

@tanstack/eslint-plugin-start
npm i https://pkg.pr.new/@tanstack/eslint-plugin-start@7970

@tanstack/history
npm i https://pkg.pr.new/@tanstack/history@7970

@tanstack/nitro-v2-vite-plugin
npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@7970

@tanstack/react-router
npm i https://pkg.pr.new/@tanstack/react-router@7970

@tanstack/react-router-devtools
npm i https://pkg.pr.new/@tanstack/react-router-devtools@7970

@tanstack/react-router-ssr-query
npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@7970

@tanstack/react-start
npm i https://pkg.pr.new/@tanstack/react-start@7970

@tanstack/react-start-client
npm i https://pkg.pr.new/@tanstack/react-start-client@7970

@tanstack/react-start-rsc
npm i https://pkg.pr.new/@tanstack/react-start-rsc@7970

@tanstack/react-start-server
npm i https://pkg.pr.new/@tanstack/react-start-server@7970

@tanstack/router-cli
npm i https://pkg.pr.new/@tanstack/router-cli@7970

@tanstack/router-core
npm i https://pkg.pr.new/@tanstack/router-core@7970

@tanstack/router-devtools
npm i https://pkg.pr.new/@tanstack/router-devtools@7970

@tanstack/router-devtools-core
npm i https://pkg.pr.new/@tanstack/router-devtools-core@7970

@tanstack/router-generator
npm i https://pkg.pr.new/@tanstack/router-generator@7970

@tanstack/router-plugin
npm i https://pkg.pr.new/@tanstack/router-plugin@7970

@tanstack/router-ssr-query-core
npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@7970

@tanstack/router-utils
npm i https://pkg.pr.new/@tanstack/router-utils@7970

@tanstack/router-vite-plugin
npm i https://pkg.pr.new/@tanstack/router-vite-plugin@7970

@tanstack/solid-router
npm i https://pkg.pr.new/@tanstack/solid-router@7970

@tanstack/solid-router-devtools
npm i https://pkg.pr.new/@tanstack/solid-router-devtools@7970

@tanstack/solid-router-ssr-query
npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@7970

@tanstack/solid-start
npm i https://pkg.pr.new/@tanstack/solid-start@7970

@tanstack/solid-start-client
npm i https://pkg.pr.new/@tanstack/solid-start-client@7970

@tanstack/solid-start-server
npm i https://pkg.pr.new/@tanstack/solid-start-server@7970

@tanstack/start-client-core
npm i https://pkg.pr.new/@tanstack/start-client-core@7970

@tanstack/start-fn-stubs
npm i https://pkg.pr.new/@tanstack/start-fn-stubs@7970

@tanstack/start-plugin-core
npm i https://pkg.pr.new/@tanstack/start-plugin-core@7970

@tanstack/start-server-core
npm i https://pkg.pr.new/@tanstack/start-server-core@7970

@tanstack/start-static-server-functions
npm i https://pkg.pr.new/@tanstack/start-static-server-functions@7970

@tanstack/start-storage-context
npm i https://pkg.pr.new/@tanstack/start-storage-context@7970

@tanstack/valibot-adapter
npm i https://pkg.pr.new/@tanstack/valibot-adapter@7970

@tanstack/virtual-file-routes
npm i https://pkg.pr.new/@tanstack/virtual-file-routes@7970

@tanstack/vue-router
npm i https://pkg.pr.new/@tanstack/vue-router@7970

@tanstack/vue-router-devtools
npm i https://pkg.pr.new/@tanstack/vue-router-devtools@7970

@tanstack/vue-router-ssr-query
npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@7970

@tanstack/vue-start
npm i https://pkg.pr.new/@tanstack/vue-start@7970

@tanstack/vue-start-client
npm i https://pkg.pr.new/@tanstack/vue-start-client@7970

@tanstack/vue-start-server
npm i https://pkg.pr.new/@tanstack/vue-start-server@7970

@tanstack/zod-adapter
npm i https://pkg.pr.new/@tanstack/zod-adapter@7970

commit: abf9767
@github-actions
github-actionsBot
commented
Aug 5, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Bundle Size Benchmarks
  • Commit: c86f13a34b9a
  • Measured at: 2026-08-06T11:04:12.144Z
  • Baseline source: history:697ebb6ddbd4
  • Dashboard: bundle-size history
The following scenarios have bundle-size changes compared with the baseline:
ScenarioCurrent (gzip)Delta vs baselineInitial gzipRawBrotliTrend
react-router.minimal87.07 KiB-45 B (-0.05%)86.93 KiB269.02 KiB75.83 KiB████▂▂▂▂▂▁▂▁
react-router.full90.85 KiB-45 B (-0.05%)90.72 KiB280.97 KiB79.09 KiB████▃▃▃▃▃▂▂▁
solid-router.minimal34.76 KiB-38 B (-0.11%)34.63 KiB99.85 KiB31.33 KiB████▂▂▂▂▂▁▁▁
solid-router.full39.85 KiB-46 B (-0.11%)39.73 KiB115.03 KiB35.88 KiB████▂▂▂▂▂▁▁▁
vue-router.minimal52.05 KiB-48 B (-0.09%)51.92 KiB143.01 KiB46.83 KiB████▂▂▂▂▂▁▁▁
vue-router.full58.01 KiB-45 B (-0.08%)57.88 KiB161.68 KiB52.08 KiB████▂▂▂▂▂▁▁▁
react-start.minimal100.55 KiB-45 B (-0.04%)100.42 KiB312.17 KiB87.40 KiB███████▁▁▁▁▁
react-start.deferred-hydration101.29 KiB-47 B (-0.05%)100.44 KiB313.54 KiB87.99 KiB███████▁▁▁▁▁
react-start.full103.88 KiB-42 B (-0.04%)103.74 KiB322.12 KiB90.17 KiB███████▁▁▁▁▁
react-start.rsbuild.minimal100.21 KiB-30 B (-0.03%)100.04 KiB316.67 KiB86.35 KiB▁▁▁▁▂▂▂█████
react-start.rsbuild.minimal-iife100.61 KiB-36 B (-0.03%)100.44 KiB317.60 KiB86.75 KiB▁▁▁▁▂▂▂████▇
react-start.rsbuild.full103.52 KiB-46 B (-0.04%)103.35 KiB326.76 KiB89.11 KiB▁▁▁▁▃▃▃████▇
solid-start.minimal48.15 KiB-30 B (-0.06%)48.02 KiB141.99 KiB42.80 KiB███████▁▁▁▁▁
solid-start.deferred-hydration51.41 KiB-30 B (-0.06%)48.08 KiB150.03 KiB45.82 KiB███████▁▁▁▁▁
solid-start.full53.38 KiB-49 B (-0.09%)53.25 KiB157.72 KiB47.34 KiB████▆▆▆▁▁▁▁▁
vue-start.minimal68.94 KiB-36 B (-0.05%)68.81 KiB195.01 KiB61.33 KiB████▆▆▆▁▁▁▁▁
vue-start.full72.90 KiB-34 B (-0.05%)72.77 KiB207.51 KiB64.80 KiB████▆▆▆▁▁▁▁▁
Current gzip tracks all emitted client JS chunks. Initial gzip tracks only the entry/import graph. Trend sparkline is historical current gzip ending with this PR measurement; lower is better.
@codspeed-hq
codspeed-hqBot
commented
Aug 5, 2026•

edited

Loading

Copy link


Copy Markdown

Merging this PR will regress 0 benchmarks
⚠️Different runtime environments detected
Some benchmarks with significant performance changes were compared across different runtime environments,

which may affect the accuracy of the results.
Open the report in CodSpeed to investigate
⚡ 4 improved benchmarks
❌ 5 (👁 5) regressed benchmarks
✅ 171 untouched benchmarks
Performance Changes
ModeBenchmarkBASEHEADEfficiency
⚡Memorymem server server-fn-churn (vue)4,147.3 KB264.3 KB×16
⚡Memorymem server error-paths unmatched (vue)2,142.1 KB479 KB×4.5
⚡Memorymem server error-paths redirect (solid)388 KB283.1 KB+37.06%
⚡Memorymem client navigation-churn (vue)1.3 MB1.2 MB+3.81%
👁Simulationssr server-fn during document ssr (react)62.9 ms66.6 ms-5.62%
👁Memorymem server error-paths redirect (vue)338.6 KB422.4 KB-19.84%
👁Memorymem server error-paths not-found (react)277.7 KB287.1 KB-3.27%
👁Memorymem server error-paths unmatched (react)317.5 KB668.3 KB-52.49%
👁Memorymem server peak-large-page (react)1.7 MB2.2 MB-21.95%
Tip
Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.
Comparing codex/direct-create-file-route (abf9767) with main (697ebb6)
Open in CodSpeed
@Sheraff
Sheraff
marked this pull request as ready for review
August 6, 2026 06:59
coderabbitai[bot]
coderabbitaiBot
reviewed
Aug 6, 2026
View reviewed changes
@coderabbitaicoderabbitaiBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/react-router/src/fileRoute.ts`:
- Around line 60-65: Preserve the typed factory contract in createFileRoute by
replacing the wrapper’s options?: any and return createRoute as any with a
FileRoute<...>['createRoute']-compatible type, using one shared typed helper if
appropriate and retaining any unavoidable cast at a documented boundary. Apply
the same correction at packages/react-router/src/fileRoute.ts:60-65,
packages/solid-router/src/fileRoute.ts:49-54, and
packages/vue-router/src/fileRoute.ts:49-54; all three createRoute wrappers
require the change.

🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
  •  Push a commit to this branch (recommended)
  •  Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 14ac885f-fffc-41b1-807c-d6c3c7992d83
📥 Commits
Reviewing files that changed from the base of the PR and between 697ebb6 and d34c25f.
📒 Files selected for processing (6)
  • packages/react-router/src/fileRoute.ts
  • packages/react-router/tests/fileRoute.test.ts
  • packages/solid-router/src/fileRoute.ts
  • packages/solid-router/tests/fileRoute.test.ts
  • packages/vue-router/src/fileRoute.ts
  • packages/vue-router/tests/fileRoute.test.ts
Comment threadpackages/react-router/src/fileRoute.ts
Outdated

@Sheraff
Sheraff
merged commit 2435885
into
mainAug 6, 2026

26 checks passed

@Sheraff
Sheraff
deleted the

codex/direct-create-file-route

branch
August 6, 2026 11:38
@github-actionsgithub-actionsBot
mentioned this pull request
Aug 6, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@coderabbitaicoderabbitai[bot]coderabbitai[bot] left review comments

Assignees


No one assigned


Labels

package: react-routerpackage: solid-routerpackage: vue-router

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@Sheraff

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Create file routes directly - #7970
Merged
Sheraff merged 5 commits into
mainfrom 
codex/direct-create-file-route
Aug 6, 2026
Merged
Create file routes directly#7970
Sheraff merged 5 commits into
mainfrom 
codex/direct-create-file-route
Conversation
@Sheraff
@SheraffSheraff
commented
Aug 5, 2026•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Collaborator
What
  • have createFileRoute create the route directly in React, Solid, and Vue
  • keep the deprecated FileRoute class and its warning behavior intact
  • preserve isRoot = false for file routes
  • add mirrored factory/class behavior tests for all three frameworks
Why
The public factory only instantiated FileRoute to reuse its createRoute field while suppressing the class's deprecation warning. Creating the route directly removes that unnecessary class path from normal file-route bundles without changing the deprecated API.
Bundle impact
Prior isolated prototype measurements from the same main base:
  • react-router.minimal: -117 B raw, -40 B gzip, -20 B Brotli
  • solid-router.minimal: -117 B raw, -38 B gzip, +4 B Brotli
Measured for this PR head against the same base:
  • vue-router.minimal: -113 B raw, -49 B gzip, -42 B Brotli
Validation
  • React and Vue focused file-route unit tests
  • Solid full client/server unit suite (840 passed, 1 skipped; server suite 3 passed)
  • React, Solid, and Vue type tests
  • React, Solid, and Vue ESLint (0 errors; existing warnings only)
  • React, Solid, and Vue production builds
Summary by CodeRabbit
  • Bug Fixes
    • File-based route creation no longer produces an unexpected deprecation warning.
    • Routes created through the standard file-route API are correctly treated as non-root routes.
    • Direct use of the deprecated route API continues to display its warning.
  • Tests
    • Added coverage confirming route behavior and warning differences across React, Solid, and Vue integrations.
@coderabbitai
coderabbitaiBot
commented
Aug 5, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Review Change Stack
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 9603c18d-53a1-46d1-b9d2-725ddfb0c08e
📥 Commits
Reviewing files that changed from the base of the PR and between d34c25f and abf9767.
📒 Files selected for processing (4)
  • .changeset/easy-zoos-greet.md
  • packages/react-router/src/fileRoute.ts
  • packages/solid-router/src/fileRoute.ts
  • packages/vue-router/src/fileRoute.ts
🚧 Files skipped from review as they are similar to previous changes (1)
  • packages/solid-router/src/fileRoute.ts
📝 Walkthrough
Walkthrough
createFileRoute now calls the shared route factory directly in the React, Solid, and Vue routers. It marks routes as non-root without warning. Direct FileRoute construction retains its deprecation warning. Tests cover both behaviors.
Changes
File route factory behavior
Layer / File(s)Summary
Direct shared factory integration
packages/{react,solid,vue}-router/src/fileRoute.ts, .changeset/easy-zoos-greet.md		createFileRoute uses the shared route factory and sets isRoot to false. The changeset marks patch releases for the three router packages.
Factory and warning behavior tests
packages/{react,solid,vue}-router/tests/fileRoute.test.ts		Tests verify non-root routes, warning suppression for createFileRoute, warning retention for direct FileRoute usage, and mock cleanup.
Estimated code review effort: 3 (Moderate) | ~20 minutes
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly and concisely describes the main change: creating file routes directly.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  •  Create stacked PR
  •  Commit on current branch
🧪 Generate unit tests (beta)
  •  Create PR with unit tests
  •  Commit unit tests in branch codex/direct-create-file-route
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands.
@github-actions
github-actionsBot
commented
Aug 5, 2026

Copy link


Copy Markdown

Contributor
🚀 Changeset Version Preview
5 package(s) bumped directly, 18 bumped as dependents.
🟩 Patch bumps
PackageVersionReason
@tanstack/react-router1.170.20 → 1.170.21Changeset
@tanstack/router-core1.171.17 → 1.171.18Changeset
@tanstack/solid-router1.170.20 → 1.170.21Changeset
@tanstack/start-server-core1.169.20 → 1.169.21Changeset
@tanstack/vue-router1.170.19 → 1.170.20Changeset
@tanstack/react-start1.168.37 → 1.168.38Dependent
@tanstack/react-start-client1.168.18 → 1.168.19Dependent
@tanstack/react-start-rsc0.1.36 → 0.1.37Dependent
@tanstack/react-start-server1.167.25 → 1.167.26Dependent
@tanstack/router-cli1.167.23 → 1.167.24Dependent
@tanstack/router-generator1.167.23 → 1.167.24Dependent
@tanstack/router-plugin1.168.25 → 1.168.26Dependent
@tanstack/router-vite-plugin1.167.25 → 1.167.26Dependent
@tanstack/solid-start1.168.36 → 1.168.37Dependent
@tanstack/solid-start-client1.168.18 → 1.168.19Dependent
@tanstack/solid-start-server1.167.25 → 1.167.26Dependent
@tanstack/start-client-core1.170.16 → 1.170.17Dependent
@tanstack/start-plugin-core1.171.28 → 1.171.29Dependent
@tanstack/start-static-server-functions1.167.21 → 1.167.22Dependent
@tanstack/start-storage-context1.167.19 → 1.167.20Dependent
@tanstack/vue-start1.168.35 → 1.168.36Dependent
@tanstack/vue-start-client1.167.21 → 1.167.22Dependent
@tanstack/vue-start-server1.167.25 → 1.167.26Dependent
@nx-cloud
nx-cloudBot
commented
Aug 5, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
View your CI Pipeline Execution ↗ for commit abf9767
CommandStatusDurationResult
nx affected --targets=test:eslint,test:unit,tes...✅ Succeeded10m 30sView ↗
nx run-many --target=build --exclude=examples/*...✅ Succeeded1m 29sView ↗
☁️ Nx Cloud last updated this comment at 2026-08-06 11:13:14 UTC
@pkg-pr-new
pkg-pr-newBot
commented
Aug 5, 2026•

edited

Loading

Copy link


Copy Markdown

More templates
@tanstack/arktype-adapter
npm i https://pkg.pr.new/@tanstack/arktype-adapter@7970

@tanstack/eslint-plugin-router
npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@7970

@tanstack/eslint-plugin-start
npm i https://pkg.pr.new/@tanstack/eslint-plugin-start@7970

@tanstack/history
npm i https://pkg.pr.new/@tanstack/history@7970

@tanstack/nitro-v2-vite-plugin
npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@7970

@tanstack/react-router
npm i https://pkg.pr.new/@tanstack/react-router@7970

@tanstack/react-router-devtools
npm i https://pkg.pr.new/@tanstack/react-router-devtools@7970

@tanstack/react-router-ssr-query
npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@7970

@tanstack/react-start
npm i https://pkg.pr.new/@tanstack/react-start@7970

@tanstack/react-start-client
npm i https://pkg.pr.new/@tanstack/react-start-client@7970

@tanstack/react-start-rsc
npm i https://pkg.pr.new/@tanstack/react-start-rsc@7970

@tanstack/react-start-server
npm i https://pkg.pr.new/@tanstack/react-start-server@7970

@tanstack/router-cli
npm i https://pkg.pr.new/@tanstack/router-cli@7970

@tanstack/router-core
npm i https://pkg.pr.new/@tanstack/router-core@7970

@tanstack/router-devtools
npm i https://pkg.pr.new/@tanstack/router-devtools@7970

@tanstack/router-devtools-core
npm i https://pkg.pr.new/@tanstack/router-devtools-core@7970

@tanstack/router-generator
npm i https://pkg.pr.new/@tanstack/router-generator@7970

@tanstack/router-plugin
npm i https://pkg.pr.new/@tanstack/router-plugin@7970

@tanstack/router-ssr-query-core
npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@7970

@tanstack/router-utils
npm i https://pkg.pr.new/@tanstack/router-utils@7970

@tanstack/router-vite-plugin
npm i https://pkg.pr.new/@tanstack/router-vite-plugin@7970

@tanstack/solid-router
npm i https://pkg.pr.new/@tanstack/solid-router@7970

@tanstack/solid-router-devtools
npm i https://pkg.pr.new/@tanstack/solid-router-devtools@7970

@tanstack/solid-router-ssr-query
npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@7970

@tanstack/solid-start
npm i https://pkg.pr.new/@tanstack/solid-start@7970

@tanstack/solid-start-client
npm i https://pkg.pr.new/@tanstack/solid-start-client@7970

@tanstack/solid-start-server
npm i https://pkg.pr.new/@tanstack/solid-start-server@7970

@tanstack/start-client-core
npm i https://pkg.pr.new/@tanstack/start-client-core@7970

@tanstack/start-fn-stubs
npm i https://pkg.pr.new/@tanstack/start-fn-stubs@7970

@tanstack/start-plugin-core
npm i https://pkg.pr.new/@tanstack/start-plugin-core@7970

@tanstack/start-server-core
npm i https://pkg.pr.new/@tanstack/start-server-core@7970

@tanstack/start-static-server-functions
npm i https://pkg.pr.new/@tanstack/start-static-server-functions@7970

@tanstack/start-storage-context
npm i https://pkg.pr.new/@tanstack/start-storage-context@7970

@tanstack/valibot-adapter
npm i https://pkg.pr.new/@tanstack/valibot-adapter@7970

@tanstack/virtual-file-routes
npm i https://pkg.pr.new/@tanstack/virtual-file-routes@7970

@tanstack/vue-router
npm i https://pkg.pr.new/@tanstack/vue-router@7970

@tanstack/vue-router-devtools
npm i https://pkg.pr.new/@tanstack/vue-router-devtools@7970

@tanstack/vue-router-ssr-query
npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@7970

@tanstack/vue-start
npm i https://pkg.pr.new/@tanstack/vue-start@7970

@tanstack/vue-start-client
npm i https://pkg.pr.new/@tanstack/vue-start-client@7970

@tanstack/vue-start-server
npm i https://pkg.pr.new/@tanstack/vue-start-server@7970

@tanstack/zod-adapter
npm i https://pkg.pr.new/@tanstack/zod-adapter@7970

commit: abf9767
@github-actions
github-actionsBot
commented
Aug 5, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Bundle Size Benchmarks
  • Commit: c86f13a34b9a
  • Measured at: 2026-08-06T11:04:12.144Z
  • Baseline source: history:697ebb6ddbd4
  • Dashboard: bundle-size history
The following scenarios have bundle-size changes compared with the baseline:
ScenarioCurrent (gzip)Delta vs baselineInitial gzipRawBrotliTrend
react-router.minimal87.07 KiB-45 B (-0.05%)86.93 KiB269.02 KiB75.83 KiB████▂▂▂▂▂▁▂▁
react-router.full90.85 KiB-45 B (-0.05%)90.72 KiB280.97 KiB79.09 KiB████▃▃▃▃▃▂▂▁
solid-router.minimal34.76 KiB-38 B (-0.11%)34.63 KiB99.85 KiB31.33 KiB████▂▂▂▂▂▁▁▁
solid-router.full39.85 KiB-46 B (-0.11%)39.73 KiB115.03 KiB35.88 KiB████▂▂▂▂▂▁▁▁
vue-router.minimal52.05 KiB-48 B (-0.09%)51.92 KiB143.01 KiB46.83 KiB████▂▂▂▂▂▁▁▁
vue-router.full58.01 KiB-45 B (-0.08%)57.88 KiB161.68 KiB52.08 KiB████▂▂▂▂▂▁▁▁
react-start.minimal100.55 KiB-45 B (-0.04%)100.42 KiB312.17 KiB87.40 KiB███████▁▁▁▁▁
react-start.deferred-hydration101.29 KiB-47 B (-0.05%)100.44 KiB313.54 KiB87.99 KiB███████▁▁▁▁▁
react-start.full103.88 KiB-42 B (-0.04%)103.74 KiB322.12 KiB90.17 KiB███████▁▁▁▁▁
react-start.rsbuild.minimal100.21 KiB-30 B (-0.03%)100.04 KiB316.67 KiB86.35 KiB▁▁▁▁▂▂▂█████
react-start.rsbuild.minimal-iife100.61 KiB-36 B (-0.03%)100.44 KiB317.60 KiB86.75 KiB▁▁▁▁▂▂▂████▇
react-start.rsbuild.full103.52 KiB-46 B (-0.04%)103.35 KiB326.76 KiB89.11 KiB▁▁▁▁▃▃▃████▇
solid-start.minimal48.15 KiB-30 B (-0.06%)48.02 KiB141.99 KiB42.80 KiB███████▁▁▁▁▁
solid-start.deferred-hydration51.41 KiB-30 B (-0.06%)48.08 KiB150.03 KiB45.82 KiB███████▁▁▁▁▁
solid-start.full53.38 KiB-49 B (-0.09%)53.25 KiB157.72 KiB47.34 KiB████▆▆▆▁▁▁▁▁
vue-start.minimal68.94 KiB-36 B (-0.05%)68.81 KiB195.01 KiB61.33 KiB████▆▆▆▁▁▁▁▁
vue-start.full72.90 KiB-34 B (-0.05%)72.77 KiB207.51 KiB64.80 KiB████▆▆▆▁▁▁▁▁
Current gzip tracks all emitted client JS chunks. Initial gzip tracks only the entry/import graph. Trend sparkline is historical current gzip ending with this PR measurement; lower is better.
@codspeed-hq
codspeed-hqBot
commented
Aug 5, 2026•

edited

Loading

Copy link


Copy Markdown

Merging this PR will regress 0 benchmarks
⚠️Different runtime environments detected
Some benchmarks with significant performance changes were compared across different runtime environments,

which may affect the accuracy of the results.
Open the report in CodSpeed to investigate
⚡ 4 improved benchmarks
❌ 5 (👁 5) regressed benchmarks
✅ 171 untouched benchmarks
Performance Changes
ModeBenchmarkBASEHEADEfficiency
⚡Memorymem server server-fn-churn (vue)4,147.3 KB264.3 KB×16
⚡Memorymem server error-paths unmatched (vue)2,142.1 KB479 KB×4.5
⚡Memorymem server error-paths redirect (solid)388 KB283.1 KB+37.06%
⚡Memorymem client navigation-churn (vue)1.3 MB1.2 MB+3.81%
👁Simulationssr server-fn during document ssr (react)62.9 ms66.6 ms-5.62%
👁Memorymem server error-paths redirect (vue)338.6 KB422.4 KB-19.84%
👁Memorymem server error-paths not-found (react)277.7 KB287.1 KB-3.27%
👁Memorymem server error-paths unmatched (react)317.5 KB668.3 KB-52.49%
👁Memorymem server peak-large-page (react)1.7 MB2.2 MB-21.95%
Tip
Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.
Comparing codex/direct-create-file-route (abf9767) with main (697ebb6)
Open in CodSpeed
@Sheraff
Sheraff
marked this pull request as ready for review
August 6, 2026 06:59
coderabbitai[bot]
coderabbitaiBot
reviewed
Aug 6, 2026
View reviewed changes
@coderabbitaicoderabbitaiBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/react-router/src/fileRoute.ts`:
- Around line 60-65: Preserve the typed factory contract in createFileRoute by
replacing the wrapper’s options?: any and return createRoute as any with a
FileRoute<...>['createRoute']-compatible type, using one shared typed helper if
appropriate and retaining any unavoidable cast at a documented boundary. Apply
the same correction at packages/react-router/src/fileRoute.ts:60-65,
packages/solid-router/src/fileRoute.ts:49-54, and
packages/vue-router/src/fileRoute.ts:49-54; all three createRoute wrappers
require the change.

🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
  •  Push a commit to this branch (recommended)
  •  Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 14ac885f-fffc-41b1-807c-d6c3c7992d83
📥 Commits
Reviewing files that changed from the base of the PR and between 697ebb6 and d34c25f.
📒 Files selected for processing (6)
  • packages/react-router/src/fileRoute.ts
  • packages/react-router/tests/fileRoute.test.ts
  • packages/solid-router/src/fileRoute.ts
  • packages/solid-router/tests/fileRoute.test.ts
  • packages/vue-router/src/fileRoute.ts
  • packages/vue-router/tests/fileRoute.test.ts
Comment threadpackages/react-router/src/fileRoute.ts
Outdated

@Sheraff
Sheraff
merged commit 2435885
into
mainAug 6, 2026

26 checks passed

@Sheraff
Sheraff
deleted the

codex/direct-create-file-route

branch
August 6, 2026 11:38
@github-actionsgithub-actionsBot
mentioned this pull request
Aug 6, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@coderabbitaicoderabbitai[bot]coderabbitai[bot] left review comments

Assignees


No one assigned


Labels

package: react-routerpackage: solid-routerpackage: vue-router

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@Sheraff

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Create file routes directly - #7970
Merged
Sheraff merged 5 commits into
mainfrom 
codex/direct-create-file-route
Aug 6, 2026
Merged
Create file routes directly#7970
Sheraff merged 5 commits into
mainfrom 
codex/direct-create-file-route
Conversation
@Sheraff
@SheraffSheraff
commented
Aug 5, 2026•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Collaborator
What
  • have createFileRoute create the route directly in React, Solid, and Vue
  • keep the deprecated FileRoute class and its warning behavior intact
  • preserve isRoot = false for file routes
  • add mirrored factory/class behavior tests for all three frameworks
Why
The public factory only instantiated FileRoute to reuse its createRoute field while suppressing the class's deprecation warning. Creating the route directly removes that unnecessary class path from normal file-route bundles without changing the deprecated API.
Bundle impact
Prior isolated prototype measurements from the same main base:
  • react-router.minimal: -117 B raw, -40 B gzip, -20 B Brotli
  • solid-router.minimal: -117 B raw, -38 B gzip, +4 B Brotli
Measured for this PR head against the same base:
  • vue-router.minimal: -113 B raw, -49 B gzip, -42 B Brotli
Validation
  • React and Vue focused file-route unit tests
  • Solid full client/server unit suite (840 passed, 1 skipped; server suite 3 passed)
  • React, Solid, and Vue type tests
  • React, Solid, and Vue ESLint (0 errors; existing warnings only)
  • React, Solid, and Vue production builds
Summary by CodeRabbit
  • Bug Fixes
    • File-based route creation no longer produces an unexpected deprecation warning.
    • Routes created through the standard file-route API are correctly treated as non-root routes.
    • Direct use of the deprecated route API continues to display its warning.
  • Tests
    • Added coverage confirming route behavior and warning differences across React, Solid, and Vue integrations.
@coderabbitai
coderabbitaiBot
commented
Aug 5, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Review Change Stack
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 9603c18d-53a1-46d1-b9d2-725ddfb0c08e
📥 Commits
Reviewing files that changed from the base of the PR and between d34c25f and abf9767.
📒 Files selected for processing (4)
  • .changeset/easy-zoos-greet.md
  • packages/react-router/src/fileRoute.ts
  • packages/solid-router/src/fileRoute.ts
  • packages/vue-router/src/fileRoute.ts
🚧 Files skipped from review as they are similar to previous changes (1)
  • packages/solid-router/src/fileRoute.ts
📝 Walkthrough
Walkthrough
createFileRoute now calls the shared route factory directly in the React, Solid, and Vue routers. It marks routes as non-root without warning. Direct FileRoute construction retains its deprecation warning. Tests cover both behaviors.
Changes
File route factory behavior
Layer / File(s)Summary
Direct shared factory integration
packages/{react,solid,vue}-router/src/fileRoute.ts, .changeset/easy-zoos-greet.md		createFileRoute uses the shared route factory and sets isRoot to false. The changeset marks patch releases for the three router packages.
Factory and warning behavior tests
packages/{react,solid,vue}-router/tests/fileRoute.test.ts		Tests verify non-root routes, warning suppression for createFileRoute, warning retention for direct FileRoute usage, and mock cleanup.
Estimated code review effort: 3 (Moderate) | ~20 minutes
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly and concisely describes the main change: creating file routes directly.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  •  Create stacked PR
  •  Commit on current branch
🧪 Generate unit tests (beta)
  •  Create PR with unit tests
  •  Commit unit tests in branch codex/direct-create-file-route
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands.
@github-actions
github-actionsBot
commented
Aug 5, 2026

Copy link


Copy Markdown

Contributor
🚀 Changeset Version Preview
5 package(s) bumped directly, 18 bumped as dependents.
🟩 Patch bumps
PackageVersionReason
@tanstack/react-router1.170.20 → 1.170.21Changeset
@tanstack/router-core1.171.17 → 1.171.18Changeset
@tanstack/solid-router1.170.20 → 1.170.21Changeset
@tanstack/start-server-core1.169.20 → 1.169.21Changeset
@tanstack/vue-router1.170.19 → 1.170.20Changeset
@tanstack/react-start1.168.37 → 1.168.38Dependent
@tanstack/react-start-client1.168.18 → 1.168.19Dependent
@tanstack/react-start-rsc0.1.36 → 0.1.37Dependent
@tanstack/react-start-server1.167.25 → 1.167.26Dependent
@tanstack/router-cli1.167.23 → 1.167.24Dependent
@tanstack/router-generator1.167.23 → 1.167.24Dependent
@tanstack/router-plugin1.168.25 → 1.168.26Dependent
@tanstack/router-vite-plugin1.167.25 → 1.167.26Dependent
@tanstack/solid-start1.168.36 → 1.168.37Dependent
@tanstack/solid-start-client1.168.18 → 1.168.19Dependent
@tanstack/solid-start-server1.167.25 → 1.167.26Dependent
@tanstack/start-client-core1.170.16 → 1.170.17Dependent
@tanstack/start-plugin-core1.171.28 → 1.171.29Dependent
@tanstack/start-static-server-functions1.167.21 → 1.167.22Dependent
@tanstack/start-storage-context1.167.19 → 1.167.20Dependent
@tanstack/vue-start1.168.35 → 1.168.36Dependent
@tanstack/vue-start-client1.167.21 → 1.167.22Dependent
@tanstack/vue-start-server1.167.25 → 1.167.26Dependent
@nx-cloud
nx-cloudBot
commented
Aug 5, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
View your CI Pipeline Execution ↗ for commit abf9767
CommandStatusDurationResult
nx affected --targets=test:eslint,test:unit,tes...✅ Succeeded10m 30sView ↗
nx run-many --target=build --exclude=examples/*...✅ Succeeded1m 29sView ↗
☁️ Nx Cloud last updated this comment at 2026-08-06 11:13:14 UTC
@pkg-pr-new
pkg-pr-newBot
commented
Aug 5, 2026•

edited

Loading

Copy link


Copy Markdown

More templates
@tanstack/arktype-adapter
npm i https://pkg.pr.new/@tanstack/arktype-adapter@7970

@tanstack/eslint-plugin-router
npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@7970

@tanstack/eslint-plugin-start
npm i https://pkg.pr.new/@tanstack/eslint-plugin-start@7970

@tanstack/history
npm i https://pkg.pr.new/@tanstack/history@7970

@tanstack/nitro-v2-vite-plugin
npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@7970

@tanstack/react-router
npm i https://pkg.pr.new/@tanstack/react-router@7970

@tanstack/react-router-devtools
npm i https://pkg.pr.new/@tanstack/react-router-devtools@7970

@tanstack/react-router-ssr-query
npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@7970

@tanstack/react-start
npm i https://pkg.pr.new/@tanstack/react-start@7970

@tanstack/react-start-client
npm i https://pkg.pr.new/@tanstack/react-start-client@7970

@tanstack/react-start-rsc
npm i https://pkg.pr.new/@tanstack/react-start-rsc@7970

@tanstack/react-start-server
npm i https://pkg.pr.new/@tanstack/react-start-server@7970

@tanstack/router-cli
npm i https://pkg.pr.new/@tanstack/router-cli@7970

@tanstack/router-core
npm i https://pkg.pr.new/@tanstack/router-core@7970

@tanstack/router-devtools
npm i https://pkg.pr.new/@tanstack/router-devtools@7970

@tanstack/router-devtools-core
npm i https://pkg.pr.new/@tanstack/router-devtools-core@7970

@tanstack/router-generator
npm i https://pkg.pr.new/@tanstack/router-generator@7970

@tanstack/router-plugin
npm i https://pkg.pr.new/@tanstack/router-plugin@7970

@tanstack/router-ssr-query-core
npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@7970

@tanstack/router-utils
npm i https://pkg.pr.new/@tanstack/router-utils@7970

@tanstack/router-vite-plugin
npm i https://pkg.pr.new/@tanstack/router-vite-plugin@7970

@tanstack/solid-router
npm i https://pkg.pr.new/@tanstack/solid-router@7970

@tanstack/solid-router-devtools
npm i https://pkg.pr.new/@tanstack/solid-router-devtools@7970

@tanstack/solid-router-ssr-query
npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@7970

@tanstack/solid-start
npm i https://pkg.pr.new/@tanstack/solid-start@7970

@tanstack/solid-start-client
npm i https://pkg.pr.new/@tanstack/solid-start-client@7970

@tanstack/solid-start-server
npm i https://pkg.pr.new/@tanstack/solid-start-server@7970

@tanstack/start-client-core
npm i https://pkg.pr.new/@tanstack/start-client-core@7970

@tanstack/start-fn-stubs
npm i https://pkg.pr.new/@tanstack/start-fn-stubs@7970

@tanstack/start-plugin-core
npm i https://pkg.pr.new/@tanstack/start-plugin-core@7970

@tanstack/start-server-core
npm i https://pkg.pr.new/@tanstack/start-server-core@7970

@tanstack/start-static-server-functions
npm i https://pkg.pr.new/@tanstack/start-static-server-functions@7970

@tanstack/start-storage-context
npm i https://pkg.pr.new/@tanstack/start-storage-context@7970

@tanstack/valibot-adapter
npm i https://pkg.pr.new/@tanstack/valibot-adapter@7970

@tanstack/virtual-file-routes
npm i https://pkg.pr.new/@tanstack/virtual-file-routes@7970

@tanstack/vue-router
npm i https://pkg.pr.new/@tanstack/vue-router@7970

@tanstack/vue-router-devtools
npm i https://pkg.pr.new/@tanstack/vue-router-devtools@7970

@tanstack/vue-router-ssr-query
npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@7970

@tanstack/vue-start
npm i https://pkg.pr.new/@tanstack/vue-start@7970

@tanstack/vue-start-client
npm i https://pkg.pr.new/@tanstack/vue-start-client@7970

@tanstack/vue-start-server
npm i https://pkg.pr.new/@tanstack/vue-start-server@7970

@tanstack/zod-adapter
npm i https://pkg.pr.new/@tanstack/zod-adapter@7970

commit: abf9767
@github-actions
github-actionsBot
commented
Aug 5, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Bundle Size Benchmarks
  • Commit: c86f13a34b9a
  • Measured at: 2026-08-06T11:04:12.144Z
  • Baseline source: history:697ebb6ddbd4
  • Dashboard: bundle-size history
The following scenarios have bundle-size changes compared with the baseline:
ScenarioCurrent (gzip)Delta vs baselineInitial gzipRawBrotliTrend
react-router.minimal87.07 KiB-45 B (-0.05%)86.93 KiB269.02 KiB75.83 KiB████▂▂▂▂▂▁▂▁
react-router.full90.85 KiB-45 B (-0.05%)90.72 KiB280.97 KiB79.09 KiB████▃▃▃▃▃▂▂▁
solid-router.minimal34.76 KiB-38 B (-0.11%)34.63 KiB99.85 KiB31.33 KiB████▂▂▂▂▂▁▁▁
solid-router.full39.85 KiB-46 B (-0.11%)39.73 KiB115.03 KiB35.88 KiB████▂▂▂▂▂▁▁▁
vue-router.minimal52.05 KiB-48 B (-0.09%)51.92 KiB143.01 KiB46.83 KiB████▂▂▂▂▂▁▁▁
vue-router.full58.01 KiB-45 B (-0.08%)57.88 KiB161.68 KiB52.08 KiB████▂▂▂▂▂▁▁▁
react-start.minimal100.55 KiB-45 B (-0.04%)100.42 KiB312.17 KiB87.40 KiB███████▁▁▁▁▁
react-start.deferred-hydration101.29 KiB-47 B (-0.05%)100.44 KiB313.54 KiB87.99 KiB███████▁▁▁▁▁
react-start.full103.88 KiB-42 B (-0.04%)103.74 KiB322.12 KiB90.17 KiB███████▁▁▁▁▁
react-start.rsbuild.minimal100.21 KiB-30 B (-0.03%)100.04 KiB316.67 KiB86.35 KiB▁▁▁▁▂▂▂█████
react-start.rsbuild.minimal-iife100.61 KiB-36 B (-0.03%)100.44 KiB317.60 KiB86.75 KiB▁▁▁▁▂▂▂████▇
react-start.rsbuild.full103.52 KiB-46 B (-0.04%)103.35 KiB326.76 KiB89.11 KiB▁▁▁▁▃▃▃████▇
solid-start.minimal48.15 KiB-30 B (-0.06%)48.02 KiB141.99 KiB42.80 KiB███████▁▁▁▁▁
solid-start.deferred-hydration51.41 KiB-30 B (-0.06%)48.08 KiB150.03 KiB45.82 KiB███████▁▁▁▁▁
solid-start.full53.38 KiB-49 B (-0.09%)53.25 KiB157.72 KiB47.34 KiB████▆▆▆▁▁▁▁▁
vue-start.minimal68.94 KiB-36 B (-0.05%)68.81 KiB195.01 KiB61.33 KiB████▆▆▆▁▁▁▁▁
vue-start.full72.90 KiB-34 B (-0.05%)72.77 KiB207.51 KiB64.80 KiB████▆▆▆▁▁▁▁▁
Current gzip tracks all emitted client JS chunks. Initial gzip tracks only the entry/import graph. Trend sparkline is historical current gzip ending with this PR measurement; lower is better.
@codspeed-hq
codspeed-hqBot
commented
Aug 5, 2026•

edited

Loading

Copy link


Copy Markdown

Merging this PR will regress 0 benchmarks
⚠️Different runtime environments detected
Some benchmarks with significant performance changes were compared across different runtime environments,

which may affect the accuracy of the results.
Open the report in CodSpeed to investigate
⚡ 4 improved benchmarks
❌ 5 (👁 5) regressed benchmarks
✅ 171 untouched benchmarks
Performance Changes
ModeBenchmarkBASEHEADEfficiency
⚡Memorymem server server-fn-churn (vue)4,147.3 KB264.3 KB×16
⚡Memorymem server error-paths unmatched (vue)2,142.1 KB479 KB×4.5
⚡Memorymem server error-paths redirect (solid)388 KB283.1 KB+37.06%
⚡Memorymem client navigation-churn (vue)1.3 MB1.2 MB+3.81%
👁Simulationssr server-fn during document ssr (react)62.9 ms66.6 ms-5.62%
👁Memorymem server error-paths redirect (vue)338.6 KB422.4 KB-19.84%
👁Memorymem server error-paths not-found (react)277.7 KB287.1 KB-3.27%
👁Memorymem server error-paths unmatched (react)317.5 KB668.3 KB-52.49%
👁Memorymem server peak-large-page (react)1.7 MB2.2 MB-21.95%
Tip
Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.
Comparing codex/direct-create-file-route (abf9767) with main (697ebb6)
Open in CodSpeed
@Sheraff
Sheraff
marked this pull request as ready for review
August 6, 2026 06:59
coderabbitai[bot]
coderabbitaiBot
reviewed
Aug 6, 2026
View reviewed changes
@coderabbitaicoderabbitaiBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/react-router/src/fileRoute.ts`:
- Around line 60-65: Preserve the typed factory contract in createFileRoute by
replacing the wrapper’s options?: any and return createRoute as any with a
FileRoute<...>['createRoute']-compatible type, using one shared typed helper if
appropriate and retaining any unavoidable cast at a documented boundary. Apply
the same correction at packages/react-router/src/fileRoute.ts:60-65,
packages/solid-router/src/fileRoute.ts:49-54, and
packages/vue-router/src/fileRoute.ts:49-54; all three createRoute wrappers
require the change.

🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
  •  Push a commit to this branch (recommended)
  •  Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 14ac885f-fffc-41b1-807c-d6c3c7992d83
📥 Commits
Reviewing files that changed from the base of the PR and between 697ebb6 and d34c25f.
📒 Files selected for processing (6)
  • packages/react-router/src/fileRoute.ts
  • packages/react-router/tests/fileRoute.test.ts
  • packages/solid-router/src/fileRoute.ts
  • packages/solid-router/tests/fileRoute.test.ts
  • packages/vue-router/src/fileRoute.ts
  • packages/vue-router/tests/fileRoute.test.ts
Comment threadpackages/react-router/src/fileRoute.ts
Outdated

@Sheraff
Sheraff
merged commit 2435885
into
mainAug 6, 2026

26 checks passed

@Sheraff
Sheraff
deleted the

codex/direct-create-file-route

branch
August 6, 2026 11:38
@github-actionsgithub-actionsBot
mentioned this pull request
Aug 6, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@coderabbitaicoderabbitai[bot]coderabbitai[bot] left review comments

Assignees


No one assigned


Labels

package: react-routerpackage: solid-routerpackage: vue-router

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@Sheraff