Pass intersection observer disabled state directly - #7971

Merged
Sheraff merged 4 commits into
mainfrom
codex/direct-intersection-observer-disabled
Aug 6, 2026
Merged

Pass intersection observer disabled state directly#7971
Sheraff merged 4 commits into
mainfrom
codex/direct-intersection-observer-disabled

Conversation

@Sheraff

@SheraffSheraff commented Aug 5, 2026•
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Collaborator

Summary

  • pass the disabled boolean directly to the React and Solid intersection-observer helpers
  • pass Vue's reactive disabled getter directly, preserving watchEffect tracking
  • cover disabled viewport links and reactive observer teardown in Vue

Bundle-size impact

Prior isolated prototype measurements from the same main base (6aefb33925):

ScenarioRawGzipBrotli
react-router.minimal-32 B-10 B-3 B
solid-router.minimal-23 B-4 B-65 B

The final Vue hunk, measured against an otherwise identical worktree:

ScenarioRawGzipBrotli
vue-router.minimal-68 B-25 B+62 B

Gzip is the benchmark's primary metric.

Validation

  • React link tests: 131 passed
  • Solid unit tests: 838 client tests passed (1 skipped), 3 server tests passed
  • Vue link tests: 131 passed
  • React, Solid, and Vue type tests passed
  • React, Solid, and Vue builds passed
  • React, Solid, and Vue ESLint targets passed with existing warnings only

Summary by CodeRabbit

  • Bug Fixes

    • Improved viewport-based link preloading behavior across React, Solid, and Vue.
    • Links now correctly skip observation when disabled or when viewport preloading is unavailable.
    • Preloading observation now responds correctly when link conditions change.
    • Updated behavior is consistent across supported framework integrations.

  • Tests

    • Added coverage confirming disabled links are not observed and that observation starts or stops as conditions change.

@coderabbitai

coderabbitaiBot commented Aug 5, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

The change separates disabled state from IntersectionObserverInit options in React, Solid, and Vue utilities. Link integrations use the new signatures. Vue tests cover disabled links and reactive observer lifecycle behavior.

Changes

Intersection observer API update

Layer / File(s)Summary
Update observer utility signatures
packages/react-router/src/utils.ts, packages/solid-router/src/utils.ts, packages/vue-router/src/utils.ts, .changeset/quiet-doors-double.md		The utilities accept observer options separately from disabled state. The observer checks, examples, and documentation use the new parameters. A patch changeset covers the three router packages.
Update link observer calls
packages/react-router/src/link.tsx, packages/solid-router/src/link.tsx, packages/vue-router/src/link.tsx		Links pass boolean or callback disabled conditions directly to useIntersectionObserver.
Validate Vue observer behavior
packages/vue-router/tests/link.test.tsx		Tests verify that disabled viewport links are not observed and that observer creation and disconnection react to a disabled getter.

Estimated code review effort: 3 (Moderate) | ~20 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 66.67% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly and concisely describes the main change: passing the intersection observer disabled state directly.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/direct-intersection-observer-disabled

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@nx-cloud

nx-cloudBot commented Aug 5, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

View your CI Pipeline Execution ↗ for commit 7d62f08

CommandStatusDurationResult
nx affected --targets=test:eslint,test:unit,tes...✅ Succeeded2m 38sView ↗

☁️ Nx Cloud last updated this comment at 2026-08-06 11:10:43 UTC

@github-actions

github-actionsBot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

🚀 Changeset Version Preview

5 package(s) bumped directly, 18 bumped as dependents.

🟩 Patch bumps

PackageVersionReason
@tanstack/react-router1.170.20 → 1.170.21Changeset
@tanstack/router-core1.171.17 → 1.171.18Changeset
@tanstack/solid-router1.170.20 → 1.170.21Changeset
@tanstack/start-server-core1.169.20 → 1.169.21Changeset
@tanstack/vue-router1.170.19 → 1.170.20Changeset
@tanstack/react-start1.168.37 → 1.168.38Dependent
@tanstack/react-start-client1.168.18 → 1.168.19Dependent
@tanstack/react-start-rsc0.1.36 → 0.1.37Dependent
@tanstack/react-start-server1.167.25 → 1.167.26Dependent
@tanstack/router-cli1.167.23 → 1.167.24Dependent
@tanstack/router-generator1.167.23 → 1.167.24Dependent
@tanstack/router-plugin1.168.25 → 1.168.26Dependent
@tanstack/router-vite-plugin1.167.25 → 1.167.26Dependent
@tanstack/solid-start1.168.36 → 1.168.37Dependent
@tanstack/solid-start-client1.168.18 → 1.168.19Dependent
@tanstack/solid-start-server1.167.25 → 1.167.26Dependent
@tanstack/start-client-core1.170.16 → 1.170.17Dependent
@tanstack/start-plugin-core1.171.28 → 1.171.29Dependent
@tanstack/start-static-server-functions1.167.21 → 1.167.22Dependent
@tanstack/start-storage-context1.167.19 → 1.167.20Dependent
@tanstack/vue-start1.168.35 → 1.168.36Dependent
@tanstack/vue-start-client1.167.21 → 1.167.22Dependent
@tanstack/vue-start-server1.167.25 → 1.167.26Dependent

@github-actions

github-actionsBot commented Aug 5, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

Bundle Size Benchmarks

  • Commit: 5d9d59b8b9d5
  • Measured at: 2026-08-06T10:52:17.935Z
  • Baseline source: history:697ebb6ddbd4
  • Dashboard: bundle-size history

The following scenarios have bundle-size changes compared with the baseline:

ScenarioCurrent (gzip)Delta vs baselineInitial gzipRawBrotliTrend
react-router.minimal87.10 KiB-8 B (-0.01%)86.97 KiB269.10 KiB75.87 KiB████▂▂▂▂▂▁▂▁
react-router.full90.89 KiB-4 B (-0.00%)90.75 KiB281.06 KiB79.10 KiB████▂▂▂▂▂▁▂▂
solid-router.minimal34.79 KiB-2 B (-0.01%)34.67 KiB99.95 KiB31.35 KiB████▂▂▂▂▂▁▁▁
solid-router.full39.90 KiB-3 B (-0.01%)39.77 KiB115.12 KiB35.92 KiB████▂▂▂▂▂▁▁▁
vue-router.minimal52.07 KiB-24 B (-0.04%)51.94 KiB143.05 KiB46.90 KiB████▂▂▂▂▂▁▁▁
vue-router.full58.03 KiB-21 B (-0.04%)57.90 KiB161.73 KiB52.05 KiB████▂▂▂▂▂▁▁▁
react-start.minimal100.59 KiB-5 B (-0.00%)100.46 KiB312.25 KiB87.36 KiB███████▁▁▁▁▁
react-start.deferred-hydration101.33 KiB-9 B (-0.01%)100.48 KiB313.63 KiB87.99 KiB███████▁▁▁▁▁
react-start.full103.91 KiB-8 B (-0.01%)103.78 KiB322.20 KiB90.18 KiB███████▁▁▁▁▁
react-start.rsbuild.minimal100.23 KiB-4 B (-0.00%)100.06 KiB316.74 KiB86.39 KiB▁▁▁▁▂▂▂█████
react-start.rsbuild.minimal-iife100.64 KiB-3 B (-0.00%)100.48 KiB317.67 KiB86.73 KiB▁▁▁▁▂▂▂█████
react-start.rsbuild.full103.56 KiB-5 B (-0.00%)103.39 KiB326.83 KiB89.12 KiB▁▁▁▁▃▃▃█████
solid-start.minimal48.18 KiB-1 B (-0.00%)48.05 KiB142.08 KiB42.78 KiB███████▁▁▁▁▁
solid-start.full53.42 KiB-10 B (-0.02%)53.29 KiB157.82 KiB47.41 KiB████▆▆▆▁▁▁▁▁
vue-start.minimal68.95 KiB-26 B (-0.04%)68.82 KiB195.05 KiB61.26 KiB████▆▆▆▁▁▁▁▁
vue-start.full72.91 KiB-22 B (-0.03%)72.78 KiB207.55 KiB64.71 KiB████▆▆▆▁▁▁▁▁

Current gzip tracks all emitted client JS chunks. Initial gzip tracks only the entry/import graph. Trend sparkline is historical current gzip ending with this PR measurement; lower is better.

@pkg-pr-new

pkg-pr-newBot commented Aug 5, 2026•
edited
Loading

Copy link
Copy Markdown
More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/@tanstack/arktype-adapter@7971

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@7971

@tanstack/eslint-plugin-start

npm i https://pkg.pr.new/@tanstack/eslint-plugin-start@7971

@tanstack/history

npm i https://pkg.pr.new/@tanstack/history@7971

@tanstack/nitro-v2-vite-plugin

npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@7971

@tanstack/react-router

npm i https://pkg.pr.new/@tanstack/react-router@7971

@tanstack/react-router-devtools

npm i https://pkg.pr.new/@tanstack/react-router-devtools@7971

@tanstack/react-router-ssr-query

npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@7971

@tanstack/react-start

npm i https://pkg.pr.new/@tanstack/react-start@7971

@tanstack/react-start-client

npm i https://pkg.pr.new/@tanstack/react-start-client@7971

@tanstack/react-start-rsc

npm i https://pkg.pr.new/@tanstack/react-start-rsc@7971

@tanstack/react-start-server

npm i https://pkg.pr.new/@tanstack/react-start-server@7971

@tanstack/router-cli

npm i https://pkg.pr.new/@tanstack/router-cli@7971

@tanstack/router-core

npm i https://pkg.pr.new/@tanstack/router-core@7971

@tanstack/router-devtools

npm i https://pkg.pr.new/@tanstack/router-devtools@7971

@tanstack/router-devtools-core

npm i https://pkg.pr.new/@tanstack/router-devtools-core@7971

@tanstack/router-generator

npm i https://pkg.pr.new/@tanstack/router-generator@7971

@tanstack/router-plugin

npm i https://pkg.pr.new/@tanstack/router-plugin@7971

@tanstack/router-ssr-query-core

npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@7971

@tanstack/router-utils

npm i https://pkg.pr.new/@tanstack/router-utils@7971

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/@tanstack/router-vite-plugin@7971

@tanstack/solid-router

npm i https://pkg.pr.new/@tanstack/solid-router@7971

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/@tanstack/solid-router-devtools@7971

@tanstack/solid-router-ssr-query

npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@7971

@tanstack/solid-start

npm i https://pkg.pr.new/@tanstack/solid-start@7971

@tanstack/solid-start-client

npm i https://pkg.pr.new/@tanstack/solid-start-client@7971

@tanstack/solid-start-server

npm i https://pkg.pr.new/@tanstack/solid-start-server@7971

@tanstack/start-client-core

npm i https://pkg.pr.new/@tanstack/start-client-core@7971

@tanstack/start-fn-stubs

npm i https://pkg.pr.new/@tanstack/start-fn-stubs@7971

@tanstack/start-plugin-core

npm i https://pkg.pr.new/@tanstack/start-plugin-core@7971

@tanstack/start-server-core

npm i https://pkg.pr.new/@tanstack/start-server-core@7971

@tanstack/start-static-server-functions

npm i https://pkg.pr.new/@tanstack/start-static-server-functions@7971

@tanstack/start-storage-context

npm i https://pkg.pr.new/@tanstack/start-storage-context@7971

@tanstack/valibot-adapter

npm i https://pkg.pr.new/@tanstack/valibot-adapter@7971

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/@tanstack/virtual-file-routes@7971

@tanstack/vue-router

npm i https://pkg.pr.new/@tanstack/vue-router@7971

@tanstack/vue-router-devtools

npm i https://pkg.pr.new/@tanstack/vue-router-devtools@7971

@tanstack/vue-router-ssr-query

npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@7971

@tanstack/vue-start

npm i https://pkg.pr.new/@tanstack/vue-start@7971

@tanstack/vue-start-client

npm i https://pkg.pr.new/@tanstack/vue-start-client@7971

@tanstack/vue-start-server

npm i https://pkg.pr.new/@tanstack/vue-start-server@7971

@tanstack/zod-adapter

npm i https://pkg.pr.new/@tanstack/zod-adapter@7971

commit: 7d62f08

@codspeed-hq

codspeed-hqBot commented Aug 5, 2026•
edited
Loading

Copy link
Copy Markdown

Merging this PR will regress 0 benchmarks

⚠️Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 9 improved benchmarks
❌ 6 (👁 6) regressed benchmarks
✅ 165 untouched benchmarks

Performance Changes

ModeBenchmarkBASEHEADEfficiency
⚡Memorymem server server-fn-churn (vue)4,147.3 KB270.5 KB×15
⚡Memorymem server error-paths unmatched (vue)2,142.1 KB477.8 KB×4.5
⚡Memorymem server peak-large-page (react)1,737.5 KB951.6 KB+82.59%
⚡Memorymem server error-paths redirect (solid)388 KB283.2 KB+37%
⚡Memorymem server error-paths redirect (vue)338.6 KB295.9 KB+14.42%
⚡Simulationssr server-fn multipart (solid)64.2 ms61.2 ms+4.94%
⚡Simulationssr server-fn raw-stream (solid)113.2 ms108.3 ms+4.5%
⚡Memorymem server error-paths not-found (react)277.7 KB266.5 KB+4.2%
⚡Memorymem client navigation-churn (vue)1.3 MB1.2 MB+3.71%
👁Memorymem server error-paths not-found (solid)415.1 KB783.6 KB-47.03%
👁Memorymem server error-paths unmatched (react)317.5 KB481.9 KB-34.12%
👁Simulationssr dehydrate rich types (vue)135.2 ms139.4 ms-3.05%
👁Simulationssr request loop (solid)156.5 ms163.9 ms-4.48%
👁Simulationssr server-fn during document ssr (react)62.9 ms66.9 ms-6.06%
👁Memorymem client unique-location-churn (solid)341.2 KB471.5 KB-27.63%

Tip

Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.

Comparing codex/direct-intersection-observer-disabled (7d62f08) with main (697ebb6)

Open in CodSpeed

@Sheraff
Sheraff marked this pull request as ready for review August 6, 2026 07:01
coderabbitai[bot]
coderabbitaiBot reviewed Aug 6, 2026
View reviewed changes

@coderabbitaicoderabbitaiBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.changeset/quiet-doors-double.md:
- Line 7: Update the changeset description to document the released observer API
change: in the React, Solid, and Vue observer helpers, the disabled state is now
separate from the IntersectionObserverInit options. Replace the current
link-component cleanup wording with this API-focused description.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 1c6df6b3-c8b6-4b8d-bd2a-ea26814414cd

📥 Commits

Reviewing files that changed from the base of the PR and between a71c605 and 7d62f08.

📒 Files selected for processing (1)
  • .changeset/quiet-doors-double.md

Comment thread.changeset/quiet-doors-double.md
'@tanstack/vue-router': patch
---

clean intersection observer options in link component

@coderabbitaicoderabbitaiBotAug 6, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win

Describe the released observer API change.

The current text only mentions link-component cleanup. State that disabled state is now separate from IntersectionObserverInit options in the React, Solid, and Vue observer helpers.

Proposed wording
-clean intersection observer options in link component+Separate disabled state from intersection observer options in React, Solid, and Vue router helpers.
📝 Committable suggestion

‼️IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
clean intersection observer options in link component
Separate disabled state from intersection observer options in React, Solid, and Vue router helpers.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @.changeset/quiet-doors-double.md at line 7, Update the changeset description
to document the released observer API change: in the React, Solid, and Vue
observer helpers, the disabled state is now separate from the
IntersectionObserverInit options. Replace the current link-component cleanup
wording with this API-focused description.

@Sheraff
Sheraff merged commit 86bf510 into mainAug 6, 2026
28 of 29 checks passed
@Sheraff
Sheraff deleted the codex/direct-intersection-observer-disabled branch August 6, 2026 11:38
@github-actionsgithub-actionsBot mentioned this pull request Aug 6, 2026
Merged
@coderabbitaicoderabbitaiBot mentioned this pull request Aug 11, 2026
Merged
@brenelzbrenelz mentioned this pull request Aug 13, 2026
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitaicoderabbitai[bot]coderabbitai[bot] left review comments

Assignees

No one assigned

Labels

package: react-routerpackage: solid-routerpackage: vue-router

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Sheraff
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Pass intersection observer disabled state directly - #7971
Merged
Sheraff merged 4 commits into
mainfrom 
codex/direct-intersection-observer-disabled
Aug 6, 2026
Merged
Pass intersection observer disabled state directly#7971
Sheraff merged 4 commits into
mainfrom 
codex/direct-intersection-observer-disabled
Conversation
@Sheraff
@SheraffSheraff
commented
Aug 5, 2026•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Collaborator
Summary
  • pass the disabled boolean directly to the React and Solid intersection-observer helpers
  • pass Vue's reactive disabled getter directly, preserving watchEffect tracking
  • cover disabled viewport links and reactive observer teardown in Vue
Bundle-size impact
Prior isolated prototype measurements from the same main base (6aefb33925):
ScenarioRawGzipBrotli
react-router.minimal-32 B-10 B-3 B
solid-router.minimal-23 B-4 B-65 B
The final Vue hunk, measured against an otherwise identical worktree:
ScenarioRawGzipBrotli
vue-router.minimal-68 B-25 B+62 B
Gzip is the benchmark's primary metric.
Validation
  • React link tests: 131 passed
  • Solid unit tests: 838 client tests passed (1 skipped), 3 server tests passed
  • Vue link tests: 131 passed
  • React, Solid, and Vue type tests passed
  • React, Solid, and Vue builds passed
  • React, Solid, and Vue ESLint targets passed with existing warnings only
Summary by CodeRabbit
  • Bug Fixes
    • Improved viewport-based link preloading behavior across React, Solid, and Vue.
    • Links now correctly skip observation when disabled or when viewport preloading is unavailable.
    • Preloading observation now responds correctly when link conditions change.
    • Updated behavior is consistent across supported framework integrations.
  • Tests
    • Added coverage confirming disabled links are not observed and that observation starts or stops as conditions change.
@coderabbitai
coderabbitaiBot
commented
Aug 5, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Review Change Stack
📝 Walkthrough
Walkthrough
The change separates disabled state from IntersectionObserverInit options in React, Solid, and Vue utilities. Link integrations use the new signatures. Vue tests cover disabled links and reactive observer lifecycle behavior.
Changes
Intersection observer API update
Layer / File(s)Summary
Update observer utility signatures
packages/react-router/src/utils.ts, packages/solid-router/src/utils.ts, packages/vue-router/src/utils.ts, .changeset/quiet-doors-double.md		The utilities accept observer options separately from disabled state. The observer checks, examples, and documentation use the new parameters. A patch changeset covers the three router packages.
Update link observer calls
packages/react-router/src/link.tsx, packages/solid-router/src/link.tsx, packages/vue-router/src/link.tsx		Links pass boolean or callback disabled conditions directly to useIntersectionObserver.
Validate Vue observer behavior
packages/vue-router/tests/link.test.tsx		Tests verify that disabled viewport links are not observed and that observer creation and disconnection react to a disabled getter.
Estimated code review effort: 3 (Moderate) | ~20 minutes
🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 warning)
Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 66.67% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly and concisely describes the main change: passing the intersection observer disabled state directly.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  •  Create PR with unit tests
  •  Commit unit tests in branch codex/direct-intersection-observer-disabled
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands.
@nx-cloud
nx-cloudBot
commented
Aug 5, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
View your CI Pipeline Execution ↗ for commit 7d62f08
CommandStatusDurationResult
nx affected --targets=test:eslint,test:unit,tes...✅ Succeeded2m 38sView ↗
☁️ Nx Cloud last updated this comment at 2026-08-06 11:10:43 UTC
@github-actions
github-actionsBot
commented
Aug 5, 2026

Copy link


Copy Markdown

Contributor
🚀 Changeset Version Preview
5 package(s) bumped directly, 18 bumped as dependents.
🟩 Patch bumps
PackageVersionReason
@tanstack/react-router1.170.20 → 1.170.21Changeset
@tanstack/router-core1.171.17 → 1.171.18Changeset
@tanstack/solid-router1.170.20 → 1.170.21Changeset
@tanstack/start-server-core1.169.20 → 1.169.21Changeset
@tanstack/vue-router1.170.19 → 1.170.20Changeset
@tanstack/react-start1.168.37 → 1.168.38Dependent
@tanstack/react-start-client1.168.18 → 1.168.19Dependent
@tanstack/react-start-rsc0.1.36 → 0.1.37Dependent
@tanstack/react-start-server1.167.25 → 1.167.26Dependent
@tanstack/router-cli1.167.23 → 1.167.24Dependent
@tanstack/router-generator1.167.23 → 1.167.24Dependent
@tanstack/router-plugin1.168.25 → 1.168.26Dependent
@tanstack/router-vite-plugin1.167.25 → 1.167.26Dependent
@tanstack/solid-start1.168.36 → 1.168.37Dependent
@tanstack/solid-start-client1.168.18 → 1.168.19Dependent
@tanstack/solid-start-server1.167.25 → 1.167.26Dependent
@tanstack/start-client-core1.170.16 → 1.170.17Dependent
@tanstack/start-plugin-core1.171.28 → 1.171.29Dependent
@tanstack/start-static-server-functions1.167.21 → 1.167.22Dependent
@tanstack/start-storage-context1.167.19 → 1.167.20Dependent
@tanstack/vue-start1.168.35 → 1.168.36Dependent
@tanstack/vue-start-client1.167.21 → 1.167.22Dependent
@tanstack/vue-start-server1.167.25 → 1.167.26Dependent
@github-actions
github-actionsBot
commented
Aug 5, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Bundle Size Benchmarks
  • Commit: 5d9d59b8b9d5
  • Measured at: 2026-08-06T10:52:17.935Z
  • Baseline source: history:697ebb6ddbd4
  • Dashboard: bundle-size history
The following scenarios have bundle-size changes compared with the baseline:
ScenarioCurrent (gzip)Delta vs baselineInitial gzipRawBrotliTrend
react-router.minimal87.10 KiB-8 B (-0.01%)86.97 KiB269.10 KiB75.87 KiB████▂▂▂▂▂▁▂▁
react-router.full90.89 KiB-4 B (-0.00%)90.75 KiB281.06 KiB79.10 KiB████▂▂▂▂▂▁▂▂
solid-router.minimal34.79 KiB-2 B (-0.01%)34.67 KiB99.95 KiB31.35 KiB████▂▂▂▂▂▁▁▁
solid-router.full39.90 KiB-3 B (-0.01%)39.77 KiB115.12 KiB35.92 KiB████▂▂▂▂▂▁▁▁
vue-router.minimal52.07 KiB-24 B (-0.04%)51.94 KiB143.05 KiB46.90 KiB████▂▂▂▂▂▁▁▁
vue-router.full58.03 KiB-21 B (-0.04%)57.90 KiB161.73 KiB52.05 KiB████▂▂▂▂▂▁▁▁
react-start.minimal100.59 KiB-5 B (-0.00%)100.46 KiB312.25 KiB87.36 KiB███████▁▁▁▁▁
react-start.deferred-hydration101.33 KiB-9 B (-0.01%)100.48 KiB313.63 KiB87.99 KiB███████▁▁▁▁▁
react-start.full103.91 KiB-8 B (-0.01%)103.78 KiB322.20 KiB90.18 KiB███████▁▁▁▁▁
react-start.rsbuild.minimal100.23 KiB-4 B (-0.00%)100.06 KiB316.74 KiB86.39 KiB▁▁▁▁▂▂▂█████
react-start.rsbuild.minimal-iife100.64 KiB-3 B (-0.00%)100.48 KiB317.67 KiB86.73 KiB▁▁▁▁▂▂▂█████
react-start.rsbuild.full103.56 KiB-5 B (-0.00%)103.39 KiB326.83 KiB89.12 KiB▁▁▁▁▃▃▃█████
solid-start.minimal48.18 KiB-1 B (-0.00%)48.05 KiB142.08 KiB42.78 KiB███████▁▁▁▁▁
solid-start.full53.42 KiB-10 B (-0.02%)53.29 KiB157.82 KiB47.41 KiB████▆▆▆▁▁▁▁▁
vue-start.minimal68.95 KiB-26 B (-0.04%)68.82 KiB195.05 KiB61.26 KiB████▆▆▆▁▁▁▁▁
vue-start.full72.91 KiB-22 B (-0.03%)72.78 KiB207.55 KiB64.71 KiB████▆▆▆▁▁▁▁▁
Current gzip tracks all emitted client JS chunks. Initial gzip tracks only the entry/import graph. Trend sparkline is historical current gzip ending with this PR measurement; lower is better.
@pkg-pr-new
pkg-pr-newBot
commented
Aug 5, 2026•

edited

Loading

Copy link


Copy Markdown

More templates
@tanstack/arktype-adapter
npm i https://pkg.pr.new/@tanstack/arktype-adapter@7971

@tanstack/eslint-plugin-router
npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@7971

@tanstack/eslint-plugin-start
npm i https://pkg.pr.new/@tanstack/eslint-plugin-start@7971

@tanstack/history
npm i https://pkg.pr.new/@tanstack/history@7971

@tanstack/nitro-v2-vite-plugin
npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@7971

@tanstack/react-router
npm i https://pkg.pr.new/@tanstack/react-router@7971

@tanstack/react-router-devtools
npm i https://pkg.pr.new/@tanstack/react-router-devtools@7971

@tanstack/react-router-ssr-query
npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@7971

@tanstack/react-start
npm i https://pkg.pr.new/@tanstack/react-start@7971

@tanstack/react-start-client
npm i https://pkg.pr.new/@tanstack/react-start-client@7971

@tanstack/react-start-rsc
npm i https://pkg.pr.new/@tanstack/react-start-rsc@7971

@tanstack/react-start-server
npm i https://pkg.pr.new/@tanstack/react-start-server@7971

@tanstack/router-cli
npm i https://pkg.pr.new/@tanstack/router-cli@7971

@tanstack/router-core
npm i https://pkg.pr.new/@tanstack/router-core@7971

@tanstack/router-devtools
npm i https://pkg.pr.new/@tanstack/router-devtools@7971

@tanstack/router-devtools-core
npm i https://pkg.pr.new/@tanstack/router-devtools-core@7971

@tanstack/router-generator
npm i https://pkg.pr.new/@tanstack/router-generator@7971

@tanstack/router-plugin
npm i https://pkg.pr.new/@tanstack/router-plugin@7971

@tanstack/router-ssr-query-core
npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@7971

@tanstack/router-utils
npm i https://pkg.pr.new/@tanstack/router-utils@7971

@tanstack/router-vite-plugin
npm i https://pkg.pr.new/@tanstack/router-vite-plugin@7971

@tanstack/solid-router
npm i https://pkg.pr.new/@tanstack/solid-router@7971

@tanstack/solid-router-devtools
npm i https://pkg.pr.new/@tanstack/solid-router-devtools@7971

@tanstack/solid-router-ssr-query
npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@7971

@tanstack/solid-start
npm i https://pkg.pr.new/@tanstack/solid-start@7971

@tanstack/solid-start-client
npm i https://pkg.pr.new/@tanstack/solid-start-client@7971

@tanstack/solid-start-server
npm i https://pkg.pr.new/@tanstack/solid-start-server@7971

@tanstack/start-client-core
npm i https://pkg.pr.new/@tanstack/start-client-core@7971

@tanstack/start-fn-stubs
npm i https://pkg.pr.new/@tanstack/start-fn-stubs@7971

@tanstack/start-plugin-core
npm i https://pkg.pr.new/@tanstack/start-plugin-core@7971

@tanstack/start-server-core
npm i https://pkg.pr.new/@tanstack/start-server-core@7971

@tanstack/start-static-server-functions
npm i https://pkg.pr.new/@tanstack/start-static-server-functions@7971

@tanstack/start-storage-context
npm i https://pkg.pr.new/@tanstack/start-storage-context@7971

@tanstack/valibot-adapter
npm i https://pkg.pr.new/@tanstack/valibot-adapter@7971

@tanstack/virtual-file-routes
npm i https://pkg.pr.new/@tanstack/virtual-file-routes@7971

@tanstack/vue-router
npm i https://pkg.pr.new/@tanstack/vue-router@7971

@tanstack/vue-router-devtools
npm i https://pkg.pr.new/@tanstack/vue-router-devtools@7971

@tanstack/vue-router-ssr-query
npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@7971

@tanstack/vue-start
npm i https://pkg.pr.new/@tanstack/vue-start@7971

@tanstack/vue-start-client
npm i https://pkg.pr.new/@tanstack/vue-start-client@7971

@tanstack/vue-start-server
npm i https://pkg.pr.new/@tanstack/vue-start-server@7971

@tanstack/zod-adapter
npm i https://pkg.pr.new/@tanstack/zod-adapter@7971

commit: 7d62f08
@codspeed-hq
codspeed-hqBot
commented
Aug 5, 2026•

edited

Loading

Copy link


Copy Markdown

Merging this PR will regress 0 benchmarks
⚠️Different runtime environments detected
Some benchmarks with significant performance changes were compared across different runtime environments,

which may affect the accuracy of the results.
Open the report in CodSpeed to investigate
⚡ 9 improved benchmarks
❌ 6 (👁 6) regressed benchmarks
✅ 165 untouched benchmarks
Performance Changes
ModeBenchmarkBASEHEADEfficiency
⚡Memorymem server server-fn-churn (vue)4,147.3 KB270.5 KB×15
⚡Memorymem server error-paths unmatched (vue)2,142.1 KB477.8 KB×4.5
⚡Memorymem server peak-large-page (react)1,737.5 KB951.6 KB+82.59%
⚡Memorymem server error-paths redirect (solid)388 KB283.2 KB+37%
⚡Memorymem server error-paths redirect (vue)338.6 KB295.9 KB+14.42%
⚡Simulationssr server-fn multipart (solid)64.2 ms61.2 ms+4.94%
⚡Simulationssr server-fn raw-stream (solid)113.2 ms108.3 ms+4.5%
⚡Memorymem server error-paths not-found (react)277.7 KB266.5 KB+4.2%
⚡Memorymem client navigation-churn (vue)1.3 MB1.2 MB+3.71%
👁Memorymem server error-paths not-found (solid)415.1 KB783.6 KB-47.03%
👁Memorymem server error-paths unmatched (react)317.5 KB481.9 KB-34.12%
👁Simulationssr dehydrate rich types (vue)135.2 ms139.4 ms-3.05%
👁Simulationssr request loop (solid)156.5 ms163.9 ms-4.48%
👁Simulationssr server-fn during document ssr (react)62.9 ms66.9 ms-6.06%
👁Memorymem client unique-location-churn (solid)341.2 KB471.5 KB-27.63%
Tip
Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.
Comparing codex/direct-intersection-observer-disabled (7d62f08) with main (697ebb6)
Open in CodSpeed
@Sheraff
Sheraff
marked this pull request as ready for review
August 6, 2026 07:01
coderabbitai[bot]
coderabbitaiBot
reviewed
Aug 6, 2026
View reviewed changes
@coderabbitaicoderabbitaiBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.changeset/quiet-doors-double.md:
- Line 7: Update the changeset description to document the released observer API
change: in the React, Solid, and Vue observer helpers, the disabled state is now
separate from the IntersectionObserverInit options. Replace the current
link-component cleanup wording with this API-focused description.

🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
  •  Push a commit to this branch (recommended)
  •  Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 1c6df6b3-c8b6-4b8d-bd2a-ea26814414cd
📥 Commits
Reviewing files that changed from the base of the PR and between a71c605 and 7d62f08.
📒 Files selected for processing (1)
  • .changeset/quiet-doors-double.md
Comment thread.changeset/quiet-doors-double.md
'@tanstack/vue-router': patch
---

clean intersection observer options in link component
@coderabbitaicoderabbitaiBotAug 6, 2026

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Describe the released observer API change.
The current text only mentions link-component cleanup. State that disabled state is now separate from IntersectionObserverInit options in the React, Solid, and Vue observer helpers.
Proposed wording
-clean intersection observer options in link component+Separate disabled state from intersection observer options in React, Solid, and Vue router helpers.
📝 Committable suggestion
‼️IMPORTANT

Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

clean intersection observer options in link component
Separate disabled state from intersection observer options in React, Solid, and Vue router helpers.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @.changeset/quiet-doors-double.md at line 7, Update the changeset description
to document the released observer API change: in the React, Solid, and Vue
observer helpers, the disabled state is now separate from the
IntersectionObserverInit options. Replace the current link-component cleanup
wording with this API-focused description.

@Sheraff
Sheraff
merged commit 86bf510
into
mainAug 6, 2026

28 of 29 checks passed

@Sheraff
Sheraff
deleted the

codex/direct-intersection-observer-disabled

branch
August 6, 2026 11:38
@github-actionsgithub-actionsBot
mentioned this pull request
Aug 6, 2026
 Merged

@coderabbitaicoderabbitaiBot
mentioned this pull request
Aug 11, 2026
 Merged

@brenelzbrenelz
mentioned this pull request
Aug 13, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@coderabbitaicoderabbitai[bot]coderabbitai[bot] left review comments

Assignees


No one assigned


Labels

package: react-routerpackage: solid-routerpackage: vue-router

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@Sheraff

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Pass intersection observer disabled state directly - #7971
Merged
Sheraff merged 4 commits into
mainfrom 
codex/direct-intersection-observer-disabled
Aug 6, 2026
Merged
Pass intersection observer disabled state directly#7971
Sheraff merged 4 commits into
mainfrom 
codex/direct-intersection-observer-disabled
Conversation
@Sheraff
@SheraffSheraff
commented
Aug 5, 2026•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Collaborator
Summary
  • pass the disabled boolean directly to the React and Solid intersection-observer helpers
  • pass Vue's reactive disabled getter directly, preserving watchEffect tracking
  • cover disabled viewport links and reactive observer teardown in Vue
Bundle-size impact
Prior isolated prototype measurements from the same main base (6aefb33925):
ScenarioRawGzipBrotli
react-router.minimal-32 B-10 B-3 B
solid-router.minimal-23 B-4 B-65 B
The final Vue hunk, measured against an otherwise identical worktree:
ScenarioRawGzipBrotli
vue-router.minimal-68 B-25 B+62 B
Gzip is the benchmark's primary metric.
Validation
  • React link tests: 131 passed
  • Solid unit tests: 838 client tests passed (1 skipped), 3 server tests passed
  • Vue link tests: 131 passed
  • React, Solid, and Vue type tests passed
  • React, Solid, and Vue builds passed
  • React, Solid, and Vue ESLint targets passed with existing warnings only
Summary by CodeRabbit
  • Bug Fixes
    • Improved viewport-based link preloading behavior across React, Solid, and Vue.
    • Links now correctly skip observation when disabled or when viewport preloading is unavailable.
    • Preloading observation now responds correctly when link conditions change.
    • Updated behavior is consistent across supported framework integrations.
  • Tests
    • Added coverage confirming disabled links are not observed and that observation starts or stops as conditions change.
@coderabbitai
coderabbitaiBot
commented
Aug 5, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Review Change Stack
📝 Walkthrough
Walkthrough
The change separates disabled state from IntersectionObserverInit options in React, Solid, and Vue utilities. Link integrations use the new signatures. Vue tests cover disabled links and reactive observer lifecycle behavior.
Changes
Intersection observer API update
Layer / File(s)Summary
Update observer utility signatures
packages/react-router/src/utils.ts, packages/solid-router/src/utils.ts, packages/vue-router/src/utils.ts, .changeset/quiet-doors-double.md		The utilities accept observer options separately from disabled state. The observer checks, examples, and documentation use the new parameters. A patch changeset covers the three router packages.
Update link observer calls
packages/react-router/src/link.tsx, packages/solid-router/src/link.tsx, packages/vue-router/src/link.tsx		Links pass boolean or callback disabled conditions directly to useIntersectionObserver.
Validate Vue observer behavior
packages/vue-router/tests/link.test.tsx		Tests verify that disabled viewport links are not observed and that observer creation and disconnection react to a disabled getter.
Estimated code review effort: 3 (Moderate) | ~20 minutes
🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 warning)
Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 66.67% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly and concisely describes the main change: passing the intersection observer disabled state directly.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  •  Create PR with unit tests
  •  Commit unit tests in branch codex/direct-intersection-observer-disabled
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands.
@nx-cloud
nx-cloudBot
commented
Aug 5, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
View your CI Pipeline Execution ↗ for commit 7d62f08
CommandStatusDurationResult
nx affected --targets=test:eslint,test:unit,tes...✅ Succeeded2m 38sView ↗
☁️ Nx Cloud last updated this comment at 2026-08-06 11:10:43 UTC
@github-actions
github-actionsBot
commented
Aug 5, 2026

Copy link


Copy Markdown

Contributor
🚀 Changeset Version Preview
5 package(s) bumped directly, 18 bumped as dependents.
🟩 Patch bumps
PackageVersionReason
@tanstack/react-router1.170.20 → 1.170.21Changeset
@tanstack/router-core1.171.17 → 1.171.18Changeset
@tanstack/solid-router1.170.20 → 1.170.21Changeset
@tanstack/start-server-core1.169.20 → 1.169.21Changeset
@tanstack/vue-router1.170.19 → 1.170.20Changeset
@tanstack/react-start1.168.37 → 1.168.38Dependent
@tanstack/react-start-client1.168.18 → 1.168.19Dependent
@tanstack/react-start-rsc0.1.36 → 0.1.37Dependent
@tanstack/react-start-server1.167.25 → 1.167.26Dependent
@tanstack/router-cli1.167.23 → 1.167.24Dependent
@tanstack/router-generator1.167.23 → 1.167.24Dependent
@tanstack/router-plugin1.168.25 → 1.168.26Dependent
@tanstack/router-vite-plugin1.167.25 → 1.167.26Dependent
@tanstack/solid-start1.168.36 → 1.168.37Dependent
@tanstack/solid-start-client1.168.18 → 1.168.19Dependent
@tanstack/solid-start-server1.167.25 → 1.167.26Dependent
@tanstack/start-client-core1.170.16 → 1.170.17Dependent
@tanstack/start-plugin-core1.171.28 → 1.171.29Dependent
@tanstack/start-static-server-functions1.167.21 → 1.167.22Dependent
@tanstack/start-storage-context1.167.19 → 1.167.20Dependent
@tanstack/vue-start1.168.35 → 1.168.36Dependent
@tanstack/vue-start-client1.167.21 → 1.167.22Dependent
@tanstack/vue-start-server1.167.25 → 1.167.26Dependent
@github-actions
github-actionsBot
commented
Aug 5, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Bundle Size Benchmarks
  • Commit: 5d9d59b8b9d5
  • Measured at: 2026-08-06T10:52:17.935Z
  • Baseline source: history:697ebb6ddbd4
  • Dashboard: bundle-size history
The following scenarios have bundle-size changes compared with the baseline:
ScenarioCurrent (gzip)Delta vs baselineInitial gzipRawBrotliTrend
react-router.minimal87.10 KiB-8 B (-0.01%)86.97 KiB269.10 KiB75.87 KiB████▂▂▂▂▂▁▂▁
react-router.full90.89 KiB-4 B (-0.00%)90.75 KiB281.06 KiB79.10 KiB████▂▂▂▂▂▁▂▂
solid-router.minimal34.79 KiB-2 B (-0.01%)34.67 KiB99.95 KiB31.35 KiB████▂▂▂▂▂▁▁▁
solid-router.full39.90 KiB-3 B (-0.01%)39.77 KiB115.12 KiB35.92 KiB████▂▂▂▂▂▁▁▁
vue-router.minimal52.07 KiB-24 B (-0.04%)51.94 KiB143.05 KiB46.90 KiB████▂▂▂▂▂▁▁▁
vue-router.full58.03 KiB-21 B (-0.04%)57.90 KiB161.73 KiB52.05 KiB████▂▂▂▂▂▁▁▁
react-start.minimal100.59 KiB-5 B (-0.00%)100.46 KiB312.25 KiB87.36 KiB███████▁▁▁▁▁
react-start.deferred-hydration101.33 KiB-9 B (-0.01%)100.48 KiB313.63 KiB87.99 KiB███████▁▁▁▁▁
react-start.full103.91 KiB-8 B (-0.01%)103.78 KiB322.20 KiB90.18 KiB███████▁▁▁▁▁
react-start.rsbuild.minimal100.23 KiB-4 B (-0.00%)100.06 KiB316.74 KiB86.39 KiB▁▁▁▁▂▂▂█████
react-start.rsbuild.minimal-iife100.64 KiB-3 B (-0.00%)100.48 KiB317.67 KiB86.73 KiB▁▁▁▁▂▂▂█████
react-start.rsbuild.full103.56 KiB-5 B (-0.00%)103.39 KiB326.83 KiB89.12 KiB▁▁▁▁▃▃▃█████
solid-start.minimal48.18 KiB-1 B (-0.00%)48.05 KiB142.08 KiB42.78 KiB███████▁▁▁▁▁
solid-start.full53.42 KiB-10 B (-0.02%)53.29 KiB157.82 KiB47.41 KiB████▆▆▆▁▁▁▁▁
vue-start.minimal68.95 KiB-26 B (-0.04%)68.82 KiB195.05 KiB61.26 KiB████▆▆▆▁▁▁▁▁
vue-start.full72.91 KiB-22 B (-0.03%)72.78 KiB207.55 KiB64.71 KiB████▆▆▆▁▁▁▁▁
Current gzip tracks all emitted client JS chunks. Initial gzip tracks only the entry/import graph. Trend sparkline is historical current gzip ending with this PR measurement; lower is better.
@pkg-pr-new
pkg-pr-newBot
commented
Aug 5, 2026•

edited

Loading

Copy link


Copy Markdown

More templates
@tanstack/arktype-adapter
npm i https://pkg.pr.new/@tanstack/arktype-adapter@7971

@tanstack/eslint-plugin-router
npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@7971

@tanstack/eslint-plugin-start
npm i https://pkg.pr.new/@tanstack/eslint-plugin-start@7971

@tanstack/history
npm i https://pkg.pr.new/@tanstack/history@7971

@tanstack/nitro-v2-vite-plugin
npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@7971

@tanstack/react-router
npm i https://pkg.pr.new/@tanstack/react-router@7971

@tanstack/react-router-devtools
npm i https://pkg.pr.new/@tanstack/react-router-devtools@7971

@tanstack/react-router-ssr-query
npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@7971

@tanstack/react-start
npm i https://pkg.pr.new/@tanstack/react-start@7971

@tanstack/react-start-client
npm i https://pkg.pr.new/@tanstack/react-start-client@7971

@tanstack/react-start-rsc
npm i https://pkg.pr.new/@tanstack/react-start-rsc@7971

@tanstack/react-start-server
npm i https://pkg.pr.new/@tanstack/react-start-server@7971

@tanstack/router-cli
npm i https://pkg.pr.new/@tanstack/router-cli@7971

@tanstack/router-core
npm i https://pkg.pr.new/@tanstack/router-core@7971

@tanstack/router-devtools
npm i https://pkg.pr.new/@tanstack/router-devtools@7971

@tanstack/router-devtools-core
npm i https://pkg.pr.new/@tanstack/router-devtools-core@7971

@tanstack/router-generator
npm i https://pkg.pr.new/@tanstack/router-generator@7971

@tanstack/router-plugin
npm i https://pkg.pr.new/@tanstack/router-plugin@7971

@tanstack/router-ssr-query-core
npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@7971

@tanstack/router-utils
npm i https://pkg.pr.new/@tanstack/router-utils@7971

@tanstack/router-vite-plugin
npm i https://pkg.pr.new/@tanstack/router-vite-plugin@7971

@tanstack/solid-router
npm i https://pkg.pr.new/@tanstack/solid-router@7971

@tanstack/solid-router-devtools
npm i https://pkg.pr.new/@tanstack/solid-router-devtools@7971

@tanstack/solid-router-ssr-query
npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@7971

@tanstack/solid-start
npm i https://pkg.pr.new/@tanstack/solid-start@7971

@tanstack/solid-start-client
npm i https://pkg.pr.new/@tanstack/solid-start-client@7971

@tanstack/solid-start-server
npm i https://pkg.pr.new/@tanstack/solid-start-server@7971

@tanstack/start-client-core
npm i https://pkg.pr.new/@tanstack/start-client-core@7971

@tanstack/start-fn-stubs
npm i https://pkg.pr.new/@tanstack/start-fn-stubs@7971

@tanstack/start-plugin-core
npm i https://pkg.pr.new/@tanstack/start-plugin-core@7971

@tanstack/start-server-core
npm i https://pkg.pr.new/@tanstack/start-server-core@7971

@tanstack/start-static-server-functions
npm i https://pkg.pr.new/@tanstack/start-static-server-functions@7971

@tanstack/start-storage-context
npm i https://pkg.pr.new/@tanstack/start-storage-context@7971

@tanstack/valibot-adapter
npm i https://pkg.pr.new/@tanstack/valibot-adapter@7971

@tanstack/virtual-file-routes
npm i https://pkg.pr.new/@tanstack/virtual-file-routes@7971

@tanstack/vue-router
npm i https://pkg.pr.new/@tanstack/vue-router@7971

@tanstack/vue-router-devtools
npm i https://pkg.pr.new/@tanstack/vue-router-devtools@7971

@tanstack/vue-router-ssr-query
npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@7971

@tanstack/vue-start
npm i https://pkg.pr.new/@tanstack/vue-start@7971

@tanstack/vue-start-client
npm i https://pkg.pr.new/@tanstack/vue-start-client@7971

@tanstack/vue-start-server
npm i https://pkg.pr.new/@tanstack/vue-start-server@7971

@tanstack/zod-adapter
npm i https://pkg.pr.new/@tanstack/zod-adapter@7971

commit: 7d62f08
@codspeed-hq
codspeed-hqBot
commented
Aug 5, 2026•

edited

Loading

Copy link


Copy Markdown

Merging this PR will regress 0 benchmarks
⚠️Different runtime environments detected
Some benchmarks with significant performance changes were compared across different runtime environments,

which may affect the accuracy of the results.
Open the report in CodSpeed to investigate
⚡ 9 improved benchmarks
❌ 6 (👁 6) regressed benchmarks
✅ 165 untouched benchmarks
Performance Changes
ModeBenchmarkBASEHEADEfficiency
⚡Memorymem server server-fn-churn (vue)4,147.3 KB270.5 KB×15
⚡Memorymem server error-paths unmatched (vue)2,142.1 KB477.8 KB×4.5
⚡Memorymem server peak-large-page (react)1,737.5 KB951.6 KB+82.59%
⚡Memorymem server error-paths redirect (solid)388 KB283.2 KB+37%
⚡Memorymem server error-paths redirect (vue)338.6 KB295.9 KB+14.42%
⚡Simulationssr server-fn multipart (solid)64.2 ms61.2 ms+4.94%
⚡Simulationssr server-fn raw-stream (solid)113.2 ms108.3 ms+4.5%
⚡Memorymem server error-paths not-found (react)277.7 KB266.5 KB+4.2%
⚡Memorymem client navigation-churn (vue)1.3 MB1.2 MB+3.71%
👁Memorymem server error-paths not-found (solid)415.1 KB783.6 KB-47.03%
👁Memorymem server error-paths unmatched (react)317.5 KB481.9 KB-34.12%
👁Simulationssr dehydrate rich types (vue)135.2 ms139.4 ms-3.05%
👁Simulationssr request loop (solid)156.5 ms163.9 ms-4.48%
👁Simulationssr server-fn during document ssr (react)62.9 ms66.9 ms-6.06%
👁Memorymem client unique-location-churn (solid)341.2 KB471.5 KB-27.63%
Tip
Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.
Comparing codex/direct-intersection-observer-disabled (7d62f08) with main (697ebb6)
Open in CodSpeed
@Sheraff
Sheraff
marked this pull request as ready for review
August 6, 2026 07:01
coderabbitai[bot]
coderabbitaiBot
reviewed
Aug 6, 2026
View reviewed changes
@coderabbitaicoderabbitaiBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.changeset/quiet-doors-double.md:
- Line 7: Update the changeset description to document the released observer API
change: in the React, Solid, and Vue observer helpers, the disabled state is now
separate from the IntersectionObserverInit options. Replace the current
link-component cleanup wording with this API-focused description.

🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
  •  Push a commit to this branch (recommended)
  •  Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 1c6df6b3-c8b6-4b8d-bd2a-ea26814414cd
📥 Commits
Reviewing files that changed from the base of the PR and between a71c605 and 7d62f08.
📒 Files selected for processing (1)
  • .changeset/quiet-doors-double.md
Comment thread.changeset/quiet-doors-double.md
'@tanstack/vue-router': patch
---

clean intersection observer options in link component
@coderabbitaicoderabbitaiBotAug 6, 2026

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Describe the released observer API change.
The current text only mentions link-component cleanup. State that disabled state is now separate from IntersectionObserverInit options in the React, Solid, and Vue observer helpers.
Proposed wording
-clean intersection observer options in link component+Separate disabled state from intersection observer options in React, Solid, and Vue router helpers.
📝 Committable suggestion
‼️IMPORTANT

Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

clean intersection observer options in link component
Separate disabled state from intersection observer options in React, Solid, and Vue router helpers.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @.changeset/quiet-doors-double.md at line 7, Update the changeset description
to document the released observer API change: in the React, Solid, and Vue
observer helpers, the disabled state is now separate from the
IntersectionObserverInit options. Replace the current link-component cleanup
wording with this API-focused description.

@Sheraff
Sheraff
merged commit 86bf510
into
mainAug 6, 2026

28 of 29 checks passed

@Sheraff
Sheraff
deleted the

codex/direct-intersection-observer-disabled

branch
August 6, 2026 11:38
@github-actionsgithub-actionsBot
mentioned this pull request
Aug 6, 2026
 Merged

@coderabbitaicoderabbitaiBot
mentioned this pull request
Aug 11, 2026
 Merged

@brenelzbrenelz
mentioned this pull request
Aug 13, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@coderabbitaicoderabbitai[bot]coderabbitai[bot] left review comments

Assignees


No one assigned


Labels

package: react-routerpackage: solid-routerpackage: vue-router

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@Sheraff

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Pass intersection observer disabled state directly - #7971
Merged
Sheraff merged 4 commits into
mainfrom 
codex/direct-intersection-observer-disabled
Aug 6, 2026
Merged
Pass intersection observer disabled state directly#7971
Sheraff merged 4 commits into
mainfrom 
codex/direct-intersection-observer-disabled
Conversation
@Sheraff
@SheraffSheraff
commented
Aug 5, 2026•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Collaborator
Summary
  • pass the disabled boolean directly to the React and Solid intersection-observer helpers
  • pass Vue's reactive disabled getter directly, preserving watchEffect tracking
  • cover disabled viewport links and reactive observer teardown in Vue
Bundle-size impact
Prior isolated prototype measurements from the same main base (6aefb33925):
ScenarioRawGzipBrotli
react-router.minimal-32 B-10 B-3 B
solid-router.minimal-23 B-4 B-65 B
The final Vue hunk, measured against an otherwise identical worktree:
ScenarioRawGzipBrotli
vue-router.minimal-68 B-25 B+62 B
Gzip is the benchmark's primary metric.
Validation
  • React link tests: 131 passed
  • Solid unit tests: 838 client tests passed (1 skipped), 3 server tests passed
  • Vue link tests: 131 passed
  • React, Solid, and Vue type tests passed
  • React, Solid, and Vue builds passed
  • React, Solid, and Vue ESLint targets passed with existing warnings only
Summary by CodeRabbit
  • Bug Fixes
    • Improved viewport-based link preloading behavior across React, Solid, and Vue.
    • Links now correctly skip observation when disabled or when viewport preloading is unavailable.
    • Preloading observation now responds correctly when link conditions change.
    • Updated behavior is consistent across supported framework integrations.
  • Tests
    • Added coverage confirming disabled links are not observed and that observation starts or stops as conditions change.
@coderabbitai
coderabbitaiBot
commented
Aug 5, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Review Change Stack
📝 Walkthrough
Walkthrough
The change separates disabled state from IntersectionObserverInit options in React, Solid, and Vue utilities. Link integrations use the new signatures. Vue tests cover disabled links and reactive observer lifecycle behavior.
Changes
Intersection observer API update
Layer / File(s)Summary
Update observer utility signatures
packages/react-router/src/utils.ts, packages/solid-router/src/utils.ts, packages/vue-router/src/utils.ts, .changeset/quiet-doors-double.md		The utilities accept observer options separately from disabled state. The observer checks, examples, and documentation use the new parameters. A patch changeset covers the three router packages.
Update link observer calls
packages/react-router/src/link.tsx, packages/solid-router/src/link.tsx, packages/vue-router/src/link.tsx		Links pass boolean or callback disabled conditions directly to useIntersectionObserver.
Validate Vue observer behavior
packages/vue-router/tests/link.test.tsx		Tests verify that disabled viewport links are not observed and that observer creation and disconnection react to a disabled getter.
Estimated code review effort: 3 (Moderate) | ~20 minutes
🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 warning)
Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 66.67% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly and concisely describes the main change: passing the intersection observer disabled state directly.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  •  Create PR with unit tests
  •  Commit unit tests in branch codex/direct-intersection-observer-disabled
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands.
@nx-cloud
nx-cloudBot
commented
Aug 5, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
View your CI Pipeline Execution ↗ for commit 7d62f08
CommandStatusDurationResult
nx affected --targets=test:eslint,test:unit,tes...✅ Succeeded2m 38sView ↗
☁️ Nx Cloud last updated this comment at 2026-08-06 11:10:43 UTC
@github-actions
github-actionsBot
commented
Aug 5, 2026

Copy link


Copy Markdown

Contributor
🚀 Changeset Version Preview
5 package(s) bumped directly, 18 bumped as dependents.
🟩 Patch bumps
PackageVersionReason
@tanstack/react-router1.170.20 → 1.170.21Changeset
@tanstack/router-core1.171.17 → 1.171.18Changeset
@tanstack/solid-router1.170.20 → 1.170.21Changeset
@tanstack/start-server-core1.169.20 → 1.169.21Changeset
@tanstack/vue-router1.170.19 → 1.170.20Changeset
@tanstack/react-start1.168.37 → 1.168.38Dependent
@tanstack/react-start-client1.168.18 → 1.168.19Dependent
@tanstack/react-start-rsc0.1.36 → 0.1.37Dependent
@tanstack/react-start-server1.167.25 → 1.167.26Dependent
@tanstack/router-cli1.167.23 → 1.167.24Dependent
@tanstack/router-generator1.167.23 → 1.167.24Dependent
@tanstack/router-plugin1.168.25 → 1.168.26Dependent
@tanstack/router-vite-plugin1.167.25 → 1.167.26Dependent
@tanstack/solid-start1.168.36 → 1.168.37Dependent
@tanstack/solid-start-client1.168.18 → 1.168.19Dependent
@tanstack/solid-start-server1.167.25 → 1.167.26Dependent
@tanstack/start-client-core1.170.16 → 1.170.17Dependent
@tanstack/start-plugin-core1.171.28 → 1.171.29Dependent
@tanstack/start-static-server-functions1.167.21 → 1.167.22Dependent
@tanstack/start-storage-context1.167.19 → 1.167.20Dependent
@tanstack/vue-start1.168.35 → 1.168.36Dependent
@tanstack/vue-start-client1.167.21 → 1.167.22Dependent
@tanstack/vue-start-server1.167.25 → 1.167.26Dependent
@github-actions
github-actionsBot
commented
Aug 5, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Bundle Size Benchmarks
  • Commit: 5d9d59b8b9d5
  • Measured at: 2026-08-06T10:52:17.935Z
  • Baseline source: history:697ebb6ddbd4
  • Dashboard: bundle-size history
The following scenarios have bundle-size changes compared with the baseline:
ScenarioCurrent (gzip)Delta vs baselineInitial gzipRawBrotliTrend
react-router.minimal87.10 KiB-8 B (-0.01%)86.97 KiB269.10 KiB75.87 KiB████▂▂▂▂▂▁▂▁
react-router.full90.89 KiB-4 B (-0.00%)90.75 KiB281.06 KiB79.10 KiB████▂▂▂▂▂▁▂▂
solid-router.minimal34.79 KiB-2 B (-0.01%)34.67 KiB99.95 KiB31.35 KiB████▂▂▂▂▂▁▁▁
solid-router.full39.90 KiB-3 B (-0.01%)39.77 KiB115.12 KiB35.92 KiB████▂▂▂▂▂▁▁▁
vue-router.minimal52.07 KiB-24 B (-0.04%)51.94 KiB143.05 KiB46.90 KiB████▂▂▂▂▂▁▁▁
vue-router.full58.03 KiB-21 B (-0.04%)57.90 KiB161.73 KiB52.05 KiB████▂▂▂▂▂▁▁▁
react-start.minimal100.59 KiB-5 B (-0.00%)100.46 KiB312.25 KiB87.36 KiB███████▁▁▁▁▁
react-start.deferred-hydration101.33 KiB-9 B (-0.01%)100.48 KiB313.63 KiB87.99 KiB███████▁▁▁▁▁
react-start.full103.91 KiB-8 B (-0.01%)103.78 KiB322.20 KiB90.18 KiB███████▁▁▁▁▁
react-start.rsbuild.minimal100.23 KiB-4 B (-0.00%)100.06 KiB316.74 KiB86.39 KiB▁▁▁▁▂▂▂█████
react-start.rsbuild.minimal-iife100.64 KiB-3 B (-0.00%)100.48 KiB317.67 KiB86.73 KiB▁▁▁▁▂▂▂█████
react-start.rsbuild.full103.56 KiB-5 B (-0.00%)103.39 KiB326.83 KiB89.12 KiB▁▁▁▁▃▃▃█████
solid-start.minimal48.18 KiB-1 B (-0.00%)48.05 KiB142.08 KiB42.78 KiB███████▁▁▁▁▁
solid-start.full53.42 KiB-10 B (-0.02%)53.29 KiB157.82 KiB47.41 KiB████▆▆▆▁▁▁▁▁
vue-start.minimal68.95 KiB-26 B (-0.04%)68.82 KiB195.05 KiB61.26 KiB████▆▆▆▁▁▁▁▁
vue-start.full72.91 KiB-22 B (-0.03%)72.78 KiB207.55 KiB64.71 KiB████▆▆▆▁▁▁▁▁
Current gzip tracks all emitted client JS chunks. Initial gzip tracks only the entry/import graph. Trend sparkline is historical current gzip ending with this PR measurement; lower is better.
@pkg-pr-new
pkg-pr-newBot
commented
Aug 5, 2026•

edited

Loading

Copy link


Copy Markdown

More templates
@tanstack/arktype-adapter
npm i https://pkg.pr.new/@tanstack/arktype-adapter@7971

@tanstack/eslint-plugin-router
npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@7971

@tanstack/eslint-plugin-start
npm i https://pkg.pr.new/@tanstack/eslint-plugin-start@7971

@tanstack/history
npm i https://pkg.pr.new/@tanstack/history@7971

@tanstack/nitro-v2-vite-plugin
npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@7971

@tanstack/react-router
npm i https://pkg.pr.new/@tanstack/react-router@7971

@tanstack/react-router-devtools
npm i https://pkg.pr.new/@tanstack/react-router-devtools@7971

@tanstack/react-router-ssr-query
npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@7971

@tanstack/react-start
npm i https://pkg.pr.new/@tanstack/react-start@7971

@tanstack/react-start-client
npm i https://pkg.pr.new/@tanstack/react-start-client@7971

@tanstack/react-start-rsc
npm i https://pkg.pr.new/@tanstack/react-start-rsc@7971

@tanstack/react-start-server
npm i https://pkg.pr.new/@tanstack/react-start-server@7971

@tanstack/router-cli
npm i https://pkg.pr.new/@tanstack/router-cli@7971

@tanstack/router-core
npm i https://pkg.pr.new/@tanstack/router-core@7971

@tanstack/router-devtools
npm i https://pkg.pr.new/@tanstack/router-devtools@7971

@tanstack/router-devtools-core
npm i https://pkg.pr.new/@tanstack/router-devtools-core@7971

@tanstack/router-generator
npm i https://pkg.pr.new/@tanstack/router-generator@7971

@tanstack/router-plugin
npm i https://pkg.pr.new/@tanstack/router-plugin@7971

@tanstack/router-ssr-query-core
npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@7971

@tanstack/router-utils
npm i https://pkg.pr.new/@tanstack/router-utils@7971

@tanstack/router-vite-plugin
npm i https://pkg.pr.new/@tanstack/router-vite-plugin@7971

@tanstack/solid-router
npm i https://pkg.pr.new/@tanstack/solid-router@7971

@tanstack/solid-router-devtools
npm i https://pkg.pr.new/@tanstack/solid-router-devtools@7971

@tanstack/solid-router-ssr-query
npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@7971

@tanstack/solid-start
npm i https://pkg.pr.new/@tanstack/solid-start@7971

@tanstack/solid-start-client
npm i https://pkg.pr.new/@tanstack/solid-start-client@7971

@tanstack/solid-start-server
npm i https://pkg.pr.new/@tanstack/solid-start-server@7971

@tanstack/start-client-core
npm i https://pkg.pr.new/@tanstack/start-client-core@7971

@tanstack/start-fn-stubs
npm i https://pkg.pr.new/@tanstack/start-fn-stubs@7971

@tanstack/start-plugin-core
npm i https://pkg.pr.new/@tanstack/start-plugin-core@7971

@tanstack/start-server-core
npm i https://pkg.pr.new/@tanstack/start-server-core@7971

@tanstack/start-static-server-functions
npm i https://pkg.pr.new/@tanstack/start-static-server-functions@7971

@tanstack/start-storage-context
npm i https://pkg.pr.new/@tanstack/start-storage-context@7971

@tanstack/valibot-adapter
npm i https://pkg.pr.new/@tanstack/valibot-adapter@7971

@tanstack/virtual-file-routes
npm i https://pkg.pr.new/@tanstack/virtual-file-routes@7971

@tanstack/vue-router
npm i https://pkg.pr.new/@tanstack/vue-router@7971

@tanstack/vue-router-devtools
npm i https://pkg.pr.new/@tanstack/vue-router-devtools@7971

@tanstack/vue-router-ssr-query
npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@7971

@tanstack/vue-start
npm i https://pkg.pr.new/@tanstack/vue-start@7971

@tanstack/vue-start-client
npm i https://pkg.pr.new/@tanstack/vue-start-client@7971

@tanstack/vue-start-server
npm i https://pkg.pr.new/@tanstack/vue-start-server@7971

@tanstack/zod-adapter
npm i https://pkg.pr.new/@tanstack/zod-adapter@7971

commit: 7d62f08
@codspeed-hq
codspeed-hqBot
commented
Aug 5, 2026•

edited

Loading

Copy link


Copy Markdown

Merging this PR will regress 0 benchmarks
⚠️Different runtime environments detected
Some benchmarks with significant performance changes were compared across different runtime environments,

which may affect the accuracy of the results.
Open the report in CodSpeed to investigate
⚡ 9 improved benchmarks
❌ 6 (👁 6) regressed benchmarks
✅ 165 untouched benchmarks
Performance Changes
ModeBenchmarkBASEHEADEfficiency
⚡Memorymem server server-fn-churn (vue)4,147.3 KB270.5 KB×15
⚡Memorymem server error-paths unmatched (vue)2,142.1 KB477.8 KB×4.5
⚡Memorymem server peak-large-page (react)1,737.5 KB951.6 KB+82.59%
⚡Memorymem server error-paths redirect (solid)388 KB283.2 KB+37%
⚡Memorymem server error-paths redirect (vue)338.6 KB295.9 KB+14.42%
⚡Simulationssr server-fn multipart (solid)64.2 ms61.2 ms+4.94%
⚡Simulationssr server-fn raw-stream (solid)113.2 ms108.3 ms+4.5%
⚡Memorymem server error-paths not-found (react)277.7 KB266.5 KB+4.2%
⚡Memorymem client navigation-churn (vue)1.3 MB1.2 MB+3.71%
👁Memorymem server error-paths not-found (solid)415.1 KB783.6 KB-47.03%
👁Memorymem server error-paths unmatched (react)317.5 KB481.9 KB-34.12%
👁Simulationssr dehydrate rich types (vue)135.2 ms139.4 ms-3.05%
👁Simulationssr request loop (solid)156.5 ms163.9 ms-4.48%
👁Simulationssr server-fn during document ssr (react)62.9 ms66.9 ms-6.06%
👁Memorymem client unique-location-churn (solid)341.2 KB471.5 KB-27.63%
Tip
Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.
Comparing codex/direct-intersection-observer-disabled (7d62f08) with main (697ebb6)
Open in CodSpeed
@Sheraff
Sheraff
marked this pull request as ready for review
August 6, 2026 07:01
coderabbitai[bot]
coderabbitaiBot
reviewed
Aug 6, 2026
View reviewed changes
@coderabbitaicoderabbitaiBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.changeset/quiet-doors-double.md:
- Line 7: Update the changeset description to document the released observer API
change: in the React, Solid, and Vue observer helpers, the disabled state is now
separate from the IntersectionObserverInit options. Replace the current
link-component cleanup wording with this API-focused description.

🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
  •  Push a commit to this branch (recommended)
  •  Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 1c6df6b3-c8b6-4b8d-bd2a-ea26814414cd
📥 Commits
Reviewing files that changed from the base of the PR and between a71c605 and 7d62f08.
📒 Files selected for processing (1)
  • .changeset/quiet-doors-double.md
Comment thread.changeset/quiet-doors-double.md
'@tanstack/vue-router': patch
---

clean intersection observer options in link component
@coderabbitaicoderabbitaiBotAug 6, 2026

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Describe the released observer API change.
The current text only mentions link-component cleanup. State that disabled state is now separate from IntersectionObserverInit options in the React, Solid, and Vue observer helpers.
Proposed wording
-clean intersection observer options in link component+Separate disabled state from intersection observer options in React, Solid, and Vue router helpers.
📝 Committable suggestion
‼️IMPORTANT

Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

clean intersection observer options in link component
Separate disabled state from intersection observer options in React, Solid, and Vue router helpers.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @.changeset/quiet-doors-double.md at line 7, Update the changeset description
to document the released observer API change: in the React, Solid, and Vue
observer helpers, the disabled state is now separate from the
IntersectionObserverInit options. Replace the current link-component cleanup
wording with this API-focused description.

@Sheraff
Sheraff
merged commit 86bf510
into
mainAug 6, 2026

28 of 29 checks passed

@Sheraff
Sheraff
deleted the

codex/direct-intersection-observer-disabled

branch
August 6, 2026 11:38
@github-actionsgithub-actionsBot
mentioned this pull request
Aug 6, 2026
 Merged

@coderabbitaicoderabbitaiBot
mentioned this pull request
Aug 11, 2026
 Merged

@brenelzbrenelz
mentioned this pull request
Aug 13, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@coderabbitaicoderabbitai[bot]coderabbitai[bot] left review comments

Assignees


No one assigned


Labels

package: react-routerpackage: solid-routerpackage: vue-router

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@Sheraff

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Pass intersection observer disabled state directly - #7971
Merged
Sheraff merged 4 commits into
mainfrom 
codex/direct-intersection-observer-disabled
Aug 6, 2026
Merged
Pass intersection observer disabled state directly#7971
Sheraff merged 4 commits into
mainfrom 
codex/direct-intersection-observer-disabled
Conversation
@Sheraff
@SheraffSheraff
commented
Aug 5, 2026•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Collaborator
Summary
  • pass the disabled boolean directly to the React and Solid intersection-observer helpers
  • pass Vue's reactive disabled getter directly, preserving watchEffect tracking
  • cover disabled viewport links and reactive observer teardown in Vue
Bundle-size impact
Prior isolated prototype measurements from the same main base (6aefb33925):
ScenarioRawGzipBrotli
react-router.minimal-32 B-10 B-3 B
solid-router.minimal-23 B-4 B-65 B
The final Vue hunk, measured against an otherwise identical worktree:
ScenarioRawGzipBrotli
vue-router.minimal-68 B-25 B+62 B
Gzip is the benchmark's primary metric.
Validation
  • React link tests: 131 passed
  • Solid unit tests: 838 client tests passed (1 skipped), 3 server tests passed
  • Vue link tests: 131 passed
  • React, Solid, and Vue type tests passed
  • React, Solid, and Vue builds passed
  • React, Solid, and Vue ESLint targets passed with existing warnings only
Summary by CodeRabbit
  • Bug Fixes
    • Improved viewport-based link preloading behavior across React, Solid, and Vue.
    • Links now correctly skip observation when disabled or when viewport preloading is unavailable.
    • Preloading observation now responds correctly when link conditions change.
    • Updated behavior is consistent across supported framework integrations.
  • Tests
    • Added coverage confirming disabled links are not observed and that observation starts or stops as conditions change.
@coderabbitai
coderabbitaiBot
commented
Aug 5, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Review Change Stack
📝 Walkthrough
Walkthrough
The change separates disabled state from IntersectionObserverInit options in React, Solid, and Vue utilities. Link integrations use the new signatures. Vue tests cover disabled links and reactive observer lifecycle behavior.
Changes
Intersection observer API update
Layer / File(s)Summary
Update observer utility signatures
packages/react-router/src/utils.ts, packages/solid-router/src/utils.ts, packages/vue-router/src/utils.ts, .changeset/quiet-doors-double.md		The utilities accept observer options separately from disabled state. The observer checks, examples, and documentation use the new parameters. A patch changeset covers the three router packages.
Update link observer calls
packages/react-router/src/link.tsx, packages/solid-router/src/link.tsx, packages/vue-router/src/link.tsx		Links pass boolean or callback disabled conditions directly to useIntersectionObserver.
Validate Vue observer behavior
packages/vue-router/tests/link.test.tsx		Tests verify that disabled viewport links are not observed and that observer creation and disconnection react to a disabled getter.
Estimated code review effort: 3 (Moderate) | ~20 minutes
🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 warning)
Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 66.67% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly and concisely describes the main change: passing the intersection observer disabled state directly.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  •  Create PR with unit tests
  •  Commit unit tests in branch codex/direct-intersection-observer-disabled
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands.
@nx-cloud
nx-cloudBot
commented
Aug 5, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
View your CI Pipeline Execution ↗ for commit 7d62f08
CommandStatusDurationResult
nx affected --targets=test:eslint,test:unit,tes...✅ Succeeded2m 38sView ↗
☁️ Nx Cloud last updated this comment at 2026-08-06 11:10:43 UTC
@github-actions
github-actionsBot
commented
Aug 5, 2026

Copy link


Copy Markdown

Contributor
🚀 Changeset Version Preview
5 package(s) bumped directly, 18 bumped as dependents.
🟩 Patch bumps
PackageVersionReason
@tanstack/react-router1.170.20 → 1.170.21Changeset
@tanstack/router-core1.171.17 → 1.171.18Changeset
@tanstack/solid-router1.170.20 → 1.170.21Changeset
@tanstack/start-server-core1.169.20 → 1.169.21Changeset
@tanstack/vue-router1.170.19 → 1.170.20Changeset
@tanstack/react-start1.168.37 → 1.168.38Dependent
@tanstack/react-start-client1.168.18 → 1.168.19Dependent
@tanstack/react-start-rsc0.1.36 → 0.1.37Dependent
@tanstack/react-start-server1.167.25 → 1.167.26Dependent
@tanstack/router-cli1.167.23 → 1.167.24Dependent
@tanstack/router-generator1.167.23 → 1.167.24Dependent
@tanstack/router-plugin1.168.25 → 1.168.26Dependent
@tanstack/router-vite-plugin1.167.25 → 1.167.26Dependent
@tanstack/solid-start1.168.36 → 1.168.37Dependent
@tanstack/solid-start-client1.168.18 → 1.168.19Dependent
@tanstack/solid-start-server1.167.25 → 1.167.26Dependent
@tanstack/start-client-core1.170.16 → 1.170.17Dependent
@tanstack/start-plugin-core1.171.28 → 1.171.29Dependent
@tanstack/start-static-server-functions1.167.21 → 1.167.22Dependent
@tanstack/start-storage-context1.167.19 → 1.167.20Dependent
@tanstack/vue-start1.168.35 → 1.168.36Dependent
@tanstack/vue-start-client1.167.21 → 1.167.22Dependent
@tanstack/vue-start-server1.167.25 → 1.167.26Dependent
@github-actions
github-actionsBot
commented
Aug 5, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Bundle Size Benchmarks
  • Commit: 5d9d59b8b9d5
  • Measured at: 2026-08-06T10:52:17.935Z
  • Baseline source: history:697ebb6ddbd4
  • Dashboard: bundle-size history
The following scenarios have bundle-size changes compared with the baseline:
ScenarioCurrent (gzip)Delta vs baselineInitial gzipRawBrotliTrend
react-router.minimal87.10 KiB-8 B (-0.01%)86.97 KiB269.10 KiB75.87 KiB████▂▂▂▂▂▁▂▁
react-router.full90.89 KiB-4 B (-0.00%)90.75 KiB281.06 KiB79.10 KiB████▂▂▂▂▂▁▂▂
solid-router.minimal34.79 KiB-2 B (-0.01%)34.67 KiB99.95 KiB31.35 KiB████▂▂▂▂▂▁▁▁
solid-router.full39.90 KiB-3 B (-0.01%)39.77 KiB115.12 KiB35.92 KiB████▂▂▂▂▂▁▁▁
vue-router.minimal52.07 KiB-24 B (-0.04%)51.94 KiB143.05 KiB46.90 KiB████▂▂▂▂▂▁▁▁
vue-router.full58.03 KiB-21 B (-0.04%)57.90 KiB161.73 KiB52.05 KiB████▂▂▂▂▂▁▁▁
react-start.minimal100.59 KiB-5 B (-0.00%)100.46 KiB312.25 KiB87.36 KiB███████▁▁▁▁▁
react-start.deferred-hydration101.33 KiB-9 B (-0.01%)100.48 KiB313.63 KiB87.99 KiB███████▁▁▁▁▁
react-start.full103.91 KiB-8 B (-0.01%)103.78 KiB322.20 KiB90.18 KiB███████▁▁▁▁▁
react-start.rsbuild.minimal100.23 KiB-4 B (-0.00%)100.06 KiB316.74 KiB86.39 KiB▁▁▁▁▂▂▂█████
react-start.rsbuild.minimal-iife100.64 KiB-3 B (-0.00%)100.48 KiB317.67 KiB86.73 KiB▁▁▁▁▂▂▂█████
react-start.rsbuild.full103.56 KiB-5 B (-0.00%)103.39 KiB326.83 KiB89.12 KiB▁▁▁▁▃▃▃█████
solid-start.minimal48.18 KiB-1 B (-0.00%)48.05 KiB142.08 KiB42.78 KiB███████▁▁▁▁▁
solid-start.full53.42 KiB-10 B (-0.02%)53.29 KiB157.82 KiB47.41 KiB████▆▆▆▁▁▁▁▁
vue-start.minimal68.95 KiB-26 B (-0.04%)68.82 KiB195.05 KiB61.26 KiB████▆▆▆▁▁▁▁▁
vue-start.full72.91 KiB-22 B (-0.03%)72.78 KiB207.55 KiB64.71 KiB████▆▆▆▁▁▁▁▁
Current gzip tracks all emitted client JS chunks. Initial gzip tracks only the entry/import graph. Trend sparkline is historical current gzip ending with this PR measurement; lower is better.
@pkg-pr-new
pkg-pr-newBot
commented
Aug 5, 2026•

edited

Loading

Copy link


Copy Markdown

More templates
@tanstack/arktype-adapter
npm i https://pkg.pr.new/@tanstack/arktype-adapter@7971

@tanstack/eslint-plugin-router
npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@7971

@tanstack/eslint-plugin-start
npm i https://pkg.pr.new/@tanstack/eslint-plugin-start@7971

@tanstack/history
npm i https://pkg.pr.new/@tanstack/history@7971

@tanstack/nitro-v2-vite-plugin
npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@7971

@tanstack/react-router
npm i https://pkg.pr.new/@tanstack/react-router@7971

@tanstack/react-router-devtools
npm i https://pkg.pr.new/@tanstack/react-router-devtools@7971

@tanstack/react-router-ssr-query
npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@7971

@tanstack/react-start
npm i https://pkg.pr.new/@tanstack/react-start@7971

@tanstack/react-start-client
npm i https://pkg.pr.new/@tanstack/react-start-client@7971

@tanstack/react-start-rsc
npm i https://pkg.pr.new/@tanstack/react-start-rsc@7971

@tanstack/react-start-server
npm i https://pkg.pr.new/@tanstack/react-start-server@7971

@tanstack/router-cli
npm i https://pkg.pr.new/@tanstack/router-cli@7971

@tanstack/router-core
npm i https://pkg.pr.new/@tanstack/router-core@7971

@tanstack/router-devtools
npm i https://pkg.pr.new/@tanstack/router-devtools@7971

@tanstack/router-devtools-core
npm i https://pkg.pr.new/@tanstack/router-devtools-core@7971

@tanstack/router-generator
npm i https://pkg.pr.new/@tanstack/router-generator@7971

@tanstack/router-plugin
npm i https://pkg.pr.new/@tanstack/router-plugin@7971

@tanstack/router-ssr-query-core
npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@7971

@tanstack/router-utils
npm i https://pkg.pr.new/@tanstack/router-utils@7971

@tanstack/router-vite-plugin
npm i https://pkg.pr.new/@tanstack/router-vite-plugin@7971

@tanstack/solid-router
npm i https://pkg.pr.new/@tanstack/solid-router@7971

@tanstack/solid-router-devtools
npm i https://pkg.pr.new/@tanstack/solid-router-devtools@7971

@tanstack/solid-router-ssr-query
npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@7971

@tanstack/solid-start
npm i https://pkg.pr.new/@tanstack/solid-start@7971

@tanstack/solid-start-client
npm i https://pkg.pr.new/@tanstack/solid-start-client@7971

@tanstack/solid-start-server
npm i https://pkg.pr.new/@tanstack/solid-start-server@7971

@tanstack/start-client-core
npm i https://pkg.pr.new/@tanstack/start-client-core@7971

@tanstack/start-fn-stubs
npm i https://pkg.pr.new/@tanstack/start-fn-stubs@7971

@tanstack/start-plugin-core
npm i https://pkg.pr.new/@tanstack/start-plugin-core@7971

@tanstack/start-server-core
npm i https://pkg.pr.new/@tanstack/start-server-core@7971

@tanstack/start-static-server-functions
npm i https://pkg.pr.new/@tanstack/start-static-server-functions@7971

@tanstack/start-storage-context
npm i https://pkg.pr.new/@tanstack/start-storage-context@7971

@tanstack/valibot-adapter
npm i https://pkg.pr.new/@tanstack/valibot-adapter@7971

@tanstack/virtual-file-routes
npm i https://pkg.pr.new/@tanstack/virtual-file-routes@7971

@tanstack/vue-router
npm i https://pkg.pr.new/@tanstack/vue-router@7971

@tanstack/vue-router-devtools
npm i https://pkg.pr.new/@tanstack/vue-router-devtools@7971

@tanstack/vue-router-ssr-query
npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@7971

@tanstack/vue-start
npm i https://pkg.pr.new/@tanstack/vue-start@7971

@tanstack/vue-start-client
npm i https://pkg.pr.new/@tanstack/vue-start-client@7971

@tanstack/vue-start-server
npm i https://pkg.pr.new/@tanstack/vue-start-server@7971

@tanstack/zod-adapter
npm i https://pkg.pr.new/@tanstack/zod-adapter@7971

commit: 7d62f08
@codspeed-hq
codspeed-hqBot
commented
Aug 5, 2026•

edited

Loading

Copy link


Copy Markdown

Merging this PR will regress 0 benchmarks
⚠️Different runtime environments detected
Some benchmarks with significant performance changes were compared across different runtime environments,

which may affect the accuracy of the results.
Open the report in CodSpeed to investigate
⚡ 9 improved benchmarks
❌ 6 (👁 6) regressed benchmarks
✅ 165 untouched benchmarks
Performance Changes
ModeBenchmarkBASEHEADEfficiency
⚡Memorymem server server-fn-churn (vue)4,147.3 KB270.5 KB×15
⚡Memorymem server error-paths unmatched (vue)2,142.1 KB477.8 KB×4.5
⚡Memorymem server peak-large-page (react)1,737.5 KB951.6 KB+82.59%
⚡Memorymem server error-paths redirect (solid)388 KB283.2 KB+37%
⚡Memorymem server error-paths redirect (vue)338.6 KB295.9 KB+14.42%
⚡Simulationssr server-fn multipart (solid)64.2 ms61.2 ms+4.94%
⚡Simulationssr server-fn raw-stream (solid)113.2 ms108.3 ms+4.5%
⚡Memorymem server error-paths not-found (react)277.7 KB266.5 KB+4.2%
⚡Memorymem client navigation-churn (vue)1.3 MB1.2 MB+3.71%
👁Memorymem server error-paths not-found (solid)415.1 KB783.6 KB-47.03%
👁Memorymem server error-paths unmatched (react)317.5 KB481.9 KB-34.12%
👁Simulationssr dehydrate rich types (vue)135.2 ms139.4 ms-3.05%
👁Simulationssr request loop (solid)156.5 ms163.9 ms-4.48%
👁Simulationssr server-fn during document ssr (react)62.9 ms66.9 ms-6.06%
👁Memorymem client unique-location-churn (solid)341.2 KB471.5 KB-27.63%
Tip
Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.
Comparing codex/direct-intersection-observer-disabled (7d62f08) with main (697ebb6)
Open in CodSpeed
@Sheraff
Sheraff
marked this pull request as ready for review
August 6, 2026 07:01
coderabbitai[bot]
coderabbitaiBot
reviewed
Aug 6, 2026
View reviewed changes
@coderabbitaicoderabbitaiBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.changeset/quiet-doors-double.md:
- Line 7: Update the changeset description to document the released observer API
change: in the React, Solid, and Vue observer helpers, the disabled state is now
separate from the IntersectionObserverInit options. Replace the current
link-component cleanup wording with this API-focused description.

🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
  •  Push a commit to this branch (recommended)
  •  Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 1c6df6b3-c8b6-4b8d-bd2a-ea26814414cd
📥 Commits
Reviewing files that changed from the base of the PR and between a71c605 and 7d62f08.
📒 Files selected for processing (1)
  • .changeset/quiet-doors-double.md
Comment thread.changeset/quiet-doors-double.md
'@tanstack/vue-router': patch
---

clean intersection observer options in link component
@coderabbitaicoderabbitaiBotAug 6, 2026

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Describe the released observer API change.
The current text only mentions link-component cleanup. State that disabled state is now separate from IntersectionObserverInit options in the React, Solid, and Vue observer helpers.
Proposed wording
-clean intersection observer options in link component+Separate disabled state from intersection observer options in React, Solid, and Vue router helpers.
📝 Committable suggestion
‼️IMPORTANT

Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

clean intersection observer options in link component
Separate disabled state from intersection observer options in React, Solid, and Vue router helpers.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @.changeset/quiet-doors-double.md at line 7, Update the changeset description
to document the released observer API change: in the React, Solid, and Vue
observer helpers, the disabled state is now separate from the
IntersectionObserverInit options. Replace the current link-component cleanup
wording with this API-focused description.

@Sheraff
Sheraff
merged commit 86bf510
into
mainAug 6, 2026

28 of 29 checks passed

@Sheraff
Sheraff
deleted the

codex/direct-intersection-observer-disabled

branch
August 6, 2026 11:38
@github-actionsgithub-actionsBot
mentioned this pull request
Aug 6, 2026
 Merged

@coderabbitaicoderabbitaiBot
mentioned this pull request
Aug 11, 2026
 Merged

@brenelzbrenelz
mentioned this pull request
Aug 13, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@coderabbitaicoderabbitai[bot]coderabbitai[bot] left review comments

Assignees


No one assigned


Labels

package: react-routerpackage: solid-routerpackage: vue-router

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@Sheraff

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Pass intersection observer disabled state directly - #7971
Merged
Sheraff merged 4 commits into
mainfrom 
codex/direct-intersection-observer-disabled
Aug 6, 2026
Merged
Pass intersection observer disabled state directly#7971
Sheraff merged 4 commits into
mainfrom 
codex/direct-intersection-observer-disabled
Conversation
@Sheraff
@SheraffSheraff
commented
Aug 5, 2026•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Collaborator
Summary
  • pass the disabled boolean directly to the React and Solid intersection-observer helpers
  • pass Vue's reactive disabled getter directly, preserving watchEffect tracking
  • cover disabled viewport links and reactive observer teardown in Vue
Bundle-size impact
Prior isolated prototype measurements from the same main base (6aefb33925):
ScenarioRawGzipBrotli
react-router.minimal-32 B-10 B-3 B
solid-router.minimal-23 B-4 B-65 B
The final Vue hunk, measured against an otherwise identical worktree:
ScenarioRawGzipBrotli
vue-router.minimal-68 B-25 B+62 B
Gzip is the benchmark's primary metric.
Validation
  • React link tests: 131 passed
  • Solid unit tests: 838 client tests passed (1 skipped), 3 server tests passed
  • Vue link tests: 131 passed
  • React, Solid, and Vue type tests passed
  • React, Solid, and Vue builds passed
  • React, Solid, and Vue ESLint targets passed with existing warnings only
Summary by CodeRabbit
  • Bug Fixes
    • Improved viewport-based link preloading behavior across React, Solid, and Vue.
    • Links now correctly skip observation when disabled or when viewport preloading is unavailable.
    • Preloading observation now responds correctly when link conditions change.
    • Updated behavior is consistent across supported framework integrations.
  • Tests
    • Added coverage confirming disabled links are not observed and that observation starts or stops as conditions change.
@coderabbitai
coderabbitaiBot
commented
Aug 5, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Review Change Stack
📝 Walkthrough
Walkthrough
The change separates disabled state from IntersectionObserverInit options in React, Solid, and Vue utilities. Link integrations use the new signatures. Vue tests cover disabled links and reactive observer lifecycle behavior.
Changes
Intersection observer API update
Layer / File(s)Summary
Update observer utility signatures
packages/react-router/src/utils.ts, packages/solid-router/src/utils.ts, packages/vue-router/src/utils.ts, .changeset/quiet-doors-double.md		The utilities accept observer options separately from disabled state. The observer checks, examples, and documentation use the new parameters. A patch changeset covers the three router packages.
Update link observer calls
packages/react-router/src/link.tsx, packages/solid-router/src/link.tsx, packages/vue-router/src/link.tsx		Links pass boolean or callback disabled conditions directly to useIntersectionObserver.
Validate Vue observer behavior
packages/vue-router/tests/link.test.tsx		Tests verify that disabled viewport links are not observed and that observer creation and disconnection react to a disabled getter.
Estimated code review effort: 3 (Moderate) | ~20 minutes
🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 warning)
Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 66.67% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly and concisely describes the main change: passing the intersection observer disabled state directly.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  •  Create PR with unit tests
  •  Commit unit tests in branch codex/direct-intersection-observer-disabled
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands.
@nx-cloud
nx-cloudBot
commented
Aug 5, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
View your CI Pipeline Execution ↗ for commit 7d62f08
CommandStatusDurationResult
nx affected --targets=test:eslint,test:unit,tes...✅ Succeeded2m 38sView ↗
☁️ Nx Cloud last updated this comment at 2026-08-06 11:10:43 UTC
@github-actions
github-actionsBot
commented
Aug 5, 2026

Copy link


Copy Markdown

Contributor
🚀 Changeset Version Preview
5 package(s) bumped directly, 18 bumped as dependents.
🟩 Patch bumps
PackageVersionReason
@tanstack/react-router1.170.20 → 1.170.21Changeset
@tanstack/router-core1.171.17 → 1.171.18Changeset
@tanstack/solid-router1.170.20 → 1.170.21Changeset
@tanstack/start-server-core1.169.20 → 1.169.21Changeset
@tanstack/vue-router1.170.19 → 1.170.20Changeset
@tanstack/react-start1.168.37 → 1.168.38Dependent
@tanstack/react-start-client1.168.18 → 1.168.19Dependent
@tanstack/react-start-rsc0.1.36 → 0.1.37Dependent
@tanstack/react-start-server1.167.25 → 1.167.26Dependent
@tanstack/router-cli1.167.23 → 1.167.24Dependent
@tanstack/router-generator1.167.23 → 1.167.24Dependent
@tanstack/router-plugin1.168.25 → 1.168.26Dependent
@tanstack/router-vite-plugin1.167.25 → 1.167.26Dependent
@tanstack/solid-start1.168.36 → 1.168.37Dependent
@tanstack/solid-start-client1.168.18 → 1.168.19Dependent
@tanstack/solid-start-server1.167.25 → 1.167.26Dependent
@tanstack/start-client-core1.170.16 → 1.170.17Dependent
@tanstack/start-plugin-core1.171.28 → 1.171.29Dependent
@tanstack/start-static-server-functions1.167.21 → 1.167.22Dependent
@tanstack/start-storage-context1.167.19 → 1.167.20Dependent
@tanstack/vue-start1.168.35 → 1.168.36Dependent
@tanstack/vue-start-client1.167.21 → 1.167.22Dependent
@tanstack/vue-start-server1.167.25 → 1.167.26Dependent
@github-actions
github-actionsBot
commented
Aug 5, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Bundle Size Benchmarks
  • Commit: 5d9d59b8b9d5
  • Measured at: 2026-08-06T10:52:17.935Z
  • Baseline source: history:697ebb6ddbd4
  • Dashboard: bundle-size history
The following scenarios have bundle-size changes compared with the baseline:
ScenarioCurrent (gzip)Delta vs baselineInitial gzipRawBrotliTrend
react-router.minimal87.10 KiB-8 B (-0.01%)86.97 KiB269.10 KiB75.87 KiB████▂▂▂▂▂▁▂▁
react-router.full90.89 KiB-4 B (-0.00%)90.75 KiB281.06 KiB79.10 KiB████▂▂▂▂▂▁▂▂
solid-router.minimal34.79 KiB-2 B (-0.01%)34.67 KiB99.95 KiB31.35 KiB████▂▂▂▂▂▁▁▁
solid-router.full39.90 KiB-3 B (-0.01%)39.77 KiB115.12 KiB35.92 KiB████▂▂▂▂▂▁▁▁
vue-router.minimal52.07 KiB-24 B (-0.04%)51.94 KiB143.05 KiB46.90 KiB████▂▂▂▂▂▁▁▁
vue-router.full58.03 KiB-21 B (-0.04%)57.90 KiB161.73 KiB52.05 KiB████▂▂▂▂▂▁▁▁
react-start.minimal100.59 KiB-5 B (-0.00%)100.46 KiB312.25 KiB87.36 KiB███████▁▁▁▁▁
react-start.deferred-hydration101.33 KiB-9 B (-0.01%)100.48 KiB313.63 KiB87.99 KiB███████▁▁▁▁▁
react-start.full103.91 KiB-8 B (-0.01%)103.78 KiB322.20 KiB90.18 KiB███████▁▁▁▁▁
react-start.rsbuild.minimal100.23 KiB-4 B (-0.00%)100.06 KiB316.74 KiB86.39 KiB▁▁▁▁▂▂▂█████
react-start.rsbuild.minimal-iife100.64 KiB-3 B (-0.00%)100.48 KiB317.67 KiB86.73 KiB▁▁▁▁▂▂▂█████
react-start.rsbuild.full103.56 KiB-5 B (-0.00%)103.39 KiB326.83 KiB89.12 KiB▁▁▁▁▃▃▃█████
solid-start.minimal48.18 KiB-1 B (-0.00%)48.05 KiB142.08 KiB42.78 KiB███████▁▁▁▁▁
solid-start.full53.42 KiB-10 B (-0.02%)53.29 KiB157.82 KiB47.41 KiB████▆▆▆▁▁▁▁▁
vue-start.minimal68.95 KiB-26 B (-0.04%)68.82 KiB195.05 KiB61.26 KiB████▆▆▆▁▁▁▁▁
vue-start.full72.91 KiB-22 B (-0.03%)72.78 KiB207.55 KiB64.71 KiB████▆▆▆▁▁▁▁▁
Current gzip tracks all emitted client JS chunks. Initial gzip tracks only the entry/import graph. Trend sparkline is historical current gzip ending with this PR measurement; lower is better.
@pkg-pr-new
pkg-pr-newBot
commented
Aug 5, 2026•

edited

Loading

Copy link


Copy Markdown

More templates
@tanstack/arktype-adapter
npm i https://pkg.pr.new/@tanstack/arktype-adapter@7971

@tanstack/eslint-plugin-router
npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@7971

@tanstack/eslint-plugin-start
npm i https://pkg.pr.new/@tanstack/eslint-plugin-start@7971

@tanstack/history
npm i https://pkg.pr.new/@tanstack/history@7971

@tanstack/nitro-v2-vite-plugin
npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@7971

@tanstack/react-router
npm i https://pkg.pr.new/@tanstack/react-router@7971

@tanstack/react-router-devtools
npm i https://pkg.pr.new/@tanstack/react-router-devtools@7971

@tanstack/react-router-ssr-query
npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@7971

@tanstack/react-start
npm i https://pkg.pr.new/@tanstack/react-start@7971

@tanstack/react-start-client
npm i https://pkg.pr.new/@tanstack/react-start-client@7971

@tanstack/react-start-rsc
npm i https://pkg.pr.new/@tanstack/react-start-rsc@7971

@tanstack/react-start-server
npm i https://pkg.pr.new/@tanstack/react-start-server@7971

@tanstack/router-cli
npm i https://pkg.pr.new/@tanstack/router-cli@7971

@tanstack/router-core
npm i https://pkg.pr.new/@tanstack/router-core@7971

@tanstack/router-devtools
npm i https://pkg.pr.new/@tanstack/router-devtools@7971

@tanstack/router-devtools-core
npm i https://pkg.pr.new/@tanstack/router-devtools-core@7971

@tanstack/router-generator
npm i https://pkg.pr.new/@tanstack/router-generator@7971

@tanstack/router-plugin
npm i https://pkg.pr.new/@tanstack/router-plugin@7971

@tanstack/router-ssr-query-core
npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@7971

@tanstack/router-utils
npm i https://pkg.pr.new/@tanstack/router-utils@7971

@tanstack/router-vite-plugin
npm i https://pkg.pr.new/@tanstack/router-vite-plugin@7971

@tanstack/solid-router
npm i https://pkg.pr.new/@tanstack/solid-router@7971

@tanstack/solid-router-devtools
npm i https://pkg.pr.new/@tanstack/solid-router-devtools@7971

@tanstack/solid-router-ssr-query
npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@7971

@tanstack/solid-start
npm i https://pkg.pr.new/@tanstack/solid-start@7971

@tanstack/solid-start-client
npm i https://pkg.pr.new/@tanstack/solid-start-client@7971

@tanstack/solid-start-server
npm i https://pkg.pr.new/@tanstack/solid-start-server@7971

@tanstack/start-client-core
npm i https://pkg.pr.new/@tanstack/start-client-core@7971

@tanstack/start-fn-stubs
npm i https://pkg.pr.new/@tanstack/start-fn-stubs@7971

@tanstack/start-plugin-core
npm i https://pkg.pr.new/@tanstack/start-plugin-core@7971

@tanstack/start-server-core
npm i https://pkg.pr.new/@tanstack/start-server-core@7971

@tanstack/start-static-server-functions
npm i https://pkg.pr.new/@tanstack/start-static-server-functions@7971

@tanstack/start-storage-context
npm i https://pkg.pr.new/@tanstack/start-storage-context@7971

@tanstack/valibot-adapter
npm i https://pkg.pr.new/@tanstack/valibot-adapter@7971

@tanstack/virtual-file-routes
npm i https://pkg.pr.new/@tanstack/virtual-file-routes@7971

@tanstack/vue-router
npm i https://pkg.pr.new/@tanstack/vue-router@7971

@tanstack/vue-router-devtools
npm i https://pkg.pr.new/@tanstack/vue-router-devtools@7971

@tanstack/vue-router-ssr-query
npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@7971

@tanstack/vue-start
npm i https://pkg.pr.new/@tanstack/vue-start@7971

@tanstack/vue-start-client
npm i https://pkg.pr.new/@tanstack/vue-start-client@7971

@tanstack/vue-start-server
npm i https://pkg.pr.new/@tanstack/vue-start-server@7971

@tanstack/zod-adapter
npm i https://pkg.pr.new/@tanstack/zod-adapter@7971

commit: 7d62f08
@codspeed-hq
codspeed-hqBot
commented
Aug 5, 2026•

edited

Loading

Copy link


Copy Markdown

Merging this PR will regress 0 benchmarks
⚠️Different runtime environments detected
Some benchmarks with significant performance changes were compared across different runtime environments,

which may affect the accuracy of the results.
Open the report in CodSpeed to investigate
⚡ 9 improved benchmarks
❌ 6 (👁 6) regressed benchmarks
✅ 165 untouched benchmarks
Performance Changes
ModeBenchmarkBASEHEADEfficiency
⚡Memorymem server server-fn-churn (vue)4,147.3 KB270.5 KB×15
⚡Memorymem server error-paths unmatched (vue)2,142.1 KB477.8 KB×4.5
⚡Memorymem server peak-large-page (react)1,737.5 KB951.6 KB+82.59%
⚡Memorymem server error-paths redirect (solid)388 KB283.2 KB+37%
⚡Memorymem server error-paths redirect (vue)338.6 KB295.9 KB+14.42%
⚡Simulationssr server-fn multipart (solid)64.2 ms61.2 ms+4.94%
⚡Simulationssr server-fn raw-stream (solid)113.2 ms108.3 ms+4.5%
⚡Memorymem server error-paths not-found (react)277.7 KB266.5 KB+4.2%
⚡Memorymem client navigation-churn (vue)1.3 MB1.2 MB+3.71%
👁Memorymem server error-paths not-found (solid)415.1 KB783.6 KB-47.03%
👁Memorymem server error-paths unmatched (react)317.5 KB481.9 KB-34.12%
👁Simulationssr dehydrate rich types (vue)135.2 ms139.4 ms-3.05%
👁Simulationssr request loop (solid)156.5 ms163.9 ms-4.48%
👁Simulationssr server-fn during document ssr (react)62.9 ms66.9 ms-6.06%
👁Memorymem client unique-location-churn (solid)341.2 KB471.5 KB-27.63%
Tip
Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.
Comparing codex/direct-intersection-observer-disabled (7d62f08) with main (697ebb6)
Open in CodSpeed
@Sheraff
Sheraff
marked this pull request as ready for review
August 6, 2026 07:01
coderabbitai[bot]
coderabbitaiBot
reviewed
Aug 6, 2026
View reviewed changes
@coderabbitaicoderabbitaiBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.changeset/quiet-doors-double.md:
- Line 7: Update the changeset description to document the released observer API
change: in the React, Solid, and Vue observer helpers, the disabled state is now
separate from the IntersectionObserverInit options. Replace the current
link-component cleanup wording with this API-focused description.

🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
  •  Push a commit to this branch (recommended)
  •  Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 1c6df6b3-c8b6-4b8d-bd2a-ea26814414cd
📥 Commits
Reviewing files that changed from the base of the PR and between a71c605 and 7d62f08.
📒 Files selected for processing (1)
  • .changeset/quiet-doors-double.md
Comment thread.changeset/quiet-doors-double.md
'@tanstack/vue-router': patch
---

clean intersection observer options in link component
@coderabbitaicoderabbitaiBotAug 6, 2026

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Describe the released observer API change.
The current text only mentions link-component cleanup. State that disabled state is now separate from IntersectionObserverInit options in the React, Solid, and Vue observer helpers.
Proposed wording
-clean intersection observer options in link component+Separate disabled state from intersection observer options in React, Solid, and Vue router helpers.
📝 Committable suggestion
‼️IMPORTANT

Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

clean intersection observer options in link component
Separate disabled state from intersection observer options in React, Solid, and Vue router helpers.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @.changeset/quiet-doors-double.md at line 7, Update the changeset description
to document the released observer API change: in the React, Solid, and Vue
observer helpers, the disabled state is now separate from the
IntersectionObserverInit options. Replace the current link-component cleanup
wording with this API-focused description.

@Sheraff
Sheraff
merged commit 86bf510
into
mainAug 6, 2026

28 of 29 checks passed

@Sheraff
Sheraff
deleted the

codex/direct-intersection-observer-disabled

branch
August 6, 2026 11:38
@github-actionsgithub-actionsBot
mentioned this pull request
Aug 6, 2026
 Merged

@coderabbitaicoderabbitaiBot
mentioned this pull request
Aug 11, 2026
 Merged

@brenelzbrenelz
mentioned this pull request
Aug 13, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@coderabbitaicoderabbitai[bot]coderabbitai[bot] left review comments

Assignees


No one assigned


Labels

package: react-routerpackage: solid-routerpackage: vue-router

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@Sheraff

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Pass intersection observer disabled state directly - #7971
Merged
Sheraff merged 4 commits into
mainfrom 
codex/direct-intersection-observer-disabled
Aug 6, 2026
Merged
Pass intersection observer disabled state directly#7971
Sheraff merged 4 commits into
mainfrom 
codex/direct-intersection-observer-disabled
Conversation
@Sheraff
@SheraffSheraff
commented
Aug 5, 2026•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Collaborator
Summary
  • pass the disabled boolean directly to the React and Solid intersection-observer helpers
  • pass Vue's reactive disabled getter directly, preserving watchEffect tracking
  • cover disabled viewport links and reactive observer teardown in Vue
Bundle-size impact
Prior isolated prototype measurements from the same main base (6aefb33925):
ScenarioRawGzipBrotli
react-router.minimal-32 B-10 B-3 B
solid-router.minimal-23 B-4 B-65 B
The final Vue hunk, measured against an otherwise identical worktree:
ScenarioRawGzipBrotli
vue-router.minimal-68 B-25 B+62 B
Gzip is the benchmark's primary metric.
Validation
  • React link tests: 131 passed
  • Solid unit tests: 838 client tests passed (1 skipped), 3 server tests passed
  • Vue link tests: 131 passed
  • React, Solid, and Vue type tests passed
  • React, Solid, and Vue builds passed
  • React, Solid, and Vue ESLint targets passed with existing warnings only
Summary by CodeRabbit
  • Bug Fixes
    • Improved viewport-based link preloading behavior across React, Solid, and Vue.
    • Links now correctly skip observation when disabled or when viewport preloading is unavailable.
    • Preloading observation now responds correctly when link conditions change.
    • Updated behavior is consistent across supported framework integrations.
  • Tests
    • Added coverage confirming disabled links are not observed and that observation starts or stops as conditions change.
@coderabbitai
coderabbitaiBot
commented
Aug 5, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Review Change Stack
📝 Walkthrough
Walkthrough
The change separates disabled state from IntersectionObserverInit options in React, Solid, and Vue utilities. Link integrations use the new signatures. Vue tests cover disabled links and reactive observer lifecycle behavior.
Changes
Intersection observer API update
Layer / File(s)Summary
Update observer utility signatures
packages/react-router/src/utils.ts, packages/solid-router/src/utils.ts, packages/vue-router/src/utils.ts, .changeset/quiet-doors-double.md		The utilities accept observer options separately from disabled state. The observer checks, examples, and documentation use the new parameters. A patch changeset covers the three router packages.
Update link observer calls
packages/react-router/src/link.tsx, packages/solid-router/src/link.tsx, packages/vue-router/src/link.tsx		Links pass boolean or callback disabled conditions directly to useIntersectionObserver.
Validate Vue observer behavior
packages/vue-router/tests/link.test.tsx		Tests verify that disabled viewport links are not observed and that observer creation and disconnection react to a disabled getter.
Estimated code review effort: 3 (Moderate) | ~20 minutes
🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 warning)
Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 66.67% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly and concisely describes the main change: passing the intersection observer disabled state directly.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  •  Create PR with unit tests
  •  Commit unit tests in branch codex/direct-intersection-observer-disabled
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands.
@nx-cloud
nx-cloudBot
commented
Aug 5, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
View your CI Pipeline Execution ↗ for commit 7d62f08
CommandStatusDurationResult
nx affected --targets=test:eslint,test:unit,tes...✅ Succeeded2m 38sView ↗
☁️ Nx Cloud last updated this comment at 2026-08-06 11:10:43 UTC
@github-actions
github-actionsBot
commented
Aug 5, 2026

Copy link


Copy Markdown

Contributor
🚀 Changeset Version Preview
5 package(s) bumped directly, 18 bumped as dependents.
🟩 Patch bumps
PackageVersionReason
@tanstack/react-router1.170.20 → 1.170.21Changeset
@tanstack/router-core1.171.17 → 1.171.18Changeset
@tanstack/solid-router1.170.20 → 1.170.21Changeset
@tanstack/start-server-core1.169.20 → 1.169.21Changeset
@tanstack/vue-router1.170.19 → 1.170.20Changeset
@tanstack/react-start1.168.37 → 1.168.38Dependent
@tanstack/react-start-client1.168.18 → 1.168.19Dependent
@tanstack/react-start-rsc0.1.36 → 0.1.37Dependent
@tanstack/react-start-server1.167.25 → 1.167.26Dependent
@tanstack/router-cli1.167.23 → 1.167.24Dependent
@tanstack/router-generator1.167.23 → 1.167.24Dependent
@tanstack/router-plugin1.168.25 → 1.168.26Dependent
@tanstack/router-vite-plugin1.167.25 → 1.167.26Dependent
@tanstack/solid-start1.168.36 → 1.168.37Dependent
@tanstack/solid-start-client1.168.18 → 1.168.19Dependent
@tanstack/solid-start-server1.167.25 → 1.167.26Dependent
@tanstack/start-client-core1.170.16 → 1.170.17Dependent
@tanstack/start-plugin-core1.171.28 → 1.171.29Dependent
@tanstack/start-static-server-functions1.167.21 → 1.167.22Dependent
@tanstack/start-storage-context1.167.19 → 1.167.20Dependent
@tanstack/vue-start1.168.35 → 1.168.36Dependent
@tanstack/vue-start-client1.167.21 → 1.167.22Dependent
@tanstack/vue-start-server1.167.25 → 1.167.26Dependent
@github-actions
github-actionsBot
commented
Aug 5, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Bundle Size Benchmarks
  • Commit: 5d9d59b8b9d5
  • Measured at: 2026-08-06T10:52:17.935Z
  • Baseline source: history:697ebb6ddbd4
  • Dashboard: bundle-size history
The following scenarios have bundle-size changes compared with the baseline:
ScenarioCurrent (gzip)Delta vs baselineInitial gzipRawBrotliTrend
react-router.minimal87.10 KiB-8 B (-0.01%)86.97 KiB269.10 KiB75.87 KiB████▂▂▂▂▂▁▂▁
react-router.full90.89 KiB-4 B (-0.00%)90.75 KiB281.06 KiB79.10 KiB████▂▂▂▂▂▁▂▂
solid-router.minimal34.79 KiB-2 B (-0.01%)34.67 KiB99.95 KiB31.35 KiB████▂▂▂▂▂▁▁▁
solid-router.full39.90 KiB-3 B (-0.01%)39.77 KiB115.12 KiB35.92 KiB████▂▂▂▂▂▁▁▁
vue-router.minimal52.07 KiB-24 B (-0.04%)51.94 KiB143.05 KiB46.90 KiB████▂▂▂▂▂▁▁▁
vue-router.full58.03 KiB-21 B (-0.04%)57.90 KiB161.73 KiB52.05 KiB████▂▂▂▂▂▁▁▁
react-start.minimal100.59 KiB-5 B (-0.00%)100.46 KiB312.25 KiB87.36 KiB███████▁▁▁▁▁
react-start.deferred-hydration101.33 KiB-9 B (-0.01%)100.48 KiB313.63 KiB87.99 KiB███████▁▁▁▁▁
react-start.full103.91 KiB-8 B (-0.01%)103.78 KiB322.20 KiB90.18 KiB███████▁▁▁▁▁
react-start.rsbuild.minimal100.23 KiB-4 B (-0.00%)100.06 KiB316.74 KiB86.39 KiB▁▁▁▁▂▂▂█████
react-start.rsbuild.minimal-iife100.64 KiB-3 B (-0.00%)100.48 KiB317.67 KiB86.73 KiB▁▁▁▁▂▂▂█████
react-start.rsbuild.full103.56 KiB-5 B (-0.00%)103.39 KiB326.83 KiB89.12 KiB▁▁▁▁▃▃▃█████
solid-start.minimal48.18 KiB-1 B (-0.00%)48.05 KiB142.08 KiB42.78 KiB███████▁▁▁▁▁
solid-start.full53.42 KiB-10 B (-0.02%)53.29 KiB157.82 KiB47.41 KiB████▆▆▆▁▁▁▁▁
vue-start.minimal68.95 KiB-26 B (-0.04%)68.82 KiB195.05 KiB61.26 KiB████▆▆▆▁▁▁▁▁
vue-start.full72.91 KiB-22 B (-0.03%)72.78 KiB207.55 KiB64.71 KiB████▆▆▆▁▁▁▁▁
Current gzip tracks all emitted client JS chunks. Initial gzip tracks only the entry/import graph. Trend sparkline is historical current gzip ending with this PR measurement; lower is better.
@pkg-pr-new
pkg-pr-newBot
commented
Aug 5, 2026•

edited

Loading

Copy link


Copy Markdown

More templates
@tanstack/arktype-adapter
npm i https://pkg.pr.new/@tanstack/arktype-adapter@7971

@tanstack/eslint-plugin-router
npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@7971

@tanstack/eslint-plugin-start
npm i https://pkg.pr.new/@tanstack/eslint-plugin-start@7971

@tanstack/history
npm i https://pkg.pr.new/@tanstack/history@7971

@tanstack/nitro-v2-vite-plugin
npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@7971

@tanstack/react-router
npm i https://pkg.pr.new/@tanstack/react-router@7971

@tanstack/react-router-devtools
npm i https://pkg.pr.new/@tanstack/react-router-devtools@7971

@tanstack/react-router-ssr-query
npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@7971

@tanstack/react-start
npm i https://pkg.pr.new/@tanstack/react-start@7971

@tanstack/react-start-client
npm i https://pkg.pr.new/@tanstack/react-start-client@7971

@tanstack/react-start-rsc
npm i https://pkg.pr.new/@tanstack/react-start-rsc@7971

@tanstack/react-start-server
npm i https://pkg.pr.new/@tanstack/react-start-server@7971

@tanstack/router-cli
npm i https://pkg.pr.new/@tanstack/router-cli@7971

@tanstack/router-core
npm i https://pkg.pr.new/@tanstack/router-core@7971

@tanstack/router-devtools
npm i https://pkg.pr.new/@tanstack/router-devtools@7971

@tanstack/router-devtools-core
npm i https://pkg.pr.new/@tanstack/router-devtools-core@7971

@tanstack/router-generator
npm i https://pkg.pr.new/@tanstack/router-generator@7971

@tanstack/router-plugin
npm i https://pkg.pr.new/@tanstack/router-plugin@7971

@tanstack/router-ssr-query-core
npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@7971

@tanstack/router-utils
npm i https://pkg.pr.new/@tanstack/router-utils@7971

@tanstack/router-vite-plugin
npm i https://pkg.pr.new/@tanstack/router-vite-plugin@7971

@tanstack/solid-router
npm i https://pkg.pr.new/@tanstack/solid-router@7971

@tanstack/solid-router-devtools
npm i https://pkg.pr.new/@tanstack/solid-router-devtools@7971

@tanstack/solid-router-ssr-query
npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@7971

@tanstack/solid-start
npm i https://pkg.pr.new/@tanstack/solid-start@7971

@tanstack/solid-start-client
npm i https://pkg.pr.new/@tanstack/solid-start-client@7971

@tanstack/solid-start-server
npm i https://pkg.pr.new/@tanstack/solid-start-server@7971

@tanstack/start-client-core
npm i https://pkg.pr.new/@tanstack/start-client-core@7971

@tanstack/start-fn-stubs
npm i https://pkg.pr.new/@tanstack/start-fn-stubs@7971

@tanstack/start-plugin-core
npm i https://pkg.pr.new/@tanstack/start-plugin-core@7971

@tanstack/start-server-core
npm i https://pkg.pr.new/@tanstack/start-server-core@7971

@tanstack/start-static-server-functions
npm i https://pkg.pr.new/@tanstack/start-static-server-functions@7971

@tanstack/start-storage-context
npm i https://pkg.pr.new/@tanstack/start-storage-context@7971

@tanstack/valibot-adapter
npm i https://pkg.pr.new/@tanstack/valibot-adapter@7971

@tanstack/virtual-file-routes
npm i https://pkg.pr.new/@tanstack/virtual-file-routes@7971

@tanstack/vue-router
npm i https://pkg.pr.new/@tanstack/vue-router@7971

@tanstack/vue-router-devtools
npm i https://pkg.pr.new/@tanstack/vue-router-devtools@7971

@tanstack/vue-router-ssr-query
npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@7971

@tanstack/vue-start
npm i https://pkg.pr.new/@tanstack/vue-start@7971

@tanstack/vue-start-client
npm i https://pkg.pr.new/@tanstack/vue-start-client@7971

@tanstack/vue-start-server
npm i https://pkg.pr.new/@tanstack/vue-start-server@7971

@tanstack/zod-adapter
npm i https://pkg.pr.new/@tanstack/zod-adapter@7971

commit: 7d62f08
@codspeed-hq
codspeed-hqBot
commented
Aug 5, 2026•

edited

Loading

Copy link


Copy Markdown

Merging this PR will regress 0 benchmarks
⚠️Different runtime environments detected
Some benchmarks with significant performance changes were compared across different runtime environments,

which may affect the accuracy of the results.
Open the report in CodSpeed to investigate
⚡ 9 improved benchmarks
❌ 6 (👁 6) regressed benchmarks
✅ 165 untouched benchmarks
Performance Changes
ModeBenchmarkBASEHEADEfficiency
⚡Memorymem server server-fn-churn (vue)4,147.3 KB270.5 KB×15
⚡Memorymem server error-paths unmatched (vue)2,142.1 KB477.8 KB×4.5
⚡Memorymem server peak-large-page (react)1,737.5 KB951.6 KB+82.59%
⚡Memorymem server error-paths redirect (solid)388 KB283.2 KB+37%
⚡Memorymem server error-paths redirect (vue)338.6 KB295.9 KB+14.42%
⚡Simulationssr server-fn multipart (solid)64.2 ms61.2 ms+4.94%
⚡Simulationssr server-fn raw-stream (solid)113.2 ms108.3 ms+4.5%
⚡Memorymem server error-paths not-found (react)277.7 KB266.5 KB+4.2%
⚡Memorymem client navigation-churn (vue)1.3 MB1.2 MB+3.71%
👁Memorymem server error-paths not-found (solid)415.1 KB783.6 KB-47.03%
👁Memorymem server error-paths unmatched (react)317.5 KB481.9 KB-34.12%
👁Simulationssr dehydrate rich types (vue)135.2 ms139.4 ms-3.05%
👁Simulationssr request loop (solid)156.5 ms163.9 ms-4.48%
👁Simulationssr server-fn during document ssr (react)62.9 ms66.9 ms-6.06%
👁Memorymem client unique-location-churn (solid)341.2 KB471.5 KB-27.63%
Tip
Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.
Comparing codex/direct-intersection-observer-disabled (7d62f08) with main (697ebb6)
Open in CodSpeed
@Sheraff
Sheraff
marked this pull request as ready for review
August 6, 2026 07:01
coderabbitai[bot]
coderabbitaiBot
reviewed
Aug 6, 2026
View reviewed changes
@coderabbitaicoderabbitaiBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.changeset/quiet-doors-double.md:
- Line 7: Update the changeset description to document the released observer API
change: in the React, Solid, and Vue observer helpers, the disabled state is now
separate from the IntersectionObserverInit options. Replace the current
link-component cleanup wording with this API-focused description.

🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
  •  Push a commit to this branch (recommended)
  •  Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 1c6df6b3-c8b6-4b8d-bd2a-ea26814414cd
📥 Commits
Reviewing files that changed from the base of the PR and between a71c605 and 7d62f08.
📒 Files selected for processing (1)
  • .changeset/quiet-doors-double.md
Comment thread.changeset/quiet-doors-double.md
'@tanstack/vue-router': patch
---

clean intersection observer options in link component
@coderabbitaicoderabbitaiBotAug 6, 2026

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Describe the released observer API change.
The current text only mentions link-component cleanup. State that disabled state is now separate from IntersectionObserverInit options in the React, Solid, and Vue observer helpers.
Proposed wording
-clean intersection observer options in link component+Separate disabled state from intersection observer options in React, Solid, and Vue router helpers.
📝 Committable suggestion
‼️IMPORTANT

Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

clean intersection observer options in link component
Separate disabled state from intersection observer options in React, Solid, and Vue router helpers.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @.changeset/quiet-doors-double.md at line 7, Update the changeset description
to document the released observer API change: in the React, Solid, and Vue
observer helpers, the disabled state is now separate from the
IntersectionObserverInit options. Replace the current link-component cleanup
wording with this API-focused description.

@Sheraff
Sheraff
merged commit 86bf510
into
mainAug 6, 2026

28 of 29 checks passed

@Sheraff
Sheraff
deleted the

codex/direct-intersection-observer-disabled

branch
August 6, 2026 11:38
@github-actionsgithub-actionsBot
mentioned this pull request
Aug 6, 2026
 Merged

@coderabbitaicoderabbitaiBot
mentioned this pull request
Aug 11, 2026
 Merged

@brenelzbrenelz
mentioned this pull request
Aug 13, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@coderabbitaicoderabbitai[bot]coderabbitai[bot] left review comments

Assignees


No one assigned


Labels

package: react-routerpackage: solid-routerpackage: vue-router

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@Sheraff

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Pass intersection observer disabled state directly - #7971
Merged
Sheraff merged 4 commits into
mainfrom 
codex/direct-intersection-observer-disabled
Aug 6, 2026
Merged
Pass intersection observer disabled state directly#7971
Sheraff merged 4 commits into
mainfrom 
codex/direct-intersection-observer-disabled
Conversation
@Sheraff
@SheraffSheraff
commented
Aug 5, 2026•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Collaborator
Summary
  • pass the disabled boolean directly to the React and Solid intersection-observer helpers
  • pass Vue's reactive disabled getter directly, preserving watchEffect tracking
  • cover disabled viewport links and reactive observer teardown in Vue
Bundle-size impact
Prior isolated prototype measurements from the same main base (6aefb33925):
ScenarioRawGzipBrotli
react-router.minimal-32 B-10 B-3 B
solid-router.minimal-23 B-4 B-65 B
The final Vue hunk, measured against an otherwise identical worktree:
ScenarioRawGzipBrotli
vue-router.minimal-68 B-25 B+62 B
Gzip is the benchmark's primary metric.
Validation
  • React link tests: 131 passed
  • Solid unit tests: 838 client tests passed (1 skipped), 3 server tests passed
  • Vue link tests: 131 passed
  • React, Solid, and Vue type tests passed
  • React, Solid, and Vue builds passed
  • React, Solid, and Vue ESLint targets passed with existing warnings only
Summary by CodeRabbit
  • Bug Fixes
    • Improved viewport-based link preloading behavior across React, Solid, and Vue.
    • Links now correctly skip observation when disabled or when viewport preloading is unavailable.
    • Preloading observation now responds correctly when link conditions change.
    • Updated behavior is consistent across supported framework integrations.
  • Tests
    • Added coverage confirming disabled links are not observed and that observation starts or stops as conditions change.
@coderabbitai
coderabbitaiBot
commented
Aug 5, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Review Change Stack
📝 Walkthrough
Walkthrough
The change separates disabled state from IntersectionObserverInit options in React, Solid, and Vue utilities. Link integrations use the new signatures. Vue tests cover disabled links and reactive observer lifecycle behavior.
Changes
Intersection observer API update
Layer / File(s)Summary
Update observer utility signatures
packages/react-router/src/utils.ts, packages/solid-router/src/utils.ts, packages/vue-router/src/utils.ts, .changeset/quiet-doors-double.md		The utilities accept observer options separately from disabled state. The observer checks, examples, and documentation use the new parameters. A patch changeset covers the three router packages.
Update link observer calls
packages/react-router/src/link.tsx, packages/solid-router/src/link.tsx, packages/vue-router/src/link.tsx		Links pass boolean or callback disabled conditions directly to useIntersectionObserver.
Validate Vue observer behavior
packages/vue-router/tests/link.test.tsx		Tests verify that disabled viewport links are not observed and that observer creation and disconnection react to a disabled getter.
Estimated code review effort: 3 (Moderate) | ~20 minutes
🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 warning)
Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 66.67% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly and concisely describes the main change: passing the intersection observer disabled state directly.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  •  Create PR with unit tests
  •  Commit unit tests in branch codex/direct-intersection-observer-disabled
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands.
@nx-cloud
nx-cloudBot
commented
Aug 5, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
View your CI Pipeline Execution ↗ for commit 7d62f08
CommandStatusDurationResult
nx affected --targets=test:eslint,test:unit,tes...✅ Succeeded2m 38sView ↗
☁️ Nx Cloud last updated this comment at 2026-08-06 11:10:43 UTC
@github-actions
github-actionsBot
commented
Aug 5, 2026

Copy link


Copy Markdown

Contributor
🚀 Changeset Version Preview
5 package(s) bumped directly, 18 bumped as dependents.
🟩 Patch bumps
PackageVersionReason
@tanstack/react-router1.170.20 → 1.170.21Changeset
@tanstack/router-core1.171.17 → 1.171.18Changeset
@tanstack/solid-router1.170.20 → 1.170.21Changeset
@tanstack/start-server-core1.169.20 → 1.169.21Changeset
@tanstack/vue-router1.170.19 → 1.170.20Changeset
@tanstack/react-start1.168.37 → 1.168.38Dependent
@tanstack/react-start-client1.168.18 → 1.168.19Dependent
@tanstack/react-start-rsc0.1.36 → 0.1.37Dependent
@tanstack/react-start-server1.167.25 → 1.167.26Dependent
@tanstack/router-cli1.167.23 → 1.167.24Dependent
@tanstack/router-generator1.167.23 → 1.167.24Dependent
@tanstack/router-plugin1.168.25 → 1.168.26Dependent
@tanstack/router-vite-plugin1.167.25 → 1.167.26Dependent
@tanstack/solid-start1.168.36 → 1.168.37Dependent
@tanstack/solid-start-client1.168.18 → 1.168.19Dependent
@tanstack/solid-start-server1.167.25 → 1.167.26Dependent
@tanstack/start-client-core1.170.16 → 1.170.17Dependent
@tanstack/start-plugin-core1.171.28 → 1.171.29Dependent
@tanstack/start-static-server-functions1.167.21 → 1.167.22Dependent
@tanstack/start-storage-context1.167.19 → 1.167.20Dependent
@tanstack/vue-start1.168.35 → 1.168.36Dependent
@tanstack/vue-start-client1.167.21 → 1.167.22Dependent
@tanstack/vue-start-server1.167.25 → 1.167.26Dependent
@github-actions
github-actionsBot
commented
Aug 5, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Bundle Size Benchmarks
  • Commit: 5d9d59b8b9d5
  • Measured at: 2026-08-06T10:52:17.935Z
  • Baseline source: history:697ebb6ddbd4
  • Dashboard: bundle-size history
The following scenarios have bundle-size changes compared with the baseline:
ScenarioCurrent (gzip)Delta vs baselineInitial gzipRawBrotliTrend
react-router.minimal87.10 KiB-8 B (-0.01%)86.97 KiB269.10 KiB75.87 KiB████▂▂▂▂▂▁▂▁
react-router.full90.89 KiB-4 B (-0.00%)90.75 KiB281.06 KiB79.10 KiB████▂▂▂▂▂▁▂▂
solid-router.minimal34.79 KiB-2 B (-0.01%)34.67 KiB99.95 KiB31.35 KiB████▂▂▂▂▂▁▁▁
solid-router.full39.90 KiB-3 B (-0.01%)39.77 KiB115.12 KiB35.92 KiB████▂▂▂▂▂▁▁▁
vue-router.minimal52.07 KiB-24 B (-0.04%)51.94 KiB143.05 KiB46.90 KiB████▂▂▂▂▂▁▁▁
vue-router.full58.03 KiB-21 B (-0.04%)57.90 KiB161.73 KiB52.05 KiB████▂▂▂▂▂▁▁▁
react-start.minimal100.59 KiB-5 B (-0.00%)100.46 KiB312.25 KiB87.36 KiB███████▁▁▁▁▁
react-start.deferred-hydration101.33 KiB-9 B (-0.01%)100.48 KiB313.63 KiB87.99 KiB███████▁▁▁▁▁
react-start.full103.91 KiB-8 B (-0.01%)103.78 KiB322.20 KiB90.18 KiB███████▁▁▁▁▁
react-start.rsbuild.minimal100.23 KiB-4 B (-0.00%)100.06 KiB316.74 KiB86.39 KiB▁▁▁▁▂▂▂█████
react-start.rsbuild.minimal-iife100.64 KiB-3 B (-0.00%)100.48 KiB317.67 KiB86.73 KiB▁▁▁▁▂▂▂█████
react-start.rsbuild.full103.56 KiB-5 B (-0.00%)103.39 KiB326.83 KiB89.12 KiB▁▁▁▁▃▃▃█████
solid-start.minimal48.18 KiB-1 B (-0.00%)48.05 KiB142.08 KiB42.78 KiB███████▁▁▁▁▁
solid-start.full53.42 KiB-10 B (-0.02%)53.29 KiB157.82 KiB47.41 KiB████▆▆▆▁▁▁▁▁
vue-start.minimal68.95 KiB-26 B (-0.04%)68.82 KiB195.05 KiB61.26 KiB████▆▆▆▁▁▁▁▁
vue-start.full72.91 KiB-22 B (-0.03%)72.78 KiB207.55 KiB64.71 KiB████▆▆▆▁▁▁▁▁
Current gzip tracks all emitted client JS chunks. Initial gzip tracks only the entry/import graph. Trend sparkline is historical current gzip ending with this PR measurement; lower is better.
@pkg-pr-new
pkg-pr-newBot
commented
Aug 5, 2026•

edited

Loading

Copy link


Copy Markdown

More templates
@tanstack/arktype-adapter
npm i https://pkg.pr.new/@tanstack/arktype-adapter@7971

@tanstack/eslint-plugin-router
npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@7971

@tanstack/eslint-plugin-start
npm i https://pkg.pr.new/@tanstack/eslint-plugin-start@7971

@tanstack/history
npm i https://pkg.pr.new/@tanstack/history@7971

@tanstack/nitro-v2-vite-plugin
npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@7971

@tanstack/react-router
npm i https://pkg.pr.new/@tanstack/react-router@7971

@tanstack/react-router-devtools
npm i https://pkg.pr.new/@tanstack/react-router-devtools@7971

@tanstack/react-router-ssr-query
npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@7971

@tanstack/react-start
npm i https://pkg.pr.new/@tanstack/react-start@7971

@tanstack/react-start-client
npm i https://pkg.pr.new/@tanstack/react-start-client@7971

@tanstack/react-start-rsc
npm i https://pkg.pr.new/@tanstack/react-start-rsc@7971

@tanstack/react-start-server
npm i https://pkg.pr.new/@tanstack/react-start-server@7971

@tanstack/router-cli
npm i https://pkg.pr.new/@tanstack/router-cli@7971

@tanstack/router-core
npm i https://pkg.pr.new/@tanstack/router-core@7971

@tanstack/router-devtools
npm i https://pkg.pr.new/@tanstack/router-devtools@7971

@tanstack/router-devtools-core
npm i https://pkg.pr.new/@tanstack/router-devtools-core@7971

@tanstack/router-generator
npm i https://pkg.pr.new/@tanstack/router-generator@7971

@tanstack/router-plugin
npm i https://pkg.pr.new/@tanstack/router-plugin@7971

@tanstack/router-ssr-query-core
npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@7971

@tanstack/router-utils
npm i https://pkg.pr.new/@tanstack/router-utils@7971

@tanstack/router-vite-plugin
npm i https://pkg.pr.new/@tanstack/router-vite-plugin@7971

@tanstack/solid-router
npm i https://pkg.pr.new/@tanstack/solid-router@7971

@tanstack/solid-router-devtools
npm i https://pkg.pr.new/@tanstack/solid-router-devtools@7971

@tanstack/solid-router-ssr-query
npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@7971

@tanstack/solid-start
npm i https://pkg.pr.new/@tanstack/solid-start@7971

@tanstack/solid-start-client
npm i https://pkg.pr.new/@tanstack/solid-start-client@7971

@tanstack/solid-start-server
npm i https://pkg.pr.new/@tanstack/solid-start-server@7971

@tanstack/start-client-core
npm i https://pkg.pr.new/@tanstack/start-client-core@7971

@tanstack/start-fn-stubs
npm i https://pkg.pr.new/@tanstack/start-fn-stubs@7971

@tanstack/start-plugin-core
npm i https://pkg.pr.new/@tanstack/start-plugin-core@7971

@tanstack/start-server-core
npm i https://pkg.pr.new/@tanstack/start-server-core@7971

@tanstack/start-static-server-functions
npm i https://pkg.pr.new/@tanstack/start-static-server-functions@7971

@tanstack/start-storage-context
npm i https://pkg.pr.new/@tanstack/start-storage-context@7971

@tanstack/valibot-adapter
npm i https://pkg.pr.new/@tanstack/valibot-adapter@7971

@tanstack/virtual-file-routes
npm i https://pkg.pr.new/@tanstack/virtual-file-routes@7971

@tanstack/vue-router
npm i https://pkg.pr.new/@tanstack/vue-router@7971

@tanstack/vue-router-devtools
npm i https://pkg.pr.new/@tanstack/vue-router-devtools@7971

@tanstack/vue-router-ssr-query
npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@7971

@tanstack/vue-start
npm i https://pkg.pr.new/@tanstack/vue-start@7971

@tanstack/vue-start-client
npm i https://pkg.pr.new/@tanstack/vue-start-client@7971

@tanstack/vue-start-server
npm i https://pkg.pr.new/@tanstack/vue-start-server@7971

@tanstack/zod-adapter
npm i https://pkg.pr.new/@tanstack/zod-adapter@7971

commit: 7d62f08
@codspeed-hq
codspeed-hqBot
commented
Aug 5, 2026•

edited

Loading

Copy link


Copy Markdown

Merging this PR will regress 0 benchmarks
⚠️Different runtime environments detected
Some benchmarks with significant performance changes were compared across different runtime environments,

which may affect the accuracy of the results.
Open the report in CodSpeed to investigate
⚡ 9 improved benchmarks
❌ 6 (👁 6) regressed benchmarks
✅ 165 untouched benchmarks
Performance Changes
ModeBenchmarkBASEHEADEfficiency
⚡Memorymem server server-fn-churn (vue)4,147.3 KB270.5 KB×15
⚡Memorymem server error-paths unmatched (vue)2,142.1 KB477.8 KB×4.5
⚡Memorymem server peak-large-page (react)1,737.5 KB951.6 KB+82.59%
⚡Memorymem server error-paths redirect (solid)388 KB283.2 KB+37%
⚡Memorymem server error-paths redirect (vue)338.6 KB295.9 KB+14.42%
⚡Simulationssr server-fn multipart (solid)64.2 ms61.2 ms+4.94%
⚡Simulationssr server-fn raw-stream (solid)113.2 ms108.3 ms+4.5%
⚡Memorymem server error-paths not-found (react)277.7 KB266.5 KB+4.2%
⚡Memorymem client navigation-churn (vue)1.3 MB1.2 MB+3.71%
👁Memorymem server error-paths not-found (solid)415.1 KB783.6 KB-47.03%
👁Memorymem server error-paths unmatched (react)317.5 KB481.9 KB-34.12%
👁Simulationssr dehydrate rich types (vue)135.2 ms139.4 ms-3.05%
👁Simulationssr request loop (solid)156.5 ms163.9 ms-4.48%
👁Simulationssr server-fn during document ssr (react)62.9 ms66.9 ms-6.06%
👁Memorymem client unique-location-churn (solid)341.2 KB471.5 KB-27.63%
Tip
Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.
Comparing codex/direct-intersection-observer-disabled (7d62f08) with main (697ebb6)
Open in CodSpeed
@Sheraff
Sheraff
marked this pull request as ready for review
August 6, 2026 07:01
coderabbitai[bot]
coderabbitaiBot
reviewed
Aug 6, 2026
View reviewed changes
@coderabbitaicoderabbitaiBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.changeset/quiet-doors-double.md:
- Line 7: Update the changeset description to document the released observer API
change: in the React, Solid, and Vue observer helpers, the disabled state is now
separate from the IntersectionObserverInit options. Replace the current
link-component cleanup wording with this API-focused description.

🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
  •  Push a commit to this branch (recommended)
  •  Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 1c6df6b3-c8b6-4b8d-bd2a-ea26814414cd
📥 Commits
Reviewing files that changed from the base of the PR and between a71c605 and 7d62f08.
📒 Files selected for processing (1)
  • .changeset/quiet-doors-double.md
Comment thread.changeset/quiet-doors-double.md
'@tanstack/vue-router': patch
---

clean intersection observer options in link component
@coderabbitaicoderabbitaiBotAug 6, 2026

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Describe the released observer API change.
The current text only mentions link-component cleanup. State that disabled state is now separate from IntersectionObserverInit options in the React, Solid, and Vue observer helpers.
Proposed wording
-clean intersection observer options in link component+Separate disabled state from intersection observer options in React, Solid, and Vue router helpers.
📝 Committable suggestion
‼️IMPORTANT

Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

clean intersection observer options in link component
Separate disabled state from intersection observer options in React, Solid, and Vue router helpers.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @.changeset/quiet-doors-double.md at line 7, Update the changeset description
to document the released observer API change: in the React, Solid, and Vue
observer helpers, the disabled state is now separate from the
IntersectionObserverInit options. Replace the current link-component cleanup
wording with this API-focused description.

@Sheraff
Sheraff
merged commit 86bf510
into
mainAug 6, 2026

28 of 29 checks passed

@Sheraff
Sheraff
deleted the

codex/direct-intersection-observer-disabled

branch
August 6, 2026 11:38
@github-actionsgithub-actionsBot
mentioned this pull request
Aug 6, 2026
 Merged

@coderabbitaicoderabbitaiBot
mentioned this pull request
Aug 11, 2026
 Merged

@brenelzbrenelz
mentioned this pull request
Aug 13, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@coderabbitaicoderabbitai[bot]coderabbitai[bot] left review comments

Assignees


No one assigned


Labels

package: react-routerpackage: solid-routerpackage: vue-router

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@Sheraff