perf(start-client-core): compact private frame decoder result keys - #7978

Merged
Sheraff merged 6 commits into
mainfrom
codex/frame-decoder-compact-result
Aug 7, 2026
Merged

perf(start-client-core): compact private frame decoder result keys#7978
Sheraff merged 6 commits into
mainfrom
codex/frame-decoder-compact-result

Conversation

@Sheraff

@SheraffSheraff commented Aug 6, 2026•
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Collaborator

What changed

  • Rename the private createFrameDecoder result keys from getOrCreateStream/jsonChunks to getStream/chunks.
  • Update the sole production consumer and direct decoder tests in lockstep.
  • Keep the existing two-property object shape, function/stream identities, property order, and public exports unchanged.

Bundle impact

Across the full 17-scenario matrix, all 11 Start scenarios improve by 4–12 B gzip and 24 B raw; all six router-only scenarios are byte-identical. Both renames also improve independently on react-start.minimal: getStream saves 6 B gzip / 16 B raw, and chunks saves 1 B gzip / 8 B raw. Brotli is mixed and documented in the evidence report.

Validation

  • start-client-core frame-decoder unit suite: 19 passed
  • TypeScript 5.6, 5.7, 5.8, 5.9, 6.0, and 7.0 matrices passed
  • ESLint passed with no new errors
  • React Start Vite/SSR client-RPC RawStream e2e: 6 passed
  • Full 17-scenario bundle matrix passed
  • Runtime allocation/destructure benchmark found no directional change
  • Five independent bundle, runtime, API, integration, and codegen reviews approved

Detailed artifacts and attribution are recorded in RESULT-optimization-frame-decoder-compact-result.md.

Summary by CodeRabbit

  • Refactor

    • Updated framed response handling with clearer stream and chunk naming.
    • Improved consistency in stream decoding interfaces without changing behavior.
    • Reduced the size of private frame decoder result keys.

  • Tests

    • Updated decoder coverage to use the revised stream and chunk terminology.
    • Existing test behavior and assertions remain unchanged.

@coderabbitai

coderabbitaiBot commented Aug 6, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 045851a8-70eb-4673-b830-e1c3eeeb3482

📥 Commits

Reviewing files that changed from the base of the PR and between 7b62859 and b775949.

📒 Files selected for processing (1)
  • .changeset/kind-ghosts-win.md
📝 Walkthrough

Walkthrough

The frame decoder result API now exposes getStream and chunks. Server framed-response handling and decoder tests use the renamed properties. A Changeset records a patch release.

Changes

Frame decoder naming update

Layer / File(s)Summary
Rename decoder result properties
packages/start-client-core/src/client-rpc/frame-decoder.ts		FrameDecoderResult and createFrameDecoder now expose getStream and chunks.
Update response handling and tests
packages/start-client-core/src/client-rpc/serverFnFetcher.ts, packages/start-client-core/tests/frame-decoder.test.ts		Framed-response handling and decoder tests now consume the renamed properties. Aliases preserve existing local test names.
Record patch release
.changeset/kind-ghosts-win.md		The Changeset records a patch release for @tanstack/start-client-core.

Estimated code review effort: 1 (Trivial) | ~5 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly and concisely describes the main change: compacting private frame decoder result keys.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/frame-decoder-compact-result

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@nx-cloud

nx-cloudBot commented Aug 6, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

View your CI Pipeline Execution ↗ for commit b775949

CommandStatusDurationResult
nx affected --targets=test:eslint,test:unit,tes...✅ Succeeded50m 9sView ↗
nx run-many --target=build --exclude=examples/*...✅ Succeeded1m 53sView ↗

☁️ Nx Cloud last updated this comment at 2026-08-07 13:08:41 UTC

@github-actions

github-actionsBot commented Aug 6, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

🚀 Changeset Version Preview

1 package(s) bumped directly, 13 bumped as dependents.

🟩 Patch bumps

PackageVersionReason
@tanstack/start-client-core1.170.18 → 1.170.19Changeset
@tanstack/react-start1.168.39 → 1.168.40Dependent
@tanstack/react-start-client1.168.20 → 1.168.21Dependent
@tanstack/react-start-rsc0.1.38 → 0.1.39Dependent
@tanstack/react-start-server1.167.27 → 1.167.28Dependent
@tanstack/solid-start1.168.38 → 1.168.39Dependent
@tanstack/solid-start-client1.168.20 → 1.168.21Dependent
@tanstack/solid-start-server1.167.27 → 1.167.28Dependent
@tanstack/start-plugin-core1.171.30 → 1.171.31Dependent
@tanstack/start-server-core1.169.22 → 1.169.23Dependent
@tanstack/start-static-server-functions1.167.23 → 1.167.24Dependent
@tanstack/vue-start1.168.37 → 1.168.38Dependent
@tanstack/vue-start-client1.167.23 → 1.167.24Dependent
@tanstack/vue-start-server1.167.27 → 1.167.28Dependent

@github-actions

github-actionsBot commented Aug 6, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

Bundle Size Benchmarks

  • Commit: 27a6a68ba55a
  • Measured at: 2026-08-07T12:19:36.068Z
  • Baseline source: history:ea3a665d81cb
  • Dashboard: bundle-size history

The following scenarios have bundle-size changes compared with the baseline:

ScenarioCurrent (gzip)Delta vs baselineInitial gzipRawBrotliTrend
react-start.minimal100.39 KiB-8 B (-0.01%)100.25 KiB310.86 KiB87.16 KiB██▂▂▂▂▁▁▁▁▁▁
react-start.deferred-hydration101.13 KiB-9 B (-0.01%)100.28 KiB312.23 KiB87.87 KiB██▂▂▂▂▁▁▁▁▁▁
react-start.full103.75 KiB-3 B (-0.00%)103.61 KiB320.81 KiB90.16 KiB██▂▂▂▂▁▁▁▁▁▁
react-start.rsbuild.minimal99.98 KiB-8 B (-0.01%)99.81 KiB315.35 KiB86.25 KiB▁▁████▃▃▃▄▄▄
react-start.rsbuild.minimal-iife100.39 KiB-9 B (-0.01%)100.22 KiB316.28 KiB86.60 KiB▁▁████▃▃▃▄▄▄
react-start.rsbuild.full103.28 KiB-11 B (-0.01%)103.11 KiB325.44 KiB88.92 KiB▁▁██▇█▃▃▃▄▄▃
solid-start.minimal47.96 KiB-5 B (-0.01%)47.83 KiB140.63 KiB42.69 KiB██▂▂▂▂▁▁▁▁▁▁
solid-start.deferred-hydration51.23 KiB-4 B (-0.01%)47.89 KiB148.67 KiB45.66 KiB██▂▂▂▂▁▁▁▁▁▁
solid-start.full53.23 KiB-8 B (-0.01%)53.11 KiB156.35 KiB47.32 KiB██▂▂▂▂▁▁▁▁▁▁
vue-start.minimal68.64 KiB-5 B (-0.01%)68.51 KiB193.40 KiB61.10 KiB██▃▃▂▂▁▁▁▁▁▁
vue-start.full72.65 KiB-4 B (-0.01%)72.52 KiB205.90 KiB64.57 KiB██▂▂▂▂▁▁▁▁▁▁

Current gzip tracks all emitted client JS chunks. Initial gzip tracks only the entry/import graph. Trend sparkline is historical current gzip ending with this PR measurement; lower is better.

@pkg-pr-new

pkg-pr-newBot commented Aug 6, 2026•
edited
Loading

Copy link
Copy Markdown
More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/@tanstack/arktype-adapter@7978

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@7978

@tanstack/eslint-plugin-start

npm i https://pkg.pr.new/@tanstack/eslint-plugin-start@7978

@tanstack/history

npm i https://pkg.pr.new/@tanstack/history@7978

@tanstack/nitro-v2-vite-plugin

npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@7978

@tanstack/react-router

npm i https://pkg.pr.new/@tanstack/react-router@7978

@tanstack/react-router-devtools

npm i https://pkg.pr.new/@tanstack/react-router-devtools@7978

@tanstack/react-router-ssr-query

npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@7978

@tanstack/react-start

npm i https://pkg.pr.new/@tanstack/react-start@7978

@tanstack/react-start-client

npm i https://pkg.pr.new/@tanstack/react-start-client@7978

@tanstack/react-start-rsc

npm i https://pkg.pr.new/@tanstack/react-start-rsc@7978

@tanstack/react-start-server

npm i https://pkg.pr.new/@tanstack/react-start-server@7978

@tanstack/router-cli

npm i https://pkg.pr.new/@tanstack/router-cli@7978

@tanstack/router-core

npm i https://pkg.pr.new/@tanstack/router-core@7978

@tanstack/router-devtools

npm i https://pkg.pr.new/@tanstack/router-devtools@7978

@tanstack/router-devtools-core

npm i https://pkg.pr.new/@tanstack/router-devtools-core@7978

@tanstack/router-generator

npm i https://pkg.pr.new/@tanstack/router-generator@7978

@tanstack/router-plugin

npm i https://pkg.pr.new/@tanstack/router-plugin@7978

@tanstack/router-ssr-query-core

npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@7978

@tanstack/router-utils

npm i https://pkg.pr.new/@tanstack/router-utils@7978

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/@tanstack/router-vite-plugin@7978

@tanstack/solid-router

npm i https://pkg.pr.new/@tanstack/solid-router@7978

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/@tanstack/solid-router-devtools@7978

@tanstack/solid-router-ssr-query

npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@7978

@tanstack/solid-start

npm i https://pkg.pr.new/@tanstack/solid-start@7978

@tanstack/solid-start-client

npm i https://pkg.pr.new/@tanstack/solid-start-client@7978

@tanstack/solid-start-server

npm i https://pkg.pr.new/@tanstack/solid-start-server@7978

@tanstack/start-client-core

npm i https://pkg.pr.new/@tanstack/start-client-core@7978

@tanstack/start-fn-stubs

npm i https://pkg.pr.new/@tanstack/start-fn-stubs@7978

@tanstack/start-plugin-core

npm i https://pkg.pr.new/@tanstack/start-plugin-core@7978

@tanstack/start-server-core

npm i https://pkg.pr.new/@tanstack/start-server-core@7978

@tanstack/start-static-server-functions

npm i https://pkg.pr.new/@tanstack/start-static-server-functions@7978

@tanstack/start-storage-context

npm i https://pkg.pr.new/@tanstack/start-storage-context@7978

@tanstack/valibot-adapter

npm i https://pkg.pr.new/@tanstack/valibot-adapter@7978

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/@tanstack/virtual-file-routes@7978

@tanstack/vue-router

npm i https://pkg.pr.new/@tanstack/vue-router@7978

@tanstack/vue-router-devtools

npm i https://pkg.pr.new/@tanstack/vue-router-devtools@7978

@tanstack/vue-router-ssr-query

npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@7978

@tanstack/vue-start

npm i https://pkg.pr.new/@tanstack/vue-start@7978

@tanstack/vue-start-client

npm i https://pkg.pr.new/@tanstack/vue-start-client@7978

@tanstack/vue-start-server

npm i https://pkg.pr.new/@tanstack/vue-start-server@7978

@tanstack/zod-adapter

npm i https://pkg.pr.new/@tanstack/zod-adapter@7978

commit: b775949

@codspeed-hq

codspeed-hqBot commented Aug 6, 2026•
edited
Loading

Copy link
Copy Markdown

Merging this PR will regress 5 benchmarks

⚠️Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 6 improved benchmarks
❌ 5 regressed benchmarks
✅ 169 untouched benchmarks

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

ModeBenchmarkBASEHEADEfficiency
❌Memorymem server error-paths not-found (vue)319.4 KB2,015.4 KB-84.15%
❌Memorymem client navigation-churn (vue)1.2 MB1.3 MB-5.56%
❌Memorymem server error-paths not-found (react)255.6 KB266.3 KB-4.02%
❌Memorymem server server-fn-churn (react)265 KB276.1 KB-4.02%
❌Memorymem client unique-location-churn (react)665.1 KB692.3 KB-3.92%
⚡Memorymem server server-fn-churn (vue)4,529.1 KB263.2 KB×17
⚡Memorymem server error-paths unmatched (solid)1,807.2 KB436.3 KB×4.1
⚡Memorymem server error-paths redirect (solid)523.7 KB277.8 KB+88.52%
⚡Memorymem server error-paths redirect (vue)370 KB294.2 KB+25.76%
⚡Simulationclient-history navigation loop (react)39.7 ms35.8 ms+10.95%
⚡Simulationssr request loop (solid)155.4 ms145.6 ms+6.75%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.

Comparing codex/frame-decoder-compact-result (b775949) with main (995bd97)

Open in CodSpeed

nx-cloud[bot]
nx-cloudBot reviewed Aug 6, 2026
View reviewed changes

@nx-cloudnx-cloudBot left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

At least one additional CI pipeline execution has run since the conclusion below was written and it may no longer be applicable.

Nx Cloud has identified a possible root cause for your failed CI:

We classified this failure as an environment issue rather than a code change. The test failed with EADDRINUSE on port 32915, meaning another process had already claimed that port before the test's external server could start — unrelated to the PR's internal key renames in @tanstack/start-client-core. No port configuration or test infrastructure was modified by this PR.

No code changes were suggested for this issue.

Trigger a rerun:

Rerun CI

Nx Cloud View detailed reasoning on Nx Cloud ↗


🎓 Learn more about Self-Healing CI on nx.dev

@Sheraff
Sheraff marked this pull request as ready for review August 7, 2026 10:00
@Sheraff
Sheraff merged commit 2fbc99f into mainAug 7, 2026
25 of 26 checks passed
@Sheraff
Sheraff deleted the codex/frame-decoder-compact-result branch August 7, 2026 13:18
@github-actionsgithub-actionsBot mentioned this pull request Aug 7, 2026
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nx-cloudnx-cloud[bot]nx-cloud[bot] left review comments

Assignees

No one assigned

Labels

package: start-client-core

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Sheraff
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
perf(start-client-core): compact private frame decoder result keys - #7978
Merged
Sheraff merged 6 commits into
mainfrom 
codex/frame-decoder-compact-result
Aug 7, 2026
Merged
perf(start-client-core): compact private frame decoder result keys#7978
Sheraff merged 6 commits into
mainfrom 
codex/frame-decoder-compact-result
Conversation
@Sheraff
@SheraffSheraff
commented
Aug 6, 2026•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Collaborator
What changed
  • Rename the private createFrameDecoder result keys from getOrCreateStream/jsonChunks to getStream/chunks.
  • Update the sole production consumer and direct decoder tests in lockstep.
  • Keep the existing two-property object shape, function/stream identities, property order, and public exports unchanged.
Bundle impact
Across the full 17-scenario matrix, all 11 Start scenarios improve by 4–12 B gzip and 24 B raw; all six router-only scenarios are byte-identical. Both renames also improve independently on react-start.minimal: getStream saves 6 B gzip / 16 B raw, and chunks saves 1 B gzip / 8 B raw. Brotli is mixed and documented in the evidence report.
Validation
  • start-client-core frame-decoder unit suite: 19 passed
  • TypeScript 5.6, 5.7, 5.8, 5.9, 6.0, and 7.0 matrices passed
  • ESLint passed with no new errors
  • React Start Vite/SSR client-RPC RawStream e2e: 6 passed
  • Full 17-scenario bundle matrix passed
  • Runtime allocation/destructure benchmark found no directional change
  • Five independent bundle, runtime, API, integration, and codegen reviews approved
Detailed artifacts and attribution are recorded in RESULT-optimization-frame-decoder-compact-result.md.
Summary by CodeRabbit
  • Refactor
    • Updated framed response handling with clearer stream and chunk naming.
    • Improved consistency in stream decoding interfaces without changing behavior.
    • Reduced the size of private frame decoder result keys.
  • Tests
    • Updated decoder coverage to use the revised stream and chunk terminology.
    • Existing test behavior and assertions remain unchanged.
@coderabbitai
coderabbitaiBot
commented
Aug 6, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Review Change Stack
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 045851a8-70eb-4673-b830-e1c3eeeb3482
📥 Commits
Reviewing files that changed from the base of the PR and between 7b62859 and b775949.
📒 Files selected for processing (1)
  • .changeset/kind-ghosts-win.md
📝 Walkthrough
Walkthrough
The frame decoder result API now exposes getStream and chunks. Server framed-response handling and decoder tests use the renamed properties. A Changeset records a patch release.
Changes
Frame decoder naming update
Layer / File(s)Summary
Rename decoder result properties
packages/start-client-core/src/client-rpc/frame-decoder.ts		FrameDecoderResult and createFrameDecoder now expose getStream and chunks.
Update response handling and tests
packages/start-client-core/src/client-rpc/serverFnFetcher.ts, packages/start-client-core/tests/frame-decoder.test.ts		Framed-response handling and decoder tests now consume the renamed properties. Aliases preserve existing local test names.
Record patch release
.changeset/kind-ghosts-win.md		The Changeset records a patch release for @tanstack/start-client-core.
Estimated code review effort: 1 (Trivial) | ~5 minutes
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly and concisely describes the main change: compacting private frame decoder result keys.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  •  Create PR with unit tests
  •  Commit unit tests in branch codex/frame-decoder-compact-result
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands.
@nx-cloud
nx-cloudBot
commented
Aug 6, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
View your CI Pipeline Execution ↗ for commit b775949
CommandStatusDurationResult
nx affected --targets=test:eslint,test:unit,tes...✅ Succeeded50m 9sView ↗
nx run-many --target=build --exclude=examples/*...✅ Succeeded1m 53sView ↗
☁️ Nx Cloud last updated this comment at 2026-08-07 13:08:41 UTC
@github-actions
github-actionsBot
commented
Aug 6, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
🚀 Changeset Version Preview
1 package(s) bumped directly, 13 bumped as dependents.
🟩 Patch bumps
PackageVersionReason
@tanstack/start-client-core1.170.18 → 1.170.19Changeset
@tanstack/react-start1.168.39 → 1.168.40Dependent
@tanstack/react-start-client1.168.20 → 1.168.21Dependent
@tanstack/react-start-rsc0.1.38 → 0.1.39Dependent
@tanstack/react-start-server1.167.27 → 1.167.28Dependent
@tanstack/solid-start1.168.38 → 1.168.39Dependent
@tanstack/solid-start-client1.168.20 → 1.168.21Dependent
@tanstack/solid-start-server1.167.27 → 1.167.28Dependent
@tanstack/start-plugin-core1.171.30 → 1.171.31Dependent
@tanstack/start-server-core1.169.22 → 1.169.23Dependent
@tanstack/start-static-server-functions1.167.23 → 1.167.24Dependent
@tanstack/vue-start1.168.37 → 1.168.38Dependent
@tanstack/vue-start-client1.167.23 → 1.167.24Dependent
@tanstack/vue-start-server1.167.27 → 1.167.28Dependent
@github-actions
github-actionsBot
commented
Aug 6, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Bundle Size Benchmarks
  • Commit: 27a6a68ba55a
  • Measured at: 2026-08-07T12:19:36.068Z
  • Baseline source: history:ea3a665d81cb
  • Dashboard: bundle-size history
The following scenarios have bundle-size changes compared with the baseline:
ScenarioCurrent (gzip)Delta vs baselineInitial gzipRawBrotliTrend
react-start.minimal100.39 KiB-8 B (-0.01%)100.25 KiB310.86 KiB87.16 KiB██▂▂▂▂▁▁▁▁▁▁
react-start.deferred-hydration101.13 KiB-9 B (-0.01%)100.28 KiB312.23 KiB87.87 KiB██▂▂▂▂▁▁▁▁▁▁
react-start.full103.75 KiB-3 B (-0.00%)103.61 KiB320.81 KiB90.16 KiB██▂▂▂▂▁▁▁▁▁▁
react-start.rsbuild.minimal99.98 KiB-8 B (-0.01%)99.81 KiB315.35 KiB86.25 KiB▁▁████▃▃▃▄▄▄
react-start.rsbuild.minimal-iife100.39 KiB-9 B (-0.01%)100.22 KiB316.28 KiB86.60 KiB▁▁████▃▃▃▄▄▄
react-start.rsbuild.full103.28 KiB-11 B (-0.01%)103.11 KiB325.44 KiB88.92 KiB▁▁██▇█▃▃▃▄▄▃
solid-start.minimal47.96 KiB-5 B (-0.01%)47.83 KiB140.63 KiB42.69 KiB██▂▂▂▂▁▁▁▁▁▁
solid-start.deferred-hydration51.23 KiB-4 B (-0.01%)47.89 KiB148.67 KiB45.66 KiB██▂▂▂▂▁▁▁▁▁▁
solid-start.full53.23 KiB-8 B (-0.01%)53.11 KiB156.35 KiB47.32 KiB██▂▂▂▂▁▁▁▁▁▁
vue-start.minimal68.64 KiB-5 B (-0.01%)68.51 KiB193.40 KiB61.10 KiB██▃▃▂▂▁▁▁▁▁▁
vue-start.full72.65 KiB-4 B (-0.01%)72.52 KiB205.90 KiB64.57 KiB██▂▂▂▂▁▁▁▁▁▁
Current gzip tracks all emitted client JS chunks. Initial gzip tracks only the entry/import graph. Trend sparkline is historical current gzip ending with this PR measurement; lower is better.
@pkg-pr-new
pkg-pr-newBot
commented
Aug 6, 2026•

edited

Loading

Copy link


Copy Markdown

More templates
@tanstack/arktype-adapter
npm i https://pkg.pr.new/@tanstack/arktype-adapter@7978

@tanstack/eslint-plugin-router
npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@7978

@tanstack/eslint-plugin-start
npm i https://pkg.pr.new/@tanstack/eslint-plugin-start@7978

@tanstack/history
npm i https://pkg.pr.new/@tanstack/history@7978

@tanstack/nitro-v2-vite-plugin
npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@7978

@tanstack/react-router
npm i https://pkg.pr.new/@tanstack/react-router@7978

@tanstack/react-router-devtools
npm i https://pkg.pr.new/@tanstack/react-router-devtools@7978

@tanstack/react-router-ssr-query
npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@7978

@tanstack/react-start
npm i https://pkg.pr.new/@tanstack/react-start@7978

@tanstack/react-start-client
npm i https://pkg.pr.new/@tanstack/react-start-client@7978

@tanstack/react-start-rsc
npm i https://pkg.pr.new/@tanstack/react-start-rsc@7978

@tanstack/react-start-server
npm i https://pkg.pr.new/@tanstack/react-start-server@7978

@tanstack/router-cli
npm i https://pkg.pr.new/@tanstack/router-cli@7978

@tanstack/router-core
npm i https://pkg.pr.new/@tanstack/router-core@7978

@tanstack/router-devtools
npm i https://pkg.pr.new/@tanstack/router-devtools@7978

@tanstack/router-devtools-core
npm i https://pkg.pr.new/@tanstack/router-devtools-core@7978

@tanstack/router-generator
npm i https://pkg.pr.new/@tanstack/router-generator@7978

@tanstack/router-plugin
npm i https://pkg.pr.new/@tanstack/router-plugin@7978

@tanstack/router-ssr-query-core
npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@7978

@tanstack/router-utils
npm i https://pkg.pr.new/@tanstack/router-utils@7978

@tanstack/router-vite-plugin
npm i https://pkg.pr.new/@tanstack/router-vite-plugin@7978

@tanstack/solid-router
npm i https://pkg.pr.new/@tanstack/solid-router@7978

@tanstack/solid-router-devtools
npm i https://pkg.pr.new/@tanstack/solid-router-devtools@7978

@tanstack/solid-router-ssr-query
npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@7978

@tanstack/solid-start
npm i https://pkg.pr.new/@tanstack/solid-start@7978

@tanstack/solid-start-client
npm i https://pkg.pr.new/@tanstack/solid-start-client@7978

@tanstack/solid-start-server
npm i https://pkg.pr.new/@tanstack/solid-start-server@7978

@tanstack/start-client-core
npm i https://pkg.pr.new/@tanstack/start-client-core@7978

@tanstack/start-fn-stubs
npm i https://pkg.pr.new/@tanstack/start-fn-stubs@7978

@tanstack/start-plugin-core
npm i https://pkg.pr.new/@tanstack/start-plugin-core@7978

@tanstack/start-server-core
npm i https://pkg.pr.new/@tanstack/start-server-core@7978

@tanstack/start-static-server-functions
npm i https://pkg.pr.new/@tanstack/start-static-server-functions@7978

@tanstack/start-storage-context
npm i https://pkg.pr.new/@tanstack/start-storage-context@7978

@tanstack/valibot-adapter
npm i https://pkg.pr.new/@tanstack/valibot-adapter@7978

@tanstack/virtual-file-routes
npm i https://pkg.pr.new/@tanstack/virtual-file-routes@7978

@tanstack/vue-router
npm i https://pkg.pr.new/@tanstack/vue-router@7978

@tanstack/vue-router-devtools
npm i https://pkg.pr.new/@tanstack/vue-router-devtools@7978

@tanstack/vue-router-ssr-query
npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@7978

@tanstack/vue-start
npm i https://pkg.pr.new/@tanstack/vue-start@7978

@tanstack/vue-start-client
npm i https://pkg.pr.new/@tanstack/vue-start-client@7978

@tanstack/vue-start-server
npm i https://pkg.pr.new/@tanstack/vue-start-server@7978

@tanstack/zod-adapter
npm i https://pkg.pr.new/@tanstack/zod-adapter@7978

commit: b775949
@codspeed-hq
codspeed-hqBot
commented
Aug 6, 2026•

edited

Loading

Copy link


Copy Markdown

Merging this PR will regress 5 benchmarks
⚠️Different runtime environments detected
Some benchmarks with significant performance changes were compared across different runtime environments,

which may affect the accuracy of the results.
Open the report in CodSpeed to investigate
⚡ 6 improved benchmarks
❌ 5 regressed benchmarks
✅ 169 untouched benchmarks
Warning
Please fix the performance issues or acknowledge them on CodSpeed.
Performance Changes
ModeBenchmarkBASEHEADEfficiency
❌Memorymem server error-paths not-found (vue)319.4 KB2,015.4 KB-84.15%
❌Memorymem client navigation-churn (vue)1.2 MB1.3 MB-5.56%
❌Memorymem server error-paths not-found (react)255.6 KB266.3 KB-4.02%
❌Memorymem server server-fn-churn (react)265 KB276.1 KB-4.02%
❌Memorymem client unique-location-churn (react)665.1 KB692.3 KB-3.92%
⚡Memorymem server server-fn-churn (vue)4,529.1 KB263.2 KB×17
⚡Memorymem server error-paths unmatched (solid)1,807.2 KB436.3 KB×4.1
⚡Memorymem server error-paths redirect (solid)523.7 KB277.8 KB+88.52%
⚡Memorymem server error-paths redirect (vue)370 KB294.2 KB+25.76%
⚡Simulationclient-history navigation loop (react)39.7 ms35.8 ms+10.95%
⚡Simulationssr request loop (solid)155.4 ms145.6 ms+6.75%
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing codex/frame-decoder-compact-result (b775949) with main (995bd97)
Open in CodSpeed
nx-cloud[bot]
nx-cloudBot
reviewed
Aug 6, 2026
View reviewed changes
@nx-cloudnx-cloudBot
left a comment
•

edited

Loading

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important
At least one additional CI pipeline execution has run since the conclusion below was written and it may no longer be applicable.
Nx Cloud has identified a possible root cause for your failed CI:
We classified this failure as an environment issue rather than a code change. The test failed with EADDRINUSE on port 32915, meaning another process had already claimed that port before the test's external server could start — unrelated to the PR's internal key renames in @tanstack/start-client-core. No port configuration or test infrastructure was modified by this PR.
No code changes were suggested for this issue.
Trigger a rerun:
Rerun CI
Nx Cloud View detailed reasoning on Nx Cloud ↗

🎓 Learn more about Self-Healing CI on nx.dev
@Sheraff
Sheraff
marked this pull request as ready for review
August 7, 2026 10:00
@Sheraff
Sheraff
merged commit 2fbc99f
into
mainAug 7, 2026

25 of 26 checks passed

@Sheraff
Sheraff
deleted the

codex/frame-decoder-compact-result

branch
August 7, 2026 13:18
@github-actionsgithub-actionsBot
mentioned this pull request
Aug 7, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@nx-cloudnx-cloud[bot]nx-cloud[bot] left review comments

Assignees


No one assigned


Labels

package: start-client-core

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@Sheraff

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
perf(start-client-core): compact private frame decoder result keys - #7978
Merged
Sheraff merged 6 commits into
mainfrom 
codex/frame-decoder-compact-result
Aug 7, 2026
Merged
perf(start-client-core): compact private frame decoder result keys#7978
Sheraff merged 6 commits into
mainfrom 
codex/frame-decoder-compact-result
Conversation
@Sheraff
@SheraffSheraff
commented
Aug 6, 2026•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Collaborator
What changed
  • Rename the private createFrameDecoder result keys from getOrCreateStream/jsonChunks to getStream/chunks.
  • Update the sole production consumer and direct decoder tests in lockstep.
  • Keep the existing two-property object shape, function/stream identities, property order, and public exports unchanged.
Bundle impact
Across the full 17-scenario matrix, all 11 Start scenarios improve by 4–12 B gzip and 24 B raw; all six router-only scenarios are byte-identical. Both renames also improve independently on react-start.minimal: getStream saves 6 B gzip / 16 B raw, and chunks saves 1 B gzip / 8 B raw. Brotli is mixed and documented in the evidence report.
Validation
  • start-client-core frame-decoder unit suite: 19 passed
  • TypeScript 5.6, 5.7, 5.8, 5.9, 6.0, and 7.0 matrices passed
  • ESLint passed with no new errors
  • React Start Vite/SSR client-RPC RawStream e2e: 6 passed
  • Full 17-scenario bundle matrix passed
  • Runtime allocation/destructure benchmark found no directional change
  • Five independent bundle, runtime, API, integration, and codegen reviews approved
Detailed artifacts and attribution are recorded in RESULT-optimization-frame-decoder-compact-result.md.
Summary by CodeRabbit
  • Refactor
    • Updated framed response handling with clearer stream and chunk naming.
    • Improved consistency in stream decoding interfaces without changing behavior.
    • Reduced the size of private frame decoder result keys.
  • Tests
    • Updated decoder coverage to use the revised stream and chunk terminology.
    • Existing test behavior and assertions remain unchanged.
@coderabbitai
coderabbitaiBot
commented
Aug 6, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Review Change Stack
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 045851a8-70eb-4673-b830-e1c3eeeb3482
📥 Commits
Reviewing files that changed from the base of the PR and between 7b62859 and b775949.
📒 Files selected for processing (1)
  • .changeset/kind-ghosts-win.md
📝 Walkthrough
Walkthrough
The frame decoder result API now exposes getStream and chunks. Server framed-response handling and decoder tests use the renamed properties. A Changeset records a patch release.
Changes
Frame decoder naming update
Layer / File(s)Summary
Rename decoder result properties
packages/start-client-core/src/client-rpc/frame-decoder.ts		FrameDecoderResult and createFrameDecoder now expose getStream and chunks.
Update response handling and tests
packages/start-client-core/src/client-rpc/serverFnFetcher.ts, packages/start-client-core/tests/frame-decoder.test.ts		Framed-response handling and decoder tests now consume the renamed properties. Aliases preserve existing local test names.
Record patch release
.changeset/kind-ghosts-win.md		The Changeset records a patch release for @tanstack/start-client-core.
Estimated code review effort: 1 (Trivial) | ~5 minutes
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly and concisely describes the main change: compacting private frame decoder result keys.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  •  Create PR with unit tests
  •  Commit unit tests in branch codex/frame-decoder-compact-result
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands.
@nx-cloud
nx-cloudBot
commented
Aug 6, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
View your CI Pipeline Execution ↗ for commit b775949
CommandStatusDurationResult
nx affected --targets=test:eslint,test:unit,tes...✅ Succeeded50m 9sView ↗
nx run-many --target=build --exclude=examples/*...✅ Succeeded1m 53sView ↗
☁️ Nx Cloud last updated this comment at 2026-08-07 13:08:41 UTC
@github-actions
github-actionsBot
commented
Aug 6, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
🚀 Changeset Version Preview
1 package(s) bumped directly, 13 bumped as dependents.
🟩 Patch bumps
PackageVersionReason
@tanstack/start-client-core1.170.18 → 1.170.19Changeset
@tanstack/react-start1.168.39 → 1.168.40Dependent
@tanstack/react-start-client1.168.20 → 1.168.21Dependent
@tanstack/react-start-rsc0.1.38 → 0.1.39Dependent
@tanstack/react-start-server1.167.27 → 1.167.28Dependent
@tanstack/solid-start1.168.38 → 1.168.39Dependent
@tanstack/solid-start-client1.168.20 → 1.168.21Dependent
@tanstack/solid-start-server1.167.27 → 1.167.28Dependent
@tanstack/start-plugin-core1.171.30 → 1.171.31Dependent
@tanstack/start-server-core1.169.22 → 1.169.23Dependent
@tanstack/start-static-server-functions1.167.23 → 1.167.24Dependent
@tanstack/vue-start1.168.37 → 1.168.38Dependent
@tanstack/vue-start-client1.167.23 → 1.167.24Dependent
@tanstack/vue-start-server1.167.27 → 1.167.28Dependent
@github-actions
github-actionsBot
commented
Aug 6, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Bundle Size Benchmarks
  • Commit: 27a6a68ba55a
  • Measured at: 2026-08-07T12:19:36.068Z
  • Baseline source: history:ea3a665d81cb
  • Dashboard: bundle-size history
The following scenarios have bundle-size changes compared with the baseline:
ScenarioCurrent (gzip)Delta vs baselineInitial gzipRawBrotliTrend
react-start.minimal100.39 KiB-8 B (-0.01%)100.25 KiB310.86 KiB87.16 KiB██▂▂▂▂▁▁▁▁▁▁
react-start.deferred-hydration101.13 KiB-9 B (-0.01%)100.28 KiB312.23 KiB87.87 KiB██▂▂▂▂▁▁▁▁▁▁
react-start.full103.75 KiB-3 B (-0.00%)103.61 KiB320.81 KiB90.16 KiB██▂▂▂▂▁▁▁▁▁▁
react-start.rsbuild.minimal99.98 KiB-8 B (-0.01%)99.81 KiB315.35 KiB86.25 KiB▁▁████▃▃▃▄▄▄
react-start.rsbuild.minimal-iife100.39 KiB-9 B (-0.01%)100.22 KiB316.28 KiB86.60 KiB▁▁████▃▃▃▄▄▄
react-start.rsbuild.full103.28 KiB-11 B (-0.01%)103.11 KiB325.44 KiB88.92 KiB▁▁██▇█▃▃▃▄▄▃
solid-start.minimal47.96 KiB-5 B (-0.01%)47.83 KiB140.63 KiB42.69 KiB██▂▂▂▂▁▁▁▁▁▁
solid-start.deferred-hydration51.23 KiB-4 B (-0.01%)47.89 KiB148.67 KiB45.66 KiB██▂▂▂▂▁▁▁▁▁▁
solid-start.full53.23 KiB-8 B (-0.01%)53.11 KiB156.35 KiB47.32 KiB██▂▂▂▂▁▁▁▁▁▁
vue-start.minimal68.64 KiB-5 B (-0.01%)68.51 KiB193.40 KiB61.10 KiB██▃▃▂▂▁▁▁▁▁▁
vue-start.full72.65 KiB-4 B (-0.01%)72.52 KiB205.90 KiB64.57 KiB██▂▂▂▂▁▁▁▁▁▁
Current gzip tracks all emitted client JS chunks. Initial gzip tracks only the entry/import graph. Trend sparkline is historical current gzip ending with this PR measurement; lower is better.
@pkg-pr-new
pkg-pr-newBot
commented
Aug 6, 2026•

edited

Loading

Copy link


Copy Markdown

More templates
@tanstack/arktype-adapter
npm i https://pkg.pr.new/@tanstack/arktype-adapter@7978

@tanstack/eslint-plugin-router
npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@7978

@tanstack/eslint-plugin-start
npm i https://pkg.pr.new/@tanstack/eslint-plugin-start@7978

@tanstack/history
npm i https://pkg.pr.new/@tanstack/history@7978

@tanstack/nitro-v2-vite-plugin
npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@7978

@tanstack/react-router
npm i https://pkg.pr.new/@tanstack/react-router@7978

@tanstack/react-router-devtools
npm i https://pkg.pr.new/@tanstack/react-router-devtools@7978

@tanstack/react-router-ssr-query
npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@7978

@tanstack/react-start
npm i https://pkg.pr.new/@tanstack/react-start@7978

@tanstack/react-start-client
npm i https://pkg.pr.new/@tanstack/react-start-client@7978

@tanstack/react-start-rsc
npm i https://pkg.pr.new/@tanstack/react-start-rsc@7978

@tanstack/react-start-server
npm i https://pkg.pr.new/@tanstack/react-start-server@7978

@tanstack/router-cli
npm i https://pkg.pr.new/@tanstack/router-cli@7978

@tanstack/router-core
npm i https://pkg.pr.new/@tanstack/router-core@7978

@tanstack/router-devtools
npm i https://pkg.pr.new/@tanstack/router-devtools@7978

@tanstack/router-devtools-core
npm i https://pkg.pr.new/@tanstack/router-devtools-core@7978

@tanstack/router-generator
npm i https://pkg.pr.new/@tanstack/router-generator@7978

@tanstack/router-plugin
npm i https://pkg.pr.new/@tanstack/router-plugin@7978

@tanstack/router-ssr-query-core
npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@7978

@tanstack/router-utils
npm i https://pkg.pr.new/@tanstack/router-utils@7978

@tanstack/router-vite-plugin
npm i https://pkg.pr.new/@tanstack/router-vite-plugin@7978

@tanstack/solid-router
npm i https://pkg.pr.new/@tanstack/solid-router@7978

@tanstack/solid-router-devtools
npm i https://pkg.pr.new/@tanstack/solid-router-devtools@7978

@tanstack/solid-router-ssr-query
npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@7978

@tanstack/solid-start
npm i https://pkg.pr.new/@tanstack/solid-start@7978

@tanstack/solid-start-client
npm i https://pkg.pr.new/@tanstack/solid-start-client@7978

@tanstack/solid-start-server
npm i https://pkg.pr.new/@tanstack/solid-start-server@7978

@tanstack/start-client-core
npm i https://pkg.pr.new/@tanstack/start-client-core@7978

@tanstack/start-fn-stubs
npm i https://pkg.pr.new/@tanstack/start-fn-stubs@7978

@tanstack/start-plugin-core
npm i https://pkg.pr.new/@tanstack/start-plugin-core@7978

@tanstack/start-server-core
npm i https://pkg.pr.new/@tanstack/start-server-core@7978

@tanstack/start-static-server-functions
npm i https://pkg.pr.new/@tanstack/start-static-server-functions@7978

@tanstack/start-storage-context
npm i https://pkg.pr.new/@tanstack/start-storage-context@7978

@tanstack/valibot-adapter
npm i https://pkg.pr.new/@tanstack/valibot-adapter@7978

@tanstack/virtual-file-routes
npm i https://pkg.pr.new/@tanstack/virtual-file-routes@7978

@tanstack/vue-router
npm i https://pkg.pr.new/@tanstack/vue-router@7978

@tanstack/vue-router-devtools
npm i https://pkg.pr.new/@tanstack/vue-router-devtools@7978

@tanstack/vue-router-ssr-query
npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@7978

@tanstack/vue-start
npm i https://pkg.pr.new/@tanstack/vue-start@7978

@tanstack/vue-start-client
npm i https://pkg.pr.new/@tanstack/vue-start-client@7978

@tanstack/vue-start-server
npm i https://pkg.pr.new/@tanstack/vue-start-server@7978

@tanstack/zod-adapter
npm i https://pkg.pr.new/@tanstack/zod-adapter@7978

commit: b775949
@codspeed-hq
codspeed-hqBot
commented
Aug 6, 2026•

edited

Loading

Copy link


Copy Markdown

Merging this PR will regress 5 benchmarks
⚠️Different runtime environments detected
Some benchmarks with significant performance changes were compared across different runtime environments,

which may affect the accuracy of the results.
Open the report in CodSpeed to investigate
⚡ 6 improved benchmarks
❌ 5 regressed benchmarks
✅ 169 untouched benchmarks
Warning
Please fix the performance issues or acknowledge them on CodSpeed.
Performance Changes
ModeBenchmarkBASEHEADEfficiency
❌Memorymem server error-paths not-found (vue)319.4 KB2,015.4 KB-84.15%
❌Memorymem client navigation-churn (vue)1.2 MB1.3 MB-5.56%
❌Memorymem server error-paths not-found (react)255.6 KB266.3 KB-4.02%
❌Memorymem server server-fn-churn (react)265 KB276.1 KB-4.02%
❌Memorymem client unique-location-churn (react)665.1 KB692.3 KB-3.92%
⚡Memorymem server server-fn-churn (vue)4,529.1 KB263.2 KB×17
⚡Memorymem server error-paths unmatched (solid)1,807.2 KB436.3 KB×4.1
⚡Memorymem server error-paths redirect (solid)523.7 KB277.8 KB+88.52%
⚡Memorymem server error-paths redirect (vue)370 KB294.2 KB+25.76%
⚡Simulationclient-history navigation loop (react)39.7 ms35.8 ms+10.95%
⚡Simulationssr request loop (solid)155.4 ms145.6 ms+6.75%
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing codex/frame-decoder-compact-result (b775949) with main (995bd97)
Open in CodSpeed
nx-cloud[bot]
nx-cloudBot
reviewed
Aug 6, 2026
View reviewed changes
@nx-cloudnx-cloudBot
left a comment
•

edited

Loading

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important
At least one additional CI pipeline execution has run since the conclusion below was written and it may no longer be applicable.
Nx Cloud has identified a possible root cause for your failed CI:
We classified this failure as an environment issue rather than a code change. The test failed with EADDRINUSE on port 32915, meaning another process had already claimed that port before the test's external server could start — unrelated to the PR's internal key renames in @tanstack/start-client-core. No port configuration or test infrastructure was modified by this PR.
No code changes were suggested for this issue.
Trigger a rerun:
Rerun CI
Nx Cloud View detailed reasoning on Nx Cloud ↗

🎓 Learn more about Self-Healing CI on nx.dev
@Sheraff
Sheraff
marked this pull request as ready for review
August 7, 2026 10:00
@Sheraff
Sheraff
merged commit 2fbc99f
into
mainAug 7, 2026

25 of 26 checks passed

@Sheraff
Sheraff
deleted the

codex/frame-decoder-compact-result

branch
August 7, 2026 13:18
@github-actionsgithub-actionsBot
mentioned this pull request
Aug 7, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@nx-cloudnx-cloud[bot]nx-cloud[bot] left review comments

Assignees


No one assigned


Labels

package: start-client-core

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@Sheraff

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
perf(start-client-core): compact private frame decoder result keys - #7978
Merged
Sheraff merged 6 commits into
mainfrom 
codex/frame-decoder-compact-result
Aug 7, 2026
Merged
perf(start-client-core): compact private frame decoder result keys#7978
Sheraff merged 6 commits into
mainfrom 
codex/frame-decoder-compact-result
Conversation
@Sheraff
@SheraffSheraff
commented
Aug 6, 2026•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Collaborator
What changed
  • Rename the private createFrameDecoder result keys from getOrCreateStream/jsonChunks to getStream/chunks.
  • Update the sole production consumer and direct decoder tests in lockstep.
  • Keep the existing two-property object shape, function/stream identities, property order, and public exports unchanged.
Bundle impact
Across the full 17-scenario matrix, all 11 Start scenarios improve by 4–12 B gzip and 24 B raw; all six router-only scenarios are byte-identical. Both renames also improve independently on react-start.minimal: getStream saves 6 B gzip / 16 B raw, and chunks saves 1 B gzip / 8 B raw. Brotli is mixed and documented in the evidence report.
Validation
  • start-client-core frame-decoder unit suite: 19 passed
  • TypeScript 5.6, 5.7, 5.8, 5.9, 6.0, and 7.0 matrices passed
  • ESLint passed with no new errors
  • React Start Vite/SSR client-RPC RawStream e2e: 6 passed
  • Full 17-scenario bundle matrix passed
  • Runtime allocation/destructure benchmark found no directional change
  • Five independent bundle, runtime, API, integration, and codegen reviews approved
Detailed artifacts and attribution are recorded in RESULT-optimization-frame-decoder-compact-result.md.
Summary by CodeRabbit
  • Refactor
    • Updated framed response handling with clearer stream and chunk naming.
    • Improved consistency in stream decoding interfaces without changing behavior.
    • Reduced the size of private frame decoder result keys.
  • Tests
    • Updated decoder coverage to use the revised stream and chunk terminology.
    • Existing test behavior and assertions remain unchanged.
@coderabbitai
coderabbitaiBot
commented
Aug 6, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Review Change Stack
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 045851a8-70eb-4673-b830-e1c3eeeb3482
📥 Commits
Reviewing files that changed from the base of the PR and between 7b62859 and b775949.
📒 Files selected for processing (1)
  • .changeset/kind-ghosts-win.md
📝 Walkthrough
Walkthrough
The frame decoder result API now exposes getStream and chunks. Server framed-response handling and decoder tests use the renamed properties. A Changeset records a patch release.
Changes
Frame decoder naming update
Layer / File(s)Summary
Rename decoder result properties
packages/start-client-core/src/client-rpc/frame-decoder.ts		FrameDecoderResult and createFrameDecoder now expose getStream and chunks.
Update response handling and tests
packages/start-client-core/src/client-rpc/serverFnFetcher.ts, packages/start-client-core/tests/frame-decoder.test.ts		Framed-response handling and decoder tests now consume the renamed properties. Aliases preserve existing local test names.
Record patch release
.changeset/kind-ghosts-win.md		The Changeset records a patch release for @tanstack/start-client-core.
Estimated code review effort: 1 (Trivial) | ~5 minutes
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly and concisely describes the main change: compacting private frame decoder result keys.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  •  Create PR with unit tests
  •  Commit unit tests in branch codex/frame-decoder-compact-result
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands.
@nx-cloud
nx-cloudBot
commented
Aug 6, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
View your CI Pipeline Execution ↗ for commit b775949
CommandStatusDurationResult
nx affected --targets=test:eslint,test:unit,tes...✅ Succeeded50m 9sView ↗
nx run-many --target=build --exclude=examples/*...✅ Succeeded1m 53sView ↗
☁️ Nx Cloud last updated this comment at 2026-08-07 13:08:41 UTC
@github-actions
github-actionsBot
commented
Aug 6, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
🚀 Changeset Version Preview
1 package(s) bumped directly, 13 bumped as dependents.
🟩 Patch bumps
PackageVersionReason
@tanstack/start-client-core1.170.18 → 1.170.19Changeset
@tanstack/react-start1.168.39 → 1.168.40Dependent
@tanstack/react-start-client1.168.20 → 1.168.21Dependent
@tanstack/react-start-rsc0.1.38 → 0.1.39Dependent
@tanstack/react-start-server1.167.27 → 1.167.28Dependent
@tanstack/solid-start1.168.38 → 1.168.39Dependent
@tanstack/solid-start-client1.168.20 → 1.168.21Dependent
@tanstack/solid-start-server1.167.27 → 1.167.28Dependent
@tanstack/start-plugin-core1.171.30 → 1.171.31Dependent
@tanstack/start-server-core1.169.22 → 1.169.23Dependent
@tanstack/start-static-server-functions1.167.23 → 1.167.24Dependent
@tanstack/vue-start1.168.37 → 1.168.38Dependent
@tanstack/vue-start-client1.167.23 → 1.167.24Dependent
@tanstack/vue-start-server1.167.27 → 1.167.28Dependent
@github-actions
github-actionsBot
commented
Aug 6, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Bundle Size Benchmarks
  • Commit: 27a6a68ba55a
  • Measured at: 2026-08-07T12:19:36.068Z
  • Baseline source: history:ea3a665d81cb
  • Dashboard: bundle-size history
The following scenarios have bundle-size changes compared with the baseline:
ScenarioCurrent (gzip)Delta vs baselineInitial gzipRawBrotliTrend
react-start.minimal100.39 KiB-8 B (-0.01%)100.25 KiB310.86 KiB87.16 KiB██▂▂▂▂▁▁▁▁▁▁
react-start.deferred-hydration101.13 KiB-9 B (-0.01%)100.28 KiB312.23 KiB87.87 KiB██▂▂▂▂▁▁▁▁▁▁
react-start.full103.75 KiB-3 B (-0.00%)103.61 KiB320.81 KiB90.16 KiB██▂▂▂▂▁▁▁▁▁▁
react-start.rsbuild.minimal99.98 KiB-8 B (-0.01%)99.81 KiB315.35 KiB86.25 KiB▁▁████▃▃▃▄▄▄
react-start.rsbuild.minimal-iife100.39 KiB-9 B (-0.01%)100.22 KiB316.28 KiB86.60 KiB▁▁████▃▃▃▄▄▄
react-start.rsbuild.full103.28 KiB-11 B (-0.01%)103.11 KiB325.44 KiB88.92 KiB▁▁██▇█▃▃▃▄▄▃
solid-start.minimal47.96 KiB-5 B (-0.01%)47.83 KiB140.63 KiB42.69 KiB██▂▂▂▂▁▁▁▁▁▁
solid-start.deferred-hydration51.23 KiB-4 B (-0.01%)47.89 KiB148.67 KiB45.66 KiB██▂▂▂▂▁▁▁▁▁▁
solid-start.full53.23 KiB-8 B (-0.01%)53.11 KiB156.35 KiB47.32 KiB██▂▂▂▂▁▁▁▁▁▁
vue-start.minimal68.64 KiB-5 B (-0.01%)68.51 KiB193.40 KiB61.10 KiB██▃▃▂▂▁▁▁▁▁▁
vue-start.full72.65 KiB-4 B (-0.01%)72.52 KiB205.90 KiB64.57 KiB██▂▂▂▂▁▁▁▁▁▁
Current gzip tracks all emitted client JS chunks. Initial gzip tracks only the entry/import graph. Trend sparkline is historical current gzip ending with this PR measurement; lower is better.
@pkg-pr-new
pkg-pr-newBot
commented
Aug 6, 2026•

edited

Loading

Copy link


Copy Markdown

More templates
@tanstack/arktype-adapter
npm i https://pkg.pr.new/@tanstack/arktype-adapter@7978

@tanstack/eslint-plugin-router
npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@7978

@tanstack/eslint-plugin-start
npm i https://pkg.pr.new/@tanstack/eslint-plugin-start@7978

@tanstack/history
npm i https://pkg.pr.new/@tanstack/history@7978

@tanstack/nitro-v2-vite-plugin
npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@7978

@tanstack/react-router
npm i https://pkg.pr.new/@tanstack/react-router@7978

@tanstack/react-router-devtools
npm i https://pkg.pr.new/@tanstack/react-router-devtools@7978

@tanstack/react-router-ssr-query
npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@7978

@tanstack/react-start
npm i https://pkg.pr.new/@tanstack/react-start@7978

@tanstack/react-start-client
npm i https://pkg.pr.new/@tanstack/react-start-client@7978

@tanstack/react-start-rsc
npm i https://pkg.pr.new/@tanstack/react-start-rsc@7978

@tanstack/react-start-server
npm i https://pkg.pr.new/@tanstack/react-start-server@7978

@tanstack/router-cli
npm i https://pkg.pr.new/@tanstack/router-cli@7978

@tanstack/router-core
npm i https://pkg.pr.new/@tanstack/router-core@7978

@tanstack/router-devtools
npm i https://pkg.pr.new/@tanstack/router-devtools@7978

@tanstack/router-devtools-core
npm i https://pkg.pr.new/@tanstack/router-devtools-core@7978

@tanstack/router-generator
npm i https://pkg.pr.new/@tanstack/router-generator@7978

@tanstack/router-plugin
npm i https://pkg.pr.new/@tanstack/router-plugin@7978

@tanstack/router-ssr-query-core
npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@7978

@tanstack/router-utils
npm i https://pkg.pr.new/@tanstack/router-utils@7978

@tanstack/router-vite-plugin
npm i https://pkg.pr.new/@tanstack/router-vite-plugin@7978

@tanstack/solid-router
npm i https://pkg.pr.new/@tanstack/solid-router@7978

@tanstack/solid-router-devtools
npm i https://pkg.pr.new/@tanstack/solid-router-devtools@7978

@tanstack/solid-router-ssr-query
npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@7978

@tanstack/solid-start
npm i https://pkg.pr.new/@tanstack/solid-start@7978

@tanstack/solid-start-client
npm i https://pkg.pr.new/@tanstack/solid-start-client@7978

@tanstack/solid-start-server
npm i https://pkg.pr.new/@tanstack/solid-start-server@7978

@tanstack/start-client-core
npm i https://pkg.pr.new/@tanstack/start-client-core@7978

@tanstack/start-fn-stubs
npm i https://pkg.pr.new/@tanstack/start-fn-stubs@7978

@tanstack/start-plugin-core
npm i https://pkg.pr.new/@tanstack/start-plugin-core@7978

@tanstack/start-server-core
npm i https://pkg.pr.new/@tanstack/start-server-core@7978

@tanstack/start-static-server-functions
npm i https://pkg.pr.new/@tanstack/start-static-server-functions@7978

@tanstack/start-storage-context
npm i https://pkg.pr.new/@tanstack/start-storage-context@7978

@tanstack/valibot-adapter
npm i https://pkg.pr.new/@tanstack/valibot-adapter@7978

@tanstack/virtual-file-routes
npm i https://pkg.pr.new/@tanstack/virtual-file-routes@7978

@tanstack/vue-router
npm i https://pkg.pr.new/@tanstack/vue-router@7978

@tanstack/vue-router-devtools
npm i https://pkg.pr.new/@tanstack/vue-router-devtools@7978

@tanstack/vue-router-ssr-query
npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@7978

@tanstack/vue-start
npm i https://pkg.pr.new/@tanstack/vue-start@7978

@tanstack/vue-start-client
npm i https://pkg.pr.new/@tanstack/vue-start-client@7978

@tanstack/vue-start-server
npm i https://pkg.pr.new/@tanstack/vue-start-server@7978

@tanstack/zod-adapter
npm i https://pkg.pr.new/@tanstack/zod-adapter@7978

commit: b775949
@codspeed-hq
codspeed-hqBot
commented
Aug 6, 2026•

edited

Loading

Copy link


Copy Markdown

Merging this PR will regress 5 benchmarks
⚠️Different runtime environments detected
Some benchmarks with significant performance changes were compared across different runtime environments,

which may affect the accuracy of the results.
Open the report in CodSpeed to investigate
⚡ 6 improved benchmarks
❌ 5 regressed benchmarks
✅ 169 untouched benchmarks
Warning
Please fix the performance issues or acknowledge them on CodSpeed.
Performance Changes
ModeBenchmarkBASEHEADEfficiency
❌Memorymem server error-paths not-found (vue)319.4 KB2,015.4 KB-84.15%
❌Memorymem client navigation-churn (vue)1.2 MB1.3 MB-5.56%
❌Memorymem server error-paths not-found (react)255.6 KB266.3 KB-4.02%
❌Memorymem server server-fn-churn (react)265 KB276.1 KB-4.02%
❌Memorymem client unique-location-churn (react)665.1 KB692.3 KB-3.92%
⚡Memorymem server server-fn-churn (vue)4,529.1 KB263.2 KB×17
⚡Memorymem server error-paths unmatched (solid)1,807.2 KB436.3 KB×4.1
⚡Memorymem server error-paths redirect (solid)523.7 KB277.8 KB+88.52%
⚡Memorymem server error-paths redirect (vue)370 KB294.2 KB+25.76%
⚡Simulationclient-history navigation loop (react)39.7 ms35.8 ms+10.95%
⚡Simulationssr request loop (solid)155.4 ms145.6 ms+6.75%
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing codex/frame-decoder-compact-result (b775949) with main (995bd97)
Open in CodSpeed
nx-cloud[bot]
nx-cloudBot
reviewed
Aug 6, 2026
View reviewed changes
@nx-cloudnx-cloudBot
left a comment
•

edited

Loading

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important
At least one additional CI pipeline execution has run since the conclusion below was written and it may no longer be applicable.
Nx Cloud has identified a possible root cause for your failed CI:
We classified this failure as an environment issue rather than a code change. The test failed with EADDRINUSE on port 32915, meaning another process had already claimed that port before the test's external server could start — unrelated to the PR's internal key renames in @tanstack/start-client-core. No port configuration or test infrastructure was modified by this PR.
No code changes were suggested for this issue.
Trigger a rerun:
Rerun CI
Nx Cloud View detailed reasoning on Nx Cloud ↗

🎓 Learn more about Self-Healing CI on nx.dev
@Sheraff
Sheraff
marked this pull request as ready for review
August 7, 2026 10:00
@Sheraff
Sheraff
merged commit 2fbc99f
into
mainAug 7, 2026

25 of 26 checks passed

@Sheraff
Sheraff
deleted the

codex/frame-decoder-compact-result

branch
August 7, 2026 13:18
@github-actionsgithub-actionsBot
mentioned this pull request
Aug 7, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@nx-cloudnx-cloud[bot]nx-cloud[bot] left review comments

Assignees


No one assigned


Labels

package: start-client-core

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@Sheraff

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
perf(start-client-core): compact private frame decoder result keys - #7978
Merged
Sheraff merged 6 commits into
mainfrom 
codex/frame-decoder-compact-result
Aug 7, 2026
Merged
perf(start-client-core): compact private frame decoder result keys#7978
Sheraff merged 6 commits into
mainfrom 
codex/frame-decoder-compact-result
Conversation
@Sheraff
@SheraffSheraff
commented
Aug 6, 2026•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Collaborator
What changed
  • Rename the private createFrameDecoder result keys from getOrCreateStream/jsonChunks to getStream/chunks.
  • Update the sole production consumer and direct decoder tests in lockstep.
  • Keep the existing two-property object shape, function/stream identities, property order, and public exports unchanged.
Bundle impact
Across the full 17-scenario matrix, all 11 Start scenarios improve by 4–12 B gzip and 24 B raw; all six router-only scenarios are byte-identical. Both renames also improve independently on react-start.minimal: getStream saves 6 B gzip / 16 B raw, and chunks saves 1 B gzip / 8 B raw. Brotli is mixed and documented in the evidence report.
Validation
  • start-client-core frame-decoder unit suite: 19 passed
  • TypeScript 5.6, 5.7, 5.8, 5.9, 6.0, and 7.0 matrices passed
  • ESLint passed with no new errors
  • React Start Vite/SSR client-RPC RawStream e2e: 6 passed
  • Full 17-scenario bundle matrix passed
  • Runtime allocation/destructure benchmark found no directional change
  • Five independent bundle, runtime, API, integration, and codegen reviews approved
Detailed artifacts and attribution are recorded in RESULT-optimization-frame-decoder-compact-result.md.
Summary by CodeRabbit
  • Refactor
    • Updated framed response handling with clearer stream and chunk naming.
    • Improved consistency in stream decoding interfaces without changing behavior.
    • Reduced the size of private frame decoder result keys.
  • Tests
    • Updated decoder coverage to use the revised stream and chunk terminology.
    • Existing test behavior and assertions remain unchanged.
@coderabbitai
coderabbitaiBot
commented
Aug 6, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Review Change Stack
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 045851a8-70eb-4673-b830-e1c3eeeb3482
📥 Commits
Reviewing files that changed from the base of the PR and between 7b62859 and b775949.
📒 Files selected for processing (1)
  • .changeset/kind-ghosts-win.md
📝 Walkthrough
Walkthrough
The frame decoder result API now exposes getStream and chunks. Server framed-response handling and decoder tests use the renamed properties. A Changeset records a patch release.
Changes
Frame decoder naming update
Layer / File(s)Summary
Rename decoder result properties
packages/start-client-core/src/client-rpc/frame-decoder.ts		FrameDecoderResult and createFrameDecoder now expose getStream and chunks.
Update response handling and tests
packages/start-client-core/src/client-rpc/serverFnFetcher.ts, packages/start-client-core/tests/frame-decoder.test.ts		Framed-response handling and decoder tests now consume the renamed properties. Aliases preserve existing local test names.
Record patch release
.changeset/kind-ghosts-win.md		The Changeset records a patch release for @tanstack/start-client-core.
Estimated code review effort: 1 (Trivial) | ~5 minutes
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly and concisely describes the main change: compacting private frame decoder result keys.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  •  Create PR with unit tests
  •  Commit unit tests in branch codex/frame-decoder-compact-result
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands.
@nx-cloud
nx-cloudBot
commented
Aug 6, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
View your CI Pipeline Execution ↗ for commit b775949
CommandStatusDurationResult
nx affected --targets=test:eslint,test:unit,tes...✅ Succeeded50m 9sView ↗
nx run-many --target=build --exclude=examples/*...✅ Succeeded1m 53sView ↗
☁️ Nx Cloud last updated this comment at 2026-08-07 13:08:41 UTC
@github-actions
github-actionsBot
commented
Aug 6, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
🚀 Changeset Version Preview
1 package(s) bumped directly, 13 bumped as dependents.
🟩 Patch bumps
PackageVersionReason
@tanstack/start-client-core1.170.18 → 1.170.19Changeset
@tanstack/react-start1.168.39 → 1.168.40Dependent
@tanstack/react-start-client1.168.20 → 1.168.21Dependent
@tanstack/react-start-rsc0.1.38 → 0.1.39Dependent
@tanstack/react-start-server1.167.27 → 1.167.28Dependent
@tanstack/solid-start1.168.38 → 1.168.39Dependent
@tanstack/solid-start-client1.168.20 → 1.168.21Dependent
@tanstack/solid-start-server1.167.27 → 1.167.28Dependent
@tanstack/start-plugin-core1.171.30 → 1.171.31Dependent
@tanstack/start-server-core1.169.22 → 1.169.23Dependent
@tanstack/start-static-server-functions1.167.23 → 1.167.24Dependent
@tanstack/vue-start1.168.37 → 1.168.38Dependent
@tanstack/vue-start-client1.167.23 → 1.167.24Dependent
@tanstack/vue-start-server1.167.27 → 1.167.28Dependent
@github-actions
github-actionsBot
commented
Aug 6, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Bundle Size Benchmarks
  • Commit: 27a6a68ba55a
  • Measured at: 2026-08-07T12:19:36.068Z
  • Baseline source: history:ea3a665d81cb
  • Dashboard: bundle-size history
The following scenarios have bundle-size changes compared with the baseline:
ScenarioCurrent (gzip)Delta vs baselineInitial gzipRawBrotliTrend
react-start.minimal100.39 KiB-8 B (-0.01%)100.25 KiB310.86 KiB87.16 KiB██▂▂▂▂▁▁▁▁▁▁
react-start.deferred-hydration101.13 KiB-9 B (-0.01%)100.28 KiB312.23 KiB87.87 KiB██▂▂▂▂▁▁▁▁▁▁
react-start.full103.75 KiB-3 B (-0.00%)103.61 KiB320.81 KiB90.16 KiB██▂▂▂▂▁▁▁▁▁▁
react-start.rsbuild.minimal99.98 KiB-8 B (-0.01%)99.81 KiB315.35 KiB86.25 KiB▁▁████▃▃▃▄▄▄
react-start.rsbuild.minimal-iife100.39 KiB-9 B (-0.01%)100.22 KiB316.28 KiB86.60 KiB▁▁████▃▃▃▄▄▄
react-start.rsbuild.full103.28 KiB-11 B (-0.01%)103.11 KiB325.44 KiB88.92 KiB▁▁██▇█▃▃▃▄▄▃
solid-start.minimal47.96 KiB-5 B (-0.01%)47.83 KiB140.63 KiB42.69 KiB██▂▂▂▂▁▁▁▁▁▁
solid-start.deferred-hydration51.23 KiB-4 B (-0.01%)47.89 KiB148.67 KiB45.66 KiB██▂▂▂▂▁▁▁▁▁▁
solid-start.full53.23 KiB-8 B (-0.01%)53.11 KiB156.35 KiB47.32 KiB██▂▂▂▂▁▁▁▁▁▁
vue-start.minimal68.64 KiB-5 B (-0.01%)68.51 KiB193.40 KiB61.10 KiB██▃▃▂▂▁▁▁▁▁▁
vue-start.full72.65 KiB-4 B (-0.01%)72.52 KiB205.90 KiB64.57 KiB██▂▂▂▂▁▁▁▁▁▁
Current gzip tracks all emitted client JS chunks. Initial gzip tracks only the entry/import graph. Trend sparkline is historical current gzip ending with this PR measurement; lower is better.
@pkg-pr-new
pkg-pr-newBot
commented
Aug 6, 2026•

edited

Loading

Copy link


Copy Markdown

More templates
@tanstack/arktype-adapter
npm i https://pkg.pr.new/@tanstack/arktype-adapter@7978

@tanstack/eslint-plugin-router
npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@7978

@tanstack/eslint-plugin-start
npm i https://pkg.pr.new/@tanstack/eslint-plugin-start@7978

@tanstack/history
npm i https://pkg.pr.new/@tanstack/history@7978

@tanstack/nitro-v2-vite-plugin
npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@7978

@tanstack/react-router
npm i https://pkg.pr.new/@tanstack/react-router@7978

@tanstack/react-router-devtools
npm i https://pkg.pr.new/@tanstack/react-router-devtools@7978

@tanstack/react-router-ssr-query
npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@7978

@tanstack/react-start
npm i https://pkg.pr.new/@tanstack/react-start@7978

@tanstack/react-start-client
npm i https://pkg.pr.new/@tanstack/react-start-client@7978

@tanstack/react-start-rsc
npm i https://pkg.pr.new/@tanstack/react-start-rsc@7978

@tanstack/react-start-server
npm i https://pkg.pr.new/@tanstack/react-start-server@7978

@tanstack/router-cli
npm i https://pkg.pr.new/@tanstack/router-cli@7978

@tanstack/router-core
npm i https://pkg.pr.new/@tanstack/router-core@7978

@tanstack/router-devtools
npm i https://pkg.pr.new/@tanstack/router-devtools@7978

@tanstack/router-devtools-core
npm i https://pkg.pr.new/@tanstack/router-devtools-core@7978

@tanstack/router-generator
npm i https://pkg.pr.new/@tanstack/router-generator@7978

@tanstack/router-plugin
npm i https://pkg.pr.new/@tanstack/router-plugin@7978

@tanstack/router-ssr-query-core
npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@7978

@tanstack/router-utils
npm i https://pkg.pr.new/@tanstack/router-utils@7978

@tanstack/router-vite-plugin
npm i https://pkg.pr.new/@tanstack/router-vite-plugin@7978

@tanstack/solid-router
npm i https://pkg.pr.new/@tanstack/solid-router@7978

@tanstack/solid-router-devtools
npm i https://pkg.pr.new/@tanstack/solid-router-devtools@7978

@tanstack/solid-router-ssr-query
npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@7978

@tanstack/solid-start
npm i https://pkg.pr.new/@tanstack/solid-start@7978

@tanstack/solid-start-client
npm i https://pkg.pr.new/@tanstack/solid-start-client@7978

@tanstack/solid-start-server
npm i https://pkg.pr.new/@tanstack/solid-start-server@7978

@tanstack/start-client-core
npm i https://pkg.pr.new/@tanstack/start-client-core@7978

@tanstack/start-fn-stubs
npm i https://pkg.pr.new/@tanstack/start-fn-stubs@7978

@tanstack/start-plugin-core
npm i https://pkg.pr.new/@tanstack/start-plugin-core@7978

@tanstack/start-server-core
npm i https://pkg.pr.new/@tanstack/start-server-core@7978

@tanstack/start-static-server-functions
npm i https://pkg.pr.new/@tanstack/start-static-server-functions@7978

@tanstack/start-storage-context
npm i https://pkg.pr.new/@tanstack/start-storage-context@7978

@tanstack/valibot-adapter
npm i https://pkg.pr.new/@tanstack/valibot-adapter@7978

@tanstack/virtual-file-routes
npm i https://pkg.pr.new/@tanstack/virtual-file-routes@7978

@tanstack/vue-router
npm i https://pkg.pr.new/@tanstack/vue-router@7978

@tanstack/vue-router-devtools
npm i https://pkg.pr.new/@tanstack/vue-router-devtools@7978

@tanstack/vue-router-ssr-query
npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@7978

@tanstack/vue-start
npm i https://pkg.pr.new/@tanstack/vue-start@7978

@tanstack/vue-start-client
npm i https://pkg.pr.new/@tanstack/vue-start-client@7978

@tanstack/vue-start-server
npm i https://pkg.pr.new/@tanstack/vue-start-server@7978

@tanstack/zod-adapter
npm i https://pkg.pr.new/@tanstack/zod-adapter@7978

commit: b775949
@codspeed-hq
codspeed-hqBot
commented
Aug 6, 2026•

edited

Loading

Copy link


Copy Markdown

Merging this PR will regress 5 benchmarks
⚠️Different runtime environments detected
Some benchmarks with significant performance changes were compared across different runtime environments,

which may affect the accuracy of the results.
Open the report in CodSpeed to investigate
⚡ 6 improved benchmarks
❌ 5 regressed benchmarks
✅ 169 untouched benchmarks
Warning
Please fix the performance issues or acknowledge them on CodSpeed.
Performance Changes
ModeBenchmarkBASEHEADEfficiency
❌Memorymem server error-paths not-found (vue)319.4 KB2,015.4 KB-84.15%
❌Memorymem client navigation-churn (vue)1.2 MB1.3 MB-5.56%
❌Memorymem server error-paths not-found (react)255.6 KB266.3 KB-4.02%
❌Memorymem server server-fn-churn (react)265 KB276.1 KB-4.02%
❌Memorymem client unique-location-churn (react)665.1 KB692.3 KB-3.92%
⚡Memorymem server server-fn-churn (vue)4,529.1 KB263.2 KB×17
⚡Memorymem server error-paths unmatched (solid)1,807.2 KB436.3 KB×4.1
⚡Memorymem server error-paths redirect (solid)523.7 KB277.8 KB+88.52%
⚡Memorymem server error-paths redirect (vue)370 KB294.2 KB+25.76%
⚡Simulationclient-history navigation loop (react)39.7 ms35.8 ms+10.95%
⚡Simulationssr request loop (solid)155.4 ms145.6 ms+6.75%
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing codex/frame-decoder-compact-result (b775949) with main (995bd97)
Open in CodSpeed
nx-cloud[bot]
nx-cloudBot
reviewed
Aug 6, 2026
View reviewed changes
@nx-cloudnx-cloudBot
left a comment
•

edited

Loading

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important
At least one additional CI pipeline execution has run since the conclusion below was written and it may no longer be applicable.
Nx Cloud has identified a possible root cause for your failed CI:
We classified this failure as an environment issue rather than a code change. The test failed with EADDRINUSE on port 32915, meaning another process had already claimed that port before the test's external server could start — unrelated to the PR's internal key renames in @tanstack/start-client-core. No port configuration or test infrastructure was modified by this PR.
No code changes were suggested for this issue.
Trigger a rerun:
Rerun CI
Nx Cloud View detailed reasoning on Nx Cloud ↗

🎓 Learn more about Self-Healing CI on nx.dev
@Sheraff
Sheraff
marked this pull request as ready for review
August 7, 2026 10:00
@Sheraff
Sheraff
merged commit 2fbc99f
into
mainAug 7, 2026

25 of 26 checks passed

@Sheraff
Sheraff
deleted the

codex/frame-decoder-compact-result

branch
August 7, 2026 13:18
@github-actionsgithub-actionsBot
mentioned this pull request
Aug 7, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@nx-cloudnx-cloud[bot]nx-cloud[bot] left review comments

Assignees


No one assigned


Labels

package: start-client-core

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@Sheraff

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
perf(start-client-core): compact private frame decoder result keys - #7978
Merged
Sheraff merged 6 commits into
mainfrom 
codex/frame-decoder-compact-result
Aug 7, 2026
Merged
perf(start-client-core): compact private frame decoder result keys#7978
Sheraff merged 6 commits into
mainfrom 
codex/frame-decoder-compact-result
Conversation
@Sheraff
@SheraffSheraff
commented
Aug 6, 2026•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Collaborator
What changed
  • Rename the private createFrameDecoder result keys from getOrCreateStream/jsonChunks to getStream/chunks.
  • Update the sole production consumer and direct decoder tests in lockstep.
  • Keep the existing two-property object shape, function/stream identities, property order, and public exports unchanged.
Bundle impact
Across the full 17-scenario matrix, all 11 Start scenarios improve by 4–12 B gzip and 24 B raw; all six router-only scenarios are byte-identical. Both renames also improve independently on react-start.minimal: getStream saves 6 B gzip / 16 B raw, and chunks saves 1 B gzip / 8 B raw. Brotli is mixed and documented in the evidence report.
Validation
  • start-client-core frame-decoder unit suite: 19 passed
  • TypeScript 5.6, 5.7, 5.8, 5.9, 6.0, and 7.0 matrices passed
  • ESLint passed with no new errors
  • React Start Vite/SSR client-RPC RawStream e2e: 6 passed
  • Full 17-scenario bundle matrix passed
  • Runtime allocation/destructure benchmark found no directional change
  • Five independent bundle, runtime, API, integration, and codegen reviews approved
Detailed artifacts and attribution are recorded in RESULT-optimization-frame-decoder-compact-result.md.
Summary by CodeRabbit
  • Refactor
    • Updated framed response handling with clearer stream and chunk naming.
    • Improved consistency in stream decoding interfaces without changing behavior.
    • Reduced the size of private frame decoder result keys.
  • Tests
    • Updated decoder coverage to use the revised stream and chunk terminology.
    • Existing test behavior and assertions remain unchanged.
@coderabbitai
coderabbitaiBot
commented
Aug 6, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Review Change Stack
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 045851a8-70eb-4673-b830-e1c3eeeb3482
📥 Commits
Reviewing files that changed from the base of the PR and between 7b62859 and b775949.
📒 Files selected for processing (1)
  • .changeset/kind-ghosts-win.md
📝 Walkthrough
Walkthrough
The frame decoder result API now exposes getStream and chunks. Server framed-response handling and decoder tests use the renamed properties. A Changeset records a patch release.
Changes
Frame decoder naming update
Layer / File(s)Summary
Rename decoder result properties
packages/start-client-core/src/client-rpc/frame-decoder.ts		FrameDecoderResult and createFrameDecoder now expose getStream and chunks.
Update response handling and tests
packages/start-client-core/src/client-rpc/serverFnFetcher.ts, packages/start-client-core/tests/frame-decoder.test.ts		Framed-response handling and decoder tests now consume the renamed properties. Aliases preserve existing local test names.
Record patch release
.changeset/kind-ghosts-win.md		The Changeset records a patch release for @tanstack/start-client-core.
Estimated code review effort: 1 (Trivial) | ~5 minutes
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly and concisely describes the main change: compacting private frame decoder result keys.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  •  Create PR with unit tests
  •  Commit unit tests in branch codex/frame-decoder-compact-result
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands.
@nx-cloud
nx-cloudBot
commented
Aug 6, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
View your CI Pipeline Execution ↗ for commit b775949
CommandStatusDurationResult
nx affected --targets=test:eslint,test:unit,tes...✅ Succeeded50m 9sView ↗
nx run-many --target=build --exclude=examples/*...✅ Succeeded1m 53sView ↗
☁️ Nx Cloud last updated this comment at 2026-08-07 13:08:41 UTC
@github-actions
github-actionsBot
commented
Aug 6, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
🚀 Changeset Version Preview
1 package(s) bumped directly, 13 bumped as dependents.
🟩 Patch bumps
PackageVersionReason
@tanstack/start-client-core1.170.18 → 1.170.19Changeset
@tanstack/react-start1.168.39 → 1.168.40Dependent
@tanstack/react-start-client1.168.20 → 1.168.21Dependent
@tanstack/react-start-rsc0.1.38 → 0.1.39Dependent
@tanstack/react-start-server1.167.27 → 1.167.28Dependent
@tanstack/solid-start1.168.38 → 1.168.39Dependent
@tanstack/solid-start-client1.168.20 → 1.168.21Dependent
@tanstack/solid-start-server1.167.27 → 1.167.28Dependent
@tanstack/start-plugin-core1.171.30 → 1.171.31Dependent
@tanstack/start-server-core1.169.22 → 1.169.23Dependent
@tanstack/start-static-server-functions1.167.23 → 1.167.24Dependent
@tanstack/vue-start1.168.37 → 1.168.38Dependent
@tanstack/vue-start-client1.167.23 → 1.167.24Dependent
@tanstack/vue-start-server1.167.27 → 1.167.28Dependent
@github-actions
github-actionsBot
commented
Aug 6, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Bundle Size Benchmarks
  • Commit: 27a6a68ba55a
  • Measured at: 2026-08-07T12:19:36.068Z
  • Baseline source: history:ea3a665d81cb
  • Dashboard: bundle-size history
The following scenarios have bundle-size changes compared with the baseline:
ScenarioCurrent (gzip)Delta vs baselineInitial gzipRawBrotliTrend
react-start.minimal100.39 KiB-8 B (-0.01%)100.25 KiB310.86 KiB87.16 KiB██▂▂▂▂▁▁▁▁▁▁
react-start.deferred-hydration101.13 KiB-9 B (-0.01%)100.28 KiB312.23 KiB87.87 KiB██▂▂▂▂▁▁▁▁▁▁
react-start.full103.75 KiB-3 B (-0.00%)103.61 KiB320.81 KiB90.16 KiB██▂▂▂▂▁▁▁▁▁▁
react-start.rsbuild.minimal99.98 KiB-8 B (-0.01%)99.81 KiB315.35 KiB86.25 KiB▁▁████▃▃▃▄▄▄
react-start.rsbuild.minimal-iife100.39 KiB-9 B (-0.01%)100.22 KiB316.28 KiB86.60 KiB▁▁████▃▃▃▄▄▄
react-start.rsbuild.full103.28 KiB-11 B (-0.01%)103.11 KiB325.44 KiB88.92 KiB▁▁██▇█▃▃▃▄▄▃
solid-start.minimal47.96 KiB-5 B (-0.01%)47.83 KiB140.63 KiB42.69 KiB██▂▂▂▂▁▁▁▁▁▁
solid-start.deferred-hydration51.23 KiB-4 B (-0.01%)47.89 KiB148.67 KiB45.66 KiB██▂▂▂▂▁▁▁▁▁▁
solid-start.full53.23 KiB-8 B (-0.01%)53.11 KiB156.35 KiB47.32 KiB██▂▂▂▂▁▁▁▁▁▁
vue-start.minimal68.64 KiB-5 B (-0.01%)68.51 KiB193.40 KiB61.10 KiB██▃▃▂▂▁▁▁▁▁▁
vue-start.full72.65 KiB-4 B (-0.01%)72.52 KiB205.90 KiB64.57 KiB██▂▂▂▂▁▁▁▁▁▁
Current gzip tracks all emitted client JS chunks. Initial gzip tracks only the entry/import graph. Trend sparkline is historical current gzip ending with this PR measurement; lower is better.
@pkg-pr-new
pkg-pr-newBot
commented
Aug 6, 2026•

edited

Loading

Copy link


Copy Markdown

More templates
@tanstack/arktype-adapter
npm i https://pkg.pr.new/@tanstack/arktype-adapter@7978

@tanstack/eslint-plugin-router
npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@7978

@tanstack/eslint-plugin-start
npm i https://pkg.pr.new/@tanstack/eslint-plugin-start@7978

@tanstack/history
npm i https://pkg.pr.new/@tanstack/history@7978

@tanstack/nitro-v2-vite-plugin
npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@7978

@tanstack/react-router
npm i https://pkg.pr.new/@tanstack/react-router@7978

@tanstack/react-router-devtools
npm i https://pkg.pr.new/@tanstack/react-router-devtools@7978

@tanstack/react-router-ssr-query
npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@7978

@tanstack/react-start
npm i https://pkg.pr.new/@tanstack/react-start@7978

@tanstack/react-start-client
npm i https://pkg.pr.new/@tanstack/react-start-client@7978

@tanstack/react-start-rsc
npm i https://pkg.pr.new/@tanstack/react-start-rsc@7978

@tanstack/react-start-server
npm i https://pkg.pr.new/@tanstack/react-start-server@7978

@tanstack/router-cli
npm i https://pkg.pr.new/@tanstack/router-cli@7978

@tanstack/router-core
npm i https://pkg.pr.new/@tanstack/router-core@7978

@tanstack/router-devtools
npm i https://pkg.pr.new/@tanstack/router-devtools@7978

@tanstack/router-devtools-core
npm i https://pkg.pr.new/@tanstack/router-devtools-core@7978

@tanstack/router-generator
npm i https://pkg.pr.new/@tanstack/router-generator@7978

@tanstack/router-plugin
npm i https://pkg.pr.new/@tanstack/router-plugin@7978

@tanstack/router-ssr-query-core
npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@7978

@tanstack/router-utils
npm i https://pkg.pr.new/@tanstack/router-utils@7978

@tanstack/router-vite-plugin
npm i https://pkg.pr.new/@tanstack/router-vite-plugin@7978

@tanstack/solid-router
npm i https://pkg.pr.new/@tanstack/solid-router@7978

@tanstack/solid-router-devtools
npm i https://pkg.pr.new/@tanstack/solid-router-devtools@7978

@tanstack/solid-router-ssr-query
npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@7978

@tanstack/solid-start
npm i https://pkg.pr.new/@tanstack/solid-start@7978

@tanstack/solid-start-client
npm i https://pkg.pr.new/@tanstack/solid-start-client@7978

@tanstack/solid-start-server
npm i https://pkg.pr.new/@tanstack/solid-start-server@7978

@tanstack/start-client-core
npm i https://pkg.pr.new/@tanstack/start-client-core@7978

@tanstack/start-fn-stubs
npm i https://pkg.pr.new/@tanstack/start-fn-stubs@7978

@tanstack/start-plugin-core
npm i https://pkg.pr.new/@tanstack/start-plugin-core@7978

@tanstack/start-server-core
npm i https://pkg.pr.new/@tanstack/start-server-core@7978

@tanstack/start-static-server-functions
npm i https://pkg.pr.new/@tanstack/start-static-server-functions@7978

@tanstack/start-storage-context
npm i https://pkg.pr.new/@tanstack/start-storage-context@7978

@tanstack/valibot-adapter
npm i https://pkg.pr.new/@tanstack/valibot-adapter@7978

@tanstack/virtual-file-routes
npm i https://pkg.pr.new/@tanstack/virtual-file-routes@7978

@tanstack/vue-router
npm i https://pkg.pr.new/@tanstack/vue-router@7978

@tanstack/vue-router-devtools
npm i https://pkg.pr.new/@tanstack/vue-router-devtools@7978

@tanstack/vue-router-ssr-query
npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@7978

@tanstack/vue-start
npm i https://pkg.pr.new/@tanstack/vue-start@7978

@tanstack/vue-start-client
npm i https://pkg.pr.new/@tanstack/vue-start-client@7978

@tanstack/vue-start-server
npm i https://pkg.pr.new/@tanstack/vue-start-server@7978

@tanstack/zod-adapter
npm i https://pkg.pr.new/@tanstack/zod-adapter@7978

commit: b775949
@codspeed-hq
codspeed-hqBot
commented
Aug 6, 2026•

edited

Loading

Copy link


Copy Markdown

Merging this PR will regress 5 benchmarks
⚠️Different runtime environments detected
Some benchmarks with significant performance changes were compared across different runtime environments,

which may affect the accuracy of the results.
Open the report in CodSpeed to investigate
⚡ 6 improved benchmarks
❌ 5 regressed benchmarks
✅ 169 untouched benchmarks
Warning
Please fix the performance issues or acknowledge them on CodSpeed.
Performance Changes
ModeBenchmarkBASEHEADEfficiency
❌Memorymem server error-paths not-found (vue)319.4 KB2,015.4 KB-84.15%
❌Memorymem client navigation-churn (vue)1.2 MB1.3 MB-5.56%
❌Memorymem server error-paths not-found (react)255.6 KB266.3 KB-4.02%
❌Memorymem server server-fn-churn (react)265 KB276.1 KB-4.02%
❌Memorymem client unique-location-churn (react)665.1 KB692.3 KB-3.92%
⚡Memorymem server server-fn-churn (vue)4,529.1 KB263.2 KB×17
⚡Memorymem server error-paths unmatched (solid)1,807.2 KB436.3 KB×4.1
⚡Memorymem server error-paths redirect (solid)523.7 KB277.8 KB+88.52%
⚡Memorymem server error-paths redirect (vue)370 KB294.2 KB+25.76%
⚡Simulationclient-history navigation loop (react)39.7 ms35.8 ms+10.95%
⚡Simulationssr request loop (solid)155.4 ms145.6 ms+6.75%
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing codex/frame-decoder-compact-result (b775949) with main (995bd97)
Open in CodSpeed
nx-cloud[bot]
nx-cloudBot
reviewed
Aug 6, 2026
View reviewed changes
@nx-cloudnx-cloudBot
left a comment
•

edited

Loading

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important
At least one additional CI pipeline execution has run since the conclusion below was written and it may no longer be applicable.
Nx Cloud has identified a possible root cause for your failed CI:
We classified this failure as an environment issue rather than a code change. The test failed with EADDRINUSE on port 32915, meaning another process had already claimed that port before the test's external server could start — unrelated to the PR's internal key renames in @tanstack/start-client-core. No port configuration or test infrastructure was modified by this PR.
No code changes were suggested for this issue.
Trigger a rerun:
Rerun CI
Nx Cloud View detailed reasoning on Nx Cloud ↗

🎓 Learn more about Self-Healing CI on nx.dev
@Sheraff
Sheraff
marked this pull request as ready for review
August 7, 2026 10:00
@Sheraff
Sheraff
merged commit 2fbc99f
into
mainAug 7, 2026

25 of 26 checks passed

@Sheraff
Sheraff
deleted the

codex/frame-decoder-compact-result

branch
August 7, 2026 13:18
@github-actionsgithub-actionsBot
mentioned this pull request
Aug 7, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@nx-cloudnx-cloud[bot]nx-cloud[bot] left review comments

Assignees


No one assigned


Labels

package: start-client-core

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@Sheraff

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
perf(start-client-core): compact private frame decoder result keys - #7978
Merged
Sheraff merged 6 commits into
mainfrom 
codex/frame-decoder-compact-result
Aug 7, 2026
Merged
perf(start-client-core): compact private frame decoder result keys#7978
Sheraff merged 6 commits into
mainfrom 
codex/frame-decoder-compact-result
Conversation
@Sheraff
@SheraffSheraff
commented
Aug 6, 2026•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Collaborator
What changed
  • Rename the private createFrameDecoder result keys from getOrCreateStream/jsonChunks to getStream/chunks.
  • Update the sole production consumer and direct decoder tests in lockstep.
  • Keep the existing two-property object shape, function/stream identities, property order, and public exports unchanged.
Bundle impact
Across the full 17-scenario matrix, all 11 Start scenarios improve by 4–12 B gzip and 24 B raw; all six router-only scenarios are byte-identical. Both renames also improve independently on react-start.minimal: getStream saves 6 B gzip / 16 B raw, and chunks saves 1 B gzip / 8 B raw. Brotli is mixed and documented in the evidence report.
Validation
  • start-client-core frame-decoder unit suite: 19 passed
  • TypeScript 5.6, 5.7, 5.8, 5.9, 6.0, and 7.0 matrices passed
  • ESLint passed with no new errors
  • React Start Vite/SSR client-RPC RawStream e2e: 6 passed
  • Full 17-scenario bundle matrix passed
  • Runtime allocation/destructure benchmark found no directional change
  • Five independent bundle, runtime, API, integration, and codegen reviews approved
Detailed artifacts and attribution are recorded in RESULT-optimization-frame-decoder-compact-result.md.
Summary by CodeRabbit
  • Refactor
    • Updated framed response handling with clearer stream and chunk naming.
    • Improved consistency in stream decoding interfaces without changing behavior.
    • Reduced the size of private frame decoder result keys.
  • Tests
    • Updated decoder coverage to use the revised stream and chunk terminology.
    • Existing test behavior and assertions remain unchanged.
@coderabbitai
coderabbitaiBot
commented
Aug 6, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Review Change Stack
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 045851a8-70eb-4673-b830-e1c3eeeb3482
📥 Commits
Reviewing files that changed from the base of the PR and between 7b62859 and b775949.
📒 Files selected for processing (1)
  • .changeset/kind-ghosts-win.md
📝 Walkthrough
Walkthrough
The frame decoder result API now exposes getStream and chunks. Server framed-response handling and decoder tests use the renamed properties. A Changeset records a patch release.
Changes
Frame decoder naming update
Layer / File(s)Summary
Rename decoder result properties
packages/start-client-core/src/client-rpc/frame-decoder.ts		FrameDecoderResult and createFrameDecoder now expose getStream and chunks.
Update response handling and tests
packages/start-client-core/src/client-rpc/serverFnFetcher.ts, packages/start-client-core/tests/frame-decoder.test.ts		Framed-response handling and decoder tests now consume the renamed properties. Aliases preserve existing local test names.
Record patch release
.changeset/kind-ghosts-win.md		The Changeset records a patch release for @tanstack/start-client-core.
Estimated code review effort: 1 (Trivial) | ~5 minutes
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly and concisely describes the main change: compacting private frame decoder result keys.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  •  Create PR with unit tests
  •  Commit unit tests in branch codex/frame-decoder-compact-result
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands.
@nx-cloud
nx-cloudBot
commented
Aug 6, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
View your CI Pipeline Execution ↗ for commit b775949
CommandStatusDurationResult
nx affected --targets=test:eslint,test:unit,tes...✅ Succeeded50m 9sView ↗
nx run-many --target=build --exclude=examples/*...✅ Succeeded1m 53sView ↗
☁️ Nx Cloud last updated this comment at 2026-08-07 13:08:41 UTC
@github-actions
github-actionsBot
commented
Aug 6, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
🚀 Changeset Version Preview
1 package(s) bumped directly, 13 bumped as dependents.
🟩 Patch bumps
PackageVersionReason
@tanstack/start-client-core1.170.18 → 1.170.19Changeset
@tanstack/react-start1.168.39 → 1.168.40Dependent
@tanstack/react-start-client1.168.20 → 1.168.21Dependent
@tanstack/react-start-rsc0.1.38 → 0.1.39Dependent
@tanstack/react-start-server1.167.27 → 1.167.28Dependent
@tanstack/solid-start1.168.38 → 1.168.39Dependent
@tanstack/solid-start-client1.168.20 → 1.168.21Dependent
@tanstack/solid-start-server1.167.27 → 1.167.28Dependent
@tanstack/start-plugin-core1.171.30 → 1.171.31Dependent
@tanstack/start-server-core1.169.22 → 1.169.23Dependent
@tanstack/start-static-server-functions1.167.23 → 1.167.24Dependent
@tanstack/vue-start1.168.37 → 1.168.38Dependent
@tanstack/vue-start-client1.167.23 → 1.167.24Dependent
@tanstack/vue-start-server1.167.27 → 1.167.28Dependent
@github-actions
github-actionsBot
commented
Aug 6, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Bundle Size Benchmarks
  • Commit: 27a6a68ba55a
  • Measured at: 2026-08-07T12:19:36.068Z
  • Baseline source: history:ea3a665d81cb
  • Dashboard: bundle-size history
The following scenarios have bundle-size changes compared with the baseline:
ScenarioCurrent (gzip)Delta vs baselineInitial gzipRawBrotliTrend
react-start.minimal100.39 KiB-8 B (-0.01%)100.25 KiB310.86 KiB87.16 KiB██▂▂▂▂▁▁▁▁▁▁
react-start.deferred-hydration101.13 KiB-9 B (-0.01%)100.28 KiB312.23 KiB87.87 KiB██▂▂▂▂▁▁▁▁▁▁
react-start.full103.75 KiB-3 B (-0.00%)103.61 KiB320.81 KiB90.16 KiB██▂▂▂▂▁▁▁▁▁▁
react-start.rsbuild.minimal99.98 KiB-8 B (-0.01%)99.81 KiB315.35 KiB86.25 KiB▁▁████▃▃▃▄▄▄
react-start.rsbuild.minimal-iife100.39 KiB-9 B (-0.01%)100.22 KiB316.28 KiB86.60 KiB▁▁████▃▃▃▄▄▄
react-start.rsbuild.full103.28 KiB-11 B (-0.01%)103.11 KiB325.44 KiB88.92 KiB▁▁██▇█▃▃▃▄▄▃
solid-start.minimal47.96 KiB-5 B (-0.01%)47.83 KiB140.63 KiB42.69 KiB██▂▂▂▂▁▁▁▁▁▁
solid-start.deferred-hydration51.23 KiB-4 B (-0.01%)47.89 KiB148.67 KiB45.66 KiB██▂▂▂▂▁▁▁▁▁▁
solid-start.full53.23 KiB-8 B (-0.01%)53.11 KiB156.35 KiB47.32 KiB██▂▂▂▂▁▁▁▁▁▁
vue-start.minimal68.64 KiB-5 B (-0.01%)68.51 KiB193.40 KiB61.10 KiB██▃▃▂▂▁▁▁▁▁▁
vue-start.full72.65 KiB-4 B (-0.01%)72.52 KiB205.90 KiB64.57 KiB██▂▂▂▂▁▁▁▁▁▁
Current gzip tracks all emitted client JS chunks. Initial gzip tracks only the entry/import graph. Trend sparkline is historical current gzip ending with this PR measurement; lower is better.
@pkg-pr-new
pkg-pr-newBot
commented
Aug 6, 2026•

edited

Loading

Copy link


Copy Markdown

More templates
@tanstack/arktype-adapter
npm i https://pkg.pr.new/@tanstack/arktype-adapter@7978

@tanstack/eslint-plugin-router
npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@7978

@tanstack/eslint-plugin-start
npm i https://pkg.pr.new/@tanstack/eslint-plugin-start@7978

@tanstack/history
npm i https://pkg.pr.new/@tanstack/history@7978

@tanstack/nitro-v2-vite-plugin
npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@7978

@tanstack/react-router
npm i https://pkg.pr.new/@tanstack/react-router@7978

@tanstack/react-router-devtools
npm i https://pkg.pr.new/@tanstack/react-router-devtools@7978

@tanstack/react-router-ssr-query
npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@7978

@tanstack/react-start
npm i https://pkg.pr.new/@tanstack/react-start@7978

@tanstack/react-start-client
npm i https://pkg.pr.new/@tanstack/react-start-client@7978

@tanstack/react-start-rsc
npm i https://pkg.pr.new/@tanstack/react-start-rsc@7978

@tanstack/react-start-server
npm i https://pkg.pr.new/@tanstack/react-start-server@7978

@tanstack/router-cli
npm i https://pkg.pr.new/@tanstack/router-cli@7978

@tanstack/router-core
npm i https://pkg.pr.new/@tanstack/router-core@7978

@tanstack/router-devtools
npm i https://pkg.pr.new/@tanstack/router-devtools@7978

@tanstack/router-devtools-core
npm i https://pkg.pr.new/@tanstack/router-devtools-core@7978

@tanstack/router-generator
npm i https://pkg.pr.new/@tanstack/router-generator@7978

@tanstack/router-plugin
npm i https://pkg.pr.new/@tanstack/router-plugin@7978

@tanstack/router-ssr-query-core
npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@7978

@tanstack/router-utils
npm i https://pkg.pr.new/@tanstack/router-utils@7978

@tanstack/router-vite-plugin
npm i https://pkg.pr.new/@tanstack/router-vite-plugin@7978

@tanstack/solid-router
npm i https://pkg.pr.new/@tanstack/solid-router@7978

@tanstack/solid-router-devtools
npm i https://pkg.pr.new/@tanstack/solid-router-devtools@7978

@tanstack/solid-router-ssr-query
npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@7978

@tanstack/solid-start
npm i https://pkg.pr.new/@tanstack/solid-start@7978

@tanstack/solid-start-client
npm i https://pkg.pr.new/@tanstack/solid-start-client@7978

@tanstack/solid-start-server
npm i https://pkg.pr.new/@tanstack/solid-start-server@7978

@tanstack/start-client-core
npm i https://pkg.pr.new/@tanstack/start-client-core@7978

@tanstack/start-fn-stubs
npm i https://pkg.pr.new/@tanstack/start-fn-stubs@7978

@tanstack/start-plugin-core
npm i https://pkg.pr.new/@tanstack/start-plugin-core@7978

@tanstack/start-server-core
npm i https://pkg.pr.new/@tanstack/start-server-core@7978

@tanstack/start-static-server-functions
npm i https://pkg.pr.new/@tanstack/start-static-server-functions@7978

@tanstack/start-storage-context
npm i https://pkg.pr.new/@tanstack/start-storage-context@7978

@tanstack/valibot-adapter
npm i https://pkg.pr.new/@tanstack/valibot-adapter@7978

@tanstack/virtual-file-routes
npm i https://pkg.pr.new/@tanstack/virtual-file-routes@7978

@tanstack/vue-router
npm i https://pkg.pr.new/@tanstack/vue-router@7978

@tanstack/vue-router-devtools
npm i https://pkg.pr.new/@tanstack/vue-router-devtools@7978

@tanstack/vue-router-ssr-query
npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@7978

@tanstack/vue-start
npm i https://pkg.pr.new/@tanstack/vue-start@7978

@tanstack/vue-start-client
npm i https://pkg.pr.new/@tanstack/vue-start-client@7978

@tanstack/vue-start-server
npm i https://pkg.pr.new/@tanstack/vue-start-server@7978

@tanstack/zod-adapter
npm i https://pkg.pr.new/@tanstack/zod-adapter@7978

commit: b775949
@codspeed-hq
codspeed-hqBot
commented
Aug 6, 2026•

edited

Loading

Copy link


Copy Markdown

Merging this PR will regress 5 benchmarks
⚠️Different runtime environments detected
Some benchmarks with significant performance changes were compared across different runtime environments,

which may affect the accuracy of the results.
Open the report in CodSpeed to investigate
⚡ 6 improved benchmarks
❌ 5 regressed benchmarks
✅ 169 untouched benchmarks
Warning
Please fix the performance issues or acknowledge them on CodSpeed.
Performance Changes
ModeBenchmarkBASEHEADEfficiency
❌Memorymem server error-paths not-found (vue)319.4 KB2,015.4 KB-84.15%
❌Memorymem client navigation-churn (vue)1.2 MB1.3 MB-5.56%
❌Memorymem server error-paths not-found (react)255.6 KB266.3 KB-4.02%
❌Memorymem server server-fn-churn (react)265 KB276.1 KB-4.02%
❌Memorymem client unique-location-churn (react)665.1 KB692.3 KB-3.92%
⚡Memorymem server server-fn-churn (vue)4,529.1 KB263.2 KB×17
⚡Memorymem server error-paths unmatched (solid)1,807.2 KB436.3 KB×4.1
⚡Memorymem server error-paths redirect (solid)523.7 KB277.8 KB+88.52%
⚡Memorymem server error-paths redirect (vue)370 KB294.2 KB+25.76%
⚡Simulationclient-history navigation loop (react)39.7 ms35.8 ms+10.95%
⚡Simulationssr request loop (solid)155.4 ms145.6 ms+6.75%
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing codex/frame-decoder-compact-result (b775949) with main (995bd97)
Open in CodSpeed
nx-cloud[bot]
nx-cloudBot
reviewed
Aug 6, 2026
View reviewed changes
@nx-cloudnx-cloudBot
left a comment
•

edited

Loading

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important
At least one additional CI pipeline execution has run since the conclusion below was written and it may no longer be applicable.
Nx Cloud has identified a possible root cause for your failed CI:
We classified this failure as an environment issue rather than a code change. The test failed with EADDRINUSE on port 32915, meaning another process had already claimed that port before the test's external server could start — unrelated to the PR's internal key renames in @tanstack/start-client-core. No port configuration or test infrastructure was modified by this PR.
No code changes were suggested for this issue.
Trigger a rerun:
Rerun CI
Nx Cloud View detailed reasoning on Nx Cloud ↗

🎓 Learn more about Self-Healing CI on nx.dev
@Sheraff
Sheraff
marked this pull request as ready for review
August 7, 2026 10:00
@Sheraff
Sheraff
merged commit 2fbc99f
into
mainAug 7, 2026

25 of 26 checks passed

@Sheraff
Sheraff
deleted the

codex/frame-decoder-compact-result

branch
August 7, 2026 13:18
@github-actionsgithub-actionsBot
mentioned this pull request
Aug 7, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@nx-cloudnx-cloud[bot]nx-cloud[bot] left review comments

Assignees


No one assigned


Labels

package: start-client-core

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@Sheraff

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
perf(start-client-core): compact private frame decoder result keys - #7978
Merged
Sheraff merged 6 commits into
mainfrom 
codex/frame-decoder-compact-result
Aug 7, 2026
Merged
perf(start-client-core): compact private frame decoder result keys#7978
Sheraff merged 6 commits into
mainfrom 
codex/frame-decoder-compact-result
Conversation
@Sheraff
@SheraffSheraff
commented
Aug 6, 2026•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Collaborator
What changed
  • Rename the private createFrameDecoder result keys from getOrCreateStream/jsonChunks to getStream/chunks.
  • Update the sole production consumer and direct decoder tests in lockstep.
  • Keep the existing two-property object shape, function/stream identities, property order, and public exports unchanged.
Bundle impact
Across the full 17-scenario matrix, all 11 Start scenarios improve by 4–12 B gzip and 24 B raw; all six router-only scenarios are byte-identical. Both renames also improve independently on react-start.minimal: getStream saves 6 B gzip / 16 B raw, and chunks saves 1 B gzip / 8 B raw. Brotli is mixed and documented in the evidence report.
Validation
  • start-client-core frame-decoder unit suite: 19 passed
  • TypeScript 5.6, 5.7, 5.8, 5.9, 6.0, and 7.0 matrices passed
  • ESLint passed with no new errors
  • React Start Vite/SSR client-RPC RawStream e2e: 6 passed
  • Full 17-scenario bundle matrix passed
  • Runtime allocation/destructure benchmark found no directional change
  • Five independent bundle, runtime, API, integration, and codegen reviews approved
Detailed artifacts and attribution are recorded in RESULT-optimization-frame-decoder-compact-result.md.
Summary by CodeRabbit
  • Refactor
    • Updated framed response handling with clearer stream and chunk naming.
    • Improved consistency in stream decoding interfaces without changing behavior.
    • Reduced the size of private frame decoder result keys.
  • Tests
    • Updated decoder coverage to use the revised stream and chunk terminology.
    • Existing test behavior and assertions remain unchanged.
@coderabbitai
coderabbitaiBot
commented
Aug 6, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Review Change Stack
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 045851a8-70eb-4673-b830-e1c3eeeb3482
📥 Commits
Reviewing files that changed from the base of the PR and between 7b62859 and b775949.
📒 Files selected for processing (1)
  • .changeset/kind-ghosts-win.md
📝 Walkthrough
Walkthrough
The frame decoder result API now exposes getStream and chunks. Server framed-response handling and decoder tests use the renamed properties. A Changeset records a patch release.
Changes
Frame decoder naming update
Layer / File(s)Summary
Rename decoder result properties
packages/start-client-core/src/client-rpc/frame-decoder.ts		FrameDecoderResult and createFrameDecoder now expose getStream and chunks.
Update response handling and tests
packages/start-client-core/src/client-rpc/serverFnFetcher.ts, packages/start-client-core/tests/frame-decoder.test.ts		Framed-response handling and decoder tests now consume the renamed properties. Aliases preserve existing local test names.
Record patch release
.changeset/kind-ghosts-win.md		The Changeset records a patch release for @tanstack/start-client-core.
Estimated code review effort: 1 (Trivial) | ~5 minutes
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly and concisely describes the main change: compacting private frame decoder result keys.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  •  Create PR with unit tests
  •  Commit unit tests in branch codex/frame-decoder-compact-result
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands.
@nx-cloud
nx-cloudBot
commented
Aug 6, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
View your CI Pipeline Execution ↗ for commit b775949
CommandStatusDurationResult
nx affected --targets=test:eslint,test:unit,tes...✅ Succeeded50m 9sView ↗
nx run-many --target=build --exclude=examples/*...✅ Succeeded1m 53sView ↗
☁️ Nx Cloud last updated this comment at 2026-08-07 13:08:41 UTC
@github-actions
github-actionsBot
commented
Aug 6, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
🚀 Changeset Version Preview
1 package(s) bumped directly, 13 bumped as dependents.
🟩 Patch bumps
PackageVersionReason
@tanstack/start-client-core1.170.18 → 1.170.19Changeset
@tanstack/react-start1.168.39 → 1.168.40Dependent
@tanstack/react-start-client1.168.20 → 1.168.21Dependent
@tanstack/react-start-rsc0.1.38 → 0.1.39Dependent
@tanstack/react-start-server1.167.27 → 1.167.28Dependent
@tanstack/solid-start1.168.38 → 1.168.39Dependent
@tanstack/solid-start-client1.168.20 → 1.168.21Dependent
@tanstack/solid-start-server1.167.27 → 1.167.28Dependent
@tanstack/start-plugin-core1.171.30 → 1.171.31Dependent
@tanstack/start-server-core1.169.22 → 1.169.23Dependent
@tanstack/start-static-server-functions1.167.23 → 1.167.24Dependent
@tanstack/vue-start1.168.37 → 1.168.38Dependent
@tanstack/vue-start-client1.167.23 → 1.167.24Dependent
@tanstack/vue-start-server1.167.27 → 1.167.28Dependent
@github-actions
github-actionsBot
commented
Aug 6, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Bundle Size Benchmarks
  • Commit: 27a6a68ba55a
  • Measured at: 2026-08-07T12:19:36.068Z
  • Baseline source: history:ea3a665d81cb
  • Dashboard: bundle-size history
The following scenarios have bundle-size changes compared with the baseline:
ScenarioCurrent (gzip)Delta vs baselineInitial gzipRawBrotliTrend
react-start.minimal100.39 KiB-8 B (-0.01%)100.25 KiB310.86 KiB87.16 KiB██▂▂▂▂▁▁▁▁▁▁
react-start.deferred-hydration101.13 KiB-9 B (-0.01%)100.28 KiB312.23 KiB87.87 KiB██▂▂▂▂▁▁▁▁▁▁
react-start.full103.75 KiB-3 B (-0.00%)103.61 KiB320.81 KiB90.16 KiB██▂▂▂▂▁▁▁▁▁▁
react-start.rsbuild.minimal99.98 KiB-8 B (-0.01%)99.81 KiB315.35 KiB86.25 KiB▁▁████▃▃▃▄▄▄
react-start.rsbuild.minimal-iife100.39 KiB-9 B (-0.01%)100.22 KiB316.28 KiB86.60 KiB▁▁████▃▃▃▄▄▄
react-start.rsbuild.full103.28 KiB-11 B (-0.01%)103.11 KiB325.44 KiB88.92 KiB▁▁██▇█▃▃▃▄▄▃
solid-start.minimal47.96 KiB-5 B (-0.01%)47.83 KiB140.63 KiB42.69 KiB██▂▂▂▂▁▁▁▁▁▁
solid-start.deferred-hydration51.23 KiB-4 B (-0.01%)47.89 KiB148.67 KiB45.66 KiB██▂▂▂▂▁▁▁▁▁▁
solid-start.full53.23 KiB-8 B (-0.01%)53.11 KiB156.35 KiB47.32 KiB██▂▂▂▂▁▁▁▁▁▁
vue-start.minimal68.64 KiB-5 B (-0.01%)68.51 KiB193.40 KiB61.10 KiB██▃▃▂▂▁▁▁▁▁▁
vue-start.full72.65 KiB-4 B (-0.01%)72.52 KiB205.90 KiB64.57 KiB██▂▂▂▂▁▁▁▁▁▁
Current gzip tracks all emitted client JS chunks. Initial gzip tracks only the entry/import graph. Trend sparkline is historical current gzip ending with this PR measurement; lower is better.
@pkg-pr-new
pkg-pr-newBot
commented
Aug 6, 2026•

edited

Loading

Copy link


Copy Markdown

More templates
@tanstack/arktype-adapter
npm i https://pkg.pr.new/@tanstack/arktype-adapter@7978

@tanstack/eslint-plugin-router
npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@7978

@tanstack/eslint-plugin-start
npm i https://pkg.pr.new/@tanstack/eslint-plugin-start@7978

@tanstack/history
npm i https://pkg.pr.new/@tanstack/history@7978

@tanstack/nitro-v2-vite-plugin
npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@7978

@tanstack/react-router
npm i https://pkg.pr.new/@tanstack/react-router@7978

@tanstack/react-router-devtools
npm i https://pkg.pr.new/@tanstack/react-router-devtools@7978

@tanstack/react-router-ssr-query
npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@7978

@tanstack/react-start
npm i https://pkg.pr.new/@tanstack/react-start@7978

@tanstack/react-start-client
npm i https://pkg.pr.new/@tanstack/react-start-client@7978

@tanstack/react-start-rsc
npm i https://pkg.pr.new/@tanstack/react-start-rsc@7978

@tanstack/react-start-server
npm i https://pkg.pr.new/@tanstack/react-start-server@7978

@tanstack/router-cli
npm i https://pkg.pr.new/@tanstack/router-cli@7978

@tanstack/router-core
npm i https://pkg.pr.new/@tanstack/router-core@7978

@tanstack/router-devtools
npm i https://pkg.pr.new/@tanstack/router-devtools@7978

@tanstack/router-devtools-core
npm i https://pkg.pr.new/@tanstack/router-devtools-core@7978

@tanstack/router-generator
npm i https://pkg.pr.new/@tanstack/router-generator@7978

@tanstack/router-plugin
npm i https://pkg.pr.new/@tanstack/router-plugin@7978

@tanstack/router-ssr-query-core
npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@7978

@tanstack/router-utils
npm i https://pkg.pr.new/@tanstack/router-utils@7978

@tanstack/router-vite-plugin
npm i https://pkg.pr.new/@tanstack/router-vite-plugin@7978

@tanstack/solid-router
npm i https://pkg.pr.new/@tanstack/solid-router@7978

@tanstack/solid-router-devtools
npm i https://pkg.pr.new/@tanstack/solid-router-devtools@7978

@tanstack/solid-router-ssr-query
npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@7978

@tanstack/solid-start
npm i https://pkg.pr.new/@tanstack/solid-start@7978

@tanstack/solid-start-client
npm i https://pkg.pr.new/@tanstack/solid-start-client@7978

@tanstack/solid-start-server
npm i https://pkg.pr.new/@tanstack/solid-start-server@7978

@tanstack/start-client-core
npm i https://pkg.pr.new/@tanstack/start-client-core@7978

@tanstack/start-fn-stubs
npm i https://pkg.pr.new/@tanstack/start-fn-stubs@7978

@tanstack/start-plugin-core
npm i https://pkg.pr.new/@tanstack/start-plugin-core@7978

@tanstack/start-server-core
npm i https://pkg.pr.new/@tanstack/start-server-core@7978

@tanstack/start-static-server-functions
npm i https://pkg.pr.new/@tanstack/start-static-server-functions@7978

@tanstack/start-storage-context
npm i https://pkg.pr.new/@tanstack/start-storage-context@7978

@tanstack/valibot-adapter
npm i https://pkg.pr.new/@tanstack/valibot-adapter@7978

@tanstack/virtual-file-routes
npm i https://pkg.pr.new/@tanstack/virtual-file-routes@7978

@tanstack/vue-router
npm i https://pkg.pr.new/@tanstack/vue-router@7978

@tanstack/vue-router-devtools
npm i https://pkg.pr.new/@tanstack/vue-router-devtools@7978

@tanstack/vue-router-ssr-query
npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@7978

@tanstack/vue-start
npm i https://pkg.pr.new/@tanstack/vue-start@7978

@tanstack/vue-start-client
npm i https://pkg.pr.new/@tanstack/vue-start-client@7978

@tanstack/vue-start-server
npm i https://pkg.pr.new/@tanstack/vue-start-server@7978

@tanstack/zod-adapter
npm i https://pkg.pr.new/@tanstack/zod-adapter@7978

commit: b775949
@codspeed-hq
codspeed-hqBot
commented
Aug 6, 2026•

edited

Loading

Copy link


Copy Markdown

Merging this PR will regress 5 benchmarks
⚠️Different runtime environments detected
Some benchmarks with significant performance changes were compared across different runtime environments,

which may affect the accuracy of the results.
Open the report in CodSpeed to investigate
⚡ 6 improved benchmarks
❌ 5 regressed benchmarks
✅ 169 untouched benchmarks
Warning
Please fix the performance issues or acknowledge them on CodSpeed.
Performance Changes
ModeBenchmarkBASEHEADEfficiency
❌Memorymem server error-paths not-found (vue)319.4 KB2,015.4 KB-84.15%
❌Memorymem client navigation-churn (vue)1.2 MB1.3 MB-5.56%
❌Memorymem server error-paths not-found (react)255.6 KB266.3 KB-4.02%
❌Memorymem server server-fn-churn (react)265 KB276.1 KB-4.02%
❌Memorymem client unique-location-churn (react)665.1 KB692.3 KB-3.92%
⚡Memorymem server server-fn-churn (vue)4,529.1 KB263.2 KB×17
⚡Memorymem server error-paths unmatched (solid)1,807.2 KB436.3 KB×4.1
⚡Memorymem server error-paths redirect (solid)523.7 KB277.8 KB+88.52%
⚡Memorymem server error-paths redirect (vue)370 KB294.2 KB+25.76%
⚡Simulationclient-history navigation loop (react)39.7 ms35.8 ms+10.95%
⚡Simulationssr request loop (solid)155.4 ms145.6 ms+6.75%
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing codex/frame-decoder-compact-result (b775949) with main (995bd97)
Open in CodSpeed
nx-cloud[bot]
nx-cloudBot
reviewed
Aug 6, 2026
View reviewed changes
@nx-cloudnx-cloudBot
left a comment
•

edited

Loading

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important
At least one additional CI pipeline execution has run since the conclusion below was written and it may no longer be applicable.
Nx Cloud has identified a possible root cause for your failed CI:
We classified this failure as an environment issue rather than a code change. The test failed with EADDRINUSE on port 32915, meaning another process had already claimed that port before the test's external server could start — unrelated to the PR's internal key renames in @tanstack/start-client-core. No port configuration or test infrastructure was modified by this PR.
No code changes were suggested for this issue.
Trigger a rerun:
Rerun CI
Nx Cloud View detailed reasoning on Nx Cloud ↗

🎓 Learn more about Self-Healing CI on nx.dev
@Sheraff
Sheraff
marked this pull request as ready for review
August 7, 2026 10:00
@Sheraff
Sheraff
merged commit 2fbc99f
into
mainAug 7, 2026

25 of 26 checks passed

@Sheraff
Sheraff
deleted the

codex/frame-decoder-compact-result

branch
August 7, 2026 13:18
@github-actionsgithub-actionsBot
mentioned this pull request
Aug 7, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@nx-cloudnx-cloud[bot]nx-cloud[bot] left review comments

Assignees


No one assigned


Labels

package: start-client-core

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@Sheraff