inline isServer for proper DCE - #7996

Merged
schiller-manuel merged 1 commit into
mainfrom
bundlesize-inline-isserver
Aug 8, 2026
Merged

inline isServer for proper DCE#7996
schiller-manuel merged 1 commit into
mainfrom
bundlesize-inline-isserver

Conversation

@schiller-manuel

@schiller-manuelschiller-manuel commented Aug 7, 2026•
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • Refactor
    • Improved server-side rendering compatibility and build-time optimization across React, Solid, and Vue routing.
    • Preserved existing server-rendered state handling and client-side behavior.

@coderabbitai

coderabbitaiBot commented Aug 7, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 98a923ef-ff84-4170-bfc7-8f502f80e433

📥 Commits

Reviewing files that changed from the base of the PR and between 4fa1df7 and 8c88574.

📒 Files selected for processing (4)
  • packages/react-router/src/link.tsx
  • packages/react-router/src/useRouterState.tsx
  • packages/solid-router/src/useRouterState.tsx
  • packages/vue-router/src/useRouterState.tsx
📝 Walkthrough

Walkthrough

The React, Solid, and Vue router implementations inline isServer ?? router.isServer in SSR conditions. Existing server state handling and client subscriptions remain unchanged. React Link includes comments for bundler dead-code elimination.

Changes

SSR detection

Layer / File(s)Summary
Inline server checks
packages/react-router/src/link.tsx, packages/react-router/src/useRouterState.tsx, packages/solid-router/src/useRouterState.tsx, packages/vue-router/src/useRouterState.tsx		SSR conditions now evaluate isServer ?? router.isServer inline. React Link documents the inline form required for bundler constant folding.

Estimated code review effort: 2 (Simple) | ~5 minutes

Suggested reviewers:sheraff

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly and concisely describes inlining isServer to enable proper dead-code elimination, which is the main change.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch bundlesize-inline-isserver

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@nx-cloud

nx-cloudBot commented Aug 7, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

View your CI Pipeline Execution ↗ for commit 5f744df

CommandStatusDurationResult
nx run-many --target=build --exclude=examples/*...✅ Succeeded2m 12sView ↗

☁️ Nx Cloud last updated this comment at 2026-08-08 00:12:04 UTC

@github-actions

github-actionsBot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

🚀 Changeset Version Preview

No changeset entries found. Merging this PR will not cause a version bump for any packages.

@pkg-pr-new

pkg-pr-newBot commented Aug 7, 2026•
edited
Loading

Copy link
Copy Markdown
More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/@tanstack/arktype-adapter@7996

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@7996

@tanstack/eslint-plugin-start

npm i https://pkg.pr.new/@tanstack/eslint-plugin-start@7996

@tanstack/history

npm i https://pkg.pr.new/@tanstack/history@7996

@tanstack/nitro-v2-vite-plugin

npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@7996

@tanstack/react-router

npm i https://pkg.pr.new/@tanstack/react-router@7996

@tanstack/react-router-devtools

npm i https://pkg.pr.new/@tanstack/react-router-devtools@7996

@tanstack/react-router-ssr-query

npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@7996

@tanstack/react-start

npm i https://pkg.pr.new/@tanstack/react-start@7996

@tanstack/react-start-client

npm i https://pkg.pr.new/@tanstack/react-start-client@7996

@tanstack/react-start-rsc

npm i https://pkg.pr.new/@tanstack/react-start-rsc@7996

@tanstack/react-start-server

npm i https://pkg.pr.new/@tanstack/react-start-server@7996

@tanstack/router-cli

npm i https://pkg.pr.new/@tanstack/router-cli@7996

@tanstack/router-core

npm i https://pkg.pr.new/@tanstack/router-core@7996

@tanstack/router-devtools

npm i https://pkg.pr.new/@tanstack/router-devtools@7996

@tanstack/router-devtools-core

npm i https://pkg.pr.new/@tanstack/router-devtools-core@7996

@tanstack/router-generator

npm i https://pkg.pr.new/@tanstack/router-generator@7996

@tanstack/router-plugin

npm i https://pkg.pr.new/@tanstack/router-plugin@7996

@tanstack/router-ssr-query-core

npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@7996

@tanstack/router-utils

npm i https://pkg.pr.new/@tanstack/router-utils@7996

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/@tanstack/router-vite-plugin@7996

@tanstack/solid-router

npm i https://pkg.pr.new/@tanstack/solid-router@7996

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/@tanstack/solid-router-devtools@7996

@tanstack/solid-router-ssr-query

npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@7996

@tanstack/solid-start

npm i https://pkg.pr.new/@tanstack/solid-start@7996

@tanstack/solid-start-client

npm i https://pkg.pr.new/@tanstack/solid-start-client@7996

@tanstack/solid-start-server

npm i https://pkg.pr.new/@tanstack/solid-start-server@7996

@tanstack/start-client-core

npm i https://pkg.pr.new/@tanstack/start-client-core@7996

@tanstack/start-fn-stubs

npm i https://pkg.pr.new/@tanstack/start-fn-stubs@7996

@tanstack/start-plugin-core

npm i https://pkg.pr.new/@tanstack/start-plugin-core@7996

@tanstack/start-server-core

npm i https://pkg.pr.new/@tanstack/start-server-core@7996

@tanstack/start-static-server-functions

npm i https://pkg.pr.new/@tanstack/start-static-server-functions@7996

@tanstack/start-storage-context

npm i https://pkg.pr.new/@tanstack/start-storage-context@7996

@tanstack/valibot-adapter

npm i https://pkg.pr.new/@tanstack/valibot-adapter@7996

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/@tanstack/virtual-file-routes@7996

@tanstack/vue-router

npm i https://pkg.pr.new/@tanstack/vue-router@7996

@tanstack/vue-router-devtools

npm i https://pkg.pr.new/@tanstack/vue-router-devtools@7996

@tanstack/vue-router-ssr-query

npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@7996

@tanstack/vue-start

npm i https://pkg.pr.new/@tanstack/vue-start@7996

@tanstack/vue-start-client

npm i https://pkg.pr.new/@tanstack/vue-start-client@7996

@tanstack/vue-start-server

npm i https://pkg.pr.new/@tanstack/vue-start-server@7996

@tanstack/zod-adapter

npm i https://pkg.pr.new/@tanstack/zod-adapter@7996

commit: 8c88574

@github-actions

github-actionsBot commented Aug 7, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

Bundle Size Benchmarks

This pull request does not affect bundle size in any measured scenario.

@codspeed-hq

codspeed-hqBot commented Aug 7, 2026•
edited
Loading

Copy link
Copy Markdown

Merging this PR will regress 5 benchmarks

⚠️Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 4 improved benchmarks
❌ 5 regressed benchmarks
✅ 171 untouched benchmarks

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

ModeBenchmarkBASEHEADEfficiency
❌Memorymem server error-paths not-found (solid)410.8 KB845.3 KB-51.4%
❌Memorymem client unique-location-churn (solid)341.6 KB566.6 KB-39.71%
❌Memorymem server error-paths redirect (vue)300.2 KB442.5 KB-32.16%
❌Memorymem server peak-large-page (solid)813.2 KB995.8 KB-18.34%
❌Memorymem client navigation-churn (solid)563.1 KB594 KB-5.2%
⚡Memorymem server server-fn-churn (vue)3,927.3 KB274.8 KB×14
⚡Memorymem server peak-large-page (react)2,064 KB952.8 KB×2.2
⚡Simulationssr request loop (solid)152.3 ms145.5 ms+4.66%
⚡Memorymem server error-paths not-found (vue)333 KB320.5 KB+3.92%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.

Comparing bundlesize-inline-isserver (8c88574) with main (4fa1df7)

Open in CodSpeed

@schiller-manuel
schiller-manuelforce-pushed the bundlesize-inline-isserver branch from a28b3d3 to 5f744dfCompareAugust 7, 2026 23:53
Base automatically changed from bundlesize-no-esbuild to mainAugust 8, 2026 00:04
@schiller-manuel
schiller-manuel requested a review from a team as a code ownerAugust 8, 2026 00:04
@schiller-manuel
schiller-manuelforce-pushed the bundlesize-inline-isserver branch from 5f744df to 8c88574CompareAugust 8, 2026 00:04
@schiller-manuel
schiller-manuel merged commit c568caf into mainAug 8, 2026
24 of 26 checks passed
@schiller-manuel
schiller-manuel deleted the bundlesize-inline-isserver branch August 8, 2026 07:55
@brenelzbrenelz mentioned this pull request Aug 13, 2026
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

package: react-routerpackage: solid-routerpackage: vue-router

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@schiller-manuel
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
inline isServer for proper DCE - #7996
Merged
schiller-manuel merged 1 commit into
mainfrom 
bundlesize-inline-isserver
Aug 8, 2026
Merged
inline isServer for proper DCE#7996
schiller-manuel merged 1 commit into
mainfrom 
bundlesize-inline-isserver
Conversation
@schiller-manuel
@schiller-manuelschiller-manuel
commented
Aug 7, 2026•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Collaborator
Summary by CodeRabbit
  • Refactor
    • Improved server-side rendering compatibility and build-time optimization across React, Solid, and Vue routing.
    • Preserved existing server-rendered state handling and client-side behavior.
@coderabbitai
coderabbitaiBot
commented
Aug 7, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Review Change Stack
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 98a923ef-ff84-4170-bfc7-8f502f80e433
📥 Commits
Reviewing files that changed from the base of the PR and between 4fa1df7 and 8c88574.
📒 Files selected for processing (4)
  • packages/react-router/src/link.tsx
  • packages/react-router/src/useRouterState.tsx
  • packages/solid-router/src/useRouterState.tsx
  • packages/vue-router/src/useRouterState.tsx
📝 Walkthrough
Walkthrough
The React, Solid, and Vue router implementations inline isServer ?? router.isServer in SSR conditions. Existing server state handling and client subscriptions remain unchanged. React Link includes comments for bundler dead-code elimination.
Changes
SSR detection
Layer / File(s)Summary
Inline server checks
packages/react-router/src/link.tsx, packages/react-router/src/useRouterState.tsx, packages/solid-router/src/useRouterState.tsx, packages/vue-router/src/useRouterState.tsx		SSR conditions now evaluate isServer ?? router.isServer inline. React Link documents the inline form required for bundler constant folding.
Estimated code review effort: 2 (Simple) | ~5 minutes
Suggested reviewers:sheraff
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly and concisely describes inlining isServer to enable proper dead-code elimination, which is the main change.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  •  Create stacked PR
  •  Commit on current branch
🧪 Generate unit tests (beta)
  •  Create PR with unit tests
  •  Commit unit tests in branch bundlesize-inline-isserver
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands.
@nx-cloud
nx-cloudBot
commented
Aug 7, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
View your CI Pipeline Execution ↗ for commit 5f744df
CommandStatusDurationResult
nx run-many --target=build --exclude=examples/*...✅ Succeeded2m 12sView ↗
☁️ Nx Cloud last updated this comment at 2026-08-08 00:12:04 UTC
@github-actions
github-actionsBot
commented
Aug 7, 2026

Copy link


Copy Markdown

Contributor
🚀 Changeset Version Preview
No changeset entries found. Merging this PR will not cause a version bump for any packages.
@pkg-pr-new
pkg-pr-newBot
commented
Aug 7, 2026•

edited

Loading

Copy link


Copy Markdown

More templates
@tanstack/arktype-adapter
npm i https://pkg.pr.new/@tanstack/arktype-adapter@7996

@tanstack/eslint-plugin-router
npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@7996

@tanstack/eslint-plugin-start
npm i https://pkg.pr.new/@tanstack/eslint-plugin-start@7996

@tanstack/history
npm i https://pkg.pr.new/@tanstack/history@7996

@tanstack/nitro-v2-vite-plugin
npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@7996

@tanstack/react-router
npm i https://pkg.pr.new/@tanstack/react-router@7996

@tanstack/react-router-devtools
npm i https://pkg.pr.new/@tanstack/react-router-devtools@7996

@tanstack/react-router-ssr-query
npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@7996

@tanstack/react-start
npm i https://pkg.pr.new/@tanstack/react-start@7996

@tanstack/react-start-client
npm i https://pkg.pr.new/@tanstack/react-start-client@7996

@tanstack/react-start-rsc
npm i https://pkg.pr.new/@tanstack/react-start-rsc@7996

@tanstack/react-start-server
npm i https://pkg.pr.new/@tanstack/react-start-server@7996

@tanstack/router-cli
npm i https://pkg.pr.new/@tanstack/router-cli@7996

@tanstack/router-core
npm i https://pkg.pr.new/@tanstack/router-core@7996

@tanstack/router-devtools
npm i https://pkg.pr.new/@tanstack/router-devtools@7996

@tanstack/router-devtools-core
npm i https://pkg.pr.new/@tanstack/router-devtools-core@7996

@tanstack/router-generator
npm i https://pkg.pr.new/@tanstack/router-generator@7996

@tanstack/router-plugin
npm i https://pkg.pr.new/@tanstack/router-plugin@7996

@tanstack/router-ssr-query-core
npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@7996

@tanstack/router-utils
npm i https://pkg.pr.new/@tanstack/router-utils@7996

@tanstack/router-vite-plugin
npm i https://pkg.pr.new/@tanstack/router-vite-plugin@7996

@tanstack/solid-router
npm i https://pkg.pr.new/@tanstack/solid-router@7996

@tanstack/solid-router-devtools
npm i https://pkg.pr.new/@tanstack/solid-router-devtools@7996

@tanstack/solid-router-ssr-query
npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@7996

@tanstack/solid-start
npm i https://pkg.pr.new/@tanstack/solid-start@7996

@tanstack/solid-start-client
npm i https://pkg.pr.new/@tanstack/solid-start-client@7996

@tanstack/solid-start-server
npm i https://pkg.pr.new/@tanstack/solid-start-server@7996

@tanstack/start-client-core
npm i https://pkg.pr.new/@tanstack/start-client-core@7996

@tanstack/start-fn-stubs
npm i https://pkg.pr.new/@tanstack/start-fn-stubs@7996

@tanstack/start-plugin-core
npm i https://pkg.pr.new/@tanstack/start-plugin-core@7996

@tanstack/start-server-core
npm i https://pkg.pr.new/@tanstack/start-server-core@7996

@tanstack/start-static-server-functions
npm i https://pkg.pr.new/@tanstack/start-static-server-functions@7996

@tanstack/start-storage-context
npm i https://pkg.pr.new/@tanstack/start-storage-context@7996

@tanstack/valibot-adapter
npm i https://pkg.pr.new/@tanstack/valibot-adapter@7996

@tanstack/virtual-file-routes
npm i https://pkg.pr.new/@tanstack/virtual-file-routes@7996

@tanstack/vue-router
npm i https://pkg.pr.new/@tanstack/vue-router@7996

@tanstack/vue-router-devtools
npm i https://pkg.pr.new/@tanstack/vue-router-devtools@7996

@tanstack/vue-router-ssr-query
npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@7996

@tanstack/vue-start
npm i https://pkg.pr.new/@tanstack/vue-start@7996

@tanstack/vue-start-client
npm i https://pkg.pr.new/@tanstack/vue-start-client@7996

@tanstack/vue-start-server
npm i https://pkg.pr.new/@tanstack/vue-start-server@7996

@tanstack/zod-adapter
npm i https://pkg.pr.new/@tanstack/zod-adapter@7996

commit: 8c88574
@github-actions
github-actionsBot
commented
Aug 7, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Bundle Size Benchmarks
This pull request does not affect bundle size in any measured scenario.
@codspeed-hq
codspeed-hqBot
commented
Aug 7, 2026•

edited

Loading

Copy link


Copy Markdown

Merging this PR will regress 5 benchmarks
⚠️Different runtime environments detected
Some benchmarks with significant performance changes were compared across different runtime environments,

which may affect the accuracy of the results.
Open the report in CodSpeed to investigate
⚡ 4 improved benchmarks
❌ 5 regressed benchmarks
✅ 171 untouched benchmarks
Warning
Please fix the performance issues or acknowledge them on CodSpeed.
Performance Changes
ModeBenchmarkBASEHEADEfficiency
❌Memorymem server error-paths not-found (solid)410.8 KB845.3 KB-51.4%
❌Memorymem client unique-location-churn (solid)341.6 KB566.6 KB-39.71%
❌Memorymem server error-paths redirect (vue)300.2 KB442.5 KB-32.16%
❌Memorymem server peak-large-page (solid)813.2 KB995.8 KB-18.34%
❌Memorymem client navigation-churn (solid)563.1 KB594 KB-5.2%
⚡Memorymem server server-fn-churn (vue)3,927.3 KB274.8 KB×14
⚡Memorymem server peak-large-page (react)2,064 KB952.8 KB×2.2
⚡Simulationssr request loop (solid)152.3 ms145.5 ms+4.66%
⚡Memorymem server error-paths not-found (vue)333 KB320.5 KB+3.92%
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing bundlesize-inline-isserver (8c88574) with main (4fa1df7)
Open in CodSpeed
@schiller-manuel
schiller-manuelforce-pushed
the
bundlesize-inline-isserver
branch
from
a28b3d3 to
5f744dfCompareAugust 7, 2026 23:53

Base automatically changed from
bundlesize-no-esbuild to
mainAugust 8, 2026 00:04
@schiller-manuel
schiller-manuel
requested a review
from a team
as a code ownerAugust 8, 2026 00:04
@schiller-manuel
schiller-manuelforce-pushed
the
bundlesize-inline-isserver
branch
from
5f744df to
8c88574CompareAugust 8, 2026 00:04
@schiller-manuel
schiller-manuel
merged commit c568caf
into
mainAug 8, 2026

24 of 26 checks passed

@schiller-manuel
schiller-manuel
deleted the

bundlesize-inline-isserver

branch
August 8, 2026 07:55
@brenelzbrenelz
mentioned this pull request
Aug 13, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

package: react-routerpackage: solid-routerpackage: vue-router

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@schiller-manuel

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
inline isServer for proper DCE - #7996
Merged
schiller-manuel merged 1 commit into
mainfrom 
bundlesize-inline-isserver
Aug 8, 2026
Merged
inline isServer for proper DCE#7996
schiller-manuel merged 1 commit into
mainfrom 
bundlesize-inline-isserver
Conversation
@schiller-manuel
@schiller-manuelschiller-manuel
commented
Aug 7, 2026•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Collaborator
Summary by CodeRabbit
  • Refactor
    • Improved server-side rendering compatibility and build-time optimization across React, Solid, and Vue routing.
    • Preserved existing server-rendered state handling and client-side behavior.
@coderabbitai
coderabbitaiBot
commented
Aug 7, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Review Change Stack
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 98a923ef-ff84-4170-bfc7-8f502f80e433
📥 Commits
Reviewing files that changed from the base of the PR and between 4fa1df7 and 8c88574.
📒 Files selected for processing (4)
  • packages/react-router/src/link.tsx
  • packages/react-router/src/useRouterState.tsx
  • packages/solid-router/src/useRouterState.tsx
  • packages/vue-router/src/useRouterState.tsx
📝 Walkthrough
Walkthrough
The React, Solid, and Vue router implementations inline isServer ?? router.isServer in SSR conditions. Existing server state handling and client subscriptions remain unchanged. React Link includes comments for bundler dead-code elimination.
Changes
SSR detection
Layer / File(s)Summary
Inline server checks
packages/react-router/src/link.tsx, packages/react-router/src/useRouterState.tsx, packages/solid-router/src/useRouterState.tsx, packages/vue-router/src/useRouterState.tsx		SSR conditions now evaluate isServer ?? router.isServer inline. React Link documents the inline form required for bundler constant folding.
Estimated code review effort: 2 (Simple) | ~5 minutes
Suggested reviewers:sheraff
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly and concisely describes inlining isServer to enable proper dead-code elimination, which is the main change.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  •  Create stacked PR
  •  Commit on current branch
🧪 Generate unit tests (beta)
  •  Create PR with unit tests
  •  Commit unit tests in branch bundlesize-inline-isserver
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands.
@nx-cloud
nx-cloudBot
commented
Aug 7, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
View your CI Pipeline Execution ↗ for commit 5f744df
CommandStatusDurationResult
nx run-many --target=build --exclude=examples/*...✅ Succeeded2m 12sView ↗
☁️ Nx Cloud last updated this comment at 2026-08-08 00:12:04 UTC
@github-actions
github-actionsBot
commented
Aug 7, 2026

Copy link


Copy Markdown

Contributor
🚀 Changeset Version Preview
No changeset entries found. Merging this PR will not cause a version bump for any packages.
@pkg-pr-new
pkg-pr-newBot
commented
Aug 7, 2026•

edited

Loading

Copy link


Copy Markdown

More templates
@tanstack/arktype-adapter
npm i https://pkg.pr.new/@tanstack/arktype-adapter@7996

@tanstack/eslint-plugin-router
npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@7996

@tanstack/eslint-plugin-start
npm i https://pkg.pr.new/@tanstack/eslint-plugin-start@7996

@tanstack/history
npm i https://pkg.pr.new/@tanstack/history@7996

@tanstack/nitro-v2-vite-plugin
npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@7996

@tanstack/react-router
npm i https://pkg.pr.new/@tanstack/react-router@7996

@tanstack/react-router-devtools
npm i https://pkg.pr.new/@tanstack/react-router-devtools@7996

@tanstack/react-router-ssr-query
npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@7996

@tanstack/react-start
npm i https://pkg.pr.new/@tanstack/react-start@7996

@tanstack/react-start-client
npm i https://pkg.pr.new/@tanstack/react-start-client@7996

@tanstack/react-start-rsc
npm i https://pkg.pr.new/@tanstack/react-start-rsc@7996

@tanstack/react-start-server
npm i https://pkg.pr.new/@tanstack/react-start-server@7996

@tanstack/router-cli
npm i https://pkg.pr.new/@tanstack/router-cli@7996

@tanstack/router-core
npm i https://pkg.pr.new/@tanstack/router-core@7996

@tanstack/router-devtools
npm i https://pkg.pr.new/@tanstack/router-devtools@7996

@tanstack/router-devtools-core
npm i https://pkg.pr.new/@tanstack/router-devtools-core@7996

@tanstack/router-generator
npm i https://pkg.pr.new/@tanstack/router-generator@7996

@tanstack/router-plugin
npm i https://pkg.pr.new/@tanstack/router-plugin@7996

@tanstack/router-ssr-query-core
npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@7996

@tanstack/router-utils
npm i https://pkg.pr.new/@tanstack/router-utils@7996

@tanstack/router-vite-plugin
npm i https://pkg.pr.new/@tanstack/router-vite-plugin@7996

@tanstack/solid-router
npm i https://pkg.pr.new/@tanstack/solid-router@7996

@tanstack/solid-router-devtools
npm i https://pkg.pr.new/@tanstack/solid-router-devtools@7996

@tanstack/solid-router-ssr-query
npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@7996

@tanstack/solid-start
npm i https://pkg.pr.new/@tanstack/solid-start@7996

@tanstack/solid-start-client
npm i https://pkg.pr.new/@tanstack/solid-start-client@7996

@tanstack/solid-start-server
npm i https://pkg.pr.new/@tanstack/solid-start-server@7996

@tanstack/start-client-core
npm i https://pkg.pr.new/@tanstack/start-client-core@7996

@tanstack/start-fn-stubs
npm i https://pkg.pr.new/@tanstack/start-fn-stubs@7996

@tanstack/start-plugin-core
npm i https://pkg.pr.new/@tanstack/start-plugin-core@7996

@tanstack/start-server-core
npm i https://pkg.pr.new/@tanstack/start-server-core@7996

@tanstack/start-static-server-functions
npm i https://pkg.pr.new/@tanstack/start-static-server-functions@7996

@tanstack/start-storage-context
npm i https://pkg.pr.new/@tanstack/start-storage-context@7996

@tanstack/valibot-adapter
npm i https://pkg.pr.new/@tanstack/valibot-adapter@7996

@tanstack/virtual-file-routes
npm i https://pkg.pr.new/@tanstack/virtual-file-routes@7996

@tanstack/vue-router
npm i https://pkg.pr.new/@tanstack/vue-router@7996

@tanstack/vue-router-devtools
npm i https://pkg.pr.new/@tanstack/vue-router-devtools@7996

@tanstack/vue-router-ssr-query
npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@7996

@tanstack/vue-start
npm i https://pkg.pr.new/@tanstack/vue-start@7996

@tanstack/vue-start-client
npm i https://pkg.pr.new/@tanstack/vue-start-client@7996

@tanstack/vue-start-server
npm i https://pkg.pr.new/@tanstack/vue-start-server@7996

@tanstack/zod-adapter
npm i https://pkg.pr.new/@tanstack/zod-adapter@7996

commit: 8c88574
@github-actions
github-actionsBot
commented
Aug 7, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Bundle Size Benchmarks
This pull request does not affect bundle size in any measured scenario.
@codspeed-hq
codspeed-hqBot
commented
Aug 7, 2026•

edited

Loading

Copy link


Copy Markdown

Merging this PR will regress 5 benchmarks
⚠️Different runtime environments detected
Some benchmarks with significant performance changes were compared across different runtime environments,

which may affect the accuracy of the results.
Open the report in CodSpeed to investigate
⚡ 4 improved benchmarks
❌ 5 regressed benchmarks
✅ 171 untouched benchmarks
Warning
Please fix the performance issues or acknowledge them on CodSpeed.
Performance Changes
ModeBenchmarkBASEHEADEfficiency
❌Memorymem server error-paths not-found (solid)410.8 KB845.3 KB-51.4%
❌Memorymem client unique-location-churn (solid)341.6 KB566.6 KB-39.71%
❌Memorymem server error-paths redirect (vue)300.2 KB442.5 KB-32.16%
❌Memorymem server peak-large-page (solid)813.2 KB995.8 KB-18.34%
❌Memorymem client navigation-churn (solid)563.1 KB594 KB-5.2%
⚡Memorymem server server-fn-churn (vue)3,927.3 KB274.8 KB×14
⚡Memorymem server peak-large-page (react)2,064 KB952.8 KB×2.2
⚡Simulationssr request loop (solid)152.3 ms145.5 ms+4.66%
⚡Memorymem server error-paths not-found (vue)333 KB320.5 KB+3.92%
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing bundlesize-inline-isserver (8c88574) with main (4fa1df7)
Open in CodSpeed
@schiller-manuel
schiller-manuelforce-pushed
the
bundlesize-inline-isserver
branch
from
a28b3d3 to
5f744dfCompareAugust 7, 2026 23:53

Base automatically changed from
bundlesize-no-esbuild to
mainAugust 8, 2026 00:04
@schiller-manuel
schiller-manuel
requested a review
from a team
as a code ownerAugust 8, 2026 00:04
@schiller-manuel
schiller-manuelforce-pushed
the
bundlesize-inline-isserver
branch
from
5f744df to
8c88574CompareAugust 8, 2026 00:04
@schiller-manuel
schiller-manuel
merged commit c568caf
into
mainAug 8, 2026

24 of 26 checks passed

@schiller-manuel
schiller-manuel
deleted the

bundlesize-inline-isserver

branch
August 8, 2026 07:55
@brenelzbrenelz
mentioned this pull request
Aug 13, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

package: react-routerpackage: solid-routerpackage: vue-router

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@schiller-manuel

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
inline isServer for proper DCE - #7996
Merged
schiller-manuel merged 1 commit into
mainfrom 
bundlesize-inline-isserver
Aug 8, 2026
Merged
inline isServer for proper DCE#7996
schiller-manuel merged 1 commit into
mainfrom 
bundlesize-inline-isserver
Conversation
@schiller-manuel
@schiller-manuelschiller-manuel
commented
Aug 7, 2026•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Collaborator
Summary by CodeRabbit
  • Refactor
    • Improved server-side rendering compatibility and build-time optimization across React, Solid, and Vue routing.
    • Preserved existing server-rendered state handling and client-side behavior.
@coderabbitai
coderabbitaiBot
commented
Aug 7, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Review Change Stack
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 98a923ef-ff84-4170-bfc7-8f502f80e433
📥 Commits
Reviewing files that changed from the base of the PR and between 4fa1df7 and 8c88574.
📒 Files selected for processing (4)
  • packages/react-router/src/link.tsx
  • packages/react-router/src/useRouterState.tsx
  • packages/solid-router/src/useRouterState.tsx
  • packages/vue-router/src/useRouterState.tsx
📝 Walkthrough
Walkthrough
The React, Solid, and Vue router implementations inline isServer ?? router.isServer in SSR conditions. Existing server state handling and client subscriptions remain unchanged. React Link includes comments for bundler dead-code elimination.
Changes
SSR detection
Layer / File(s)Summary
Inline server checks
packages/react-router/src/link.tsx, packages/react-router/src/useRouterState.tsx, packages/solid-router/src/useRouterState.tsx, packages/vue-router/src/useRouterState.tsx		SSR conditions now evaluate isServer ?? router.isServer inline. React Link documents the inline form required for bundler constant folding.
Estimated code review effort: 2 (Simple) | ~5 minutes
Suggested reviewers:sheraff
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly and concisely describes inlining isServer to enable proper dead-code elimination, which is the main change.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  •  Create stacked PR
  •  Commit on current branch
🧪 Generate unit tests (beta)
  •  Create PR with unit tests
  •  Commit unit tests in branch bundlesize-inline-isserver
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands.
@nx-cloud
nx-cloudBot
commented
Aug 7, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
View your CI Pipeline Execution ↗ for commit 5f744df
CommandStatusDurationResult
nx run-many --target=build --exclude=examples/*...✅ Succeeded2m 12sView ↗
☁️ Nx Cloud last updated this comment at 2026-08-08 00:12:04 UTC
@github-actions
github-actionsBot
commented
Aug 7, 2026

Copy link


Copy Markdown

Contributor
🚀 Changeset Version Preview
No changeset entries found. Merging this PR will not cause a version bump for any packages.
@pkg-pr-new
pkg-pr-newBot
commented
Aug 7, 2026•

edited

Loading

Copy link


Copy Markdown

More templates
@tanstack/arktype-adapter
npm i https://pkg.pr.new/@tanstack/arktype-adapter@7996

@tanstack/eslint-plugin-router
npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@7996

@tanstack/eslint-plugin-start
npm i https://pkg.pr.new/@tanstack/eslint-plugin-start@7996

@tanstack/history
npm i https://pkg.pr.new/@tanstack/history@7996

@tanstack/nitro-v2-vite-plugin
npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@7996

@tanstack/react-router
npm i https://pkg.pr.new/@tanstack/react-router@7996

@tanstack/react-router-devtools
npm i https://pkg.pr.new/@tanstack/react-router-devtools@7996

@tanstack/react-router-ssr-query
npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@7996

@tanstack/react-start
npm i https://pkg.pr.new/@tanstack/react-start@7996

@tanstack/react-start-client
npm i https://pkg.pr.new/@tanstack/react-start-client@7996

@tanstack/react-start-rsc
npm i https://pkg.pr.new/@tanstack/react-start-rsc@7996

@tanstack/react-start-server
npm i https://pkg.pr.new/@tanstack/react-start-server@7996

@tanstack/router-cli
npm i https://pkg.pr.new/@tanstack/router-cli@7996

@tanstack/router-core
npm i https://pkg.pr.new/@tanstack/router-core@7996

@tanstack/router-devtools
npm i https://pkg.pr.new/@tanstack/router-devtools@7996

@tanstack/router-devtools-core
npm i https://pkg.pr.new/@tanstack/router-devtools-core@7996

@tanstack/router-generator
npm i https://pkg.pr.new/@tanstack/router-generator@7996

@tanstack/router-plugin
npm i https://pkg.pr.new/@tanstack/router-plugin@7996

@tanstack/router-ssr-query-core
npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@7996

@tanstack/router-utils
npm i https://pkg.pr.new/@tanstack/router-utils@7996

@tanstack/router-vite-plugin
npm i https://pkg.pr.new/@tanstack/router-vite-plugin@7996

@tanstack/solid-router
npm i https://pkg.pr.new/@tanstack/solid-router@7996

@tanstack/solid-router-devtools
npm i https://pkg.pr.new/@tanstack/solid-router-devtools@7996

@tanstack/solid-router-ssr-query
npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@7996

@tanstack/solid-start
npm i https://pkg.pr.new/@tanstack/solid-start@7996

@tanstack/solid-start-client
npm i https://pkg.pr.new/@tanstack/solid-start-client@7996

@tanstack/solid-start-server
npm i https://pkg.pr.new/@tanstack/solid-start-server@7996

@tanstack/start-client-core
npm i https://pkg.pr.new/@tanstack/start-client-core@7996

@tanstack/start-fn-stubs
npm i https://pkg.pr.new/@tanstack/start-fn-stubs@7996

@tanstack/start-plugin-core
npm i https://pkg.pr.new/@tanstack/start-plugin-core@7996

@tanstack/start-server-core
npm i https://pkg.pr.new/@tanstack/start-server-core@7996

@tanstack/start-static-server-functions
npm i https://pkg.pr.new/@tanstack/start-static-server-functions@7996

@tanstack/start-storage-context
npm i https://pkg.pr.new/@tanstack/start-storage-context@7996

@tanstack/valibot-adapter
npm i https://pkg.pr.new/@tanstack/valibot-adapter@7996

@tanstack/virtual-file-routes
npm i https://pkg.pr.new/@tanstack/virtual-file-routes@7996

@tanstack/vue-router
npm i https://pkg.pr.new/@tanstack/vue-router@7996

@tanstack/vue-router-devtools
npm i https://pkg.pr.new/@tanstack/vue-router-devtools@7996

@tanstack/vue-router-ssr-query
npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@7996

@tanstack/vue-start
npm i https://pkg.pr.new/@tanstack/vue-start@7996

@tanstack/vue-start-client
npm i https://pkg.pr.new/@tanstack/vue-start-client@7996

@tanstack/vue-start-server
npm i https://pkg.pr.new/@tanstack/vue-start-server@7996

@tanstack/zod-adapter
npm i https://pkg.pr.new/@tanstack/zod-adapter@7996

commit: 8c88574
@github-actions
github-actionsBot
commented
Aug 7, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Bundle Size Benchmarks
This pull request does not affect bundle size in any measured scenario.
@codspeed-hq
codspeed-hqBot
commented
Aug 7, 2026•

edited

Loading

Copy link


Copy Markdown

Merging this PR will regress 5 benchmarks
⚠️Different runtime environments detected
Some benchmarks with significant performance changes were compared across different runtime environments,

which may affect the accuracy of the results.
Open the report in CodSpeed to investigate
⚡ 4 improved benchmarks
❌ 5 regressed benchmarks
✅ 171 untouched benchmarks
Warning
Please fix the performance issues or acknowledge them on CodSpeed.
Performance Changes
ModeBenchmarkBASEHEADEfficiency
❌Memorymem server error-paths not-found (solid)410.8 KB845.3 KB-51.4%
❌Memorymem client unique-location-churn (solid)341.6 KB566.6 KB-39.71%
❌Memorymem server error-paths redirect (vue)300.2 KB442.5 KB-32.16%
❌Memorymem server peak-large-page (solid)813.2 KB995.8 KB-18.34%
❌Memorymem client navigation-churn (solid)563.1 KB594 KB-5.2%
⚡Memorymem server server-fn-churn (vue)3,927.3 KB274.8 KB×14
⚡Memorymem server peak-large-page (react)2,064 KB952.8 KB×2.2
⚡Simulationssr request loop (solid)152.3 ms145.5 ms+4.66%
⚡Memorymem server error-paths not-found (vue)333 KB320.5 KB+3.92%
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing bundlesize-inline-isserver (8c88574) with main (4fa1df7)
Open in CodSpeed
@schiller-manuel
schiller-manuelforce-pushed
the
bundlesize-inline-isserver
branch
from
a28b3d3 to
5f744dfCompareAugust 7, 2026 23:53

Base automatically changed from
bundlesize-no-esbuild to
mainAugust 8, 2026 00:04
@schiller-manuel
schiller-manuel
requested a review
from a team
as a code ownerAugust 8, 2026 00:04
@schiller-manuel
schiller-manuelforce-pushed
the
bundlesize-inline-isserver
branch
from
5f744df to
8c88574CompareAugust 8, 2026 00:04
@schiller-manuel
schiller-manuel
merged commit c568caf
into
mainAug 8, 2026

24 of 26 checks passed

@schiller-manuel
schiller-manuel
deleted the

bundlesize-inline-isserver

branch
August 8, 2026 07:55
@brenelzbrenelz
mentioned this pull request
Aug 13, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

package: react-routerpackage: solid-routerpackage: vue-router

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@schiller-manuel

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
inline isServer for proper DCE - #7996
Merged
schiller-manuel merged 1 commit into
mainfrom 
bundlesize-inline-isserver
Aug 8, 2026
Merged
inline isServer for proper DCE#7996
schiller-manuel merged 1 commit into
mainfrom 
bundlesize-inline-isserver
Conversation
@schiller-manuel
@schiller-manuelschiller-manuel
commented
Aug 7, 2026•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Collaborator
Summary by CodeRabbit
  • Refactor
    • Improved server-side rendering compatibility and build-time optimization across React, Solid, and Vue routing.
    • Preserved existing server-rendered state handling and client-side behavior.
@coderabbitai
coderabbitaiBot
commented
Aug 7, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Review Change Stack
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 98a923ef-ff84-4170-bfc7-8f502f80e433
📥 Commits
Reviewing files that changed from the base of the PR and between 4fa1df7 and 8c88574.
📒 Files selected for processing (4)
  • packages/react-router/src/link.tsx
  • packages/react-router/src/useRouterState.tsx
  • packages/solid-router/src/useRouterState.tsx
  • packages/vue-router/src/useRouterState.tsx
📝 Walkthrough
Walkthrough
The React, Solid, and Vue router implementations inline isServer ?? router.isServer in SSR conditions. Existing server state handling and client subscriptions remain unchanged. React Link includes comments for bundler dead-code elimination.
Changes
SSR detection
Layer / File(s)Summary
Inline server checks
packages/react-router/src/link.tsx, packages/react-router/src/useRouterState.tsx, packages/solid-router/src/useRouterState.tsx, packages/vue-router/src/useRouterState.tsx		SSR conditions now evaluate isServer ?? router.isServer inline. React Link documents the inline form required for bundler constant folding.
Estimated code review effort: 2 (Simple) | ~5 minutes
Suggested reviewers:sheraff
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly and concisely describes inlining isServer to enable proper dead-code elimination, which is the main change.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  •  Create stacked PR
  •  Commit on current branch
🧪 Generate unit tests (beta)
  •  Create PR with unit tests
  •  Commit unit tests in branch bundlesize-inline-isserver
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands.
@nx-cloud
nx-cloudBot
commented
Aug 7, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
View your CI Pipeline Execution ↗ for commit 5f744df
CommandStatusDurationResult
nx run-many --target=build --exclude=examples/*...✅ Succeeded2m 12sView ↗
☁️ Nx Cloud last updated this comment at 2026-08-08 00:12:04 UTC
@github-actions
github-actionsBot
commented
Aug 7, 2026

Copy link


Copy Markdown

Contributor
🚀 Changeset Version Preview
No changeset entries found. Merging this PR will not cause a version bump for any packages.
@pkg-pr-new
pkg-pr-newBot
commented
Aug 7, 2026•

edited

Loading

Copy link


Copy Markdown

More templates
@tanstack/arktype-adapter
npm i https://pkg.pr.new/@tanstack/arktype-adapter@7996

@tanstack/eslint-plugin-router
npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@7996

@tanstack/eslint-plugin-start
npm i https://pkg.pr.new/@tanstack/eslint-plugin-start@7996

@tanstack/history
npm i https://pkg.pr.new/@tanstack/history@7996

@tanstack/nitro-v2-vite-plugin
npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@7996

@tanstack/react-router
npm i https://pkg.pr.new/@tanstack/react-router@7996

@tanstack/react-router-devtools
npm i https://pkg.pr.new/@tanstack/react-router-devtools@7996

@tanstack/react-router-ssr-query
npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@7996

@tanstack/react-start
npm i https://pkg.pr.new/@tanstack/react-start@7996

@tanstack/react-start-client
npm i https://pkg.pr.new/@tanstack/react-start-client@7996

@tanstack/react-start-rsc
npm i https://pkg.pr.new/@tanstack/react-start-rsc@7996

@tanstack/react-start-server
npm i https://pkg.pr.new/@tanstack/react-start-server@7996

@tanstack/router-cli
npm i https://pkg.pr.new/@tanstack/router-cli@7996

@tanstack/router-core
npm i https://pkg.pr.new/@tanstack/router-core@7996

@tanstack/router-devtools
npm i https://pkg.pr.new/@tanstack/router-devtools@7996

@tanstack/router-devtools-core
npm i https://pkg.pr.new/@tanstack/router-devtools-core@7996

@tanstack/router-generator
npm i https://pkg.pr.new/@tanstack/router-generator@7996

@tanstack/router-plugin
npm i https://pkg.pr.new/@tanstack/router-plugin@7996

@tanstack/router-ssr-query-core
npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@7996

@tanstack/router-utils
npm i https://pkg.pr.new/@tanstack/router-utils@7996

@tanstack/router-vite-plugin
npm i https://pkg.pr.new/@tanstack/router-vite-plugin@7996

@tanstack/solid-router
npm i https://pkg.pr.new/@tanstack/solid-router@7996

@tanstack/solid-router-devtools
npm i https://pkg.pr.new/@tanstack/solid-router-devtools@7996

@tanstack/solid-router-ssr-query
npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@7996

@tanstack/solid-start
npm i https://pkg.pr.new/@tanstack/solid-start@7996

@tanstack/solid-start-client
npm i https://pkg.pr.new/@tanstack/solid-start-client@7996

@tanstack/solid-start-server
npm i https://pkg.pr.new/@tanstack/solid-start-server@7996

@tanstack/start-client-core
npm i https://pkg.pr.new/@tanstack/start-client-core@7996

@tanstack/start-fn-stubs
npm i https://pkg.pr.new/@tanstack/start-fn-stubs@7996

@tanstack/start-plugin-core
npm i https://pkg.pr.new/@tanstack/start-plugin-core@7996

@tanstack/start-server-core
npm i https://pkg.pr.new/@tanstack/start-server-core@7996

@tanstack/start-static-server-functions
npm i https://pkg.pr.new/@tanstack/start-static-server-functions@7996

@tanstack/start-storage-context
npm i https://pkg.pr.new/@tanstack/start-storage-context@7996

@tanstack/valibot-adapter
npm i https://pkg.pr.new/@tanstack/valibot-adapter@7996

@tanstack/virtual-file-routes
npm i https://pkg.pr.new/@tanstack/virtual-file-routes@7996

@tanstack/vue-router
npm i https://pkg.pr.new/@tanstack/vue-router@7996

@tanstack/vue-router-devtools
npm i https://pkg.pr.new/@tanstack/vue-router-devtools@7996

@tanstack/vue-router-ssr-query
npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@7996

@tanstack/vue-start
npm i https://pkg.pr.new/@tanstack/vue-start@7996

@tanstack/vue-start-client
npm i https://pkg.pr.new/@tanstack/vue-start-client@7996

@tanstack/vue-start-server
npm i https://pkg.pr.new/@tanstack/vue-start-server@7996

@tanstack/zod-adapter
npm i https://pkg.pr.new/@tanstack/zod-adapter@7996

commit: 8c88574
@github-actions
github-actionsBot
commented
Aug 7, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Bundle Size Benchmarks
This pull request does not affect bundle size in any measured scenario.
@codspeed-hq
codspeed-hqBot
commented
Aug 7, 2026•

edited

Loading

Copy link


Copy Markdown

Merging this PR will regress 5 benchmarks
⚠️Different runtime environments detected
Some benchmarks with significant performance changes were compared across different runtime environments,

which may affect the accuracy of the results.
Open the report in CodSpeed to investigate
⚡ 4 improved benchmarks
❌ 5 regressed benchmarks
✅ 171 untouched benchmarks
Warning
Please fix the performance issues or acknowledge them on CodSpeed.
Performance Changes
ModeBenchmarkBASEHEADEfficiency
❌Memorymem server error-paths not-found (solid)410.8 KB845.3 KB-51.4%
❌Memorymem client unique-location-churn (solid)341.6 KB566.6 KB-39.71%
❌Memorymem server error-paths redirect (vue)300.2 KB442.5 KB-32.16%
❌Memorymem server peak-large-page (solid)813.2 KB995.8 KB-18.34%
❌Memorymem client navigation-churn (solid)563.1 KB594 KB-5.2%
⚡Memorymem server server-fn-churn (vue)3,927.3 KB274.8 KB×14
⚡Memorymem server peak-large-page (react)2,064 KB952.8 KB×2.2
⚡Simulationssr request loop (solid)152.3 ms145.5 ms+4.66%
⚡Memorymem server error-paths not-found (vue)333 KB320.5 KB+3.92%
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing bundlesize-inline-isserver (8c88574) with main (4fa1df7)
Open in CodSpeed
@schiller-manuel
schiller-manuelforce-pushed
the
bundlesize-inline-isserver
branch
from
a28b3d3 to
5f744dfCompareAugust 7, 2026 23:53

Base automatically changed from
bundlesize-no-esbuild to
mainAugust 8, 2026 00:04
@schiller-manuel
schiller-manuel
requested a review
from a team
as a code ownerAugust 8, 2026 00:04
@schiller-manuel
schiller-manuelforce-pushed
the
bundlesize-inline-isserver
branch
from
5f744df to
8c88574CompareAugust 8, 2026 00:04
@schiller-manuel
schiller-manuel
merged commit c568caf
into
mainAug 8, 2026

24 of 26 checks passed

@schiller-manuel
schiller-manuel
deleted the

bundlesize-inline-isserver

branch
August 8, 2026 07:55
@brenelzbrenelz
mentioned this pull request
Aug 13, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

package: react-routerpackage: solid-routerpackage: vue-router

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@schiller-manuel

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
inline isServer for proper DCE - #7996
Merged
schiller-manuel merged 1 commit into
mainfrom 
bundlesize-inline-isserver
Aug 8, 2026
Merged
inline isServer for proper DCE#7996
schiller-manuel merged 1 commit into
mainfrom 
bundlesize-inline-isserver
Conversation
@schiller-manuel
@schiller-manuelschiller-manuel
commented
Aug 7, 2026•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Collaborator
Summary by CodeRabbit
  • Refactor
    • Improved server-side rendering compatibility and build-time optimization across React, Solid, and Vue routing.
    • Preserved existing server-rendered state handling and client-side behavior.
@coderabbitai
coderabbitaiBot
commented
Aug 7, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Review Change Stack
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 98a923ef-ff84-4170-bfc7-8f502f80e433
📥 Commits
Reviewing files that changed from the base of the PR and between 4fa1df7 and 8c88574.
📒 Files selected for processing (4)
  • packages/react-router/src/link.tsx
  • packages/react-router/src/useRouterState.tsx
  • packages/solid-router/src/useRouterState.tsx
  • packages/vue-router/src/useRouterState.tsx
📝 Walkthrough
Walkthrough
The React, Solid, and Vue router implementations inline isServer ?? router.isServer in SSR conditions. Existing server state handling and client subscriptions remain unchanged. React Link includes comments for bundler dead-code elimination.
Changes
SSR detection
Layer / File(s)Summary
Inline server checks
packages/react-router/src/link.tsx, packages/react-router/src/useRouterState.tsx, packages/solid-router/src/useRouterState.tsx, packages/vue-router/src/useRouterState.tsx		SSR conditions now evaluate isServer ?? router.isServer inline. React Link documents the inline form required for bundler constant folding.
Estimated code review effort: 2 (Simple) | ~5 minutes
Suggested reviewers:sheraff
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly and concisely describes inlining isServer to enable proper dead-code elimination, which is the main change.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  •  Create stacked PR
  •  Commit on current branch
🧪 Generate unit tests (beta)
  •  Create PR with unit tests
  •  Commit unit tests in branch bundlesize-inline-isserver
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands.
@nx-cloud
nx-cloudBot
commented
Aug 7, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
View your CI Pipeline Execution ↗ for commit 5f744df
CommandStatusDurationResult
nx run-many --target=build --exclude=examples/*...✅ Succeeded2m 12sView ↗
☁️ Nx Cloud last updated this comment at 2026-08-08 00:12:04 UTC
@github-actions
github-actionsBot
commented
Aug 7, 2026

Copy link


Copy Markdown

Contributor
🚀 Changeset Version Preview
No changeset entries found. Merging this PR will not cause a version bump for any packages.
@pkg-pr-new
pkg-pr-newBot
commented
Aug 7, 2026•

edited

Loading

Copy link


Copy Markdown

More templates
@tanstack/arktype-adapter
npm i https://pkg.pr.new/@tanstack/arktype-adapter@7996

@tanstack/eslint-plugin-router
npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@7996

@tanstack/eslint-plugin-start
npm i https://pkg.pr.new/@tanstack/eslint-plugin-start@7996

@tanstack/history
npm i https://pkg.pr.new/@tanstack/history@7996

@tanstack/nitro-v2-vite-plugin
npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@7996

@tanstack/react-router
npm i https://pkg.pr.new/@tanstack/react-router@7996

@tanstack/react-router-devtools
npm i https://pkg.pr.new/@tanstack/react-router-devtools@7996

@tanstack/react-router-ssr-query
npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@7996

@tanstack/react-start
npm i https://pkg.pr.new/@tanstack/react-start@7996

@tanstack/react-start-client
npm i https://pkg.pr.new/@tanstack/react-start-client@7996

@tanstack/react-start-rsc
npm i https://pkg.pr.new/@tanstack/react-start-rsc@7996

@tanstack/react-start-server
npm i https://pkg.pr.new/@tanstack/react-start-server@7996

@tanstack/router-cli
npm i https://pkg.pr.new/@tanstack/router-cli@7996

@tanstack/router-core
npm i https://pkg.pr.new/@tanstack/router-core@7996

@tanstack/router-devtools
npm i https://pkg.pr.new/@tanstack/router-devtools@7996

@tanstack/router-devtools-core
npm i https://pkg.pr.new/@tanstack/router-devtools-core@7996

@tanstack/router-generator
npm i https://pkg.pr.new/@tanstack/router-generator@7996

@tanstack/router-plugin
npm i https://pkg.pr.new/@tanstack/router-plugin@7996

@tanstack/router-ssr-query-core
npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@7996

@tanstack/router-utils
npm i https://pkg.pr.new/@tanstack/router-utils@7996

@tanstack/router-vite-plugin
npm i https://pkg.pr.new/@tanstack/router-vite-plugin@7996

@tanstack/solid-router
npm i https://pkg.pr.new/@tanstack/solid-router@7996

@tanstack/solid-router-devtools
npm i https://pkg.pr.new/@tanstack/solid-router-devtools@7996

@tanstack/solid-router-ssr-query
npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@7996

@tanstack/solid-start
npm i https://pkg.pr.new/@tanstack/solid-start@7996

@tanstack/solid-start-client
npm i https://pkg.pr.new/@tanstack/solid-start-client@7996

@tanstack/solid-start-server
npm i https://pkg.pr.new/@tanstack/solid-start-server@7996

@tanstack/start-client-core
npm i https://pkg.pr.new/@tanstack/start-client-core@7996

@tanstack/start-fn-stubs
npm i https://pkg.pr.new/@tanstack/start-fn-stubs@7996

@tanstack/start-plugin-core
npm i https://pkg.pr.new/@tanstack/start-plugin-core@7996

@tanstack/start-server-core
npm i https://pkg.pr.new/@tanstack/start-server-core@7996

@tanstack/start-static-server-functions
npm i https://pkg.pr.new/@tanstack/start-static-server-functions@7996

@tanstack/start-storage-context
npm i https://pkg.pr.new/@tanstack/start-storage-context@7996

@tanstack/valibot-adapter
npm i https://pkg.pr.new/@tanstack/valibot-adapter@7996

@tanstack/virtual-file-routes
npm i https://pkg.pr.new/@tanstack/virtual-file-routes@7996

@tanstack/vue-router
npm i https://pkg.pr.new/@tanstack/vue-router@7996

@tanstack/vue-router-devtools
npm i https://pkg.pr.new/@tanstack/vue-router-devtools@7996

@tanstack/vue-router-ssr-query
npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@7996

@tanstack/vue-start
npm i https://pkg.pr.new/@tanstack/vue-start@7996

@tanstack/vue-start-client
npm i https://pkg.pr.new/@tanstack/vue-start-client@7996

@tanstack/vue-start-server
npm i https://pkg.pr.new/@tanstack/vue-start-server@7996

@tanstack/zod-adapter
npm i https://pkg.pr.new/@tanstack/zod-adapter@7996

commit: 8c88574
@github-actions
github-actionsBot
commented
Aug 7, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Bundle Size Benchmarks
This pull request does not affect bundle size in any measured scenario.
@codspeed-hq
codspeed-hqBot
commented
Aug 7, 2026•

edited

Loading

Copy link


Copy Markdown

Merging this PR will regress 5 benchmarks
⚠️Different runtime environments detected
Some benchmarks with significant performance changes were compared across different runtime environments,

which may affect the accuracy of the results.
Open the report in CodSpeed to investigate
⚡ 4 improved benchmarks
❌ 5 regressed benchmarks
✅ 171 untouched benchmarks
Warning
Please fix the performance issues or acknowledge them on CodSpeed.
Performance Changes
ModeBenchmarkBASEHEADEfficiency
❌Memorymem server error-paths not-found (solid)410.8 KB845.3 KB-51.4%
❌Memorymem client unique-location-churn (solid)341.6 KB566.6 KB-39.71%
❌Memorymem server error-paths redirect (vue)300.2 KB442.5 KB-32.16%
❌Memorymem server peak-large-page (solid)813.2 KB995.8 KB-18.34%
❌Memorymem client navigation-churn (solid)563.1 KB594 KB-5.2%
⚡Memorymem server server-fn-churn (vue)3,927.3 KB274.8 KB×14
⚡Memorymem server peak-large-page (react)2,064 KB952.8 KB×2.2
⚡Simulationssr request loop (solid)152.3 ms145.5 ms+4.66%
⚡Memorymem server error-paths not-found (vue)333 KB320.5 KB+3.92%
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing bundlesize-inline-isserver (8c88574) with main (4fa1df7)
Open in CodSpeed
@schiller-manuel
schiller-manuelforce-pushed
the
bundlesize-inline-isserver
branch
from
a28b3d3 to
5f744dfCompareAugust 7, 2026 23:53

Base automatically changed from
bundlesize-no-esbuild to
mainAugust 8, 2026 00:04
@schiller-manuel
schiller-manuel
requested a review
from a team
as a code ownerAugust 8, 2026 00:04
@schiller-manuel
schiller-manuelforce-pushed
the
bundlesize-inline-isserver
branch
from
5f744df to
8c88574CompareAugust 8, 2026 00:04
@schiller-manuel
schiller-manuel
merged commit c568caf
into
mainAug 8, 2026

24 of 26 checks passed

@schiller-manuel
schiller-manuel
deleted the

bundlesize-inline-isserver

branch
August 8, 2026 07:55
@brenelzbrenelz
mentioned this pull request
Aug 13, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

package: react-routerpackage: solid-routerpackage: vue-router

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@schiller-manuel

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
inline isServer for proper DCE - #7996
Merged
schiller-manuel merged 1 commit into
mainfrom 
bundlesize-inline-isserver
Aug 8, 2026
Merged
inline isServer for proper DCE#7996
schiller-manuel merged 1 commit into
mainfrom 
bundlesize-inline-isserver
Conversation
@schiller-manuel
@schiller-manuelschiller-manuel
commented
Aug 7, 2026•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Collaborator
Summary by CodeRabbit
  • Refactor
    • Improved server-side rendering compatibility and build-time optimization across React, Solid, and Vue routing.
    • Preserved existing server-rendered state handling and client-side behavior.
@coderabbitai
coderabbitaiBot
commented
Aug 7, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Review Change Stack
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 98a923ef-ff84-4170-bfc7-8f502f80e433
📥 Commits
Reviewing files that changed from the base of the PR and between 4fa1df7 and 8c88574.
📒 Files selected for processing (4)
  • packages/react-router/src/link.tsx
  • packages/react-router/src/useRouterState.tsx
  • packages/solid-router/src/useRouterState.tsx
  • packages/vue-router/src/useRouterState.tsx
📝 Walkthrough
Walkthrough
The React, Solid, and Vue router implementations inline isServer ?? router.isServer in SSR conditions. Existing server state handling and client subscriptions remain unchanged. React Link includes comments for bundler dead-code elimination.
Changes
SSR detection
Layer / File(s)Summary
Inline server checks
packages/react-router/src/link.tsx, packages/react-router/src/useRouterState.tsx, packages/solid-router/src/useRouterState.tsx, packages/vue-router/src/useRouterState.tsx		SSR conditions now evaluate isServer ?? router.isServer inline. React Link documents the inline form required for bundler constant folding.
Estimated code review effort: 2 (Simple) | ~5 minutes
Suggested reviewers:sheraff
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly and concisely describes inlining isServer to enable proper dead-code elimination, which is the main change.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  •  Create stacked PR
  •  Commit on current branch
🧪 Generate unit tests (beta)
  •  Create PR with unit tests
  •  Commit unit tests in branch bundlesize-inline-isserver
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands.
@nx-cloud
nx-cloudBot
commented
Aug 7, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
View your CI Pipeline Execution ↗ for commit 5f744df
CommandStatusDurationResult
nx run-many --target=build --exclude=examples/*...✅ Succeeded2m 12sView ↗
☁️ Nx Cloud last updated this comment at 2026-08-08 00:12:04 UTC
@github-actions
github-actionsBot
commented
Aug 7, 2026

Copy link


Copy Markdown

Contributor
🚀 Changeset Version Preview
No changeset entries found. Merging this PR will not cause a version bump for any packages.
@pkg-pr-new
pkg-pr-newBot
commented
Aug 7, 2026•

edited

Loading

Copy link


Copy Markdown

More templates
@tanstack/arktype-adapter
npm i https://pkg.pr.new/@tanstack/arktype-adapter@7996

@tanstack/eslint-plugin-router
npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@7996

@tanstack/eslint-plugin-start
npm i https://pkg.pr.new/@tanstack/eslint-plugin-start@7996

@tanstack/history
npm i https://pkg.pr.new/@tanstack/history@7996

@tanstack/nitro-v2-vite-plugin
npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@7996

@tanstack/react-router
npm i https://pkg.pr.new/@tanstack/react-router@7996

@tanstack/react-router-devtools
npm i https://pkg.pr.new/@tanstack/react-router-devtools@7996

@tanstack/react-router-ssr-query
npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@7996

@tanstack/react-start
npm i https://pkg.pr.new/@tanstack/react-start@7996

@tanstack/react-start-client
npm i https://pkg.pr.new/@tanstack/react-start-client@7996

@tanstack/react-start-rsc
npm i https://pkg.pr.new/@tanstack/react-start-rsc@7996

@tanstack/react-start-server
npm i https://pkg.pr.new/@tanstack/react-start-server@7996

@tanstack/router-cli
npm i https://pkg.pr.new/@tanstack/router-cli@7996

@tanstack/router-core
npm i https://pkg.pr.new/@tanstack/router-core@7996

@tanstack/router-devtools
npm i https://pkg.pr.new/@tanstack/router-devtools@7996

@tanstack/router-devtools-core
npm i https://pkg.pr.new/@tanstack/router-devtools-core@7996

@tanstack/router-generator
npm i https://pkg.pr.new/@tanstack/router-generator@7996

@tanstack/router-plugin
npm i https://pkg.pr.new/@tanstack/router-plugin@7996

@tanstack/router-ssr-query-core
npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@7996

@tanstack/router-utils
npm i https://pkg.pr.new/@tanstack/router-utils@7996

@tanstack/router-vite-plugin
npm i https://pkg.pr.new/@tanstack/router-vite-plugin@7996

@tanstack/solid-router
npm i https://pkg.pr.new/@tanstack/solid-router@7996

@tanstack/solid-router-devtools
npm i https://pkg.pr.new/@tanstack/solid-router-devtools@7996

@tanstack/solid-router-ssr-query
npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@7996

@tanstack/solid-start
npm i https://pkg.pr.new/@tanstack/solid-start@7996

@tanstack/solid-start-client
npm i https://pkg.pr.new/@tanstack/solid-start-client@7996

@tanstack/solid-start-server
npm i https://pkg.pr.new/@tanstack/solid-start-server@7996

@tanstack/start-client-core
npm i https://pkg.pr.new/@tanstack/start-client-core@7996

@tanstack/start-fn-stubs
npm i https://pkg.pr.new/@tanstack/start-fn-stubs@7996

@tanstack/start-plugin-core
npm i https://pkg.pr.new/@tanstack/start-plugin-core@7996

@tanstack/start-server-core
npm i https://pkg.pr.new/@tanstack/start-server-core@7996

@tanstack/start-static-server-functions
npm i https://pkg.pr.new/@tanstack/start-static-server-functions@7996

@tanstack/start-storage-context
npm i https://pkg.pr.new/@tanstack/start-storage-context@7996

@tanstack/valibot-adapter
npm i https://pkg.pr.new/@tanstack/valibot-adapter@7996

@tanstack/virtual-file-routes
npm i https://pkg.pr.new/@tanstack/virtual-file-routes@7996

@tanstack/vue-router
npm i https://pkg.pr.new/@tanstack/vue-router@7996

@tanstack/vue-router-devtools
npm i https://pkg.pr.new/@tanstack/vue-router-devtools@7996

@tanstack/vue-router-ssr-query
npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@7996

@tanstack/vue-start
npm i https://pkg.pr.new/@tanstack/vue-start@7996

@tanstack/vue-start-client
npm i https://pkg.pr.new/@tanstack/vue-start-client@7996

@tanstack/vue-start-server
npm i https://pkg.pr.new/@tanstack/vue-start-server@7996

@tanstack/zod-adapter
npm i https://pkg.pr.new/@tanstack/zod-adapter@7996

commit: 8c88574
@github-actions
github-actionsBot
commented
Aug 7, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Bundle Size Benchmarks
This pull request does not affect bundle size in any measured scenario.
@codspeed-hq
codspeed-hqBot
commented
Aug 7, 2026•

edited

Loading

Copy link


Copy Markdown

Merging this PR will regress 5 benchmarks
⚠️Different runtime environments detected
Some benchmarks with significant performance changes were compared across different runtime environments,

which may affect the accuracy of the results.
Open the report in CodSpeed to investigate
⚡ 4 improved benchmarks
❌ 5 regressed benchmarks
✅ 171 untouched benchmarks
Warning
Please fix the performance issues or acknowledge them on CodSpeed.
Performance Changes
ModeBenchmarkBASEHEADEfficiency
❌Memorymem server error-paths not-found (solid)410.8 KB845.3 KB-51.4%
❌Memorymem client unique-location-churn (solid)341.6 KB566.6 KB-39.71%
❌Memorymem server error-paths redirect (vue)300.2 KB442.5 KB-32.16%
❌Memorymem server peak-large-page (solid)813.2 KB995.8 KB-18.34%
❌Memorymem client navigation-churn (solid)563.1 KB594 KB-5.2%
⚡Memorymem server server-fn-churn (vue)3,927.3 KB274.8 KB×14
⚡Memorymem server peak-large-page (react)2,064 KB952.8 KB×2.2
⚡Simulationssr request loop (solid)152.3 ms145.5 ms+4.66%
⚡Memorymem server error-paths not-found (vue)333 KB320.5 KB+3.92%
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing bundlesize-inline-isserver (8c88574) with main (4fa1df7)
Open in CodSpeed
@schiller-manuel
schiller-manuelforce-pushed
the
bundlesize-inline-isserver
branch
from
a28b3d3 to
5f744dfCompareAugust 7, 2026 23:53

Base automatically changed from
bundlesize-no-esbuild to
mainAugust 8, 2026 00:04
@schiller-manuel
schiller-manuel
requested a review
from a team
as a code ownerAugust 8, 2026 00:04
@schiller-manuel
schiller-manuelforce-pushed
the
bundlesize-inline-isserver
branch
from
5f744df to
8c88574CompareAugust 8, 2026 00:04
@schiller-manuel
schiller-manuel
merged commit c568caf
into
mainAug 8, 2026

24 of 26 checks passed

@schiller-manuel
schiller-manuel
deleted the

bundlesize-inline-isserver

branch
August 8, 2026 07:55
@brenelzbrenelz
mentioned this pull request
Aug 13, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

package: react-routerpackage: solid-routerpackage: vue-router

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@schiller-manuel

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
inline isServer for proper DCE - #7996
Merged
schiller-manuel merged 1 commit into
mainfrom 
bundlesize-inline-isserver
Aug 8, 2026
Merged
inline isServer for proper DCE#7996
schiller-manuel merged 1 commit into
mainfrom 
bundlesize-inline-isserver
Conversation
@schiller-manuel
@schiller-manuelschiller-manuel
commented
Aug 7, 2026•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Collaborator
Summary by CodeRabbit
  • Refactor
    • Improved server-side rendering compatibility and build-time optimization across React, Solid, and Vue routing.
    • Preserved existing server-rendered state handling and client-side behavior.
@coderabbitai
coderabbitaiBot
commented
Aug 7, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Review Change Stack
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 98a923ef-ff84-4170-bfc7-8f502f80e433
📥 Commits
Reviewing files that changed from the base of the PR and between 4fa1df7 and 8c88574.
📒 Files selected for processing (4)
  • packages/react-router/src/link.tsx
  • packages/react-router/src/useRouterState.tsx
  • packages/solid-router/src/useRouterState.tsx
  • packages/vue-router/src/useRouterState.tsx
📝 Walkthrough
Walkthrough
The React, Solid, and Vue router implementations inline isServer ?? router.isServer in SSR conditions. Existing server state handling and client subscriptions remain unchanged. React Link includes comments for bundler dead-code elimination.
Changes
SSR detection
Layer / File(s)Summary
Inline server checks
packages/react-router/src/link.tsx, packages/react-router/src/useRouterState.tsx, packages/solid-router/src/useRouterState.tsx, packages/vue-router/src/useRouterState.tsx		SSR conditions now evaluate isServer ?? router.isServer inline. React Link documents the inline form required for bundler constant folding.
Estimated code review effort: 2 (Simple) | ~5 minutes
Suggested reviewers:sheraff
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly and concisely describes inlining isServer to enable proper dead-code elimination, which is the main change.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  •  Create stacked PR
  •  Commit on current branch
🧪 Generate unit tests (beta)
  •  Create PR with unit tests
  •  Commit unit tests in branch bundlesize-inline-isserver
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands.
@nx-cloud
nx-cloudBot
commented
Aug 7, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
View your CI Pipeline Execution ↗ for commit 5f744df
CommandStatusDurationResult
nx run-many --target=build --exclude=examples/*...✅ Succeeded2m 12sView ↗
☁️ Nx Cloud last updated this comment at 2026-08-08 00:12:04 UTC
@github-actions
github-actionsBot
commented
Aug 7, 2026

Copy link


Copy Markdown

Contributor
🚀 Changeset Version Preview
No changeset entries found. Merging this PR will not cause a version bump for any packages.
@pkg-pr-new
pkg-pr-newBot
commented
Aug 7, 2026•

edited

Loading

Copy link


Copy Markdown

More templates
@tanstack/arktype-adapter
npm i https://pkg.pr.new/@tanstack/arktype-adapter@7996

@tanstack/eslint-plugin-router
npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@7996

@tanstack/eslint-plugin-start
npm i https://pkg.pr.new/@tanstack/eslint-plugin-start@7996

@tanstack/history
npm i https://pkg.pr.new/@tanstack/history@7996

@tanstack/nitro-v2-vite-plugin
npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@7996

@tanstack/react-router
npm i https://pkg.pr.new/@tanstack/react-router@7996

@tanstack/react-router-devtools
npm i https://pkg.pr.new/@tanstack/react-router-devtools@7996

@tanstack/react-router-ssr-query
npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@7996

@tanstack/react-start
npm i https://pkg.pr.new/@tanstack/react-start@7996

@tanstack/react-start-client
npm i https://pkg.pr.new/@tanstack/react-start-client@7996

@tanstack/react-start-rsc
npm i https://pkg.pr.new/@tanstack/react-start-rsc@7996

@tanstack/react-start-server
npm i https://pkg.pr.new/@tanstack/react-start-server@7996

@tanstack/router-cli
npm i https://pkg.pr.new/@tanstack/router-cli@7996

@tanstack/router-core
npm i https://pkg.pr.new/@tanstack/router-core@7996

@tanstack/router-devtools
npm i https://pkg.pr.new/@tanstack/router-devtools@7996

@tanstack/router-devtools-core
npm i https://pkg.pr.new/@tanstack/router-devtools-core@7996

@tanstack/router-generator
npm i https://pkg.pr.new/@tanstack/router-generator@7996

@tanstack/router-plugin
npm i https://pkg.pr.new/@tanstack/router-plugin@7996

@tanstack/router-ssr-query-core
npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@7996

@tanstack/router-utils
npm i https://pkg.pr.new/@tanstack/router-utils@7996

@tanstack/router-vite-plugin
npm i https://pkg.pr.new/@tanstack/router-vite-plugin@7996

@tanstack/solid-router
npm i https://pkg.pr.new/@tanstack/solid-router@7996

@tanstack/solid-router-devtools
npm i https://pkg.pr.new/@tanstack/solid-router-devtools@7996

@tanstack/solid-router-ssr-query
npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@7996

@tanstack/solid-start
npm i https://pkg.pr.new/@tanstack/solid-start@7996

@tanstack/solid-start-client
npm i https://pkg.pr.new/@tanstack/solid-start-client@7996

@tanstack/solid-start-server
npm i https://pkg.pr.new/@tanstack/solid-start-server@7996

@tanstack/start-client-core
npm i https://pkg.pr.new/@tanstack/start-client-core@7996

@tanstack/start-fn-stubs
npm i https://pkg.pr.new/@tanstack/start-fn-stubs@7996

@tanstack/start-plugin-core
npm i https://pkg.pr.new/@tanstack/start-plugin-core@7996

@tanstack/start-server-core
npm i https://pkg.pr.new/@tanstack/start-server-core@7996

@tanstack/start-static-server-functions
npm i https://pkg.pr.new/@tanstack/start-static-server-functions@7996

@tanstack/start-storage-context
npm i https://pkg.pr.new/@tanstack/start-storage-context@7996

@tanstack/valibot-adapter
npm i https://pkg.pr.new/@tanstack/valibot-adapter@7996

@tanstack/virtual-file-routes
npm i https://pkg.pr.new/@tanstack/virtual-file-routes@7996

@tanstack/vue-router
npm i https://pkg.pr.new/@tanstack/vue-router@7996

@tanstack/vue-router-devtools
npm i https://pkg.pr.new/@tanstack/vue-router-devtools@7996

@tanstack/vue-router-ssr-query
npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@7996

@tanstack/vue-start
npm i https://pkg.pr.new/@tanstack/vue-start@7996

@tanstack/vue-start-client
npm i https://pkg.pr.new/@tanstack/vue-start-client@7996

@tanstack/vue-start-server
npm i https://pkg.pr.new/@tanstack/vue-start-server@7996

@tanstack/zod-adapter
npm i https://pkg.pr.new/@tanstack/zod-adapter@7996

commit: 8c88574
@github-actions
github-actionsBot
commented
Aug 7, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Bundle Size Benchmarks
This pull request does not affect bundle size in any measured scenario.
@codspeed-hq
codspeed-hqBot
commented
Aug 7, 2026•

edited

Loading

Copy link


Copy Markdown

Merging this PR will regress 5 benchmarks
⚠️Different runtime environments detected
Some benchmarks with significant performance changes were compared across different runtime environments,

which may affect the accuracy of the results.
Open the report in CodSpeed to investigate
⚡ 4 improved benchmarks
❌ 5 regressed benchmarks
✅ 171 untouched benchmarks
Warning
Please fix the performance issues or acknowledge them on CodSpeed.
Performance Changes
ModeBenchmarkBASEHEADEfficiency
❌Memorymem server error-paths not-found (solid)410.8 KB845.3 KB-51.4%
❌Memorymem client unique-location-churn (solid)341.6 KB566.6 KB-39.71%
❌Memorymem server error-paths redirect (vue)300.2 KB442.5 KB-32.16%
❌Memorymem server peak-large-page (solid)813.2 KB995.8 KB-18.34%
❌Memorymem client navigation-churn (solid)563.1 KB594 KB-5.2%
⚡Memorymem server server-fn-churn (vue)3,927.3 KB274.8 KB×14
⚡Memorymem server peak-large-page (react)2,064 KB952.8 KB×2.2
⚡Simulationssr request loop (solid)152.3 ms145.5 ms+4.66%
⚡Memorymem server error-paths not-found (vue)333 KB320.5 KB+3.92%
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing bundlesize-inline-isserver (8c88574) with main (4fa1df7)
Open in CodSpeed
@schiller-manuel
schiller-manuelforce-pushed
the
bundlesize-inline-isserver
branch
from
a28b3d3 to
5f744dfCompareAugust 7, 2026 23:53

Base automatically changed from
bundlesize-no-esbuild to
mainAugust 8, 2026 00:04
@schiller-manuel
schiller-manuel
requested a review
from a team
as a code ownerAugust 8, 2026 00:04
@schiller-manuel
schiller-manuelforce-pushed
the
bundlesize-inline-isserver
branch
from
5f744df to
8c88574CompareAugust 8, 2026 00:04
@schiller-manuel
schiller-manuel
merged commit c568caf
into
mainAug 8, 2026

24 of 26 checks passed

@schiller-manuel
schiller-manuel
deleted the

bundlesize-inline-isserver

branch
August 8, 2026 07:55
@brenelzbrenelz
mentioned this pull request
Aug 13, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

package: react-routerpackage: solid-routerpackage: vue-router

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@schiller-manuel