perf(router-core): optimize server search serialization - #8012

Draft
Sheraff wants to merge 1 commit into
mainfrom
codex/server-search-serialization
Draft

perf(router-core): optimize server search serialization#8012
Sheraff wants to merge 1 commit into
mainfrom
codex/server-search-serialization

Conversation

@Sheraff

@SheraffSheraff commented Aug 8, 2026

Copy link
Copy Markdown
Collaborator

What changed

  • Select a dedicated default search serializer behind the existing isServer conditional export.
  • Classify JSON primitives with an allocation-free scanner on the server, avoiding exception-heavy JSON.parse calls for impossible JSON and bypassing parsing for fully validated primitives.
  • Continue using the native parser for quoted strings, arrays, objects, and whitespace-prefixed values.
  • Preserve the compact perf(router-core): skip impossible JSON parse attempts #8006 client implementation and the existing path for custom parsers.
  • Add server-specific parity tests and focused performance benchmarks.

The environment check intentionally remains at serializer invocation time. The server isServer export also loads router code, so reading it while the serializer factory initializes can encounter the isServer -> load-server -> router -> searchParams module cycle.

Why

#8006 keeps the client fast path compact because every byte matters there. Server builds can dead-code-eliminate a larger implementation, allowing exact primitive validation and avoiding costly parser exceptions without increasing client bundles.

Performance

Measured with the same Vitest benchmark file against the exact merged #8006 implementation:

  • ordinary application strings: ~2.5% faster
  • realistic application distribution: ~6% faster
  • JSON primitive strings: ~26% faster
  • invalid number-like strings: ~54x faster
  • JSON-literal-prefix misses: ~47-53x faster

Inputs that still require the native parser remain within single-digit percentages of the baseline, and whitespace-prefixed structured inputs no longer have a length-amplifying double-scan regression.

The full 17-scenario client bundle matrix is byte-for-byte unchanged: zero delta for raw, gzip, Brotli, and initial gzip sizes.

Validation

  • @tanstack/router-core:test:unit: 106 files passed; 1,616 tests passed and 3 expected failures
  • @tanstack/router-core:test:types: TypeScript 5.6 through 7.0 passed
  • @tanstack/router-core:test:eslint: 0 errors
  • focused server Vitest benchmarks against the exact perf(router-core): skip impossible JSON parse attempts #8006 baseline
  • full bundle-size benchmark across all 17 scenarios

@coderabbitai

coderabbitaiBot commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 4ebbe526-aa87-441b-8d0b-166ee51d908c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@nx-cloud

nx-cloudBot commented Aug 8, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

View your CI Pipeline Execution ↗ for commit 0ae9eb0

CommandStatusDurationResult
nx affected --targets=test:eslint,test:unit,tes...✅ Succeeded10m 23sView ↗
nx run-many --target=build --exclude=examples/*...✅ Succeeded2m 14sView ↗

☁️ Nx Cloud last updated this comment at 2026-08-08 17:58:29 UTC

@github-actions

github-actionsBot commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

🚀 Changeset Version Preview

2 package(s) bumped directly, 21 bumped as dependents.

🟩 Patch bumps

PackageVersionReason
@tanstack/router-core1.171.19 → 1.171.20Changeset
@tanstack/start-client-core1.170.19 → 1.170.20Changeset
@tanstack/react-router1.170.23 → 1.170.24Dependent
@tanstack/react-start1.168.40 → 1.168.41Dependent
@tanstack/react-start-client1.168.21 → 1.168.22Dependent
@tanstack/react-start-rsc0.1.39 → 0.1.40Dependent
@tanstack/react-start-server1.167.28 → 1.167.29Dependent
@tanstack/router-cli1.167.25 → 1.167.26Dependent
@tanstack/router-generator1.167.25 → 1.167.26Dependent
@tanstack/router-plugin1.168.27 → 1.168.28Dependent
@tanstack/router-vite-plugin1.167.27 → 1.167.28Dependent
@tanstack/solid-router1.170.22 → 1.170.23Dependent
@tanstack/solid-start1.168.39 → 1.168.40Dependent
@tanstack/solid-start-client1.168.21 → 1.168.22Dependent
@tanstack/solid-start-server1.167.28 → 1.167.29Dependent
@tanstack/start-plugin-core1.171.31 → 1.171.32Dependent
@tanstack/start-server-core1.169.23 → 1.169.24Dependent
@tanstack/start-static-server-functions1.167.24 → 1.167.25Dependent
@tanstack/start-storage-context1.167.21 → 1.167.22Dependent
@tanstack/vue-router1.170.21 → 1.170.22Dependent
@tanstack/vue-start1.168.38 → 1.168.39Dependent
@tanstack/vue-start-client1.167.24 → 1.167.25Dependent
@tanstack/vue-start-server1.167.28 → 1.167.29Dependent

@github-actions

github-actionsBot commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

Bundle Size Benchmarks

This pull request does not affect bundle size in any measured scenario.

@pkg-pr-new

pkg-pr-newBot commented Aug 8, 2026

Copy link
Copy Markdown
More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/@tanstack/arktype-adapter@8012

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@8012

@tanstack/eslint-plugin-start

npm i https://pkg.pr.new/@tanstack/eslint-plugin-start@8012

@tanstack/history

npm i https://pkg.pr.new/@tanstack/history@8012

@tanstack/nitro-v2-vite-plugin

npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@8012

@tanstack/react-router

npm i https://pkg.pr.new/@tanstack/react-router@8012

@tanstack/react-router-devtools

npm i https://pkg.pr.new/@tanstack/react-router-devtools@8012

@tanstack/react-router-ssr-query

npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@8012

@tanstack/react-start

npm i https://pkg.pr.new/@tanstack/react-start@8012

@tanstack/react-start-client

npm i https://pkg.pr.new/@tanstack/react-start-client@8012

@tanstack/react-start-rsc

npm i https://pkg.pr.new/@tanstack/react-start-rsc@8012

@tanstack/react-start-server

npm i https://pkg.pr.new/@tanstack/react-start-server@8012

@tanstack/router-cli

npm i https://pkg.pr.new/@tanstack/router-cli@8012

@tanstack/router-core

npm i https://pkg.pr.new/@tanstack/router-core@8012

@tanstack/router-devtools

npm i https://pkg.pr.new/@tanstack/router-devtools@8012

@tanstack/router-devtools-core

npm i https://pkg.pr.new/@tanstack/router-devtools-core@8012

@tanstack/router-generator

npm i https://pkg.pr.new/@tanstack/router-generator@8012

@tanstack/router-plugin

npm i https://pkg.pr.new/@tanstack/router-plugin@8012

@tanstack/router-ssr-query-core

npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@8012

@tanstack/router-utils

npm i https://pkg.pr.new/@tanstack/router-utils@8012

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/@tanstack/router-vite-plugin@8012

@tanstack/solid-router

npm i https://pkg.pr.new/@tanstack/solid-router@8012

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/@tanstack/solid-router-devtools@8012

@tanstack/solid-router-ssr-query

npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@8012

@tanstack/solid-start

npm i https://pkg.pr.new/@tanstack/solid-start@8012

@tanstack/solid-start-client

npm i https://pkg.pr.new/@tanstack/solid-start-client@8012

@tanstack/solid-start-server

npm i https://pkg.pr.new/@tanstack/solid-start-server@8012

@tanstack/start-client-core

npm i https://pkg.pr.new/@tanstack/start-client-core@8012

@tanstack/start-fn-stubs

npm i https://pkg.pr.new/@tanstack/start-fn-stubs@8012

@tanstack/start-plugin-core

npm i https://pkg.pr.new/@tanstack/start-plugin-core@8012

@tanstack/start-server-core

npm i https://pkg.pr.new/@tanstack/start-server-core@8012

@tanstack/start-static-server-functions

npm i https://pkg.pr.new/@tanstack/start-static-server-functions@8012

@tanstack/start-storage-context

npm i https://pkg.pr.new/@tanstack/start-storage-context@8012

@tanstack/valibot-adapter

npm i https://pkg.pr.new/@tanstack/valibot-adapter@8012

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/@tanstack/virtual-file-routes@8012

@tanstack/vue-router

npm i https://pkg.pr.new/@tanstack/vue-router@8012

@tanstack/vue-router-devtools

npm i https://pkg.pr.new/@tanstack/vue-router-devtools@8012

@tanstack/vue-router-ssr-query

npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@8012

@tanstack/vue-start

npm i https://pkg.pr.new/@tanstack/vue-start@8012

@tanstack/vue-start-client

npm i https://pkg.pr.new/@tanstack/vue-start-client@8012

@tanstack/vue-start-server

npm i https://pkg.pr.new/@tanstack/vue-start-server@8012

@tanstack/zod-adapter

npm i https://pkg.pr.new/@tanstack/zod-adapter@8012

commit: 0ae9eb0

@codspeed-hq

codspeed-hqBot commented Aug 8, 2026

Copy link
Copy Markdown

Merging this PR will degrade performance by 0.08%

⚠️Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 6 improved benchmarks
❌ 3 regressed benchmarks
✅ 171 untouched benchmarks

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

ModeBenchmarkBASEHEADEfficiency
❌Memorymem server error-paths redirect (vue)433.1 KB904.6 KB-52.13%
❌Memorymem server error-paths unmatched (solid)428.5 KB454.6 KB-5.75%
❌Memorymem server server-fn-churn (react)264.7 KB276.7 KB-4.31%
⚡Memorymem server error-paths not-found (solid)728.6 KB418.6 KB+74.03%
⚡Memorymem client preload-churn (vue)805.5 KB736.9 KB+9.32%
⚡Memorymem client navigation-churn (solid)575 KB528.4 KB+8.83%
⚡Simulationssr dehydrate rich types (solid)99.7 ms95.9 ms+4.01%
⚡Memorymem server error-paths unmatched (react)272.3 KB263.2 KB+3.48%
⚡Memorymem client unique-location-churn (solid)352.4 KB341.5 KB+3.18%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.

Comparing codex/server-search-serialization (0ae9eb0) with main (44a8c3e)

Open in CodSpeed

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

package: router-core

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Sheraff
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
perf(router-core): optimize server search serialization - #8012
Draft
Sheraff wants to merge 1 commit into
mainfrom 
codex/server-search-serialization
Draft
perf(router-core): optimize server search serialization#8012
Sheraff wants to merge 1 commit into
mainfrom 
codex/server-search-serialization
Conversation
@Sheraff
@SheraffSheraff
commented
Aug 8, 2026

Copy link


Copy Markdown

Collaborator
What changed
  • Select a dedicated default search serializer behind the existing isServer conditional export.
  • Classify JSON primitives with an allocation-free scanner on the server, avoiding exception-heavy JSON.parse calls for impossible JSON and bypassing parsing for fully validated primitives.
  • Continue using the native parser for quoted strings, arrays, objects, and whitespace-prefixed values.
  • Preserve the compact perf(router-core): skip impossible JSON parse attempts #8006 client implementation and the existing path for custom parsers.
  • Add server-specific parity tests and focused performance benchmarks.
The environment check intentionally remains at serializer invocation time. The server isServer export also loads router code, so reading it while the serializer factory initializes can encounter the isServer -> load-server -> router -> searchParams module cycle.
Why
#8006 keeps the client fast path compact because every byte matters there. Server builds can dead-code-eliminate a larger implementation, allowing exact primitive validation and avoiding costly parser exceptions without increasing client bundles.
Performance
Measured with the same Vitest benchmark file against the exact merged #8006 implementation:
  • ordinary application strings: ~2.5% faster
  • realistic application distribution: ~6% faster
  • JSON primitive strings: ~26% faster
  • invalid number-like strings: ~54x faster
  • JSON-literal-prefix misses: ~47-53x faster
Inputs that still require the native parser remain within single-digit percentages of the baseline, and whitespace-prefixed structured inputs no longer have a length-amplifying double-scan regression.
The full 17-scenario client bundle matrix is byte-for-byte unchanged: zero delta for raw, gzip, Brotli, and initial gzip sizes.
Validation
  • @tanstack/router-core:test:unit: 106 files passed; 1,616 tests passed and 3 expected failures
  • @tanstack/router-core:test:types: TypeScript 5.6 through 7.0 passed
  • @tanstack/router-core:test:eslint: 0 errors
  • focused server Vitest benchmarks against the exact perf(router-core): skip impossible JSON parse attempts #8006 baseline
  • full bundle-size benchmark across all 17 scenarios
@coderabbitai
coderabbitaiBot
commented
Aug 8, 2026

Copy link


Copy Markdown

Contributor
Important
Review skipped
Draft detected.
Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 4ebbe526-aa87-441b-8d0b-166ee51d908c
You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.
Use the checkbox below for a quick retry:
  •  🔍 Trigger review
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands.
@nx-cloud
nx-cloudBot
commented
Aug 8, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
View your CI Pipeline Execution ↗ for commit 0ae9eb0
CommandStatusDurationResult
nx affected --targets=test:eslint,test:unit,tes...✅ Succeeded10m 23sView ↗
nx run-many --target=build --exclude=examples/*...✅ Succeeded2m 14sView ↗
☁️ Nx Cloud last updated this comment at 2026-08-08 17:58:29 UTC
@github-actions
github-actionsBot
commented
Aug 8, 2026

Copy link


Copy Markdown

Contributor
🚀 Changeset Version Preview
2 package(s) bumped directly, 21 bumped as dependents.
🟩 Patch bumps
PackageVersionReason
@tanstack/router-core1.171.19 → 1.171.20Changeset
@tanstack/start-client-core1.170.19 → 1.170.20Changeset
@tanstack/react-router1.170.23 → 1.170.24Dependent
@tanstack/react-start1.168.40 → 1.168.41Dependent
@tanstack/react-start-client1.168.21 → 1.168.22Dependent
@tanstack/react-start-rsc0.1.39 → 0.1.40Dependent
@tanstack/react-start-server1.167.28 → 1.167.29Dependent
@tanstack/router-cli1.167.25 → 1.167.26Dependent
@tanstack/router-generator1.167.25 → 1.167.26Dependent
@tanstack/router-plugin1.168.27 → 1.168.28Dependent
@tanstack/router-vite-plugin1.167.27 → 1.167.28Dependent
@tanstack/solid-router1.170.22 → 1.170.23Dependent
@tanstack/solid-start1.168.39 → 1.168.40Dependent
@tanstack/solid-start-client1.168.21 → 1.168.22Dependent
@tanstack/solid-start-server1.167.28 → 1.167.29Dependent
@tanstack/start-plugin-core1.171.31 → 1.171.32Dependent
@tanstack/start-server-core1.169.23 → 1.169.24Dependent
@tanstack/start-static-server-functions1.167.24 → 1.167.25Dependent
@tanstack/start-storage-context1.167.21 → 1.167.22Dependent
@tanstack/vue-router1.170.21 → 1.170.22Dependent
@tanstack/vue-start1.168.38 → 1.168.39Dependent
@tanstack/vue-start-client1.167.24 → 1.167.25Dependent
@tanstack/vue-start-server1.167.28 → 1.167.29Dependent
@github-actions
github-actionsBot
commented
Aug 8, 2026

Copy link


Copy Markdown

Contributor
Bundle Size Benchmarks
This pull request does not affect bundle size in any measured scenario.
@pkg-pr-new
pkg-pr-newBot
commented
Aug 8, 2026

Copy link


Copy Markdown

More templates
@tanstack/arktype-adapter
npm i https://pkg.pr.new/@tanstack/arktype-adapter@8012

@tanstack/eslint-plugin-router
npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@8012

@tanstack/eslint-plugin-start
npm i https://pkg.pr.new/@tanstack/eslint-plugin-start@8012

@tanstack/history
npm i https://pkg.pr.new/@tanstack/history@8012

@tanstack/nitro-v2-vite-plugin
npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@8012

@tanstack/react-router
npm i https://pkg.pr.new/@tanstack/react-router@8012

@tanstack/react-router-devtools
npm i https://pkg.pr.new/@tanstack/react-router-devtools@8012

@tanstack/react-router-ssr-query
npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@8012

@tanstack/react-start
npm i https://pkg.pr.new/@tanstack/react-start@8012

@tanstack/react-start-client
npm i https://pkg.pr.new/@tanstack/react-start-client@8012

@tanstack/react-start-rsc
npm i https://pkg.pr.new/@tanstack/react-start-rsc@8012

@tanstack/react-start-server
npm i https://pkg.pr.new/@tanstack/react-start-server@8012

@tanstack/router-cli
npm i https://pkg.pr.new/@tanstack/router-cli@8012

@tanstack/router-core
npm i https://pkg.pr.new/@tanstack/router-core@8012

@tanstack/router-devtools
npm i https://pkg.pr.new/@tanstack/router-devtools@8012

@tanstack/router-devtools-core
npm i https://pkg.pr.new/@tanstack/router-devtools-core@8012

@tanstack/router-generator
npm i https://pkg.pr.new/@tanstack/router-generator@8012

@tanstack/router-plugin
npm i https://pkg.pr.new/@tanstack/router-plugin@8012

@tanstack/router-ssr-query-core
npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@8012

@tanstack/router-utils
npm i https://pkg.pr.new/@tanstack/router-utils@8012

@tanstack/router-vite-plugin
npm i https://pkg.pr.new/@tanstack/router-vite-plugin@8012

@tanstack/solid-router
npm i https://pkg.pr.new/@tanstack/solid-router@8012

@tanstack/solid-router-devtools
npm i https://pkg.pr.new/@tanstack/solid-router-devtools@8012

@tanstack/solid-router-ssr-query
npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@8012

@tanstack/solid-start
npm i https://pkg.pr.new/@tanstack/solid-start@8012

@tanstack/solid-start-client
npm i https://pkg.pr.new/@tanstack/solid-start-client@8012

@tanstack/solid-start-server
npm i https://pkg.pr.new/@tanstack/solid-start-server@8012

@tanstack/start-client-core
npm i https://pkg.pr.new/@tanstack/start-client-core@8012

@tanstack/start-fn-stubs
npm i https://pkg.pr.new/@tanstack/start-fn-stubs@8012

@tanstack/start-plugin-core
npm i https://pkg.pr.new/@tanstack/start-plugin-core@8012

@tanstack/start-server-core
npm i https://pkg.pr.new/@tanstack/start-server-core@8012

@tanstack/start-static-server-functions
npm i https://pkg.pr.new/@tanstack/start-static-server-functions@8012

@tanstack/start-storage-context
npm i https://pkg.pr.new/@tanstack/start-storage-context@8012

@tanstack/valibot-adapter
npm i https://pkg.pr.new/@tanstack/valibot-adapter@8012

@tanstack/virtual-file-routes
npm i https://pkg.pr.new/@tanstack/virtual-file-routes@8012

@tanstack/vue-router
npm i https://pkg.pr.new/@tanstack/vue-router@8012

@tanstack/vue-router-devtools
npm i https://pkg.pr.new/@tanstack/vue-router-devtools@8012

@tanstack/vue-router-ssr-query
npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@8012

@tanstack/vue-start
npm i https://pkg.pr.new/@tanstack/vue-start@8012

@tanstack/vue-start-client
npm i https://pkg.pr.new/@tanstack/vue-start-client@8012

@tanstack/vue-start-server
npm i https://pkg.pr.new/@tanstack/vue-start-server@8012

@tanstack/zod-adapter
npm i https://pkg.pr.new/@tanstack/zod-adapter@8012

commit: 0ae9eb0
@codspeed-hq
codspeed-hqBot
commented
Aug 8, 2026

Copy link


Copy Markdown

Merging this PR will degrade performance by 0.08%
⚠️Different runtime environments detected
Some benchmarks with significant performance changes were compared across different runtime environments,

which may affect the accuracy of the results.
Open the report in CodSpeed to investigate
⚡ 6 improved benchmarks
❌ 3 regressed benchmarks
✅ 171 untouched benchmarks
Warning
Please fix the performance issues or acknowledge them on CodSpeed.
Performance Changes
ModeBenchmarkBASEHEADEfficiency
❌Memorymem server error-paths redirect (vue)433.1 KB904.6 KB-52.13%
❌Memorymem server error-paths unmatched (solid)428.5 KB454.6 KB-5.75%
❌Memorymem server server-fn-churn (react)264.7 KB276.7 KB-4.31%
⚡Memorymem server error-paths not-found (solid)728.6 KB418.6 KB+74.03%
⚡Memorymem client preload-churn (vue)805.5 KB736.9 KB+9.32%
⚡Memorymem client navigation-churn (solid)575 KB528.4 KB+8.83%
⚡Simulationssr dehydrate rich types (solid)99.7 ms95.9 ms+4.01%
⚡Memorymem server error-paths unmatched (react)272.3 KB263.2 KB+3.48%
⚡Memorymem client unique-location-churn (solid)352.4 KB341.5 KB+3.18%
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing codex/server-search-serialization (0ae9eb0) with main (44a8c3e)
Open in CodSpeed
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

package: router-core

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@Sheraff

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
perf(router-core): optimize server search serialization - #8012
Draft
Sheraff wants to merge 1 commit into
mainfrom 
codex/server-search-serialization
Draft
perf(router-core): optimize server search serialization#8012
Sheraff wants to merge 1 commit into
mainfrom 
codex/server-search-serialization
Conversation
@Sheraff
@SheraffSheraff
commented
Aug 8, 2026

Copy link


Copy Markdown

Collaborator
What changed
  • Select a dedicated default search serializer behind the existing isServer conditional export.
  • Classify JSON primitives with an allocation-free scanner on the server, avoiding exception-heavy JSON.parse calls for impossible JSON and bypassing parsing for fully validated primitives.
  • Continue using the native parser for quoted strings, arrays, objects, and whitespace-prefixed values.
  • Preserve the compact perf(router-core): skip impossible JSON parse attempts #8006 client implementation and the existing path for custom parsers.
  • Add server-specific parity tests and focused performance benchmarks.
The environment check intentionally remains at serializer invocation time. The server isServer export also loads router code, so reading it while the serializer factory initializes can encounter the isServer -> load-server -> router -> searchParams module cycle.
Why
#8006 keeps the client fast path compact because every byte matters there. Server builds can dead-code-eliminate a larger implementation, allowing exact primitive validation and avoiding costly parser exceptions without increasing client bundles.
Performance
Measured with the same Vitest benchmark file against the exact merged #8006 implementation:
  • ordinary application strings: ~2.5% faster
  • realistic application distribution: ~6% faster
  • JSON primitive strings: ~26% faster
  • invalid number-like strings: ~54x faster
  • JSON-literal-prefix misses: ~47-53x faster
Inputs that still require the native parser remain within single-digit percentages of the baseline, and whitespace-prefixed structured inputs no longer have a length-amplifying double-scan regression.
The full 17-scenario client bundle matrix is byte-for-byte unchanged: zero delta for raw, gzip, Brotli, and initial gzip sizes.
Validation
  • @tanstack/router-core:test:unit: 106 files passed; 1,616 tests passed and 3 expected failures
  • @tanstack/router-core:test:types: TypeScript 5.6 through 7.0 passed
  • @tanstack/router-core:test:eslint: 0 errors
  • focused server Vitest benchmarks against the exact perf(router-core): skip impossible JSON parse attempts #8006 baseline
  • full bundle-size benchmark across all 17 scenarios
@coderabbitai
coderabbitaiBot
commented
Aug 8, 2026

Copy link


Copy Markdown

Contributor
Important
Review skipped
Draft detected.
Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 4ebbe526-aa87-441b-8d0b-166ee51d908c
You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.
Use the checkbox below for a quick retry:
  •  🔍 Trigger review
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands.
@nx-cloud
nx-cloudBot
commented
Aug 8, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
View your CI Pipeline Execution ↗ for commit 0ae9eb0
CommandStatusDurationResult
nx affected --targets=test:eslint,test:unit,tes...✅ Succeeded10m 23sView ↗
nx run-many --target=build --exclude=examples/*...✅ Succeeded2m 14sView ↗
☁️ Nx Cloud last updated this comment at 2026-08-08 17:58:29 UTC
@github-actions
github-actionsBot
commented
Aug 8, 2026

Copy link


Copy Markdown

Contributor
🚀 Changeset Version Preview
2 package(s) bumped directly, 21 bumped as dependents.
🟩 Patch bumps
PackageVersionReason
@tanstack/router-core1.171.19 → 1.171.20Changeset
@tanstack/start-client-core1.170.19 → 1.170.20Changeset
@tanstack/react-router1.170.23 → 1.170.24Dependent
@tanstack/react-start1.168.40 → 1.168.41Dependent
@tanstack/react-start-client1.168.21 → 1.168.22Dependent
@tanstack/react-start-rsc0.1.39 → 0.1.40Dependent
@tanstack/react-start-server1.167.28 → 1.167.29Dependent
@tanstack/router-cli1.167.25 → 1.167.26Dependent
@tanstack/router-generator1.167.25 → 1.167.26Dependent
@tanstack/router-plugin1.168.27 → 1.168.28Dependent
@tanstack/router-vite-plugin1.167.27 → 1.167.28Dependent
@tanstack/solid-router1.170.22 → 1.170.23Dependent
@tanstack/solid-start1.168.39 → 1.168.40Dependent
@tanstack/solid-start-client1.168.21 → 1.168.22Dependent
@tanstack/solid-start-server1.167.28 → 1.167.29Dependent
@tanstack/start-plugin-core1.171.31 → 1.171.32Dependent
@tanstack/start-server-core1.169.23 → 1.169.24Dependent
@tanstack/start-static-server-functions1.167.24 → 1.167.25Dependent
@tanstack/start-storage-context1.167.21 → 1.167.22Dependent
@tanstack/vue-router1.170.21 → 1.170.22Dependent
@tanstack/vue-start1.168.38 → 1.168.39Dependent
@tanstack/vue-start-client1.167.24 → 1.167.25Dependent
@tanstack/vue-start-server1.167.28 → 1.167.29Dependent
@github-actions
github-actionsBot
commented
Aug 8, 2026

Copy link


Copy Markdown

Contributor
Bundle Size Benchmarks
This pull request does not affect bundle size in any measured scenario.
@pkg-pr-new
pkg-pr-newBot
commented
Aug 8, 2026

Copy link


Copy Markdown

More templates
@tanstack/arktype-adapter
npm i https://pkg.pr.new/@tanstack/arktype-adapter@8012

@tanstack/eslint-plugin-router
npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@8012

@tanstack/eslint-plugin-start
npm i https://pkg.pr.new/@tanstack/eslint-plugin-start@8012

@tanstack/history
npm i https://pkg.pr.new/@tanstack/history@8012

@tanstack/nitro-v2-vite-plugin
npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@8012

@tanstack/react-router
npm i https://pkg.pr.new/@tanstack/react-router@8012

@tanstack/react-router-devtools
npm i https://pkg.pr.new/@tanstack/react-router-devtools@8012

@tanstack/react-router-ssr-query
npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@8012

@tanstack/react-start
npm i https://pkg.pr.new/@tanstack/react-start@8012

@tanstack/react-start-client
npm i https://pkg.pr.new/@tanstack/react-start-client@8012

@tanstack/react-start-rsc
npm i https://pkg.pr.new/@tanstack/react-start-rsc@8012

@tanstack/react-start-server
npm i https://pkg.pr.new/@tanstack/react-start-server@8012

@tanstack/router-cli
npm i https://pkg.pr.new/@tanstack/router-cli@8012

@tanstack/router-core
npm i https://pkg.pr.new/@tanstack/router-core@8012

@tanstack/router-devtools
npm i https://pkg.pr.new/@tanstack/router-devtools@8012

@tanstack/router-devtools-core
npm i https://pkg.pr.new/@tanstack/router-devtools-core@8012

@tanstack/router-generator
npm i https://pkg.pr.new/@tanstack/router-generator@8012

@tanstack/router-plugin
npm i https://pkg.pr.new/@tanstack/router-plugin@8012

@tanstack/router-ssr-query-core
npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@8012

@tanstack/router-utils
npm i https://pkg.pr.new/@tanstack/router-utils@8012

@tanstack/router-vite-plugin
npm i https://pkg.pr.new/@tanstack/router-vite-plugin@8012

@tanstack/solid-router
npm i https://pkg.pr.new/@tanstack/solid-router@8012

@tanstack/solid-router-devtools
npm i https://pkg.pr.new/@tanstack/solid-router-devtools@8012

@tanstack/solid-router-ssr-query
npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@8012

@tanstack/solid-start
npm i https://pkg.pr.new/@tanstack/solid-start@8012

@tanstack/solid-start-client
npm i https://pkg.pr.new/@tanstack/solid-start-client@8012

@tanstack/solid-start-server
npm i https://pkg.pr.new/@tanstack/solid-start-server@8012

@tanstack/start-client-core
npm i https://pkg.pr.new/@tanstack/start-client-core@8012

@tanstack/start-fn-stubs
npm i https://pkg.pr.new/@tanstack/start-fn-stubs@8012

@tanstack/start-plugin-core
npm i https://pkg.pr.new/@tanstack/start-plugin-core@8012

@tanstack/start-server-core
npm i https://pkg.pr.new/@tanstack/start-server-core@8012

@tanstack/start-static-server-functions
npm i https://pkg.pr.new/@tanstack/start-static-server-functions@8012

@tanstack/start-storage-context
npm i https://pkg.pr.new/@tanstack/start-storage-context@8012

@tanstack/valibot-adapter
npm i https://pkg.pr.new/@tanstack/valibot-adapter@8012

@tanstack/virtual-file-routes
npm i https://pkg.pr.new/@tanstack/virtual-file-routes@8012

@tanstack/vue-router
npm i https://pkg.pr.new/@tanstack/vue-router@8012

@tanstack/vue-router-devtools
npm i https://pkg.pr.new/@tanstack/vue-router-devtools@8012

@tanstack/vue-router-ssr-query
npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@8012

@tanstack/vue-start
npm i https://pkg.pr.new/@tanstack/vue-start@8012

@tanstack/vue-start-client
npm i https://pkg.pr.new/@tanstack/vue-start-client@8012

@tanstack/vue-start-server
npm i https://pkg.pr.new/@tanstack/vue-start-server@8012

@tanstack/zod-adapter
npm i https://pkg.pr.new/@tanstack/zod-adapter@8012

commit: 0ae9eb0
@codspeed-hq
codspeed-hqBot
commented
Aug 8, 2026

Copy link


Copy Markdown

Merging this PR will degrade performance by 0.08%
⚠️Different runtime environments detected
Some benchmarks with significant performance changes were compared across different runtime environments,

which may affect the accuracy of the results.
Open the report in CodSpeed to investigate
⚡ 6 improved benchmarks
❌ 3 regressed benchmarks
✅ 171 untouched benchmarks
Warning
Please fix the performance issues or acknowledge them on CodSpeed.
Performance Changes
ModeBenchmarkBASEHEADEfficiency
❌Memorymem server error-paths redirect (vue)433.1 KB904.6 KB-52.13%
❌Memorymem server error-paths unmatched (solid)428.5 KB454.6 KB-5.75%
❌Memorymem server server-fn-churn (react)264.7 KB276.7 KB-4.31%
⚡Memorymem server error-paths not-found (solid)728.6 KB418.6 KB+74.03%
⚡Memorymem client preload-churn (vue)805.5 KB736.9 KB+9.32%
⚡Memorymem client navigation-churn (solid)575 KB528.4 KB+8.83%
⚡Simulationssr dehydrate rich types (solid)99.7 ms95.9 ms+4.01%
⚡Memorymem server error-paths unmatched (react)272.3 KB263.2 KB+3.48%
⚡Memorymem client unique-location-churn (solid)352.4 KB341.5 KB+3.18%
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing codex/server-search-serialization (0ae9eb0) with main (44a8c3e)
Open in CodSpeed
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

package: router-core

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@Sheraff

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
perf(router-core): optimize server search serialization - #8012
Draft
Sheraff wants to merge 1 commit into
mainfrom 
codex/server-search-serialization
Draft
perf(router-core): optimize server search serialization#8012
Sheraff wants to merge 1 commit into
mainfrom 
codex/server-search-serialization
Conversation
@Sheraff
@SheraffSheraff
commented
Aug 8, 2026

Copy link


Copy Markdown

Collaborator
What changed
  • Select a dedicated default search serializer behind the existing isServer conditional export.
  • Classify JSON primitives with an allocation-free scanner on the server, avoiding exception-heavy JSON.parse calls for impossible JSON and bypassing parsing for fully validated primitives.
  • Continue using the native parser for quoted strings, arrays, objects, and whitespace-prefixed values.
  • Preserve the compact perf(router-core): skip impossible JSON parse attempts #8006 client implementation and the existing path for custom parsers.
  • Add server-specific parity tests and focused performance benchmarks.
The environment check intentionally remains at serializer invocation time. The server isServer export also loads router code, so reading it while the serializer factory initializes can encounter the isServer -> load-server -> router -> searchParams module cycle.
Why
#8006 keeps the client fast path compact because every byte matters there. Server builds can dead-code-eliminate a larger implementation, allowing exact primitive validation and avoiding costly parser exceptions without increasing client bundles.
Performance
Measured with the same Vitest benchmark file against the exact merged #8006 implementation:
  • ordinary application strings: ~2.5% faster
  • realistic application distribution: ~6% faster
  • JSON primitive strings: ~26% faster
  • invalid number-like strings: ~54x faster
  • JSON-literal-prefix misses: ~47-53x faster
Inputs that still require the native parser remain within single-digit percentages of the baseline, and whitespace-prefixed structured inputs no longer have a length-amplifying double-scan regression.
The full 17-scenario client bundle matrix is byte-for-byte unchanged: zero delta for raw, gzip, Brotli, and initial gzip sizes.
Validation
  • @tanstack/router-core:test:unit: 106 files passed; 1,616 tests passed and 3 expected failures
  • @tanstack/router-core:test:types: TypeScript 5.6 through 7.0 passed
  • @tanstack/router-core:test:eslint: 0 errors
  • focused server Vitest benchmarks against the exact perf(router-core): skip impossible JSON parse attempts #8006 baseline
  • full bundle-size benchmark across all 17 scenarios
@coderabbitai
coderabbitaiBot
commented
Aug 8, 2026

Copy link


Copy Markdown

Contributor
Important
Review skipped
Draft detected.
Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 4ebbe526-aa87-441b-8d0b-166ee51d908c
You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.
Use the checkbox below for a quick retry:
  •  🔍 Trigger review
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands.
@nx-cloud
nx-cloudBot
commented
Aug 8, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
View your CI Pipeline Execution ↗ for commit 0ae9eb0
CommandStatusDurationResult
nx affected --targets=test:eslint,test:unit,tes...✅ Succeeded10m 23sView ↗
nx run-many --target=build --exclude=examples/*...✅ Succeeded2m 14sView ↗
☁️ Nx Cloud last updated this comment at 2026-08-08 17:58:29 UTC
@github-actions
github-actionsBot
commented
Aug 8, 2026

Copy link


Copy Markdown

Contributor
🚀 Changeset Version Preview
2 package(s) bumped directly, 21 bumped as dependents.
🟩 Patch bumps
PackageVersionReason
@tanstack/router-core1.171.19 → 1.171.20Changeset
@tanstack/start-client-core1.170.19 → 1.170.20Changeset
@tanstack/react-router1.170.23 → 1.170.24Dependent
@tanstack/react-start1.168.40 → 1.168.41Dependent
@tanstack/react-start-client1.168.21 → 1.168.22Dependent
@tanstack/react-start-rsc0.1.39 → 0.1.40Dependent
@tanstack/react-start-server1.167.28 → 1.167.29Dependent
@tanstack/router-cli1.167.25 → 1.167.26Dependent
@tanstack/router-generator1.167.25 → 1.167.26Dependent
@tanstack/router-plugin1.168.27 → 1.168.28Dependent
@tanstack/router-vite-plugin1.167.27 → 1.167.28Dependent
@tanstack/solid-router1.170.22 → 1.170.23Dependent
@tanstack/solid-start1.168.39 → 1.168.40Dependent
@tanstack/solid-start-client1.168.21 → 1.168.22Dependent
@tanstack/solid-start-server1.167.28 → 1.167.29Dependent
@tanstack/start-plugin-core1.171.31 → 1.171.32Dependent
@tanstack/start-server-core1.169.23 → 1.169.24Dependent
@tanstack/start-static-server-functions1.167.24 → 1.167.25Dependent
@tanstack/start-storage-context1.167.21 → 1.167.22Dependent
@tanstack/vue-router1.170.21 → 1.170.22Dependent
@tanstack/vue-start1.168.38 → 1.168.39Dependent
@tanstack/vue-start-client1.167.24 → 1.167.25Dependent
@tanstack/vue-start-server1.167.28 → 1.167.29Dependent
@github-actions
github-actionsBot
commented
Aug 8, 2026

Copy link


Copy Markdown

Contributor
Bundle Size Benchmarks
This pull request does not affect bundle size in any measured scenario.
@pkg-pr-new
pkg-pr-newBot
commented
Aug 8, 2026

Copy link


Copy Markdown

More templates
@tanstack/arktype-adapter
npm i https://pkg.pr.new/@tanstack/arktype-adapter@8012

@tanstack/eslint-plugin-router
npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@8012

@tanstack/eslint-plugin-start
npm i https://pkg.pr.new/@tanstack/eslint-plugin-start@8012

@tanstack/history
npm i https://pkg.pr.new/@tanstack/history@8012

@tanstack/nitro-v2-vite-plugin
npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@8012

@tanstack/react-router
npm i https://pkg.pr.new/@tanstack/react-router@8012

@tanstack/react-router-devtools
npm i https://pkg.pr.new/@tanstack/react-router-devtools@8012

@tanstack/react-router-ssr-query
npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@8012

@tanstack/react-start
npm i https://pkg.pr.new/@tanstack/react-start@8012

@tanstack/react-start-client
npm i https://pkg.pr.new/@tanstack/react-start-client@8012

@tanstack/react-start-rsc
npm i https://pkg.pr.new/@tanstack/react-start-rsc@8012

@tanstack/react-start-server
npm i https://pkg.pr.new/@tanstack/react-start-server@8012

@tanstack/router-cli
npm i https://pkg.pr.new/@tanstack/router-cli@8012

@tanstack/router-core
npm i https://pkg.pr.new/@tanstack/router-core@8012

@tanstack/router-devtools
npm i https://pkg.pr.new/@tanstack/router-devtools@8012

@tanstack/router-devtools-core
npm i https://pkg.pr.new/@tanstack/router-devtools-core@8012

@tanstack/router-generator
npm i https://pkg.pr.new/@tanstack/router-generator@8012

@tanstack/router-plugin
npm i https://pkg.pr.new/@tanstack/router-plugin@8012

@tanstack/router-ssr-query-core
npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@8012

@tanstack/router-utils
npm i https://pkg.pr.new/@tanstack/router-utils@8012

@tanstack/router-vite-plugin
npm i https://pkg.pr.new/@tanstack/router-vite-plugin@8012

@tanstack/solid-router
npm i https://pkg.pr.new/@tanstack/solid-router@8012

@tanstack/solid-router-devtools
npm i https://pkg.pr.new/@tanstack/solid-router-devtools@8012

@tanstack/solid-router-ssr-query
npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@8012

@tanstack/solid-start
npm i https://pkg.pr.new/@tanstack/solid-start@8012

@tanstack/solid-start-client
npm i https://pkg.pr.new/@tanstack/solid-start-client@8012

@tanstack/solid-start-server
npm i https://pkg.pr.new/@tanstack/solid-start-server@8012

@tanstack/start-client-core
npm i https://pkg.pr.new/@tanstack/start-client-core@8012

@tanstack/start-fn-stubs
npm i https://pkg.pr.new/@tanstack/start-fn-stubs@8012

@tanstack/start-plugin-core
npm i https://pkg.pr.new/@tanstack/start-plugin-core@8012

@tanstack/start-server-core
npm i https://pkg.pr.new/@tanstack/start-server-core@8012

@tanstack/start-static-server-functions
npm i https://pkg.pr.new/@tanstack/start-static-server-functions@8012

@tanstack/start-storage-context
npm i https://pkg.pr.new/@tanstack/start-storage-context@8012

@tanstack/valibot-adapter
npm i https://pkg.pr.new/@tanstack/valibot-adapter@8012

@tanstack/virtual-file-routes
npm i https://pkg.pr.new/@tanstack/virtual-file-routes@8012

@tanstack/vue-router
npm i https://pkg.pr.new/@tanstack/vue-router@8012

@tanstack/vue-router-devtools
npm i https://pkg.pr.new/@tanstack/vue-router-devtools@8012

@tanstack/vue-router-ssr-query
npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@8012

@tanstack/vue-start
npm i https://pkg.pr.new/@tanstack/vue-start@8012

@tanstack/vue-start-client
npm i https://pkg.pr.new/@tanstack/vue-start-client@8012

@tanstack/vue-start-server
npm i https://pkg.pr.new/@tanstack/vue-start-server@8012

@tanstack/zod-adapter
npm i https://pkg.pr.new/@tanstack/zod-adapter@8012

commit: 0ae9eb0
@codspeed-hq
codspeed-hqBot
commented
Aug 8, 2026

Copy link


Copy Markdown

Merging this PR will degrade performance by 0.08%
⚠️Different runtime environments detected
Some benchmarks with significant performance changes were compared across different runtime environments,

which may affect the accuracy of the results.
Open the report in CodSpeed to investigate
⚡ 6 improved benchmarks
❌ 3 regressed benchmarks
✅ 171 untouched benchmarks
Warning
Please fix the performance issues or acknowledge them on CodSpeed.
Performance Changes
ModeBenchmarkBASEHEADEfficiency
❌Memorymem server error-paths redirect (vue)433.1 KB904.6 KB-52.13%
❌Memorymem server error-paths unmatched (solid)428.5 KB454.6 KB-5.75%
❌Memorymem server server-fn-churn (react)264.7 KB276.7 KB-4.31%
⚡Memorymem server error-paths not-found (solid)728.6 KB418.6 KB+74.03%
⚡Memorymem client preload-churn (vue)805.5 KB736.9 KB+9.32%
⚡Memorymem client navigation-churn (solid)575 KB528.4 KB+8.83%
⚡Simulationssr dehydrate rich types (solid)99.7 ms95.9 ms+4.01%
⚡Memorymem server error-paths unmatched (react)272.3 KB263.2 KB+3.48%
⚡Memorymem client unique-location-churn (solid)352.4 KB341.5 KB+3.18%
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing codex/server-search-serialization (0ae9eb0) with main (44a8c3e)
Open in CodSpeed
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

package: router-core

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@Sheraff

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
perf(router-core): optimize server search serialization - #8012
Draft
Sheraff wants to merge 1 commit into
mainfrom 
codex/server-search-serialization
Draft
perf(router-core): optimize server search serialization#8012
Sheraff wants to merge 1 commit into
mainfrom 
codex/server-search-serialization
Conversation
@Sheraff
@SheraffSheraff
commented
Aug 8, 2026

Copy link


Copy Markdown

Collaborator
What changed
  • Select a dedicated default search serializer behind the existing isServer conditional export.
  • Classify JSON primitives with an allocation-free scanner on the server, avoiding exception-heavy JSON.parse calls for impossible JSON and bypassing parsing for fully validated primitives.
  • Continue using the native parser for quoted strings, arrays, objects, and whitespace-prefixed values.
  • Preserve the compact perf(router-core): skip impossible JSON parse attempts #8006 client implementation and the existing path for custom parsers.
  • Add server-specific parity tests and focused performance benchmarks.
The environment check intentionally remains at serializer invocation time. The server isServer export also loads router code, so reading it while the serializer factory initializes can encounter the isServer -> load-server -> router -> searchParams module cycle.
Why
#8006 keeps the client fast path compact because every byte matters there. Server builds can dead-code-eliminate a larger implementation, allowing exact primitive validation and avoiding costly parser exceptions without increasing client bundles.
Performance
Measured with the same Vitest benchmark file against the exact merged #8006 implementation:
  • ordinary application strings: ~2.5% faster
  • realistic application distribution: ~6% faster
  • JSON primitive strings: ~26% faster
  • invalid number-like strings: ~54x faster
  • JSON-literal-prefix misses: ~47-53x faster
Inputs that still require the native parser remain within single-digit percentages of the baseline, and whitespace-prefixed structured inputs no longer have a length-amplifying double-scan regression.
The full 17-scenario client bundle matrix is byte-for-byte unchanged: zero delta for raw, gzip, Brotli, and initial gzip sizes.
Validation
  • @tanstack/router-core:test:unit: 106 files passed; 1,616 tests passed and 3 expected failures
  • @tanstack/router-core:test:types: TypeScript 5.6 through 7.0 passed
  • @tanstack/router-core:test:eslint: 0 errors
  • focused server Vitest benchmarks against the exact perf(router-core): skip impossible JSON parse attempts #8006 baseline
  • full bundle-size benchmark across all 17 scenarios
@coderabbitai
coderabbitaiBot
commented
Aug 8, 2026

Copy link


Copy Markdown

Contributor
Important
Review skipped
Draft detected.
Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 4ebbe526-aa87-441b-8d0b-166ee51d908c
You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.
Use the checkbox below for a quick retry:
  •  🔍 Trigger review
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands.
@nx-cloud
nx-cloudBot
commented
Aug 8, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
View your CI Pipeline Execution ↗ for commit 0ae9eb0
CommandStatusDurationResult
nx affected --targets=test:eslint,test:unit,tes...✅ Succeeded10m 23sView ↗
nx run-many --target=build --exclude=examples/*...✅ Succeeded2m 14sView ↗
☁️ Nx Cloud last updated this comment at 2026-08-08 17:58:29 UTC
@github-actions
github-actionsBot
commented
Aug 8, 2026

Copy link


Copy Markdown

Contributor
🚀 Changeset Version Preview
2 package(s) bumped directly, 21 bumped as dependents.
🟩 Patch bumps
PackageVersionReason
@tanstack/router-core1.171.19 → 1.171.20Changeset
@tanstack/start-client-core1.170.19 → 1.170.20Changeset
@tanstack/react-router1.170.23 → 1.170.24Dependent
@tanstack/react-start1.168.40 → 1.168.41Dependent
@tanstack/react-start-client1.168.21 → 1.168.22Dependent
@tanstack/react-start-rsc0.1.39 → 0.1.40Dependent
@tanstack/react-start-server1.167.28 → 1.167.29Dependent
@tanstack/router-cli1.167.25 → 1.167.26Dependent
@tanstack/router-generator1.167.25 → 1.167.26Dependent
@tanstack/router-plugin1.168.27 → 1.168.28Dependent
@tanstack/router-vite-plugin1.167.27 → 1.167.28Dependent
@tanstack/solid-router1.170.22 → 1.170.23Dependent
@tanstack/solid-start1.168.39 → 1.168.40Dependent
@tanstack/solid-start-client1.168.21 → 1.168.22Dependent
@tanstack/solid-start-server1.167.28 → 1.167.29Dependent
@tanstack/start-plugin-core1.171.31 → 1.171.32Dependent
@tanstack/start-server-core1.169.23 → 1.169.24Dependent
@tanstack/start-static-server-functions1.167.24 → 1.167.25Dependent
@tanstack/start-storage-context1.167.21 → 1.167.22Dependent
@tanstack/vue-router1.170.21 → 1.170.22Dependent
@tanstack/vue-start1.168.38 → 1.168.39Dependent
@tanstack/vue-start-client1.167.24 → 1.167.25Dependent
@tanstack/vue-start-server1.167.28 → 1.167.29Dependent
@github-actions
github-actionsBot
commented
Aug 8, 2026

Copy link


Copy Markdown

Contributor
Bundle Size Benchmarks
This pull request does not affect bundle size in any measured scenario.
@pkg-pr-new
pkg-pr-newBot
commented
Aug 8, 2026

Copy link


Copy Markdown

More templates
@tanstack/arktype-adapter
npm i https://pkg.pr.new/@tanstack/arktype-adapter@8012

@tanstack/eslint-plugin-router
npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@8012

@tanstack/eslint-plugin-start
npm i https://pkg.pr.new/@tanstack/eslint-plugin-start@8012

@tanstack/history
npm i https://pkg.pr.new/@tanstack/history@8012

@tanstack/nitro-v2-vite-plugin
npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@8012

@tanstack/react-router
npm i https://pkg.pr.new/@tanstack/react-router@8012

@tanstack/react-router-devtools
npm i https://pkg.pr.new/@tanstack/react-router-devtools@8012

@tanstack/react-router-ssr-query
npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@8012

@tanstack/react-start
npm i https://pkg.pr.new/@tanstack/react-start@8012

@tanstack/react-start-client
npm i https://pkg.pr.new/@tanstack/react-start-client@8012

@tanstack/react-start-rsc
npm i https://pkg.pr.new/@tanstack/react-start-rsc@8012

@tanstack/react-start-server
npm i https://pkg.pr.new/@tanstack/react-start-server@8012

@tanstack/router-cli
npm i https://pkg.pr.new/@tanstack/router-cli@8012

@tanstack/router-core
npm i https://pkg.pr.new/@tanstack/router-core@8012

@tanstack/router-devtools
npm i https://pkg.pr.new/@tanstack/router-devtools@8012

@tanstack/router-devtools-core
npm i https://pkg.pr.new/@tanstack/router-devtools-core@8012

@tanstack/router-generator
npm i https://pkg.pr.new/@tanstack/router-generator@8012

@tanstack/router-plugin
npm i https://pkg.pr.new/@tanstack/router-plugin@8012

@tanstack/router-ssr-query-core
npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@8012

@tanstack/router-utils
npm i https://pkg.pr.new/@tanstack/router-utils@8012

@tanstack/router-vite-plugin
npm i https://pkg.pr.new/@tanstack/router-vite-plugin@8012

@tanstack/solid-router
npm i https://pkg.pr.new/@tanstack/solid-router@8012

@tanstack/solid-router-devtools
npm i https://pkg.pr.new/@tanstack/solid-router-devtools@8012

@tanstack/solid-router-ssr-query
npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@8012

@tanstack/solid-start
npm i https://pkg.pr.new/@tanstack/solid-start@8012

@tanstack/solid-start-client
npm i https://pkg.pr.new/@tanstack/solid-start-client@8012

@tanstack/solid-start-server
npm i https://pkg.pr.new/@tanstack/solid-start-server@8012

@tanstack/start-client-core
npm i https://pkg.pr.new/@tanstack/start-client-core@8012

@tanstack/start-fn-stubs
npm i https://pkg.pr.new/@tanstack/start-fn-stubs@8012

@tanstack/start-plugin-core
npm i https://pkg.pr.new/@tanstack/start-plugin-core@8012

@tanstack/start-server-core
npm i https://pkg.pr.new/@tanstack/start-server-core@8012

@tanstack/start-static-server-functions
npm i https://pkg.pr.new/@tanstack/start-static-server-functions@8012

@tanstack/start-storage-context
npm i https://pkg.pr.new/@tanstack/start-storage-context@8012

@tanstack/valibot-adapter
npm i https://pkg.pr.new/@tanstack/valibot-adapter@8012

@tanstack/virtual-file-routes
npm i https://pkg.pr.new/@tanstack/virtual-file-routes@8012

@tanstack/vue-router
npm i https://pkg.pr.new/@tanstack/vue-router@8012

@tanstack/vue-router-devtools
npm i https://pkg.pr.new/@tanstack/vue-router-devtools@8012

@tanstack/vue-router-ssr-query
npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@8012

@tanstack/vue-start
npm i https://pkg.pr.new/@tanstack/vue-start@8012

@tanstack/vue-start-client
npm i https://pkg.pr.new/@tanstack/vue-start-client@8012

@tanstack/vue-start-server
npm i https://pkg.pr.new/@tanstack/vue-start-server@8012

@tanstack/zod-adapter
npm i https://pkg.pr.new/@tanstack/zod-adapter@8012

commit: 0ae9eb0
@codspeed-hq
codspeed-hqBot
commented
Aug 8, 2026

Copy link


Copy Markdown

Merging this PR will degrade performance by 0.08%
⚠️Different runtime environments detected
Some benchmarks with significant performance changes were compared across different runtime environments,

which may affect the accuracy of the results.
Open the report in CodSpeed to investigate
⚡ 6 improved benchmarks
❌ 3 regressed benchmarks
✅ 171 untouched benchmarks
Warning
Please fix the performance issues or acknowledge them on CodSpeed.
Performance Changes
ModeBenchmarkBASEHEADEfficiency
❌Memorymem server error-paths redirect (vue)433.1 KB904.6 KB-52.13%
❌Memorymem server error-paths unmatched (solid)428.5 KB454.6 KB-5.75%
❌Memorymem server server-fn-churn (react)264.7 KB276.7 KB-4.31%
⚡Memorymem server error-paths not-found (solid)728.6 KB418.6 KB+74.03%
⚡Memorymem client preload-churn (vue)805.5 KB736.9 KB+9.32%
⚡Memorymem client navigation-churn (solid)575 KB528.4 KB+8.83%
⚡Simulationssr dehydrate rich types (solid)99.7 ms95.9 ms+4.01%
⚡Memorymem server error-paths unmatched (react)272.3 KB263.2 KB+3.48%
⚡Memorymem client unique-location-churn (solid)352.4 KB341.5 KB+3.18%
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing codex/server-search-serialization (0ae9eb0) with main (44a8c3e)
Open in CodSpeed
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

package: router-core

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@Sheraff

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
perf(router-core): optimize server search serialization - #8012
Draft
Sheraff wants to merge 1 commit into
mainfrom 
codex/server-search-serialization
Draft
perf(router-core): optimize server search serialization#8012
Sheraff wants to merge 1 commit into
mainfrom 
codex/server-search-serialization
Conversation
@Sheraff
@SheraffSheraff
commented
Aug 8, 2026

Copy link


Copy Markdown

Collaborator
What changed
  • Select a dedicated default search serializer behind the existing isServer conditional export.
  • Classify JSON primitives with an allocation-free scanner on the server, avoiding exception-heavy JSON.parse calls for impossible JSON and bypassing parsing for fully validated primitives.
  • Continue using the native parser for quoted strings, arrays, objects, and whitespace-prefixed values.
  • Preserve the compact perf(router-core): skip impossible JSON parse attempts #8006 client implementation and the existing path for custom parsers.
  • Add server-specific parity tests and focused performance benchmarks.
The environment check intentionally remains at serializer invocation time. The server isServer export also loads router code, so reading it while the serializer factory initializes can encounter the isServer -> load-server -> router -> searchParams module cycle.
Why
#8006 keeps the client fast path compact because every byte matters there. Server builds can dead-code-eliminate a larger implementation, allowing exact primitive validation and avoiding costly parser exceptions without increasing client bundles.
Performance
Measured with the same Vitest benchmark file against the exact merged #8006 implementation:
  • ordinary application strings: ~2.5% faster
  • realistic application distribution: ~6% faster
  • JSON primitive strings: ~26% faster
  • invalid number-like strings: ~54x faster
  • JSON-literal-prefix misses: ~47-53x faster
Inputs that still require the native parser remain within single-digit percentages of the baseline, and whitespace-prefixed structured inputs no longer have a length-amplifying double-scan regression.
The full 17-scenario client bundle matrix is byte-for-byte unchanged: zero delta for raw, gzip, Brotli, and initial gzip sizes.
Validation
  • @tanstack/router-core:test:unit: 106 files passed; 1,616 tests passed and 3 expected failures
  • @tanstack/router-core:test:types: TypeScript 5.6 through 7.0 passed
  • @tanstack/router-core:test:eslint: 0 errors
  • focused server Vitest benchmarks against the exact perf(router-core): skip impossible JSON parse attempts #8006 baseline
  • full bundle-size benchmark across all 17 scenarios
@coderabbitai
coderabbitaiBot
commented
Aug 8, 2026

Copy link


Copy Markdown

Contributor
Important
Review skipped
Draft detected.
Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 4ebbe526-aa87-441b-8d0b-166ee51d908c
You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.
Use the checkbox below for a quick retry:
  •  🔍 Trigger review
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands.
@nx-cloud
nx-cloudBot
commented
Aug 8, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
View your CI Pipeline Execution ↗ for commit 0ae9eb0
CommandStatusDurationResult
nx affected --targets=test:eslint,test:unit,tes...✅ Succeeded10m 23sView ↗
nx run-many --target=build --exclude=examples/*...✅ Succeeded2m 14sView ↗
☁️ Nx Cloud last updated this comment at 2026-08-08 17:58:29 UTC
@github-actions
github-actionsBot
commented
Aug 8, 2026

Copy link


Copy Markdown

Contributor
🚀 Changeset Version Preview
2 package(s) bumped directly, 21 bumped as dependents.
🟩 Patch bumps
PackageVersionReason
@tanstack/router-core1.171.19 → 1.171.20Changeset
@tanstack/start-client-core1.170.19 → 1.170.20Changeset
@tanstack/react-router1.170.23 → 1.170.24Dependent
@tanstack/react-start1.168.40 → 1.168.41Dependent
@tanstack/react-start-client1.168.21 → 1.168.22Dependent
@tanstack/react-start-rsc0.1.39 → 0.1.40Dependent
@tanstack/react-start-server1.167.28 → 1.167.29Dependent
@tanstack/router-cli1.167.25 → 1.167.26Dependent
@tanstack/router-generator1.167.25 → 1.167.26Dependent
@tanstack/router-plugin1.168.27 → 1.168.28Dependent
@tanstack/router-vite-plugin1.167.27 → 1.167.28Dependent
@tanstack/solid-router1.170.22 → 1.170.23Dependent
@tanstack/solid-start1.168.39 → 1.168.40Dependent
@tanstack/solid-start-client1.168.21 → 1.168.22Dependent
@tanstack/solid-start-server1.167.28 → 1.167.29Dependent
@tanstack/start-plugin-core1.171.31 → 1.171.32Dependent
@tanstack/start-server-core1.169.23 → 1.169.24Dependent
@tanstack/start-static-server-functions1.167.24 → 1.167.25Dependent
@tanstack/start-storage-context1.167.21 → 1.167.22Dependent
@tanstack/vue-router1.170.21 → 1.170.22Dependent
@tanstack/vue-start1.168.38 → 1.168.39Dependent
@tanstack/vue-start-client1.167.24 → 1.167.25Dependent
@tanstack/vue-start-server1.167.28 → 1.167.29Dependent
@github-actions
github-actionsBot
commented
Aug 8, 2026

Copy link


Copy Markdown

Contributor
Bundle Size Benchmarks
This pull request does not affect bundle size in any measured scenario.
@pkg-pr-new
pkg-pr-newBot
commented
Aug 8, 2026

Copy link


Copy Markdown

More templates
@tanstack/arktype-adapter
npm i https://pkg.pr.new/@tanstack/arktype-adapter@8012

@tanstack/eslint-plugin-router
npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@8012

@tanstack/eslint-plugin-start
npm i https://pkg.pr.new/@tanstack/eslint-plugin-start@8012

@tanstack/history
npm i https://pkg.pr.new/@tanstack/history@8012

@tanstack/nitro-v2-vite-plugin
npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@8012

@tanstack/react-router
npm i https://pkg.pr.new/@tanstack/react-router@8012

@tanstack/react-router-devtools
npm i https://pkg.pr.new/@tanstack/react-router-devtools@8012

@tanstack/react-router-ssr-query
npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@8012

@tanstack/react-start
npm i https://pkg.pr.new/@tanstack/react-start@8012

@tanstack/react-start-client
npm i https://pkg.pr.new/@tanstack/react-start-client@8012

@tanstack/react-start-rsc
npm i https://pkg.pr.new/@tanstack/react-start-rsc@8012

@tanstack/react-start-server
npm i https://pkg.pr.new/@tanstack/react-start-server@8012

@tanstack/router-cli
npm i https://pkg.pr.new/@tanstack/router-cli@8012

@tanstack/router-core
npm i https://pkg.pr.new/@tanstack/router-core@8012

@tanstack/router-devtools
npm i https://pkg.pr.new/@tanstack/router-devtools@8012

@tanstack/router-devtools-core
npm i https://pkg.pr.new/@tanstack/router-devtools-core@8012

@tanstack/router-generator
npm i https://pkg.pr.new/@tanstack/router-generator@8012

@tanstack/router-plugin
npm i https://pkg.pr.new/@tanstack/router-plugin@8012

@tanstack/router-ssr-query-core
npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@8012

@tanstack/router-utils
npm i https://pkg.pr.new/@tanstack/router-utils@8012

@tanstack/router-vite-plugin
npm i https://pkg.pr.new/@tanstack/router-vite-plugin@8012

@tanstack/solid-router
npm i https://pkg.pr.new/@tanstack/solid-router@8012

@tanstack/solid-router-devtools
npm i https://pkg.pr.new/@tanstack/solid-router-devtools@8012

@tanstack/solid-router-ssr-query
npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@8012

@tanstack/solid-start
npm i https://pkg.pr.new/@tanstack/solid-start@8012

@tanstack/solid-start-client
npm i https://pkg.pr.new/@tanstack/solid-start-client@8012

@tanstack/solid-start-server
npm i https://pkg.pr.new/@tanstack/solid-start-server@8012

@tanstack/start-client-core
npm i https://pkg.pr.new/@tanstack/start-client-core@8012

@tanstack/start-fn-stubs
npm i https://pkg.pr.new/@tanstack/start-fn-stubs@8012

@tanstack/start-plugin-core
npm i https://pkg.pr.new/@tanstack/start-plugin-core@8012

@tanstack/start-server-core
npm i https://pkg.pr.new/@tanstack/start-server-core@8012

@tanstack/start-static-server-functions
npm i https://pkg.pr.new/@tanstack/start-static-server-functions@8012

@tanstack/start-storage-context
npm i https://pkg.pr.new/@tanstack/start-storage-context@8012

@tanstack/valibot-adapter
npm i https://pkg.pr.new/@tanstack/valibot-adapter@8012

@tanstack/virtual-file-routes
npm i https://pkg.pr.new/@tanstack/virtual-file-routes@8012

@tanstack/vue-router
npm i https://pkg.pr.new/@tanstack/vue-router@8012

@tanstack/vue-router-devtools
npm i https://pkg.pr.new/@tanstack/vue-router-devtools@8012

@tanstack/vue-router-ssr-query
npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@8012

@tanstack/vue-start
npm i https://pkg.pr.new/@tanstack/vue-start@8012

@tanstack/vue-start-client
npm i https://pkg.pr.new/@tanstack/vue-start-client@8012

@tanstack/vue-start-server
npm i https://pkg.pr.new/@tanstack/vue-start-server@8012

@tanstack/zod-adapter
npm i https://pkg.pr.new/@tanstack/zod-adapter@8012

commit: 0ae9eb0
@codspeed-hq
codspeed-hqBot
commented
Aug 8, 2026

Copy link


Copy Markdown

Merging this PR will degrade performance by 0.08%
⚠️Different runtime environments detected
Some benchmarks with significant performance changes were compared across different runtime environments,

which may affect the accuracy of the results.
Open the report in CodSpeed to investigate
⚡ 6 improved benchmarks
❌ 3 regressed benchmarks
✅ 171 untouched benchmarks
Warning
Please fix the performance issues or acknowledge them on CodSpeed.
Performance Changes
ModeBenchmarkBASEHEADEfficiency
❌Memorymem server error-paths redirect (vue)433.1 KB904.6 KB-52.13%
❌Memorymem server error-paths unmatched (solid)428.5 KB454.6 KB-5.75%
❌Memorymem server server-fn-churn (react)264.7 KB276.7 KB-4.31%
⚡Memorymem server error-paths not-found (solid)728.6 KB418.6 KB+74.03%
⚡Memorymem client preload-churn (vue)805.5 KB736.9 KB+9.32%
⚡Memorymem client navigation-churn (solid)575 KB528.4 KB+8.83%
⚡Simulationssr dehydrate rich types (solid)99.7 ms95.9 ms+4.01%
⚡Memorymem server error-paths unmatched (react)272.3 KB263.2 KB+3.48%
⚡Memorymem client unique-location-churn (solid)352.4 KB341.5 KB+3.18%
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing codex/server-search-serialization (0ae9eb0) with main (44a8c3e)
Open in CodSpeed
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

package: router-core

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@Sheraff

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
perf(router-core): optimize server search serialization - #8012
Draft
Sheraff wants to merge 1 commit into
mainfrom 
codex/server-search-serialization
Draft
perf(router-core): optimize server search serialization#8012
Sheraff wants to merge 1 commit into
mainfrom 
codex/server-search-serialization
Conversation
@Sheraff
@SheraffSheraff
commented
Aug 8, 2026

Copy link


Copy Markdown

Collaborator
What changed
  • Select a dedicated default search serializer behind the existing isServer conditional export.
  • Classify JSON primitives with an allocation-free scanner on the server, avoiding exception-heavy JSON.parse calls for impossible JSON and bypassing parsing for fully validated primitives.
  • Continue using the native parser for quoted strings, arrays, objects, and whitespace-prefixed values.
  • Preserve the compact perf(router-core): skip impossible JSON parse attempts #8006 client implementation and the existing path for custom parsers.
  • Add server-specific parity tests and focused performance benchmarks.
The environment check intentionally remains at serializer invocation time. The server isServer export also loads router code, so reading it while the serializer factory initializes can encounter the isServer -> load-server -> router -> searchParams module cycle.
Why
#8006 keeps the client fast path compact because every byte matters there. Server builds can dead-code-eliminate a larger implementation, allowing exact primitive validation and avoiding costly parser exceptions without increasing client bundles.
Performance
Measured with the same Vitest benchmark file against the exact merged #8006 implementation:
  • ordinary application strings: ~2.5% faster
  • realistic application distribution: ~6% faster
  • JSON primitive strings: ~26% faster
  • invalid number-like strings: ~54x faster
  • JSON-literal-prefix misses: ~47-53x faster
Inputs that still require the native parser remain within single-digit percentages of the baseline, and whitespace-prefixed structured inputs no longer have a length-amplifying double-scan regression.
The full 17-scenario client bundle matrix is byte-for-byte unchanged: zero delta for raw, gzip, Brotli, and initial gzip sizes.
Validation
  • @tanstack/router-core:test:unit: 106 files passed; 1,616 tests passed and 3 expected failures
  • @tanstack/router-core:test:types: TypeScript 5.6 through 7.0 passed
  • @tanstack/router-core:test:eslint: 0 errors
  • focused server Vitest benchmarks against the exact perf(router-core): skip impossible JSON parse attempts #8006 baseline
  • full bundle-size benchmark across all 17 scenarios
@coderabbitai
coderabbitaiBot
commented
Aug 8, 2026

Copy link


Copy Markdown

Contributor
Important
Review skipped
Draft detected.
Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 4ebbe526-aa87-441b-8d0b-166ee51d908c
You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.
Use the checkbox below for a quick retry:
  •  🔍 Trigger review
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands.
@nx-cloud
nx-cloudBot
commented
Aug 8, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
View your CI Pipeline Execution ↗ for commit 0ae9eb0
CommandStatusDurationResult
nx affected --targets=test:eslint,test:unit,tes...✅ Succeeded10m 23sView ↗
nx run-many --target=build --exclude=examples/*...✅ Succeeded2m 14sView ↗
☁️ Nx Cloud last updated this comment at 2026-08-08 17:58:29 UTC
@github-actions
github-actionsBot
commented
Aug 8, 2026

Copy link


Copy Markdown

Contributor
🚀 Changeset Version Preview
2 package(s) bumped directly, 21 bumped as dependents.
🟩 Patch bumps
PackageVersionReason
@tanstack/router-core1.171.19 → 1.171.20Changeset
@tanstack/start-client-core1.170.19 → 1.170.20Changeset
@tanstack/react-router1.170.23 → 1.170.24Dependent
@tanstack/react-start1.168.40 → 1.168.41Dependent
@tanstack/react-start-client1.168.21 → 1.168.22Dependent
@tanstack/react-start-rsc0.1.39 → 0.1.40Dependent
@tanstack/react-start-server1.167.28 → 1.167.29Dependent
@tanstack/router-cli1.167.25 → 1.167.26Dependent
@tanstack/router-generator1.167.25 → 1.167.26Dependent
@tanstack/router-plugin1.168.27 → 1.168.28Dependent
@tanstack/router-vite-plugin1.167.27 → 1.167.28Dependent
@tanstack/solid-router1.170.22 → 1.170.23Dependent
@tanstack/solid-start1.168.39 → 1.168.40Dependent
@tanstack/solid-start-client1.168.21 → 1.168.22Dependent
@tanstack/solid-start-server1.167.28 → 1.167.29Dependent
@tanstack/start-plugin-core1.171.31 → 1.171.32Dependent
@tanstack/start-server-core1.169.23 → 1.169.24Dependent
@tanstack/start-static-server-functions1.167.24 → 1.167.25Dependent
@tanstack/start-storage-context1.167.21 → 1.167.22Dependent
@tanstack/vue-router1.170.21 → 1.170.22Dependent
@tanstack/vue-start1.168.38 → 1.168.39Dependent
@tanstack/vue-start-client1.167.24 → 1.167.25Dependent
@tanstack/vue-start-server1.167.28 → 1.167.29Dependent
@github-actions
github-actionsBot
commented
Aug 8, 2026

Copy link


Copy Markdown

Contributor
Bundle Size Benchmarks
This pull request does not affect bundle size in any measured scenario.
@pkg-pr-new
pkg-pr-newBot
commented
Aug 8, 2026

Copy link


Copy Markdown

More templates
@tanstack/arktype-adapter
npm i https://pkg.pr.new/@tanstack/arktype-adapter@8012

@tanstack/eslint-plugin-router
npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@8012

@tanstack/eslint-plugin-start
npm i https://pkg.pr.new/@tanstack/eslint-plugin-start@8012

@tanstack/history
npm i https://pkg.pr.new/@tanstack/history@8012

@tanstack/nitro-v2-vite-plugin
npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@8012

@tanstack/react-router
npm i https://pkg.pr.new/@tanstack/react-router@8012

@tanstack/react-router-devtools
npm i https://pkg.pr.new/@tanstack/react-router-devtools@8012

@tanstack/react-router-ssr-query
npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@8012

@tanstack/react-start
npm i https://pkg.pr.new/@tanstack/react-start@8012

@tanstack/react-start-client
npm i https://pkg.pr.new/@tanstack/react-start-client@8012

@tanstack/react-start-rsc
npm i https://pkg.pr.new/@tanstack/react-start-rsc@8012

@tanstack/react-start-server
npm i https://pkg.pr.new/@tanstack/react-start-server@8012

@tanstack/router-cli
npm i https://pkg.pr.new/@tanstack/router-cli@8012

@tanstack/router-core
npm i https://pkg.pr.new/@tanstack/router-core@8012

@tanstack/router-devtools
npm i https://pkg.pr.new/@tanstack/router-devtools@8012

@tanstack/router-devtools-core
npm i https://pkg.pr.new/@tanstack/router-devtools-core@8012

@tanstack/router-generator
npm i https://pkg.pr.new/@tanstack/router-generator@8012

@tanstack/router-plugin
npm i https://pkg.pr.new/@tanstack/router-plugin@8012

@tanstack/router-ssr-query-core
npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@8012

@tanstack/router-utils
npm i https://pkg.pr.new/@tanstack/router-utils@8012

@tanstack/router-vite-plugin
npm i https://pkg.pr.new/@tanstack/router-vite-plugin@8012

@tanstack/solid-router
npm i https://pkg.pr.new/@tanstack/solid-router@8012

@tanstack/solid-router-devtools
npm i https://pkg.pr.new/@tanstack/solid-router-devtools@8012

@tanstack/solid-router-ssr-query
npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@8012

@tanstack/solid-start
npm i https://pkg.pr.new/@tanstack/solid-start@8012

@tanstack/solid-start-client
npm i https://pkg.pr.new/@tanstack/solid-start-client@8012

@tanstack/solid-start-server
npm i https://pkg.pr.new/@tanstack/solid-start-server@8012

@tanstack/start-client-core
npm i https://pkg.pr.new/@tanstack/start-client-core@8012

@tanstack/start-fn-stubs
npm i https://pkg.pr.new/@tanstack/start-fn-stubs@8012

@tanstack/start-plugin-core
npm i https://pkg.pr.new/@tanstack/start-plugin-core@8012

@tanstack/start-server-core
npm i https://pkg.pr.new/@tanstack/start-server-core@8012

@tanstack/start-static-server-functions
npm i https://pkg.pr.new/@tanstack/start-static-server-functions@8012

@tanstack/start-storage-context
npm i https://pkg.pr.new/@tanstack/start-storage-context@8012

@tanstack/valibot-adapter
npm i https://pkg.pr.new/@tanstack/valibot-adapter@8012

@tanstack/virtual-file-routes
npm i https://pkg.pr.new/@tanstack/virtual-file-routes@8012

@tanstack/vue-router
npm i https://pkg.pr.new/@tanstack/vue-router@8012

@tanstack/vue-router-devtools
npm i https://pkg.pr.new/@tanstack/vue-router-devtools@8012

@tanstack/vue-router-ssr-query
npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@8012

@tanstack/vue-start
npm i https://pkg.pr.new/@tanstack/vue-start@8012

@tanstack/vue-start-client
npm i https://pkg.pr.new/@tanstack/vue-start-client@8012

@tanstack/vue-start-server
npm i https://pkg.pr.new/@tanstack/vue-start-server@8012

@tanstack/zod-adapter
npm i https://pkg.pr.new/@tanstack/zod-adapter@8012

commit: 0ae9eb0
@codspeed-hq
codspeed-hqBot
commented
Aug 8, 2026

Copy link


Copy Markdown

Merging this PR will degrade performance by 0.08%
⚠️Different runtime environments detected
Some benchmarks with significant performance changes were compared across different runtime environments,

which may affect the accuracy of the results.
Open the report in CodSpeed to investigate
⚡ 6 improved benchmarks
❌ 3 regressed benchmarks
✅ 171 untouched benchmarks
Warning
Please fix the performance issues or acknowledge them on CodSpeed.
Performance Changes
ModeBenchmarkBASEHEADEfficiency
❌Memorymem server error-paths redirect (vue)433.1 KB904.6 KB-52.13%
❌Memorymem server error-paths unmatched (solid)428.5 KB454.6 KB-5.75%
❌Memorymem server server-fn-churn (react)264.7 KB276.7 KB-4.31%
⚡Memorymem server error-paths not-found (solid)728.6 KB418.6 KB+74.03%
⚡Memorymem client preload-churn (vue)805.5 KB736.9 KB+9.32%
⚡Memorymem client navigation-churn (solid)575 KB528.4 KB+8.83%
⚡Simulationssr dehydrate rich types (solid)99.7 ms95.9 ms+4.01%
⚡Memorymem server error-paths unmatched (react)272.3 KB263.2 KB+3.48%
⚡Memorymem client unique-location-churn (solid)352.4 KB341.5 KB+3.18%
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing codex/server-search-serialization (0ae9eb0) with main (44a8c3e)
Open in CodSpeed
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

package: router-core

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@Sheraff

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
perf(router-core): optimize server search serialization - #8012
Draft
Sheraff wants to merge 1 commit into
mainfrom 
codex/server-search-serialization
Draft
perf(router-core): optimize server search serialization#8012
Sheraff wants to merge 1 commit into
mainfrom 
codex/server-search-serialization
Conversation
@Sheraff
@SheraffSheraff
commented
Aug 8, 2026

Copy link


Copy Markdown

Collaborator
What changed
  • Select a dedicated default search serializer behind the existing isServer conditional export.
  • Classify JSON primitives with an allocation-free scanner on the server, avoiding exception-heavy JSON.parse calls for impossible JSON and bypassing parsing for fully validated primitives.
  • Continue using the native parser for quoted strings, arrays, objects, and whitespace-prefixed values.
  • Preserve the compact perf(router-core): skip impossible JSON parse attempts #8006 client implementation and the existing path for custom parsers.
  • Add server-specific parity tests and focused performance benchmarks.
The environment check intentionally remains at serializer invocation time. The server isServer export also loads router code, so reading it while the serializer factory initializes can encounter the isServer -> load-server -> router -> searchParams module cycle.
Why
#8006 keeps the client fast path compact because every byte matters there. Server builds can dead-code-eliminate a larger implementation, allowing exact primitive validation and avoiding costly parser exceptions without increasing client bundles.
Performance
Measured with the same Vitest benchmark file against the exact merged #8006 implementation:
  • ordinary application strings: ~2.5% faster
  • realistic application distribution: ~6% faster
  • JSON primitive strings: ~26% faster
  • invalid number-like strings: ~54x faster
  • JSON-literal-prefix misses: ~47-53x faster
Inputs that still require the native parser remain within single-digit percentages of the baseline, and whitespace-prefixed structured inputs no longer have a length-amplifying double-scan regression.
The full 17-scenario client bundle matrix is byte-for-byte unchanged: zero delta for raw, gzip, Brotli, and initial gzip sizes.
Validation
  • @tanstack/router-core:test:unit: 106 files passed; 1,616 tests passed and 3 expected failures
  • @tanstack/router-core:test:types: TypeScript 5.6 through 7.0 passed
  • @tanstack/router-core:test:eslint: 0 errors
  • focused server Vitest benchmarks against the exact perf(router-core): skip impossible JSON parse attempts #8006 baseline
  • full bundle-size benchmark across all 17 scenarios
@coderabbitai
coderabbitaiBot
commented
Aug 8, 2026

Copy link


Copy Markdown

Contributor
Important
Review skipped
Draft detected.
Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 4ebbe526-aa87-441b-8d0b-166ee51d908c
You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.
Use the checkbox below for a quick retry:
  •  🔍 Trigger review
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands.
@nx-cloud
nx-cloudBot
commented
Aug 8, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
View your CI Pipeline Execution ↗ for commit 0ae9eb0
CommandStatusDurationResult
nx affected --targets=test:eslint,test:unit,tes...✅ Succeeded10m 23sView ↗
nx run-many --target=build --exclude=examples/*...✅ Succeeded2m 14sView ↗
☁️ Nx Cloud last updated this comment at 2026-08-08 17:58:29 UTC
@github-actions
github-actionsBot
commented
Aug 8, 2026

Copy link


Copy Markdown

Contributor
🚀 Changeset Version Preview
2 package(s) bumped directly, 21 bumped as dependents.
🟩 Patch bumps
PackageVersionReason
@tanstack/router-core1.171.19 → 1.171.20Changeset
@tanstack/start-client-core1.170.19 → 1.170.20Changeset
@tanstack/react-router1.170.23 → 1.170.24Dependent
@tanstack/react-start1.168.40 → 1.168.41Dependent
@tanstack/react-start-client1.168.21 → 1.168.22Dependent
@tanstack/react-start-rsc0.1.39 → 0.1.40Dependent
@tanstack/react-start-server1.167.28 → 1.167.29Dependent
@tanstack/router-cli1.167.25 → 1.167.26Dependent
@tanstack/router-generator1.167.25 → 1.167.26Dependent
@tanstack/router-plugin1.168.27 → 1.168.28Dependent
@tanstack/router-vite-plugin1.167.27 → 1.167.28Dependent
@tanstack/solid-router1.170.22 → 1.170.23Dependent
@tanstack/solid-start1.168.39 → 1.168.40Dependent
@tanstack/solid-start-client1.168.21 → 1.168.22Dependent
@tanstack/solid-start-server1.167.28 → 1.167.29Dependent
@tanstack/start-plugin-core1.171.31 → 1.171.32Dependent
@tanstack/start-server-core1.169.23 → 1.169.24Dependent
@tanstack/start-static-server-functions1.167.24 → 1.167.25Dependent
@tanstack/start-storage-context1.167.21 → 1.167.22Dependent
@tanstack/vue-router1.170.21 → 1.170.22Dependent
@tanstack/vue-start1.168.38 → 1.168.39Dependent
@tanstack/vue-start-client1.167.24 → 1.167.25Dependent
@tanstack/vue-start-server1.167.28 → 1.167.29Dependent
@github-actions
github-actionsBot
commented
Aug 8, 2026

Copy link


Copy Markdown

Contributor
Bundle Size Benchmarks
This pull request does not affect bundle size in any measured scenario.
@pkg-pr-new
pkg-pr-newBot
commented
Aug 8, 2026

Copy link


Copy Markdown

More templates
@tanstack/arktype-adapter
npm i https://pkg.pr.new/@tanstack/arktype-adapter@8012

@tanstack/eslint-plugin-router
npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@8012

@tanstack/eslint-plugin-start
npm i https://pkg.pr.new/@tanstack/eslint-plugin-start@8012

@tanstack/history
npm i https://pkg.pr.new/@tanstack/history@8012

@tanstack/nitro-v2-vite-plugin
npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@8012

@tanstack/react-router
npm i https://pkg.pr.new/@tanstack/react-router@8012

@tanstack/react-router-devtools
npm i https://pkg.pr.new/@tanstack/react-router-devtools@8012

@tanstack/react-router-ssr-query
npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@8012

@tanstack/react-start
npm i https://pkg.pr.new/@tanstack/react-start@8012

@tanstack/react-start-client
npm i https://pkg.pr.new/@tanstack/react-start-client@8012

@tanstack/react-start-rsc
npm i https://pkg.pr.new/@tanstack/react-start-rsc@8012

@tanstack/react-start-server
npm i https://pkg.pr.new/@tanstack/react-start-server@8012

@tanstack/router-cli
npm i https://pkg.pr.new/@tanstack/router-cli@8012

@tanstack/router-core
npm i https://pkg.pr.new/@tanstack/router-core@8012

@tanstack/router-devtools
npm i https://pkg.pr.new/@tanstack/router-devtools@8012

@tanstack/router-devtools-core
npm i https://pkg.pr.new/@tanstack/router-devtools-core@8012

@tanstack/router-generator
npm i https://pkg.pr.new/@tanstack/router-generator@8012

@tanstack/router-plugin
npm i https://pkg.pr.new/@tanstack/router-plugin@8012

@tanstack/router-ssr-query-core
npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@8012

@tanstack/router-utils
npm i https://pkg.pr.new/@tanstack/router-utils@8012

@tanstack/router-vite-plugin
npm i https://pkg.pr.new/@tanstack/router-vite-plugin@8012

@tanstack/solid-router
npm i https://pkg.pr.new/@tanstack/solid-router@8012

@tanstack/solid-router-devtools
npm i https://pkg.pr.new/@tanstack/solid-router-devtools@8012

@tanstack/solid-router-ssr-query
npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@8012

@tanstack/solid-start
npm i https://pkg.pr.new/@tanstack/solid-start@8012

@tanstack/solid-start-client
npm i https://pkg.pr.new/@tanstack/solid-start-client@8012

@tanstack/solid-start-server
npm i https://pkg.pr.new/@tanstack/solid-start-server@8012

@tanstack/start-client-core
npm i https://pkg.pr.new/@tanstack/start-client-core@8012

@tanstack/start-fn-stubs
npm i https://pkg.pr.new/@tanstack/start-fn-stubs@8012

@tanstack/start-plugin-core
npm i https://pkg.pr.new/@tanstack/start-plugin-core@8012

@tanstack/start-server-core
npm i https://pkg.pr.new/@tanstack/start-server-core@8012

@tanstack/start-static-server-functions
npm i https://pkg.pr.new/@tanstack/start-static-server-functions@8012

@tanstack/start-storage-context
npm i https://pkg.pr.new/@tanstack/start-storage-context@8012

@tanstack/valibot-adapter
npm i https://pkg.pr.new/@tanstack/valibot-adapter@8012

@tanstack/virtual-file-routes
npm i https://pkg.pr.new/@tanstack/virtual-file-routes@8012

@tanstack/vue-router
npm i https://pkg.pr.new/@tanstack/vue-router@8012

@tanstack/vue-router-devtools
npm i https://pkg.pr.new/@tanstack/vue-router-devtools@8012

@tanstack/vue-router-ssr-query
npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@8012

@tanstack/vue-start
npm i https://pkg.pr.new/@tanstack/vue-start@8012

@tanstack/vue-start-client
npm i https://pkg.pr.new/@tanstack/vue-start-client@8012

@tanstack/vue-start-server
npm i https://pkg.pr.new/@tanstack/vue-start-server@8012

@tanstack/zod-adapter
npm i https://pkg.pr.new/@tanstack/zod-adapter@8012

commit: 0ae9eb0
@codspeed-hq
codspeed-hqBot
commented
Aug 8, 2026

Copy link


Copy Markdown

Merging this PR will degrade performance by 0.08%
⚠️Different runtime environments detected
Some benchmarks with significant performance changes were compared across different runtime environments,

which may affect the accuracy of the results.
Open the report in CodSpeed to investigate
⚡ 6 improved benchmarks
❌ 3 regressed benchmarks
✅ 171 untouched benchmarks
Warning
Please fix the performance issues or acknowledge them on CodSpeed.
Performance Changes
ModeBenchmarkBASEHEADEfficiency
❌Memorymem server error-paths redirect (vue)433.1 KB904.6 KB-52.13%
❌Memorymem server error-paths unmatched (solid)428.5 KB454.6 KB-5.75%
❌Memorymem server server-fn-churn (react)264.7 KB276.7 KB-4.31%
⚡Memorymem server error-paths not-found (solid)728.6 KB418.6 KB+74.03%
⚡Memorymem client preload-churn (vue)805.5 KB736.9 KB+9.32%
⚡Memorymem client navigation-churn (solid)575 KB528.4 KB+8.83%
⚡Simulationssr dehydrate rich types (solid)99.7 ms95.9 ms+4.01%
⚡Memorymem server error-paths unmatched (react)272.3 KB263.2 KB+3.48%
⚡Memorymem client unique-location-churn (solid)352.4 KB341.5 KB+3.18%
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing codex/server-search-serialization (0ae9eb0) with main (44a8c3e)
Open in CodSpeed
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

package: router-core

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@Sheraff