perf(router-core): skip impossible JSON parses during search parsing - #8013

Draft
Sheraff wants to merge 1 commit into
mainfrom
perf/router-core-search-parse-fast-path
Draft

perf(router-core): skip impossible JSON parses during search parsing#8013
Sheraff wants to merge 1 commit into
mainfrom
perf/router-core-search-parse-fast-path

Conversation

@Sheraff

@SheraffSheraff commented Aug 8, 2026•
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Collaborator

Summary

  • apply the existing jsonStart fast path to parseSearchWith when using JSON.parse
  • preserve custom parser behavior and cover both paths with unit tests
  • add default search parsing benchmark scenarios and a patch changeset

Testing

  • CI=1 NX_DAEMON=false pnpm nx run @tanstack/router-core:test:unit --outputStyle=stream --skipRemoteCache -- tests/searchParams.test.ts
  • CI=1 NX_DAEMON=false pnpm nx run @tanstack/router-core:test:types --outputStyle=stream --skipRemoteCache
  • CI=1 NX_DAEMON=false pnpm nx run @tanstack/router-core:test:eslint --outputStyle=stream --skipRemoteCache
  • CI=1 NX_DAEMON=false pnpm nx run @tanstack/router-core:test:unit --outputStyle=stream --skipRemoteCache -- bench tests/searchParams.bench.ts --run

Summary by CodeRabbit

  • Bug Fixes

    • Improved search-parameter parsing by skipping values that cannot be valid JSON.
    • Preserved existing parsing behavior and silent error handling for eligible values.

  • Performance

    • Reduced unnecessary JSON parsing during search-parameter processing.

  • Tests

    • Added coverage for custom parsing, decoded parameters, invalid JSON values, and parsing performance.

@nx-cloud

nx-cloudBot commented Aug 8, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

View your CI Pipeline Execution ↗ for commit bfb5233

CommandStatusDurationResult
nx affected --targets=test:eslint,test:unit,tes...✅ Succeeded11m 58sView ↗
nx run-many --target=build --exclude=examples/*...✅ Succeeded2m 6sView ↗

☁️ Nx Cloud last updated this comment at 2026-08-08 18:40:15 UTC

@github-actions

github-actionsBot commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

🚀 Changeset Version Preview

2 package(s) bumped directly, 21 bumped as dependents.

🟩 Patch bumps

PackageVersionReason
@tanstack/router-core1.171.19 → 1.171.20Changeset
@tanstack/start-client-core1.170.19 → 1.170.20Changeset
@tanstack/react-router1.170.23 → 1.170.24Dependent
@tanstack/react-start1.168.40 → 1.168.41Dependent
@tanstack/react-start-client1.168.21 → 1.168.22Dependent
@tanstack/react-start-rsc0.1.39 → 0.1.40Dependent
@tanstack/react-start-server1.167.28 → 1.167.29Dependent
@tanstack/router-cli1.167.25 → 1.167.26Dependent
@tanstack/router-generator1.167.25 → 1.167.26Dependent
@tanstack/router-plugin1.168.27 → 1.168.28Dependent
@tanstack/router-vite-plugin1.167.27 → 1.167.28Dependent
@tanstack/solid-router1.170.22 → 1.170.23Dependent
@tanstack/solid-start1.168.39 → 1.168.40Dependent
@tanstack/solid-start-client1.168.21 → 1.168.22Dependent
@tanstack/solid-start-server1.167.28 → 1.167.29Dependent
@tanstack/start-plugin-core1.171.31 → 1.171.32Dependent
@tanstack/start-server-core1.169.23 → 1.169.24Dependent
@tanstack/start-static-server-functions1.167.24 → 1.167.25Dependent
@tanstack/start-storage-context1.167.21 → 1.167.22Dependent
@tanstack/vue-router1.170.21 → 1.170.22Dependent
@tanstack/vue-start1.168.38 → 1.168.39Dependent
@tanstack/vue-start-client1.167.24 → 1.167.25Dependent
@tanstack/vue-start-server1.167.28 → 1.167.29Dependent

@coderabbitai

coderabbitaiBot commented Aug 8, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 25e0496d-f38b-4880-b2e3-8de1cae4b5bf

📥 Commits

Reviewing files that changed from the base of the PR and between 44a8c3e and bfb5233.

📒 Files selected for processing (4)
  • .changeset/fast-search-parsing.md
  • packages/router-core/src/searchParams.ts
  • packages/router-core/tests/searchParams.bench.ts
  • packages/router-core/tests/searchParams.test.ts
📝 Walkthrough

Walkthrough

parseSearchWith now skips native JSON.parse attempts for values that cannot begin valid JSON. Tests cover custom parsers and skipped calls. Benchmarks measure parsing across several search-parameter value sets. A patch Changeset documents the behavior.

Changes

Search parameter parsing

Layer / File(s)Summary
Parser optimization and validation
packages/router-core/src/searchParams.ts, packages/router-core/tests/searchParams.test.ts, .changeset/fast-search-parsing.md		parseSearchWith detects native JSON.parse and skips values that cannot begin valid JSON. Tests cover custom parser output, decoded values, and skipped JSON.parse calls.
Parsing benchmark coverage
packages/router-core/tests/searchParams.bench.ts		Benchmarks parse ordinary, JSON-initial, JSON-compatible, and mixed serialized search values. Round-trip assertions validate the prepared fixtures.

Estimated code review effort: 2 (Simple) | ~15 minutes

Possibly related PRs

  • TanStack/router#8006: Both changes update parseSearchWith to skip impossible JSON.parse attempts and add related tests and Changesets.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly and concisely describes the main performance change in search parsing.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch perf/router-core-search-parse-fast-path

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actionsBot commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

Bundle Size Benchmarks

  • Commit: 6f3a5ba67da0
  • Measured at: 2026-08-08T18:29:25.678Z
  • Baseline source: history:44a8c3e1d2af
  • Dashboard: bundle-size history

The following scenarios have bundle-size changes compared with the baseline:

ScenarioCurrent (gzip)Delta vs baselineInitial gzipRawBrotliTrend
react-router.minimal83.93 KiB+18 B (+0.02%)83.80 KiB262.72 KiB73.03 KiB███████▁▁▁▁▁
react-router.full87.45 KiB+18 B (+0.02%)87.31 KiB274.43 KiB76.16 KiB███████▁▁▁▁▁
solid-router.minimal33.26 KiB+20 B (+0.06%)33.13 KiB96.55 KiB30.05 KiB███████▁▁▁▁▁
solid-router.full38.08 KiB+17 B (+0.04%)37.96 KiB111.19 KiB34.30 KiB███████▁▁▁▁▁
vue-router.minimal49.54 KiB+20 B (+0.04%)49.42 KiB138.30 KiB44.75 KiB███████▁▁▁▁▁
vue-router.full55.12 KiB+16 B (+0.03%)55.00 KiB156.47 KiB49.64 KiB███████▁▁▁▁▁
react-start.minimal96.77 KiB+16 B (+0.02%)96.64 KiB304.93 KiB83.86 KiB███████▁▁▁▁▁
react-start.deferred-hydration97.50 KiB+16 B (+0.02%)96.66 KiB306.29 KiB84.51 KiB███████▁▁▁▁▁
react-start.full99.94 KiB+20 B (+0.02%)99.80 KiB314.65 KiB86.61 KiB███████▁▁▁▁▁
react-start.rsbuild.minimal100.08 KiB+18 B (+0.02%)99.91 KiB315.48 KiB86.35 KiB▁▄▄▃▃▄▄▄▄▆▇█
react-start.rsbuild.minimal-iife100.49 KiB+19 B (+0.02%)100.32 KiB316.42 KiB86.61 KiB▁▄▄▃▃▄▄▄▄▆▇█
react-start.rsbuild.full103.41 KiB+17 B (+0.02%)103.24 KiB325.57 KiB89.02 KiB▁▃▃▃▃▄▄▄▄▆▇█
solid-start.minimal46.03 KiB+16 B (+0.03%)45.90 KiB137.61 KiB40.94 KiB███████▁▁▁▁▁
solid-start.deferred-hydration49.10 KiB+15 B (+0.03%)45.96 KiB145.07 KiB43.73 KiB███████▁▁▁▁▁
solid-start.full51.11 KiB+17 B (+0.03%)50.98 KiB153.00 KiB45.31 KiB███████▁▁▁▁▁
vue-start.minimal65.56 KiB+14 B (+0.02%)65.44 KiB189.12 KiB58.36 KiB███████▁▁▁▁▁
vue-start.full69.39 KiB+19 B (+0.03%)69.26 KiB201.40 KiB61.67 KiB███████▁▁▁▁▁

Current gzip tracks all emitted client JS chunks. Initial gzip tracks only the entry/import graph. Trend sparkline is historical current gzip ending with this PR measurement; lower is better.

@pkg-pr-new

pkg-pr-newBot commented Aug 8, 2026

Copy link
Copy Markdown
More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/@tanstack/arktype-adapter@8013

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@8013

@tanstack/eslint-plugin-start

npm i https://pkg.pr.new/@tanstack/eslint-plugin-start@8013

@tanstack/history

npm i https://pkg.pr.new/@tanstack/history@8013

@tanstack/nitro-v2-vite-plugin

npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@8013

@tanstack/react-router

npm i https://pkg.pr.new/@tanstack/react-router@8013

@tanstack/react-router-devtools

npm i https://pkg.pr.new/@tanstack/react-router-devtools@8013

@tanstack/react-router-ssr-query

npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@8013

@tanstack/react-start

npm i https://pkg.pr.new/@tanstack/react-start@8013

@tanstack/react-start-client

npm i https://pkg.pr.new/@tanstack/react-start-client@8013

@tanstack/react-start-rsc

npm i https://pkg.pr.new/@tanstack/react-start-rsc@8013

@tanstack/react-start-server

npm i https://pkg.pr.new/@tanstack/react-start-server@8013

@tanstack/router-cli

npm i https://pkg.pr.new/@tanstack/router-cli@8013

@tanstack/router-core

npm i https://pkg.pr.new/@tanstack/router-core@8013

@tanstack/router-devtools

npm i https://pkg.pr.new/@tanstack/router-devtools@8013

@tanstack/router-devtools-core

npm i https://pkg.pr.new/@tanstack/router-devtools-core@8013

@tanstack/router-generator

npm i https://pkg.pr.new/@tanstack/router-generator@8013

@tanstack/router-plugin

npm i https://pkg.pr.new/@tanstack/router-plugin@8013

@tanstack/router-ssr-query-core

npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@8013

@tanstack/router-utils

npm i https://pkg.pr.new/@tanstack/router-utils@8013

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/@tanstack/router-vite-plugin@8013

@tanstack/solid-router

npm i https://pkg.pr.new/@tanstack/solid-router@8013

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/@tanstack/solid-router-devtools@8013

@tanstack/solid-router-ssr-query

npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@8013

@tanstack/solid-start

npm i https://pkg.pr.new/@tanstack/solid-start@8013

@tanstack/solid-start-client

npm i https://pkg.pr.new/@tanstack/solid-start-client@8013

@tanstack/solid-start-server

npm i https://pkg.pr.new/@tanstack/solid-start-server@8013

@tanstack/start-client-core

npm i https://pkg.pr.new/@tanstack/start-client-core@8013

@tanstack/start-fn-stubs

npm i https://pkg.pr.new/@tanstack/start-fn-stubs@8013

@tanstack/start-plugin-core

npm i https://pkg.pr.new/@tanstack/start-plugin-core@8013

@tanstack/start-server-core

npm i https://pkg.pr.new/@tanstack/start-server-core@8013

@tanstack/start-static-server-functions

npm i https://pkg.pr.new/@tanstack/start-static-server-functions@8013

@tanstack/start-storage-context

npm i https://pkg.pr.new/@tanstack/start-storage-context@8013

@tanstack/valibot-adapter

npm i https://pkg.pr.new/@tanstack/valibot-adapter@8013

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/@tanstack/virtual-file-routes@8013

@tanstack/vue-router

npm i https://pkg.pr.new/@tanstack/vue-router@8013

@tanstack/vue-router-devtools

npm i https://pkg.pr.new/@tanstack/vue-router-devtools@8013

@tanstack/vue-router-ssr-query

npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@8013

@tanstack/vue-start

npm i https://pkg.pr.new/@tanstack/vue-start@8013

@tanstack/vue-start-client

npm i https://pkg.pr.new/@tanstack/vue-start-client@8013

@tanstack/vue-start-server

npm i https://pkg.pr.new/@tanstack/vue-start-server@8013

@tanstack/zod-adapter

npm i https://pkg.pr.new/@tanstack/zod-adapter@8013

commit: bfb5233

@codspeed-hq

codspeed-hqBot commented Aug 8, 2026

Copy link
Copy Markdown

Merging this PR will degrade performance by 10.71%

⚠️Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 3 improved benchmarks
❌ 5 regressed benchmarks
✅ 172 untouched benchmarks

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

ModeBenchmarkBASEHEADEfficiency
❌Memorymem server error-paths unmatched (react)272.3 KB849.3 KB-67.93%
❌Memorymem client unique-location-churn (solid)352.4 KB457.4 KB-22.96%
❌Memorymem client navigation-churn (solid)575 KB629 KB-8.58%
❌Memorymem client unique-location-churn (vue)1.2 MB1.3 MB-6.16%
❌Memorymem server server-fn-churn (vue)263.2 KB274.8 KB-4.21%
⚡Memorymem server error-paths not-found (solid)728.6 KB417 KB+74.72%
⚡Memorymem client preload-churn (vue)805.5 KB736.6 KB+9.35%
⚡Memorymem server error-paths not-found (react)260.8 KB250.3 KB+4.18%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.

Comparing perf/router-core-search-parse-fast-path (bfb5233) with main (44a8c3e)

Open in CodSpeed

@Sheraff
Sheraff marked this pull request as draft August 9, 2026 06:25
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

package: router-core

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Sheraff
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
perf(router-core): skip impossible JSON parses during search parsing - #8013
Draft
Sheraff wants to merge 1 commit into
mainfrom 
perf/router-core-search-parse-fast-path
Draft
perf(router-core): skip impossible JSON parses during search parsing#8013
Sheraff wants to merge 1 commit into
mainfrom 
perf/router-core-search-parse-fast-path
Conversation
@Sheraff
@SheraffSheraff
commented
Aug 8, 2026•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Collaborator
Summary
  • apply the existing jsonStart fast path to parseSearchWith when using JSON.parse
  • preserve custom parser behavior and cover both paths with unit tests
  • add default search parsing benchmark scenarios and a patch changeset
Testing
  • CI=1 NX_DAEMON=false pnpm nx run @tanstack/router-core:test:unit --outputStyle=stream --skipRemoteCache -- tests/searchParams.test.ts
  • CI=1 NX_DAEMON=false pnpm nx run @tanstack/router-core:test:types --outputStyle=stream --skipRemoteCache
  • CI=1 NX_DAEMON=false pnpm nx run @tanstack/router-core:test:eslint --outputStyle=stream --skipRemoteCache
  • CI=1 NX_DAEMON=false pnpm nx run @tanstack/router-core:test:unit --outputStyle=stream --skipRemoteCache -- bench tests/searchParams.bench.ts --run
Summary by CodeRabbit
  • Bug Fixes
    • Improved search-parameter parsing by skipping values that cannot be valid JSON.
    • Preserved existing parsing behavior and silent error handling for eligible values.
  • Performance
    • Reduced unnecessary JSON parsing during search-parameter processing.
  • Tests
    • Added coverage for custom parsing, decoded parameters, invalid JSON values, and parsing performance.
@nx-cloud
nx-cloudBot
commented
Aug 8, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
View your CI Pipeline Execution ↗ for commit bfb5233
CommandStatusDurationResult
nx affected --targets=test:eslint,test:unit,tes...✅ Succeeded11m 58sView ↗
nx run-many --target=build --exclude=examples/*...✅ Succeeded2m 6sView ↗
☁️ Nx Cloud last updated this comment at 2026-08-08 18:40:15 UTC
@github-actions
github-actionsBot
commented
Aug 8, 2026

Copy link


Copy Markdown

Contributor
🚀 Changeset Version Preview
2 package(s) bumped directly, 21 bumped as dependents.
🟩 Patch bumps
PackageVersionReason
@tanstack/router-core1.171.19 → 1.171.20Changeset
@tanstack/start-client-core1.170.19 → 1.170.20Changeset
@tanstack/react-router1.170.23 → 1.170.24Dependent
@tanstack/react-start1.168.40 → 1.168.41Dependent
@tanstack/react-start-client1.168.21 → 1.168.22Dependent
@tanstack/react-start-rsc0.1.39 → 0.1.40Dependent
@tanstack/react-start-server1.167.28 → 1.167.29Dependent
@tanstack/router-cli1.167.25 → 1.167.26Dependent
@tanstack/router-generator1.167.25 → 1.167.26Dependent
@tanstack/router-plugin1.168.27 → 1.168.28Dependent
@tanstack/router-vite-plugin1.167.27 → 1.167.28Dependent
@tanstack/solid-router1.170.22 → 1.170.23Dependent
@tanstack/solid-start1.168.39 → 1.168.40Dependent
@tanstack/solid-start-client1.168.21 → 1.168.22Dependent
@tanstack/solid-start-server1.167.28 → 1.167.29Dependent
@tanstack/start-plugin-core1.171.31 → 1.171.32Dependent
@tanstack/start-server-core1.169.23 → 1.169.24Dependent
@tanstack/start-static-server-functions1.167.24 → 1.167.25Dependent
@tanstack/start-storage-context1.167.21 → 1.167.22Dependent
@tanstack/vue-router1.170.21 → 1.170.22Dependent
@tanstack/vue-start1.168.38 → 1.168.39Dependent
@tanstack/vue-start-client1.167.24 → 1.167.25Dependent
@tanstack/vue-start-server1.167.28 → 1.167.29Dependent
@coderabbitai
coderabbitaiBot
commented
Aug 8, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Review Change Stack
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 25e0496d-f38b-4880-b2e3-8de1cae4b5bf
📥 Commits
Reviewing files that changed from the base of the PR and between 44a8c3e and bfb5233.
📒 Files selected for processing (4)
  • .changeset/fast-search-parsing.md
  • packages/router-core/src/searchParams.ts
  • packages/router-core/tests/searchParams.bench.ts
  • packages/router-core/tests/searchParams.test.ts
📝 Walkthrough
Walkthrough
parseSearchWith now skips native JSON.parse attempts for values that cannot begin valid JSON. Tests cover custom parsers and skipped calls. Benchmarks measure parsing across several search-parameter value sets. A patch Changeset documents the behavior.
Changes
Search parameter parsing
Layer / File(s)Summary
Parser optimization and validation
packages/router-core/src/searchParams.ts, packages/router-core/tests/searchParams.test.ts, .changeset/fast-search-parsing.md		parseSearchWith detects native JSON.parse and skips values that cannot begin valid JSON. Tests cover custom parser output, decoded values, and skipped JSON.parse calls.
Parsing benchmark coverage
packages/router-core/tests/searchParams.bench.ts		Benchmarks parse ordinary, JSON-initial, JSON-compatible, and mixed serialized search values. Round-trip assertions validate the prepared fixtures.
Estimated code review effort: 2 (Simple) | ~15 minutes
Possibly related PRs
  • TanStack/router#8006: Both changes update parseSearchWith to skip impossible JSON.parse attempts and add related tests and Changesets.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly and concisely describes the main performance change in search parsing.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  •  Create stacked PR
  •  Commit on current branch
🧪 Generate unit tests (beta)
  •  Create PR with unit tests
  •  Commit unit tests in branch perf/router-core-search-parse-fast-path
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands.
@github-actions
github-actionsBot
commented
Aug 8, 2026

Copy link


Copy Markdown

Contributor
Bundle Size Benchmarks
  • Commit: 6f3a5ba67da0
  • Measured at: 2026-08-08T18:29:25.678Z
  • Baseline source: history:44a8c3e1d2af
  • Dashboard: bundle-size history
The following scenarios have bundle-size changes compared with the baseline:
ScenarioCurrent (gzip)Delta vs baselineInitial gzipRawBrotliTrend
react-router.minimal83.93 KiB+18 B (+0.02%)83.80 KiB262.72 KiB73.03 KiB███████▁▁▁▁▁
react-router.full87.45 KiB+18 B (+0.02%)87.31 KiB274.43 KiB76.16 KiB███████▁▁▁▁▁
solid-router.minimal33.26 KiB+20 B (+0.06%)33.13 KiB96.55 KiB30.05 KiB███████▁▁▁▁▁
solid-router.full38.08 KiB+17 B (+0.04%)37.96 KiB111.19 KiB34.30 KiB███████▁▁▁▁▁
vue-router.minimal49.54 KiB+20 B (+0.04%)49.42 KiB138.30 KiB44.75 KiB███████▁▁▁▁▁
vue-router.full55.12 KiB+16 B (+0.03%)55.00 KiB156.47 KiB49.64 KiB███████▁▁▁▁▁
react-start.minimal96.77 KiB+16 B (+0.02%)96.64 KiB304.93 KiB83.86 KiB███████▁▁▁▁▁
react-start.deferred-hydration97.50 KiB+16 B (+0.02%)96.66 KiB306.29 KiB84.51 KiB███████▁▁▁▁▁
react-start.full99.94 KiB+20 B (+0.02%)99.80 KiB314.65 KiB86.61 KiB███████▁▁▁▁▁
react-start.rsbuild.minimal100.08 KiB+18 B (+0.02%)99.91 KiB315.48 KiB86.35 KiB▁▄▄▃▃▄▄▄▄▆▇█
react-start.rsbuild.minimal-iife100.49 KiB+19 B (+0.02%)100.32 KiB316.42 KiB86.61 KiB▁▄▄▃▃▄▄▄▄▆▇█
react-start.rsbuild.full103.41 KiB+17 B (+0.02%)103.24 KiB325.57 KiB89.02 KiB▁▃▃▃▃▄▄▄▄▆▇█
solid-start.minimal46.03 KiB+16 B (+0.03%)45.90 KiB137.61 KiB40.94 KiB███████▁▁▁▁▁
solid-start.deferred-hydration49.10 KiB+15 B (+0.03%)45.96 KiB145.07 KiB43.73 KiB███████▁▁▁▁▁
solid-start.full51.11 KiB+17 B (+0.03%)50.98 KiB153.00 KiB45.31 KiB███████▁▁▁▁▁
vue-start.minimal65.56 KiB+14 B (+0.02%)65.44 KiB189.12 KiB58.36 KiB███████▁▁▁▁▁
vue-start.full69.39 KiB+19 B (+0.03%)69.26 KiB201.40 KiB61.67 KiB███████▁▁▁▁▁
Current gzip tracks all emitted client JS chunks. Initial gzip tracks only the entry/import graph. Trend sparkline is historical current gzip ending with this PR measurement; lower is better.
@pkg-pr-new
pkg-pr-newBot
commented
Aug 8, 2026

Copy link


Copy Markdown

More templates
@tanstack/arktype-adapter
npm i https://pkg.pr.new/@tanstack/arktype-adapter@8013

@tanstack/eslint-plugin-router
npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@8013

@tanstack/eslint-plugin-start
npm i https://pkg.pr.new/@tanstack/eslint-plugin-start@8013

@tanstack/history
npm i https://pkg.pr.new/@tanstack/history@8013

@tanstack/nitro-v2-vite-plugin
npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@8013

@tanstack/react-router
npm i https://pkg.pr.new/@tanstack/react-router@8013

@tanstack/react-router-devtools
npm i https://pkg.pr.new/@tanstack/react-router-devtools@8013

@tanstack/react-router-ssr-query
npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@8013

@tanstack/react-start
npm i https://pkg.pr.new/@tanstack/react-start@8013

@tanstack/react-start-client
npm i https://pkg.pr.new/@tanstack/react-start-client@8013

@tanstack/react-start-rsc
npm i https://pkg.pr.new/@tanstack/react-start-rsc@8013

@tanstack/react-start-server
npm i https://pkg.pr.new/@tanstack/react-start-server@8013

@tanstack/router-cli
npm i https://pkg.pr.new/@tanstack/router-cli@8013

@tanstack/router-core
npm i https://pkg.pr.new/@tanstack/router-core@8013

@tanstack/router-devtools
npm i https://pkg.pr.new/@tanstack/router-devtools@8013

@tanstack/router-devtools-core
npm i https://pkg.pr.new/@tanstack/router-devtools-core@8013

@tanstack/router-generator
npm i https://pkg.pr.new/@tanstack/router-generator@8013

@tanstack/router-plugin
npm i https://pkg.pr.new/@tanstack/router-plugin@8013

@tanstack/router-ssr-query-core
npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@8013

@tanstack/router-utils
npm i https://pkg.pr.new/@tanstack/router-utils@8013

@tanstack/router-vite-plugin
npm i https://pkg.pr.new/@tanstack/router-vite-plugin@8013

@tanstack/solid-router
npm i https://pkg.pr.new/@tanstack/solid-router@8013

@tanstack/solid-router-devtools
npm i https://pkg.pr.new/@tanstack/solid-router-devtools@8013

@tanstack/solid-router-ssr-query
npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@8013

@tanstack/solid-start
npm i https://pkg.pr.new/@tanstack/solid-start@8013

@tanstack/solid-start-client
npm i https://pkg.pr.new/@tanstack/solid-start-client@8013

@tanstack/solid-start-server
npm i https://pkg.pr.new/@tanstack/solid-start-server@8013

@tanstack/start-client-core
npm i https://pkg.pr.new/@tanstack/start-client-core@8013

@tanstack/start-fn-stubs
npm i https://pkg.pr.new/@tanstack/start-fn-stubs@8013

@tanstack/start-plugin-core
npm i https://pkg.pr.new/@tanstack/start-plugin-core@8013

@tanstack/start-server-core
npm i https://pkg.pr.new/@tanstack/start-server-core@8013

@tanstack/start-static-server-functions
npm i https://pkg.pr.new/@tanstack/start-static-server-functions@8013

@tanstack/start-storage-context
npm i https://pkg.pr.new/@tanstack/start-storage-context@8013

@tanstack/valibot-adapter
npm i https://pkg.pr.new/@tanstack/valibot-adapter@8013

@tanstack/virtual-file-routes
npm i https://pkg.pr.new/@tanstack/virtual-file-routes@8013

@tanstack/vue-router
npm i https://pkg.pr.new/@tanstack/vue-router@8013

@tanstack/vue-router-devtools
npm i https://pkg.pr.new/@tanstack/vue-router-devtools@8013

@tanstack/vue-router-ssr-query
npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@8013

@tanstack/vue-start
npm i https://pkg.pr.new/@tanstack/vue-start@8013

@tanstack/vue-start-client
npm i https://pkg.pr.new/@tanstack/vue-start-client@8013

@tanstack/vue-start-server
npm i https://pkg.pr.new/@tanstack/vue-start-server@8013

@tanstack/zod-adapter
npm i https://pkg.pr.new/@tanstack/zod-adapter@8013

commit: bfb5233
@codspeed-hq
codspeed-hqBot
commented
Aug 8, 2026

Copy link


Copy Markdown

Merging this PR will degrade performance by 10.71%
⚠️Different runtime environments detected
Some benchmarks with significant performance changes were compared across different runtime environments,

which may affect the accuracy of the results.
Open the report in CodSpeed to investigate
⚡ 3 improved benchmarks
❌ 5 regressed benchmarks
✅ 172 untouched benchmarks
Warning
Please fix the performance issues or acknowledge them on CodSpeed.
Performance Changes
ModeBenchmarkBASEHEADEfficiency
❌Memorymem server error-paths unmatched (react)272.3 KB849.3 KB-67.93%
❌Memorymem client unique-location-churn (solid)352.4 KB457.4 KB-22.96%
❌Memorymem client navigation-churn (solid)575 KB629 KB-8.58%
❌Memorymem client unique-location-churn (vue)1.2 MB1.3 MB-6.16%
❌Memorymem server server-fn-churn (vue)263.2 KB274.8 KB-4.21%
⚡Memorymem server error-paths not-found (solid)728.6 KB417 KB+74.72%
⚡Memorymem client preload-churn (vue)805.5 KB736.6 KB+9.35%
⚡Memorymem server error-paths not-found (react)260.8 KB250.3 KB+4.18%
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing perf/router-core-search-parse-fast-path (bfb5233) with main (44a8c3e)
Open in CodSpeed
@Sheraff
Sheraff
marked this pull request as draft
August 9, 2026 06:25
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

package: router-core

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@Sheraff

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
perf(router-core): skip impossible JSON parses during search parsing - #8013
Draft
Sheraff wants to merge 1 commit into
mainfrom 
perf/router-core-search-parse-fast-path
Draft
perf(router-core): skip impossible JSON parses during search parsing#8013
Sheraff wants to merge 1 commit into
mainfrom 
perf/router-core-search-parse-fast-path
Conversation
@Sheraff
@SheraffSheraff
commented
Aug 8, 2026•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Collaborator
Summary
  • apply the existing jsonStart fast path to parseSearchWith when using JSON.parse
  • preserve custom parser behavior and cover both paths with unit tests
  • add default search parsing benchmark scenarios and a patch changeset
Testing
  • CI=1 NX_DAEMON=false pnpm nx run @tanstack/router-core:test:unit --outputStyle=stream --skipRemoteCache -- tests/searchParams.test.ts
  • CI=1 NX_DAEMON=false pnpm nx run @tanstack/router-core:test:types --outputStyle=stream --skipRemoteCache
  • CI=1 NX_DAEMON=false pnpm nx run @tanstack/router-core:test:eslint --outputStyle=stream --skipRemoteCache
  • CI=1 NX_DAEMON=false pnpm nx run @tanstack/router-core:test:unit --outputStyle=stream --skipRemoteCache -- bench tests/searchParams.bench.ts --run
Summary by CodeRabbit
  • Bug Fixes
    • Improved search-parameter parsing by skipping values that cannot be valid JSON.
    • Preserved existing parsing behavior and silent error handling for eligible values.
  • Performance
    • Reduced unnecessary JSON parsing during search-parameter processing.
  • Tests
    • Added coverage for custom parsing, decoded parameters, invalid JSON values, and parsing performance.
@nx-cloud
nx-cloudBot
commented
Aug 8, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
View your CI Pipeline Execution ↗ for commit bfb5233
CommandStatusDurationResult
nx affected --targets=test:eslint,test:unit,tes...✅ Succeeded11m 58sView ↗
nx run-many --target=build --exclude=examples/*...✅ Succeeded2m 6sView ↗
☁️ Nx Cloud last updated this comment at 2026-08-08 18:40:15 UTC
@github-actions
github-actionsBot
commented
Aug 8, 2026

Copy link


Copy Markdown

Contributor
🚀 Changeset Version Preview
2 package(s) bumped directly, 21 bumped as dependents.
🟩 Patch bumps
PackageVersionReason
@tanstack/router-core1.171.19 → 1.171.20Changeset
@tanstack/start-client-core1.170.19 → 1.170.20Changeset
@tanstack/react-router1.170.23 → 1.170.24Dependent
@tanstack/react-start1.168.40 → 1.168.41Dependent
@tanstack/react-start-client1.168.21 → 1.168.22Dependent
@tanstack/react-start-rsc0.1.39 → 0.1.40Dependent
@tanstack/react-start-server1.167.28 → 1.167.29Dependent
@tanstack/router-cli1.167.25 → 1.167.26Dependent
@tanstack/router-generator1.167.25 → 1.167.26Dependent
@tanstack/router-plugin1.168.27 → 1.168.28Dependent
@tanstack/router-vite-plugin1.167.27 → 1.167.28Dependent
@tanstack/solid-router1.170.22 → 1.170.23Dependent
@tanstack/solid-start1.168.39 → 1.168.40Dependent
@tanstack/solid-start-client1.168.21 → 1.168.22Dependent
@tanstack/solid-start-server1.167.28 → 1.167.29Dependent
@tanstack/start-plugin-core1.171.31 → 1.171.32Dependent
@tanstack/start-server-core1.169.23 → 1.169.24Dependent
@tanstack/start-static-server-functions1.167.24 → 1.167.25Dependent
@tanstack/start-storage-context1.167.21 → 1.167.22Dependent
@tanstack/vue-router1.170.21 → 1.170.22Dependent
@tanstack/vue-start1.168.38 → 1.168.39Dependent
@tanstack/vue-start-client1.167.24 → 1.167.25Dependent
@tanstack/vue-start-server1.167.28 → 1.167.29Dependent
@coderabbitai
coderabbitaiBot
commented
Aug 8, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Review Change Stack
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 25e0496d-f38b-4880-b2e3-8de1cae4b5bf
📥 Commits
Reviewing files that changed from the base of the PR and between 44a8c3e and bfb5233.
📒 Files selected for processing (4)
  • .changeset/fast-search-parsing.md
  • packages/router-core/src/searchParams.ts
  • packages/router-core/tests/searchParams.bench.ts
  • packages/router-core/tests/searchParams.test.ts
📝 Walkthrough
Walkthrough
parseSearchWith now skips native JSON.parse attempts for values that cannot begin valid JSON. Tests cover custom parsers and skipped calls. Benchmarks measure parsing across several search-parameter value sets. A patch Changeset documents the behavior.
Changes
Search parameter parsing
Layer / File(s)Summary
Parser optimization and validation
packages/router-core/src/searchParams.ts, packages/router-core/tests/searchParams.test.ts, .changeset/fast-search-parsing.md		parseSearchWith detects native JSON.parse and skips values that cannot begin valid JSON. Tests cover custom parser output, decoded values, and skipped JSON.parse calls.
Parsing benchmark coverage
packages/router-core/tests/searchParams.bench.ts		Benchmarks parse ordinary, JSON-initial, JSON-compatible, and mixed serialized search values. Round-trip assertions validate the prepared fixtures.
Estimated code review effort: 2 (Simple) | ~15 minutes
Possibly related PRs
  • TanStack/router#8006: Both changes update parseSearchWith to skip impossible JSON.parse attempts and add related tests and Changesets.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly and concisely describes the main performance change in search parsing.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  •  Create stacked PR
  •  Commit on current branch
🧪 Generate unit tests (beta)
  •  Create PR with unit tests
  •  Commit unit tests in branch perf/router-core-search-parse-fast-path
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands.
@github-actions
github-actionsBot
commented
Aug 8, 2026

Copy link


Copy Markdown

Contributor
Bundle Size Benchmarks
  • Commit: 6f3a5ba67da0
  • Measured at: 2026-08-08T18:29:25.678Z
  • Baseline source: history:44a8c3e1d2af
  • Dashboard: bundle-size history
The following scenarios have bundle-size changes compared with the baseline:
ScenarioCurrent (gzip)Delta vs baselineInitial gzipRawBrotliTrend
react-router.minimal83.93 KiB+18 B (+0.02%)83.80 KiB262.72 KiB73.03 KiB███████▁▁▁▁▁
react-router.full87.45 KiB+18 B (+0.02%)87.31 KiB274.43 KiB76.16 KiB███████▁▁▁▁▁
solid-router.minimal33.26 KiB+20 B (+0.06%)33.13 KiB96.55 KiB30.05 KiB███████▁▁▁▁▁
solid-router.full38.08 KiB+17 B (+0.04%)37.96 KiB111.19 KiB34.30 KiB███████▁▁▁▁▁
vue-router.minimal49.54 KiB+20 B (+0.04%)49.42 KiB138.30 KiB44.75 KiB███████▁▁▁▁▁
vue-router.full55.12 KiB+16 B (+0.03%)55.00 KiB156.47 KiB49.64 KiB███████▁▁▁▁▁
react-start.minimal96.77 KiB+16 B (+0.02%)96.64 KiB304.93 KiB83.86 KiB███████▁▁▁▁▁
react-start.deferred-hydration97.50 KiB+16 B (+0.02%)96.66 KiB306.29 KiB84.51 KiB███████▁▁▁▁▁
react-start.full99.94 KiB+20 B (+0.02%)99.80 KiB314.65 KiB86.61 KiB███████▁▁▁▁▁
react-start.rsbuild.minimal100.08 KiB+18 B (+0.02%)99.91 KiB315.48 KiB86.35 KiB▁▄▄▃▃▄▄▄▄▆▇█
react-start.rsbuild.minimal-iife100.49 KiB+19 B (+0.02%)100.32 KiB316.42 KiB86.61 KiB▁▄▄▃▃▄▄▄▄▆▇█
react-start.rsbuild.full103.41 KiB+17 B (+0.02%)103.24 KiB325.57 KiB89.02 KiB▁▃▃▃▃▄▄▄▄▆▇█
solid-start.minimal46.03 KiB+16 B (+0.03%)45.90 KiB137.61 KiB40.94 KiB███████▁▁▁▁▁
solid-start.deferred-hydration49.10 KiB+15 B (+0.03%)45.96 KiB145.07 KiB43.73 KiB███████▁▁▁▁▁
solid-start.full51.11 KiB+17 B (+0.03%)50.98 KiB153.00 KiB45.31 KiB███████▁▁▁▁▁
vue-start.minimal65.56 KiB+14 B (+0.02%)65.44 KiB189.12 KiB58.36 KiB███████▁▁▁▁▁
vue-start.full69.39 KiB+19 B (+0.03%)69.26 KiB201.40 KiB61.67 KiB███████▁▁▁▁▁
Current gzip tracks all emitted client JS chunks. Initial gzip tracks only the entry/import graph. Trend sparkline is historical current gzip ending with this PR measurement; lower is better.
@pkg-pr-new
pkg-pr-newBot
commented
Aug 8, 2026

Copy link


Copy Markdown

More templates
@tanstack/arktype-adapter
npm i https://pkg.pr.new/@tanstack/arktype-adapter@8013

@tanstack/eslint-plugin-router
npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@8013

@tanstack/eslint-plugin-start
npm i https://pkg.pr.new/@tanstack/eslint-plugin-start@8013

@tanstack/history
npm i https://pkg.pr.new/@tanstack/history@8013

@tanstack/nitro-v2-vite-plugin
npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@8013

@tanstack/react-router
npm i https://pkg.pr.new/@tanstack/react-router@8013

@tanstack/react-router-devtools
npm i https://pkg.pr.new/@tanstack/react-router-devtools@8013

@tanstack/react-router-ssr-query
npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@8013

@tanstack/react-start
npm i https://pkg.pr.new/@tanstack/react-start@8013

@tanstack/react-start-client
npm i https://pkg.pr.new/@tanstack/react-start-client@8013

@tanstack/react-start-rsc
npm i https://pkg.pr.new/@tanstack/react-start-rsc@8013

@tanstack/react-start-server
npm i https://pkg.pr.new/@tanstack/react-start-server@8013

@tanstack/router-cli
npm i https://pkg.pr.new/@tanstack/router-cli@8013

@tanstack/router-core
npm i https://pkg.pr.new/@tanstack/router-core@8013

@tanstack/router-devtools
npm i https://pkg.pr.new/@tanstack/router-devtools@8013

@tanstack/router-devtools-core
npm i https://pkg.pr.new/@tanstack/router-devtools-core@8013

@tanstack/router-generator
npm i https://pkg.pr.new/@tanstack/router-generator@8013

@tanstack/router-plugin
npm i https://pkg.pr.new/@tanstack/router-plugin@8013

@tanstack/router-ssr-query-core
npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@8013

@tanstack/router-utils
npm i https://pkg.pr.new/@tanstack/router-utils@8013

@tanstack/router-vite-plugin
npm i https://pkg.pr.new/@tanstack/router-vite-plugin@8013

@tanstack/solid-router
npm i https://pkg.pr.new/@tanstack/solid-router@8013

@tanstack/solid-router-devtools
npm i https://pkg.pr.new/@tanstack/solid-router-devtools@8013

@tanstack/solid-router-ssr-query
npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@8013

@tanstack/solid-start
npm i https://pkg.pr.new/@tanstack/solid-start@8013

@tanstack/solid-start-client
npm i https://pkg.pr.new/@tanstack/solid-start-client@8013

@tanstack/solid-start-server
npm i https://pkg.pr.new/@tanstack/solid-start-server@8013

@tanstack/start-client-core
npm i https://pkg.pr.new/@tanstack/start-client-core@8013

@tanstack/start-fn-stubs
npm i https://pkg.pr.new/@tanstack/start-fn-stubs@8013

@tanstack/start-plugin-core
npm i https://pkg.pr.new/@tanstack/start-plugin-core@8013

@tanstack/start-server-core
npm i https://pkg.pr.new/@tanstack/start-server-core@8013

@tanstack/start-static-server-functions
npm i https://pkg.pr.new/@tanstack/start-static-server-functions@8013

@tanstack/start-storage-context
npm i https://pkg.pr.new/@tanstack/start-storage-context@8013

@tanstack/valibot-adapter
npm i https://pkg.pr.new/@tanstack/valibot-adapter@8013

@tanstack/virtual-file-routes
npm i https://pkg.pr.new/@tanstack/virtual-file-routes@8013

@tanstack/vue-router
npm i https://pkg.pr.new/@tanstack/vue-router@8013

@tanstack/vue-router-devtools
npm i https://pkg.pr.new/@tanstack/vue-router-devtools@8013

@tanstack/vue-router-ssr-query
npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@8013

@tanstack/vue-start
npm i https://pkg.pr.new/@tanstack/vue-start@8013

@tanstack/vue-start-client
npm i https://pkg.pr.new/@tanstack/vue-start-client@8013

@tanstack/vue-start-server
npm i https://pkg.pr.new/@tanstack/vue-start-server@8013

@tanstack/zod-adapter
npm i https://pkg.pr.new/@tanstack/zod-adapter@8013

commit: bfb5233
@codspeed-hq
codspeed-hqBot
commented
Aug 8, 2026

Copy link


Copy Markdown

Merging this PR will degrade performance by 10.71%
⚠️Different runtime environments detected
Some benchmarks with significant performance changes were compared across different runtime environments,

which may affect the accuracy of the results.
Open the report in CodSpeed to investigate
⚡ 3 improved benchmarks
❌ 5 regressed benchmarks
✅ 172 untouched benchmarks
Warning
Please fix the performance issues or acknowledge them on CodSpeed.
Performance Changes
ModeBenchmarkBASEHEADEfficiency
❌Memorymem server error-paths unmatched (react)272.3 KB849.3 KB-67.93%
❌Memorymem client unique-location-churn (solid)352.4 KB457.4 KB-22.96%
❌Memorymem client navigation-churn (solid)575 KB629 KB-8.58%
❌Memorymem client unique-location-churn (vue)1.2 MB1.3 MB-6.16%
❌Memorymem server server-fn-churn (vue)263.2 KB274.8 KB-4.21%
⚡Memorymem server error-paths not-found (solid)728.6 KB417 KB+74.72%
⚡Memorymem client preload-churn (vue)805.5 KB736.6 KB+9.35%
⚡Memorymem server error-paths not-found (react)260.8 KB250.3 KB+4.18%
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing perf/router-core-search-parse-fast-path (bfb5233) with main (44a8c3e)
Open in CodSpeed
@Sheraff
Sheraff
marked this pull request as draft
August 9, 2026 06:25
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

package: router-core

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@Sheraff

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
perf(router-core): skip impossible JSON parses during search parsing - #8013
Draft
Sheraff wants to merge 1 commit into
mainfrom 
perf/router-core-search-parse-fast-path
Draft
perf(router-core): skip impossible JSON parses during search parsing#8013
Sheraff wants to merge 1 commit into
mainfrom 
perf/router-core-search-parse-fast-path
Conversation
@Sheraff
@SheraffSheraff
commented
Aug 8, 2026•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Collaborator
Summary
  • apply the existing jsonStart fast path to parseSearchWith when using JSON.parse
  • preserve custom parser behavior and cover both paths with unit tests
  • add default search parsing benchmark scenarios and a patch changeset
Testing
  • CI=1 NX_DAEMON=false pnpm nx run @tanstack/router-core:test:unit --outputStyle=stream --skipRemoteCache -- tests/searchParams.test.ts
  • CI=1 NX_DAEMON=false pnpm nx run @tanstack/router-core:test:types --outputStyle=stream --skipRemoteCache
  • CI=1 NX_DAEMON=false pnpm nx run @tanstack/router-core:test:eslint --outputStyle=stream --skipRemoteCache
  • CI=1 NX_DAEMON=false pnpm nx run @tanstack/router-core:test:unit --outputStyle=stream --skipRemoteCache -- bench tests/searchParams.bench.ts --run
Summary by CodeRabbit
  • Bug Fixes
    • Improved search-parameter parsing by skipping values that cannot be valid JSON.
    • Preserved existing parsing behavior and silent error handling for eligible values.
  • Performance
    • Reduced unnecessary JSON parsing during search-parameter processing.
  • Tests
    • Added coverage for custom parsing, decoded parameters, invalid JSON values, and parsing performance.
@nx-cloud
nx-cloudBot
commented
Aug 8, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
View your CI Pipeline Execution ↗ for commit bfb5233
CommandStatusDurationResult
nx affected --targets=test:eslint,test:unit,tes...✅ Succeeded11m 58sView ↗
nx run-many --target=build --exclude=examples/*...✅ Succeeded2m 6sView ↗
☁️ Nx Cloud last updated this comment at 2026-08-08 18:40:15 UTC
@github-actions
github-actionsBot
commented
Aug 8, 2026

Copy link


Copy Markdown

Contributor
🚀 Changeset Version Preview
2 package(s) bumped directly, 21 bumped as dependents.
🟩 Patch bumps
PackageVersionReason
@tanstack/router-core1.171.19 → 1.171.20Changeset
@tanstack/start-client-core1.170.19 → 1.170.20Changeset
@tanstack/react-router1.170.23 → 1.170.24Dependent
@tanstack/react-start1.168.40 → 1.168.41Dependent
@tanstack/react-start-client1.168.21 → 1.168.22Dependent
@tanstack/react-start-rsc0.1.39 → 0.1.40Dependent
@tanstack/react-start-server1.167.28 → 1.167.29Dependent
@tanstack/router-cli1.167.25 → 1.167.26Dependent
@tanstack/router-generator1.167.25 → 1.167.26Dependent
@tanstack/router-plugin1.168.27 → 1.168.28Dependent
@tanstack/router-vite-plugin1.167.27 → 1.167.28Dependent
@tanstack/solid-router1.170.22 → 1.170.23Dependent
@tanstack/solid-start1.168.39 → 1.168.40Dependent
@tanstack/solid-start-client1.168.21 → 1.168.22Dependent
@tanstack/solid-start-server1.167.28 → 1.167.29Dependent
@tanstack/start-plugin-core1.171.31 → 1.171.32Dependent
@tanstack/start-server-core1.169.23 → 1.169.24Dependent
@tanstack/start-static-server-functions1.167.24 → 1.167.25Dependent
@tanstack/start-storage-context1.167.21 → 1.167.22Dependent
@tanstack/vue-router1.170.21 → 1.170.22Dependent
@tanstack/vue-start1.168.38 → 1.168.39Dependent
@tanstack/vue-start-client1.167.24 → 1.167.25Dependent
@tanstack/vue-start-server1.167.28 → 1.167.29Dependent
@coderabbitai
coderabbitaiBot
commented
Aug 8, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Review Change Stack
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 25e0496d-f38b-4880-b2e3-8de1cae4b5bf
📥 Commits
Reviewing files that changed from the base of the PR and between 44a8c3e and bfb5233.
📒 Files selected for processing (4)
  • .changeset/fast-search-parsing.md
  • packages/router-core/src/searchParams.ts
  • packages/router-core/tests/searchParams.bench.ts
  • packages/router-core/tests/searchParams.test.ts
📝 Walkthrough
Walkthrough
parseSearchWith now skips native JSON.parse attempts for values that cannot begin valid JSON. Tests cover custom parsers and skipped calls. Benchmarks measure parsing across several search-parameter value sets. A patch Changeset documents the behavior.
Changes
Search parameter parsing
Layer / File(s)Summary
Parser optimization and validation
packages/router-core/src/searchParams.ts, packages/router-core/tests/searchParams.test.ts, .changeset/fast-search-parsing.md		parseSearchWith detects native JSON.parse and skips values that cannot begin valid JSON. Tests cover custom parser output, decoded values, and skipped JSON.parse calls.
Parsing benchmark coverage
packages/router-core/tests/searchParams.bench.ts		Benchmarks parse ordinary, JSON-initial, JSON-compatible, and mixed serialized search values. Round-trip assertions validate the prepared fixtures.
Estimated code review effort: 2 (Simple) | ~15 minutes
Possibly related PRs
  • TanStack/router#8006: Both changes update parseSearchWith to skip impossible JSON.parse attempts and add related tests and Changesets.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly and concisely describes the main performance change in search parsing.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  •  Create stacked PR
  •  Commit on current branch
🧪 Generate unit tests (beta)
  •  Create PR with unit tests
  •  Commit unit tests in branch perf/router-core-search-parse-fast-path
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands.
@github-actions
github-actionsBot
commented
Aug 8, 2026

Copy link


Copy Markdown

Contributor
Bundle Size Benchmarks
  • Commit: 6f3a5ba67da0
  • Measured at: 2026-08-08T18:29:25.678Z
  • Baseline source: history:44a8c3e1d2af
  • Dashboard: bundle-size history
The following scenarios have bundle-size changes compared with the baseline:
ScenarioCurrent (gzip)Delta vs baselineInitial gzipRawBrotliTrend
react-router.minimal83.93 KiB+18 B (+0.02%)83.80 KiB262.72 KiB73.03 KiB███████▁▁▁▁▁
react-router.full87.45 KiB+18 B (+0.02%)87.31 KiB274.43 KiB76.16 KiB███████▁▁▁▁▁
solid-router.minimal33.26 KiB+20 B (+0.06%)33.13 KiB96.55 KiB30.05 KiB███████▁▁▁▁▁
solid-router.full38.08 KiB+17 B (+0.04%)37.96 KiB111.19 KiB34.30 KiB███████▁▁▁▁▁
vue-router.minimal49.54 KiB+20 B (+0.04%)49.42 KiB138.30 KiB44.75 KiB███████▁▁▁▁▁
vue-router.full55.12 KiB+16 B (+0.03%)55.00 KiB156.47 KiB49.64 KiB███████▁▁▁▁▁
react-start.minimal96.77 KiB+16 B (+0.02%)96.64 KiB304.93 KiB83.86 KiB███████▁▁▁▁▁
react-start.deferred-hydration97.50 KiB+16 B (+0.02%)96.66 KiB306.29 KiB84.51 KiB███████▁▁▁▁▁
react-start.full99.94 KiB+20 B (+0.02%)99.80 KiB314.65 KiB86.61 KiB███████▁▁▁▁▁
react-start.rsbuild.minimal100.08 KiB+18 B (+0.02%)99.91 KiB315.48 KiB86.35 KiB▁▄▄▃▃▄▄▄▄▆▇█
react-start.rsbuild.minimal-iife100.49 KiB+19 B (+0.02%)100.32 KiB316.42 KiB86.61 KiB▁▄▄▃▃▄▄▄▄▆▇█
react-start.rsbuild.full103.41 KiB+17 B (+0.02%)103.24 KiB325.57 KiB89.02 KiB▁▃▃▃▃▄▄▄▄▆▇█
solid-start.minimal46.03 KiB+16 B (+0.03%)45.90 KiB137.61 KiB40.94 KiB███████▁▁▁▁▁
solid-start.deferred-hydration49.10 KiB+15 B (+0.03%)45.96 KiB145.07 KiB43.73 KiB███████▁▁▁▁▁
solid-start.full51.11 KiB+17 B (+0.03%)50.98 KiB153.00 KiB45.31 KiB███████▁▁▁▁▁
vue-start.minimal65.56 KiB+14 B (+0.02%)65.44 KiB189.12 KiB58.36 KiB███████▁▁▁▁▁
vue-start.full69.39 KiB+19 B (+0.03%)69.26 KiB201.40 KiB61.67 KiB███████▁▁▁▁▁
Current gzip tracks all emitted client JS chunks. Initial gzip tracks only the entry/import graph. Trend sparkline is historical current gzip ending with this PR measurement; lower is better.
@pkg-pr-new
pkg-pr-newBot
commented
Aug 8, 2026

Copy link


Copy Markdown

More templates
@tanstack/arktype-adapter
npm i https://pkg.pr.new/@tanstack/arktype-adapter@8013

@tanstack/eslint-plugin-router
npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@8013

@tanstack/eslint-plugin-start
npm i https://pkg.pr.new/@tanstack/eslint-plugin-start@8013

@tanstack/history
npm i https://pkg.pr.new/@tanstack/history@8013

@tanstack/nitro-v2-vite-plugin
npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@8013

@tanstack/react-router
npm i https://pkg.pr.new/@tanstack/react-router@8013

@tanstack/react-router-devtools
npm i https://pkg.pr.new/@tanstack/react-router-devtools@8013

@tanstack/react-router-ssr-query
npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@8013

@tanstack/react-start
npm i https://pkg.pr.new/@tanstack/react-start@8013

@tanstack/react-start-client
npm i https://pkg.pr.new/@tanstack/react-start-client@8013

@tanstack/react-start-rsc
npm i https://pkg.pr.new/@tanstack/react-start-rsc@8013

@tanstack/react-start-server
npm i https://pkg.pr.new/@tanstack/react-start-server@8013

@tanstack/router-cli
npm i https://pkg.pr.new/@tanstack/router-cli@8013

@tanstack/router-core
npm i https://pkg.pr.new/@tanstack/router-core@8013

@tanstack/router-devtools
npm i https://pkg.pr.new/@tanstack/router-devtools@8013

@tanstack/router-devtools-core
npm i https://pkg.pr.new/@tanstack/router-devtools-core@8013

@tanstack/router-generator
npm i https://pkg.pr.new/@tanstack/router-generator@8013

@tanstack/router-plugin
npm i https://pkg.pr.new/@tanstack/router-plugin@8013

@tanstack/router-ssr-query-core
npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@8013

@tanstack/router-utils
npm i https://pkg.pr.new/@tanstack/router-utils@8013

@tanstack/router-vite-plugin
npm i https://pkg.pr.new/@tanstack/router-vite-plugin@8013

@tanstack/solid-router
npm i https://pkg.pr.new/@tanstack/solid-router@8013

@tanstack/solid-router-devtools
npm i https://pkg.pr.new/@tanstack/solid-router-devtools@8013

@tanstack/solid-router-ssr-query
npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@8013

@tanstack/solid-start
npm i https://pkg.pr.new/@tanstack/solid-start@8013

@tanstack/solid-start-client
npm i https://pkg.pr.new/@tanstack/solid-start-client@8013

@tanstack/solid-start-server
npm i https://pkg.pr.new/@tanstack/solid-start-server@8013

@tanstack/start-client-core
npm i https://pkg.pr.new/@tanstack/start-client-core@8013

@tanstack/start-fn-stubs
npm i https://pkg.pr.new/@tanstack/start-fn-stubs@8013

@tanstack/start-plugin-core
npm i https://pkg.pr.new/@tanstack/start-plugin-core@8013

@tanstack/start-server-core
npm i https://pkg.pr.new/@tanstack/start-server-core@8013

@tanstack/start-static-server-functions
npm i https://pkg.pr.new/@tanstack/start-static-server-functions@8013

@tanstack/start-storage-context
npm i https://pkg.pr.new/@tanstack/start-storage-context@8013

@tanstack/valibot-adapter
npm i https://pkg.pr.new/@tanstack/valibot-adapter@8013

@tanstack/virtual-file-routes
npm i https://pkg.pr.new/@tanstack/virtual-file-routes@8013

@tanstack/vue-router
npm i https://pkg.pr.new/@tanstack/vue-router@8013

@tanstack/vue-router-devtools
npm i https://pkg.pr.new/@tanstack/vue-router-devtools@8013

@tanstack/vue-router-ssr-query
npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@8013

@tanstack/vue-start
npm i https://pkg.pr.new/@tanstack/vue-start@8013

@tanstack/vue-start-client
npm i https://pkg.pr.new/@tanstack/vue-start-client@8013

@tanstack/vue-start-server
npm i https://pkg.pr.new/@tanstack/vue-start-server@8013

@tanstack/zod-adapter
npm i https://pkg.pr.new/@tanstack/zod-adapter@8013

commit: bfb5233
@codspeed-hq
codspeed-hqBot
commented
Aug 8, 2026

Copy link


Copy Markdown

Merging this PR will degrade performance by 10.71%
⚠️Different runtime environments detected
Some benchmarks with significant performance changes were compared across different runtime environments,

which may affect the accuracy of the results.
Open the report in CodSpeed to investigate
⚡ 3 improved benchmarks
❌ 5 regressed benchmarks
✅ 172 untouched benchmarks
Warning
Please fix the performance issues or acknowledge them on CodSpeed.
Performance Changes
ModeBenchmarkBASEHEADEfficiency
❌Memorymem server error-paths unmatched (react)272.3 KB849.3 KB-67.93%
❌Memorymem client unique-location-churn (solid)352.4 KB457.4 KB-22.96%
❌Memorymem client navigation-churn (solid)575 KB629 KB-8.58%
❌Memorymem client unique-location-churn (vue)1.2 MB1.3 MB-6.16%
❌Memorymem server server-fn-churn (vue)263.2 KB274.8 KB-4.21%
⚡Memorymem server error-paths not-found (solid)728.6 KB417 KB+74.72%
⚡Memorymem client preload-churn (vue)805.5 KB736.6 KB+9.35%
⚡Memorymem server error-paths not-found (react)260.8 KB250.3 KB+4.18%
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing perf/router-core-search-parse-fast-path (bfb5233) with main (44a8c3e)
Open in CodSpeed
@Sheraff
Sheraff
marked this pull request as draft
August 9, 2026 06:25
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

package: router-core

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@Sheraff

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
perf(router-core): skip impossible JSON parses during search parsing - #8013
Draft
Sheraff wants to merge 1 commit into
mainfrom 
perf/router-core-search-parse-fast-path
Draft
perf(router-core): skip impossible JSON parses during search parsing#8013
Sheraff wants to merge 1 commit into
mainfrom 
perf/router-core-search-parse-fast-path
Conversation
@Sheraff
@SheraffSheraff
commented
Aug 8, 2026•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Collaborator
Summary
  • apply the existing jsonStart fast path to parseSearchWith when using JSON.parse
  • preserve custom parser behavior and cover both paths with unit tests
  • add default search parsing benchmark scenarios and a patch changeset
Testing
  • CI=1 NX_DAEMON=false pnpm nx run @tanstack/router-core:test:unit --outputStyle=stream --skipRemoteCache -- tests/searchParams.test.ts
  • CI=1 NX_DAEMON=false pnpm nx run @tanstack/router-core:test:types --outputStyle=stream --skipRemoteCache
  • CI=1 NX_DAEMON=false pnpm nx run @tanstack/router-core:test:eslint --outputStyle=stream --skipRemoteCache
  • CI=1 NX_DAEMON=false pnpm nx run @tanstack/router-core:test:unit --outputStyle=stream --skipRemoteCache -- bench tests/searchParams.bench.ts --run
Summary by CodeRabbit
  • Bug Fixes
    • Improved search-parameter parsing by skipping values that cannot be valid JSON.
    • Preserved existing parsing behavior and silent error handling for eligible values.
  • Performance
    • Reduced unnecessary JSON parsing during search-parameter processing.
  • Tests
    • Added coverage for custom parsing, decoded parameters, invalid JSON values, and parsing performance.
@nx-cloud
nx-cloudBot
commented
Aug 8, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
View your CI Pipeline Execution ↗ for commit bfb5233
CommandStatusDurationResult
nx affected --targets=test:eslint,test:unit,tes...✅ Succeeded11m 58sView ↗
nx run-many --target=build --exclude=examples/*...✅ Succeeded2m 6sView ↗
☁️ Nx Cloud last updated this comment at 2026-08-08 18:40:15 UTC
@github-actions
github-actionsBot
commented
Aug 8, 2026

Copy link


Copy Markdown

Contributor
🚀 Changeset Version Preview
2 package(s) bumped directly, 21 bumped as dependents.
🟩 Patch bumps
PackageVersionReason
@tanstack/router-core1.171.19 → 1.171.20Changeset
@tanstack/start-client-core1.170.19 → 1.170.20Changeset
@tanstack/react-router1.170.23 → 1.170.24Dependent
@tanstack/react-start1.168.40 → 1.168.41Dependent
@tanstack/react-start-client1.168.21 → 1.168.22Dependent
@tanstack/react-start-rsc0.1.39 → 0.1.40Dependent
@tanstack/react-start-server1.167.28 → 1.167.29Dependent
@tanstack/router-cli1.167.25 → 1.167.26Dependent
@tanstack/router-generator1.167.25 → 1.167.26Dependent
@tanstack/router-plugin1.168.27 → 1.168.28Dependent
@tanstack/router-vite-plugin1.167.27 → 1.167.28Dependent
@tanstack/solid-router1.170.22 → 1.170.23Dependent
@tanstack/solid-start1.168.39 → 1.168.40Dependent
@tanstack/solid-start-client1.168.21 → 1.168.22Dependent
@tanstack/solid-start-server1.167.28 → 1.167.29Dependent
@tanstack/start-plugin-core1.171.31 → 1.171.32Dependent
@tanstack/start-server-core1.169.23 → 1.169.24Dependent
@tanstack/start-static-server-functions1.167.24 → 1.167.25Dependent
@tanstack/start-storage-context1.167.21 → 1.167.22Dependent
@tanstack/vue-router1.170.21 → 1.170.22Dependent
@tanstack/vue-start1.168.38 → 1.168.39Dependent
@tanstack/vue-start-client1.167.24 → 1.167.25Dependent
@tanstack/vue-start-server1.167.28 → 1.167.29Dependent
@coderabbitai
coderabbitaiBot
commented
Aug 8, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Review Change Stack
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 25e0496d-f38b-4880-b2e3-8de1cae4b5bf
📥 Commits
Reviewing files that changed from the base of the PR and between 44a8c3e and bfb5233.
📒 Files selected for processing (4)
  • .changeset/fast-search-parsing.md
  • packages/router-core/src/searchParams.ts
  • packages/router-core/tests/searchParams.bench.ts
  • packages/router-core/tests/searchParams.test.ts
📝 Walkthrough
Walkthrough
parseSearchWith now skips native JSON.parse attempts for values that cannot begin valid JSON. Tests cover custom parsers and skipped calls. Benchmarks measure parsing across several search-parameter value sets. A patch Changeset documents the behavior.
Changes
Search parameter parsing
Layer / File(s)Summary
Parser optimization and validation
packages/router-core/src/searchParams.ts, packages/router-core/tests/searchParams.test.ts, .changeset/fast-search-parsing.md		parseSearchWith detects native JSON.parse and skips values that cannot begin valid JSON. Tests cover custom parser output, decoded values, and skipped JSON.parse calls.
Parsing benchmark coverage
packages/router-core/tests/searchParams.bench.ts		Benchmarks parse ordinary, JSON-initial, JSON-compatible, and mixed serialized search values. Round-trip assertions validate the prepared fixtures.
Estimated code review effort: 2 (Simple) | ~15 minutes
Possibly related PRs
  • TanStack/router#8006: Both changes update parseSearchWith to skip impossible JSON.parse attempts and add related tests and Changesets.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly and concisely describes the main performance change in search parsing.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  •  Create stacked PR
  •  Commit on current branch
🧪 Generate unit tests (beta)
  •  Create PR with unit tests
  •  Commit unit tests in branch perf/router-core-search-parse-fast-path
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands.
@github-actions
github-actionsBot
commented
Aug 8, 2026

Copy link


Copy Markdown

Contributor
Bundle Size Benchmarks
  • Commit: 6f3a5ba67da0
  • Measured at: 2026-08-08T18:29:25.678Z
  • Baseline source: history:44a8c3e1d2af
  • Dashboard: bundle-size history
The following scenarios have bundle-size changes compared with the baseline:
ScenarioCurrent (gzip)Delta vs baselineInitial gzipRawBrotliTrend
react-router.minimal83.93 KiB+18 B (+0.02%)83.80 KiB262.72 KiB73.03 KiB███████▁▁▁▁▁
react-router.full87.45 KiB+18 B (+0.02%)87.31 KiB274.43 KiB76.16 KiB███████▁▁▁▁▁
solid-router.minimal33.26 KiB+20 B (+0.06%)33.13 KiB96.55 KiB30.05 KiB███████▁▁▁▁▁
solid-router.full38.08 KiB+17 B (+0.04%)37.96 KiB111.19 KiB34.30 KiB███████▁▁▁▁▁
vue-router.minimal49.54 KiB+20 B (+0.04%)49.42 KiB138.30 KiB44.75 KiB███████▁▁▁▁▁
vue-router.full55.12 KiB+16 B (+0.03%)55.00 KiB156.47 KiB49.64 KiB███████▁▁▁▁▁
react-start.minimal96.77 KiB+16 B (+0.02%)96.64 KiB304.93 KiB83.86 KiB███████▁▁▁▁▁
react-start.deferred-hydration97.50 KiB+16 B (+0.02%)96.66 KiB306.29 KiB84.51 KiB███████▁▁▁▁▁
react-start.full99.94 KiB+20 B (+0.02%)99.80 KiB314.65 KiB86.61 KiB███████▁▁▁▁▁
react-start.rsbuild.minimal100.08 KiB+18 B (+0.02%)99.91 KiB315.48 KiB86.35 KiB▁▄▄▃▃▄▄▄▄▆▇█
react-start.rsbuild.minimal-iife100.49 KiB+19 B (+0.02%)100.32 KiB316.42 KiB86.61 KiB▁▄▄▃▃▄▄▄▄▆▇█
react-start.rsbuild.full103.41 KiB+17 B (+0.02%)103.24 KiB325.57 KiB89.02 KiB▁▃▃▃▃▄▄▄▄▆▇█
solid-start.minimal46.03 KiB+16 B (+0.03%)45.90 KiB137.61 KiB40.94 KiB███████▁▁▁▁▁
solid-start.deferred-hydration49.10 KiB+15 B (+0.03%)45.96 KiB145.07 KiB43.73 KiB███████▁▁▁▁▁
solid-start.full51.11 KiB+17 B (+0.03%)50.98 KiB153.00 KiB45.31 KiB███████▁▁▁▁▁
vue-start.minimal65.56 KiB+14 B (+0.02%)65.44 KiB189.12 KiB58.36 KiB███████▁▁▁▁▁
vue-start.full69.39 KiB+19 B (+0.03%)69.26 KiB201.40 KiB61.67 KiB███████▁▁▁▁▁
Current gzip tracks all emitted client JS chunks. Initial gzip tracks only the entry/import graph. Trend sparkline is historical current gzip ending with this PR measurement; lower is better.
@pkg-pr-new
pkg-pr-newBot
commented
Aug 8, 2026

Copy link


Copy Markdown

More templates
@tanstack/arktype-adapter
npm i https://pkg.pr.new/@tanstack/arktype-adapter@8013

@tanstack/eslint-plugin-router
npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@8013

@tanstack/eslint-plugin-start
npm i https://pkg.pr.new/@tanstack/eslint-plugin-start@8013

@tanstack/history
npm i https://pkg.pr.new/@tanstack/history@8013

@tanstack/nitro-v2-vite-plugin
npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@8013

@tanstack/react-router
npm i https://pkg.pr.new/@tanstack/react-router@8013

@tanstack/react-router-devtools
npm i https://pkg.pr.new/@tanstack/react-router-devtools@8013

@tanstack/react-router-ssr-query
npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@8013

@tanstack/react-start
npm i https://pkg.pr.new/@tanstack/react-start@8013

@tanstack/react-start-client
npm i https://pkg.pr.new/@tanstack/react-start-client@8013

@tanstack/react-start-rsc
npm i https://pkg.pr.new/@tanstack/react-start-rsc@8013

@tanstack/react-start-server
npm i https://pkg.pr.new/@tanstack/react-start-server@8013

@tanstack/router-cli
npm i https://pkg.pr.new/@tanstack/router-cli@8013

@tanstack/router-core
npm i https://pkg.pr.new/@tanstack/router-core@8013

@tanstack/router-devtools
npm i https://pkg.pr.new/@tanstack/router-devtools@8013

@tanstack/router-devtools-core
npm i https://pkg.pr.new/@tanstack/router-devtools-core@8013

@tanstack/router-generator
npm i https://pkg.pr.new/@tanstack/router-generator@8013

@tanstack/router-plugin
npm i https://pkg.pr.new/@tanstack/router-plugin@8013

@tanstack/router-ssr-query-core
npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@8013

@tanstack/router-utils
npm i https://pkg.pr.new/@tanstack/router-utils@8013

@tanstack/router-vite-plugin
npm i https://pkg.pr.new/@tanstack/router-vite-plugin@8013

@tanstack/solid-router
npm i https://pkg.pr.new/@tanstack/solid-router@8013

@tanstack/solid-router-devtools
npm i https://pkg.pr.new/@tanstack/solid-router-devtools@8013

@tanstack/solid-router-ssr-query
npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@8013

@tanstack/solid-start
npm i https://pkg.pr.new/@tanstack/solid-start@8013

@tanstack/solid-start-client
npm i https://pkg.pr.new/@tanstack/solid-start-client@8013

@tanstack/solid-start-server
npm i https://pkg.pr.new/@tanstack/solid-start-server@8013

@tanstack/start-client-core
npm i https://pkg.pr.new/@tanstack/start-client-core@8013

@tanstack/start-fn-stubs
npm i https://pkg.pr.new/@tanstack/start-fn-stubs@8013

@tanstack/start-plugin-core
npm i https://pkg.pr.new/@tanstack/start-plugin-core@8013

@tanstack/start-server-core
npm i https://pkg.pr.new/@tanstack/start-server-core@8013

@tanstack/start-static-server-functions
npm i https://pkg.pr.new/@tanstack/start-static-server-functions@8013

@tanstack/start-storage-context
npm i https://pkg.pr.new/@tanstack/start-storage-context@8013

@tanstack/valibot-adapter
npm i https://pkg.pr.new/@tanstack/valibot-adapter@8013

@tanstack/virtual-file-routes
npm i https://pkg.pr.new/@tanstack/virtual-file-routes@8013

@tanstack/vue-router
npm i https://pkg.pr.new/@tanstack/vue-router@8013

@tanstack/vue-router-devtools
npm i https://pkg.pr.new/@tanstack/vue-router-devtools@8013

@tanstack/vue-router-ssr-query
npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@8013

@tanstack/vue-start
npm i https://pkg.pr.new/@tanstack/vue-start@8013

@tanstack/vue-start-client
npm i https://pkg.pr.new/@tanstack/vue-start-client@8013

@tanstack/vue-start-server
npm i https://pkg.pr.new/@tanstack/vue-start-server@8013

@tanstack/zod-adapter
npm i https://pkg.pr.new/@tanstack/zod-adapter@8013

commit: bfb5233
@codspeed-hq
codspeed-hqBot
commented
Aug 8, 2026

Copy link


Copy Markdown

Merging this PR will degrade performance by 10.71%
⚠️Different runtime environments detected
Some benchmarks with significant performance changes were compared across different runtime environments,

which may affect the accuracy of the results.
Open the report in CodSpeed to investigate
⚡ 3 improved benchmarks
❌ 5 regressed benchmarks
✅ 172 untouched benchmarks
Warning
Please fix the performance issues or acknowledge them on CodSpeed.
Performance Changes
ModeBenchmarkBASEHEADEfficiency
❌Memorymem server error-paths unmatched (react)272.3 KB849.3 KB-67.93%
❌Memorymem client unique-location-churn (solid)352.4 KB457.4 KB-22.96%
❌Memorymem client navigation-churn (solid)575 KB629 KB-8.58%
❌Memorymem client unique-location-churn (vue)1.2 MB1.3 MB-6.16%
❌Memorymem server server-fn-churn (vue)263.2 KB274.8 KB-4.21%
⚡Memorymem server error-paths not-found (solid)728.6 KB417 KB+74.72%
⚡Memorymem client preload-churn (vue)805.5 KB736.6 KB+9.35%
⚡Memorymem server error-paths not-found (react)260.8 KB250.3 KB+4.18%
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing perf/router-core-search-parse-fast-path (bfb5233) with main (44a8c3e)
Open in CodSpeed
@Sheraff
Sheraff
marked this pull request as draft
August 9, 2026 06:25
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

package: router-core

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@Sheraff

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
perf(router-core): skip impossible JSON parses during search parsing - #8013
Draft
Sheraff wants to merge 1 commit into
mainfrom 
perf/router-core-search-parse-fast-path
Draft
perf(router-core): skip impossible JSON parses during search parsing#8013
Sheraff wants to merge 1 commit into
mainfrom 
perf/router-core-search-parse-fast-path
Conversation
@Sheraff
@SheraffSheraff
commented
Aug 8, 2026•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Collaborator
Summary
  • apply the existing jsonStart fast path to parseSearchWith when using JSON.parse
  • preserve custom parser behavior and cover both paths with unit tests
  • add default search parsing benchmark scenarios and a patch changeset
Testing
  • CI=1 NX_DAEMON=false pnpm nx run @tanstack/router-core:test:unit --outputStyle=stream --skipRemoteCache -- tests/searchParams.test.ts
  • CI=1 NX_DAEMON=false pnpm nx run @tanstack/router-core:test:types --outputStyle=stream --skipRemoteCache
  • CI=1 NX_DAEMON=false pnpm nx run @tanstack/router-core:test:eslint --outputStyle=stream --skipRemoteCache
  • CI=1 NX_DAEMON=false pnpm nx run @tanstack/router-core:test:unit --outputStyle=stream --skipRemoteCache -- bench tests/searchParams.bench.ts --run
Summary by CodeRabbit
  • Bug Fixes
    • Improved search-parameter parsing by skipping values that cannot be valid JSON.
    • Preserved existing parsing behavior and silent error handling for eligible values.
  • Performance
    • Reduced unnecessary JSON parsing during search-parameter processing.
  • Tests
    • Added coverage for custom parsing, decoded parameters, invalid JSON values, and parsing performance.
@nx-cloud
nx-cloudBot
commented
Aug 8, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
View your CI Pipeline Execution ↗ for commit bfb5233
CommandStatusDurationResult
nx affected --targets=test:eslint,test:unit,tes...✅ Succeeded11m 58sView ↗
nx run-many --target=build --exclude=examples/*...✅ Succeeded2m 6sView ↗
☁️ Nx Cloud last updated this comment at 2026-08-08 18:40:15 UTC
@github-actions
github-actionsBot
commented
Aug 8, 2026

Copy link


Copy Markdown

Contributor
🚀 Changeset Version Preview
2 package(s) bumped directly, 21 bumped as dependents.
🟩 Patch bumps
PackageVersionReason
@tanstack/router-core1.171.19 → 1.171.20Changeset
@tanstack/start-client-core1.170.19 → 1.170.20Changeset
@tanstack/react-router1.170.23 → 1.170.24Dependent
@tanstack/react-start1.168.40 → 1.168.41Dependent
@tanstack/react-start-client1.168.21 → 1.168.22Dependent
@tanstack/react-start-rsc0.1.39 → 0.1.40Dependent
@tanstack/react-start-server1.167.28 → 1.167.29Dependent
@tanstack/router-cli1.167.25 → 1.167.26Dependent
@tanstack/router-generator1.167.25 → 1.167.26Dependent
@tanstack/router-plugin1.168.27 → 1.168.28Dependent
@tanstack/router-vite-plugin1.167.27 → 1.167.28Dependent
@tanstack/solid-router1.170.22 → 1.170.23Dependent
@tanstack/solid-start1.168.39 → 1.168.40Dependent
@tanstack/solid-start-client1.168.21 → 1.168.22Dependent
@tanstack/solid-start-server1.167.28 → 1.167.29Dependent
@tanstack/start-plugin-core1.171.31 → 1.171.32Dependent
@tanstack/start-server-core1.169.23 → 1.169.24Dependent
@tanstack/start-static-server-functions1.167.24 → 1.167.25Dependent
@tanstack/start-storage-context1.167.21 → 1.167.22Dependent
@tanstack/vue-router1.170.21 → 1.170.22Dependent
@tanstack/vue-start1.168.38 → 1.168.39Dependent
@tanstack/vue-start-client1.167.24 → 1.167.25Dependent
@tanstack/vue-start-server1.167.28 → 1.167.29Dependent
@coderabbitai
coderabbitaiBot
commented
Aug 8, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Review Change Stack
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 25e0496d-f38b-4880-b2e3-8de1cae4b5bf
📥 Commits
Reviewing files that changed from the base of the PR and between 44a8c3e and bfb5233.
📒 Files selected for processing (4)
  • .changeset/fast-search-parsing.md
  • packages/router-core/src/searchParams.ts
  • packages/router-core/tests/searchParams.bench.ts
  • packages/router-core/tests/searchParams.test.ts
📝 Walkthrough
Walkthrough
parseSearchWith now skips native JSON.parse attempts for values that cannot begin valid JSON. Tests cover custom parsers and skipped calls. Benchmarks measure parsing across several search-parameter value sets. A patch Changeset documents the behavior.
Changes
Search parameter parsing
Layer / File(s)Summary
Parser optimization and validation
packages/router-core/src/searchParams.ts, packages/router-core/tests/searchParams.test.ts, .changeset/fast-search-parsing.md		parseSearchWith detects native JSON.parse and skips values that cannot begin valid JSON. Tests cover custom parser output, decoded values, and skipped JSON.parse calls.
Parsing benchmark coverage
packages/router-core/tests/searchParams.bench.ts		Benchmarks parse ordinary, JSON-initial, JSON-compatible, and mixed serialized search values. Round-trip assertions validate the prepared fixtures.
Estimated code review effort: 2 (Simple) | ~15 minutes
Possibly related PRs
  • TanStack/router#8006: Both changes update parseSearchWith to skip impossible JSON.parse attempts and add related tests and Changesets.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly and concisely describes the main performance change in search parsing.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  •  Create stacked PR
  •  Commit on current branch
🧪 Generate unit tests (beta)
  •  Create PR with unit tests
  •  Commit unit tests in branch perf/router-core-search-parse-fast-path
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands.
@github-actions
github-actionsBot
commented
Aug 8, 2026

Copy link


Copy Markdown

Contributor
Bundle Size Benchmarks
  • Commit: 6f3a5ba67da0
  • Measured at: 2026-08-08T18:29:25.678Z
  • Baseline source: history:44a8c3e1d2af
  • Dashboard: bundle-size history
The following scenarios have bundle-size changes compared with the baseline:
ScenarioCurrent (gzip)Delta vs baselineInitial gzipRawBrotliTrend
react-router.minimal83.93 KiB+18 B (+0.02%)83.80 KiB262.72 KiB73.03 KiB███████▁▁▁▁▁
react-router.full87.45 KiB+18 B (+0.02%)87.31 KiB274.43 KiB76.16 KiB███████▁▁▁▁▁
solid-router.minimal33.26 KiB+20 B (+0.06%)33.13 KiB96.55 KiB30.05 KiB███████▁▁▁▁▁
solid-router.full38.08 KiB+17 B (+0.04%)37.96 KiB111.19 KiB34.30 KiB███████▁▁▁▁▁
vue-router.minimal49.54 KiB+20 B (+0.04%)49.42 KiB138.30 KiB44.75 KiB███████▁▁▁▁▁
vue-router.full55.12 KiB+16 B (+0.03%)55.00 KiB156.47 KiB49.64 KiB███████▁▁▁▁▁
react-start.minimal96.77 KiB+16 B (+0.02%)96.64 KiB304.93 KiB83.86 KiB███████▁▁▁▁▁
react-start.deferred-hydration97.50 KiB+16 B (+0.02%)96.66 KiB306.29 KiB84.51 KiB███████▁▁▁▁▁
react-start.full99.94 KiB+20 B (+0.02%)99.80 KiB314.65 KiB86.61 KiB███████▁▁▁▁▁
react-start.rsbuild.minimal100.08 KiB+18 B (+0.02%)99.91 KiB315.48 KiB86.35 KiB▁▄▄▃▃▄▄▄▄▆▇█
react-start.rsbuild.minimal-iife100.49 KiB+19 B (+0.02%)100.32 KiB316.42 KiB86.61 KiB▁▄▄▃▃▄▄▄▄▆▇█
react-start.rsbuild.full103.41 KiB+17 B (+0.02%)103.24 KiB325.57 KiB89.02 KiB▁▃▃▃▃▄▄▄▄▆▇█
solid-start.minimal46.03 KiB+16 B (+0.03%)45.90 KiB137.61 KiB40.94 KiB███████▁▁▁▁▁
solid-start.deferred-hydration49.10 KiB+15 B (+0.03%)45.96 KiB145.07 KiB43.73 KiB███████▁▁▁▁▁
solid-start.full51.11 KiB+17 B (+0.03%)50.98 KiB153.00 KiB45.31 KiB███████▁▁▁▁▁
vue-start.minimal65.56 KiB+14 B (+0.02%)65.44 KiB189.12 KiB58.36 KiB███████▁▁▁▁▁
vue-start.full69.39 KiB+19 B (+0.03%)69.26 KiB201.40 KiB61.67 KiB███████▁▁▁▁▁
Current gzip tracks all emitted client JS chunks. Initial gzip tracks only the entry/import graph. Trend sparkline is historical current gzip ending with this PR measurement; lower is better.
@pkg-pr-new
pkg-pr-newBot
commented
Aug 8, 2026

Copy link


Copy Markdown

More templates
@tanstack/arktype-adapter
npm i https://pkg.pr.new/@tanstack/arktype-adapter@8013

@tanstack/eslint-plugin-router
npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@8013

@tanstack/eslint-plugin-start
npm i https://pkg.pr.new/@tanstack/eslint-plugin-start@8013

@tanstack/history
npm i https://pkg.pr.new/@tanstack/history@8013

@tanstack/nitro-v2-vite-plugin
npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@8013

@tanstack/react-router
npm i https://pkg.pr.new/@tanstack/react-router@8013

@tanstack/react-router-devtools
npm i https://pkg.pr.new/@tanstack/react-router-devtools@8013

@tanstack/react-router-ssr-query
npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@8013

@tanstack/react-start
npm i https://pkg.pr.new/@tanstack/react-start@8013

@tanstack/react-start-client
npm i https://pkg.pr.new/@tanstack/react-start-client@8013

@tanstack/react-start-rsc
npm i https://pkg.pr.new/@tanstack/react-start-rsc@8013

@tanstack/react-start-server
npm i https://pkg.pr.new/@tanstack/react-start-server@8013

@tanstack/router-cli
npm i https://pkg.pr.new/@tanstack/router-cli@8013

@tanstack/router-core
npm i https://pkg.pr.new/@tanstack/router-core@8013

@tanstack/router-devtools
npm i https://pkg.pr.new/@tanstack/router-devtools@8013

@tanstack/router-devtools-core
npm i https://pkg.pr.new/@tanstack/router-devtools-core@8013

@tanstack/router-generator
npm i https://pkg.pr.new/@tanstack/router-generator@8013

@tanstack/router-plugin
npm i https://pkg.pr.new/@tanstack/router-plugin@8013

@tanstack/router-ssr-query-core
npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@8013

@tanstack/router-utils
npm i https://pkg.pr.new/@tanstack/router-utils@8013

@tanstack/router-vite-plugin
npm i https://pkg.pr.new/@tanstack/router-vite-plugin@8013

@tanstack/solid-router
npm i https://pkg.pr.new/@tanstack/solid-router@8013

@tanstack/solid-router-devtools
npm i https://pkg.pr.new/@tanstack/solid-router-devtools@8013

@tanstack/solid-router-ssr-query
npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@8013

@tanstack/solid-start
npm i https://pkg.pr.new/@tanstack/solid-start@8013

@tanstack/solid-start-client
npm i https://pkg.pr.new/@tanstack/solid-start-client@8013

@tanstack/solid-start-server
npm i https://pkg.pr.new/@tanstack/solid-start-server@8013

@tanstack/start-client-core
npm i https://pkg.pr.new/@tanstack/start-client-core@8013

@tanstack/start-fn-stubs
npm i https://pkg.pr.new/@tanstack/start-fn-stubs@8013

@tanstack/start-plugin-core
npm i https://pkg.pr.new/@tanstack/start-plugin-core@8013

@tanstack/start-server-core
npm i https://pkg.pr.new/@tanstack/start-server-core@8013

@tanstack/start-static-server-functions
npm i https://pkg.pr.new/@tanstack/start-static-server-functions@8013

@tanstack/start-storage-context
npm i https://pkg.pr.new/@tanstack/start-storage-context@8013

@tanstack/valibot-adapter
npm i https://pkg.pr.new/@tanstack/valibot-adapter@8013

@tanstack/virtual-file-routes
npm i https://pkg.pr.new/@tanstack/virtual-file-routes@8013

@tanstack/vue-router
npm i https://pkg.pr.new/@tanstack/vue-router@8013

@tanstack/vue-router-devtools
npm i https://pkg.pr.new/@tanstack/vue-router-devtools@8013

@tanstack/vue-router-ssr-query
npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@8013

@tanstack/vue-start
npm i https://pkg.pr.new/@tanstack/vue-start@8013

@tanstack/vue-start-client
npm i https://pkg.pr.new/@tanstack/vue-start-client@8013

@tanstack/vue-start-server
npm i https://pkg.pr.new/@tanstack/vue-start-server@8013

@tanstack/zod-adapter
npm i https://pkg.pr.new/@tanstack/zod-adapter@8013

commit: bfb5233
@codspeed-hq
codspeed-hqBot
commented
Aug 8, 2026

Copy link


Copy Markdown

Merging this PR will degrade performance by 10.71%
⚠️Different runtime environments detected
Some benchmarks with significant performance changes were compared across different runtime environments,

which may affect the accuracy of the results.
Open the report in CodSpeed to investigate
⚡ 3 improved benchmarks
❌ 5 regressed benchmarks
✅ 172 untouched benchmarks
Warning
Please fix the performance issues or acknowledge them on CodSpeed.
Performance Changes
ModeBenchmarkBASEHEADEfficiency
❌Memorymem server error-paths unmatched (react)272.3 KB849.3 KB-67.93%
❌Memorymem client unique-location-churn (solid)352.4 KB457.4 KB-22.96%
❌Memorymem client navigation-churn (solid)575 KB629 KB-8.58%
❌Memorymem client unique-location-churn (vue)1.2 MB1.3 MB-6.16%
❌Memorymem server server-fn-churn (vue)263.2 KB274.8 KB-4.21%
⚡Memorymem server error-paths not-found (solid)728.6 KB417 KB+74.72%
⚡Memorymem client preload-churn (vue)805.5 KB736.6 KB+9.35%
⚡Memorymem server error-paths not-found (react)260.8 KB250.3 KB+4.18%
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing perf/router-core-search-parse-fast-path (bfb5233) with main (44a8c3e)
Open in CodSpeed
@Sheraff
Sheraff
marked this pull request as draft
August 9, 2026 06:25
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

package: router-core

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@Sheraff

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
perf(router-core): skip impossible JSON parses during search parsing - #8013
Draft
Sheraff wants to merge 1 commit into
mainfrom 
perf/router-core-search-parse-fast-path
Draft
perf(router-core): skip impossible JSON parses during search parsing#8013
Sheraff wants to merge 1 commit into
mainfrom 
perf/router-core-search-parse-fast-path
Conversation
@Sheraff
@SheraffSheraff
commented
Aug 8, 2026•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Collaborator
Summary
  • apply the existing jsonStart fast path to parseSearchWith when using JSON.parse
  • preserve custom parser behavior and cover both paths with unit tests
  • add default search parsing benchmark scenarios and a patch changeset
Testing
  • CI=1 NX_DAEMON=false pnpm nx run @tanstack/router-core:test:unit --outputStyle=stream --skipRemoteCache -- tests/searchParams.test.ts
  • CI=1 NX_DAEMON=false pnpm nx run @tanstack/router-core:test:types --outputStyle=stream --skipRemoteCache
  • CI=1 NX_DAEMON=false pnpm nx run @tanstack/router-core:test:eslint --outputStyle=stream --skipRemoteCache
  • CI=1 NX_DAEMON=false pnpm nx run @tanstack/router-core:test:unit --outputStyle=stream --skipRemoteCache -- bench tests/searchParams.bench.ts --run
Summary by CodeRabbit
  • Bug Fixes
    • Improved search-parameter parsing by skipping values that cannot be valid JSON.
    • Preserved existing parsing behavior and silent error handling for eligible values.
  • Performance
    • Reduced unnecessary JSON parsing during search-parameter processing.
  • Tests
    • Added coverage for custom parsing, decoded parameters, invalid JSON values, and parsing performance.
@nx-cloud
nx-cloudBot
commented
Aug 8, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
View your CI Pipeline Execution ↗ for commit bfb5233
CommandStatusDurationResult
nx affected --targets=test:eslint,test:unit,tes...✅ Succeeded11m 58sView ↗
nx run-many --target=build --exclude=examples/*...✅ Succeeded2m 6sView ↗
☁️ Nx Cloud last updated this comment at 2026-08-08 18:40:15 UTC
@github-actions
github-actionsBot
commented
Aug 8, 2026

Copy link


Copy Markdown

Contributor
🚀 Changeset Version Preview
2 package(s) bumped directly, 21 bumped as dependents.
🟩 Patch bumps
PackageVersionReason
@tanstack/router-core1.171.19 → 1.171.20Changeset
@tanstack/start-client-core1.170.19 → 1.170.20Changeset
@tanstack/react-router1.170.23 → 1.170.24Dependent
@tanstack/react-start1.168.40 → 1.168.41Dependent
@tanstack/react-start-client1.168.21 → 1.168.22Dependent
@tanstack/react-start-rsc0.1.39 → 0.1.40Dependent
@tanstack/react-start-server1.167.28 → 1.167.29Dependent
@tanstack/router-cli1.167.25 → 1.167.26Dependent
@tanstack/router-generator1.167.25 → 1.167.26Dependent
@tanstack/router-plugin1.168.27 → 1.168.28Dependent
@tanstack/router-vite-plugin1.167.27 → 1.167.28Dependent
@tanstack/solid-router1.170.22 → 1.170.23Dependent
@tanstack/solid-start1.168.39 → 1.168.40Dependent
@tanstack/solid-start-client1.168.21 → 1.168.22Dependent
@tanstack/solid-start-server1.167.28 → 1.167.29Dependent
@tanstack/start-plugin-core1.171.31 → 1.171.32Dependent
@tanstack/start-server-core1.169.23 → 1.169.24Dependent
@tanstack/start-static-server-functions1.167.24 → 1.167.25Dependent
@tanstack/start-storage-context1.167.21 → 1.167.22Dependent
@tanstack/vue-router1.170.21 → 1.170.22Dependent
@tanstack/vue-start1.168.38 → 1.168.39Dependent
@tanstack/vue-start-client1.167.24 → 1.167.25Dependent
@tanstack/vue-start-server1.167.28 → 1.167.29Dependent
@coderabbitai
coderabbitaiBot
commented
Aug 8, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Review Change Stack
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 25e0496d-f38b-4880-b2e3-8de1cae4b5bf
📥 Commits
Reviewing files that changed from the base of the PR and between 44a8c3e and bfb5233.
📒 Files selected for processing (4)
  • .changeset/fast-search-parsing.md
  • packages/router-core/src/searchParams.ts
  • packages/router-core/tests/searchParams.bench.ts
  • packages/router-core/tests/searchParams.test.ts
📝 Walkthrough
Walkthrough
parseSearchWith now skips native JSON.parse attempts for values that cannot begin valid JSON. Tests cover custom parsers and skipped calls. Benchmarks measure parsing across several search-parameter value sets. A patch Changeset documents the behavior.
Changes
Search parameter parsing
Layer / File(s)Summary
Parser optimization and validation
packages/router-core/src/searchParams.ts, packages/router-core/tests/searchParams.test.ts, .changeset/fast-search-parsing.md		parseSearchWith detects native JSON.parse and skips values that cannot begin valid JSON. Tests cover custom parser output, decoded values, and skipped JSON.parse calls.
Parsing benchmark coverage
packages/router-core/tests/searchParams.bench.ts		Benchmarks parse ordinary, JSON-initial, JSON-compatible, and mixed serialized search values. Round-trip assertions validate the prepared fixtures.
Estimated code review effort: 2 (Simple) | ~15 minutes
Possibly related PRs
  • TanStack/router#8006: Both changes update parseSearchWith to skip impossible JSON.parse attempts and add related tests and Changesets.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly and concisely describes the main performance change in search parsing.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  •  Create stacked PR
  •  Commit on current branch
🧪 Generate unit tests (beta)
  •  Create PR with unit tests
  •  Commit unit tests in branch perf/router-core-search-parse-fast-path
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands.
@github-actions
github-actionsBot
commented
Aug 8, 2026

Copy link


Copy Markdown

Contributor
Bundle Size Benchmarks
  • Commit: 6f3a5ba67da0
  • Measured at: 2026-08-08T18:29:25.678Z
  • Baseline source: history:44a8c3e1d2af
  • Dashboard: bundle-size history
The following scenarios have bundle-size changes compared with the baseline:
ScenarioCurrent (gzip)Delta vs baselineInitial gzipRawBrotliTrend
react-router.minimal83.93 KiB+18 B (+0.02%)83.80 KiB262.72 KiB73.03 KiB███████▁▁▁▁▁
react-router.full87.45 KiB+18 B (+0.02%)87.31 KiB274.43 KiB76.16 KiB███████▁▁▁▁▁
solid-router.minimal33.26 KiB+20 B (+0.06%)33.13 KiB96.55 KiB30.05 KiB███████▁▁▁▁▁
solid-router.full38.08 KiB+17 B (+0.04%)37.96 KiB111.19 KiB34.30 KiB███████▁▁▁▁▁
vue-router.minimal49.54 KiB+20 B (+0.04%)49.42 KiB138.30 KiB44.75 KiB███████▁▁▁▁▁
vue-router.full55.12 KiB+16 B (+0.03%)55.00 KiB156.47 KiB49.64 KiB███████▁▁▁▁▁
react-start.minimal96.77 KiB+16 B (+0.02%)96.64 KiB304.93 KiB83.86 KiB███████▁▁▁▁▁
react-start.deferred-hydration97.50 KiB+16 B (+0.02%)96.66 KiB306.29 KiB84.51 KiB███████▁▁▁▁▁
react-start.full99.94 KiB+20 B (+0.02%)99.80 KiB314.65 KiB86.61 KiB███████▁▁▁▁▁
react-start.rsbuild.minimal100.08 KiB+18 B (+0.02%)99.91 KiB315.48 KiB86.35 KiB▁▄▄▃▃▄▄▄▄▆▇█
react-start.rsbuild.minimal-iife100.49 KiB+19 B (+0.02%)100.32 KiB316.42 KiB86.61 KiB▁▄▄▃▃▄▄▄▄▆▇█
react-start.rsbuild.full103.41 KiB+17 B (+0.02%)103.24 KiB325.57 KiB89.02 KiB▁▃▃▃▃▄▄▄▄▆▇█
solid-start.minimal46.03 KiB+16 B (+0.03%)45.90 KiB137.61 KiB40.94 KiB███████▁▁▁▁▁
solid-start.deferred-hydration49.10 KiB+15 B (+0.03%)45.96 KiB145.07 KiB43.73 KiB███████▁▁▁▁▁
solid-start.full51.11 KiB+17 B (+0.03%)50.98 KiB153.00 KiB45.31 KiB███████▁▁▁▁▁
vue-start.minimal65.56 KiB+14 B (+0.02%)65.44 KiB189.12 KiB58.36 KiB███████▁▁▁▁▁
vue-start.full69.39 KiB+19 B (+0.03%)69.26 KiB201.40 KiB61.67 KiB███████▁▁▁▁▁
Current gzip tracks all emitted client JS chunks. Initial gzip tracks only the entry/import graph. Trend sparkline is historical current gzip ending with this PR measurement; lower is better.
@pkg-pr-new
pkg-pr-newBot
commented
Aug 8, 2026

Copy link


Copy Markdown

More templates
@tanstack/arktype-adapter
npm i https://pkg.pr.new/@tanstack/arktype-adapter@8013

@tanstack/eslint-plugin-router
npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@8013

@tanstack/eslint-plugin-start
npm i https://pkg.pr.new/@tanstack/eslint-plugin-start@8013

@tanstack/history
npm i https://pkg.pr.new/@tanstack/history@8013

@tanstack/nitro-v2-vite-plugin
npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@8013

@tanstack/react-router
npm i https://pkg.pr.new/@tanstack/react-router@8013

@tanstack/react-router-devtools
npm i https://pkg.pr.new/@tanstack/react-router-devtools@8013

@tanstack/react-router-ssr-query
npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@8013

@tanstack/react-start
npm i https://pkg.pr.new/@tanstack/react-start@8013

@tanstack/react-start-client
npm i https://pkg.pr.new/@tanstack/react-start-client@8013

@tanstack/react-start-rsc
npm i https://pkg.pr.new/@tanstack/react-start-rsc@8013

@tanstack/react-start-server
npm i https://pkg.pr.new/@tanstack/react-start-server@8013

@tanstack/router-cli
npm i https://pkg.pr.new/@tanstack/router-cli@8013

@tanstack/router-core
npm i https://pkg.pr.new/@tanstack/router-core@8013

@tanstack/router-devtools
npm i https://pkg.pr.new/@tanstack/router-devtools@8013

@tanstack/router-devtools-core
npm i https://pkg.pr.new/@tanstack/router-devtools-core@8013

@tanstack/router-generator
npm i https://pkg.pr.new/@tanstack/router-generator@8013

@tanstack/router-plugin
npm i https://pkg.pr.new/@tanstack/router-plugin@8013

@tanstack/router-ssr-query-core
npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@8013

@tanstack/router-utils
npm i https://pkg.pr.new/@tanstack/router-utils@8013

@tanstack/router-vite-plugin
npm i https://pkg.pr.new/@tanstack/router-vite-plugin@8013

@tanstack/solid-router
npm i https://pkg.pr.new/@tanstack/solid-router@8013

@tanstack/solid-router-devtools
npm i https://pkg.pr.new/@tanstack/solid-router-devtools@8013

@tanstack/solid-router-ssr-query
npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@8013

@tanstack/solid-start
npm i https://pkg.pr.new/@tanstack/solid-start@8013

@tanstack/solid-start-client
npm i https://pkg.pr.new/@tanstack/solid-start-client@8013

@tanstack/solid-start-server
npm i https://pkg.pr.new/@tanstack/solid-start-server@8013

@tanstack/start-client-core
npm i https://pkg.pr.new/@tanstack/start-client-core@8013

@tanstack/start-fn-stubs
npm i https://pkg.pr.new/@tanstack/start-fn-stubs@8013

@tanstack/start-plugin-core
npm i https://pkg.pr.new/@tanstack/start-plugin-core@8013

@tanstack/start-server-core
npm i https://pkg.pr.new/@tanstack/start-server-core@8013

@tanstack/start-static-server-functions
npm i https://pkg.pr.new/@tanstack/start-static-server-functions@8013

@tanstack/start-storage-context
npm i https://pkg.pr.new/@tanstack/start-storage-context@8013

@tanstack/valibot-adapter
npm i https://pkg.pr.new/@tanstack/valibot-adapter@8013

@tanstack/virtual-file-routes
npm i https://pkg.pr.new/@tanstack/virtual-file-routes@8013

@tanstack/vue-router
npm i https://pkg.pr.new/@tanstack/vue-router@8013

@tanstack/vue-router-devtools
npm i https://pkg.pr.new/@tanstack/vue-router-devtools@8013

@tanstack/vue-router-ssr-query
npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@8013

@tanstack/vue-start
npm i https://pkg.pr.new/@tanstack/vue-start@8013

@tanstack/vue-start-client
npm i https://pkg.pr.new/@tanstack/vue-start-client@8013

@tanstack/vue-start-server
npm i https://pkg.pr.new/@tanstack/vue-start-server@8013

@tanstack/zod-adapter
npm i https://pkg.pr.new/@tanstack/zod-adapter@8013

commit: bfb5233
@codspeed-hq
codspeed-hqBot
commented
Aug 8, 2026

Copy link


Copy Markdown

Merging this PR will degrade performance by 10.71%
⚠️Different runtime environments detected
Some benchmarks with significant performance changes were compared across different runtime environments,

which may affect the accuracy of the results.
Open the report in CodSpeed to investigate
⚡ 3 improved benchmarks
❌ 5 regressed benchmarks
✅ 172 untouched benchmarks
Warning
Please fix the performance issues or acknowledge them on CodSpeed.
Performance Changes
ModeBenchmarkBASEHEADEfficiency
❌Memorymem server error-paths unmatched (react)272.3 KB849.3 KB-67.93%
❌Memorymem client unique-location-churn (solid)352.4 KB457.4 KB-22.96%
❌Memorymem client navigation-churn (solid)575 KB629 KB-8.58%
❌Memorymem client unique-location-churn (vue)1.2 MB1.3 MB-6.16%
❌Memorymem server server-fn-churn (vue)263.2 KB274.8 KB-4.21%
⚡Memorymem server error-paths not-found (solid)728.6 KB417 KB+74.72%
⚡Memorymem client preload-churn (vue)805.5 KB736.6 KB+9.35%
⚡Memorymem server error-paths not-found (react)260.8 KB250.3 KB+4.18%
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing perf/router-core-search-parse-fast-path (bfb5233) with main (44a8c3e)
Open in CodSpeed
@Sheraff
Sheraff
marked this pull request as draft
August 9, 2026 06:25
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

package: router-core

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@Sheraff

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
perf(router-core): skip impossible JSON parses during search parsing - #8013
Draft
Sheraff wants to merge 1 commit into
mainfrom 
perf/router-core-search-parse-fast-path
Draft
perf(router-core): skip impossible JSON parses during search parsing#8013
Sheraff wants to merge 1 commit into
mainfrom 
perf/router-core-search-parse-fast-path
Conversation
@Sheraff
@SheraffSheraff
commented
Aug 8, 2026•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Collaborator
Summary
  • apply the existing jsonStart fast path to parseSearchWith when using JSON.parse
  • preserve custom parser behavior and cover both paths with unit tests
  • add default search parsing benchmark scenarios and a patch changeset
Testing
  • CI=1 NX_DAEMON=false pnpm nx run @tanstack/router-core:test:unit --outputStyle=stream --skipRemoteCache -- tests/searchParams.test.ts
  • CI=1 NX_DAEMON=false pnpm nx run @tanstack/router-core:test:types --outputStyle=stream --skipRemoteCache
  • CI=1 NX_DAEMON=false pnpm nx run @tanstack/router-core:test:eslint --outputStyle=stream --skipRemoteCache
  • CI=1 NX_DAEMON=false pnpm nx run @tanstack/router-core:test:unit --outputStyle=stream --skipRemoteCache -- bench tests/searchParams.bench.ts --run
Summary by CodeRabbit
  • Bug Fixes
    • Improved search-parameter parsing by skipping values that cannot be valid JSON.
    • Preserved existing parsing behavior and silent error handling for eligible values.
  • Performance
    • Reduced unnecessary JSON parsing during search-parameter processing.
  • Tests
    • Added coverage for custom parsing, decoded parameters, invalid JSON values, and parsing performance.
@nx-cloud
nx-cloudBot
commented
Aug 8, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
View your CI Pipeline Execution ↗ for commit bfb5233
CommandStatusDurationResult
nx affected --targets=test:eslint,test:unit,tes...✅ Succeeded11m 58sView ↗
nx run-many --target=build --exclude=examples/*...✅ Succeeded2m 6sView ↗
☁️ Nx Cloud last updated this comment at 2026-08-08 18:40:15 UTC
@github-actions
github-actionsBot
commented
Aug 8, 2026

Copy link


Copy Markdown

Contributor
🚀 Changeset Version Preview
2 package(s) bumped directly, 21 bumped as dependents.
🟩 Patch bumps
PackageVersionReason
@tanstack/router-core1.171.19 → 1.171.20Changeset
@tanstack/start-client-core1.170.19 → 1.170.20Changeset
@tanstack/react-router1.170.23 → 1.170.24Dependent
@tanstack/react-start1.168.40 → 1.168.41Dependent
@tanstack/react-start-client1.168.21 → 1.168.22Dependent
@tanstack/react-start-rsc0.1.39 → 0.1.40Dependent
@tanstack/react-start-server1.167.28 → 1.167.29Dependent
@tanstack/router-cli1.167.25 → 1.167.26Dependent
@tanstack/router-generator1.167.25 → 1.167.26Dependent
@tanstack/router-plugin1.168.27 → 1.168.28Dependent
@tanstack/router-vite-plugin1.167.27 → 1.167.28Dependent
@tanstack/solid-router1.170.22 → 1.170.23Dependent
@tanstack/solid-start1.168.39 → 1.168.40Dependent
@tanstack/solid-start-client1.168.21 → 1.168.22Dependent
@tanstack/solid-start-server1.167.28 → 1.167.29Dependent
@tanstack/start-plugin-core1.171.31 → 1.171.32Dependent
@tanstack/start-server-core1.169.23 → 1.169.24Dependent
@tanstack/start-static-server-functions1.167.24 → 1.167.25Dependent
@tanstack/start-storage-context1.167.21 → 1.167.22Dependent
@tanstack/vue-router1.170.21 → 1.170.22Dependent
@tanstack/vue-start1.168.38 → 1.168.39Dependent
@tanstack/vue-start-client1.167.24 → 1.167.25Dependent
@tanstack/vue-start-server1.167.28 → 1.167.29Dependent
@coderabbitai
coderabbitaiBot
commented
Aug 8, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Review Change Stack
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 25e0496d-f38b-4880-b2e3-8de1cae4b5bf
📥 Commits
Reviewing files that changed from the base of the PR and between 44a8c3e and bfb5233.
📒 Files selected for processing (4)
  • .changeset/fast-search-parsing.md
  • packages/router-core/src/searchParams.ts
  • packages/router-core/tests/searchParams.bench.ts
  • packages/router-core/tests/searchParams.test.ts
📝 Walkthrough
Walkthrough
parseSearchWith now skips native JSON.parse attempts for values that cannot begin valid JSON. Tests cover custom parsers and skipped calls. Benchmarks measure parsing across several search-parameter value sets. A patch Changeset documents the behavior.
Changes
Search parameter parsing
Layer / File(s)Summary
Parser optimization and validation
packages/router-core/src/searchParams.ts, packages/router-core/tests/searchParams.test.ts, .changeset/fast-search-parsing.md		parseSearchWith detects native JSON.parse and skips values that cannot begin valid JSON. Tests cover custom parser output, decoded values, and skipped JSON.parse calls.
Parsing benchmark coverage
packages/router-core/tests/searchParams.bench.ts		Benchmarks parse ordinary, JSON-initial, JSON-compatible, and mixed serialized search values. Round-trip assertions validate the prepared fixtures.
Estimated code review effort: 2 (Simple) | ~15 minutes
Possibly related PRs
  • TanStack/router#8006: Both changes update parseSearchWith to skip impossible JSON.parse attempts and add related tests and Changesets.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly and concisely describes the main performance change in search parsing.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  •  Create stacked PR
  •  Commit on current branch
🧪 Generate unit tests (beta)
  •  Create PR with unit tests
  •  Commit unit tests in branch perf/router-core-search-parse-fast-path
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands.
@github-actions
github-actionsBot
commented
Aug 8, 2026

Copy link


Copy Markdown

Contributor
Bundle Size Benchmarks
  • Commit: 6f3a5ba67da0
  • Measured at: 2026-08-08T18:29:25.678Z
  • Baseline source: history:44a8c3e1d2af
  • Dashboard: bundle-size history
The following scenarios have bundle-size changes compared with the baseline:
ScenarioCurrent (gzip)Delta vs baselineInitial gzipRawBrotliTrend
react-router.minimal83.93 KiB+18 B (+0.02%)83.80 KiB262.72 KiB73.03 KiB███████▁▁▁▁▁
react-router.full87.45 KiB+18 B (+0.02%)87.31 KiB274.43 KiB76.16 KiB███████▁▁▁▁▁
solid-router.minimal33.26 KiB+20 B (+0.06%)33.13 KiB96.55 KiB30.05 KiB███████▁▁▁▁▁
solid-router.full38.08 KiB+17 B (+0.04%)37.96 KiB111.19 KiB34.30 KiB███████▁▁▁▁▁
vue-router.minimal49.54 KiB+20 B (+0.04%)49.42 KiB138.30 KiB44.75 KiB███████▁▁▁▁▁
vue-router.full55.12 KiB+16 B (+0.03%)55.00 KiB156.47 KiB49.64 KiB███████▁▁▁▁▁
react-start.minimal96.77 KiB+16 B (+0.02%)96.64 KiB304.93 KiB83.86 KiB███████▁▁▁▁▁
react-start.deferred-hydration97.50 KiB+16 B (+0.02%)96.66 KiB306.29 KiB84.51 KiB███████▁▁▁▁▁
react-start.full99.94 KiB+20 B (+0.02%)99.80 KiB314.65 KiB86.61 KiB███████▁▁▁▁▁
react-start.rsbuild.minimal100.08 KiB+18 B (+0.02%)99.91 KiB315.48 KiB86.35 KiB▁▄▄▃▃▄▄▄▄▆▇█
react-start.rsbuild.minimal-iife100.49 KiB+19 B (+0.02%)100.32 KiB316.42 KiB86.61 KiB▁▄▄▃▃▄▄▄▄▆▇█
react-start.rsbuild.full103.41 KiB+17 B (+0.02%)103.24 KiB325.57 KiB89.02 KiB▁▃▃▃▃▄▄▄▄▆▇█
solid-start.minimal46.03 KiB+16 B (+0.03%)45.90 KiB137.61 KiB40.94 KiB███████▁▁▁▁▁
solid-start.deferred-hydration49.10 KiB+15 B (+0.03%)45.96 KiB145.07 KiB43.73 KiB███████▁▁▁▁▁
solid-start.full51.11 KiB+17 B (+0.03%)50.98 KiB153.00 KiB45.31 KiB███████▁▁▁▁▁
vue-start.minimal65.56 KiB+14 B (+0.02%)65.44 KiB189.12 KiB58.36 KiB███████▁▁▁▁▁
vue-start.full69.39 KiB+19 B (+0.03%)69.26 KiB201.40 KiB61.67 KiB███████▁▁▁▁▁
Current gzip tracks all emitted client JS chunks. Initial gzip tracks only the entry/import graph. Trend sparkline is historical current gzip ending with this PR measurement; lower is better.
@pkg-pr-new
pkg-pr-newBot
commented
Aug 8, 2026

Copy link


Copy Markdown

More templates
@tanstack/arktype-adapter
npm i https://pkg.pr.new/@tanstack/arktype-adapter@8013

@tanstack/eslint-plugin-router
npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@8013

@tanstack/eslint-plugin-start
npm i https://pkg.pr.new/@tanstack/eslint-plugin-start@8013

@tanstack/history
npm i https://pkg.pr.new/@tanstack/history@8013

@tanstack/nitro-v2-vite-plugin
npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@8013

@tanstack/react-router
npm i https://pkg.pr.new/@tanstack/react-router@8013

@tanstack/react-router-devtools
npm i https://pkg.pr.new/@tanstack/react-router-devtools@8013

@tanstack/react-router-ssr-query
npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@8013

@tanstack/react-start
npm i https://pkg.pr.new/@tanstack/react-start@8013

@tanstack/react-start-client
npm i https://pkg.pr.new/@tanstack/react-start-client@8013

@tanstack/react-start-rsc
npm i https://pkg.pr.new/@tanstack/react-start-rsc@8013

@tanstack/react-start-server
npm i https://pkg.pr.new/@tanstack/react-start-server@8013

@tanstack/router-cli
npm i https://pkg.pr.new/@tanstack/router-cli@8013

@tanstack/router-core
npm i https://pkg.pr.new/@tanstack/router-core@8013

@tanstack/router-devtools
npm i https://pkg.pr.new/@tanstack/router-devtools@8013

@tanstack/router-devtools-core
npm i https://pkg.pr.new/@tanstack/router-devtools-core@8013

@tanstack/router-generator
npm i https://pkg.pr.new/@tanstack/router-generator@8013

@tanstack/router-plugin
npm i https://pkg.pr.new/@tanstack/router-plugin@8013

@tanstack/router-ssr-query-core
npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@8013

@tanstack/router-utils
npm i https://pkg.pr.new/@tanstack/router-utils@8013

@tanstack/router-vite-plugin
npm i https://pkg.pr.new/@tanstack/router-vite-plugin@8013

@tanstack/solid-router
npm i https://pkg.pr.new/@tanstack/solid-router@8013

@tanstack/solid-router-devtools
npm i https://pkg.pr.new/@tanstack/solid-router-devtools@8013

@tanstack/solid-router-ssr-query
npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@8013

@tanstack/solid-start
npm i https://pkg.pr.new/@tanstack/solid-start@8013

@tanstack/solid-start-client
npm i https://pkg.pr.new/@tanstack/solid-start-client@8013

@tanstack/solid-start-server
npm i https://pkg.pr.new/@tanstack/solid-start-server@8013

@tanstack/start-client-core
npm i https://pkg.pr.new/@tanstack/start-client-core@8013

@tanstack/start-fn-stubs
npm i https://pkg.pr.new/@tanstack/start-fn-stubs@8013

@tanstack/start-plugin-core
npm i https://pkg.pr.new/@tanstack/start-plugin-core@8013

@tanstack/start-server-core
npm i https://pkg.pr.new/@tanstack/start-server-core@8013

@tanstack/start-static-server-functions
npm i https://pkg.pr.new/@tanstack/start-static-server-functions@8013

@tanstack/start-storage-context
npm i https://pkg.pr.new/@tanstack/start-storage-context@8013

@tanstack/valibot-adapter
npm i https://pkg.pr.new/@tanstack/valibot-adapter@8013

@tanstack/virtual-file-routes
npm i https://pkg.pr.new/@tanstack/virtual-file-routes@8013

@tanstack/vue-router
npm i https://pkg.pr.new/@tanstack/vue-router@8013

@tanstack/vue-router-devtools
npm i https://pkg.pr.new/@tanstack/vue-router-devtools@8013

@tanstack/vue-router-ssr-query
npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@8013

@tanstack/vue-start
npm i https://pkg.pr.new/@tanstack/vue-start@8013

@tanstack/vue-start-client
npm i https://pkg.pr.new/@tanstack/vue-start-client@8013

@tanstack/vue-start-server
npm i https://pkg.pr.new/@tanstack/vue-start-server@8013

@tanstack/zod-adapter
npm i https://pkg.pr.new/@tanstack/zod-adapter@8013

commit: bfb5233
@codspeed-hq
codspeed-hqBot
commented
Aug 8, 2026

Copy link


Copy Markdown

Merging this PR will degrade performance by 10.71%
⚠️Different runtime environments detected
Some benchmarks with significant performance changes were compared across different runtime environments,

which may affect the accuracy of the results.
Open the report in CodSpeed to investigate
⚡ 3 improved benchmarks
❌ 5 regressed benchmarks
✅ 172 untouched benchmarks
Warning
Please fix the performance issues or acknowledge them on CodSpeed.
Performance Changes
ModeBenchmarkBASEHEADEfficiency
❌Memorymem server error-paths unmatched (react)272.3 KB849.3 KB-67.93%
❌Memorymem client unique-location-churn (solid)352.4 KB457.4 KB-22.96%
❌Memorymem client navigation-churn (solid)575 KB629 KB-8.58%
❌Memorymem client unique-location-churn (vue)1.2 MB1.3 MB-6.16%
❌Memorymem server server-fn-churn (vue)263.2 KB274.8 KB-4.21%
⚡Memorymem server error-paths not-found (solid)728.6 KB417 KB+74.72%
⚡Memorymem client preload-churn (vue)805.5 KB736.6 KB+9.35%
⚡Memorymem server error-paths not-found (react)260.8 KB250.3 KB+4.18%
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing perf/router-core-search-parse-fast-path (bfb5233) with main (44a8c3e)
Open in CodSpeed
@Sheraff
Sheraff
marked this pull request as draft
August 9, 2026 06:25
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

package: router-core

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@Sheraff