refactor: remove Link transition state - #8043

Merged
Sheraff merged 1 commit into
mainfrom
remove-link-is-transitioning
Aug 12, 2026
Merged

refactor: remove Link transition state#8043
Sheraff merged 1 commit into
mainfrom
remove-link-is-transitioning

Conversation

@Sheraff

@SheraffSheraff commented Aug 11, 2026•
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Collaborator

Summary

  • remove the undocumented per-Link isTransitioning state from the React, Solid, and Vue adapters
  • stop emitting data-transitioning and remove isTransitioning from Link render-prop/slot types and values
  • remove the obsolete Vue regression test and add patch changesets for all three router packages

Compatibility

isTransitioning and data-transitioning were undocumented, but the attribute was observable and Solid/Vue exposed the state at runtime. React advertised the field in its type without passing it at runtime. Please confirm that removing this accidental API is acceptable before merge.

Testing

  • CI=1 NX_DAEMON=false pnpm nx run-many --target=test:unit --projects=@tanstack/react-router,@tanstack/solid-router,@tanstack/vue-router --outputStyle=stream --skipRemoteCache
  • CI=1 NX_DAEMON=false pnpm nx run-many --target=test:types --projects=@tanstack/react-router,@tanstack/solid-router,@tanstack/vue-router --outputStyle=stream --skipRemoteCache
  • CI=1 NX_DAEMON=false pnpm nx run-many --target=test:eslint --projects=@tanstack/react-router,@tanstack/solid-router,@tanstack/vue-router --outputStyle=stream --skipRemoteCache
  • pnpm exec changeset status --since=main

Summary by CodeRabbit

  • Breaking Changes
    • Removed the undocumented isTransitioning state from React, Solid, and Vue router links.
    • Removed the data-transitioning attribute from rendered links.
    • Link child callbacks and Vue slots now receive only isActive.

@nx-cloud

nx-cloudBot commented Aug 11, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

View your CI Pipeline Execution ↗ for commit 143b1c5

CommandStatusDurationResult
nx affected --targets=test:eslint,test:unit,tes...✅ Succeeded10m 40sView ↗
nx run-many --target=build --exclude=examples/*...✅ Succeeded2m 20sView ↗

☁️ Nx Cloud last updated this comment at 2026-08-11 16:40:45 UTC

@github-actions

github-actionsBot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

🚀 Changeset Version Preview

4 package(s) bumped directly, 19 bumped as dependents.

🟩 Patch bumps

PackageVersionReason
@tanstack/react-router1.170.25 → 1.170.26Changeset
@tanstack/router-core1.171.21 → 1.171.22Changeset
@tanstack/solid-router1.170.24 → 1.170.25Changeset
@tanstack/vue-router1.170.23 → 1.170.24Changeset
@tanstack/react-start1.168.42 → 1.168.43Dependent
@tanstack/react-start-client1.168.23 → 1.168.24Dependent
@tanstack/react-start-rsc0.1.41 → 0.1.42Dependent
@tanstack/react-start-server1.167.30 → 1.167.31Dependent
@tanstack/router-cli1.167.27 → 1.167.28Dependent
@tanstack/router-generator1.167.27 → 1.167.28Dependent
@tanstack/router-plugin1.168.29 → 1.168.30Dependent
@tanstack/router-vite-plugin1.167.29 → 1.167.30Dependent
@tanstack/solid-start1.168.41 → 1.168.42Dependent
@tanstack/solid-start-client1.168.23 → 1.168.24Dependent
@tanstack/solid-start-server1.167.30 → 1.167.31Dependent
@tanstack/start-client-core1.170.21 → 1.170.22Dependent
@tanstack/start-plugin-core1.171.33 → 1.171.34Dependent
@tanstack/start-server-core1.169.25 → 1.169.26Dependent
@tanstack/start-static-server-functions1.167.26 → 1.167.27Dependent
@tanstack/start-storage-context1.167.23 → 1.167.24Dependent
@tanstack/vue-start1.168.40 → 1.168.41Dependent
@tanstack/vue-start-client1.167.26 → 1.167.27Dependent
@tanstack/vue-start-server1.167.30 → 1.167.31Dependent

@coderabbitai

coderabbitaiBot commented Aug 11, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 8b3158c2-9ac7-40c4-8c18-18a1f866cd41

📥 Commits

Reviewing files that changed from the base of the PR and between 7e93431 and 143b1c5.

📒 Files selected for processing (5)
  • .changeset/remove-link-transition-state.md
  • packages/react-router/src/link.tsx
  • packages/solid-router/src/link.tsx
  • packages/vue-router/src/link.tsx
  • packages/vue-router/tests/link.test.tsx
💤 Files with no reviewable changes (1)
  • packages/vue-router/tests/link.test.tsx
📝 Walkthrough

Walkthrough

The React, Solid, and Vue Link implementations no longer track or expose isTransitioning or data-transitioning. Their child callback state now contains only isActive. The Vue test for the removed behavior was deleted, and a patch changeset documents the change.

Changes

Link transition state removal

Layer / File(s)Summary
React Link state removal
packages/react-router/src/link.tsx, .changeset/remove-link-transition-state.md		React navigation no longer updates transition state. Link props and function children no longer expose transition data.
Solid Link state removal
packages/solid-router/src/link.tsx		Solid navigation no longer subscribes to resolution state. Transition attributes and callback state were removed.
Vue Link state removal and validation
packages/vue-router/src/link.tsx, packages/vue-router/tests/link.test.tsx		Vue Link results, navigation handling, computed props, attributes, and slots no longer include transition state. The related pending-navigation test was removed.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Possibly related PRs

  • TanStack/router#7952: Both changes modify React Router’s useLinkProps, but this PR removes transition state while that PR addresses render bailout optimization.
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 40.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly and concisely identifies the main change: removing Link transition state.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch remove-link-is-transitioning

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actionsBot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Bundle Size Benchmarks

  • Commit: 64ec8e03761f
  • Measured at: 2026-08-11T16:30:18.352Z
  • Baseline source: history:7e93431ae9ff
  • Dashboard: bundle-size history

The following scenarios have bundle-size changes compared with the baseline:

ScenarioCurrent (gzip)Delta vs baselineInitial gzipRawBrotliTrend
react-router.minimal83.84 KiB-83 B (-0.10%)83.70 KiB262.51 KiB72.91 KiB██▁▁▁▁▁▁▁▁▁▁
react-router.full87.35 KiB-77 B (-0.09%)87.21 KiB274.22 KiB76.04 KiB██▁▁▁▁▁▁▁▁▁▁
solid-router.minimal33.17 KiB-73 B (-0.21%)33.04 KiB96.31 KiB29.90 KiB██▁▁▁▁▁▁▁▁▁▁
solid-router.full38.00 KiB-70 B (-0.18%)37.88 KiB110.95 KiB34.20 KiB██▁▁▁▁▁▁▁▁▁▁
vue-router.minimal49.46 KiB-60 B (-0.12%)49.34 KiB138.03 KiB44.64 KiB██▁▁▁▁▁▁▁▁▁▁
vue-router.full55.04 KiB-57 B (-0.10%)54.92 KiB156.21 KiB49.56 KiB██▁▁▁▁▁▁▁▁▁▁
react-start.minimal96.66 KiB-93 B (-0.09%)96.52 KiB304.72 KiB83.79 KiB██▁▁▁▁▁▁▁▁▁▁
react-start.deferred-hydration97.38 KiB-95 B (-0.10%)96.54 KiB306.07 KiB84.38 KiB██▁▁▁▁▁▁▁▁▁▁
react-start.full99.84 KiB-81 B (-0.08%)99.70 KiB314.44 KiB86.44 KiB██▁▁▁▁▁▁▁▁▁▁
react-start.rsbuild.minimal99.98 KiB-84 B (-0.08%)99.81 KiB315.25 KiB86.24 KiB▂▂▂▂▆██████▁
react-start.rsbuild.minimal-iife100.39 KiB-84 B (-0.08%)100.22 KiB316.19 KiB86.60 KiB▂▂▂▂▆██████▁
react-start.rsbuild.full103.31 KiB-82 B (-0.08%)103.14 KiB325.35 KiB88.91 KiB▁▁▁▁▅██████▁
solid-start.minimal45.94 KiB-74 B (-0.16%)45.81 KiB137.37 KiB40.87 KiB██▁▁▁▁▁▁▁▁▁▁
solid-start.deferred-hydration49.00 KiB-80 B (-0.16%)45.87 KiB144.83 KiB43.72 KiB██▁▁▁▁▁▁▁▁▁▁
solid-start.full51.03 KiB-61 B (-0.12%)50.90 KiB152.76 KiB45.22 KiB██▁▁▁▁▁▁▁▁▁▁
vue-start.minimal65.48 KiB-64 B (-0.10%)65.35 KiB188.86 KiB58.33 KiB██▁▁▁▁▁▁▁▁▁▁
vue-start.full69.30 KiB-60 B (-0.08%)69.18 KiB201.13 KiB61.58 KiB██▁▁▁▁▁▁▁▁▁▁

Current gzip tracks all emitted client JS chunks. Initial gzip tracks only the entry/import graph. Trend sparkline is historical current gzip ending with this PR measurement; lower is better.

@pkg-pr-new

pkg-pr-newBot commented Aug 11, 2026

Copy link
Copy Markdown
More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/@tanstack/arktype-adapter@8043

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@8043

@tanstack/eslint-plugin-start

npm i https://pkg.pr.new/@tanstack/eslint-plugin-start@8043

@tanstack/history

npm i https://pkg.pr.new/@tanstack/history@8043

@tanstack/nitro-v2-vite-plugin

npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@8043

@tanstack/react-router

npm i https://pkg.pr.new/@tanstack/react-router@8043

@tanstack/react-router-devtools

npm i https://pkg.pr.new/@tanstack/react-router-devtools@8043

@tanstack/react-router-ssr-query

npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@8043

@tanstack/react-start

npm i https://pkg.pr.new/@tanstack/react-start@8043

@tanstack/react-start-client

npm i https://pkg.pr.new/@tanstack/react-start-client@8043

@tanstack/react-start-rsc

npm i https://pkg.pr.new/@tanstack/react-start-rsc@8043

@tanstack/react-start-server

npm i https://pkg.pr.new/@tanstack/react-start-server@8043

@tanstack/router-cli

npm i https://pkg.pr.new/@tanstack/router-cli@8043

@tanstack/router-core

npm i https://pkg.pr.new/@tanstack/router-core@8043

@tanstack/router-devtools

npm i https://pkg.pr.new/@tanstack/router-devtools@8043

@tanstack/router-devtools-core

npm i https://pkg.pr.new/@tanstack/router-devtools-core@8043

@tanstack/router-generator

npm i https://pkg.pr.new/@tanstack/router-generator@8043

@tanstack/router-plugin

npm i https://pkg.pr.new/@tanstack/router-plugin@8043

@tanstack/router-ssr-query-core

npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@8043

@tanstack/router-utils

npm i https://pkg.pr.new/@tanstack/router-utils@8043

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/@tanstack/router-vite-plugin@8043

@tanstack/solid-router

npm i https://pkg.pr.new/@tanstack/solid-router@8043

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/@tanstack/solid-router-devtools@8043

@tanstack/solid-router-ssr-query

npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@8043

@tanstack/solid-start

npm i https://pkg.pr.new/@tanstack/solid-start@8043

@tanstack/solid-start-client

npm i https://pkg.pr.new/@tanstack/solid-start-client@8043

@tanstack/solid-start-server

npm i https://pkg.pr.new/@tanstack/solid-start-server@8043

@tanstack/start-client-core

npm i https://pkg.pr.new/@tanstack/start-client-core@8043

@tanstack/start-fn-stubs

npm i https://pkg.pr.new/@tanstack/start-fn-stubs@8043

@tanstack/start-plugin-core

npm i https://pkg.pr.new/@tanstack/start-plugin-core@8043

@tanstack/start-server-core

npm i https://pkg.pr.new/@tanstack/start-server-core@8043

@tanstack/start-static-server-functions

npm i https://pkg.pr.new/@tanstack/start-static-server-functions@8043

@tanstack/start-storage-context

npm i https://pkg.pr.new/@tanstack/start-storage-context@8043

@tanstack/valibot-adapter

npm i https://pkg.pr.new/@tanstack/valibot-adapter@8043

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/@tanstack/virtual-file-routes@8043

@tanstack/vue-router

npm i https://pkg.pr.new/@tanstack/vue-router@8043

@tanstack/vue-router-devtools

npm i https://pkg.pr.new/@tanstack/vue-router-devtools@8043

@tanstack/vue-router-ssr-query

npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@8043

@tanstack/vue-start

npm i https://pkg.pr.new/@tanstack/vue-start@8043

@tanstack/vue-start-client

npm i https://pkg.pr.new/@tanstack/vue-start-client@8043

@tanstack/vue-start-server

npm i https://pkg.pr.new/@tanstack/vue-start-server@8043

@tanstack/zod-adapter

npm i https://pkg.pr.new/@tanstack/zod-adapter@8043

commit: 143b1c5

@codspeed-hq

codspeed-hqBot commented Aug 11, 2026•
edited
Loading

Copy link
Copy Markdown

Merging this PR will regress 0 benchmarks

⚠️Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 25 improved benchmarks
❌ 7 (👁 7) regressed benchmarks
✅ 148 untouched benchmarks

Performance Changes

ModeBenchmarkBASEHEADEfficiency
⚡Simulationclient-async-pipeline navigation loop (react)138.9 ms104.4 ms+32.98%
⚡Simulationclient-async-pipeline navigation loop (solid)200 ms176.5 ms+13.31%
⚡Memorymem server error-paths not-found (vue)777.5 KB688.9 KB+12.85%
⚡Simulationclient-route-tree-scale navigation loop (solid)375.4 ms334.7 ms+12.15%
⚡Simulationclient-rewrites navigation loop (solid)236.2 ms213 ms+10.91%
⚡Simulationclient-loaders navigation loop (solid)230.1 ms208.6 ms+10.26%
⚡Simulationclient-route-tree-scale navigation loop (react)189.1 ms172.7 ms+9.47%
⚡Simulationclient-rewrites navigation loop (react)155.1 ms142.3 ms+9.04%
⚡Simulationclient-control-flow navigation loop (solid)178.9 ms164.1 ms+8.98%
⚡Simulationclient-side navigation loop (react)138.1 ms126.9 ms+8.8%
⚡Simulationclient-links navigation loop (react)319.3 ms296.7 ms+7.61%
⚡Simulationclient-search-params navigation loop (solid)298.2 ms278.5 ms+7.07%
⚡Simulationclient-history navigation loop (solid)173 ms163.2 ms+6.01%
⚡Memorymem server error-paths unmatched (solid)592.5 KB560.5 KB+5.7%
⚡Simulationclient-history navigation loop (react)133.6 ms126.8 ms+5.36%
⚡Simulationclient-control-flow navigation loop (react)180.5 ms171.4 ms+5.27%
⚡Simulationclient-loaders navigation loop (react)136.3 ms129.5 ms+5.24%
⚡Memorymem server error-paths redirect (solid)379.9 KB361.2 KB+5.18%
⚡Memorymem server serialization-payload (vue)4.5 MB4.3 MB+4.94%
⚡Memorymem server aborted-requests (react)905.7 KB864.6 KB+4.75%
..................

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

Tip

Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.

Comparing remove-link-is-transitioning (143b1c5) with main (7e93431)

Open in CodSpeed

@Sheraff
Sheraff merged commit 1aafca9 into mainAug 12, 2026
26 checks passed
@Sheraff
Sheraff deleted the remove-link-is-transitioning branch August 12, 2026 07:52
@github-actionsgithub-actionsBot mentioned this pull request Aug 12, 2026
Merged
@brenelzbrenelz mentioned this pull request Aug 13, 2026
Merged
@brandhaugbrandhaug mentioned this pull request Aug 13, 2026
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

package: react-routerpackage: solid-routerpackage: vue-router

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Sheraff
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
refactor: remove Link transition state - #8043
Merged
Sheraff merged 1 commit into
mainfrom 
remove-link-is-transitioning
Aug 12, 2026
Merged
refactor: remove Link transition state#8043
Sheraff merged 1 commit into
mainfrom 
remove-link-is-transitioning
Conversation
@Sheraff
@SheraffSheraff
commented
Aug 11, 2026•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Collaborator
Summary
  • remove the undocumented per-Link isTransitioning state from the React, Solid, and Vue adapters
  • stop emitting data-transitioning and remove isTransitioning from Link render-prop/slot types and values
  • remove the obsolete Vue regression test and add patch changesets for all three router packages
Compatibility
isTransitioning and data-transitioning were undocumented, but the attribute was observable and Solid/Vue exposed the state at runtime. React advertised the field in its type without passing it at runtime. Please confirm that removing this accidental API is acceptable before merge.
Testing
  • CI=1 NX_DAEMON=false pnpm nx run-many --target=test:unit --projects=@tanstack/react-router,@tanstack/solid-router,@tanstack/vue-router --outputStyle=stream --skipRemoteCache
  • CI=1 NX_DAEMON=false pnpm nx run-many --target=test:types --projects=@tanstack/react-router,@tanstack/solid-router,@tanstack/vue-router --outputStyle=stream --skipRemoteCache
  • CI=1 NX_DAEMON=false pnpm nx run-many --target=test:eslint --projects=@tanstack/react-router,@tanstack/solid-router,@tanstack/vue-router --outputStyle=stream --skipRemoteCache
  • pnpm exec changeset status --since=main
Summary by CodeRabbit
  • Breaking Changes
    • Removed the undocumented isTransitioning state from React, Solid, and Vue router links.
    • Removed the data-transitioning attribute from rendered links.
    • Link child callbacks and Vue slots now receive only isActive.
@nx-cloud
nx-cloudBot
commented
Aug 11, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
View your CI Pipeline Execution ↗ for commit 143b1c5
CommandStatusDurationResult
nx affected --targets=test:eslint,test:unit,tes...✅ Succeeded10m 40sView ↗
nx run-many --target=build --exclude=examples/*...✅ Succeeded2m 20sView ↗
☁️ Nx Cloud last updated this comment at 2026-08-11 16:40:45 UTC
@github-actions
github-actionsBot
commented
Aug 11, 2026

Copy link


Copy Markdown

Contributor
🚀 Changeset Version Preview
4 package(s) bumped directly, 19 bumped as dependents.
🟩 Patch bumps
PackageVersionReason
@tanstack/react-router1.170.25 → 1.170.26Changeset
@tanstack/router-core1.171.21 → 1.171.22Changeset
@tanstack/solid-router1.170.24 → 1.170.25Changeset
@tanstack/vue-router1.170.23 → 1.170.24Changeset
@tanstack/react-start1.168.42 → 1.168.43Dependent
@tanstack/react-start-client1.168.23 → 1.168.24Dependent
@tanstack/react-start-rsc0.1.41 → 0.1.42Dependent
@tanstack/react-start-server1.167.30 → 1.167.31Dependent
@tanstack/router-cli1.167.27 → 1.167.28Dependent
@tanstack/router-generator1.167.27 → 1.167.28Dependent
@tanstack/router-plugin1.168.29 → 1.168.30Dependent
@tanstack/router-vite-plugin1.167.29 → 1.167.30Dependent
@tanstack/solid-start1.168.41 → 1.168.42Dependent
@tanstack/solid-start-client1.168.23 → 1.168.24Dependent
@tanstack/solid-start-server1.167.30 → 1.167.31Dependent
@tanstack/start-client-core1.170.21 → 1.170.22Dependent
@tanstack/start-plugin-core1.171.33 → 1.171.34Dependent
@tanstack/start-server-core1.169.25 → 1.169.26Dependent
@tanstack/start-static-server-functions1.167.26 → 1.167.27Dependent
@tanstack/start-storage-context1.167.23 → 1.167.24Dependent
@tanstack/vue-start1.168.40 → 1.168.41Dependent
@tanstack/vue-start-client1.167.26 → 1.167.27Dependent
@tanstack/vue-start-server1.167.30 → 1.167.31Dependent
@coderabbitai
coderabbitaiBot
commented
Aug 11, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Review Change Stack
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 8b3158c2-9ac7-40c4-8c18-18a1f866cd41
📥 Commits
Reviewing files that changed from the base of the PR and between 7e93431 and 143b1c5.
📒 Files selected for processing (5)
  • .changeset/remove-link-transition-state.md
  • packages/react-router/src/link.tsx
  • packages/solid-router/src/link.tsx
  • packages/vue-router/src/link.tsx
  • packages/vue-router/tests/link.test.tsx
💤 Files with no reviewable changes (1)
  • packages/vue-router/tests/link.test.tsx
📝 Walkthrough
Walkthrough
The React, Solid, and Vue Link implementations no longer track or expose isTransitioning or data-transitioning. Their child callback state now contains only isActive. The Vue test for the removed behavior was deleted, and a patch changeset documents the change.
Changes
Link transition state removal
Layer / File(s)Summary
React Link state removal
packages/react-router/src/link.tsx, .changeset/remove-link-transition-state.md		React navigation no longer updates transition state. Link props and function children no longer expose transition data.
Solid Link state removal
packages/solid-router/src/link.tsx		Solid navigation no longer subscribes to resolution state. Transition attributes and callback state were removed.
Vue Link state removal and validation
packages/vue-router/src/link.tsx, packages/vue-router/tests/link.test.tsx		Vue Link results, navigation handling, computed props, attributes, and slots no longer include transition state. The related pending-navigation test was removed.
Estimated code review effort: 3 (Moderate) | ~20 minutes
Possibly related PRs
  • TanStack/router#7952: Both changes modify React Router’s useLinkProps, but this PR removes transition state while that PR addresses render bailout optimization.
🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 warning)
Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 40.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly and concisely identifies the main change: removing Link transition state.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  •  Create stacked PR
  •  Commit on current branch
🧪 Generate unit tests (beta)
  •  Create PR with unit tests
  •  Commit unit tests in branch remove-link-is-transitioning
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands.
@github-actions
github-actionsBot
commented
Aug 11, 2026

Copy link


Copy Markdown

Contributor
Bundle Size Benchmarks
  • Commit: 64ec8e03761f
  • Measured at: 2026-08-11T16:30:18.352Z
  • Baseline source: history:7e93431ae9ff
  • Dashboard: bundle-size history
The following scenarios have bundle-size changes compared with the baseline:
ScenarioCurrent (gzip)Delta vs baselineInitial gzipRawBrotliTrend
react-router.minimal83.84 KiB-83 B (-0.10%)83.70 KiB262.51 KiB72.91 KiB██▁▁▁▁▁▁▁▁▁▁
react-router.full87.35 KiB-77 B (-0.09%)87.21 KiB274.22 KiB76.04 KiB██▁▁▁▁▁▁▁▁▁▁
solid-router.minimal33.17 KiB-73 B (-0.21%)33.04 KiB96.31 KiB29.90 KiB██▁▁▁▁▁▁▁▁▁▁
solid-router.full38.00 KiB-70 B (-0.18%)37.88 KiB110.95 KiB34.20 KiB██▁▁▁▁▁▁▁▁▁▁
vue-router.minimal49.46 KiB-60 B (-0.12%)49.34 KiB138.03 KiB44.64 KiB██▁▁▁▁▁▁▁▁▁▁
vue-router.full55.04 KiB-57 B (-0.10%)54.92 KiB156.21 KiB49.56 KiB██▁▁▁▁▁▁▁▁▁▁
react-start.minimal96.66 KiB-93 B (-0.09%)96.52 KiB304.72 KiB83.79 KiB██▁▁▁▁▁▁▁▁▁▁
react-start.deferred-hydration97.38 KiB-95 B (-0.10%)96.54 KiB306.07 KiB84.38 KiB██▁▁▁▁▁▁▁▁▁▁
react-start.full99.84 KiB-81 B (-0.08%)99.70 KiB314.44 KiB86.44 KiB██▁▁▁▁▁▁▁▁▁▁
react-start.rsbuild.minimal99.98 KiB-84 B (-0.08%)99.81 KiB315.25 KiB86.24 KiB▂▂▂▂▆██████▁
react-start.rsbuild.minimal-iife100.39 KiB-84 B (-0.08%)100.22 KiB316.19 KiB86.60 KiB▂▂▂▂▆██████▁
react-start.rsbuild.full103.31 KiB-82 B (-0.08%)103.14 KiB325.35 KiB88.91 KiB▁▁▁▁▅██████▁
solid-start.minimal45.94 KiB-74 B (-0.16%)45.81 KiB137.37 KiB40.87 KiB██▁▁▁▁▁▁▁▁▁▁
solid-start.deferred-hydration49.00 KiB-80 B (-0.16%)45.87 KiB144.83 KiB43.72 KiB██▁▁▁▁▁▁▁▁▁▁
solid-start.full51.03 KiB-61 B (-0.12%)50.90 KiB152.76 KiB45.22 KiB██▁▁▁▁▁▁▁▁▁▁
vue-start.minimal65.48 KiB-64 B (-0.10%)65.35 KiB188.86 KiB58.33 KiB██▁▁▁▁▁▁▁▁▁▁
vue-start.full69.30 KiB-60 B (-0.08%)69.18 KiB201.13 KiB61.58 KiB██▁▁▁▁▁▁▁▁▁▁
Current gzip tracks all emitted client JS chunks. Initial gzip tracks only the entry/import graph. Trend sparkline is historical current gzip ending with this PR measurement; lower is better.
@pkg-pr-new
pkg-pr-newBot
commented
Aug 11, 2026

Copy link


Copy Markdown

More templates
@tanstack/arktype-adapter
npm i https://pkg.pr.new/@tanstack/arktype-adapter@8043

@tanstack/eslint-plugin-router
npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@8043

@tanstack/eslint-plugin-start
npm i https://pkg.pr.new/@tanstack/eslint-plugin-start@8043

@tanstack/history
npm i https://pkg.pr.new/@tanstack/history@8043

@tanstack/nitro-v2-vite-plugin
npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@8043

@tanstack/react-router
npm i https://pkg.pr.new/@tanstack/react-router@8043

@tanstack/react-router-devtools
npm i https://pkg.pr.new/@tanstack/react-router-devtools@8043

@tanstack/react-router-ssr-query
npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@8043

@tanstack/react-start
npm i https://pkg.pr.new/@tanstack/react-start@8043

@tanstack/react-start-client
npm i https://pkg.pr.new/@tanstack/react-start-client@8043

@tanstack/react-start-rsc
npm i https://pkg.pr.new/@tanstack/react-start-rsc@8043

@tanstack/react-start-server
npm i https://pkg.pr.new/@tanstack/react-start-server@8043

@tanstack/router-cli
npm i https://pkg.pr.new/@tanstack/router-cli@8043

@tanstack/router-core
npm i https://pkg.pr.new/@tanstack/router-core@8043

@tanstack/router-devtools
npm i https://pkg.pr.new/@tanstack/router-devtools@8043

@tanstack/router-devtools-core
npm i https://pkg.pr.new/@tanstack/router-devtools-core@8043

@tanstack/router-generator
npm i https://pkg.pr.new/@tanstack/router-generator@8043

@tanstack/router-plugin
npm i https://pkg.pr.new/@tanstack/router-plugin@8043

@tanstack/router-ssr-query-core
npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@8043

@tanstack/router-utils
npm i https://pkg.pr.new/@tanstack/router-utils@8043

@tanstack/router-vite-plugin
npm i https://pkg.pr.new/@tanstack/router-vite-plugin@8043

@tanstack/solid-router
npm i https://pkg.pr.new/@tanstack/solid-router@8043

@tanstack/solid-router-devtools
npm i https://pkg.pr.new/@tanstack/solid-router-devtools@8043

@tanstack/solid-router-ssr-query
npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@8043

@tanstack/solid-start
npm i https://pkg.pr.new/@tanstack/solid-start@8043

@tanstack/solid-start-client
npm i https://pkg.pr.new/@tanstack/solid-start-client@8043

@tanstack/solid-start-server
npm i https://pkg.pr.new/@tanstack/solid-start-server@8043

@tanstack/start-client-core
npm i https://pkg.pr.new/@tanstack/start-client-core@8043

@tanstack/start-fn-stubs
npm i https://pkg.pr.new/@tanstack/start-fn-stubs@8043

@tanstack/start-plugin-core
npm i https://pkg.pr.new/@tanstack/start-plugin-core@8043

@tanstack/start-server-core
npm i https://pkg.pr.new/@tanstack/start-server-core@8043

@tanstack/start-static-server-functions
npm i https://pkg.pr.new/@tanstack/start-static-server-functions@8043

@tanstack/start-storage-context
npm i https://pkg.pr.new/@tanstack/start-storage-context@8043

@tanstack/valibot-adapter
npm i https://pkg.pr.new/@tanstack/valibot-adapter@8043

@tanstack/virtual-file-routes
npm i https://pkg.pr.new/@tanstack/virtual-file-routes@8043

@tanstack/vue-router
npm i https://pkg.pr.new/@tanstack/vue-router@8043

@tanstack/vue-router-devtools
npm i https://pkg.pr.new/@tanstack/vue-router-devtools@8043

@tanstack/vue-router-ssr-query
npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@8043

@tanstack/vue-start
npm i https://pkg.pr.new/@tanstack/vue-start@8043

@tanstack/vue-start-client
npm i https://pkg.pr.new/@tanstack/vue-start-client@8043

@tanstack/vue-start-server
npm i https://pkg.pr.new/@tanstack/vue-start-server@8043

@tanstack/zod-adapter
npm i https://pkg.pr.new/@tanstack/zod-adapter@8043

commit: 143b1c5
@codspeed-hq
codspeed-hqBot
commented
Aug 11, 2026•

edited

Loading

Copy link


Copy Markdown

Merging this PR will regress 0 benchmarks
⚠️Different runtime environments detected
Some benchmarks with significant performance changes were compared across different runtime environments,

which may affect the accuracy of the results.
Open the report in CodSpeed to investigate
⚡ 25 improved benchmarks
❌ 7 (👁 7) regressed benchmarks
✅ 148 untouched benchmarks
Performance Changes
ModeBenchmarkBASEHEADEfficiency
⚡Simulationclient-async-pipeline navigation loop (react)138.9 ms104.4 ms+32.98%
⚡Simulationclient-async-pipeline navigation loop (solid)200 ms176.5 ms+13.31%
⚡Memorymem server error-paths not-found (vue)777.5 KB688.9 KB+12.85%
⚡Simulationclient-route-tree-scale navigation loop (solid)375.4 ms334.7 ms+12.15%
⚡Simulationclient-rewrites navigation loop (solid)236.2 ms213 ms+10.91%
⚡Simulationclient-loaders navigation loop (solid)230.1 ms208.6 ms+10.26%
⚡Simulationclient-route-tree-scale navigation loop (react)189.1 ms172.7 ms+9.47%
⚡Simulationclient-rewrites navigation loop (react)155.1 ms142.3 ms+9.04%
⚡Simulationclient-control-flow navigation loop (solid)178.9 ms164.1 ms+8.98%
⚡Simulationclient-side navigation loop (react)138.1 ms126.9 ms+8.8%
⚡Simulationclient-links navigation loop (react)319.3 ms296.7 ms+7.61%
⚡Simulationclient-search-params navigation loop (solid)298.2 ms278.5 ms+7.07%
⚡Simulationclient-history navigation loop (solid)173 ms163.2 ms+6.01%
⚡Memorymem server error-paths unmatched (solid)592.5 KB560.5 KB+5.7%
⚡Simulationclient-history navigation loop (react)133.6 ms126.8 ms+5.36%
⚡Simulationclient-control-flow navigation loop (react)180.5 ms171.4 ms+5.27%
⚡Simulationclient-loaders navigation loop (react)136.3 ms129.5 ms+5.24%
⚡Memorymem server error-paths redirect (solid)379.9 KB361.2 KB+5.18%
⚡Memorymem server serialization-payload (vue)4.5 MB4.3 MB+4.94%
⚡Memorymem server aborted-requests (react)905.7 KB864.6 KB+4.75%
..................

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.
Tip
Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.
Comparing remove-link-is-transitioning (143b1c5) with main (7e93431)
Open in CodSpeed
@Sheraff
Sheraff
merged commit 1aafca9
into
mainAug 12, 2026

26 checks passed

@Sheraff
Sheraff
deleted the

remove-link-is-transitioning

branch
August 12, 2026 07:52
@github-actionsgithub-actionsBot
mentioned this pull request
Aug 12, 2026
 Merged

@brenelzbrenelz
mentioned this pull request
Aug 13, 2026
 Merged

@brandhaugbrandhaug
mentioned this pull request
Aug 13, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

package: react-routerpackage: solid-routerpackage: vue-router

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@Sheraff

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
refactor: remove Link transition state - #8043
Merged
Sheraff merged 1 commit into
mainfrom 
remove-link-is-transitioning
Aug 12, 2026
Merged
refactor: remove Link transition state#8043
Sheraff merged 1 commit into
mainfrom 
remove-link-is-transitioning
Conversation
@Sheraff
@SheraffSheraff
commented
Aug 11, 2026•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Collaborator
Summary
  • remove the undocumented per-Link isTransitioning state from the React, Solid, and Vue adapters
  • stop emitting data-transitioning and remove isTransitioning from Link render-prop/slot types and values
  • remove the obsolete Vue regression test and add patch changesets for all three router packages
Compatibility
isTransitioning and data-transitioning were undocumented, but the attribute was observable and Solid/Vue exposed the state at runtime. React advertised the field in its type without passing it at runtime. Please confirm that removing this accidental API is acceptable before merge.
Testing
  • CI=1 NX_DAEMON=false pnpm nx run-many --target=test:unit --projects=@tanstack/react-router,@tanstack/solid-router,@tanstack/vue-router --outputStyle=stream --skipRemoteCache
  • CI=1 NX_DAEMON=false pnpm nx run-many --target=test:types --projects=@tanstack/react-router,@tanstack/solid-router,@tanstack/vue-router --outputStyle=stream --skipRemoteCache
  • CI=1 NX_DAEMON=false pnpm nx run-many --target=test:eslint --projects=@tanstack/react-router,@tanstack/solid-router,@tanstack/vue-router --outputStyle=stream --skipRemoteCache
  • pnpm exec changeset status --since=main
Summary by CodeRabbit
  • Breaking Changes
    • Removed the undocumented isTransitioning state from React, Solid, and Vue router links.
    • Removed the data-transitioning attribute from rendered links.
    • Link child callbacks and Vue slots now receive only isActive.
@nx-cloud
nx-cloudBot
commented
Aug 11, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
View your CI Pipeline Execution ↗ for commit 143b1c5
CommandStatusDurationResult
nx affected --targets=test:eslint,test:unit,tes...✅ Succeeded10m 40sView ↗
nx run-many --target=build --exclude=examples/*...✅ Succeeded2m 20sView ↗
☁️ Nx Cloud last updated this comment at 2026-08-11 16:40:45 UTC
@github-actions
github-actionsBot
commented
Aug 11, 2026

Copy link


Copy Markdown

Contributor
🚀 Changeset Version Preview
4 package(s) bumped directly, 19 bumped as dependents.
🟩 Patch bumps
PackageVersionReason
@tanstack/react-router1.170.25 → 1.170.26Changeset
@tanstack/router-core1.171.21 → 1.171.22Changeset
@tanstack/solid-router1.170.24 → 1.170.25Changeset
@tanstack/vue-router1.170.23 → 1.170.24Changeset
@tanstack/react-start1.168.42 → 1.168.43Dependent
@tanstack/react-start-client1.168.23 → 1.168.24Dependent
@tanstack/react-start-rsc0.1.41 → 0.1.42Dependent
@tanstack/react-start-server1.167.30 → 1.167.31Dependent
@tanstack/router-cli1.167.27 → 1.167.28Dependent
@tanstack/router-generator1.167.27 → 1.167.28Dependent
@tanstack/router-plugin1.168.29 → 1.168.30Dependent
@tanstack/router-vite-plugin1.167.29 → 1.167.30Dependent
@tanstack/solid-start1.168.41 → 1.168.42Dependent
@tanstack/solid-start-client1.168.23 → 1.168.24Dependent
@tanstack/solid-start-server1.167.30 → 1.167.31Dependent
@tanstack/start-client-core1.170.21 → 1.170.22Dependent
@tanstack/start-plugin-core1.171.33 → 1.171.34Dependent
@tanstack/start-server-core1.169.25 → 1.169.26Dependent
@tanstack/start-static-server-functions1.167.26 → 1.167.27Dependent
@tanstack/start-storage-context1.167.23 → 1.167.24Dependent
@tanstack/vue-start1.168.40 → 1.168.41Dependent
@tanstack/vue-start-client1.167.26 → 1.167.27Dependent
@tanstack/vue-start-server1.167.30 → 1.167.31Dependent
@coderabbitai
coderabbitaiBot
commented
Aug 11, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Review Change Stack
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 8b3158c2-9ac7-40c4-8c18-18a1f866cd41
📥 Commits
Reviewing files that changed from the base of the PR and between 7e93431 and 143b1c5.
📒 Files selected for processing (5)
  • .changeset/remove-link-transition-state.md
  • packages/react-router/src/link.tsx
  • packages/solid-router/src/link.tsx
  • packages/vue-router/src/link.tsx
  • packages/vue-router/tests/link.test.tsx
💤 Files with no reviewable changes (1)
  • packages/vue-router/tests/link.test.tsx
📝 Walkthrough
Walkthrough
The React, Solid, and Vue Link implementations no longer track or expose isTransitioning or data-transitioning. Their child callback state now contains only isActive. The Vue test for the removed behavior was deleted, and a patch changeset documents the change.
Changes
Link transition state removal
Layer / File(s)Summary
React Link state removal
packages/react-router/src/link.tsx, .changeset/remove-link-transition-state.md		React navigation no longer updates transition state. Link props and function children no longer expose transition data.
Solid Link state removal
packages/solid-router/src/link.tsx		Solid navigation no longer subscribes to resolution state. Transition attributes and callback state were removed.
Vue Link state removal and validation
packages/vue-router/src/link.tsx, packages/vue-router/tests/link.test.tsx		Vue Link results, navigation handling, computed props, attributes, and slots no longer include transition state. The related pending-navigation test was removed.
Estimated code review effort: 3 (Moderate) | ~20 minutes
Possibly related PRs
  • TanStack/router#7952: Both changes modify React Router’s useLinkProps, but this PR removes transition state while that PR addresses render bailout optimization.
🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 warning)
Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 40.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly and concisely identifies the main change: removing Link transition state.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  •  Create stacked PR
  •  Commit on current branch
🧪 Generate unit tests (beta)
  •  Create PR with unit tests
  •  Commit unit tests in branch remove-link-is-transitioning
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands.
@github-actions
github-actionsBot
commented
Aug 11, 2026

Copy link


Copy Markdown

Contributor
Bundle Size Benchmarks
  • Commit: 64ec8e03761f
  • Measured at: 2026-08-11T16:30:18.352Z
  • Baseline source: history:7e93431ae9ff
  • Dashboard: bundle-size history
The following scenarios have bundle-size changes compared with the baseline:
ScenarioCurrent (gzip)Delta vs baselineInitial gzipRawBrotliTrend
react-router.minimal83.84 KiB-83 B (-0.10%)83.70 KiB262.51 KiB72.91 KiB██▁▁▁▁▁▁▁▁▁▁
react-router.full87.35 KiB-77 B (-0.09%)87.21 KiB274.22 KiB76.04 KiB██▁▁▁▁▁▁▁▁▁▁
solid-router.minimal33.17 KiB-73 B (-0.21%)33.04 KiB96.31 KiB29.90 KiB██▁▁▁▁▁▁▁▁▁▁
solid-router.full38.00 KiB-70 B (-0.18%)37.88 KiB110.95 KiB34.20 KiB██▁▁▁▁▁▁▁▁▁▁
vue-router.minimal49.46 KiB-60 B (-0.12%)49.34 KiB138.03 KiB44.64 KiB██▁▁▁▁▁▁▁▁▁▁
vue-router.full55.04 KiB-57 B (-0.10%)54.92 KiB156.21 KiB49.56 KiB██▁▁▁▁▁▁▁▁▁▁
react-start.minimal96.66 KiB-93 B (-0.09%)96.52 KiB304.72 KiB83.79 KiB██▁▁▁▁▁▁▁▁▁▁
react-start.deferred-hydration97.38 KiB-95 B (-0.10%)96.54 KiB306.07 KiB84.38 KiB██▁▁▁▁▁▁▁▁▁▁
react-start.full99.84 KiB-81 B (-0.08%)99.70 KiB314.44 KiB86.44 KiB██▁▁▁▁▁▁▁▁▁▁
react-start.rsbuild.minimal99.98 KiB-84 B (-0.08%)99.81 KiB315.25 KiB86.24 KiB▂▂▂▂▆██████▁
react-start.rsbuild.minimal-iife100.39 KiB-84 B (-0.08%)100.22 KiB316.19 KiB86.60 KiB▂▂▂▂▆██████▁
react-start.rsbuild.full103.31 KiB-82 B (-0.08%)103.14 KiB325.35 KiB88.91 KiB▁▁▁▁▅██████▁
solid-start.minimal45.94 KiB-74 B (-0.16%)45.81 KiB137.37 KiB40.87 KiB██▁▁▁▁▁▁▁▁▁▁
solid-start.deferred-hydration49.00 KiB-80 B (-0.16%)45.87 KiB144.83 KiB43.72 KiB██▁▁▁▁▁▁▁▁▁▁
solid-start.full51.03 KiB-61 B (-0.12%)50.90 KiB152.76 KiB45.22 KiB██▁▁▁▁▁▁▁▁▁▁
vue-start.minimal65.48 KiB-64 B (-0.10%)65.35 KiB188.86 KiB58.33 KiB██▁▁▁▁▁▁▁▁▁▁
vue-start.full69.30 KiB-60 B (-0.08%)69.18 KiB201.13 KiB61.58 KiB██▁▁▁▁▁▁▁▁▁▁
Current gzip tracks all emitted client JS chunks. Initial gzip tracks only the entry/import graph. Trend sparkline is historical current gzip ending with this PR measurement; lower is better.
@pkg-pr-new
pkg-pr-newBot
commented
Aug 11, 2026

Copy link


Copy Markdown

More templates
@tanstack/arktype-adapter
npm i https://pkg.pr.new/@tanstack/arktype-adapter@8043

@tanstack/eslint-plugin-router
npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@8043

@tanstack/eslint-plugin-start
npm i https://pkg.pr.new/@tanstack/eslint-plugin-start@8043

@tanstack/history
npm i https://pkg.pr.new/@tanstack/history@8043

@tanstack/nitro-v2-vite-plugin
npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@8043

@tanstack/react-router
npm i https://pkg.pr.new/@tanstack/react-router@8043

@tanstack/react-router-devtools
npm i https://pkg.pr.new/@tanstack/react-router-devtools@8043

@tanstack/react-router-ssr-query
npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@8043

@tanstack/react-start
npm i https://pkg.pr.new/@tanstack/react-start@8043

@tanstack/react-start-client
npm i https://pkg.pr.new/@tanstack/react-start-client@8043

@tanstack/react-start-rsc
npm i https://pkg.pr.new/@tanstack/react-start-rsc@8043

@tanstack/react-start-server
npm i https://pkg.pr.new/@tanstack/react-start-server@8043

@tanstack/router-cli
npm i https://pkg.pr.new/@tanstack/router-cli@8043

@tanstack/router-core
npm i https://pkg.pr.new/@tanstack/router-core@8043

@tanstack/router-devtools
npm i https://pkg.pr.new/@tanstack/router-devtools@8043

@tanstack/router-devtools-core
npm i https://pkg.pr.new/@tanstack/router-devtools-core@8043

@tanstack/router-generator
npm i https://pkg.pr.new/@tanstack/router-generator@8043

@tanstack/router-plugin
npm i https://pkg.pr.new/@tanstack/router-plugin@8043

@tanstack/router-ssr-query-core
npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@8043

@tanstack/router-utils
npm i https://pkg.pr.new/@tanstack/router-utils@8043

@tanstack/router-vite-plugin
npm i https://pkg.pr.new/@tanstack/router-vite-plugin@8043

@tanstack/solid-router
npm i https://pkg.pr.new/@tanstack/solid-router@8043

@tanstack/solid-router-devtools
npm i https://pkg.pr.new/@tanstack/solid-router-devtools@8043

@tanstack/solid-router-ssr-query
npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@8043

@tanstack/solid-start
npm i https://pkg.pr.new/@tanstack/solid-start@8043

@tanstack/solid-start-client
npm i https://pkg.pr.new/@tanstack/solid-start-client@8043

@tanstack/solid-start-server
npm i https://pkg.pr.new/@tanstack/solid-start-server@8043

@tanstack/start-client-core
npm i https://pkg.pr.new/@tanstack/start-client-core@8043

@tanstack/start-fn-stubs
npm i https://pkg.pr.new/@tanstack/start-fn-stubs@8043

@tanstack/start-plugin-core
npm i https://pkg.pr.new/@tanstack/start-plugin-core@8043

@tanstack/start-server-core
npm i https://pkg.pr.new/@tanstack/start-server-core@8043

@tanstack/start-static-server-functions
npm i https://pkg.pr.new/@tanstack/start-static-server-functions@8043

@tanstack/start-storage-context
npm i https://pkg.pr.new/@tanstack/start-storage-context@8043

@tanstack/valibot-adapter
npm i https://pkg.pr.new/@tanstack/valibot-adapter@8043

@tanstack/virtual-file-routes
npm i https://pkg.pr.new/@tanstack/virtual-file-routes@8043

@tanstack/vue-router
npm i https://pkg.pr.new/@tanstack/vue-router@8043

@tanstack/vue-router-devtools
npm i https://pkg.pr.new/@tanstack/vue-router-devtools@8043

@tanstack/vue-router-ssr-query
npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@8043

@tanstack/vue-start
npm i https://pkg.pr.new/@tanstack/vue-start@8043

@tanstack/vue-start-client
npm i https://pkg.pr.new/@tanstack/vue-start-client@8043

@tanstack/vue-start-server
npm i https://pkg.pr.new/@tanstack/vue-start-server@8043

@tanstack/zod-adapter
npm i https://pkg.pr.new/@tanstack/zod-adapter@8043

commit: 143b1c5
@codspeed-hq
codspeed-hqBot
commented
Aug 11, 2026•

edited

Loading

Copy link


Copy Markdown

Merging this PR will regress 0 benchmarks
⚠️Different runtime environments detected
Some benchmarks with significant performance changes were compared across different runtime environments,

which may affect the accuracy of the results.
Open the report in CodSpeed to investigate
⚡ 25 improved benchmarks
❌ 7 (👁 7) regressed benchmarks
✅ 148 untouched benchmarks
Performance Changes
ModeBenchmarkBASEHEADEfficiency
⚡Simulationclient-async-pipeline navigation loop (react)138.9 ms104.4 ms+32.98%
⚡Simulationclient-async-pipeline navigation loop (solid)200 ms176.5 ms+13.31%
⚡Memorymem server error-paths not-found (vue)777.5 KB688.9 KB+12.85%
⚡Simulationclient-route-tree-scale navigation loop (solid)375.4 ms334.7 ms+12.15%
⚡Simulationclient-rewrites navigation loop (solid)236.2 ms213 ms+10.91%
⚡Simulationclient-loaders navigation loop (solid)230.1 ms208.6 ms+10.26%
⚡Simulationclient-route-tree-scale navigation loop (react)189.1 ms172.7 ms+9.47%
⚡Simulationclient-rewrites navigation loop (react)155.1 ms142.3 ms+9.04%
⚡Simulationclient-control-flow navigation loop (solid)178.9 ms164.1 ms+8.98%
⚡Simulationclient-side navigation loop (react)138.1 ms126.9 ms+8.8%
⚡Simulationclient-links navigation loop (react)319.3 ms296.7 ms+7.61%
⚡Simulationclient-search-params navigation loop (solid)298.2 ms278.5 ms+7.07%
⚡Simulationclient-history navigation loop (solid)173 ms163.2 ms+6.01%
⚡Memorymem server error-paths unmatched (solid)592.5 KB560.5 KB+5.7%
⚡Simulationclient-history navigation loop (react)133.6 ms126.8 ms+5.36%
⚡Simulationclient-control-flow navigation loop (react)180.5 ms171.4 ms+5.27%
⚡Simulationclient-loaders navigation loop (react)136.3 ms129.5 ms+5.24%
⚡Memorymem server error-paths redirect (solid)379.9 KB361.2 KB+5.18%
⚡Memorymem server serialization-payload (vue)4.5 MB4.3 MB+4.94%
⚡Memorymem server aborted-requests (react)905.7 KB864.6 KB+4.75%
..................

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.
Tip
Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.
Comparing remove-link-is-transitioning (143b1c5) with main (7e93431)
Open in CodSpeed
@Sheraff
Sheraff
merged commit 1aafca9
into
mainAug 12, 2026

26 checks passed

@Sheraff
Sheraff
deleted the

remove-link-is-transitioning

branch
August 12, 2026 07:52
@github-actionsgithub-actionsBot
mentioned this pull request
Aug 12, 2026
 Merged

@brenelzbrenelz
mentioned this pull request
Aug 13, 2026
 Merged

@brandhaugbrandhaug
mentioned this pull request
Aug 13, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

package: react-routerpackage: solid-routerpackage: vue-router

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@Sheraff

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
refactor: remove Link transition state - #8043
Merged
Sheraff merged 1 commit into
mainfrom 
remove-link-is-transitioning
Aug 12, 2026
Merged
refactor: remove Link transition state#8043
Sheraff merged 1 commit into
mainfrom 
remove-link-is-transitioning
Conversation
@Sheraff
@SheraffSheraff
commented
Aug 11, 2026•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Collaborator
Summary
  • remove the undocumented per-Link isTransitioning state from the React, Solid, and Vue adapters
  • stop emitting data-transitioning and remove isTransitioning from Link render-prop/slot types and values
  • remove the obsolete Vue regression test and add patch changesets for all three router packages
Compatibility
isTransitioning and data-transitioning were undocumented, but the attribute was observable and Solid/Vue exposed the state at runtime. React advertised the field in its type without passing it at runtime. Please confirm that removing this accidental API is acceptable before merge.
Testing
  • CI=1 NX_DAEMON=false pnpm nx run-many --target=test:unit --projects=@tanstack/react-router,@tanstack/solid-router,@tanstack/vue-router --outputStyle=stream --skipRemoteCache
  • CI=1 NX_DAEMON=false pnpm nx run-many --target=test:types --projects=@tanstack/react-router,@tanstack/solid-router,@tanstack/vue-router --outputStyle=stream --skipRemoteCache
  • CI=1 NX_DAEMON=false pnpm nx run-many --target=test:eslint --projects=@tanstack/react-router,@tanstack/solid-router,@tanstack/vue-router --outputStyle=stream --skipRemoteCache
  • pnpm exec changeset status --since=main
Summary by CodeRabbit
  • Breaking Changes
    • Removed the undocumented isTransitioning state from React, Solid, and Vue router links.
    • Removed the data-transitioning attribute from rendered links.
    • Link child callbacks and Vue slots now receive only isActive.
@nx-cloud
nx-cloudBot
commented
Aug 11, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
View your CI Pipeline Execution ↗ for commit 143b1c5
CommandStatusDurationResult
nx affected --targets=test:eslint,test:unit,tes...✅ Succeeded10m 40sView ↗
nx run-many --target=build --exclude=examples/*...✅ Succeeded2m 20sView ↗
☁️ Nx Cloud last updated this comment at 2026-08-11 16:40:45 UTC
@github-actions
github-actionsBot
commented
Aug 11, 2026

Copy link


Copy Markdown

Contributor
🚀 Changeset Version Preview
4 package(s) bumped directly, 19 bumped as dependents.
🟩 Patch bumps
PackageVersionReason
@tanstack/react-router1.170.25 → 1.170.26Changeset
@tanstack/router-core1.171.21 → 1.171.22Changeset
@tanstack/solid-router1.170.24 → 1.170.25Changeset
@tanstack/vue-router1.170.23 → 1.170.24Changeset
@tanstack/react-start1.168.42 → 1.168.43Dependent
@tanstack/react-start-client1.168.23 → 1.168.24Dependent
@tanstack/react-start-rsc0.1.41 → 0.1.42Dependent
@tanstack/react-start-server1.167.30 → 1.167.31Dependent
@tanstack/router-cli1.167.27 → 1.167.28Dependent
@tanstack/router-generator1.167.27 → 1.167.28Dependent
@tanstack/router-plugin1.168.29 → 1.168.30Dependent
@tanstack/router-vite-plugin1.167.29 → 1.167.30Dependent
@tanstack/solid-start1.168.41 → 1.168.42Dependent
@tanstack/solid-start-client1.168.23 → 1.168.24Dependent
@tanstack/solid-start-server1.167.30 → 1.167.31Dependent
@tanstack/start-client-core1.170.21 → 1.170.22Dependent
@tanstack/start-plugin-core1.171.33 → 1.171.34Dependent
@tanstack/start-server-core1.169.25 → 1.169.26Dependent
@tanstack/start-static-server-functions1.167.26 → 1.167.27Dependent
@tanstack/start-storage-context1.167.23 → 1.167.24Dependent
@tanstack/vue-start1.168.40 → 1.168.41Dependent
@tanstack/vue-start-client1.167.26 → 1.167.27Dependent
@tanstack/vue-start-server1.167.30 → 1.167.31Dependent
@coderabbitai
coderabbitaiBot
commented
Aug 11, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Review Change Stack
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 8b3158c2-9ac7-40c4-8c18-18a1f866cd41
📥 Commits
Reviewing files that changed from the base of the PR and between 7e93431 and 143b1c5.
📒 Files selected for processing (5)
  • .changeset/remove-link-transition-state.md
  • packages/react-router/src/link.tsx
  • packages/solid-router/src/link.tsx
  • packages/vue-router/src/link.tsx
  • packages/vue-router/tests/link.test.tsx
💤 Files with no reviewable changes (1)
  • packages/vue-router/tests/link.test.tsx
📝 Walkthrough
Walkthrough
The React, Solid, and Vue Link implementations no longer track or expose isTransitioning or data-transitioning. Their child callback state now contains only isActive. The Vue test for the removed behavior was deleted, and a patch changeset documents the change.
Changes
Link transition state removal
Layer / File(s)Summary
React Link state removal
packages/react-router/src/link.tsx, .changeset/remove-link-transition-state.md		React navigation no longer updates transition state. Link props and function children no longer expose transition data.
Solid Link state removal
packages/solid-router/src/link.tsx		Solid navigation no longer subscribes to resolution state. Transition attributes and callback state were removed.
Vue Link state removal and validation
packages/vue-router/src/link.tsx, packages/vue-router/tests/link.test.tsx		Vue Link results, navigation handling, computed props, attributes, and slots no longer include transition state. The related pending-navigation test was removed.
Estimated code review effort: 3 (Moderate) | ~20 minutes
Possibly related PRs
  • TanStack/router#7952: Both changes modify React Router’s useLinkProps, but this PR removes transition state while that PR addresses render bailout optimization.
🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 warning)
Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 40.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly and concisely identifies the main change: removing Link transition state.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  •  Create stacked PR
  •  Commit on current branch
🧪 Generate unit tests (beta)
  •  Create PR with unit tests
  •  Commit unit tests in branch remove-link-is-transitioning
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands.
@github-actions
github-actionsBot
commented
Aug 11, 2026

Copy link


Copy Markdown

Contributor
Bundle Size Benchmarks
  • Commit: 64ec8e03761f
  • Measured at: 2026-08-11T16:30:18.352Z
  • Baseline source: history:7e93431ae9ff
  • Dashboard: bundle-size history
The following scenarios have bundle-size changes compared with the baseline:
ScenarioCurrent (gzip)Delta vs baselineInitial gzipRawBrotliTrend
react-router.minimal83.84 KiB-83 B (-0.10%)83.70 KiB262.51 KiB72.91 KiB██▁▁▁▁▁▁▁▁▁▁
react-router.full87.35 KiB-77 B (-0.09%)87.21 KiB274.22 KiB76.04 KiB██▁▁▁▁▁▁▁▁▁▁
solid-router.minimal33.17 KiB-73 B (-0.21%)33.04 KiB96.31 KiB29.90 KiB██▁▁▁▁▁▁▁▁▁▁
solid-router.full38.00 KiB-70 B (-0.18%)37.88 KiB110.95 KiB34.20 KiB██▁▁▁▁▁▁▁▁▁▁
vue-router.minimal49.46 KiB-60 B (-0.12%)49.34 KiB138.03 KiB44.64 KiB██▁▁▁▁▁▁▁▁▁▁
vue-router.full55.04 KiB-57 B (-0.10%)54.92 KiB156.21 KiB49.56 KiB██▁▁▁▁▁▁▁▁▁▁
react-start.minimal96.66 KiB-93 B (-0.09%)96.52 KiB304.72 KiB83.79 KiB██▁▁▁▁▁▁▁▁▁▁
react-start.deferred-hydration97.38 KiB-95 B (-0.10%)96.54 KiB306.07 KiB84.38 KiB██▁▁▁▁▁▁▁▁▁▁
react-start.full99.84 KiB-81 B (-0.08%)99.70 KiB314.44 KiB86.44 KiB██▁▁▁▁▁▁▁▁▁▁
react-start.rsbuild.minimal99.98 KiB-84 B (-0.08%)99.81 KiB315.25 KiB86.24 KiB▂▂▂▂▆██████▁
react-start.rsbuild.minimal-iife100.39 KiB-84 B (-0.08%)100.22 KiB316.19 KiB86.60 KiB▂▂▂▂▆██████▁
react-start.rsbuild.full103.31 KiB-82 B (-0.08%)103.14 KiB325.35 KiB88.91 KiB▁▁▁▁▅██████▁
solid-start.minimal45.94 KiB-74 B (-0.16%)45.81 KiB137.37 KiB40.87 KiB██▁▁▁▁▁▁▁▁▁▁
solid-start.deferred-hydration49.00 KiB-80 B (-0.16%)45.87 KiB144.83 KiB43.72 KiB██▁▁▁▁▁▁▁▁▁▁
solid-start.full51.03 KiB-61 B (-0.12%)50.90 KiB152.76 KiB45.22 KiB██▁▁▁▁▁▁▁▁▁▁
vue-start.minimal65.48 KiB-64 B (-0.10%)65.35 KiB188.86 KiB58.33 KiB██▁▁▁▁▁▁▁▁▁▁
vue-start.full69.30 KiB-60 B (-0.08%)69.18 KiB201.13 KiB61.58 KiB██▁▁▁▁▁▁▁▁▁▁
Current gzip tracks all emitted client JS chunks. Initial gzip tracks only the entry/import graph. Trend sparkline is historical current gzip ending with this PR measurement; lower is better.
@pkg-pr-new
pkg-pr-newBot
commented
Aug 11, 2026

Copy link


Copy Markdown

More templates
@tanstack/arktype-adapter
npm i https://pkg.pr.new/@tanstack/arktype-adapter@8043

@tanstack/eslint-plugin-router
npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@8043

@tanstack/eslint-plugin-start
npm i https://pkg.pr.new/@tanstack/eslint-plugin-start@8043

@tanstack/history
npm i https://pkg.pr.new/@tanstack/history@8043

@tanstack/nitro-v2-vite-plugin
npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@8043

@tanstack/react-router
npm i https://pkg.pr.new/@tanstack/react-router@8043

@tanstack/react-router-devtools
npm i https://pkg.pr.new/@tanstack/react-router-devtools@8043

@tanstack/react-router-ssr-query
npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@8043

@tanstack/react-start
npm i https://pkg.pr.new/@tanstack/react-start@8043

@tanstack/react-start-client
npm i https://pkg.pr.new/@tanstack/react-start-client@8043

@tanstack/react-start-rsc
npm i https://pkg.pr.new/@tanstack/react-start-rsc@8043

@tanstack/react-start-server
npm i https://pkg.pr.new/@tanstack/react-start-server@8043

@tanstack/router-cli
npm i https://pkg.pr.new/@tanstack/router-cli@8043

@tanstack/router-core
npm i https://pkg.pr.new/@tanstack/router-core@8043

@tanstack/router-devtools
npm i https://pkg.pr.new/@tanstack/router-devtools@8043

@tanstack/router-devtools-core
npm i https://pkg.pr.new/@tanstack/router-devtools-core@8043

@tanstack/router-generator
npm i https://pkg.pr.new/@tanstack/router-generator@8043

@tanstack/router-plugin
npm i https://pkg.pr.new/@tanstack/router-plugin@8043

@tanstack/router-ssr-query-core
npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@8043

@tanstack/router-utils
npm i https://pkg.pr.new/@tanstack/router-utils@8043

@tanstack/router-vite-plugin
npm i https://pkg.pr.new/@tanstack/router-vite-plugin@8043

@tanstack/solid-router
npm i https://pkg.pr.new/@tanstack/solid-router@8043

@tanstack/solid-router-devtools
npm i https://pkg.pr.new/@tanstack/solid-router-devtools@8043

@tanstack/solid-router-ssr-query
npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@8043

@tanstack/solid-start
npm i https://pkg.pr.new/@tanstack/solid-start@8043

@tanstack/solid-start-client
npm i https://pkg.pr.new/@tanstack/solid-start-client@8043

@tanstack/solid-start-server
npm i https://pkg.pr.new/@tanstack/solid-start-server@8043

@tanstack/start-client-core
npm i https://pkg.pr.new/@tanstack/start-client-core@8043

@tanstack/start-fn-stubs
npm i https://pkg.pr.new/@tanstack/start-fn-stubs@8043

@tanstack/start-plugin-core
npm i https://pkg.pr.new/@tanstack/start-plugin-core@8043

@tanstack/start-server-core
npm i https://pkg.pr.new/@tanstack/start-server-core@8043

@tanstack/start-static-server-functions
npm i https://pkg.pr.new/@tanstack/start-static-server-functions@8043

@tanstack/start-storage-context
npm i https://pkg.pr.new/@tanstack/start-storage-context@8043

@tanstack/valibot-adapter
npm i https://pkg.pr.new/@tanstack/valibot-adapter@8043

@tanstack/virtual-file-routes
npm i https://pkg.pr.new/@tanstack/virtual-file-routes@8043

@tanstack/vue-router
npm i https://pkg.pr.new/@tanstack/vue-router@8043

@tanstack/vue-router-devtools
npm i https://pkg.pr.new/@tanstack/vue-router-devtools@8043

@tanstack/vue-router-ssr-query
npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@8043

@tanstack/vue-start
npm i https://pkg.pr.new/@tanstack/vue-start@8043

@tanstack/vue-start-client
npm i https://pkg.pr.new/@tanstack/vue-start-client@8043

@tanstack/vue-start-server
npm i https://pkg.pr.new/@tanstack/vue-start-server@8043

@tanstack/zod-adapter
npm i https://pkg.pr.new/@tanstack/zod-adapter@8043

commit: 143b1c5
@codspeed-hq
codspeed-hqBot
commented
Aug 11, 2026•

edited

Loading

Copy link


Copy Markdown

Merging this PR will regress 0 benchmarks
⚠️Different runtime environments detected
Some benchmarks with significant performance changes were compared across different runtime environments,

which may affect the accuracy of the results.
Open the report in CodSpeed to investigate
⚡ 25 improved benchmarks
❌ 7 (👁 7) regressed benchmarks
✅ 148 untouched benchmarks
Performance Changes
ModeBenchmarkBASEHEADEfficiency
⚡Simulationclient-async-pipeline navigation loop (react)138.9 ms104.4 ms+32.98%
⚡Simulationclient-async-pipeline navigation loop (solid)200 ms176.5 ms+13.31%
⚡Memorymem server error-paths not-found (vue)777.5 KB688.9 KB+12.85%
⚡Simulationclient-route-tree-scale navigation loop (solid)375.4 ms334.7 ms+12.15%
⚡Simulationclient-rewrites navigation loop (solid)236.2 ms213 ms+10.91%
⚡Simulationclient-loaders navigation loop (solid)230.1 ms208.6 ms+10.26%
⚡Simulationclient-route-tree-scale navigation loop (react)189.1 ms172.7 ms+9.47%
⚡Simulationclient-rewrites navigation loop (react)155.1 ms142.3 ms+9.04%
⚡Simulationclient-control-flow navigation loop (solid)178.9 ms164.1 ms+8.98%
⚡Simulationclient-side navigation loop (react)138.1 ms126.9 ms+8.8%
⚡Simulationclient-links navigation loop (react)319.3 ms296.7 ms+7.61%
⚡Simulationclient-search-params navigation loop (solid)298.2 ms278.5 ms+7.07%
⚡Simulationclient-history navigation loop (solid)173 ms163.2 ms+6.01%
⚡Memorymem server error-paths unmatched (solid)592.5 KB560.5 KB+5.7%
⚡Simulationclient-history navigation loop (react)133.6 ms126.8 ms+5.36%
⚡Simulationclient-control-flow navigation loop (react)180.5 ms171.4 ms+5.27%
⚡Simulationclient-loaders navigation loop (react)136.3 ms129.5 ms+5.24%
⚡Memorymem server error-paths redirect (solid)379.9 KB361.2 KB+5.18%
⚡Memorymem server serialization-payload (vue)4.5 MB4.3 MB+4.94%
⚡Memorymem server aborted-requests (react)905.7 KB864.6 KB+4.75%
..................

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.
Tip
Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.
Comparing remove-link-is-transitioning (143b1c5) with main (7e93431)
Open in CodSpeed
@Sheraff
Sheraff
merged commit 1aafca9
into
mainAug 12, 2026

26 checks passed

@Sheraff
Sheraff
deleted the

remove-link-is-transitioning

branch
August 12, 2026 07:52
@github-actionsgithub-actionsBot
mentioned this pull request
Aug 12, 2026
 Merged

@brenelzbrenelz
mentioned this pull request
Aug 13, 2026
 Merged

@brandhaugbrandhaug
mentioned this pull request
Aug 13, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

package: react-routerpackage: solid-routerpackage: vue-router

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@Sheraff

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
refactor: remove Link transition state - #8043
Merged
Sheraff merged 1 commit into
mainfrom 
remove-link-is-transitioning
Aug 12, 2026
Merged
refactor: remove Link transition state#8043
Sheraff merged 1 commit into
mainfrom 
remove-link-is-transitioning
Conversation
@Sheraff
@SheraffSheraff
commented
Aug 11, 2026•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Collaborator
Summary
  • remove the undocumented per-Link isTransitioning state from the React, Solid, and Vue adapters
  • stop emitting data-transitioning and remove isTransitioning from Link render-prop/slot types and values
  • remove the obsolete Vue regression test and add patch changesets for all three router packages
Compatibility
isTransitioning and data-transitioning were undocumented, but the attribute was observable and Solid/Vue exposed the state at runtime. React advertised the field in its type without passing it at runtime. Please confirm that removing this accidental API is acceptable before merge.
Testing
  • CI=1 NX_DAEMON=false pnpm nx run-many --target=test:unit --projects=@tanstack/react-router,@tanstack/solid-router,@tanstack/vue-router --outputStyle=stream --skipRemoteCache
  • CI=1 NX_DAEMON=false pnpm nx run-many --target=test:types --projects=@tanstack/react-router,@tanstack/solid-router,@tanstack/vue-router --outputStyle=stream --skipRemoteCache
  • CI=1 NX_DAEMON=false pnpm nx run-many --target=test:eslint --projects=@tanstack/react-router,@tanstack/solid-router,@tanstack/vue-router --outputStyle=stream --skipRemoteCache
  • pnpm exec changeset status --since=main
Summary by CodeRabbit
  • Breaking Changes
    • Removed the undocumented isTransitioning state from React, Solid, and Vue router links.
    • Removed the data-transitioning attribute from rendered links.
    • Link child callbacks and Vue slots now receive only isActive.
@nx-cloud
nx-cloudBot
commented
Aug 11, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
View your CI Pipeline Execution ↗ for commit 143b1c5
CommandStatusDurationResult
nx affected --targets=test:eslint,test:unit,tes...✅ Succeeded10m 40sView ↗
nx run-many --target=build --exclude=examples/*...✅ Succeeded2m 20sView ↗
☁️ Nx Cloud last updated this comment at 2026-08-11 16:40:45 UTC
@github-actions
github-actionsBot
commented
Aug 11, 2026

Copy link


Copy Markdown

Contributor
🚀 Changeset Version Preview
4 package(s) bumped directly, 19 bumped as dependents.
🟩 Patch bumps
PackageVersionReason
@tanstack/react-router1.170.25 → 1.170.26Changeset
@tanstack/router-core1.171.21 → 1.171.22Changeset
@tanstack/solid-router1.170.24 → 1.170.25Changeset
@tanstack/vue-router1.170.23 → 1.170.24Changeset
@tanstack/react-start1.168.42 → 1.168.43Dependent
@tanstack/react-start-client1.168.23 → 1.168.24Dependent
@tanstack/react-start-rsc0.1.41 → 0.1.42Dependent
@tanstack/react-start-server1.167.30 → 1.167.31Dependent
@tanstack/router-cli1.167.27 → 1.167.28Dependent
@tanstack/router-generator1.167.27 → 1.167.28Dependent
@tanstack/router-plugin1.168.29 → 1.168.30Dependent
@tanstack/router-vite-plugin1.167.29 → 1.167.30Dependent
@tanstack/solid-start1.168.41 → 1.168.42Dependent
@tanstack/solid-start-client1.168.23 → 1.168.24Dependent
@tanstack/solid-start-server1.167.30 → 1.167.31Dependent
@tanstack/start-client-core1.170.21 → 1.170.22Dependent
@tanstack/start-plugin-core1.171.33 → 1.171.34Dependent
@tanstack/start-server-core1.169.25 → 1.169.26Dependent
@tanstack/start-static-server-functions1.167.26 → 1.167.27Dependent
@tanstack/start-storage-context1.167.23 → 1.167.24Dependent
@tanstack/vue-start1.168.40 → 1.168.41Dependent
@tanstack/vue-start-client1.167.26 → 1.167.27Dependent
@tanstack/vue-start-server1.167.30 → 1.167.31Dependent
@coderabbitai
coderabbitaiBot
commented
Aug 11, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Review Change Stack
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 8b3158c2-9ac7-40c4-8c18-18a1f866cd41
📥 Commits
Reviewing files that changed from the base of the PR and between 7e93431 and 143b1c5.
📒 Files selected for processing (5)
  • .changeset/remove-link-transition-state.md
  • packages/react-router/src/link.tsx
  • packages/solid-router/src/link.tsx
  • packages/vue-router/src/link.tsx
  • packages/vue-router/tests/link.test.tsx
💤 Files with no reviewable changes (1)
  • packages/vue-router/tests/link.test.tsx
📝 Walkthrough
Walkthrough
The React, Solid, and Vue Link implementations no longer track or expose isTransitioning or data-transitioning. Their child callback state now contains only isActive. The Vue test for the removed behavior was deleted, and a patch changeset documents the change.
Changes
Link transition state removal
Layer / File(s)Summary
React Link state removal
packages/react-router/src/link.tsx, .changeset/remove-link-transition-state.md		React navigation no longer updates transition state. Link props and function children no longer expose transition data.
Solid Link state removal
packages/solid-router/src/link.tsx		Solid navigation no longer subscribes to resolution state. Transition attributes and callback state were removed.
Vue Link state removal and validation
packages/vue-router/src/link.tsx, packages/vue-router/tests/link.test.tsx		Vue Link results, navigation handling, computed props, attributes, and slots no longer include transition state. The related pending-navigation test was removed.
Estimated code review effort: 3 (Moderate) | ~20 minutes
Possibly related PRs
  • TanStack/router#7952: Both changes modify React Router’s useLinkProps, but this PR removes transition state while that PR addresses render bailout optimization.
🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 warning)
Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 40.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly and concisely identifies the main change: removing Link transition state.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  •  Create stacked PR
  •  Commit on current branch
🧪 Generate unit tests (beta)
  •  Create PR with unit tests
  •  Commit unit tests in branch remove-link-is-transitioning
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands.
@github-actions
github-actionsBot
commented
Aug 11, 2026

Copy link


Copy Markdown

Contributor
Bundle Size Benchmarks
  • Commit: 64ec8e03761f
  • Measured at: 2026-08-11T16:30:18.352Z
  • Baseline source: history:7e93431ae9ff
  • Dashboard: bundle-size history
The following scenarios have bundle-size changes compared with the baseline:
ScenarioCurrent (gzip)Delta vs baselineInitial gzipRawBrotliTrend
react-router.minimal83.84 KiB-83 B (-0.10%)83.70 KiB262.51 KiB72.91 KiB██▁▁▁▁▁▁▁▁▁▁
react-router.full87.35 KiB-77 B (-0.09%)87.21 KiB274.22 KiB76.04 KiB██▁▁▁▁▁▁▁▁▁▁
solid-router.minimal33.17 KiB-73 B (-0.21%)33.04 KiB96.31 KiB29.90 KiB██▁▁▁▁▁▁▁▁▁▁
solid-router.full38.00 KiB-70 B (-0.18%)37.88 KiB110.95 KiB34.20 KiB██▁▁▁▁▁▁▁▁▁▁
vue-router.minimal49.46 KiB-60 B (-0.12%)49.34 KiB138.03 KiB44.64 KiB██▁▁▁▁▁▁▁▁▁▁
vue-router.full55.04 KiB-57 B (-0.10%)54.92 KiB156.21 KiB49.56 KiB██▁▁▁▁▁▁▁▁▁▁
react-start.minimal96.66 KiB-93 B (-0.09%)96.52 KiB304.72 KiB83.79 KiB██▁▁▁▁▁▁▁▁▁▁
react-start.deferred-hydration97.38 KiB-95 B (-0.10%)96.54 KiB306.07 KiB84.38 KiB██▁▁▁▁▁▁▁▁▁▁
react-start.full99.84 KiB-81 B (-0.08%)99.70 KiB314.44 KiB86.44 KiB██▁▁▁▁▁▁▁▁▁▁
react-start.rsbuild.minimal99.98 KiB-84 B (-0.08%)99.81 KiB315.25 KiB86.24 KiB▂▂▂▂▆██████▁
react-start.rsbuild.minimal-iife100.39 KiB-84 B (-0.08%)100.22 KiB316.19 KiB86.60 KiB▂▂▂▂▆██████▁
react-start.rsbuild.full103.31 KiB-82 B (-0.08%)103.14 KiB325.35 KiB88.91 KiB▁▁▁▁▅██████▁
solid-start.minimal45.94 KiB-74 B (-0.16%)45.81 KiB137.37 KiB40.87 KiB██▁▁▁▁▁▁▁▁▁▁
solid-start.deferred-hydration49.00 KiB-80 B (-0.16%)45.87 KiB144.83 KiB43.72 KiB██▁▁▁▁▁▁▁▁▁▁
solid-start.full51.03 KiB-61 B (-0.12%)50.90 KiB152.76 KiB45.22 KiB██▁▁▁▁▁▁▁▁▁▁
vue-start.minimal65.48 KiB-64 B (-0.10%)65.35 KiB188.86 KiB58.33 KiB██▁▁▁▁▁▁▁▁▁▁
vue-start.full69.30 KiB-60 B (-0.08%)69.18 KiB201.13 KiB61.58 KiB██▁▁▁▁▁▁▁▁▁▁
Current gzip tracks all emitted client JS chunks. Initial gzip tracks only the entry/import graph. Trend sparkline is historical current gzip ending with this PR measurement; lower is better.
@pkg-pr-new
pkg-pr-newBot
commented
Aug 11, 2026

Copy link


Copy Markdown

More templates
@tanstack/arktype-adapter
npm i https://pkg.pr.new/@tanstack/arktype-adapter@8043

@tanstack/eslint-plugin-router
npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@8043

@tanstack/eslint-plugin-start
npm i https://pkg.pr.new/@tanstack/eslint-plugin-start@8043

@tanstack/history
npm i https://pkg.pr.new/@tanstack/history@8043

@tanstack/nitro-v2-vite-plugin
npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@8043

@tanstack/react-router
npm i https://pkg.pr.new/@tanstack/react-router@8043

@tanstack/react-router-devtools
npm i https://pkg.pr.new/@tanstack/react-router-devtools@8043

@tanstack/react-router-ssr-query
npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@8043

@tanstack/react-start
npm i https://pkg.pr.new/@tanstack/react-start@8043

@tanstack/react-start-client
npm i https://pkg.pr.new/@tanstack/react-start-client@8043

@tanstack/react-start-rsc
npm i https://pkg.pr.new/@tanstack/react-start-rsc@8043

@tanstack/react-start-server
npm i https://pkg.pr.new/@tanstack/react-start-server@8043

@tanstack/router-cli
npm i https://pkg.pr.new/@tanstack/router-cli@8043

@tanstack/router-core
npm i https://pkg.pr.new/@tanstack/router-core@8043

@tanstack/router-devtools
npm i https://pkg.pr.new/@tanstack/router-devtools@8043

@tanstack/router-devtools-core
npm i https://pkg.pr.new/@tanstack/router-devtools-core@8043

@tanstack/router-generator
npm i https://pkg.pr.new/@tanstack/router-generator@8043

@tanstack/router-plugin
npm i https://pkg.pr.new/@tanstack/router-plugin@8043

@tanstack/router-ssr-query-core
npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@8043

@tanstack/router-utils
npm i https://pkg.pr.new/@tanstack/router-utils@8043

@tanstack/router-vite-plugin
npm i https://pkg.pr.new/@tanstack/router-vite-plugin@8043

@tanstack/solid-router
npm i https://pkg.pr.new/@tanstack/solid-router@8043

@tanstack/solid-router-devtools
npm i https://pkg.pr.new/@tanstack/solid-router-devtools@8043

@tanstack/solid-router-ssr-query
npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@8043

@tanstack/solid-start
npm i https://pkg.pr.new/@tanstack/solid-start@8043

@tanstack/solid-start-client
npm i https://pkg.pr.new/@tanstack/solid-start-client@8043

@tanstack/solid-start-server
npm i https://pkg.pr.new/@tanstack/solid-start-server@8043

@tanstack/start-client-core
npm i https://pkg.pr.new/@tanstack/start-client-core@8043

@tanstack/start-fn-stubs
npm i https://pkg.pr.new/@tanstack/start-fn-stubs@8043

@tanstack/start-plugin-core
npm i https://pkg.pr.new/@tanstack/start-plugin-core@8043

@tanstack/start-server-core
npm i https://pkg.pr.new/@tanstack/start-server-core@8043

@tanstack/start-static-server-functions
npm i https://pkg.pr.new/@tanstack/start-static-server-functions@8043

@tanstack/start-storage-context
npm i https://pkg.pr.new/@tanstack/start-storage-context@8043

@tanstack/valibot-adapter
npm i https://pkg.pr.new/@tanstack/valibot-adapter@8043

@tanstack/virtual-file-routes
npm i https://pkg.pr.new/@tanstack/virtual-file-routes@8043

@tanstack/vue-router
npm i https://pkg.pr.new/@tanstack/vue-router@8043

@tanstack/vue-router-devtools
npm i https://pkg.pr.new/@tanstack/vue-router-devtools@8043

@tanstack/vue-router-ssr-query
npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@8043

@tanstack/vue-start
npm i https://pkg.pr.new/@tanstack/vue-start@8043

@tanstack/vue-start-client
npm i https://pkg.pr.new/@tanstack/vue-start-client@8043

@tanstack/vue-start-server
npm i https://pkg.pr.new/@tanstack/vue-start-server@8043

@tanstack/zod-adapter
npm i https://pkg.pr.new/@tanstack/zod-adapter@8043

commit: 143b1c5
@codspeed-hq
codspeed-hqBot
commented
Aug 11, 2026•

edited

Loading

Copy link


Copy Markdown

Merging this PR will regress 0 benchmarks
⚠️Different runtime environments detected
Some benchmarks with significant performance changes were compared across different runtime environments,

which may affect the accuracy of the results.
Open the report in CodSpeed to investigate
⚡ 25 improved benchmarks
❌ 7 (👁 7) regressed benchmarks
✅ 148 untouched benchmarks
Performance Changes
ModeBenchmarkBASEHEADEfficiency
⚡Simulationclient-async-pipeline navigation loop (react)138.9 ms104.4 ms+32.98%
⚡Simulationclient-async-pipeline navigation loop (solid)200 ms176.5 ms+13.31%
⚡Memorymem server error-paths not-found (vue)777.5 KB688.9 KB+12.85%
⚡Simulationclient-route-tree-scale navigation loop (solid)375.4 ms334.7 ms+12.15%
⚡Simulationclient-rewrites navigation loop (solid)236.2 ms213 ms+10.91%
⚡Simulationclient-loaders navigation loop (solid)230.1 ms208.6 ms+10.26%
⚡Simulationclient-route-tree-scale navigation loop (react)189.1 ms172.7 ms+9.47%
⚡Simulationclient-rewrites navigation loop (react)155.1 ms142.3 ms+9.04%
⚡Simulationclient-control-flow navigation loop (solid)178.9 ms164.1 ms+8.98%
⚡Simulationclient-side navigation loop (react)138.1 ms126.9 ms+8.8%
⚡Simulationclient-links navigation loop (react)319.3 ms296.7 ms+7.61%
⚡Simulationclient-search-params navigation loop (solid)298.2 ms278.5 ms+7.07%
⚡Simulationclient-history navigation loop (solid)173 ms163.2 ms+6.01%
⚡Memorymem server error-paths unmatched (solid)592.5 KB560.5 KB+5.7%
⚡Simulationclient-history navigation loop (react)133.6 ms126.8 ms+5.36%
⚡Simulationclient-control-flow navigation loop (react)180.5 ms171.4 ms+5.27%
⚡Simulationclient-loaders navigation loop (react)136.3 ms129.5 ms+5.24%
⚡Memorymem server error-paths redirect (solid)379.9 KB361.2 KB+5.18%
⚡Memorymem server serialization-payload (vue)4.5 MB4.3 MB+4.94%
⚡Memorymem server aborted-requests (react)905.7 KB864.6 KB+4.75%
..................

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.
Tip
Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.
Comparing remove-link-is-transitioning (143b1c5) with main (7e93431)
Open in CodSpeed
@Sheraff
Sheraff
merged commit 1aafca9
into
mainAug 12, 2026

26 checks passed

@Sheraff
Sheraff
deleted the

remove-link-is-transitioning

branch
August 12, 2026 07:52
@github-actionsgithub-actionsBot
mentioned this pull request
Aug 12, 2026
 Merged

@brenelzbrenelz
mentioned this pull request
Aug 13, 2026
 Merged

@brandhaugbrandhaug
mentioned this pull request
Aug 13, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

package: react-routerpackage: solid-routerpackage: vue-router

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@Sheraff

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
refactor: remove Link transition state - #8043
Merged
Sheraff merged 1 commit into
mainfrom 
remove-link-is-transitioning
Aug 12, 2026
Merged
refactor: remove Link transition state#8043
Sheraff merged 1 commit into
mainfrom 
remove-link-is-transitioning
Conversation
@Sheraff
@SheraffSheraff
commented
Aug 11, 2026•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Collaborator
Summary
  • remove the undocumented per-Link isTransitioning state from the React, Solid, and Vue adapters
  • stop emitting data-transitioning and remove isTransitioning from Link render-prop/slot types and values
  • remove the obsolete Vue regression test and add patch changesets for all three router packages
Compatibility
isTransitioning and data-transitioning were undocumented, but the attribute was observable and Solid/Vue exposed the state at runtime. React advertised the field in its type without passing it at runtime. Please confirm that removing this accidental API is acceptable before merge.
Testing
  • CI=1 NX_DAEMON=false pnpm nx run-many --target=test:unit --projects=@tanstack/react-router,@tanstack/solid-router,@tanstack/vue-router --outputStyle=stream --skipRemoteCache
  • CI=1 NX_DAEMON=false pnpm nx run-many --target=test:types --projects=@tanstack/react-router,@tanstack/solid-router,@tanstack/vue-router --outputStyle=stream --skipRemoteCache
  • CI=1 NX_DAEMON=false pnpm nx run-many --target=test:eslint --projects=@tanstack/react-router,@tanstack/solid-router,@tanstack/vue-router --outputStyle=stream --skipRemoteCache
  • pnpm exec changeset status --since=main
Summary by CodeRabbit
  • Breaking Changes
    • Removed the undocumented isTransitioning state from React, Solid, and Vue router links.
    • Removed the data-transitioning attribute from rendered links.
    • Link child callbacks and Vue slots now receive only isActive.
@nx-cloud
nx-cloudBot
commented
Aug 11, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
View your CI Pipeline Execution ↗ for commit 143b1c5
CommandStatusDurationResult
nx affected --targets=test:eslint,test:unit,tes...✅ Succeeded10m 40sView ↗
nx run-many --target=build --exclude=examples/*...✅ Succeeded2m 20sView ↗
☁️ Nx Cloud last updated this comment at 2026-08-11 16:40:45 UTC
@github-actions
github-actionsBot
commented
Aug 11, 2026

Copy link


Copy Markdown

Contributor
🚀 Changeset Version Preview
4 package(s) bumped directly, 19 bumped as dependents.
🟩 Patch bumps
PackageVersionReason
@tanstack/react-router1.170.25 → 1.170.26Changeset
@tanstack/router-core1.171.21 → 1.171.22Changeset
@tanstack/solid-router1.170.24 → 1.170.25Changeset
@tanstack/vue-router1.170.23 → 1.170.24Changeset
@tanstack/react-start1.168.42 → 1.168.43Dependent
@tanstack/react-start-client1.168.23 → 1.168.24Dependent
@tanstack/react-start-rsc0.1.41 → 0.1.42Dependent
@tanstack/react-start-server1.167.30 → 1.167.31Dependent
@tanstack/router-cli1.167.27 → 1.167.28Dependent
@tanstack/router-generator1.167.27 → 1.167.28Dependent
@tanstack/router-plugin1.168.29 → 1.168.30Dependent
@tanstack/router-vite-plugin1.167.29 → 1.167.30Dependent
@tanstack/solid-start1.168.41 → 1.168.42Dependent
@tanstack/solid-start-client1.168.23 → 1.168.24Dependent
@tanstack/solid-start-server1.167.30 → 1.167.31Dependent
@tanstack/start-client-core1.170.21 → 1.170.22Dependent
@tanstack/start-plugin-core1.171.33 → 1.171.34Dependent
@tanstack/start-server-core1.169.25 → 1.169.26Dependent
@tanstack/start-static-server-functions1.167.26 → 1.167.27Dependent
@tanstack/start-storage-context1.167.23 → 1.167.24Dependent
@tanstack/vue-start1.168.40 → 1.168.41Dependent
@tanstack/vue-start-client1.167.26 → 1.167.27Dependent
@tanstack/vue-start-server1.167.30 → 1.167.31Dependent
@coderabbitai
coderabbitaiBot
commented
Aug 11, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Review Change Stack
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 8b3158c2-9ac7-40c4-8c18-18a1f866cd41
📥 Commits
Reviewing files that changed from the base of the PR and between 7e93431 and 143b1c5.
📒 Files selected for processing (5)
  • .changeset/remove-link-transition-state.md
  • packages/react-router/src/link.tsx
  • packages/solid-router/src/link.tsx
  • packages/vue-router/src/link.tsx
  • packages/vue-router/tests/link.test.tsx
💤 Files with no reviewable changes (1)
  • packages/vue-router/tests/link.test.tsx
📝 Walkthrough
Walkthrough
The React, Solid, and Vue Link implementations no longer track or expose isTransitioning or data-transitioning. Their child callback state now contains only isActive. The Vue test for the removed behavior was deleted, and a patch changeset documents the change.
Changes
Link transition state removal
Layer / File(s)Summary
React Link state removal
packages/react-router/src/link.tsx, .changeset/remove-link-transition-state.md		React navigation no longer updates transition state. Link props and function children no longer expose transition data.
Solid Link state removal
packages/solid-router/src/link.tsx		Solid navigation no longer subscribes to resolution state. Transition attributes and callback state were removed.
Vue Link state removal and validation
packages/vue-router/src/link.tsx, packages/vue-router/tests/link.test.tsx		Vue Link results, navigation handling, computed props, attributes, and slots no longer include transition state. The related pending-navigation test was removed.
Estimated code review effort: 3 (Moderate) | ~20 minutes
Possibly related PRs
  • TanStack/router#7952: Both changes modify React Router’s useLinkProps, but this PR removes transition state while that PR addresses render bailout optimization.
🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 warning)
Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 40.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly and concisely identifies the main change: removing Link transition state.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  •  Create stacked PR
  •  Commit on current branch
🧪 Generate unit tests (beta)
  •  Create PR with unit tests
  •  Commit unit tests in branch remove-link-is-transitioning
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands.
@github-actions
github-actionsBot
commented
Aug 11, 2026

Copy link


Copy Markdown

Contributor
Bundle Size Benchmarks
  • Commit: 64ec8e03761f
  • Measured at: 2026-08-11T16:30:18.352Z
  • Baseline source: history:7e93431ae9ff
  • Dashboard: bundle-size history
The following scenarios have bundle-size changes compared with the baseline:
ScenarioCurrent (gzip)Delta vs baselineInitial gzipRawBrotliTrend
react-router.minimal83.84 KiB-83 B (-0.10%)83.70 KiB262.51 KiB72.91 KiB██▁▁▁▁▁▁▁▁▁▁
react-router.full87.35 KiB-77 B (-0.09%)87.21 KiB274.22 KiB76.04 KiB██▁▁▁▁▁▁▁▁▁▁
solid-router.minimal33.17 KiB-73 B (-0.21%)33.04 KiB96.31 KiB29.90 KiB██▁▁▁▁▁▁▁▁▁▁
solid-router.full38.00 KiB-70 B (-0.18%)37.88 KiB110.95 KiB34.20 KiB██▁▁▁▁▁▁▁▁▁▁
vue-router.minimal49.46 KiB-60 B (-0.12%)49.34 KiB138.03 KiB44.64 KiB██▁▁▁▁▁▁▁▁▁▁
vue-router.full55.04 KiB-57 B (-0.10%)54.92 KiB156.21 KiB49.56 KiB██▁▁▁▁▁▁▁▁▁▁
react-start.minimal96.66 KiB-93 B (-0.09%)96.52 KiB304.72 KiB83.79 KiB██▁▁▁▁▁▁▁▁▁▁
react-start.deferred-hydration97.38 KiB-95 B (-0.10%)96.54 KiB306.07 KiB84.38 KiB██▁▁▁▁▁▁▁▁▁▁
react-start.full99.84 KiB-81 B (-0.08%)99.70 KiB314.44 KiB86.44 KiB██▁▁▁▁▁▁▁▁▁▁
react-start.rsbuild.minimal99.98 KiB-84 B (-0.08%)99.81 KiB315.25 KiB86.24 KiB▂▂▂▂▆██████▁
react-start.rsbuild.minimal-iife100.39 KiB-84 B (-0.08%)100.22 KiB316.19 KiB86.60 KiB▂▂▂▂▆██████▁
react-start.rsbuild.full103.31 KiB-82 B (-0.08%)103.14 KiB325.35 KiB88.91 KiB▁▁▁▁▅██████▁
solid-start.minimal45.94 KiB-74 B (-0.16%)45.81 KiB137.37 KiB40.87 KiB██▁▁▁▁▁▁▁▁▁▁
solid-start.deferred-hydration49.00 KiB-80 B (-0.16%)45.87 KiB144.83 KiB43.72 KiB██▁▁▁▁▁▁▁▁▁▁
solid-start.full51.03 KiB-61 B (-0.12%)50.90 KiB152.76 KiB45.22 KiB██▁▁▁▁▁▁▁▁▁▁
vue-start.minimal65.48 KiB-64 B (-0.10%)65.35 KiB188.86 KiB58.33 KiB██▁▁▁▁▁▁▁▁▁▁
vue-start.full69.30 KiB-60 B (-0.08%)69.18 KiB201.13 KiB61.58 KiB██▁▁▁▁▁▁▁▁▁▁
Current gzip tracks all emitted client JS chunks. Initial gzip tracks only the entry/import graph. Trend sparkline is historical current gzip ending with this PR measurement; lower is better.
@pkg-pr-new
pkg-pr-newBot
commented
Aug 11, 2026

Copy link


Copy Markdown

More templates
@tanstack/arktype-adapter
npm i https://pkg.pr.new/@tanstack/arktype-adapter@8043

@tanstack/eslint-plugin-router
npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@8043

@tanstack/eslint-plugin-start
npm i https://pkg.pr.new/@tanstack/eslint-plugin-start@8043

@tanstack/history
npm i https://pkg.pr.new/@tanstack/history@8043

@tanstack/nitro-v2-vite-plugin
npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@8043

@tanstack/react-router
npm i https://pkg.pr.new/@tanstack/react-router@8043

@tanstack/react-router-devtools
npm i https://pkg.pr.new/@tanstack/react-router-devtools@8043

@tanstack/react-router-ssr-query
npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@8043

@tanstack/react-start
npm i https://pkg.pr.new/@tanstack/react-start@8043

@tanstack/react-start-client
npm i https://pkg.pr.new/@tanstack/react-start-client@8043

@tanstack/react-start-rsc
npm i https://pkg.pr.new/@tanstack/react-start-rsc@8043

@tanstack/react-start-server
npm i https://pkg.pr.new/@tanstack/react-start-server@8043

@tanstack/router-cli
npm i https://pkg.pr.new/@tanstack/router-cli@8043

@tanstack/router-core
npm i https://pkg.pr.new/@tanstack/router-core@8043

@tanstack/router-devtools
npm i https://pkg.pr.new/@tanstack/router-devtools@8043

@tanstack/router-devtools-core
npm i https://pkg.pr.new/@tanstack/router-devtools-core@8043

@tanstack/router-generator
npm i https://pkg.pr.new/@tanstack/router-generator@8043

@tanstack/router-plugin
npm i https://pkg.pr.new/@tanstack/router-plugin@8043

@tanstack/router-ssr-query-core
npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@8043

@tanstack/router-utils
npm i https://pkg.pr.new/@tanstack/router-utils@8043

@tanstack/router-vite-plugin
npm i https://pkg.pr.new/@tanstack/router-vite-plugin@8043

@tanstack/solid-router
npm i https://pkg.pr.new/@tanstack/solid-router@8043

@tanstack/solid-router-devtools
npm i https://pkg.pr.new/@tanstack/solid-router-devtools@8043

@tanstack/solid-router-ssr-query
npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@8043

@tanstack/solid-start
npm i https://pkg.pr.new/@tanstack/solid-start@8043

@tanstack/solid-start-client
npm i https://pkg.pr.new/@tanstack/solid-start-client@8043

@tanstack/solid-start-server
npm i https://pkg.pr.new/@tanstack/solid-start-server@8043

@tanstack/start-client-core
npm i https://pkg.pr.new/@tanstack/start-client-core@8043

@tanstack/start-fn-stubs
npm i https://pkg.pr.new/@tanstack/start-fn-stubs@8043

@tanstack/start-plugin-core
npm i https://pkg.pr.new/@tanstack/start-plugin-core@8043

@tanstack/start-server-core
npm i https://pkg.pr.new/@tanstack/start-server-core@8043

@tanstack/start-static-server-functions
npm i https://pkg.pr.new/@tanstack/start-static-server-functions@8043

@tanstack/start-storage-context
npm i https://pkg.pr.new/@tanstack/start-storage-context@8043

@tanstack/valibot-adapter
npm i https://pkg.pr.new/@tanstack/valibot-adapter@8043

@tanstack/virtual-file-routes
npm i https://pkg.pr.new/@tanstack/virtual-file-routes@8043

@tanstack/vue-router
npm i https://pkg.pr.new/@tanstack/vue-router@8043

@tanstack/vue-router-devtools
npm i https://pkg.pr.new/@tanstack/vue-router-devtools@8043

@tanstack/vue-router-ssr-query
npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@8043

@tanstack/vue-start
npm i https://pkg.pr.new/@tanstack/vue-start@8043

@tanstack/vue-start-client
npm i https://pkg.pr.new/@tanstack/vue-start-client@8043

@tanstack/vue-start-server
npm i https://pkg.pr.new/@tanstack/vue-start-server@8043

@tanstack/zod-adapter
npm i https://pkg.pr.new/@tanstack/zod-adapter@8043

commit: 143b1c5
@codspeed-hq
codspeed-hqBot
commented
Aug 11, 2026•

edited

Loading

Copy link


Copy Markdown

Merging this PR will regress 0 benchmarks
⚠️Different runtime environments detected
Some benchmarks with significant performance changes were compared across different runtime environments,

which may affect the accuracy of the results.
Open the report in CodSpeed to investigate
⚡ 25 improved benchmarks
❌ 7 (👁 7) regressed benchmarks
✅ 148 untouched benchmarks
Performance Changes
ModeBenchmarkBASEHEADEfficiency
⚡Simulationclient-async-pipeline navigation loop (react)138.9 ms104.4 ms+32.98%
⚡Simulationclient-async-pipeline navigation loop (solid)200 ms176.5 ms+13.31%
⚡Memorymem server error-paths not-found (vue)777.5 KB688.9 KB+12.85%
⚡Simulationclient-route-tree-scale navigation loop (solid)375.4 ms334.7 ms+12.15%
⚡Simulationclient-rewrites navigation loop (solid)236.2 ms213 ms+10.91%
⚡Simulationclient-loaders navigation loop (solid)230.1 ms208.6 ms+10.26%
⚡Simulationclient-route-tree-scale navigation loop (react)189.1 ms172.7 ms+9.47%
⚡Simulationclient-rewrites navigation loop (react)155.1 ms142.3 ms+9.04%
⚡Simulationclient-control-flow navigation loop (solid)178.9 ms164.1 ms+8.98%
⚡Simulationclient-side navigation loop (react)138.1 ms126.9 ms+8.8%
⚡Simulationclient-links navigation loop (react)319.3 ms296.7 ms+7.61%
⚡Simulationclient-search-params navigation loop (solid)298.2 ms278.5 ms+7.07%
⚡Simulationclient-history navigation loop (solid)173 ms163.2 ms+6.01%
⚡Memorymem server error-paths unmatched (solid)592.5 KB560.5 KB+5.7%
⚡Simulationclient-history navigation loop (react)133.6 ms126.8 ms+5.36%
⚡Simulationclient-control-flow navigation loop (react)180.5 ms171.4 ms+5.27%
⚡Simulationclient-loaders navigation loop (react)136.3 ms129.5 ms+5.24%
⚡Memorymem server error-paths redirect (solid)379.9 KB361.2 KB+5.18%
⚡Memorymem server serialization-payload (vue)4.5 MB4.3 MB+4.94%
⚡Memorymem server aborted-requests (react)905.7 KB864.6 KB+4.75%
..................

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.
Tip
Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.
Comparing remove-link-is-transitioning (143b1c5) with main (7e93431)
Open in CodSpeed
@Sheraff
Sheraff
merged commit 1aafca9
into
mainAug 12, 2026

26 checks passed

@Sheraff
Sheraff
deleted the

remove-link-is-transitioning

branch
August 12, 2026 07:52
@github-actionsgithub-actionsBot
mentioned this pull request
Aug 12, 2026
 Merged

@brenelzbrenelz
mentioned this pull request
Aug 13, 2026
 Merged

@brandhaugbrandhaug
mentioned this pull request
Aug 13, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

package: react-routerpackage: solid-routerpackage: vue-router

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@Sheraff

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
refactor: remove Link transition state - #8043
Merged
Sheraff merged 1 commit into
mainfrom 
remove-link-is-transitioning
Aug 12, 2026
Merged
refactor: remove Link transition state#8043
Sheraff merged 1 commit into
mainfrom 
remove-link-is-transitioning
Conversation
@Sheraff
@SheraffSheraff
commented
Aug 11, 2026•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Collaborator
Summary
  • remove the undocumented per-Link isTransitioning state from the React, Solid, and Vue adapters
  • stop emitting data-transitioning and remove isTransitioning from Link render-prop/slot types and values
  • remove the obsolete Vue regression test and add patch changesets for all three router packages
Compatibility
isTransitioning and data-transitioning were undocumented, but the attribute was observable and Solid/Vue exposed the state at runtime. React advertised the field in its type without passing it at runtime. Please confirm that removing this accidental API is acceptable before merge.
Testing
  • CI=1 NX_DAEMON=false pnpm nx run-many --target=test:unit --projects=@tanstack/react-router,@tanstack/solid-router,@tanstack/vue-router --outputStyle=stream --skipRemoteCache
  • CI=1 NX_DAEMON=false pnpm nx run-many --target=test:types --projects=@tanstack/react-router,@tanstack/solid-router,@tanstack/vue-router --outputStyle=stream --skipRemoteCache
  • CI=1 NX_DAEMON=false pnpm nx run-many --target=test:eslint --projects=@tanstack/react-router,@tanstack/solid-router,@tanstack/vue-router --outputStyle=stream --skipRemoteCache
  • pnpm exec changeset status --since=main
Summary by CodeRabbit
  • Breaking Changes
    • Removed the undocumented isTransitioning state from React, Solid, and Vue router links.
    • Removed the data-transitioning attribute from rendered links.
    • Link child callbacks and Vue slots now receive only isActive.
@nx-cloud
nx-cloudBot
commented
Aug 11, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
View your CI Pipeline Execution ↗ for commit 143b1c5
CommandStatusDurationResult
nx affected --targets=test:eslint,test:unit,tes...✅ Succeeded10m 40sView ↗
nx run-many --target=build --exclude=examples/*...✅ Succeeded2m 20sView ↗
☁️ Nx Cloud last updated this comment at 2026-08-11 16:40:45 UTC
@github-actions
github-actionsBot
commented
Aug 11, 2026

Copy link


Copy Markdown

Contributor
🚀 Changeset Version Preview
4 package(s) bumped directly, 19 bumped as dependents.
🟩 Patch bumps
PackageVersionReason
@tanstack/react-router1.170.25 → 1.170.26Changeset
@tanstack/router-core1.171.21 → 1.171.22Changeset
@tanstack/solid-router1.170.24 → 1.170.25Changeset
@tanstack/vue-router1.170.23 → 1.170.24Changeset
@tanstack/react-start1.168.42 → 1.168.43Dependent
@tanstack/react-start-client1.168.23 → 1.168.24Dependent
@tanstack/react-start-rsc0.1.41 → 0.1.42Dependent
@tanstack/react-start-server1.167.30 → 1.167.31Dependent
@tanstack/router-cli1.167.27 → 1.167.28Dependent
@tanstack/router-generator1.167.27 → 1.167.28Dependent
@tanstack/router-plugin1.168.29 → 1.168.30Dependent
@tanstack/router-vite-plugin1.167.29 → 1.167.30Dependent
@tanstack/solid-start1.168.41 → 1.168.42Dependent
@tanstack/solid-start-client1.168.23 → 1.168.24Dependent
@tanstack/solid-start-server1.167.30 → 1.167.31Dependent
@tanstack/start-client-core1.170.21 → 1.170.22Dependent
@tanstack/start-plugin-core1.171.33 → 1.171.34Dependent
@tanstack/start-server-core1.169.25 → 1.169.26Dependent
@tanstack/start-static-server-functions1.167.26 → 1.167.27Dependent
@tanstack/start-storage-context1.167.23 → 1.167.24Dependent
@tanstack/vue-start1.168.40 → 1.168.41Dependent
@tanstack/vue-start-client1.167.26 → 1.167.27Dependent
@tanstack/vue-start-server1.167.30 → 1.167.31Dependent
@coderabbitai
coderabbitaiBot
commented
Aug 11, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Review Change Stack
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 8b3158c2-9ac7-40c4-8c18-18a1f866cd41
📥 Commits
Reviewing files that changed from the base of the PR and between 7e93431 and 143b1c5.
📒 Files selected for processing (5)
  • .changeset/remove-link-transition-state.md
  • packages/react-router/src/link.tsx
  • packages/solid-router/src/link.tsx
  • packages/vue-router/src/link.tsx
  • packages/vue-router/tests/link.test.tsx
💤 Files with no reviewable changes (1)
  • packages/vue-router/tests/link.test.tsx
📝 Walkthrough
Walkthrough
The React, Solid, and Vue Link implementations no longer track or expose isTransitioning or data-transitioning. Their child callback state now contains only isActive. The Vue test for the removed behavior was deleted, and a patch changeset documents the change.
Changes
Link transition state removal
Layer / File(s)Summary
React Link state removal
packages/react-router/src/link.tsx, .changeset/remove-link-transition-state.md		React navigation no longer updates transition state. Link props and function children no longer expose transition data.
Solid Link state removal
packages/solid-router/src/link.tsx		Solid navigation no longer subscribes to resolution state. Transition attributes and callback state were removed.
Vue Link state removal and validation
packages/vue-router/src/link.tsx, packages/vue-router/tests/link.test.tsx		Vue Link results, navigation handling, computed props, attributes, and slots no longer include transition state. The related pending-navigation test was removed.
Estimated code review effort: 3 (Moderate) | ~20 minutes
Possibly related PRs
  • TanStack/router#7952: Both changes modify React Router’s useLinkProps, but this PR removes transition state while that PR addresses render bailout optimization.
🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 warning)
Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 40.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly and concisely identifies the main change: removing Link transition state.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  •  Create stacked PR
  •  Commit on current branch
🧪 Generate unit tests (beta)
  •  Create PR with unit tests
  •  Commit unit tests in branch remove-link-is-transitioning
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands.
@github-actions
github-actionsBot
commented
Aug 11, 2026

Copy link


Copy Markdown

Contributor
Bundle Size Benchmarks
  • Commit: 64ec8e03761f
  • Measured at: 2026-08-11T16:30:18.352Z
  • Baseline source: history:7e93431ae9ff
  • Dashboard: bundle-size history
The following scenarios have bundle-size changes compared with the baseline:
ScenarioCurrent (gzip)Delta vs baselineInitial gzipRawBrotliTrend
react-router.minimal83.84 KiB-83 B (-0.10%)83.70 KiB262.51 KiB72.91 KiB██▁▁▁▁▁▁▁▁▁▁
react-router.full87.35 KiB-77 B (-0.09%)87.21 KiB274.22 KiB76.04 KiB██▁▁▁▁▁▁▁▁▁▁
solid-router.minimal33.17 KiB-73 B (-0.21%)33.04 KiB96.31 KiB29.90 KiB██▁▁▁▁▁▁▁▁▁▁
solid-router.full38.00 KiB-70 B (-0.18%)37.88 KiB110.95 KiB34.20 KiB██▁▁▁▁▁▁▁▁▁▁
vue-router.minimal49.46 KiB-60 B (-0.12%)49.34 KiB138.03 KiB44.64 KiB██▁▁▁▁▁▁▁▁▁▁
vue-router.full55.04 KiB-57 B (-0.10%)54.92 KiB156.21 KiB49.56 KiB██▁▁▁▁▁▁▁▁▁▁
react-start.minimal96.66 KiB-93 B (-0.09%)96.52 KiB304.72 KiB83.79 KiB██▁▁▁▁▁▁▁▁▁▁
react-start.deferred-hydration97.38 KiB-95 B (-0.10%)96.54 KiB306.07 KiB84.38 KiB██▁▁▁▁▁▁▁▁▁▁
react-start.full99.84 KiB-81 B (-0.08%)99.70 KiB314.44 KiB86.44 KiB██▁▁▁▁▁▁▁▁▁▁
react-start.rsbuild.minimal99.98 KiB-84 B (-0.08%)99.81 KiB315.25 KiB86.24 KiB▂▂▂▂▆██████▁
react-start.rsbuild.minimal-iife100.39 KiB-84 B (-0.08%)100.22 KiB316.19 KiB86.60 KiB▂▂▂▂▆██████▁
react-start.rsbuild.full103.31 KiB-82 B (-0.08%)103.14 KiB325.35 KiB88.91 KiB▁▁▁▁▅██████▁
solid-start.minimal45.94 KiB-74 B (-0.16%)45.81 KiB137.37 KiB40.87 KiB██▁▁▁▁▁▁▁▁▁▁
solid-start.deferred-hydration49.00 KiB-80 B (-0.16%)45.87 KiB144.83 KiB43.72 KiB██▁▁▁▁▁▁▁▁▁▁
solid-start.full51.03 KiB-61 B (-0.12%)50.90 KiB152.76 KiB45.22 KiB██▁▁▁▁▁▁▁▁▁▁
vue-start.minimal65.48 KiB-64 B (-0.10%)65.35 KiB188.86 KiB58.33 KiB██▁▁▁▁▁▁▁▁▁▁
vue-start.full69.30 KiB-60 B (-0.08%)69.18 KiB201.13 KiB61.58 KiB██▁▁▁▁▁▁▁▁▁▁
Current gzip tracks all emitted client JS chunks. Initial gzip tracks only the entry/import graph. Trend sparkline is historical current gzip ending with this PR measurement; lower is better.
@pkg-pr-new
pkg-pr-newBot
commented
Aug 11, 2026

Copy link


Copy Markdown

More templates
@tanstack/arktype-adapter
npm i https://pkg.pr.new/@tanstack/arktype-adapter@8043

@tanstack/eslint-plugin-router
npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@8043

@tanstack/eslint-plugin-start
npm i https://pkg.pr.new/@tanstack/eslint-plugin-start@8043

@tanstack/history
npm i https://pkg.pr.new/@tanstack/history@8043

@tanstack/nitro-v2-vite-plugin
npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@8043

@tanstack/react-router
npm i https://pkg.pr.new/@tanstack/react-router@8043

@tanstack/react-router-devtools
npm i https://pkg.pr.new/@tanstack/react-router-devtools@8043

@tanstack/react-router-ssr-query
npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@8043

@tanstack/react-start
npm i https://pkg.pr.new/@tanstack/react-start@8043

@tanstack/react-start-client
npm i https://pkg.pr.new/@tanstack/react-start-client@8043

@tanstack/react-start-rsc
npm i https://pkg.pr.new/@tanstack/react-start-rsc@8043

@tanstack/react-start-server
npm i https://pkg.pr.new/@tanstack/react-start-server@8043

@tanstack/router-cli
npm i https://pkg.pr.new/@tanstack/router-cli@8043

@tanstack/router-core
npm i https://pkg.pr.new/@tanstack/router-core@8043

@tanstack/router-devtools
npm i https://pkg.pr.new/@tanstack/router-devtools@8043

@tanstack/router-devtools-core
npm i https://pkg.pr.new/@tanstack/router-devtools-core@8043

@tanstack/router-generator
npm i https://pkg.pr.new/@tanstack/router-generator@8043

@tanstack/router-plugin
npm i https://pkg.pr.new/@tanstack/router-plugin@8043

@tanstack/router-ssr-query-core
npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@8043

@tanstack/router-utils
npm i https://pkg.pr.new/@tanstack/router-utils@8043

@tanstack/router-vite-plugin
npm i https://pkg.pr.new/@tanstack/router-vite-plugin@8043

@tanstack/solid-router
npm i https://pkg.pr.new/@tanstack/solid-router@8043

@tanstack/solid-router-devtools
npm i https://pkg.pr.new/@tanstack/solid-router-devtools@8043

@tanstack/solid-router-ssr-query
npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@8043

@tanstack/solid-start
npm i https://pkg.pr.new/@tanstack/solid-start@8043

@tanstack/solid-start-client
npm i https://pkg.pr.new/@tanstack/solid-start-client@8043

@tanstack/solid-start-server
npm i https://pkg.pr.new/@tanstack/solid-start-server@8043

@tanstack/start-client-core
npm i https://pkg.pr.new/@tanstack/start-client-core@8043

@tanstack/start-fn-stubs
npm i https://pkg.pr.new/@tanstack/start-fn-stubs@8043

@tanstack/start-plugin-core
npm i https://pkg.pr.new/@tanstack/start-plugin-core@8043

@tanstack/start-server-core
npm i https://pkg.pr.new/@tanstack/start-server-core@8043

@tanstack/start-static-server-functions
npm i https://pkg.pr.new/@tanstack/start-static-server-functions@8043

@tanstack/start-storage-context
npm i https://pkg.pr.new/@tanstack/start-storage-context@8043

@tanstack/valibot-adapter
npm i https://pkg.pr.new/@tanstack/valibot-adapter@8043

@tanstack/virtual-file-routes
npm i https://pkg.pr.new/@tanstack/virtual-file-routes@8043

@tanstack/vue-router
npm i https://pkg.pr.new/@tanstack/vue-router@8043

@tanstack/vue-router-devtools
npm i https://pkg.pr.new/@tanstack/vue-router-devtools@8043

@tanstack/vue-router-ssr-query
npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@8043

@tanstack/vue-start
npm i https://pkg.pr.new/@tanstack/vue-start@8043

@tanstack/vue-start-client
npm i https://pkg.pr.new/@tanstack/vue-start-client@8043

@tanstack/vue-start-server
npm i https://pkg.pr.new/@tanstack/vue-start-server@8043

@tanstack/zod-adapter
npm i https://pkg.pr.new/@tanstack/zod-adapter@8043

commit: 143b1c5
@codspeed-hq
codspeed-hqBot
commented
Aug 11, 2026•

edited

Loading

Copy link


Copy Markdown

Merging this PR will regress 0 benchmarks
⚠️Different runtime environments detected
Some benchmarks with significant performance changes were compared across different runtime environments,

which may affect the accuracy of the results.
Open the report in CodSpeed to investigate
⚡ 25 improved benchmarks
❌ 7 (👁 7) regressed benchmarks
✅ 148 untouched benchmarks
Performance Changes
ModeBenchmarkBASEHEADEfficiency
⚡Simulationclient-async-pipeline navigation loop (react)138.9 ms104.4 ms+32.98%
⚡Simulationclient-async-pipeline navigation loop (solid)200 ms176.5 ms+13.31%
⚡Memorymem server error-paths not-found (vue)777.5 KB688.9 KB+12.85%
⚡Simulationclient-route-tree-scale navigation loop (solid)375.4 ms334.7 ms+12.15%
⚡Simulationclient-rewrites navigation loop (solid)236.2 ms213 ms+10.91%
⚡Simulationclient-loaders navigation loop (solid)230.1 ms208.6 ms+10.26%
⚡Simulationclient-route-tree-scale navigation loop (react)189.1 ms172.7 ms+9.47%
⚡Simulationclient-rewrites navigation loop (react)155.1 ms142.3 ms+9.04%
⚡Simulationclient-control-flow navigation loop (solid)178.9 ms164.1 ms+8.98%
⚡Simulationclient-side navigation loop (react)138.1 ms126.9 ms+8.8%
⚡Simulationclient-links navigation loop (react)319.3 ms296.7 ms+7.61%
⚡Simulationclient-search-params navigation loop (solid)298.2 ms278.5 ms+7.07%
⚡Simulationclient-history navigation loop (solid)173 ms163.2 ms+6.01%
⚡Memorymem server error-paths unmatched (solid)592.5 KB560.5 KB+5.7%
⚡Simulationclient-history navigation loop (react)133.6 ms126.8 ms+5.36%
⚡Simulationclient-control-flow navigation loop (react)180.5 ms171.4 ms+5.27%
⚡Simulationclient-loaders navigation loop (react)136.3 ms129.5 ms+5.24%
⚡Memorymem server error-paths redirect (solid)379.9 KB361.2 KB+5.18%
⚡Memorymem server serialization-payload (vue)4.5 MB4.3 MB+4.94%
⚡Memorymem server aborted-requests (react)905.7 KB864.6 KB+4.75%
..................

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.
Tip
Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.
Comparing remove-link-is-transitioning (143b1c5) with main (7e93431)
Open in CodSpeed
@Sheraff
Sheraff
merged commit 1aafca9
into
mainAug 12, 2026

26 checks passed

@Sheraff
Sheraff
deleted the

remove-link-is-transitioning

branch
August 12, 2026 07:52
@github-actionsgithub-actionsBot
mentioned this pull request
Aug 12, 2026
 Merged

@brenelzbrenelz
mentioned this pull request
Aug 13, 2026
 Merged

@brandhaugbrandhaug
mentioned this pull request
Aug 13, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

package: react-routerpackage: solid-routerpackage: vue-router

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@Sheraff

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
refactor: remove Link transition state - #8043
Merged
Sheraff merged 1 commit into
mainfrom 
remove-link-is-transitioning
Aug 12, 2026
Merged
refactor: remove Link transition state#8043
Sheraff merged 1 commit into
mainfrom 
remove-link-is-transitioning
Conversation
@Sheraff
@SheraffSheraff
commented
Aug 11, 2026•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Collaborator
Summary
  • remove the undocumented per-Link isTransitioning state from the React, Solid, and Vue adapters
  • stop emitting data-transitioning and remove isTransitioning from Link render-prop/slot types and values
  • remove the obsolete Vue regression test and add patch changesets for all three router packages
Compatibility
isTransitioning and data-transitioning were undocumented, but the attribute was observable and Solid/Vue exposed the state at runtime. React advertised the field in its type without passing it at runtime. Please confirm that removing this accidental API is acceptable before merge.
Testing
  • CI=1 NX_DAEMON=false pnpm nx run-many --target=test:unit --projects=@tanstack/react-router,@tanstack/solid-router,@tanstack/vue-router --outputStyle=stream --skipRemoteCache
  • CI=1 NX_DAEMON=false pnpm nx run-many --target=test:types --projects=@tanstack/react-router,@tanstack/solid-router,@tanstack/vue-router --outputStyle=stream --skipRemoteCache
  • CI=1 NX_DAEMON=false pnpm nx run-many --target=test:eslint --projects=@tanstack/react-router,@tanstack/solid-router,@tanstack/vue-router --outputStyle=stream --skipRemoteCache
  • pnpm exec changeset status --since=main
Summary by CodeRabbit
  • Breaking Changes
    • Removed the undocumented isTransitioning state from React, Solid, and Vue router links.
    • Removed the data-transitioning attribute from rendered links.
    • Link child callbacks and Vue slots now receive only isActive.
@nx-cloud
nx-cloudBot
commented
Aug 11, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
View your CI Pipeline Execution ↗ for commit 143b1c5
CommandStatusDurationResult
nx affected --targets=test:eslint,test:unit,tes...✅ Succeeded10m 40sView ↗
nx run-many --target=build --exclude=examples/*...✅ Succeeded2m 20sView ↗
☁️ Nx Cloud last updated this comment at 2026-08-11 16:40:45 UTC
@github-actions
github-actionsBot
commented
Aug 11, 2026

Copy link


Copy Markdown

Contributor
🚀 Changeset Version Preview
4 package(s) bumped directly, 19 bumped as dependents.
🟩 Patch bumps
PackageVersionReason
@tanstack/react-router1.170.25 → 1.170.26Changeset
@tanstack/router-core1.171.21 → 1.171.22Changeset
@tanstack/solid-router1.170.24 → 1.170.25Changeset
@tanstack/vue-router1.170.23 → 1.170.24Changeset
@tanstack/react-start1.168.42 → 1.168.43Dependent
@tanstack/react-start-client1.168.23 → 1.168.24Dependent
@tanstack/react-start-rsc0.1.41 → 0.1.42Dependent
@tanstack/react-start-server1.167.30 → 1.167.31Dependent
@tanstack/router-cli1.167.27 → 1.167.28Dependent
@tanstack/router-generator1.167.27 → 1.167.28Dependent
@tanstack/router-plugin1.168.29 → 1.168.30Dependent
@tanstack/router-vite-plugin1.167.29 → 1.167.30Dependent
@tanstack/solid-start1.168.41 → 1.168.42Dependent
@tanstack/solid-start-client1.168.23 → 1.168.24Dependent
@tanstack/solid-start-server1.167.30 → 1.167.31Dependent
@tanstack/start-client-core1.170.21 → 1.170.22Dependent
@tanstack/start-plugin-core1.171.33 → 1.171.34Dependent
@tanstack/start-server-core1.169.25 → 1.169.26Dependent
@tanstack/start-static-server-functions1.167.26 → 1.167.27Dependent
@tanstack/start-storage-context1.167.23 → 1.167.24Dependent
@tanstack/vue-start1.168.40 → 1.168.41Dependent
@tanstack/vue-start-client1.167.26 → 1.167.27Dependent
@tanstack/vue-start-server1.167.30 → 1.167.31Dependent
@coderabbitai
coderabbitaiBot
commented
Aug 11, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Review Change Stack
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 8b3158c2-9ac7-40c4-8c18-18a1f866cd41
📥 Commits
Reviewing files that changed from the base of the PR and between 7e93431 and 143b1c5.
📒 Files selected for processing (5)
  • .changeset/remove-link-transition-state.md
  • packages/react-router/src/link.tsx
  • packages/solid-router/src/link.tsx
  • packages/vue-router/src/link.tsx
  • packages/vue-router/tests/link.test.tsx
💤 Files with no reviewable changes (1)
  • packages/vue-router/tests/link.test.tsx
📝 Walkthrough
Walkthrough
The React, Solid, and Vue Link implementations no longer track or expose isTransitioning or data-transitioning. Their child callback state now contains only isActive. The Vue test for the removed behavior was deleted, and a patch changeset documents the change.
Changes
Link transition state removal
Layer / File(s)Summary
React Link state removal
packages/react-router/src/link.tsx, .changeset/remove-link-transition-state.md		React navigation no longer updates transition state. Link props and function children no longer expose transition data.
Solid Link state removal
packages/solid-router/src/link.tsx		Solid navigation no longer subscribes to resolution state. Transition attributes and callback state were removed.
Vue Link state removal and validation
packages/vue-router/src/link.tsx, packages/vue-router/tests/link.test.tsx		Vue Link results, navigation handling, computed props, attributes, and slots no longer include transition state. The related pending-navigation test was removed.
Estimated code review effort: 3 (Moderate) | ~20 minutes
Possibly related PRs
  • TanStack/router#7952: Both changes modify React Router’s useLinkProps, but this PR removes transition state while that PR addresses render bailout optimization.
🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 warning)
Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 40.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly and concisely identifies the main change: removing Link transition state.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  •  Create stacked PR
  •  Commit on current branch
🧪 Generate unit tests (beta)
  •  Create PR with unit tests
  •  Commit unit tests in branch remove-link-is-transitioning
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands.
@github-actions
github-actionsBot
commented
Aug 11, 2026

Copy link


Copy Markdown

Contributor
Bundle Size Benchmarks
  • Commit: 64ec8e03761f
  • Measured at: 2026-08-11T16:30:18.352Z
  • Baseline source: history:7e93431ae9ff
  • Dashboard: bundle-size history
The following scenarios have bundle-size changes compared with the baseline:
ScenarioCurrent (gzip)Delta vs baselineInitial gzipRawBrotliTrend
react-router.minimal83.84 KiB-83 B (-0.10%)83.70 KiB262.51 KiB72.91 KiB██▁▁▁▁▁▁▁▁▁▁
react-router.full87.35 KiB-77 B (-0.09%)87.21 KiB274.22 KiB76.04 KiB██▁▁▁▁▁▁▁▁▁▁
solid-router.minimal33.17 KiB-73 B (-0.21%)33.04 KiB96.31 KiB29.90 KiB██▁▁▁▁▁▁▁▁▁▁
solid-router.full38.00 KiB-70 B (-0.18%)37.88 KiB110.95 KiB34.20 KiB██▁▁▁▁▁▁▁▁▁▁
vue-router.minimal49.46 KiB-60 B (-0.12%)49.34 KiB138.03 KiB44.64 KiB██▁▁▁▁▁▁▁▁▁▁
vue-router.full55.04 KiB-57 B (-0.10%)54.92 KiB156.21 KiB49.56 KiB██▁▁▁▁▁▁▁▁▁▁
react-start.minimal96.66 KiB-93 B (-0.09%)96.52 KiB304.72 KiB83.79 KiB██▁▁▁▁▁▁▁▁▁▁
react-start.deferred-hydration97.38 KiB-95 B (-0.10%)96.54 KiB306.07 KiB84.38 KiB██▁▁▁▁▁▁▁▁▁▁
react-start.full99.84 KiB-81 B (-0.08%)99.70 KiB314.44 KiB86.44 KiB██▁▁▁▁▁▁▁▁▁▁
react-start.rsbuild.minimal99.98 KiB-84 B (-0.08%)99.81 KiB315.25 KiB86.24 KiB▂▂▂▂▆██████▁
react-start.rsbuild.minimal-iife100.39 KiB-84 B (-0.08%)100.22 KiB316.19 KiB86.60 KiB▂▂▂▂▆██████▁
react-start.rsbuild.full103.31 KiB-82 B (-0.08%)103.14 KiB325.35 KiB88.91 KiB▁▁▁▁▅██████▁
solid-start.minimal45.94 KiB-74 B (-0.16%)45.81 KiB137.37 KiB40.87 KiB██▁▁▁▁▁▁▁▁▁▁
solid-start.deferred-hydration49.00 KiB-80 B (-0.16%)45.87 KiB144.83 KiB43.72 KiB██▁▁▁▁▁▁▁▁▁▁
solid-start.full51.03 KiB-61 B (-0.12%)50.90 KiB152.76 KiB45.22 KiB██▁▁▁▁▁▁▁▁▁▁
vue-start.minimal65.48 KiB-64 B (-0.10%)65.35 KiB188.86 KiB58.33 KiB██▁▁▁▁▁▁▁▁▁▁
vue-start.full69.30 KiB-60 B (-0.08%)69.18 KiB201.13 KiB61.58 KiB██▁▁▁▁▁▁▁▁▁▁
Current gzip tracks all emitted client JS chunks. Initial gzip tracks only the entry/import graph. Trend sparkline is historical current gzip ending with this PR measurement; lower is better.
@pkg-pr-new
pkg-pr-newBot
commented
Aug 11, 2026

Copy link


Copy Markdown

More templates
@tanstack/arktype-adapter
npm i https://pkg.pr.new/@tanstack/arktype-adapter@8043

@tanstack/eslint-plugin-router
npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@8043

@tanstack/eslint-plugin-start
npm i https://pkg.pr.new/@tanstack/eslint-plugin-start@8043

@tanstack/history
npm i https://pkg.pr.new/@tanstack/history@8043

@tanstack/nitro-v2-vite-plugin
npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@8043

@tanstack/react-router
npm i https://pkg.pr.new/@tanstack/react-router@8043

@tanstack/react-router-devtools
npm i https://pkg.pr.new/@tanstack/react-router-devtools@8043

@tanstack/react-router-ssr-query
npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@8043

@tanstack/react-start
npm i https://pkg.pr.new/@tanstack/react-start@8043

@tanstack/react-start-client
npm i https://pkg.pr.new/@tanstack/react-start-client@8043

@tanstack/react-start-rsc
npm i https://pkg.pr.new/@tanstack/react-start-rsc@8043

@tanstack/react-start-server
npm i https://pkg.pr.new/@tanstack/react-start-server@8043

@tanstack/router-cli
npm i https://pkg.pr.new/@tanstack/router-cli@8043

@tanstack/router-core
npm i https://pkg.pr.new/@tanstack/router-core@8043

@tanstack/router-devtools
npm i https://pkg.pr.new/@tanstack/router-devtools@8043

@tanstack/router-devtools-core
npm i https://pkg.pr.new/@tanstack/router-devtools-core@8043

@tanstack/router-generator
npm i https://pkg.pr.new/@tanstack/router-generator@8043

@tanstack/router-plugin
npm i https://pkg.pr.new/@tanstack/router-plugin@8043

@tanstack/router-ssr-query-core
npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@8043

@tanstack/router-utils
npm i https://pkg.pr.new/@tanstack/router-utils@8043

@tanstack/router-vite-plugin
npm i https://pkg.pr.new/@tanstack/router-vite-plugin@8043

@tanstack/solid-router
npm i https://pkg.pr.new/@tanstack/solid-router@8043

@tanstack/solid-router-devtools
npm i https://pkg.pr.new/@tanstack/solid-router-devtools@8043

@tanstack/solid-router-ssr-query
npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@8043

@tanstack/solid-start
npm i https://pkg.pr.new/@tanstack/solid-start@8043

@tanstack/solid-start-client
npm i https://pkg.pr.new/@tanstack/solid-start-client@8043

@tanstack/solid-start-server
npm i https://pkg.pr.new/@tanstack/solid-start-server@8043

@tanstack/start-client-core
npm i https://pkg.pr.new/@tanstack/start-client-core@8043

@tanstack/start-fn-stubs
npm i https://pkg.pr.new/@tanstack/start-fn-stubs@8043

@tanstack/start-plugin-core
npm i https://pkg.pr.new/@tanstack/start-plugin-core@8043

@tanstack/start-server-core
npm i https://pkg.pr.new/@tanstack/start-server-core@8043

@tanstack/start-static-server-functions
npm i https://pkg.pr.new/@tanstack/start-static-server-functions@8043

@tanstack/start-storage-context
npm i https://pkg.pr.new/@tanstack/start-storage-context@8043

@tanstack/valibot-adapter
npm i https://pkg.pr.new/@tanstack/valibot-adapter@8043

@tanstack/virtual-file-routes
npm i https://pkg.pr.new/@tanstack/virtual-file-routes@8043

@tanstack/vue-router
npm i https://pkg.pr.new/@tanstack/vue-router@8043

@tanstack/vue-router-devtools
npm i https://pkg.pr.new/@tanstack/vue-router-devtools@8043

@tanstack/vue-router-ssr-query
npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@8043

@tanstack/vue-start
npm i https://pkg.pr.new/@tanstack/vue-start@8043

@tanstack/vue-start-client
npm i https://pkg.pr.new/@tanstack/vue-start-client@8043

@tanstack/vue-start-server
npm i https://pkg.pr.new/@tanstack/vue-start-server@8043

@tanstack/zod-adapter
npm i https://pkg.pr.new/@tanstack/zod-adapter@8043

commit: 143b1c5
@codspeed-hq
codspeed-hqBot
commented
Aug 11, 2026•

edited

Loading

Copy link


Copy Markdown

Merging this PR will regress 0 benchmarks
⚠️Different runtime environments detected
Some benchmarks with significant performance changes were compared across different runtime environments,

which may affect the accuracy of the results.
Open the report in CodSpeed to investigate
⚡ 25 improved benchmarks
❌ 7 (👁 7) regressed benchmarks
✅ 148 untouched benchmarks
Performance Changes
ModeBenchmarkBASEHEADEfficiency
⚡Simulationclient-async-pipeline navigation loop (react)138.9 ms104.4 ms+32.98%
⚡Simulationclient-async-pipeline navigation loop (solid)200 ms176.5 ms+13.31%
⚡Memorymem server error-paths not-found (vue)777.5 KB688.9 KB+12.85%
⚡Simulationclient-route-tree-scale navigation loop (solid)375.4 ms334.7 ms+12.15%
⚡Simulationclient-rewrites navigation loop (solid)236.2 ms213 ms+10.91%
⚡Simulationclient-loaders navigation loop (solid)230.1 ms208.6 ms+10.26%
⚡Simulationclient-route-tree-scale navigation loop (react)189.1 ms172.7 ms+9.47%
⚡Simulationclient-rewrites navigation loop (react)155.1 ms142.3 ms+9.04%
⚡Simulationclient-control-flow navigation loop (solid)178.9 ms164.1 ms+8.98%
⚡Simulationclient-side navigation loop (react)138.1 ms126.9 ms+8.8%
⚡Simulationclient-links navigation loop (react)319.3 ms296.7 ms+7.61%
⚡Simulationclient-search-params navigation loop (solid)298.2 ms278.5 ms+7.07%
⚡Simulationclient-history navigation loop (solid)173 ms163.2 ms+6.01%
⚡Memorymem server error-paths unmatched (solid)592.5 KB560.5 KB+5.7%
⚡Simulationclient-history navigation loop (react)133.6 ms126.8 ms+5.36%
⚡Simulationclient-control-flow navigation loop (react)180.5 ms171.4 ms+5.27%
⚡Simulationclient-loaders navigation loop (react)136.3 ms129.5 ms+5.24%
⚡Memorymem server error-paths redirect (solid)379.9 KB361.2 KB+5.18%
⚡Memorymem server serialization-payload (vue)4.5 MB4.3 MB+4.94%
⚡Memorymem server aborted-requests (react)905.7 KB864.6 KB+4.75%
..................

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.
Tip
Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.
Comparing remove-link-is-transitioning (143b1c5) with main (7e93431)
Open in CodSpeed
@Sheraff
Sheraff
merged commit 1aafca9
into
mainAug 12, 2026

26 checks passed

@Sheraff
Sheraff
deleted the

remove-link-is-transitioning

branch
August 12, 2026 07:52
@github-actionsgithub-actionsBot
mentioned this pull request
Aug 12, 2026
 Merged

@brenelzbrenelz
mentioned this pull request
Aug 13, 2026
 Merged

@brandhaugbrandhaug
mentioned this pull request
Aug 13, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

package: react-routerpackage: solid-routerpackage: vue-router

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@Sheraff