fix(router): align pending presentation across Solid and Vue by Sheraff · Pull Request #8097 · TanStack/router

Sheraff · 2026-08-18T07:38:38Z

Summary

port retained pending and presentation-lane contracts to Solid Router and Vue Router
settle superseded Solid render receipts immediately while preserving Solid's joined native transitions
use the committed semantic lane to distinguish cold loads from accepted-but-unrendered UI

Testing

not run after the final error-handling refactor, per request; CI will validate

coderabbitai · 2026-08-18T07:38:57Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 85322a72-a2d4-4596-849f-8b8b6aed8799

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

nx-cloud · 2026-08-18T07:39:07Z

View your CI Pipeline Execution ↗ for commit 1f477f8

Command	Status	Duration	Result
`nx affected --targets=test:eslint,test:unit,tes...`	✅ Succeeded	9m 59s	View ↗
`nx run-many --target=build --exclude=examples/*...`	✅ Succeeded	1m 37s	View ↗

☁️ Nx Cloud last updated this comment at 2026-08-18 07:50:22 UTC

github-actions · 2026-08-18T07:39:59Z

🚀 Changeset Version Preview

1 package(s) bumped directly, 4 bumped as dependents.

🟩 Patch bumps

Package	Version	Reason
`@tanstack/react-router`	1.170.29 → 1.170.30	Changeset
`@tanstack/react-start`	1.168.46 → 1.168.47	Dependent
`@tanstack/react-start-client`	1.168.27 → 1.168.28	Dependent
`@tanstack/react-start-rsc`	0.1.45 → 0.1.46	Dependent
`@tanstack/react-start-server`	1.167.34 → 1.167.35	Dependent

pkg-pr-new · 2026-08-18T07:43:18Z

More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/@tanstack/arktype-adapter@8097

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@8097

@tanstack/eslint-plugin-start

npm i https://pkg.pr.new/@tanstack/eslint-plugin-start@8097

@tanstack/history

npm i https://pkg.pr.new/@tanstack/history@8097

@tanstack/nitro-v2-vite-plugin

npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@8097

@tanstack/react-router

npm i https://pkg.pr.new/@tanstack/react-router@8097

@tanstack/react-router-devtools

npm i https://pkg.pr.new/@tanstack/react-router-devtools@8097

@tanstack/react-router-ssr-query

npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@8097

@tanstack/react-start

npm i https://pkg.pr.new/@tanstack/react-start@8097

@tanstack/react-start-client

npm i https://pkg.pr.new/@tanstack/react-start-client@8097

@tanstack/react-start-rsc

npm i https://pkg.pr.new/@tanstack/react-start-rsc@8097

@tanstack/react-start-server

npm i https://pkg.pr.new/@tanstack/react-start-server@8097

@tanstack/router-cli

npm i https://pkg.pr.new/@tanstack/router-cli@8097

@tanstack/router-core

npm i https://pkg.pr.new/@tanstack/router-core@8097

@tanstack/router-devtools

npm i https://pkg.pr.new/@tanstack/router-devtools@8097

@tanstack/router-devtools-core

npm i https://pkg.pr.new/@tanstack/router-devtools-core@8097

@tanstack/router-generator

npm i https://pkg.pr.new/@tanstack/router-generator@8097

@tanstack/router-plugin

npm i https://pkg.pr.new/@tanstack/router-plugin@8097

@tanstack/router-ssr-query-core

npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@8097

@tanstack/router-utils

npm i https://pkg.pr.new/@tanstack/router-utils@8097

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/@tanstack/router-vite-plugin@8097

@tanstack/solid-router

npm i https://pkg.pr.new/@tanstack/solid-router@8097

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/@tanstack/solid-router-devtools@8097

@tanstack/solid-router-ssr-query

npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@8097

@tanstack/solid-start

npm i https://pkg.pr.new/@tanstack/solid-start@8097

@tanstack/solid-start-client

npm i https://pkg.pr.new/@tanstack/solid-start-client@8097

@tanstack/solid-start-server

npm i https://pkg.pr.new/@tanstack/solid-start-server@8097

@tanstack/start-client-core

npm i https://pkg.pr.new/@tanstack/start-client-core@8097

@tanstack/start-fn-stubs

npm i https://pkg.pr.new/@tanstack/start-fn-stubs@8097

@tanstack/start-plugin-core

npm i https://pkg.pr.new/@tanstack/start-plugin-core@8097

@tanstack/start-server-core

npm i https://pkg.pr.new/@tanstack/start-server-core@8097

@tanstack/start-static-server-functions

npm i https://pkg.pr.new/@tanstack/start-static-server-functions@8097

@tanstack/start-storage-context

npm i https://pkg.pr.new/@tanstack/start-storage-context@8097

@tanstack/valibot-adapter

npm i https://pkg.pr.new/@tanstack/valibot-adapter@8097

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/@tanstack/virtual-file-routes@8097

@tanstack/vue-router

npm i https://pkg.pr.new/@tanstack/vue-router@8097

@tanstack/vue-router-devtools

npm i https://pkg.pr.new/@tanstack/vue-router-devtools@8097

@tanstack/vue-router-ssr-query

npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@8097

@tanstack/vue-start

npm i https://pkg.pr.new/@tanstack/vue-start@8097

@tanstack/vue-start-client

npm i https://pkg.pr.new/@tanstack/vue-start-client@8097

@tanstack/vue-start-server

npm i https://pkg.pr.new/@tanstack/vue-start-server@8097

@tanstack/zod-adapter

npm i https://pkg.pr.new/@tanstack/zod-adapter@8097

commit: 1f477f8

github-actions · 2026-08-18T07:43:33Z

Bundle Size Benchmarks

Commit: dcefe2d8acbc
Measured at: 2026-08-18T07:42:47.206Z
Baseline source: history:f97188fdb4c3
Dashboard: bundle-size history

The following scenarios have bundle-size changes compared with the baseline:

Scenario	Current (gzip)	Delta vs baseline	Initial gzip	Raw	Brotli	Trend
`react-router.minimal`	83.81 KiB	-17 B (-0.02%)	83.67 KiB	262.42 KiB	72.94 KiB	▃▃▃▄██▆▃▃▂▂▁
`react-router.full`	87.30 KiB	-20 B (-0.02%)	87.17 KiB	274.12 KiB	76.05 KiB	▅▅▅▅██▆▃▃▂▂▁
`solid-router.minimal`	33.12 KiB	+7 B (+0.02%)	33.00 KiB	96.25 KiB	29.96 KiB	▆▇████▅▁▁▁▁▂
`solid-router.full`	37.96 KiB	+26 B (+0.07%)	37.84 KiB	110.89 KiB	34.16 KiB	▆▇████▅▁▁▁▁▄
`vue-router.minimal`	49.48 KiB	-24 B (-0.05%)	49.36 KiB	138.29 KiB	44.67 KiB	▁█▇███▅▃▃▃▃▂
`vue-router.full`	55.08 KiB	-29 B (-0.05%)	54.96 KiB	156.49 KiB	49.51 KiB	▁█████▆▄▄▄▄▃
`react-start.minimal`	96.62 KiB	+1 B (+0.00%)	96.48 KiB	304.65 KiB	83.81 KiB	▄▄▄▄██▅▂▂▁▁▁
`react-start.full`	99.80 KiB	-6 B (-0.01%)	99.66 KiB	314.36 KiB	86.47 KiB	▄▄▄▄██▄▁▁▁▁▁
`react-start.rsbuild.minimal`	99.96 KiB	-8 B (-0.01%)	99.79 KiB	314.98 KiB	86.17 KiB	▂▂▂▂███▃▃▂▂▁
`react-start.rsbuild.minimal-iife`	100.36 KiB	-7 B (-0.01%)	100.20 KiB	315.92 KiB	86.54 KiB	▂▂▂▂███▃▃▂▂▁
`react-start.rsbuild.full`	103.27 KiB	-18 B (-0.02%)	103.10 KiB	325.08 KiB	88.93 KiB	▂▂▂▃███▃▃▃▃▁
`solid-start.minimal`	45.92 KiB	+49 B (+0.10%)	45.79 KiB	137.31 KiB	40.83 KiB	▇█████▄▁▁▁▁▅
`solid-start.deferred-hydration`	48.99 KiB	+33 B (+0.07%)	45.85 KiB	144.77 KiB	43.69 KiB	▇▇████▄▁▁▁▁▄
`solid-start.full`	51.01 KiB	+46 B (+0.09%)	50.88 KiB	152.70 KiB	45.20 KiB	▆█████▄▁▁▁▁▆
`vue-start.minimal`	65.55 KiB	-13 B (-0.02%)	65.43 KiB	189.11 KiB	58.37 KiB	▁█████▆▅▅▅▅▄
`vue-start.full`	69.36 KiB	-13 B (-0.02%)	69.24 KiB	201.41 KiB	61.58 KiB	▁█████▆▅▅▅▅▄

Current gzip tracks all emitted client JS chunks. Initial gzip tracks only the entry/import graph. Trend sparkline is historical current gzip ending with this PR measurement; lower is better.

codspeed-hq · 2026-08-18T07:54:50Z

Merging this PR will regress 6 benchmarks

⚠️

Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.
Open the report in CodSpeed to investigate

⚡ 9 improved benchmarks
❌ 6 regressed benchmarks
✅ 165 untouched benchmarks

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

	Mode	Benchmark	`BASE`	`HEAD`	Efficiency
❌	Memory	`mem server error-paths redirect (solid)`	391.8 KB	432 KB	-9.32%
❌	Memory	`mem client navigation-churn (vue)`	1.5 MB	1.6 MB	-6.58%
❌	Memory	`mem server request-churn (vue)`	826 KB	860.6 KB	-4.02%
❌	Simulation	`client-async-pipeline navigation loop (react)`	104.5 ms	108.6 ms	-3.75%
❌	Memory	`mem server error-paths unmatched (solid)`	573.6 KB	595.9 KB	-3.74%
❌	Simulation	`ssr control-flow error 500 (react)`	227.8 ms	235.3 ms	-3.17%
⚡	Memory	`mem server error-paths unmatched (react)`	789.7 KB	588.3 KB	+34.25%
⚡	Memory	`mem server error-paths redirect (vue)`	467.9 KB	411.3 KB	+13.77%
⚡	Memory	`mem server error-paths not-found (solid)`	623.9 KB	564.6 KB	+10.49%
⚡	Memory	`mem client unique-location-churn (vue)`	575.3 KB	528.6 KB	+8.82%
⚡	Simulation	`ssr global-mw document (vue)`	970.4 ms	906.8 ms	+7.01%
⚡	Memory	`mem server peak-large-page (solid)`	1.1 MB	1 MB	+6.63%
⚡	Memory	`mem server error-paths not-found (react)`	457.9 KB	436 KB	+5.03%
⚡	Memory	`mem server aborted-requests (vue)`	983.8 KB	950.5 KB	+3.5%
⚡	Memory	`mem server error-paths unmatched (vue)`	597.9 KB	579.9 KB	+3.1%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.

_{Comparing opencode/pr-8084-solid-vue-test-port (1f477f8) with opencode/retained-pending-architecture-v5 (425bab3)}

* fix(router-core): preserve pending UI across retained routes * fix(router-core): harden pending session ownership * fix(router): align pending presentation across Solid and Vue (#8097) fix(router): align pending presentation across frameworks * changesets * test: align hydration fake timers

fix(router): align pending presentation across frameworks
1f477f8

github-actionsBot added package: router-core package: solid-router package: vue-router labels Aug 18, 2026

Sheraff merged commit 121fe64 into opencode/retained-pending-architecture-v5Aug 18, 2026
25 of 26 checks passed

Sheraff deleted the opencode/pr-8084-solid-vue-test-port branch August 18, 2026 07:55

Navigation Menu

Uh oh!

Uh oh!

fix(router): align pending presentation across Solid and Vue - #8097

fix(router): align pending presentation across Solid and Vue#8097
Sheraff merged 1 commit into
opencode/retained-pending-architecture-v5from
opencode/pr-8084-solid-vue-test-port

Sheraff commented Aug 18, 2026

Uh oh!

coderabbitaiBot commented Aug 18, 2026

Review skipped

Uh oh!

nx-cloudBot commented Aug 18, 2026•
edited
Loading

Uh oh!

github-actionsBot commented Aug 18, 2026

Uh oh!

pkg-pr-newBot commented Aug 18, 2026

Uh oh!

github-actionsBot commented Aug 18, 2026

Uh oh!

codspeed-hqBot commented Aug 18, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Uh oh!

Conversation

Sheraff commented Aug 18, 2026

Summary

Testing

Uh oh!

coderabbitaiBot commented Aug 18, 2026

Review skipped

Uh oh!

nx-cloudBot commented Aug 18, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actionsBot commented Aug 18, 2026

🚀 Changeset Version Preview

🟩 Patch bumps

Uh oh!

pkg-pr-newBot commented Aug 18, 2026

Uh oh!

github-actionsBot commented Aug 18, 2026

Bundle Size Benchmarks

Uh oh!

codspeed-hqBot commented Aug 18, 2026

Merging this PR will regress 6 benchmarks

Performance Changes

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

nx-cloudBot commented Aug 18, 2026•
edited
Loading