perf(router-core): optimize buildLocation path resolution - #8108

Merged
Sheraff merged 4 commits into
mainfrom
perf/build-location-path-resolution
Aug 19, 2026
Merged

perf(router-core): optimize buildLocation path resolution#8108
Sheraff merged 4 commits into
mainfrom
perf/build-location-path-resolution

Conversation

@Sheraff

@SheraffSheraff commented Aug 18, 2026•
edited
Loading

Copy link
Copy Markdown
Collaborator

Inspired by #8086

Summary

  • return normalized absolute paths directly from resolvePath, avoiding the LRU, split, join, and final regex pass
  • resolve relative buildLocation destinations in one pass instead of first resolving from against .
  • normalize relative bases containing repeated slashes before parent traversal, preserving cases such as /a//b + ../../c -> /c
  • reuse inherited params until an updater or route stringifier can mutate them, then clone lazily
  • preserve repeated-slash and trailing-slash behavior and protect current params from mutating stringifiers

The production diff is ten net lines: path.ts adds 14 and router.ts removes 4. Benchmark source is intentionally not included in this PR.

Benchmark setup

The benchmark constructs a real RouterCore with a 1,200-route tree and executes 1,200 buildLocation() calls per sample. Production, browser-conditioned bundles run in Node with createMemoryHistory and RouterCore configured as server. Baseline (main) and the final candidate were bundled separately, loaded into the same process, and alternated for 1,500-2,000 samples. Each case was also rerun with candidate/baseline construction order reversed.

Times below are median milliseconds per 1,200 buildLocation() calls. Arrows are baseline -> candidate.

Important wins

repeated static absolute destinations
baseline first: 0.858 -> 0.669 ms (-22.0%)
candidate first: 0.898 -> 0.722 ms (-19.7%)
repeated relative destinations
baseline first: 1.048 -> 0.897 ms (-14.4%)
candidate first: 1.058 -> 0.909 ms (-14.0%)
1,200 unique relative destinations (sustained LRU misses)
baseline first: 1.619 -> 1.542 ms (-4.7%)
candidate first: 1.619 -> 1.557 ms (-3.8%)
1,200 mixed unique destinations
baseline first: 1.972 -> 1.010 ms (-48.8%)
candidate first: 1.872 -> 1.009 ms (-46.1%)

The mixed-unique case intentionally exceeds the 1,000-entry resolve-path LRU. The large win comes from one-off absolute destinations bypassing the LRU instead of evicting useful relative-path entries. It is a large-app/cache-pressure case, not the expected gain for every navigation.

The unique-relative case also exceeds the LRU and measures the final redundant cleanPath scan on every relative cache miss. Repeated relative paths that remain cached do not receive this additional 3.8-4.7% gain.

The repository Vitest benchmark, rerun in production mode in separate processes, also improved:

1,200 unique mixed destinations: 2.418 -> 1.507 ms (37.7% faster)
1,200 repeated mixed destinations: 1.623 -> 1.459 ms (10.1% faster)
1,200 double-slash destinations: 2.450 -> 1.568 ms (36.0% faster)

Neutral case

repeated dynamic-param destinations
baseline first: 2.133 -> 2.130 ms (-0.1%)
candidate first: 2.091 -> 2.083 ms (-0.4%)

The sub-percent differences should be treated as no demonstrated change.

Bundle size

react-router.minimal compared with main:

gzip: 85,828 -> 85,844 bytes (+16)
raw: 268,920 -> 269,051 bytes (+131)
brotli: 74,750 -> 74,768 bytes (+18)

Test plan

  • pnpm nx run @tanstack/router-core:test:unit -- tests/path.test.ts tests/build-location.test.ts tests/optional-path-params.test.ts tests/optional-path-params-clean.test.ts
  • pnpm nx run @tanstack/router-core:test:types
  • pnpm nx run @tanstack/router-core:test:eslint
  • react-router.minimal bundle-size comparison

Summary by CodeRabbit

  • Bug Fixes

    • Improved URL path resolution by normalizing duplicate slashes.
    • Applied trailing-slash settings consistently to absolute paths.
    • Preserved route parameters when generating locations, preventing accidental mutation of current route state.
    • Ensured inherited parameters remain unchanged when building or updating locations.

  • Tests

    • Added coverage for repeated slashes and trailing-slash modes.
    • Added regression coverage for parameter formatting without state mutation.

@nx-cloud

nx-cloudBot commented Aug 18, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

View your CI Pipeline Execution ↗ for commit 4b877ce

CommandStatusDurationResult
nx affected --targets=test:eslint,test:unit,tes...✅ Succeeded11m 21sView ↗
nx run-many --target=build --exclude=examples/*...✅ Succeeded2m 2sView ↗

☁️ Nx Cloud last updated this comment at 2026-08-19 00:41:27 UTC

@github-actions

github-actionsBot commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

🚀 Changeset Version Preview

No changeset entries found. Merging this PR will not cause a version bump for any packages.

@coderabbitai

coderabbitaiBot commented Aug 18, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: d6b04845-ac67-41eb-a775-c0dde2600356

📥 Commits

Reviewing files that changed from the base of the PR and between 6bcaf84 and 4b877ce.

📒 Files selected for processing (2)
  • packages/router-core/src/path.ts
  • packages/router-core/tests/path.test.ts

Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.

📝 Walkthrough

Walkthrough

Router-core now normalizes duplicate slashes during path resolution and applies trailing-slash settings directly. Location construction and parameter updates preserve shared route parameters during stringification and updates.

Changes

Router path and parameter handling

Layer / File(s)Summary
Normalize destination paths
packages/router-core/src/path.ts, packages/router-core/src/router.ts, packages/router-core/tests/path.test.ts, packages/router-core/tests/build-location.test.ts		resolvePath normalizes repeated slashes and handles absolute destinations according to trailingSlash. Router code passes destinations directly to the resolver. Tests cover traversal, base paths, and trailing-slash modes.
Preserve route parameters
packages/router-core/src/router.ts, packages/router-core/tests/build-location.test.ts		Location construction and updater-based parameter changes avoid mutating shared parameter objects. Regression coverage verifies parameter immutability during stringification.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Merge Risk:⚪ Minimal · up to 4b877

This PR optimizes router path resolution and parameter handling without introducing a known user-facing correctness or production risk; no actionable merge-blocking risk remains beyond normal checks and review.

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly summarizes the primary change: optimizing buildLocation path resolution.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch perf/build-location-path-resolution

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

chatgpt-codex-connector[bot]
chatgpt-codex-connectorBot reviewed Aug 18, 2026
View reviewed changes

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:931e51a568

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadpackages/router-core/src/router.ts
@github-actions

github-actionsBot commented Aug 18, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

Bundle Size Benchmarks

  • Commit: a837a5f77928
  • Measured at: 2026-08-19T00:31:21.976Z
  • Baseline source: history:a78f2af5b49b
  • Dashboard: bundle-size history

The following scenarios have bundle-size changes compared with the baseline:

ScenarioCurrent (gzip)Delta vs baselineInitial gzipRawBrotliTrend
react-router.minimal83.83 KiB+16 B (+0.02%)83.70 KiB262.75 KiB73.02 KiB▃▃██▆▃▃▂▂▁▁▂
react-router.full87.33 KiB+20 B (+0.02%)87.20 KiB274.46 KiB76.10 KiB▄▅██▅▂▂▂▂▁▁▃
solid-router.minimal33.19 KiB+10 B (+0.03%)33.06 KiB96.61 KiB30.01 KiB████▅▁▁▁▁▇▇█
solid-router.full38.04 KiB+21 B (+0.05%)37.91 KiB111.25 KiB34.26 KiB▅▅▅▅▄▁▁▁▁▇▇█
vue-router.minimal49.53 KiB+28 B (+0.06%)49.41 KiB138.65 KiB44.70 KiB▇███▄▁▁▁▁▁▁▃
vue-router.full55.14 KiB+23 B (+0.04%)55.01 KiB156.85 KiB49.60 KiB████▄▁▁▁▁▁▁▃
react-start.minimal96.73 KiB+29 B (+0.03%)96.59 KiB305.00 KiB83.72 KiB▄▄▇▇▄▂▂▁▁▆▆█
react-start.deferred-hydration97.45 KiB+23 B (+0.02%)96.61 KiB306.36 KiB84.40 KiB▃▃██▅▃▃▁▁▆▆█
react-start.full99.89 KiB+24 B (+0.02%)99.75 KiB314.74 KiB86.58 KiB▄▄██▄▁▁▁▁▆▆▇
react-start.rsbuild.minimal100.06 KiB+47 B (+0.05%)99.89 KiB315.36 KiB86.26 KiB▁▁▆▆▅▂▂▁▁▅▅█
react-start.rsbuild.minimal-iife100.47 KiB+47 B (+0.05%)100.30 KiB316.30 KiB86.70 KiB▁▁▆▆▆▂▂▁▁▅▅█
react-start.rsbuild.full103.38 KiB+46 B (+0.04%)103.21 KiB325.45 KiB89.02 KiB▁▁▆▆▆▂▂▁▁▅▅█
solid-start.minimal46.03 KiB+15 B (+0.03%)45.90 KiB137.71 KiB40.95 KiB▅▅▅▅▃▁▁▁▁▇▇█
solid-start.deferred-hydration49.11 KiB+14 B (+0.03%)45.97 KiB145.17 KiB43.74 KiB▅▅▅▅▃▁▁▁▁▇▇█
solid-start.full51.10 KiB+10 B (+0.02%)50.97 KiB153.09 KiB45.37 KiB▅▅▅▅▃▁▁▁▁▇▇█
vue-start.minimal65.67 KiB+22 B (+0.03%)65.55 KiB189.49 KiB58.47 KiB▅▆▆▆▄▁▁▁▁▇▇█
vue-start.full69.50 KiB+26 B (+0.04%)69.37 KiB201.80 KiB61.78 KiB▅▅▅▅▃▁▁▁▁▇▇█

Current gzip tracks all emitted client JS chunks. Initial gzip tracks only the entry/import graph. Trend sparkline is historical current gzip ending with this PR measurement; lower is better.

@pkg-pr-new

pkg-pr-newBot commented Aug 18, 2026•
edited
Loading

Copy link
Copy Markdown
More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/@tanstack/arktype-adapter@8108

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@8108

@tanstack/eslint-plugin-start

npm i https://pkg.pr.new/@tanstack/eslint-plugin-start@8108

@tanstack/history

npm i https://pkg.pr.new/@tanstack/history@8108

@tanstack/nitro-v2-vite-plugin

npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@8108

@tanstack/react-router

npm i https://pkg.pr.new/@tanstack/react-router@8108

@tanstack/react-router-devtools

npm i https://pkg.pr.new/@tanstack/react-router-devtools@8108

@tanstack/react-router-ssr-query

npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@8108

@tanstack/react-start

npm i https://pkg.pr.new/@tanstack/react-start@8108

@tanstack/react-start-client

npm i https://pkg.pr.new/@tanstack/react-start-client@8108

@tanstack/react-start-rsc

npm i https://pkg.pr.new/@tanstack/react-start-rsc@8108

@tanstack/react-start-server

npm i https://pkg.pr.new/@tanstack/react-start-server@8108

@tanstack/router-cli

npm i https://pkg.pr.new/@tanstack/router-cli@8108

@tanstack/router-core

npm i https://pkg.pr.new/@tanstack/router-core@8108

@tanstack/router-devtools

npm i https://pkg.pr.new/@tanstack/router-devtools@8108

@tanstack/router-devtools-core

npm i https://pkg.pr.new/@tanstack/router-devtools-core@8108

@tanstack/router-generator

npm i https://pkg.pr.new/@tanstack/router-generator@8108

@tanstack/router-plugin

npm i https://pkg.pr.new/@tanstack/router-plugin@8108

@tanstack/router-ssr-query-core

npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@8108

@tanstack/router-utils

npm i https://pkg.pr.new/@tanstack/router-utils@8108

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/@tanstack/router-vite-plugin@8108

@tanstack/solid-router

npm i https://pkg.pr.new/@tanstack/solid-router@8108

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/@tanstack/solid-router-devtools@8108

@tanstack/solid-router-ssr-query

npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@8108

@tanstack/solid-start

npm i https://pkg.pr.new/@tanstack/solid-start@8108

@tanstack/solid-start-client

npm i https://pkg.pr.new/@tanstack/solid-start-client@8108

@tanstack/solid-start-server

npm i https://pkg.pr.new/@tanstack/solid-start-server@8108

@tanstack/start-client-core

npm i https://pkg.pr.new/@tanstack/start-client-core@8108

@tanstack/start-fn-stubs

npm i https://pkg.pr.new/@tanstack/start-fn-stubs@8108

@tanstack/start-plugin-core

npm i https://pkg.pr.new/@tanstack/start-plugin-core@8108

@tanstack/start-server-core

npm i https://pkg.pr.new/@tanstack/start-server-core@8108

@tanstack/start-static-server-functions

npm i https://pkg.pr.new/@tanstack/start-static-server-functions@8108

@tanstack/start-storage-context

npm i https://pkg.pr.new/@tanstack/start-storage-context@8108

@tanstack/valibot-adapter

npm i https://pkg.pr.new/@tanstack/valibot-adapter@8108

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/@tanstack/virtual-file-routes@8108

@tanstack/vue-router

npm i https://pkg.pr.new/@tanstack/vue-router@8108

@tanstack/vue-router-devtools

npm i https://pkg.pr.new/@tanstack/vue-router-devtools@8108

@tanstack/vue-router-ssr-query

npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@8108

@tanstack/vue-start

npm i https://pkg.pr.new/@tanstack/vue-start@8108

@tanstack/vue-start-client

npm i https://pkg.pr.new/@tanstack/vue-start-client@8108

@tanstack/vue-start-server

npm i https://pkg.pr.new/@tanstack/vue-start-server@8108

@tanstack/zod-adapter

npm i https://pkg.pr.new/@tanstack/zod-adapter@8108

commit: 4b877ce

@codspeed-hq

codspeed-hqBot commented Aug 18, 2026•
edited
Loading

Copy link
Copy Markdown

Merging this PR will regress 0 benchmarks

⚠️Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 14 improved benchmarks
❌ 2 (👁 2) regressed benchmarks
✅ 164 untouched benchmarks

Performance Changes

ModeBenchmarkBASEHEADEfficiency
⚡Memorymem server error-paths redirect (solid)998.3 KB382.2 KB×2.6
⚡Memorymem client unique-location-churn (solid)419.3 KB266.2 KB+57.5%
⚡Memorymem client interrupted-navigations (react)294.5 KB213.8 KB+37.74%
⚡Memorymem client interrupted-navigations (solid)288.4 KB213.7 KB+34.97%
⚡Memorymem client navigation-churn (solid)819 KB631.7 KB+29.66%
⚡Memorymem client interrupted-navigations (vue)455.1 KB357.6 KB+27.25%
⚡Memorymem server error-paths unmatched (react)550.6 KB433.2 KB+27.09%
⚡Memorymem client unique-location-churn (vue)559.5 KB447.3 KB+25.08%
⚡Memorymem server error-paths not-found (react)481.8 KB406.5 KB+18.52%
⚡Memorymem server error-paths redirect (react)318.7 KB288.6 KB+10.44%
⚡Memorymem server request-churn (vue)868.6 KB816.6 KB+6.37%
⚡Memorymem server aborted-requests (vue)1,069.1 KB1,019.6 KB+4.86%
⚡Simulationssr dehydrate plain control (react)354.2 ms341.4 ms+3.74%
⚡Memorymem client navigation-churn (vue)1.5 MB1.5 MB+3.5%
👁Memorymem server error-paths redirect (vue)401 KB423.6 KB-5.33%
👁Memorymem server serialization-payload (vue)4.3 MB4.5 MB-5.44%

Tip

Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.

Comparing perf/build-location-path-resolution (4b877ce) with main (a78f2af)

Open in CodSpeed

@Sheraff
Sheraff merged commit 6be202c into mainAug 19, 2026
37 of 38 checks passed
@Sheraff
Sheraff deleted the perf/build-location-path-resolution branch August 19, 2026 09:24
This was referenced Aug 19, 2026
Merged
Closed
@github-actionsgithub-actionsBot mentioned this pull request Aug 19, 2026
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chatgpt-codex-connectorchatgpt-codex-connector[bot]chatgpt-codex-connector[bot] left review comments

Assignees

No one assigned

Labels

package: router-core

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Sheraff
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
perf(router-core): optimize buildLocation path resolution - #8108
Merged
Sheraff merged 4 commits into
mainfrom 
perf/build-location-path-resolution
Aug 19, 2026
Merged
perf(router-core): optimize buildLocation path resolution#8108
Sheraff merged 4 commits into
mainfrom 
perf/build-location-path-resolution
Conversation
@Sheraff
@SheraffSheraff
commented
Aug 18, 2026•

edited

Loading

Copy link


Copy Markdown

Collaborator
Inspired by #8086
Summary
  • return normalized absolute paths directly from resolvePath, avoiding the LRU, split, join, and final regex pass
  • resolve relative buildLocation destinations in one pass instead of first resolving from against .
  • normalize relative bases containing repeated slashes before parent traversal, preserving cases such as /a//b + ../../c -> /c
  • reuse inherited params until an updater or route stringifier can mutate them, then clone lazily
  • preserve repeated-slash and trailing-slash behavior and protect current params from mutating stringifiers
The production diff is ten net lines: path.ts adds 14 and router.ts removes 4. Benchmark source is intentionally not included in this PR.
Benchmark setup
The benchmark constructs a real RouterCore with a 1,200-route tree and executes 1,200 buildLocation() calls per sample. Production, browser-conditioned bundles run in Node with createMemoryHistory and RouterCore configured as server. Baseline (main) and the final candidate were bundled separately, loaded into the same process, and alternated for 1,500-2,000 samples. Each case was also rerun with candidate/baseline construction order reversed.
Times below are median milliseconds per 1,200 buildLocation() calls. Arrows are baseline -> candidate.
Important wins
repeated static absolute destinations
baseline first: 0.858 -> 0.669 ms (-22.0%)
candidate first: 0.898 -> 0.722 ms (-19.7%)
repeated relative destinations
baseline first: 1.048 -> 0.897 ms (-14.4%)
candidate first: 1.058 -> 0.909 ms (-14.0%)
1,200 unique relative destinations (sustained LRU misses)
baseline first: 1.619 -> 1.542 ms (-4.7%)
candidate first: 1.619 -> 1.557 ms (-3.8%)
1,200 mixed unique destinations
baseline first: 1.972 -> 1.010 ms (-48.8%)
candidate first: 1.872 -> 1.009 ms (-46.1%)

The mixed-unique case intentionally exceeds the 1,000-entry resolve-path LRU. The large win comes from one-off absolute destinations bypassing the LRU instead of evicting useful relative-path entries. It is a large-app/cache-pressure case, not the expected gain for every navigation.
The unique-relative case also exceeds the LRU and measures the final redundant cleanPath scan on every relative cache miss. Repeated relative paths that remain cached do not receive this additional 3.8-4.7% gain.
The repository Vitest benchmark, rerun in production mode in separate processes, also improved:
1,200 unique mixed destinations: 2.418 -> 1.507 ms (37.7% faster)
1,200 repeated mixed destinations: 1.623 -> 1.459 ms (10.1% faster)
1,200 double-slash destinations: 2.450 -> 1.568 ms (36.0% faster)

Neutral case
repeated dynamic-param destinations
baseline first: 2.133 -> 2.130 ms (-0.1%)
candidate first: 2.091 -> 2.083 ms (-0.4%)

The sub-percent differences should be treated as no demonstrated change.
Bundle size
react-router.minimal compared with main:
gzip: 85,828 -> 85,844 bytes (+16)
raw: 268,920 -> 269,051 bytes (+131)
brotli: 74,750 -> 74,768 bytes (+18)

Test plan
  • pnpm nx run @tanstack/router-core:test:unit -- tests/path.test.ts tests/build-location.test.ts tests/optional-path-params.test.ts tests/optional-path-params-clean.test.ts
  • pnpm nx run @tanstack/router-core:test:types
  • pnpm nx run @tanstack/router-core:test:eslint
  • react-router.minimal bundle-size comparison
Summary by CodeRabbit
  • Bug Fixes
    • Improved URL path resolution by normalizing duplicate slashes.
    • Applied trailing-slash settings consistently to absolute paths.
    • Preserved route parameters when generating locations, preventing accidental mutation of current route state.
    • Ensured inherited parameters remain unchanged when building or updating locations.
  • Tests
    • Added coverage for repeated slashes and trailing-slash modes.
    • Added regression coverage for parameter formatting without state mutation.
@nx-cloud
nx-cloudBot
commented
Aug 18, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
View your CI Pipeline Execution ↗ for commit 4b877ce
CommandStatusDurationResult
nx affected --targets=test:eslint,test:unit,tes...✅ Succeeded11m 21sView ↗
nx run-many --target=build --exclude=examples/*...✅ Succeeded2m 2sView ↗
☁️ Nx Cloud last updated this comment at 2026-08-19 00:41:27 UTC
@github-actions
github-actionsBot
commented
Aug 18, 2026

Copy link


Copy Markdown

Contributor
🚀 Changeset Version Preview
No changeset entries found. Merging this PR will not cause a version bump for any packages.
@coderabbitai
coderabbitaiBot
commented
Aug 18, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Review Change Stack
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: d6b04845-ac67-41eb-a775-c0dde2600356
📥 Commits
Reviewing files that changed from the base of the PR and between 6bcaf84 and 4b877ce.
📒 Files selected for processing (2)
  • packages/router-core/src/path.ts
  • packages/router-core/tests/path.test.ts
Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.
📝 Walkthrough
Walkthrough
Router-core now normalizes duplicate slashes during path resolution and applies trailing-slash settings directly. Location construction and parameter updates preserve shared route parameters during stringification and updates.
Changes
Router path and parameter handling
Layer / File(s)Summary
Normalize destination paths
packages/router-core/src/path.ts, packages/router-core/src/router.ts, packages/router-core/tests/path.test.ts, packages/router-core/tests/build-location.test.ts		resolvePath normalizes repeated slashes and handles absolute destinations according to trailingSlash. Router code passes destinations directly to the resolver. Tests cover traversal, base paths, and trailing-slash modes.
Preserve route parameters
packages/router-core/src/router.ts, packages/router-core/tests/build-location.test.ts		Location construction and updater-based parameter changes avoid mutating shared parameter objects. Regression coverage verifies parameter immutability during stringification.
Estimated code review effort: 3 (Moderate) | ~20 minutes
Merge Risk:⚪ Minimal · up to 4b877
This PR optimizes router path resolution and parameter handling without introducing a known user-facing correctness or production risk; no actionable merge-blocking risk remains beyond normal checks and review.
Possibly related PRs
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly summarizes the primary change: optimizing buildLocation path resolution.
✨ Finishing Touches
📝 Generate docstrings
  •  Create stacked PR
  •  Commit on current branch
🧪 Generate unit tests (beta)
  •  Create PR with unit tests
  •  Commit unit tests in branch perf/build-location-path-resolution
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands.
chatgpt-codex-connector[bot]
chatgpt-codex-connectorBot
reviewed
Aug 18, 2026
View reviewed changes
@chatgpt-codex-connectorchatgpt-codex-connectorBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit:931e51a568
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Comment threadpackages/router-core/src/router.ts
@github-actions
github-actionsBot
commented
Aug 18, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Bundle Size Benchmarks
  • Commit: a837a5f77928
  • Measured at: 2026-08-19T00:31:21.976Z
  • Baseline source: history:a78f2af5b49b
  • Dashboard: bundle-size history
The following scenarios have bundle-size changes compared with the baseline:
ScenarioCurrent (gzip)Delta vs baselineInitial gzipRawBrotliTrend
react-router.minimal83.83 KiB+16 B (+0.02%)83.70 KiB262.75 KiB73.02 KiB▃▃██▆▃▃▂▂▁▁▂
react-router.full87.33 KiB+20 B (+0.02%)87.20 KiB274.46 KiB76.10 KiB▄▅██▅▂▂▂▂▁▁▃
solid-router.minimal33.19 KiB+10 B (+0.03%)33.06 KiB96.61 KiB30.01 KiB████▅▁▁▁▁▇▇█
solid-router.full38.04 KiB+21 B (+0.05%)37.91 KiB111.25 KiB34.26 KiB▅▅▅▅▄▁▁▁▁▇▇█
vue-router.minimal49.53 KiB+28 B (+0.06%)49.41 KiB138.65 KiB44.70 KiB▇███▄▁▁▁▁▁▁▃
vue-router.full55.14 KiB+23 B (+0.04%)55.01 KiB156.85 KiB49.60 KiB████▄▁▁▁▁▁▁▃
react-start.minimal96.73 KiB+29 B (+0.03%)96.59 KiB305.00 KiB83.72 KiB▄▄▇▇▄▂▂▁▁▆▆█
react-start.deferred-hydration97.45 KiB+23 B (+0.02%)96.61 KiB306.36 KiB84.40 KiB▃▃██▅▃▃▁▁▆▆█
react-start.full99.89 KiB+24 B (+0.02%)99.75 KiB314.74 KiB86.58 KiB▄▄██▄▁▁▁▁▆▆▇
react-start.rsbuild.minimal100.06 KiB+47 B (+0.05%)99.89 KiB315.36 KiB86.26 KiB▁▁▆▆▅▂▂▁▁▅▅█
react-start.rsbuild.minimal-iife100.47 KiB+47 B (+0.05%)100.30 KiB316.30 KiB86.70 KiB▁▁▆▆▆▂▂▁▁▅▅█
react-start.rsbuild.full103.38 KiB+46 B (+0.04%)103.21 KiB325.45 KiB89.02 KiB▁▁▆▆▆▂▂▁▁▅▅█
solid-start.minimal46.03 KiB+15 B (+0.03%)45.90 KiB137.71 KiB40.95 KiB▅▅▅▅▃▁▁▁▁▇▇█
solid-start.deferred-hydration49.11 KiB+14 B (+0.03%)45.97 KiB145.17 KiB43.74 KiB▅▅▅▅▃▁▁▁▁▇▇█
solid-start.full51.10 KiB+10 B (+0.02%)50.97 KiB153.09 KiB45.37 KiB▅▅▅▅▃▁▁▁▁▇▇█
vue-start.minimal65.67 KiB+22 B (+0.03%)65.55 KiB189.49 KiB58.47 KiB▅▆▆▆▄▁▁▁▁▇▇█
vue-start.full69.50 KiB+26 B (+0.04%)69.37 KiB201.80 KiB61.78 KiB▅▅▅▅▃▁▁▁▁▇▇█
Current gzip tracks all emitted client JS chunks. Initial gzip tracks only the entry/import graph. Trend sparkline is historical current gzip ending with this PR measurement; lower is better.
@pkg-pr-new
pkg-pr-newBot
commented
Aug 18, 2026•

edited

Loading

Copy link


Copy Markdown

More templates
@tanstack/arktype-adapter
npm i https://pkg.pr.new/@tanstack/arktype-adapter@8108

@tanstack/eslint-plugin-router
npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@8108

@tanstack/eslint-plugin-start
npm i https://pkg.pr.new/@tanstack/eslint-plugin-start@8108

@tanstack/history
npm i https://pkg.pr.new/@tanstack/history@8108

@tanstack/nitro-v2-vite-plugin
npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@8108

@tanstack/react-router
npm i https://pkg.pr.new/@tanstack/react-router@8108

@tanstack/react-router-devtools
npm i https://pkg.pr.new/@tanstack/react-router-devtools@8108

@tanstack/react-router-ssr-query
npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@8108

@tanstack/react-start
npm i https://pkg.pr.new/@tanstack/react-start@8108

@tanstack/react-start-client
npm i https://pkg.pr.new/@tanstack/react-start-client@8108

@tanstack/react-start-rsc
npm i https://pkg.pr.new/@tanstack/react-start-rsc@8108

@tanstack/react-start-server
npm i https://pkg.pr.new/@tanstack/react-start-server@8108

@tanstack/router-cli
npm i https://pkg.pr.new/@tanstack/router-cli@8108

@tanstack/router-core
npm i https://pkg.pr.new/@tanstack/router-core@8108

@tanstack/router-devtools
npm i https://pkg.pr.new/@tanstack/router-devtools@8108

@tanstack/router-devtools-core
npm i https://pkg.pr.new/@tanstack/router-devtools-core@8108

@tanstack/router-generator
npm i https://pkg.pr.new/@tanstack/router-generator@8108

@tanstack/router-plugin
npm i https://pkg.pr.new/@tanstack/router-plugin@8108

@tanstack/router-ssr-query-core
npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@8108

@tanstack/router-utils
npm i https://pkg.pr.new/@tanstack/router-utils@8108

@tanstack/router-vite-plugin
npm i https://pkg.pr.new/@tanstack/router-vite-plugin@8108

@tanstack/solid-router
npm i https://pkg.pr.new/@tanstack/solid-router@8108

@tanstack/solid-router-devtools
npm i https://pkg.pr.new/@tanstack/solid-router-devtools@8108

@tanstack/solid-router-ssr-query
npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@8108

@tanstack/solid-start
npm i https://pkg.pr.new/@tanstack/solid-start@8108

@tanstack/solid-start-client
npm i https://pkg.pr.new/@tanstack/solid-start-client@8108

@tanstack/solid-start-server
npm i https://pkg.pr.new/@tanstack/solid-start-server@8108

@tanstack/start-client-core
npm i https://pkg.pr.new/@tanstack/start-client-core@8108

@tanstack/start-fn-stubs
npm i https://pkg.pr.new/@tanstack/start-fn-stubs@8108

@tanstack/start-plugin-core
npm i https://pkg.pr.new/@tanstack/start-plugin-core@8108

@tanstack/start-server-core
npm i https://pkg.pr.new/@tanstack/start-server-core@8108

@tanstack/start-static-server-functions
npm i https://pkg.pr.new/@tanstack/start-static-server-functions@8108

@tanstack/start-storage-context
npm i https://pkg.pr.new/@tanstack/start-storage-context@8108

@tanstack/valibot-adapter
npm i https://pkg.pr.new/@tanstack/valibot-adapter@8108

@tanstack/virtual-file-routes
npm i https://pkg.pr.new/@tanstack/virtual-file-routes@8108

@tanstack/vue-router
npm i https://pkg.pr.new/@tanstack/vue-router@8108

@tanstack/vue-router-devtools
npm i https://pkg.pr.new/@tanstack/vue-router-devtools@8108

@tanstack/vue-router-ssr-query
npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@8108

@tanstack/vue-start
npm i https://pkg.pr.new/@tanstack/vue-start@8108

@tanstack/vue-start-client
npm i https://pkg.pr.new/@tanstack/vue-start-client@8108

@tanstack/vue-start-server
npm i https://pkg.pr.new/@tanstack/vue-start-server@8108

@tanstack/zod-adapter
npm i https://pkg.pr.new/@tanstack/zod-adapter@8108

commit: 4b877ce
@codspeed-hq
codspeed-hqBot
commented
Aug 18, 2026•

edited

Loading

Copy link


Copy Markdown

Merging this PR will regress 0 benchmarks
⚠️Different runtime environments detected
Some benchmarks with significant performance changes were compared across different runtime environments,

which may affect the accuracy of the results.
Open the report in CodSpeed to investigate
⚡ 14 improved benchmarks
❌ 2 (👁 2) regressed benchmarks
✅ 164 untouched benchmarks
Performance Changes
ModeBenchmarkBASEHEADEfficiency
⚡Memorymem server error-paths redirect (solid)998.3 KB382.2 KB×2.6
⚡Memorymem client unique-location-churn (solid)419.3 KB266.2 KB+57.5%
⚡Memorymem client interrupted-navigations (react)294.5 KB213.8 KB+37.74%
⚡Memorymem client interrupted-navigations (solid)288.4 KB213.7 KB+34.97%
⚡Memorymem client navigation-churn (solid)819 KB631.7 KB+29.66%
⚡Memorymem client interrupted-navigations (vue)455.1 KB357.6 KB+27.25%
⚡Memorymem server error-paths unmatched (react)550.6 KB433.2 KB+27.09%
⚡Memorymem client unique-location-churn (vue)559.5 KB447.3 KB+25.08%
⚡Memorymem server error-paths not-found (react)481.8 KB406.5 KB+18.52%
⚡Memorymem server error-paths redirect (react)318.7 KB288.6 KB+10.44%
⚡Memorymem server request-churn (vue)868.6 KB816.6 KB+6.37%
⚡Memorymem server aborted-requests (vue)1,069.1 KB1,019.6 KB+4.86%
⚡Simulationssr dehydrate plain control (react)354.2 ms341.4 ms+3.74%
⚡Memorymem client navigation-churn (vue)1.5 MB1.5 MB+3.5%
👁Memorymem server error-paths redirect (vue)401 KB423.6 KB-5.33%
👁Memorymem server serialization-payload (vue)4.3 MB4.5 MB-5.44%
Tip
Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.
Comparing perf/build-location-path-resolution (4b877ce) with main (a78f2af)
Open in CodSpeed
@Sheraff
Sheraff
merged commit 6be202c
into
mainAug 19, 2026

37 of 38 checks passed

@Sheraff
Sheraff
deleted the

perf/build-location-path-resolution

branch
August 19, 2026 09:24

This was referenced Aug 19, 2026
 Merged

 Closed

@github-actionsgithub-actionsBot
mentioned this pull request
Aug 19, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@chatgpt-codex-connectorchatgpt-codex-connector[bot]chatgpt-codex-connector[bot] left review comments

Assignees


No one assigned


Labels

package: router-core

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@Sheraff

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
perf(router-core): optimize buildLocation path resolution - #8108
Merged
Sheraff merged 4 commits into
mainfrom 
perf/build-location-path-resolution
Aug 19, 2026
Merged
perf(router-core): optimize buildLocation path resolution#8108
Sheraff merged 4 commits into
mainfrom 
perf/build-location-path-resolution
Conversation
@Sheraff
@SheraffSheraff
commented
Aug 18, 2026•

edited

Loading

Copy link


Copy Markdown

Collaborator
Inspired by #8086
Summary
  • return normalized absolute paths directly from resolvePath, avoiding the LRU, split, join, and final regex pass
  • resolve relative buildLocation destinations in one pass instead of first resolving from against .
  • normalize relative bases containing repeated slashes before parent traversal, preserving cases such as /a//b + ../../c -> /c
  • reuse inherited params until an updater or route stringifier can mutate them, then clone lazily
  • preserve repeated-slash and trailing-slash behavior and protect current params from mutating stringifiers
The production diff is ten net lines: path.ts adds 14 and router.ts removes 4. Benchmark source is intentionally not included in this PR.
Benchmark setup
The benchmark constructs a real RouterCore with a 1,200-route tree and executes 1,200 buildLocation() calls per sample. Production, browser-conditioned bundles run in Node with createMemoryHistory and RouterCore configured as server. Baseline (main) and the final candidate were bundled separately, loaded into the same process, and alternated for 1,500-2,000 samples. Each case was also rerun with candidate/baseline construction order reversed.
Times below are median milliseconds per 1,200 buildLocation() calls. Arrows are baseline -> candidate.
Important wins
repeated static absolute destinations
baseline first: 0.858 -> 0.669 ms (-22.0%)
candidate first: 0.898 -> 0.722 ms (-19.7%)
repeated relative destinations
baseline first: 1.048 -> 0.897 ms (-14.4%)
candidate first: 1.058 -> 0.909 ms (-14.0%)
1,200 unique relative destinations (sustained LRU misses)
baseline first: 1.619 -> 1.542 ms (-4.7%)
candidate first: 1.619 -> 1.557 ms (-3.8%)
1,200 mixed unique destinations
baseline first: 1.972 -> 1.010 ms (-48.8%)
candidate first: 1.872 -> 1.009 ms (-46.1%)

The mixed-unique case intentionally exceeds the 1,000-entry resolve-path LRU. The large win comes from one-off absolute destinations bypassing the LRU instead of evicting useful relative-path entries. It is a large-app/cache-pressure case, not the expected gain for every navigation.
The unique-relative case also exceeds the LRU and measures the final redundant cleanPath scan on every relative cache miss. Repeated relative paths that remain cached do not receive this additional 3.8-4.7% gain.
The repository Vitest benchmark, rerun in production mode in separate processes, also improved:
1,200 unique mixed destinations: 2.418 -> 1.507 ms (37.7% faster)
1,200 repeated mixed destinations: 1.623 -> 1.459 ms (10.1% faster)
1,200 double-slash destinations: 2.450 -> 1.568 ms (36.0% faster)

Neutral case
repeated dynamic-param destinations
baseline first: 2.133 -> 2.130 ms (-0.1%)
candidate first: 2.091 -> 2.083 ms (-0.4%)

The sub-percent differences should be treated as no demonstrated change.
Bundle size
react-router.minimal compared with main:
gzip: 85,828 -> 85,844 bytes (+16)
raw: 268,920 -> 269,051 bytes (+131)
brotli: 74,750 -> 74,768 bytes (+18)

Test plan
  • pnpm nx run @tanstack/router-core:test:unit -- tests/path.test.ts tests/build-location.test.ts tests/optional-path-params.test.ts tests/optional-path-params-clean.test.ts
  • pnpm nx run @tanstack/router-core:test:types
  • pnpm nx run @tanstack/router-core:test:eslint
  • react-router.minimal bundle-size comparison
Summary by CodeRabbit
  • Bug Fixes
    • Improved URL path resolution by normalizing duplicate slashes.
    • Applied trailing-slash settings consistently to absolute paths.
    • Preserved route parameters when generating locations, preventing accidental mutation of current route state.
    • Ensured inherited parameters remain unchanged when building or updating locations.
  • Tests
    • Added coverage for repeated slashes and trailing-slash modes.
    • Added regression coverage for parameter formatting without state mutation.
@nx-cloud
nx-cloudBot
commented
Aug 18, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
View your CI Pipeline Execution ↗ for commit 4b877ce
CommandStatusDurationResult
nx affected --targets=test:eslint,test:unit,tes...✅ Succeeded11m 21sView ↗
nx run-many --target=build --exclude=examples/*...✅ Succeeded2m 2sView ↗
☁️ Nx Cloud last updated this comment at 2026-08-19 00:41:27 UTC
@github-actions
github-actionsBot
commented
Aug 18, 2026

Copy link


Copy Markdown

Contributor
🚀 Changeset Version Preview
No changeset entries found. Merging this PR will not cause a version bump for any packages.
@coderabbitai
coderabbitaiBot
commented
Aug 18, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Review Change Stack
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: d6b04845-ac67-41eb-a775-c0dde2600356
📥 Commits
Reviewing files that changed from the base of the PR and between 6bcaf84 and 4b877ce.
📒 Files selected for processing (2)
  • packages/router-core/src/path.ts
  • packages/router-core/tests/path.test.ts
Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.
📝 Walkthrough
Walkthrough
Router-core now normalizes duplicate slashes during path resolution and applies trailing-slash settings directly. Location construction and parameter updates preserve shared route parameters during stringification and updates.
Changes
Router path and parameter handling
Layer / File(s)Summary
Normalize destination paths
packages/router-core/src/path.ts, packages/router-core/src/router.ts, packages/router-core/tests/path.test.ts, packages/router-core/tests/build-location.test.ts		resolvePath normalizes repeated slashes and handles absolute destinations according to trailingSlash. Router code passes destinations directly to the resolver. Tests cover traversal, base paths, and trailing-slash modes.
Preserve route parameters
packages/router-core/src/router.ts, packages/router-core/tests/build-location.test.ts		Location construction and updater-based parameter changes avoid mutating shared parameter objects. Regression coverage verifies parameter immutability during stringification.
Estimated code review effort: 3 (Moderate) | ~20 minutes
Merge Risk:⚪ Minimal · up to 4b877
This PR optimizes router path resolution and parameter handling without introducing a known user-facing correctness or production risk; no actionable merge-blocking risk remains beyond normal checks and review.
Possibly related PRs
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly summarizes the primary change: optimizing buildLocation path resolution.
✨ Finishing Touches
📝 Generate docstrings
  •  Create stacked PR
  •  Commit on current branch
🧪 Generate unit tests (beta)
  •  Create PR with unit tests
  •  Commit unit tests in branch perf/build-location-path-resolution
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands.
chatgpt-codex-connector[bot]
chatgpt-codex-connectorBot
reviewed
Aug 18, 2026
View reviewed changes
@chatgpt-codex-connectorchatgpt-codex-connectorBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit:931e51a568
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Comment threadpackages/router-core/src/router.ts
@github-actions
github-actionsBot
commented
Aug 18, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Bundle Size Benchmarks
  • Commit: a837a5f77928
  • Measured at: 2026-08-19T00:31:21.976Z
  • Baseline source: history:a78f2af5b49b
  • Dashboard: bundle-size history
The following scenarios have bundle-size changes compared with the baseline:
ScenarioCurrent (gzip)Delta vs baselineInitial gzipRawBrotliTrend
react-router.minimal83.83 KiB+16 B (+0.02%)83.70 KiB262.75 KiB73.02 KiB▃▃██▆▃▃▂▂▁▁▂
react-router.full87.33 KiB+20 B (+0.02%)87.20 KiB274.46 KiB76.10 KiB▄▅██▅▂▂▂▂▁▁▃
solid-router.minimal33.19 KiB+10 B (+0.03%)33.06 KiB96.61 KiB30.01 KiB████▅▁▁▁▁▇▇█
solid-router.full38.04 KiB+21 B (+0.05%)37.91 KiB111.25 KiB34.26 KiB▅▅▅▅▄▁▁▁▁▇▇█
vue-router.minimal49.53 KiB+28 B (+0.06%)49.41 KiB138.65 KiB44.70 KiB▇███▄▁▁▁▁▁▁▃
vue-router.full55.14 KiB+23 B (+0.04%)55.01 KiB156.85 KiB49.60 KiB████▄▁▁▁▁▁▁▃
react-start.minimal96.73 KiB+29 B (+0.03%)96.59 KiB305.00 KiB83.72 KiB▄▄▇▇▄▂▂▁▁▆▆█
react-start.deferred-hydration97.45 KiB+23 B (+0.02%)96.61 KiB306.36 KiB84.40 KiB▃▃██▅▃▃▁▁▆▆█
react-start.full99.89 KiB+24 B (+0.02%)99.75 KiB314.74 KiB86.58 KiB▄▄██▄▁▁▁▁▆▆▇
react-start.rsbuild.minimal100.06 KiB+47 B (+0.05%)99.89 KiB315.36 KiB86.26 KiB▁▁▆▆▅▂▂▁▁▅▅█
react-start.rsbuild.minimal-iife100.47 KiB+47 B (+0.05%)100.30 KiB316.30 KiB86.70 KiB▁▁▆▆▆▂▂▁▁▅▅█
react-start.rsbuild.full103.38 KiB+46 B (+0.04%)103.21 KiB325.45 KiB89.02 KiB▁▁▆▆▆▂▂▁▁▅▅█
solid-start.minimal46.03 KiB+15 B (+0.03%)45.90 KiB137.71 KiB40.95 KiB▅▅▅▅▃▁▁▁▁▇▇█
solid-start.deferred-hydration49.11 KiB+14 B (+0.03%)45.97 KiB145.17 KiB43.74 KiB▅▅▅▅▃▁▁▁▁▇▇█
solid-start.full51.10 KiB+10 B (+0.02%)50.97 KiB153.09 KiB45.37 KiB▅▅▅▅▃▁▁▁▁▇▇█
vue-start.minimal65.67 KiB+22 B (+0.03%)65.55 KiB189.49 KiB58.47 KiB▅▆▆▆▄▁▁▁▁▇▇█
vue-start.full69.50 KiB+26 B (+0.04%)69.37 KiB201.80 KiB61.78 KiB▅▅▅▅▃▁▁▁▁▇▇█
Current gzip tracks all emitted client JS chunks. Initial gzip tracks only the entry/import graph. Trend sparkline is historical current gzip ending with this PR measurement; lower is better.
@pkg-pr-new
pkg-pr-newBot
commented
Aug 18, 2026•

edited

Loading

Copy link


Copy Markdown

More templates
@tanstack/arktype-adapter
npm i https://pkg.pr.new/@tanstack/arktype-adapter@8108

@tanstack/eslint-plugin-router
npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@8108

@tanstack/eslint-plugin-start
npm i https://pkg.pr.new/@tanstack/eslint-plugin-start@8108

@tanstack/history
npm i https://pkg.pr.new/@tanstack/history@8108

@tanstack/nitro-v2-vite-plugin
npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@8108

@tanstack/react-router
npm i https://pkg.pr.new/@tanstack/react-router@8108

@tanstack/react-router-devtools
npm i https://pkg.pr.new/@tanstack/react-router-devtools@8108

@tanstack/react-router-ssr-query
npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@8108

@tanstack/react-start
npm i https://pkg.pr.new/@tanstack/react-start@8108

@tanstack/react-start-client
npm i https://pkg.pr.new/@tanstack/react-start-client@8108

@tanstack/react-start-rsc
npm i https://pkg.pr.new/@tanstack/react-start-rsc@8108

@tanstack/react-start-server
npm i https://pkg.pr.new/@tanstack/react-start-server@8108

@tanstack/router-cli
npm i https://pkg.pr.new/@tanstack/router-cli@8108

@tanstack/router-core
npm i https://pkg.pr.new/@tanstack/router-core@8108

@tanstack/router-devtools
npm i https://pkg.pr.new/@tanstack/router-devtools@8108

@tanstack/router-devtools-core
npm i https://pkg.pr.new/@tanstack/router-devtools-core@8108

@tanstack/router-generator
npm i https://pkg.pr.new/@tanstack/router-generator@8108

@tanstack/router-plugin
npm i https://pkg.pr.new/@tanstack/router-plugin@8108

@tanstack/router-ssr-query-core
npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@8108

@tanstack/router-utils
npm i https://pkg.pr.new/@tanstack/router-utils@8108

@tanstack/router-vite-plugin
npm i https://pkg.pr.new/@tanstack/router-vite-plugin@8108

@tanstack/solid-router
npm i https://pkg.pr.new/@tanstack/solid-router@8108

@tanstack/solid-router-devtools
npm i https://pkg.pr.new/@tanstack/solid-router-devtools@8108

@tanstack/solid-router-ssr-query
npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@8108

@tanstack/solid-start
npm i https://pkg.pr.new/@tanstack/solid-start@8108

@tanstack/solid-start-client
npm i https://pkg.pr.new/@tanstack/solid-start-client@8108

@tanstack/solid-start-server
npm i https://pkg.pr.new/@tanstack/solid-start-server@8108

@tanstack/start-client-core
npm i https://pkg.pr.new/@tanstack/start-client-core@8108

@tanstack/start-fn-stubs
npm i https://pkg.pr.new/@tanstack/start-fn-stubs@8108

@tanstack/start-plugin-core
npm i https://pkg.pr.new/@tanstack/start-plugin-core@8108

@tanstack/start-server-core
npm i https://pkg.pr.new/@tanstack/start-server-core@8108

@tanstack/start-static-server-functions
npm i https://pkg.pr.new/@tanstack/start-static-server-functions@8108

@tanstack/start-storage-context
npm i https://pkg.pr.new/@tanstack/start-storage-context@8108

@tanstack/valibot-adapter
npm i https://pkg.pr.new/@tanstack/valibot-adapter@8108

@tanstack/virtual-file-routes
npm i https://pkg.pr.new/@tanstack/virtual-file-routes@8108

@tanstack/vue-router
npm i https://pkg.pr.new/@tanstack/vue-router@8108

@tanstack/vue-router-devtools
npm i https://pkg.pr.new/@tanstack/vue-router-devtools@8108

@tanstack/vue-router-ssr-query
npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@8108

@tanstack/vue-start
npm i https://pkg.pr.new/@tanstack/vue-start@8108

@tanstack/vue-start-client
npm i https://pkg.pr.new/@tanstack/vue-start-client@8108

@tanstack/vue-start-server
npm i https://pkg.pr.new/@tanstack/vue-start-server@8108

@tanstack/zod-adapter
npm i https://pkg.pr.new/@tanstack/zod-adapter@8108

commit: 4b877ce
@codspeed-hq
codspeed-hqBot
commented
Aug 18, 2026•

edited

Loading

Copy link


Copy Markdown

Merging this PR will regress 0 benchmarks
⚠️Different runtime environments detected
Some benchmarks with significant performance changes were compared across different runtime environments,

which may affect the accuracy of the results.
Open the report in CodSpeed to investigate
⚡ 14 improved benchmarks
❌ 2 (👁 2) regressed benchmarks
✅ 164 untouched benchmarks
Performance Changes
ModeBenchmarkBASEHEADEfficiency
⚡Memorymem server error-paths redirect (solid)998.3 KB382.2 KB×2.6
⚡Memorymem client unique-location-churn (solid)419.3 KB266.2 KB+57.5%
⚡Memorymem client interrupted-navigations (react)294.5 KB213.8 KB+37.74%
⚡Memorymem client interrupted-navigations (solid)288.4 KB213.7 KB+34.97%
⚡Memorymem client navigation-churn (solid)819 KB631.7 KB+29.66%
⚡Memorymem client interrupted-navigations (vue)455.1 KB357.6 KB+27.25%
⚡Memorymem server error-paths unmatched (react)550.6 KB433.2 KB+27.09%
⚡Memorymem client unique-location-churn (vue)559.5 KB447.3 KB+25.08%
⚡Memorymem server error-paths not-found (react)481.8 KB406.5 KB+18.52%
⚡Memorymem server error-paths redirect (react)318.7 KB288.6 KB+10.44%
⚡Memorymem server request-churn (vue)868.6 KB816.6 KB+6.37%
⚡Memorymem server aborted-requests (vue)1,069.1 KB1,019.6 KB+4.86%
⚡Simulationssr dehydrate plain control (react)354.2 ms341.4 ms+3.74%
⚡Memorymem client navigation-churn (vue)1.5 MB1.5 MB+3.5%
👁Memorymem server error-paths redirect (vue)401 KB423.6 KB-5.33%
👁Memorymem server serialization-payload (vue)4.3 MB4.5 MB-5.44%
Tip
Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.
Comparing perf/build-location-path-resolution (4b877ce) with main (a78f2af)
Open in CodSpeed
@Sheraff
Sheraff
merged commit 6be202c
into
mainAug 19, 2026

37 of 38 checks passed

@Sheraff
Sheraff
deleted the

perf/build-location-path-resolution

branch
August 19, 2026 09:24

This was referenced Aug 19, 2026
 Merged

 Closed

@github-actionsgithub-actionsBot
mentioned this pull request
Aug 19, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@chatgpt-codex-connectorchatgpt-codex-connector[bot]chatgpt-codex-connector[bot] left review comments

Assignees


No one assigned


Labels

package: router-core

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@Sheraff

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
perf(router-core): optimize buildLocation path resolution - #8108
Merged
Sheraff merged 4 commits into
mainfrom 
perf/build-location-path-resolution
Aug 19, 2026
Merged
perf(router-core): optimize buildLocation path resolution#8108
Sheraff merged 4 commits into
mainfrom 
perf/build-location-path-resolution
Conversation
@Sheraff
@SheraffSheraff
commented
Aug 18, 2026•

edited

Loading

Copy link


Copy Markdown

Collaborator
Inspired by #8086
Summary
  • return normalized absolute paths directly from resolvePath, avoiding the LRU, split, join, and final regex pass
  • resolve relative buildLocation destinations in one pass instead of first resolving from against .
  • normalize relative bases containing repeated slashes before parent traversal, preserving cases such as /a//b + ../../c -> /c
  • reuse inherited params until an updater or route stringifier can mutate them, then clone lazily
  • preserve repeated-slash and trailing-slash behavior and protect current params from mutating stringifiers
The production diff is ten net lines: path.ts adds 14 and router.ts removes 4. Benchmark source is intentionally not included in this PR.
Benchmark setup
The benchmark constructs a real RouterCore with a 1,200-route tree and executes 1,200 buildLocation() calls per sample. Production, browser-conditioned bundles run in Node with createMemoryHistory and RouterCore configured as server. Baseline (main) and the final candidate were bundled separately, loaded into the same process, and alternated for 1,500-2,000 samples. Each case was also rerun with candidate/baseline construction order reversed.
Times below are median milliseconds per 1,200 buildLocation() calls. Arrows are baseline -> candidate.
Important wins
repeated static absolute destinations
baseline first: 0.858 -> 0.669 ms (-22.0%)
candidate first: 0.898 -> 0.722 ms (-19.7%)
repeated relative destinations
baseline first: 1.048 -> 0.897 ms (-14.4%)
candidate first: 1.058 -> 0.909 ms (-14.0%)
1,200 unique relative destinations (sustained LRU misses)
baseline first: 1.619 -> 1.542 ms (-4.7%)
candidate first: 1.619 -> 1.557 ms (-3.8%)
1,200 mixed unique destinations
baseline first: 1.972 -> 1.010 ms (-48.8%)
candidate first: 1.872 -> 1.009 ms (-46.1%)

The mixed-unique case intentionally exceeds the 1,000-entry resolve-path LRU. The large win comes from one-off absolute destinations bypassing the LRU instead of evicting useful relative-path entries. It is a large-app/cache-pressure case, not the expected gain for every navigation.
The unique-relative case also exceeds the LRU and measures the final redundant cleanPath scan on every relative cache miss. Repeated relative paths that remain cached do not receive this additional 3.8-4.7% gain.
The repository Vitest benchmark, rerun in production mode in separate processes, also improved:
1,200 unique mixed destinations: 2.418 -> 1.507 ms (37.7% faster)
1,200 repeated mixed destinations: 1.623 -> 1.459 ms (10.1% faster)
1,200 double-slash destinations: 2.450 -> 1.568 ms (36.0% faster)

Neutral case
repeated dynamic-param destinations
baseline first: 2.133 -> 2.130 ms (-0.1%)
candidate first: 2.091 -> 2.083 ms (-0.4%)

The sub-percent differences should be treated as no demonstrated change.
Bundle size
react-router.minimal compared with main:
gzip: 85,828 -> 85,844 bytes (+16)
raw: 268,920 -> 269,051 bytes (+131)
brotli: 74,750 -> 74,768 bytes (+18)

Test plan
  • pnpm nx run @tanstack/router-core:test:unit -- tests/path.test.ts tests/build-location.test.ts tests/optional-path-params.test.ts tests/optional-path-params-clean.test.ts
  • pnpm nx run @tanstack/router-core:test:types
  • pnpm nx run @tanstack/router-core:test:eslint
  • react-router.minimal bundle-size comparison
Summary by CodeRabbit
  • Bug Fixes
    • Improved URL path resolution by normalizing duplicate slashes.
    • Applied trailing-slash settings consistently to absolute paths.
    • Preserved route parameters when generating locations, preventing accidental mutation of current route state.
    • Ensured inherited parameters remain unchanged when building or updating locations.
  • Tests
    • Added coverage for repeated slashes and trailing-slash modes.
    • Added regression coverage for parameter formatting without state mutation.
@nx-cloud
nx-cloudBot
commented
Aug 18, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
View your CI Pipeline Execution ↗ for commit 4b877ce
CommandStatusDurationResult
nx affected --targets=test:eslint,test:unit,tes...✅ Succeeded11m 21sView ↗
nx run-many --target=build --exclude=examples/*...✅ Succeeded2m 2sView ↗
☁️ Nx Cloud last updated this comment at 2026-08-19 00:41:27 UTC
@github-actions
github-actionsBot
commented
Aug 18, 2026

Copy link


Copy Markdown

Contributor
🚀 Changeset Version Preview
No changeset entries found. Merging this PR will not cause a version bump for any packages.
@coderabbitai
coderabbitaiBot
commented
Aug 18, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Review Change Stack
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: d6b04845-ac67-41eb-a775-c0dde2600356
📥 Commits
Reviewing files that changed from the base of the PR and between 6bcaf84 and 4b877ce.
📒 Files selected for processing (2)
  • packages/router-core/src/path.ts
  • packages/router-core/tests/path.test.ts
Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.
📝 Walkthrough
Walkthrough
Router-core now normalizes duplicate slashes during path resolution and applies trailing-slash settings directly. Location construction and parameter updates preserve shared route parameters during stringification and updates.
Changes
Router path and parameter handling
Layer / File(s)Summary
Normalize destination paths
packages/router-core/src/path.ts, packages/router-core/src/router.ts, packages/router-core/tests/path.test.ts, packages/router-core/tests/build-location.test.ts		resolvePath normalizes repeated slashes and handles absolute destinations according to trailingSlash. Router code passes destinations directly to the resolver. Tests cover traversal, base paths, and trailing-slash modes.
Preserve route parameters
packages/router-core/src/router.ts, packages/router-core/tests/build-location.test.ts		Location construction and updater-based parameter changes avoid mutating shared parameter objects. Regression coverage verifies parameter immutability during stringification.
Estimated code review effort: 3 (Moderate) | ~20 minutes
Merge Risk:⚪ Minimal · up to 4b877
This PR optimizes router path resolution and parameter handling without introducing a known user-facing correctness or production risk; no actionable merge-blocking risk remains beyond normal checks and review.
Possibly related PRs
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly summarizes the primary change: optimizing buildLocation path resolution.
✨ Finishing Touches
📝 Generate docstrings
  •  Create stacked PR
  •  Commit on current branch
🧪 Generate unit tests (beta)
  •  Create PR with unit tests
  •  Commit unit tests in branch perf/build-location-path-resolution
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands.
chatgpt-codex-connector[bot]
chatgpt-codex-connectorBot
reviewed
Aug 18, 2026
View reviewed changes
@chatgpt-codex-connectorchatgpt-codex-connectorBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit:931e51a568
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Comment threadpackages/router-core/src/router.ts
@github-actions
github-actionsBot
commented
Aug 18, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Bundle Size Benchmarks
  • Commit: a837a5f77928
  • Measured at: 2026-08-19T00:31:21.976Z
  • Baseline source: history:a78f2af5b49b
  • Dashboard: bundle-size history
The following scenarios have bundle-size changes compared with the baseline:
ScenarioCurrent (gzip)Delta vs baselineInitial gzipRawBrotliTrend
react-router.minimal83.83 KiB+16 B (+0.02%)83.70 KiB262.75 KiB73.02 KiB▃▃██▆▃▃▂▂▁▁▂
react-router.full87.33 KiB+20 B (+0.02%)87.20 KiB274.46 KiB76.10 KiB▄▅██▅▂▂▂▂▁▁▃
solid-router.minimal33.19 KiB+10 B (+0.03%)33.06 KiB96.61 KiB30.01 KiB████▅▁▁▁▁▇▇█
solid-router.full38.04 KiB+21 B (+0.05%)37.91 KiB111.25 KiB34.26 KiB▅▅▅▅▄▁▁▁▁▇▇█
vue-router.minimal49.53 KiB+28 B (+0.06%)49.41 KiB138.65 KiB44.70 KiB▇███▄▁▁▁▁▁▁▃
vue-router.full55.14 KiB+23 B (+0.04%)55.01 KiB156.85 KiB49.60 KiB████▄▁▁▁▁▁▁▃
react-start.minimal96.73 KiB+29 B (+0.03%)96.59 KiB305.00 KiB83.72 KiB▄▄▇▇▄▂▂▁▁▆▆█
react-start.deferred-hydration97.45 KiB+23 B (+0.02%)96.61 KiB306.36 KiB84.40 KiB▃▃██▅▃▃▁▁▆▆█
react-start.full99.89 KiB+24 B (+0.02%)99.75 KiB314.74 KiB86.58 KiB▄▄██▄▁▁▁▁▆▆▇
react-start.rsbuild.minimal100.06 KiB+47 B (+0.05%)99.89 KiB315.36 KiB86.26 KiB▁▁▆▆▅▂▂▁▁▅▅█
react-start.rsbuild.minimal-iife100.47 KiB+47 B (+0.05%)100.30 KiB316.30 KiB86.70 KiB▁▁▆▆▆▂▂▁▁▅▅█
react-start.rsbuild.full103.38 KiB+46 B (+0.04%)103.21 KiB325.45 KiB89.02 KiB▁▁▆▆▆▂▂▁▁▅▅█
solid-start.minimal46.03 KiB+15 B (+0.03%)45.90 KiB137.71 KiB40.95 KiB▅▅▅▅▃▁▁▁▁▇▇█
solid-start.deferred-hydration49.11 KiB+14 B (+0.03%)45.97 KiB145.17 KiB43.74 KiB▅▅▅▅▃▁▁▁▁▇▇█
solid-start.full51.10 KiB+10 B (+0.02%)50.97 KiB153.09 KiB45.37 KiB▅▅▅▅▃▁▁▁▁▇▇█
vue-start.minimal65.67 KiB+22 B (+0.03%)65.55 KiB189.49 KiB58.47 KiB▅▆▆▆▄▁▁▁▁▇▇█
vue-start.full69.50 KiB+26 B (+0.04%)69.37 KiB201.80 KiB61.78 KiB▅▅▅▅▃▁▁▁▁▇▇█
Current gzip tracks all emitted client JS chunks. Initial gzip tracks only the entry/import graph. Trend sparkline is historical current gzip ending with this PR measurement; lower is better.
@pkg-pr-new
pkg-pr-newBot
commented
Aug 18, 2026•

edited

Loading

Copy link


Copy Markdown

More templates
@tanstack/arktype-adapter
npm i https://pkg.pr.new/@tanstack/arktype-adapter@8108

@tanstack/eslint-plugin-router
npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@8108

@tanstack/eslint-plugin-start
npm i https://pkg.pr.new/@tanstack/eslint-plugin-start@8108

@tanstack/history
npm i https://pkg.pr.new/@tanstack/history@8108

@tanstack/nitro-v2-vite-plugin
npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@8108

@tanstack/react-router
npm i https://pkg.pr.new/@tanstack/react-router@8108

@tanstack/react-router-devtools
npm i https://pkg.pr.new/@tanstack/react-router-devtools@8108

@tanstack/react-router-ssr-query
npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@8108

@tanstack/react-start
npm i https://pkg.pr.new/@tanstack/react-start@8108

@tanstack/react-start-client
npm i https://pkg.pr.new/@tanstack/react-start-client@8108

@tanstack/react-start-rsc
npm i https://pkg.pr.new/@tanstack/react-start-rsc@8108

@tanstack/react-start-server
npm i https://pkg.pr.new/@tanstack/react-start-server@8108

@tanstack/router-cli
npm i https://pkg.pr.new/@tanstack/router-cli@8108

@tanstack/router-core
npm i https://pkg.pr.new/@tanstack/router-core@8108

@tanstack/router-devtools
npm i https://pkg.pr.new/@tanstack/router-devtools@8108

@tanstack/router-devtools-core
npm i https://pkg.pr.new/@tanstack/router-devtools-core@8108

@tanstack/router-generator
npm i https://pkg.pr.new/@tanstack/router-generator@8108

@tanstack/router-plugin
npm i https://pkg.pr.new/@tanstack/router-plugin@8108

@tanstack/router-ssr-query-core
npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@8108

@tanstack/router-utils
npm i https://pkg.pr.new/@tanstack/router-utils@8108

@tanstack/router-vite-plugin
npm i https://pkg.pr.new/@tanstack/router-vite-plugin@8108

@tanstack/solid-router
npm i https://pkg.pr.new/@tanstack/solid-router@8108

@tanstack/solid-router-devtools
npm i https://pkg.pr.new/@tanstack/solid-router-devtools@8108

@tanstack/solid-router-ssr-query
npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@8108

@tanstack/solid-start
npm i https://pkg.pr.new/@tanstack/solid-start@8108

@tanstack/solid-start-client
npm i https://pkg.pr.new/@tanstack/solid-start-client@8108

@tanstack/solid-start-server
npm i https://pkg.pr.new/@tanstack/solid-start-server@8108

@tanstack/start-client-core
npm i https://pkg.pr.new/@tanstack/start-client-core@8108

@tanstack/start-fn-stubs
npm i https://pkg.pr.new/@tanstack/start-fn-stubs@8108

@tanstack/start-plugin-core
npm i https://pkg.pr.new/@tanstack/start-plugin-core@8108

@tanstack/start-server-core
npm i https://pkg.pr.new/@tanstack/start-server-core@8108

@tanstack/start-static-server-functions
npm i https://pkg.pr.new/@tanstack/start-static-server-functions@8108

@tanstack/start-storage-context
npm i https://pkg.pr.new/@tanstack/start-storage-context@8108

@tanstack/valibot-adapter
npm i https://pkg.pr.new/@tanstack/valibot-adapter@8108

@tanstack/virtual-file-routes
npm i https://pkg.pr.new/@tanstack/virtual-file-routes@8108

@tanstack/vue-router
npm i https://pkg.pr.new/@tanstack/vue-router@8108

@tanstack/vue-router-devtools
npm i https://pkg.pr.new/@tanstack/vue-router-devtools@8108

@tanstack/vue-router-ssr-query
npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@8108

@tanstack/vue-start
npm i https://pkg.pr.new/@tanstack/vue-start@8108

@tanstack/vue-start-client
npm i https://pkg.pr.new/@tanstack/vue-start-client@8108

@tanstack/vue-start-server
npm i https://pkg.pr.new/@tanstack/vue-start-server@8108

@tanstack/zod-adapter
npm i https://pkg.pr.new/@tanstack/zod-adapter@8108

commit: 4b877ce
@codspeed-hq
codspeed-hqBot
commented
Aug 18, 2026•

edited

Loading

Copy link


Copy Markdown

Merging this PR will regress 0 benchmarks
⚠️Different runtime environments detected
Some benchmarks with significant performance changes were compared across different runtime environments,

which may affect the accuracy of the results.
Open the report in CodSpeed to investigate
⚡ 14 improved benchmarks
❌ 2 (👁 2) regressed benchmarks
✅ 164 untouched benchmarks
Performance Changes
ModeBenchmarkBASEHEADEfficiency
⚡Memorymem server error-paths redirect (solid)998.3 KB382.2 KB×2.6
⚡Memorymem client unique-location-churn (solid)419.3 KB266.2 KB+57.5%
⚡Memorymem client interrupted-navigations (react)294.5 KB213.8 KB+37.74%
⚡Memorymem client interrupted-navigations (solid)288.4 KB213.7 KB+34.97%
⚡Memorymem client navigation-churn (solid)819 KB631.7 KB+29.66%
⚡Memorymem client interrupted-navigations (vue)455.1 KB357.6 KB+27.25%
⚡Memorymem server error-paths unmatched (react)550.6 KB433.2 KB+27.09%
⚡Memorymem client unique-location-churn (vue)559.5 KB447.3 KB+25.08%
⚡Memorymem server error-paths not-found (react)481.8 KB406.5 KB+18.52%
⚡Memorymem server error-paths redirect (react)318.7 KB288.6 KB+10.44%
⚡Memorymem server request-churn (vue)868.6 KB816.6 KB+6.37%
⚡Memorymem server aborted-requests (vue)1,069.1 KB1,019.6 KB+4.86%
⚡Simulationssr dehydrate plain control (react)354.2 ms341.4 ms+3.74%
⚡Memorymem client navigation-churn (vue)1.5 MB1.5 MB+3.5%
👁Memorymem server error-paths redirect (vue)401 KB423.6 KB-5.33%
👁Memorymem server serialization-payload (vue)4.3 MB4.5 MB-5.44%
Tip
Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.
Comparing perf/build-location-path-resolution (4b877ce) with main (a78f2af)
Open in CodSpeed
@Sheraff
Sheraff
merged commit 6be202c
into
mainAug 19, 2026

37 of 38 checks passed

@Sheraff
Sheraff
deleted the

perf/build-location-path-resolution

branch
August 19, 2026 09:24

This was referenced Aug 19, 2026
 Merged

 Closed

@github-actionsgithub-actionsBot
mentioned this pull request
Aug 19, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@chatgpt-codex-connectorchatgpt-codex-connector[bot]chatgpt-codex-connector[bot] left review comments

Assignees


No one assigned


Labels

package: router-core

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@Sheraff

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
perf(router-core): optimize buildLocation path resolution - #8108
Merged
Sheraff merged 4 commits into
mainfrom 
perf/build-location-path-resolution
Aug 19, 2026
Merged
perf(router-core): optimize buildLocation path resolution#8108
Sheraff merged 4 commits into
mainfrom 
perf/build-location-path-resolution
Conversation
@Sheraff
@SheraffSheraff
commented
Aug 18, 2026•

edited

Loading

Copy link


Copy Markdown

Collaborator
Inspired by #8086
Summary
  • return normalized absolute paths directly from resolvePath, avoiding the LRU, split, join, and final regex pass
  • resolve relative buildLocation destinations in one pass instead of first resolving from against .
  • normalize relative bases containing repeated slashes before parent traversal, preserving cases such as /a//b + ../../c -> /c
  • reuse inherited params until an updater or route stringifier can mutate them, then clone lazily
  • preserve repeated-slash and trailing-slash behavior and protect current params from mutating stringifiers
The production diff is ten net lines: path.ts adds 14 and router.ts removes 4. Benchmark source is intentionally not included in this PR.
Benchmark setup
The benchmark constructs a real RouterCore with a 1,200-route tree and executes 1,200 buildLocation() calls per sample. Production, browser-conditioned bundles run in Node with createMemoryHistory and RouterCore configured as server. Baseline (main) and the final candidate were bundled separately, loaded into the same process, and alternated for 1,500-2,000 samples. Each case was also rerun with candidate/baseline construction order reversed.
Times below are median milliseconds per 1,200 buildLocation() calls. Arrows are baseline -> candidate.
Important wins
repeated static absolute destinations
baseline first: 0.858 -> 0.669 ms (-22.0%)
candidate first: 0.898 -> 0.722 ms (-19.7%)
repeated relative destinations
baseline first: 1.048 -> 0.897 ms (-14.4%)
candidate first: 1.058 -> 0.909 ms (-14.0%)
1,200 unique relative destinations (sustained LRU misses)
baseline first: 1.619 -> 1.542 ms (-4.7%)
candidate first: 1.619 -> 1.557 ms (-3.8%)
1,200 mixed unique destinations
baseline first: 1.972 -> 1.010 ms (-48.8%)
candidate first: 1.872 -> 1.009 ms (-46.1%)

The mixed-unique case intentionally exceeds the 1,000-entry resolve-path LRU. The large win comes from one-off absolute destinations bypassing the LRU instead of evicting useful relative-path entries. It is a large-app/cache-pressure case, not the expected gain for every navigation.
The unique-relative case also exceeds the LRU and measures the final redundant cleanPath scan on every relative cache miss. Repeated relative paths that remain cached do not receive this additional 3.8-4.7% gain.
The repository Vitest benchmark, rerun in production mode in separate processes, also improved:
1,200 unique mixed destinations: 2.418 -> 1.507 ms (37.7% faster)
1,200 repeated mixed destinations: 1.623 -> 1.459 ms (10.1% faster)
1,200 double-slash destinations: 2.450 -> 1.568 ms (36.0% faster)

Neutral case
repeated dynamic-param destinations
baseline first: 2.133 -> 2.130 ms (-0.1%)
candidate first: 2.091 -> 2.083 ms (-0.4%)

The sub-percent differences should be treated as no demonstrated change.
Bundle size
react-router.minimal compared with main:
gzip: 85,828 -> 85,844 bytes (+16)
raw: 268,920 -> 269,051 bytes (+131)
brotli: 74,750 -> 74,768 bytes (+18)

Test plan
  • pnpm nx run @tanstack/router-core:test:unit -- tests/path.test.ts tests/build-location.test.ts tests/optional-path-params.test.ts tests/optional-path-params-clean.test.ts
  • pnpm nx run @tanstack/router-core:test:types
  • pnpm nx run @tanstack/router-core:test:eslint
  • react-router.minimal bundle-size comparison
Summary by CodeRabbit
  • Bug Fixes
    • Improved URL path resolution by normalizing duplicate slashes.
    • Applied trailing-slash settings consistently to absolute paths.
    • Preserved route parameters when generating locations, preventing accidental mutation of current route state.
    • Ensured inherited parameters remain unchanged when building or updating locations.
  • Tests
    • Added coverage for repeated slashes and trailing-slash modes.
    • Added regression coverage for parameter formatting without state mutation.
@nx-cloud
nx-cloudBot
commented
Aug 18, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
View your CI Pipeline Execution ↗ for commit 4b877ce
CommandStatusDurationResult
nx affected --targets=test:eslint,test:unit,tes...✅ Succeeded11m 21sView ↗
nx run-many --target=build --exclude=examples/*...✅ Succeeded2m 2sView ↗
☁️ Nx Cloud last updated this comment at 2026-08-19 00:41:27 UTC
@github-actions
github-actionsBot
commented
Aug 18, 2026

Copy link


Copy Markdown

Contributor
🚀 Changeset Version Preview
No changeset entries found. Merging this PR will not cause a version bump for any packages.
@coderabbitai
coderabbitaiBot
commented
Aug 18, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Review Change Stack
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: d6b04845-ac67-41eb-a775-c0dde2600356
📥 Commits
Reviewing files that changed from the base of the PR and between 6bcaf84 and 4b877ce.
📒 Files selected for processing (2)
  • packages/router-core/src/path.ts
  • packages/router-core/tests/path.test.ts
Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.
📝 Walkthrough
Walkthrough
Router-core now normalizes duplicate slashes during path resolution and applies trailing-slash settings directly. Location construction and parameter updates preserve shared route parameters during stringification and updates.
Changes
Router path and parameter handling
Layer / File(s)Summary
Normalize destination paths
packages/router-core/src/path.ts, packages/router-core/src/router.ts, packages/router-core/tests/path.test.ts, packages/router-core/tests/build-location.test.ts		resolvePath normalizes repeated slashes and handles absolute destinations according to trailingSlash. Router code passes destinations directly to the resolver. Tests cover traversal, base paths, and trailing-slash modes.
Preserve route parameters
packages/router-core/src/router.ts, packages/router-core/tests/build-location.test.ts		Location construction and updater-based parameter changes avoid mutating shared parameter objects. Regression coverage verifies parameter immutability during stringification.
Estimated code review effort: 3 (Moderate) | ~20 minutes
Merge Risk:⚪ Minimal · up to 4b877
This PR optimizes router path resolution and parameter handling without introducing a known user-facing correctness or production risk; no actionable merge-blocking risk remains beyond normal checks and review.
Possibly related PRs
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly summarizes the primary change: optimizing buildLocation path resolution.
✨ Finishing Touches
📝 Generate docstrings
  •  Create stacked PR
  •  Commit on current branch
🧪 Generate unit tests (beta)
  •  Create PR with unit tests
  •  Commit unit tests in branch perf/build-location-path-resolution
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands.
chatgpt-codex-connector[bot]
chatgpt-codex-connectorBot
reviewed
Aug 18, 2026
View reviewed changes
@chatgpt-codex-connectorchatgpt-codex-connectorBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit:931e51a568
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Comment threadpackages/router-core/src/router.ts
@github-actions
github-actionsBot
commented
Aug 18, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Bundle Size Benchmarks
  • Commit: a837a5f77928
  • Measured at: 2026-08-19T00:31:21.976Z
  • Baseline source: history:a78f2af5b49b
  • Dashboard: bundle-size history
The following scenarios have bundle-size changes compared with the baseline:
ScenarioCurrent (gzip)Delta vs baselineInitial gzipRawBrotliTrend
react-router.minimal83.83 KiB+16 B (+0.02%)83.70 KiB262.75 KiB73.02 KiB▃▃██▆▃▃▂▂▁▁▂
react-router.full87.33 KiB+20 B (+0.02%)87.20 KiB274.46 KiB76.10 KiB▄▅██▅▂▂▂▂▁▁▃
solid-router.minimal33.19 KiB+10 B (+0.03%)33.06 KiB96.61 KiB30.01 KiB████▅▁▁▁▁▇▇█
solid-router.full38.04 KiB+21 B (+0.05%)37.91 KiB111.25 KiB34.26 KiB▅▅▅▅▄▁▁▁▁▇▇█
vue-router.minimal49.53 KiB+28 B (+0.06%)49.41 KiB138.65 KiB44.70 KiB▇███▄▁▁▁▁▁▁▃
vue-router.full55.14 KiB+23 B (+0.04%)55.01 KiB156.85 KiB49.60 KiB████▄▁▁▁▁▁▁▃
react-start.minimal96.73 KiB+29 B (+0.03%)96.59 KiB305.00 KiB83.72 KiB▄▄▇▇▄▂▂▁▁▆▆█
react-start.deferred-hydration97.45 KiB+23 B (+0.02%)96.61 KiB306.36 KiB84.40 KiB▃▃██▅▃▃▁▁▆▆█
react-start.full99.89 KiB+24 B (+0.02%)99.75 KiB314.74 KiB86.58 KiB▄▄██▄▁▁▁▁▆▆▇
react-start.rsbuild.minimal100.06 KiB+47 B (+0.05%)99.89 KiB315.36 KiB86.26 KiB▁▁▆▆▅▂▂▁▁▅▅█
react-start.rsbuild.minimal-iife100.47 KiB+47 B (+0.05%)100.30 KiB316.30 KiB86.70 KiB▁▁▆▆▆▂▂▁▁▅▅█
react-start.rsbuild.full103.38 KiB+46 B (+0.04%)103.21 KiB325.45 KiB89.02 KiB▁▁▆▆▆▂▂▁▁▅▅█
solid-start.minimal46.03 KiB+15 B (+0.03%)45.90 KiB137.71 KiB40.95 KiB▅▅▅▅▃▁▁▁▁▇▇█
solid-start.deferred-hydration49.11 KiB+14 B (+0.03%)45.97 KiB145.17 KiB43.74 KiB▅▅▅▅▃▁▁▁▁▇▇█
solid-start.full51.10 KiB+10 B (+0.02%)50.97 KiB153.09 KiB45.37 KiB▅▅▅▅▃▁▁▁▁▇▇█
vue-start.minimal65.67 KiB+22 B (+0.03%)65.55 KiB189.49 KiB58.47 KiB▅▆▆▆▄▁▁▁▁▇▇█
vue-start.full69.50 KiB+26 B (+0.04%)69.37 KiB201.80 KiB61.78 KiB▅▅▅▅▃▁▁▁▁▇▇█
Current gzip tracks all emitted client JS chunks. Initial gzip tracks only the entry/import graph. Trend sparkline is historical current gzip ending with this PR measurement; lower is better.
@pkg-pr-new
pkg-pr-newBot
commented
Aug 18, 2026•

edited

Loading

Copy link


Copy Markdown

More templates
@tanstack/arktype-adapter
npm i https://pkg.pr.new/@tanstack/arktype-adapter@8108

@tanstack/eslint-plugin-router
npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@8108

@tanstack/eslint-plugin-start
npm i https://pkg.pr.new/@tanstack/eslint-plugin-start@8108

@tanstack/history
npm i https://pkg.pr.new/@tanstack/history@8108

@tanstack/nitro-v2-vite-plugin
npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@8108

@tanstack/react-router
npm i https://pkg.pr.new/@tanstack/react-router@8108

@tanstack/react-router-devtools
npm i https://pkg.pr.new/@tanstack/react-router-devtools@8108

@tanstack/react-router-ssr-query
npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@8108

@tanstack/react-start
npm i https://pkg.pr.new/@tanstack/react-start@8108

@tanstack/react-start-client
npm i https://pkg.pr.new/@tanstack/react-start-client@8108

@tanstack/react-start-rsc
npm i https://pkg.pr.new/@tanstack/react-start-rsc@8108

@tanstack/react-start-server
npm i https://pkg.pr.new/@tanstack/react-start-server@8108

@tanstack/router-cli
npm i https://pkg.pr.new/@tanstack/router-cli@8108

@tanstack/router-core
npm i https://pkg.pr.new/@tanstack/router-core@8108

@tanstack/router-devtools
npm i https://pkg.pr.new/@tanstack/router-devtools@8108

@tanstack/router-devtools-core
npm i https://pkg.pr.new/@tanstack/router-devtools-core@8108

@tanstack/router-generator
npm i https://pkg.pr.new/@tanstack/router-generator@8108

@tanstack/router-plugin
npm i https://pkg.pr.new/@tanstack/router-plugin@8108

@tanstack/router-ssr-query-core
npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@8108

@tanstack/router-utils
npm i https://pkg.pr.new/@tanstack/router-utils@8108

@tanstack/router-vite-plugin
npm i https://pkg.pr.new/@tanstack/router-vite-plugin@8108

@tanstack/solid-router
npm i https://pkg.pr.new/@tanstack/solid-router@8108

@tanstack/solid-router-devtools
npm i https://pkg.pr.new/@tanstack/solid-router-devtools@8108

@tanstack/solid-router-ssr-query
npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@8108

@tanstack/solid-start
npm i https://pkg.pr.new/@tanstack/solid-start@8108

@tanstack/solid-start-client
npm i https://pkg.pr.new/@tanstack/solid-start-client@8108

@tanstack/solid-start-server
npm i https://pkg.pr.new/@tanstack/solid-start-server@8108

@tanstack/start-client-core
npm i https://pkg.pr.new/@tanstack/start-client-core@8108

@tanstack/start-fn-stubs
npm i https://pkg.pr.new/@tanstack/start-fn-stubs@8108

@tanstack/start-plugin-core
npm i https://pkg.pr.new/@tanstack/start-plugin-core@8108

@tanstack/start-server-core
npm i https://pkg.pr.new/@tanstack/start-server-core@8108

@tanstack/start-static-server-functions
npm i https://pkg.pr.new/@tanstack/start-static-server-functions@8108

@tanstack/start-storage-context
npm i https://pkg.pr.new/@tanstack/start-storage-context@8108

@tanstack/valibot-adapter
npm i https://pkg.pr.new/@tanstack/valibot-adapter@8108

@tanstack/virtual-file-routes
npm i https://pkg.pr.new/@tanstack/virtual-file-routes@8108

@tanstack/vue-router
npm i https://pkg.pr.new/@tanstack/vue-router@8108

@tanstack/vue-router-devtools
npm i https://pkg.pr.new/@tanstack/vue-router-devtools@8108

@tanstack/vue-router-ssr-query
npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@8108

@tanstack/vue-start
npm i https://pkg.pr.new/@tanstack/vue-start@8108

@tanstack/vue-start-client
npm i https://pkg.pr.new/@tanstack/vue-start-client@8108

@tanstack/vue-start-server
npm i https://pkg.pr.new/@tanstack/vue-start-server@8108

@tanstack/zod-adapter
npm i https://pkg.pr.new/@tanstack/zod-adapter@8108

commit: 4b877ce
@codspeed-hq
codspeed-hqBot
commented
Aug 18, 2026•

edited

Loading

Copy link


Copy Markdown

Merging this PR will regress 0 benchmarks
⚠️Different runtime environments detected
Some benchmarks with significant performance changes were compared across different runtime environments,

which may affect the accuracy of the results.
Open the report in CodSpeed to investigate
⚡ 14 improved benchmarks
❌ 2 (👁 2) regressed benchmarks
✅ 164 untouched benchmarks
Performance Changes
ModeBenchmarkBASEHEADEfficiency
⚡Memorymem server error-paths redirect (solid)998.3 KB382.2 KB×2.6
⚡Memorymem client unique-location-churn (solid)419.3 KB266.2 KB+57.5%
⚡Memorymem client interrupted-navigations (react)294.5 KB213.8 KB+37.74%
⚡Memorymem client interrupted-navigations (solid)288.4 KB213.7 KB+34.97%
⚡Memorymem client navigation-churn (solid)819 KB631.7 KB+29.66%
⚡Memorymem client interrupted-navigations (vue)455.1 KB357.6 KB+27.25%
⚡Memorymem server error-paths unmatched (react)550.6 KB433.2 KB+27.09%
⚡Memorymem client unique-location-churn (vue)559.5 KB447.3 KB+25.08%
⚡Memorymem server error-paths not-found (react)481.8 KB406.5 KB+18.52%
⚡Memorymem server error-paths redirect (react)318.7 KB288.6 KB+10.44%
⚡Memorymem server request-churn (vue)868.6 KB816.6 KB+6.37%
⚡Memorymem server aborted-requests (vue)1,069.1 KB1,019.6 KB+4.86%
⚡Simulationssr dehydrate plain control (react)354.2 ms341.4 ms+3.74%
⚡Memorymem client navigation-churn (vue)1.5 MB1.5 MB+3.5%
👁Memorymem server error-paths redirect (vue)401 KB423.6 KB-5.33%
👁Memorymem server serialization-payload (vue)4.3 MB4.5 MB-5.44%
Tip
Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.
Comparing perf/build-location-path-resolution (4b877ce) with main (a78f2af)
Open in CodSpeed
@Sheraff
Sheraff
merged commit 6be202c
into
mainAug 19, 2026

37 of 38 checks passed

@Sheraff
Sheraff
deleted the

perf/build-location-path-resolution

branch
August 19, 2026 09:24

This was referenced Aug 19, 2026
 Merged

 Closed

@github-actionsgithub-actionsBot
mentioned this pull request
Aug 19, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@chatgpt-codex-connectorchatgpt-codex-connector[bot]chatgpt-codex-connector[bot] left review comments

Assignees


No one assigned


Labels

package: router-core

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@Sheraff

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
perf(router-core): optimize buildLocation path resolution - #8108
Merged
Sheraff merged 4 commits into
mainfrom 
perf/build-location-path-resolution
Aug 19, 2026
Merged
perf(router-core): optimize buildLocation path resolution#8108
Sheraff merged 4 commits into
mainfrom 
perf/build-location-path-resolution
Conversation
@Sheraff
@SheraffSheraff
commented
Aug 18, 2026•

edited

Loading

Copy link


Copy Markdown

Collaborator
Inspired by #8086
Summary
  • return normalized absolute paths directly from resolvePath, avoiding the LRU, split, join, and final regex pass
  • resolve relative buildLocation destinations in one pass instead of first resolving from against .
  • normalize relative bases containing repeated slashes before parent traversal, preserving cases such as /a//b + ../../c -> /c
  • reuse inherited params until an updater or route stringifier can mutate them, then clone lazily
  • preserve repeated-slash and trailing-slash behavior and protect current params from mutating stringifiers
The production diff is ten net lines: path.ts adds 14 and router.ts removes 4. Benchmark source is intentionally not included in this PR.
Benchmark setup
The benchmark constructs a real RouterCore with a 1,200-route tree and executes 1,200 buildLocation() calls per sample. Production, browser-conditioned bundles run in Node with createMemoryHistory and RouterCore configured as server. Baseline (main) and the final candidate were bundled separately, loaded into the same process, and alternated for 1,500-2,000 samples. Each case was also rerun with candidate/baseline construction order reversed.
Times below are median milliseconds per 1,200 buildLocation() calls. Arrows are baseline -> candidate.
Important wins
repeated static absolute destinations
baseline first: 0.858 -> 0.669 ms (-22.0%)
candidate first: 0.898 -> 0.722 ms (-19.7%)
repeated relative destinations
baseline first: 1.048 -> 0.897 ms (-14.4%)
candidate first: 1.058 -> 0.909 ms (-14.0%)
1,200 unique relative destinations (sustained LRU misses)
baseline first: 1.619 -> 1.542 ms (-4.7%)
candidate first: 1.619 -> 1.557 ms (-3.8%)
1,200 mixed unique destinations
baseline first: 1.972 -> 1.010 ms (-48.8%)
candidate first: 1.872 -> 1.009 ms (-46.1%)

The mixed-unique case intentionally exceeds the 1,000-entry resolve-path LRU. The large win comes from one-off absolute destinations bypassing the LRU instead of evicting useful relative-path entries. It is a large-app/cache-pressure case, not the expected gain for every navigation.
The unique-relative case also exceeds the LRU and measures the final redundant cleanPath scan on every relative cache miss. Repeated relative paths that remain cached do not receive this additional 3.8-4.7% gain.
The repository Vitest benchmark, rerun in production mode in separate processes, also improved:
1,200 unique mixed destinations: 2.418 -> 1.507 ms (37.7% faster)
1,200 repeated mixed destinations: 1.623 -> 1.459 ms (10.1% faster)
1,200 double-slash destinations: 2.450 -> 1.568 ms (36.0% faster)

Neutral case
repeated dynamic-param destinations
baseline first: 2.133 -> 2.130 ms (-0.1%)
candidate first: 2.091 -> 2.083 ms (-0.4%)

The sub-percent differences should be treated as no demonstrated change.
Bundle size
react-router.minimal compared with main:
gzip: 85,828 -> 85,844 bytes (+16)
raw: 268,920 -> 269,051 bytes (+131)
brotli: 74,750 -> 74,768 bytes (+18)

Test plan
  • pnpm nx run @tanstack/router-core:test:unit -- tests/path.test.ts tests/build-location.test.ts tests/optional-path-params.test.ts tests/optional-path-params-clean.test.ts
  • pnpm nx run @tanstack/router-core:test:types
  • pnpm nx run @tanstack/router-core:test:eslint
  • react-router.minimal bundle-size comparison
Summary by CodeRabbit
  • Bug Fixes
    • Improved URL path resolution by normalizing duplicate slashes.
    • Applied trailing-slash settings consistently to absolute paths.
    • Preserved route parameters when generating locations, preventing accidental mutation of current route state.
    • Ensured inherited parameters remain unchanged when building or updating locations.
  • Tests
    • Added coverage for repeated slashes and trailing-slash modes.
    • Added regression coverage for parameter formatting without state mutation.
@nx-cloud
nx-cloudBot
commented
Aug 18, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
View your CI Pipeline Execution ↗ for commit 4b877ce
CommandStatusDurationResult
nx affected --targets=test:eslint,test:unit,tes...✅ Succeeded11m 21sView ↗
nx run-many --target=build --exclude=examples/*...✅ Succeeded2m 2sView ↗
☁️ Nx Cloud last updated this comment at 2026-08-19 00:41:27 UTC
@github-actions
github-actionsBot
commented
Aug 18, 2026

Copy link


Copy Markdown

Contributor
🚀 Changeset Version Preview
No changeset entries found. Merging this PR will not cause a version bump for any packages.
@coderabbitai
coderabbitaiBot
commented
Aug 18, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Review Change Stack
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: d6b04845-ac67-41eb-a775-c0dde2600356
📥 Commits
Reviewing files that changed from the base of the PR and between 6bcaf84 and 4b877ce.
📒 Files selected for processing (2)
  • packages/router-core/src/path.ts
  • packages/router-core/tests/path.test.ts
Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.
📝 Walkthrough
Walkthrough
Router-core now normalizes duplicate slashes during path resolution and applies trailing-slash settings directly. Location construction and parameter updates preserve shared route parameters during stringification and updates.
Changes
Router path and parameter handling
Layer / File(s)Summary
Normalize destination paths
packages/router-core/src/path.ts, packages/router-core/src/router.ts, packages/router-core/tests/path.test.ts, packages/router-core/tests/build-location.test.ts		resolvePath normalizes repeated slashes and handles absolute destinations according to trailingSlash. Router code passes destinations directly to the resolver. Tests cover traversal, base paths, and trailing-slash modes.
Preserve route parameters
packages/router-core/src/router.ts, packages/router-core/tests/build-location.test.ts		Location construction and updater-based parameter changes avoid mutating shared parameter objects. Regression coverage verifies parameter immutability during stringification.
Estimated code review effort: 3 (Moderate) | ~20 minutes
Merge Risk:⚪ Minimal · up to 4b877
This PR optimizes router path resolution and parameter handling without introducing a known user-facing correctness or production risk; no actionable merge-blocking risk remains beyond normal checks and review.
Possibly related PRs
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly summarizes the primary change: optimizing buildLocation path resolution.
✨ Finishing Touches
📝 Generate docstrings
  •  Create stacked PR
  •  Commit on current branch
🧪 Generate unit tests (beta)
  •  Create PR with unit tests
  •  Commit unit tests in branch perf/build-location-path-resolution
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands.
chatgpt-codex-connector[bot]
chatgpt-codex-connectorBot
reviewed
Aug 18, 2026
View reviewed changes
@chatgpt-codex-connectorchatgpt-codex-connectorBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit:931e51a568
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Comment threadpackages/router-core/src/router.ts
@github-actions
github-actionsBot
commented
Aug 18, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Bundle Size Benchmarks
  • Commit: a837a5f77928
  • Measured at: 2026-08-19T00:31:21.976Z
  • Baseline source: history:a78f2af5b49b
  • Dashboard: bundle-size history
The following scenarios have bundle-size changes compared with the baseline:
ScenarioCurrent (gzip)Delta vs baselineInitial gzipRawBrotliTrend
react-router.minimal83.83 KiB+16 B (+0.02%)83.70 KiB262.75 KiB73.02 KiB▃▃██▆▃▃▂▂▁▁▂
react-router.full87.33 KiB+20 B (+0.02%)87.20 KiB274.46 KiB76.10 KiB▄▅██▅▂▂▂▂▁▁▃
solid-router.minimal33.19 KiB+10 B (+0.03%)33.06 KiB96.61 KiB30.01 KiB████▅▁▁▁▁▇▇█
solid-router.full38.04 KiB+21 B (+0.05%)37.91 KiB111.25 KiB34.26 KiB▅▅▅▅▄▁▁▁▁▇▇█
vue-router.minimal49.53 KiB+28 B (+0.06%)49.41 KiB138.65 KiB44.70 KiB▇███▄▁▁▁▁▁▁▃
vue-router.full55.14 KiB+23 B (+0.04%)55.01 KiB156.85 KiB49.60 KiB████▄▁▁▁▁▁▁▃
react-start.minimal96.73 KiB+29 B (+0.03%)96.59 KiB305.00 KiB83.72 KiB▄▄▇▇▄▂▂▁▁▆▆█
react-start.deferred-hydration97.45 KiB+23 B (+0.02%)96.61 KiB306.36 KiB84.40 KiB▃▃██▅▃▃▁▁▆▆█
react-start.full99.89 KiB+24 B (+0.02%)99.75 KiB314.74 KiB86.58 KiB▄▄██▄▁▁▁▁▆▆▇
react-start.rsbuild.minimal100.06 KiB+47 B (+0.05%)99.89 KiB315.36 KiB86.26 KiB▁▁▆▆▅▂▂▁▁▅▅█
react-start.rsbuild.minimal-iife100.47 KiB+47 B (+0.05%)100.30 KiB316.30 KiB86.70 KiB▁▁▆▆▆▂▂▁▁▅▅█
react-start.rsbuild.full103.38 KiB+46 B (+0.04%)103.21 KiB325.45 KiB89.02 KiB▁▁▆▆▆▂▂▁▁▅▅█
solid-start.minimal46.03 KiB+15 B (+0.03%)45.90 KiB137.71 KiB40.95 KiB▅▅▅▅▃▁▁▁▁▇▇█
solid-start.deferred-hydration49.11 KiB+14 B (+0.03%)45.97 KiB145.17 KiB43.74 KiB▅▅▅▅▃▁▁▁▁▇▇█
solid-start.full51.10 KiB+10 B (+0.02%)50.97 KiB153.09 KiB45.37 KiB▅▅▅▅▃▁▁▁▁▇▇█
vue-start.minimal65.67 KiB+22 B (+0.03%)65.55 KiB189.49 KiB58.47 KiB▅▆▆▆▄▁▁▁▁▇▇█
vue-start.full69.50 KiB+26 B (+0.04%)69.37 KiB201.80 KiB61.78 KiB▅▅▅▅▃▁▁▁▁▇▇█
Current gzip tracks all emitted client JS chunks. Initial gzip tracks only the entry/import graph. Trend sparkline is historical current gzip ending with this PR measurement; lower is better.
@pkg-pr-new
pkg-pr-newBot
commented
Aug 18, 2026•

edited

Loading

Copy link


Copy Markdown

More templates
@tanstack/arktype-adapter
npm i https://pkg.pr.new/@tanstack/arktype-adapter@8108

@tanstack/eslint-plugin-router
npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@8108

@tanstack/eslint-plugin-start
npm i https://pkg.pr.new/@tanstack/eslint-plugin-start@8108

@tanstack/history
npm i https://pkg.pr.new/@tanstack/history@8108

@tanstack/nitro-v2-vite-plugin
npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@8108

@tanstack/react-router
npm i https://pkg.pr.new/@tanstack/react-router@8108

@tanstack/react-router-devtools
npm i https://pkg.pr.new/@tanstack/react-router-devtools@8108

@tanstack/react-router-ssr-query
npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@8108

@tanstack/react-start
npm i https://pkg.pr.new/@tanstack/react-start@8108

@tanstack/react-start-client
npm i https://pkg.pr.new/@tanstack/react-start-client@8108

@tanstack/react-start-rsc
npm i https://pkg.pr.new/@tanstack/react-start-rsc@8108

@tanstack/react-start-server
npm i https://pkg.pr.new/@tanstack/react-start-server@8108

@tanstack/router-cli
npm i https://pkg.pr.new/@tanstack/router-cli@8108

@tanstack/router-core
npm i https://pkg.pr.new/@tanstack/router-core@8108

@tanstack/router-devtools
npm i https://pkg.pr.new/@tanstack/router-devtools@8108

@tanstack/router-devtools-core
npm i https://pkg.pr.new/@tanstack/router-devtools-core@8108

@tanstack/router-generator
npm i https://pkg.pr.new/@tanstack/router-generator@8108

@tanstack/router-plugin
npm i https://pkg.pr.new/@tanstack/router-plugin@8108

@tanstack/router-ssr-query-core
npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@8108

@tanstack/router-utils
npm i https://pkg.pr.new/@tanstack/router-utils@8108

@tanstack/router-vite-plugin
npm i https://pkg.pr.new/@tanstack/router-vite-plugin@8108

@tanstack/solid-router
npm i https://pkg.pr.new/@tanstack/solid-router@8108

@tanstack/solid-router-devtools
npm i https://pkg.pr.new/@tanstack/solid-router-devtools@8108

@tanstack/solid-router-ssr-query
npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@8108

@tanstack/solid-start
npm i https://pkg.pr.new/@tanstack/solid-start@8108

@tanstack/solid-start-client
npm i https://pkg.pr.new/@tanstack/solid-start-client@8108

@tanstack/solid-start-server
npm i https://pkg.pr.new/@tanstack/solid-start-server@8108

@tanstack/start-client-core
npm i https://pkg.pr.new/@tanstack/start-client-core@8108

@tanstack/start-fn-stubs
npm i https://pkg.pr.new/@tanstack/start-fn-stubs@8108

@tanstack/start-plugin-core
npm i https://pkg.pr.new/@tanstack/start-plugin-core@8108

@tanstack/start-server-core
npm i https://pkg.pr.new/@tanstack/start-server-core@8108

@tanstack/start-static-server-functions
npm i https://pkg.pr.new/@tanstack/start-static-server-functions@8108

@tanstack/start-storage-context
npm i https://pkg.pr.new/@tanstack/start-storage-context@8108

@tanstack/valibot-adapter
npm i https://pkg.pr.new/@tanstack/valibot-adapter@8108

@tanstack/virtual-file-routes
npm i https://pkg.pr.new/@tanstack/virtual-file-routes@8108

@tanstack/vue-router
npm i https://pkg.pr.new/@tanstack/vue-router@8108

@tanstack/vue-router-devtools
npm i https://pkg.pr.new/@tanstack/vue-router-devtools@8108

@tanstack/vue-router-ssr-query
npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@8108

@tanstack/vue-start
npm i https://pkg.pr.new/@tanstack/vue-start@8108

@tanstack/vue-start-client
npm i https://pkg.pr.new/@tanstack/vue-start-client@8108

@tanstack/vue-start-server
npm i https://pkg.pr.new/@tanstack/vue-start-server@8108

@tanstack/zod-adapter
npm i https://pkg.pr.new/@tanstack/zod-adapter@8108

commit: 4b877ce
@codspeed-hq
codspeed-hqBot
commented
Aug 18, 2026•

edited

Loading

Copy link


Copy Markdown

Merging this PR will regress 0 benchmarks
⚠️Different runtime environments detected
Some benchmarks with significant performance changes were compared across different runtime environments,

which may affect the accuracy of the results.
Open the report in CodSpeed to investigate
⚡ 14 improved benchmarks
❌ 2 (👁 2) regressed benchmarks
✅ 164 untouched benchmarks
Performance Changes
ModeBenchmarkBASEHEADEfficiency
⚡Memorymem server error-paths redirect (solid)998.3 KB382.2 KB×2.6
⚡Memorymem client unique-location-churn (solid)419.3 KB266.2 KB+57.5%
⚡Memorymem client interrupted-navigations (react)294.5 KB213.8 KB+37.74%
⚡Memorymem client interrupted-navigations (solid)288.4 KB213.7 KB+34.97%
⚡Memorymem client navigation-churn (solid)819 KB631.7 KB+29.66%
⚡Memorymem client interrupted-navigations (vue)455.1 KB357.6 KB+27.25%
⚡Memorymem server error-paths unmatched (react)550.6 KB433.2 KB+27.09%
⚡Memorymem client unique-location-churn (vue)559.5 KB447.3 KB+25.08%
⚡Memorymem server error-paths not-found (react)481.8 KB406.5 KB+18.52%
⚡Memorymem server error-paths redirect (react)318.7 KB288.6 KB+10.44%
⚡Memorymem server request-churn (vue)868.6 KB816.6 KB+6.37%
⚡Memorymem server aborted-requests (vue)1,069.1 KB1,019.6 KB+4.86%
⚡Simulationssr dehydrate plain control (react)354.2 ms341.4 ms+3.74%
⚡Memorymem client navigation-churn (vue)1.5 MB1.5 MB+3.5%
👁Memorymem server error-paths redirect (vue)401 KB423.6 KB-5.33%
👁Memorymem server serialization-payload (vue)4.3 MB4.5 MB-5.44%
Tip
Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.
Comparing perf/build-location-path-resolution (4b877ce) with main (a78f2af)
Open in CodSpeed
@Sheraff
Sheraff
merged commit 6be202c
into
mainAug 19, 2026

37 of 38 checks passed

@Sheraff
Sheraff
deleted the

perf/build-location-path-resolution

branch
August 19, 2026 09:24

This was referenced Aug 19, 2026
 Merged

 Closed

@github-actionsgithub-actionsBot
mentioned this pull request
Aug 19, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@chatgpt-codex-connectorchatgpt-codex-connector[bot]chatgpt-codex-connector[bot] left review comments

Assignees


No one assigned


Labels

package: router-core

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@Sheraff

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
perf(router-core): optimize buildLocation path resolution - #8108
Merged
Sheraff merged 4 commits into
mainfrom 
perf/build-location-path-resolution
Aug 19, 2026
Merged
perf(router-core): optimize buildLocation path resolution#8108
Sheraff merged 4 commits into
mainfrom 
perf/build-location-path-resolution
Conversation
@Sheraff
@SheraffSheraff
commented
Aug 18, 2026•

edited

Loading

Copy link


Copy Markdown

Collaborator
Inspired by #8086
Summary
  • return normalized absolute paths directly from resolvePath, avoiding the LRU, split, join, and final regex pass
  • resolve relative buildLocation destinations in one pass instead of first resolving from against .
  • normalize relative bases containing repeated slashes before parent traversal, preserving cases such as /a//b + ../../c -> /c
  • reuse inherited params until an updater or route stringifier can mutate them, then clone lazily
  • preserve repeated-slash and trailing-slash behavior and protect current params from mutating stringifiers
The production diff is ten net lines: path.ts adds 14 and router.ts removes 4. Benchmark source is intentionally not included in this PR.
Benchmark setup
The benchmark constructs a real RouterCore with a 1,200-route tree and executes 1,200 buildLocation() calls per sample. Production, browser-conditioned bundles run in Node with createMemoryHistory and RouterCore configured as server. Baseline (main) and the final candidate were bundled separately, loaded into the same process, and alternated for 1,500-2,000 samples. Each case was also rerun with candidate/baseline construction order reversed.
Times below are median milliseconds per 1,200 buildLocation() calls. Arrows are baseline -> candidate.
Important wins
repeated static absolute destinations
baseline first: 0.858 -> 0.669 ms (-22.0%)
candidate first: 0.898 -> 0.722 ms (-19.7%)
repeated relative destinations
baseline first: 1.048 -> 0.897 ms (-14.4%)
candidate first: 1.058 -> 0.909 ms (-14.0%)
1,200 unique relative destinations (sustained LRU misses)
baseline first: 1.619 -> 1.542 ms (-4.7%)
candidate first: 1.619 -> 1.557 ms (-3.8%)
1,200 mixed unique destinations
baseline first: 1.972 -> 1.010 ms (-48.8%)
candidate first: 1.872 -> 1.009 ms (-46.1%)

The mixed-unique case intentionally exceeds the 1,000-entry resolve-path LRU. The large win comes from one-off absolute destinations bypassing the LRU instead of evicting useful relative-path entries. It is a large-app/cache-pressure case, not the expected gain for every navigation.
The unique-relative case also exceeds the LRU and measures the final redundant cleanPath scan on every relative cache miss. Repeated relative paths that remain cached do not receive this additional 3.8-4.7% gain.
The repository Vitest benchmark, rerun in production mode in separate processes, also improved:
1,200 unique mixed destinations: 2.418 -> 1.507 ms (37.7% faster)
1,200 repeated mixed destinations: 1.623 -> 1.459 ms (10.1% faster)
1,200 double-slash destinations: 2.450 -> 1.568 ms (36.0% faster)

Neutral case
repeated dynamic-param destinations
baseline first: 2.133 -> 2.130 ms (-0.1%)
candidate first: 2.091 -> 2.083 ms (-0.4%)

The sub-percent differences should be treated as no demonstrated change.
Bundle size
react-router.minimal compared with main:
gzip: 85,828 -> 85,844 bytes (+16)
raw: 268,920 -> 269,051 bytes (+131)
brotli: 74,750 -> 74,768 bytes (+18)

Test plan
  • pnpm nx run @tanstack/router-core:test:unit -- tests/path.test.ts tests/build-location.test.ts tests/optional-path-params.test.ts tests/optional-path-params-clean.test.ts
  • pnpm nx run @tanstack/router-core:test:types
  • pnpm nx run @tanstack/router-core:test:eslint
  • react-router.minimal bundle-size comparison
Summary by CodeRabbit
  • Bug Fixes
    • Improved URL path resolution by normalizing duplicate slashes.
    • Applied trailing-slash settings consistently to absolute paths.
    • Preserved route parameters when generating locations, preventing accidental mutation of current route state.
    • Ensured inherited parameters remain unchanged when building or updating locations.
  • Tests
    • Added coverage for repeated slashes and trailing-slash modes.
    • Added regression coverage for parameter formatting without state mutation.
@nx-cloud
nx-cloudBot
commented
Aug 18, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
View your CI Pipeline Execution ↗ for commit 4b877ce
CommandStatusDurationResult
nx affected --targets=test:eslint,test:unit,tes...✅ Succeeded11m 21sView ↗
nx run-many --target=build --exclude=examples/*...✅ Succeeded2m 2sView ↗
☁️ Nx Cloud last updated this comment at 2026-08-19 00:41:27 UTC
@github-actions
github-actionsBot
commented
Aug 18, 2026

Copy link


Copy Markdown

Contributor
🚀 Changeset Version Preview
No changeset entries found. Merging this PR will not cause a version bump for any packages.
@coderabbitai
coderabbitaiBot
commented
Aug 18, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Review Change Stack
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: d6b04845-ac67-41eb-a775-c0dde2600356
📥 Commits
Reviewing files that changed from the base of the PR and between 6bcaf84 and 4b877ce.
📒 Files selected for processing (2)
  • packages/router-core/src/path.ts
  • packages/router-core/tests/path.test.ts
Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.
📝 Walkthrough
Walkthrough
Router-core now normalizes duplicate slashes during path resolution and applies trailing-slash settings directly. Location construction and parameter updates preserve shared route parameters during stringification and updates.
Changes
Router path and parameter handling
Layer / File(s)Summary
Normalize destination paths
packages/router-core/src/path.ts, packages/router-core/src/router.ts, packages/router-core/tests/path.test.ts, packages/router-core/tests/build-location.test.ts		resolvePath normalizes repeated slashes and handles absolute destinations according to trailingSlash. Router code passes destinations directly to the resolver. Tests cover traversal, base paths, and trailing-slash modes.
Preserve route parameters
packages/router-core/src/router.ts, packages/router-core/tests/build-location.test.ts		Location construction and updater-based parameter changes avoid mutating shared parameter objects. Regression coverage verifies parameter immutability during stringification.
Estimated code review effort: 3 (Moderate) | ~20 minutes
Merge Risk:⚪ Minimal · up to 4b877
This PR optimizes router path resolution and parameter handling without introducing a known user-facing correctness or production risk; no actionable merge-blocking risk remains beyond normal checks and review.
Possibly related PRs
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly summarizes the primary change: optimizing buildLocation path resolution.
✨ Finishing Touches
📝 Generate docstrings
  •  Create stacked PR
  •  Commit on current branch
🧪 Generate unit tests (beta)
  •  Create PR with unit tests
  •  Commit unit tests in branch perf/build-location-path-resolution
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands.
chatgpt-codex-connector[bot]
chatgpt-codex-connectorBot
reviewed
Aug 18, 2026
View reviewed changes
@chatgpt-codex-connectorchatgpt-codex-connectorBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit:931e51a568
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Comment threadpackages/router-core/src/router.ts
@github-actions
github-actionsBot
commented
Aug 18, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Bundle Size Benchmarks
  • Commit: a837a5f77928
  • Measured at: 2026-08-19T00:31:21.976Z
  • Baseline source: history:a78f2af5b49b
  • Dashboard: bundle-size history
The following scenarios have bundle-size changes compared with the baseline:
ScenarioCurrent (gzip)Delta vs baselineInitial gzipRawBrotliTrend
react-router.minimal83.83 KiB+16 B (+0.02%)83.70 KiB262.75 KiB73.02 KiB▃▃██▆▃▃▂▂▁▁▂
react-router.full87.33 KiB+20 B (+0.02%)87.20 KiB274.46 KiB76.10 KiB▄▅██▅▂▂▂▂▁▁▃
solid-router.minimal33.19 KiB+10 B (+0.03%)33.06 KiB96.61 KiB30.01 KiB████▅▁▁▁▁▇▇█
solid-router.full38.04 KiB+21 B (+0.05%)37.91 KiB111.25 KiB34.26 KiB▅▅▅▅▄▁▁▁▁▇▇█
vue-router.minimal49.53 KiB+28 B (+0.06%)49.41 KiB138.65 KiB44.70 KiB▇███▄▁▁▁▁▁▁▃
vue-router.full55.14 KiB+23 B (+0.04%)55.01 KiB156.85 KiB49.60 KiB████▄▁▁▁▁▁▁▃
react-start.minimal96.73 KiB+29 B (+0.03%)96.59 KiB305.00 KiB83.72 KiB▄▄▇▇▄▂▂▁▁▆▆█
react-start.deferred-hydration97.45 KiB+23 B (+0.02%)96.61 KiB306.36 KiB84.40 KiB▃▃██▅▃▃▁▁▆▆█
react-start.full99.89 KiB+24 B (+0.02%)99.75 KiB314.74 KiB86.58 KiB▄▄██▄▁▁▁▁▆▆▇
react-start.rsbuild.minimal100.06 KiB+47 B (+0.05%)99.89 KiB315.36 KiB86.26 KiB▁▁▆▆▅▂▂▁▁▅▅█
react-start.rsbuild.minimal-iife100.47 KiB+47 B (+0.05%)100.30 KiB316.30 KiB86.70 KiB▁▁▆▆▆▂▂▁▁▅▅█
react-start.rsbuild.full103.38 KiB+46 B (+0.04%)103.21 KiB325.45 KiB89.02 KiB▁▁▆▆▆▂▂▁▁▅▅█
solid-start.minimal46.03 KiB+15 B (+0.03%)45.90 KiB137.71 KiB40.95 KiB▅▅▅▅▃▁▁▁▁▇▇█
solid-start.deferred-hydration49.11 KiB+14 B (+0.03%)45.97 KiB145.17 KiB43.74 KiB▅▅▅▅▃▁▁▁▁▇▇█
solid-start.full51.10 KiB+10 B (+0.02%)50.97 KiB153.09 KiB45.37 KiB▅▅▅▅▃▁▁▁▁▇▇█
vue-start.minimal65.67 KiB+22 B (+0.03%)65.55 KiB189.49 KiB58.47 KiB▅▆▆▆▄▁▁▁▁▇▇█
vue-start.full69.50 KiB+26 B (+0.04%)69.37 KiB201.80 KiB61.78 KiB▅▅▅▅▃▁▁▁▁▇▇█
Current gzip tracks all emitted client JS chunks. Initial gzip tracks only the entry/import graph. Trend sparkline is historical current gzip ending with this PR measurement; lower is better.
@pkg-pr-new
pkg-pr-newBot
commented
Aug 18, 2026•

edited

Loading

Copy link


Copy Markdown

More templates
@tanstack/arktype-adapter
npm i https://pkg.pr.new/@tanstack/arktype-adapter@8108

@tanstack/eslint-plugin-router
npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@8108

@tanstack/eslint-plugin-start
npm i https://pkg.pr.new/@tanstack/eslint-plugin-start@8108

@tanstack/history
npm i https://pkg.pr.new/@tanstack/history@8108

@tanstack/nitro-v2-vite-plugin
npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@8108

@tanstack/react-router
npm i https://pkg.pr.new/@tanstack/react-router@8108

@tanstack/react-router-devtools
npm i https://pkg.pr.new/@tanstack/react-router-devtools@8108

@tanstack/react-router-ssr-query
npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@8108

@tanstack/react-start
npm i https://pkg.pr.new/@tanstack/react-start@8108

@tanstack/react-start-client
npm i https://pkg.pr.new/@tanstack/react-start-client@8108

@tanstack/react-start-rsc
npm i https://pkg.pr.new/@tanstack/react-start-rsc@8108

@tanstack/react-start-server
npm i https://pkg.pr.new/@tanstack/react-start-server@8108

@tanstack/router-cli
npm i https://pkg.pr.new/@tanstack/router-cli@8108

@tanstack/router-core
npm i https://pkg.pr.new/@tanstack/router-core@8108

@tanstack/router-devtools
npm i https://pkg.pr.new/@tanstack/router-devtools@8108

@tanstack/router-devtools-core
npm i https://pkg.pr.new/@tanstack/router-devtools-core@8108

@tanstack/router-generator
npm i https://pkg.pr.new/@tanstack/router-generator@8108

@tanstack/router-plugin
npm i https://pkg.pr.new/@tanstack/router-plugin@8108

@tanstack/router-ssr-query-core
npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@8108

@tanstack/router-utils
npm i https://pkg.pr.new/@tanstack/router-utils@8108

@tanstack/router-vite-plugin
npm i https://pkg.pr.new/@tanstack/router-vite-plugin@8108

@tanstack/solid-router
npm i https://pkg.pr.new/@tanstack/solid-router@8108

@tanstack/solid-router-devtools
npm i https://pkg.pr.new/@tanstack/solid-router-devtools@8108

@tanstack/solid-router-ssr-query
npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@8108

@tanstack/solid-start
npm i https://pkg.pr.new/@tanstack/solid-start@8108

@tanstack/solid-start-client
npm i https://pkg.pr.new/@tanstack/solid-start-client@8108

@tanstack/solid-start-server
npm i https://pkg.pr.new/@tanstack/solid-start-server@8108

@tanstack/start-client-core
npm i https://pkg.pr.new/@tanstack/start-client-core@8108

@tanstack/start-fn-stubs
npm i https://pkg.pr.new/@tanstack/start-fn-stubs@8108

@tanstack/start-plugin-core
npm i https://pkg.pr.new/@tanstack/start-plugin-core@8108

@tanstack/start-server-core
npm i https://pkg.pr.new/@tanstack/start-server-core@8108

@tanstack/start-static-server-functions
npm i https://pkg.pr.new/@tanstack/start-static-server-functions@8108

@tanstack/start-storage-context
npm i https://pkg.pr.new/@tanstack/start-storage-context@8108

@tanstack/valibot-adapter
npm i https://pkg.pr.new/@tanstack/valibot-adapter@8108

@tanstack/virtual-file-routes
npm i https://pkg.pr.new/@tanstack/virtual-file-routes@8108

@tanstack/vue-router
npm i https://pkg.pr.new/@tanstack/vue-router@8108

@tanstack/vue-router-devtools
npm i https://pkg.pr.new/@tanstack/vue-router-devtools@8108

@tanstack/vue-router-ssr-query
npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@8108

@tanstack/vue-start
npm i https://pkg.pr.new/@tanstack/vue-start@8108

@tanstack/vue-start-client
npm i https://pkg.pr.new/@tanstack/vue-start-client@8108

@tanstack/vue-start-server
npm i https://pkg.pr.new/@tanstack/vue-start-server@8108

@tanstack/zod-adapter
npm i https://pkg.pr.new/@tanstack/zod-adapter@8108

commit: 4b877ce
@codspeed-hq
codspeed-hqBot
commented
Aug 18, 2026•

edited

Loading

Copy link


Copy Markdown

Merging this PR will regress 0 benchmarks
⚠️Different runtime environments detected
Some benchmarks with significant performance changes were compared across different runtime environments,

which may affect the accuracy of the results.
Open the report in CodSpeed to investigate
⚡ 14 improved benchmarks
❌ 2 (👁 2) regressed benchmarks
✅ 164 untouched benchmarks
Performance Changes
ModeBenchmarkBASEHEADEfficiency
⚡Memorymem server error-paths redirect (solid)998.3 KB382.2 KB×2.6
⚡Memorymem client unique-location-churn (solid)419.3 KB266.2 KB+57.5%
⚡Memorymem client interrupted-navigations (react)294.5 KB213.8 KB+37.74%
⚡Memorymem client interrupted-navigations (solid)288.4 KB213.7 KB+34.97%
⚡Memorymem client navigation-churn (solid)819 KB631.7 KB+29.66%
⚡Memorymem client interrupted-navigations (vue)455.1 KB357.6 KB+27.25%
⚡Memorymem server error-paths unmatched (react)550.6 KB433.2 KB+27.09%
⚡Memorymem client unique-location-churn (vue)559.5 KB447.3 KB+25.08%
⚡Memorymem server error-paths not-found (react)481.8 KB406.5 KB+18.52%
⚡Memorymem server error-paths redirect (react)318.7 KB288.6 KB+10.44%
⚡Memorymem server request-churn (vue)868.6 KB816.6 KB+6.37%
⚡Memorymem server aborted-requests (vue)1,069.1 KB1,019.6 KB+4.86%
⚡Simulationssr dehydrate plain control (react)354.2 ms341.4 ms+3.74%
⚡Memorymem client navigation-churn (vue)1.5 MB1.5 MB+3.5%
👁Memorymem server error-paths redirect (vue)401 KB423.6 KB-5.33%
👁Memorymem server serialization-payload (vue)4.3 MB4.5 MB-5.44%
Tip
Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.
Comparing perf/build-location-path-resolution (4b877ce) with main (a78f2af)
Open in CodSpeed
@Sheraff
Sheraff
merged commit 6be202c
into
mainAug 19, 2026

37 of 38 checks passed

@Sheraff
Sheraff
deleted the

perf/build-location-path-resolution

branch
August 19, 2026 09:24

This was referenced Aug 19, 2026
 Merged

 Closed

@github-actionsgithub-actionsBot
mentioned this pull request
Aug 19, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@chatgpt-codex-connectorchatgpt-codex-connector[bot]chatgpt-codex-connector[bot] left review comments

Assignees


No one assigned


Labels

package: router-core

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@Sheraff

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
perf(router-core): optimize buildLocation path resolution - #8108
Merged
Sheraff merged 4 commits into
mainfrom 
perf/build-location-path-resolution
Aug 19, 2026
Merged
perf(router-core): optimize buildLocation path resolution#8108
Sheraff merged 4 commits into
mainfrom 
perf/build-location-path-resolution
Conversation
@Sheraff
@SheraffSheraff
commented
Aug 18, 2026•

edited

Loading

Copy link


Copy Markdown

Collaborator
Inspired by #8086
Summary
  • return normalized absolute paths directly from resolvePath, avoiding the LRU, split, join, and final regex pass
  • resolve relative buildLocation destinations in one pass instead of first resolving from against .
  • normalize relative bases containing repeated slashes before parent traversal, preserving cases such as /a//b + ../../c -> /c
  • reuse inherited params until an updater or route stringifier can mutate them, then clone lazily
  • preserve repeated-slash and trailing-slash behavior and protect current params from mutating stringifiers
The production diff is ten net lines: path.ts adds 14 and router.ts removes 4. Benchmark source is intentionally not included in this PR.
Benchmark setup
The benchmark constructs a real RouterCore with a 1,200-route tree and executes 1,200 buildLocation() calls per sample. Production, browser-conditioned bundles run in Node with createMemoryHistory and RouterCore configured as server. Baseline (main) and the final candidate were bundled separately, loaded into the same process, and alternated for 1,500-2,000 samples. Each case was also rerun with candidate/baseline construction order reversed.
Times below are median milliseconds per 1,200 buildLocation() calls. Arrows are baseline -> candidate.
Important wins
repeated static absolute destinations
baseline first: 0.858 -> 0.669 ms (-22.0%)
candidate first: 0.898 -> 0.722 ms (-19.7%)
repeated relative destinations
baseline first: 1.048 -> 0.897 ms (-14.4%)
candidate first: 1.058 -> 0.909 ms (-14.0%)
1,200 unique relative destinations (sustained LRU misses)
baseline first: 1.619 -> 1.542 ms (-4.7%)
candidate first: 1.619 -> 1.557 ms (-3.8%)
1,200 mixed unique destinations
baseline first: 1.972 -> 1.010 ms (-48.8%)
candidate first: 1.872 -> 1.009 ms (-46.1%)

The mixed-unique case intentionally exceeds the 1,000-entry resolve-path LRU. The large win comes from one-off absolute destinations bypassing the LRU instead of evicting useful relative-path entries. It is a large-app/cache-pressure case, not the expected gain for every navigation.
The unique-relative case also exceeds the LRU and measures the final redundant cleanPath scan on every relative cache miss. Repeated relative paths that remain cached do not receive this additional 3.8-4.7% gain.
The repository Vitest benchmark, rerun in production mode in separate processes, also improved:
1,200 unique mixed destinations: 2.418 -> 1.507 ms (37.7% faster)
1,200 repeated mixed destinations: 1.623 -> 1.459 ms (10.1% faster)
1,200 double-slash destinations: 2.450 -> 1.568 ms (36.0% faster)

Neutral case
repeated dynamic-param destinations
baseline first: 2.133 -> 2.130 ms (-0.1%)
candidate first: 2.091 -> 2.083 ms (-0.4%)

The sub-percent differences should be treated as no demonstrated change.
Bundle size
react-router.minimal compared with main:
gzip: 85,828 -> 85,844 bytes (+16)
raw: 268,920 -> 269,051 bytes (+131)
brotli: 74,750 -> 74,768 bytes (+18)

Test plan
  • pnpm nx run @tanstack/router-core:test:unit -- tests/path.test.ts tests/build-location.test.ts tests/optional-path-params.test.ts tests/optional-path-params-clean.test.ts
  • pnpm nx run @tanstack/router-core:test:types
  • pnpm nx run @tanstack/router-core:test:eslint
  • react-router.minimal bundle-size comparison
Summary by CodeRabbit
  • Bug Fixes
    • Improved URL path resolution by normalizing duplicate slashes.
    • Applied trailing-slash settings consistently to absolute paths.
    • Preserved route parameters when generating locations, preventing accidental mutation of current route state.
    • Ensured inherited parameters remain unchanged when building or updating locations.
  • Tests
    • Added coverage for repeated slashes and trailing-slash modes.
    • Added regression coverage for parameter formatting without state mutation.
@nx-cloud
nx-cloudBot
commented
Aug 18, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
View your CI Pipeline Execution ↗ for commit 4b877ce
CommandStatusDurationResult
nx affected --targets=test:eslint,test:unit,tes...✅ Succeeded11m 21sView ↗
nx run-many --target=build --exclude=examples/*...✅ Succeeded2m 2sView ↗
☁️ Nx Cloud last updated this comment at 2026-08-19 00:41:27 UTC
@github-actions
github-actionsBot
commented
Aug 18, 2026

Copy link


Copy Markdown

Contributor
🚀 Changeset Version Preview
No changeset entries found. Merging this PR will not cause a version bump for any packages.
@coderabbitai
coderabbitaiBot
commented
Aug 18, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Review Change Stack
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: d6b04845-ac67-41eb-a775-c0dde2600356
📥 Commits
Reviewing files that changed from the base of the PR and between 6bcaf84 and 4b877ce.
📒 Files selected for processing (2)
  • packages/router-core/src/path.ts
  • packages/router-core/tests/path.test.ts
Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.
📝 Walkthrough
Walkthrough
Router-core now normalizes duplicate slashes during path resolution and applies trailing-slash settings directly. Location construction and parameter updates preserve shared route parameters during stringification and updates.
Changes
Router path and parameter handling
Layer / File(s)Summary
Normalize destination paths
packages/router-core/src/path.ts, packages/router-core/src/router.ts, packages/router-core/tests/path.test.ts, packages/router-core/tests/build-location.test.ts		resolvePath normalizes repeated slashes and handles absolute destinations according to trailingSlash. Router code passes destinations directly to the resolver. Tests cover traversal, base paths, and trailing-slash modes.
Preserve route parameters
packages/router-core/src/router.ts, packages/router-core/tests/build-location.test.ts		Location construction and updater-based parameter changes avoid mutating shared parameter objects. Regression coverage verifies parameter immutability during stringification.
Estimated code review effort: 3 (Moderate) | ~20 minutes
Merge Risk:⚪ Minimal · up to 4b877
This PR optimizes router path resolution and parameter handling without introducing a known user-facing correctness or production risk; no actionable merge-blocking risk remains beyond normal checks and review.
Possibly related PRs
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly summarizes the primary change: optimizing buildLocation path resolution.
✨ Finishing Touches
📝 Generate docstrings
  •  Create stacked PR
  •  Commit on current branch
🧪 Generate unit tests (beta)
  •  Create PR with unit tests
  •  Commit unit tests in branch perf/build-location-path-resolution
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands.
chatgpt-codex-connector[bot]
chatgpt-codex-connectorBot
reviewed
Aug 18, 2026
View reviewed changes
@chatgpt-codex-connectorchatgpt-codex-connectorBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit:931e51a568
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Comment threadpackages/router-core/src/router.ts
@github-actions
github-actionsBot
commented
Aug 18, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Bundle Size Benchmarks
  • Commit: a837a5f77928
  • Measured at: 2026-08-19T00:31:21.976Z
  • Baseline source: history:a78f2af5b49b
  • Dashboard: bundle-size history
The following scenarios have bundle-size changes compared with the baseline:
ScenarioCurrent (gzip)Delta vs baselineInitial gzipRawBrotliTrend
react-router.minimal83.83 KiB+16 B (+0.02%)83.70 KiB262.75 KiB73.02 KiB▃▃██▆▃▃▂▂▁▁▂
react-router.full87.33 KiB+20 B (+0.02%)87.20 KiB274.46 KiB76.10 KiB▄▅██▅▂▂▂▂▁▁▃
solid-router.minimal33.19 KiB+10 B (+0.03%)33.06 KiB96.61 KiB30.01 KiB████▅▁▁▁▁▇▇█
solid-router.full38.04 KiB+21 B (+0.05%)37.91 KiB111.25 KiB34.26 KiB▅▅▅▅▄▁▁▁▁▇▇█
vue-router.minimal49.53 KiB+28 B (+0.06%)49.41 KiB138.65 KiB44.70 KiB▇███▄▁▁▁▁▁▁▃
vue-router.full55.14 KiB+23 B (+0.04%)55.01 KiB156.85 KiB49.60 KiB████▄▁▁▁▁▁▁▃
react-start.minimal96.73 KiB+29 B (+0.03%)96.59 KiB305.00 KiB83.72 KiB▄▄▇▇▄▂▂▁▁▆▆█
react-start.deferred-hydration97.45 KiB+23 B (+0.02%)96.61 KiB306.36 KiB84.40 KiB▃▃██▅▃▃▁▁▆▆█
react-start.full99.89 KiB+24 B (+0.02%)99.75 KiB314.74 KiB86.58 KiB▄▄██▄▁▁▁▁▆▆▇
react-start.rsbuild.minimal100.06 KiB+47 B (+0.05%)99.89 KiB315.36 KiB86.26 KiB▁▁▆▆▅▂▂▁▁▅▅█
react-start.rsbuild.minimal-iife100.47 KiB+47 B (+0.05%)100.30 KiB316.30 KiB86.70 KiB▁▁▆▆▆▂▂▁▁▅▅█
react-start.rsbuild.full103.38 KiB+46 B (+0.04%)103.21 KiB325.45 KiB89.02 KiB▁▁▆▆▆▂▂▁▁▅▅█
solid-start.minimal46.03 KiB+15 B (+0.03%)45.90 KiB137.71 KiB40.95 KiB▅▅▅▅▃▁▁▁▁▇▇█
solid-start.deferred-hydration49.11 KiB+14 B (+0.03%)45.97 KiB145.17 KiB43.74 KiB▅▅▅▅▃▁▁▁▁▇▇█
solid-start.full51.10 KiB+10 B (+0.02%)50.97 KiB153.09 KiB45.37 KiB▅▅▅▅▃▁▁▁▁▇▇█
vue-start.minimal65.67 KiB+22 B (+0.03%)65.55 KiB189.49 KiB58.47 KiB▅▆▆▆▄▁▁▁▁▇▇█
vue-start.full69.50 KiB+26 B (+0.04%)69.37 KiB201.80 KiB61.78 KiB▅▅▅▅▃▁▁▁▁▇▇█
Current gzip tracks all emitted client JS chunks. Initial gzip tracks only the entry/import graph. Trend sparkline is historical current gzip ending with this PR measurement; lower is better.
@pkg-pr-new
pkg-pr-newBot
commented
Aug 18, 2026•

edited

Loading

Copy link


Copy Markdown

More templates
@tanstack/arktype-adapter
npm i https://pkg.pr.new/@tanstack/arktype-adapter@8108

@tanstack/eslint-plugin-router
npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@8108

@tanstack/eslint-plugin-start
npm i https://pkg.pr.new/@tanstack/eslint-plugin-start@8108

@tanstack/history
npm i https://pkg.pr.new/@tanstack/history@8108

@tanstack/nitro-v2-vite-plugin
npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@8108

@tanstack/react-router
npm i https://pkg.pr.new/@tanstack/react-router@8108

@tanstack/react-router-devtools
npm i https://pkg.pr.new/@tanstack/react-router-devtools@8108

@tanstack/react-router-ssr-query
npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@8108

@tanstack/react-start
npm i https://pkg.pr.new/@tanstack/react-start@8108

@tanstack/react-start-client
npm i https://pkg.pr.new/@tanstack/react-start-client@8108

@tanstack/react-start-rsc
npm i https://pkg.pr.new/@tanstack/react-start-rsc@8108

@tanstack/react-start-server
npm i https://pkg.pr.new/@tanstack/react-start-server@8108

@tanstack/router-cli
npm i https://pkg.pr.new/@tanstack/router-cli@8108

@tanstack/router-core
npm i https://pkg.pr.new/@tanstack/router-core@8108

@tanstack/router-devtools
npm i https://pkg.pr.new/@tanstack/router-devtools@8108

@tanstack/router-devtools-core
npm i https://pkg.pr.new/@tanstack/router-devtools-core@8108

@tanstack/router-generator
npm i https://pkg.pr.new/@tanstack/router-generator@8108

@tanstack/router-plugin
npm i https://pkg.pr.new/@tanstack/router-plugin@8108

@tanstack/router-ssr-query-core
npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@8108

@tanstack/router-utils
npm i https://pkg.pr.new/@tanstack/router-utils@8108

@tanstack/router-vite-plugin
npm i https://pkg.pr.new/@tanstack/router-vite-plugin@8108

@tanstack/solid-router
npm i https://pkg.pr.new/@tanstack/solid-router@8108

@tanstack/solid-router-devtools
npm i https://pkg.pr.new/@tanstack/solid-router-devtools@8108

@tanstack/solid-router-ssr-query
npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@8108

@tanstack/solid-start
npm i https://pkg.pr.new/@tanstack/solid-start@8108

@tanstack/solid-start-client
npm i https://pkg.pr.new/@tanstack/solid-start-client@8108

@tanstack/solid-start-server
npm i https://pkg.pr.new/@tanstack/solid-start-server@8108

@tanstack/start-client-core
npm i https://pkg.pr.new/@tanstack/start-client-core@8108

@tanstack/start-fn-stubs
npm i https://pkg.pr.new/@tanstack/start-fn-stubs@8108

@tanstack/start-plugin-core
npm i https://pkg.pr.new/@tanstack/start-plugin-core@8108

@tanstack/start-server-core
npm i https://pkg.pr.new/@tanstack/start-server-core@8108

@tanstack/start-static-server-functions
npm i https://pkg.pr.new/@tanstack/start-static-server-functions@8108

@tanstack/start-storage-context
npm i https://pkg.pr.new/@tanstack/start-storage-context@8108

@tanstack/valibot-adapter
npm i https://pkg.pr.new/@tanstack/valibot-adapter@8108

@tanstack/virtual-file-routes
npm i https://pkg.pr.new/@tanstack/virtual-file-routes@8108

@tanstack/vue-router
npm i https://pkg.pr.new/@tanstack/vue-router@8108

@tanstack/vue-router-devtools
npm i https://pkg.pr.new/@tanstack/vue-router-devtools@8108

@tanstack/vue-router-ssr-query
npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@8108

@tanstack/vue-start
npm i https://pkg.pr.new/@tanstack/vue-start@8108

@tanstack/vue-start-client
npm i https://pkg.pr.new/@tanstack/vue-start-client@8108

@tanstack/vue-start-server
npm i https://pkg.pr.new/@tanstack/vue-start-server@8108

@tanstack/zod-adapter
npm i https://pkg.pr.new/@tanstack/zod-adapter@8108

commit: 4b877ce
@codspeed-hq
codspeed-hqBot
commented
Aug 18, 2026•

edited

Loading

Copy link


Copy Markdown

Merging this PR will regress 0 benchmarks
⚠️Different runtime environments detected
Some benchmarks with significant performance changes were compared across different runtime environments,

which may affect the accuracy of the results.
Open the report in CodSpeed to investigate
⚡ 14 improved benchmarks
❌ 2 (👁 2) regressed benchmarks
✅ 164 untouched benchmarks
Performance Changes
ModeBenchmarkBASEHEADEfficiency
⚡Memorymem server error-paths redirect (solid)998.3 KB382.2 KB×2.6
⚡Memorymem client unique-location-churn (solid)419.3 KB266.2 KB+57.5%
⚡Memorymem client interrupted-navigations (react)294.5 KB213.8 KB+37.74%
⚡Memorymem client interrupted-navigations (solid)288.4 KB213.7 KB+34.97%
⚡Memorymem client navigation-churn (solid)819 KB631.7 KB+29.66%
⚡Memorymem client interrupted-navigations (vue)455.1 KB357.6 KB+27.25%
⚡Memorymem server error-paths unmatched (react)550.6 KB433.2 KB+27.09%
⚡Memorymem client unique-location-churn (vue)559.5 KB447.3 KB+25.08%
⚡Memorymem server error-paths not-found (react)481.8 KB406.5 KB+18.52%
⚡Memorymem server error-paths redirect (react)318.7 KB288.6 KB+10.44%
⚡Memorymem server request-churn (vue)868.6 KB816.6 KB+6.37%
⚡Memorymem server aborted-requests (vue)1,069.1 KB1,019.6 KB+4.86%
⚡Simulationssr dehydrate plain control (react)354.2 ms341.4 ms+3.74%
⚡Memorymem client navigation-churn (vue)1.5 MB1.5 MB+3.5%
👁Memorymem server error-paths redirect (vue)401 KB423.6 KB-5.33%
👁Memorymem server serialization-payload (vue)4.3 MB4.5 MB-5.44%
Tip
Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.
Comparing perf/build-location-path-resolution (4b877ce) with main (a78f2af)
Open in CodSpeed
@Sheraff
Sheraff
merged commit 6be202c
into
mainAug 19, 2026

37 of 38 checks passed

@Sheraff
Sheraff
deleted the

perf/build-location-path-resolution

branch
August 19, 2026 09:24

This was referenced Aug 19, 2026
 Merged

 Closed

@github-actionsgithub-actionsBot
mentioned this pull request
Aug 19, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@chatgpt-codex-connectorchatgpt-codex-connector[bot]chatgpt-codex-connector[bot] left review comments

Assignees


No one assigned


Labels

package: router-core

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@Sheraff