Skip to content

fix(start): migrate to Rsbuild splitChunks config - #8135

Merged
schiller-manuel merged 1 commit into
TanStack:mainfrom
chenjiahan:chenjiahan/fix-rsbuild-split-chunks-config
Aug 22, 2026
Merged

fix(start): migrate to Rsbuild splitChunks config#8135
schiller-manuel merged 1 commit into
TanStack:mainfrom
chenjiahan:chenjiahan/fix-rsbuild-split-chunks-config

Conversation

@chenjiahan

@chenjiahanchenjiahan commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Summary

Rsbuild v2 deprecates performance.chunkSplit in favor of the top-level splitChunks option.

This migrates the Start Rsbuild client config to splitChunks with preset: 'none' and chunks: 'async', preserving the existing behavior of splitting only async route chunks.

The Vue Start e2e config no longer supplies the deprecated override.

Related Links

Summary by CodeRabbit

  • Bug Fixes

    • Updated client-side chunk splitting to the Rsbuild v2 configuration format.
    • Preserved asynchronous route code splitting while preventing unnecessary vendor and shared chunks.
  • Chores

    • Added a patch release note for the updated chunk configuration.

@coderabbitai

coderabbitaiBot commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 1bd45848-eea7-41f2-a5b4-4fd961eb5050

📥 Commits

Reviewing files that changed from the base of the PR and between cb281d7 and 4337e7e.

📒 Files selected for processing (3)
  • .changeset/modern-chunks-split.md
  • e2e/vue-start/basic/rsbuild.config.ts
  • packages/start-plugin-core/src/rsbuild/planning.ts
💤 Files with no reviewable changes (1)
  • e2e/vue-start/basic/rsbuild.config.ts

Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.


📝 Walkthrough

Walkthrough

The client Rsbuild configuration now uses v2 splitChunks with preset: 'none' and chunks: 'async'. The Vue Start example removes the legacy configuration. A patch changeset documents the migration.

Changes

Rsbuild chunk splitting

Layer / File(s)Summary
Async client chunk-splitting migration
packages/start-plugin-core/src/rsbuild/planning.ts, e2e/vue-start/basic/rsbuild.config.ts, .changeset/modern-chunks-split.md
The client configuration uses async-only splitChunks with shared and vendor chunk splitting disabled. The example removes the legacy strategy, and the changeset documents the patch release.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk:⚪ Minimal · up to 4337e

This change updates the build configuration to the supported split-chunk option while preserving async route splitting behavior; no actionable merge-blocking risk remains.

Suggested reviewers:schiller-manuel

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. (1 skipped: 1 unsupported.)Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly and concisely describes the migration from the deprecated Rsbuild chunk-splitting configuration to the v2 splitChunks configuration.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chenjiahan
chenjiahan marked this pull request as ready for review August 21, 2026 09:08
@chenjiahanchenjiahan changed the title fix(start): migrate to Rsbuild splitChunksfix(start): migrate to Rsbuild splitChunks configAug 21, 2026
@nx-cloud

nx-cloudBot commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

View your CI Pipeline Execution ↗ for commit 4337e7e

CommandStatusDurationResult
nx affected --targets=test:eslint,test:unit,tes...✅ Succeeded21m 33sView ↗
nx run-many --target=build --exclude=examples/*...✅ Succeeded2m 8sView ↗

☁️ Nx Cloud last updated this comment at 2026-08-21 21:18:34 UTC

@pkg-pr-new

Copy link
Copy Markdown
More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/@tanstack/arktype-adapter@8135

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@8135

@tanstack/eslint-plugin-start

npm i https://pkg.pr.new/@tanstack/eslint-plugin-start@8135

@tanstack/history

npm i https://pkg.pr.new/@tanstack/history@8135

@tanstack/nitro-v2-vite-plugin

npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@8135

@tanstack/react-router

npm i https://pkg.pr.new/@tanstack/react-router@8135

@tanstack/react-router-devtools

npm i https://pkg.pr.new/@tanstack/react-router-devtools@8135

@tanstack/react-router-ssr-query

npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@8135

@tanstack/react-start

npm i https://pkg.pr.new/@tanstack/react-start@8135

@tanstack/react-start-client

npm i https://pkg.pr.new/@tanstack/react-start-client@8135

@tanstack/react-start-rsc

npm i https://pkg.pr.new/@tanstack/react-start-rsc@8135

@tanstack/react-start-server

npm i https://pkg.pr.new/@tanstack/react-start-server@8135

@tanstack/router-cli

npm i https://pkg.pr.new/@tanstack/router-cli@8135

@tanstack/router-core

npm i https://pkg.pr.new/@tanstack/router-core@8135

@tanstack/router-devtools

npm i https://pkg.pr.new/@tanstack/router-devtools@8135

@tanstack/router-devtools-core

npm i https://pkg.pr.new/@tanstack/router-devtools-core@8135

@tanstack/router-generator

npm i https://pkg.pr.new/@tanstack/router-generator@8135

@tanstack/router-plugin

npm i https://pkg.pr.new/@tanstack/router-plugin@8135

@tanstack/router-ssr-query-core

npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@8135

@tanstack/router-utils

npm i https://pkg.pr.new/@tanstack/router-utils@8135

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/@tanstack/router-vite-plugin@8135

@tanstack/solid-router

npm i https://pkg.pr.new/@tanstack/solid-router@8135

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/@tanstack/solid-router-devtools@8135

@tanstack/solid-router-ssr-query

npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@8135

@tanstack/solid-start

npm i https://pkg.pr.new/@tanstack/solid-start@8135

@tanstack/solid-start-client

npm i https://pkg.pr.new/@tanstack/solid-start-client@8135

@tanstack/solid-start-server

npm i https://pkg.pr.new/@tanstack/solid-start-server@8135

@tanstack/start-client-core

npm i https://pkg.pr.new/@tanstack/start-client-core@8135

@tanstack/start-fn-stubs

npm i https://pkg.pr.new/@tanstack/start-fn-stubs@8135

@tanstack/start-plugin-core

npm i https://pkg.pr.new/@tanstack/start-plugin-core@8135

@tanstack/start-server-core

npm i https://pkg.pr.new/@tanstack/start-server-core@8135

@tanstack/start-static-server-functions

npm i https://pkg.pr.new/@tanstack/start-static-server-functions@8135

@tanstack/start-storage-context

npm i https://pkg.pr.new/@tanstack/start-storage-context@8135

@tanstack/valibot-adapter

npm i https://pkg.pr.new/@tanstack/valibot-adapter@8135

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/@tanstack/virtual-file-routes@8135

@tanstack/vue-router

npm i https://pkg.pr.new/@tanstack/vue-router@8135

@tanstack/vue-router-devtools

npm i https://pkg.pr.new/@tanstack/vue-router-devtools@8135

@tanstack/vue-router-ssr-query

npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@8135

@tanstack/vue-start

npm i https://pkg.pr.new/@tanstack/vue-start@8135

@tanstack/vue-start-client

npm i https://pkg.pr.new/@tanstack/vue-start-client@8135

@tanstack/vue-start-server

npm i https://pkg.pr.new/@tanstack/vue-start-server@8135

@tanstack/zod-adapter

npm i https://pkg.pr.new/@tanstack/zod-adapter@8135

commit: 4337e7e

@codspeed-hq

Copy link
Copy Markdown

Merging this PR will regress 9 benchmarks

⚠️Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 9 improved benchmarks
❌ 9 regressed benchmarks
✅ 162 untouched benchmarks

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

ModeBenchmarkBASEHEADEfficiency
Memorymem server server-fn-churn (react)399.9 KB1,066.8 KB-62.52%
Memorymem server error-paths redirect (vue)423.5 KB620.5 KB-31.74%
Memorymem server peak-large-page (solid)1.1 MB1.3 MB-13.93%
Memorymem server error-paths redirect (react)296.3 KB325.1 KB-8.86%
Memorymem server error-paths unmatched (vue)580.1 KB628.6 KB-7.71%
Memorymem server peak-large-page (vue)1 MB1.1 MB-7.57%
Memorymem server error-paths not-found (solid)570 KB609.4 KB-6.46%
Simulationclient-async-pipeline navigation loop (react)102.8 ms107.1 ms-3.99%
Memorymem server serialization-payload (vue)4.4 MB4.5 MB-3.48%
Memorymem server error-paths unmatched (react)1,830.3 KB415 KB×4.4
Memorymem server error-paths not-found (vue)2,071.7 KB479.9 KB×4.3
Memorymem server request-churn (react)712.7 KB659.9 KB+8%
Memorymem server aborted-requests (vue)1,058.3 KB993 KB+6.57%
Memorymem server error-paths not-found (react)435.6 KB419 KB+3.95%
Memorymem client navigation-churn (vue)1.6 MB1.5 MB+3.87%
Memorymem server request-churn (solid)746.4 KB719.9 KB+3.69%
Memorymem server aborted-requests (solid)1.2 MB1.2 MB+3.32%
Memorymem client loader-data-retention (solid)162.2 KB157.5 KB+3.02%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing chenjiahan:chenjiahan/fix-rsbuild-split-chunks-config (4337e7e) with main (cb281d7)

Open in CodSpeed

@schiller-manuel
schiller-manuel merged commit a0041bb into TanStack:mainAug 22, 2026
23 of 26 checks passed
@github-actionsgithub-actionsBot mentioned this pull request Aug 22, 2026
@chenjiahan
chenjiahan deleted the chenjiahan/fix-rsbuild-split-chunks-config branch August 22, 2026 08:37
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@chenjiahan@schiller-manuel