refactor(table-core): remove SyntheticEvent persist() calls by conao3 · Pull Request #6448 · TanStack/table

conao3 · 2026-07-21T06:29:21Z

🎯 Changes

Removes the (e as any).persist?.() calls from the sorting, expanding, resizing, and selection event handlers, plus the JSDoc / generated reference docs that described them.

persist() was a workaround for React's SyntheticEvent pooling, which was removed in React 17 (the method has been a deprecated no-op since then). v9 requires react >= 18, so these calls can't do anything anymore. Dropping them also removes 4 as any casts from table-core.

References:

React v17 RC announcement, "No Event Pooling": "Note that e.persist() is still available on the React event object, but now it doesn't do anything."
React event object in the react.dev reference: "persist(): Not used with React DOM."

✅ Checklist

I have followed the steps in the Contributing guide.
I have tested this code locally with pnpm test:pr.

Assisted-by: Claude Code:claude-fable-5

coderabbitai · 2026-07-21T06:32:39Z

📝 Walkthrough

Walkthrough

Handlers for row selection, row expansion, sorting, and column resizing no longer call optional event.persist() methods. Documentation and tests were updated to remove persistence-specific statements and assertions.

Changes

Synthetic event persistence removal

Layer / File(s)	Summary
Row selection event handling `packages/table-core/src/features/row-selection/rowSelectionFeature.utils.ts`, `packages/table-core/tests/implementation/features/row-selection/rowSelectionRange.test.ts`, `docs/reference/static-functions/functions/row_getToggleSelectedHandler.md`	Row selection reads `target.checked` without persisting the event, and the persistence-specific test and documentation are removed.
Expansion and sorting toggle handlers `packages/table-core/src/features/row-expanding/rowExpandingFeature.utils.ts`, `packages/table-core/src/features/row-sorting/rowSortingFeature.utils.ts`, `packages/table-core/tests/unit/features/row-expanding/`, `packages/table-core/tests/unit/features/row-sorting/`, `docs/reference/static-functions/functions/table_getToggleAllRowsExpandedHandler.md`, `docs/reference/static-functions/functions/column_getToggleSortingHandler.md`	Expansion and sorting handlers no longer persist events; tests now assert state updates without persistence checks.
Column resize event handling `packages/table-core/src/features/column-resizing/columnResizingFeature.utils.ts`	The resize-start handler no longer invokes optional event persistence.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

TanStack/table#6409: Related row-selection toggle-handler and event-plumbing changes.

Suggested reviewers:kevinvandy

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately summarizes the main change: removing SyntheticEvent persist() calls from table-core.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

nx-cloud · 2026-07-24T15:44:49Z

View your CI Pipeline Execution ↗ for commit 3e74221

Command	Status	Duration	Result
`nx affected --targets=test:eslint,test:sherif,t...`	✅ Succeeded	7m 19s	View ↗
`nx run-many --targets=build --exclude=examples/**`	✅ Succeeded	48s	View ↗

☁️ Nx Cloud last updated this comment at 2026-07-24 15:53:31 UTC

pkg-pr-new · 2026-07-24T15:50:20Z

More templates

@tanstack/alpine-table

npm i https://pkg.pr.new/TanStack/table/@tanstack/alpine-table@6448

@tanstack/angular-table

npm i https://pkg.pr.new/TanStack/table/@tanstack/angular-table@6448

@tanstack/angular-table-devtools

npm i https://pkg.pr.new/TanStack/table/@tanstack/angular-table-devtools@6448

@tanstack/ember-table

npm i https://pkg.pr.new/TanStack/table/@tanstack/ember-table@6448

@tanstack/lit-table

npm i https://pkg.pr.new/TanStack/table/@tanstack/lit-table@6448

@tanstack/match-sorter-utils

npm i https://pkg.pr.new/TanStack/table/@tanstack/match-sorter-utils@6448

@tanstack/preact-table

npm i https://pkg.pr.new/TanStack/table/@tanstack/preact-table@6448

@tanstack/preact-table-devtools

npm i https://pkg.pr.new/TanStack/table/@tanstack/preact-table-devtools@6448

@tanstack/react-table

npm i https://pkg.pr.new/TanStack/table/@tanstack/react-table@6448

@tanstack/react-table-devtools

npm i https://pkg.pr.new/TanStack/table/@tanstack/react-table-devtools@6448

@tanstack/solid-table

npm i https://pkg.pr.new/TanStack/table/@tanstack/solid-table@6448

@tanstack/solid-table-devtools

npm i https://pkg.pr.new/TanStack/table/@tanstack/solid-table-devtools@6448

@tanstack/svelte-table

npm i https://pkg.pr.new/TanStack/table/@tanstack/svelte-table@6448

@tanstack/table-core

npm i https://pkg.pr.new/TanStack/table/@tanstack/table-core@6448

@tanstack/table-devtools

npm i https://pkg.pr.new/TanStack/table/@tanstack/table-devtools@6448

@tanstack/vue-table

npm i https://pkg.pr.new/TanStack/table/@tanstack/vue-table@6448

@tanstack/vue-table-devtools

npm i https://pkg.pr.new/TanStack/table/@tanstack/vue-table-devtools@6448

commit: 3e74221

conao3 · 2026-07-25T09:18:34Z

Thanks!

refactor(table-core): remove SyntheticEvent persist() calls
3e74221

KevinVandy approved these changes Jul 24, 2026
View reviewed changes

KevinVandy merged commit 813f573 into TanStack:betaJul 24, 2026
9 checks passed

coderabbitaiBot mentioned this pull request Aug 2, 2026
fix: honor selection rules in select-all paths, add deselectParents option #6495
Merged

Navigation Menu

Uh oh!

Uh oh!

refactor(table-core): remove SyntheticEvent persist() calls - #6448

refactor(table-core): remove SyntheticEvent persist() calls#6448
KevinVandy merged 1 commit into
TanStack:betafrom
conao3:remove-synthetic-event-persist

conao3 commented Jul 21, 2026•
edited
Loading

Uh oh!

coderabbitaiBot commented Jul 21, 2026•
edited
Loading

Walkthrough

Changes

Uh oh!

nx-cloudBot commented Jul 24, 2026•
edited
Loading

Uh oh!

pkg-pr-newBot commented Jul 24, 2026

Uh oh!

Uh oh!

conao3 commented Jul 25, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Uh oh!

Conversation

conao3 commented Jul 21, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎯 Changes

✅ Checklist

Uh oh!

coderabbitaiBot commented Jul 21, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Uh oh!

nx-cloudBot commented Jul 24, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pkg-pr-newBot commented Jul 24, 2026

Uh oh!

Uh oh!

conao3 commented Jul 25, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

conao3 commented Jul 21, 2026•
edited
Loading

coderabbitaiBot commented Jul 21, 2026•
edited
Loading

nx-cloudBot commented Jul 24, 2026•
edited
Loading