fix(table-core): skip onRowSelectionChange on a no-op toggleAllRowsSelected

[lazerg]

🎯 Changes

table.toggleAllRowsSelected(true) rebuilds the whole selection map and calls onRowSelectionChange even when every selectable row is already selected, and toggleAllRowsSelected(false) does the same when nothing is selected. Consumers that mirror rowSelection into a URL or onto a server get a redundant write on every no-op toggle.

toggleAllRowsExpanded grew the equivalent guards in #6501, and #6532 kept those O(1) checks on purpose while leaving the general setRowSelection unguarded. This adds the matching pair: return early when selection is requested and getIsAllRowsSelected() is already true, and when deselection is requested and nothing is selected. Both read memoized getters, so the row-scaled map comparison that setRowSelection deliberately avoids stays out of the picture.

Three adapter tests drove their second onRowSelectionChange through toggleAllRowsSelected(false) with a mock handler that never writes state back, leaving the selection empty, so that call is now a no-op. They toggle selection on instead.

Fixes#6538

✅ Checklist

• I have followed the steps in the Contributing guide.
• I have tested this code locally with pnpm run test:pr.

Green across all 409 projects except @tanstack/ember-table:test:lib, whose testem browser will not start on my machine. It fails the same way on an unmodified main.

🚀 Release Impact

• This change affects published code, and I have generated a changeset.
• This change is docs/CI/dev-only (no release).

Summary by CodeRabbit

• Bug Fixes

  • Prevented redundant row-selection updates when all selectable rows are already selected or deselected.
  • Avoided triggering selection change callbacks for no-op toggle requests.
  • Preserved selection updates when the table contains a mix of selected and unselected rows.

• Tests

  • Added coverage for redundant selection operations and partial-selection scenarios.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: b3326976-e322-4c18-ad84-8b1700da00ea

📥 Commits

Reviewing files that changed from the base of the PR and between d9cca00 and f0019c5.

📒 Files selected for processing (6)

• .changeset/toggle-all-rows-selected-noop.md
• packages/alpine-table/tests/unit/adapterCoverage.test.ts
• packages/lit-table/tests/unit/adapterLifecycle.test.ts
• packages/solid-table/tests/unit/adapterReactivity.test.ts
• packages/table-core/src/features/row-selection/rowSelectionFeature.utils.ts
• packages/table-core/tests/unit/features/row-selection/rowSelectionFeature.utils.test.ts

---

📝 Walkthrough

Walkthrough

table.toggleAllRowsSelected() now skips onRowSelectionChange when the requested state already matches the current selection. Core tests cover redundant and partial selections, and adapter tests use explicit selection.

Changes

Row selection no-op behavior

Layer / File(s)	Summary
Selection guard and core coverage packages/table-core/src/features/row-selection/rowSelectionFeature.utils.ts, packages/table-core/tests/unit/features/row-selection/rowSelectionFeature.utils.test.ts	The toggle checks whether all or no selectable rows are already selected before updating. Tests cover redundant select, redundant deselect, deselectAll, and partial selection.
Adapter callback validation packages/alpine-table/tests/unit/adapterCoverage.test.ts, packages/lit-table/tests/unit/adapterLifecycle.test.ts, packages/solid-table/tests/unit/adapterReactivity.test.ts, .changeset/toggle-all-rows-selected-noop.md	Adapter tests invoke explicit select-all operations after callback replacement. The changeset documents the no-op behavior.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

• TanStack/table#6495: Modifies the same row-selection utility and related tests for different selection rules.
• TanStack/table#6532: Addresses no-op row-selection updates through centralized state-guard behavior.
• TanStack/table#6540: Adds no-op guards to a different toggle-all API.

Suggested reviewers:kevinvandy

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and concisely describes the primary change: skipping callbacks for no-op toggleAllRowsSelected calls.
Description check	✅ Passed	The description explains the change, motivation, testing, checklist status, release impact, and generated changeset.
Linked Issues check	✅ Passed	The implementation satisfies issue #6538 by adding inexpensive no-op guards while preserving setRowSelection behavior.
Out of Scope Changes check	✅ Passed	The implementation, tests, adapter updates, and changeset directly support the linked issue and stated objectives.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}