Fix Charts catalog frame embedding

[tannerlinsley]

Fixes Charts documentation embeds blocked by X-Frame-Options: DENY.

TanStack Start canonicalizes catalog embed routes by removing the trailing slash. The frame allowlist only matched the pre-redirect trailing-slash path, so the final document inherited the global denial header.

This accepts both canonical route forms at the hosting-header boundary and adds regression coverage.

Validation:

• pnpm exec tsx --test tests/charts-catalog-frame-embedding.test.ts (3 passing)
• full unit suite (113 passing, 1 skipped)
• full repository hook remains blocked on current main by unrelated unresolved Charts landing imports (@tanstack/charts, d3-scale, d3-shape, and ../../packages/charts-core/src/index.ts)

Summary by CodeRabbit

• Bug Fixes
  • Chart catalog embed pages now work with or without a trailing slash in the URL.
  • Updated frame-embedding behavior to correctly allow supported catalog embed paths while continuing to block other paths.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 161d00f5-00df-4fd7-b494-ae7bc7eacd85

📥 Commits

Reviewing files that changed from the base of the PR and between 185a7fb and 21101af.

📒 Files selected for processing (2)

• src/utils/frame-embedding.ts
• tests/charts-catalog-frame-embedding.test.ts

---

📝 Walkthrough

Walkthrough

Chart catalog frame embedding now permits both base paths and trailing-slash variants. The related test uses the non-trailing-slash path as the exact allowed document and updates denied paths accordingly.

Changes

Chart catalog embedding

Layer / File(s)	Summary
Allow trailing-slash catalog embeds src/utils/frame-embedding.ts, tests/charts-catalog-frame-embedding.test.ts	isFrameEmbeddingAllowed accepts chart catalog embed paths with or without a trailing slash, and the bypass test reflects the updated exact-path behavior.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

• TanStack/tanstack.com#1068: Updates the same frame-embedding logic and chart catalog embed path tests.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly summarizes the main change: allowing Charts catalog embeds to frame correctly.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches 💡 1

📝 Generate docstrings 💡

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/charts-catalog-frame-embedding

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[cloudflare-workers-and-pages]

Deploying with Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status	Name	Latest Commit	Preview URL	Updated (UTC)
✅ Deployment successful! View logs	tanstack-com	21101af	Commit Preview URL Branch Preview URL	Jul 29 2026, 07:35 PM