Uh oh!
There was an error while loading. Please reload this page.
fix(intent/registry): restore 'Copy install prompt' button label - #1101
Conversation
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe package registry route changes the copy-install button label to “Copy install prompt” while retaining the existing icon and behavior. ChangesCopy install prompt label
Estimated code review effort: 1 (Trivial) | ~2 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Deploying with |
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs | tanstack-com | 6e929f8 | Commit Preview URL Branch Preview URL | Aug 03 2026, 05:03 AM |
Uh oh!
There was an error while loading. Please reload this page.
The install-prompt button on package detail pages renders as "CopyIcon install prompt" instead of "Copy install prompt".
This is a regression from #1094. The codemod that renamed phosphor icons to their
Icon-suffixed exports treated the wordCopyin the button's JSX text as a component reference and rewrote it.Why CI did not catch it
The damage is in a text node, so it is valid JSX and valid TypeScript.
tsc,oxlint, and the 143 unit tests all pass on the broken code — it is already live in production.Worth noting the same masking bug went the other way in
NPMStatsChart.tsxduring #1094, where an actual<Copy />component was missed. That one raised TS2304 and got fixed before merge. Only the text-node direction is silent.Scope
I re-checked the whole #1094 diff for the same class of damage:
Everything else that matched is a legitimate import alias or generated-registry entry. This is the only affected string.
Testing
Found by opening a package page on a preview deploy — the accessibility tree exposed the button as
"CopyIcon install prompt".pnpm testpasses.Summary by CodeRabbit