Uh oh!
There was an error while loading. Please reload this page.
Defer mobile navbar auth loading - #1110
Conversation
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthrough
ChangesMobile authentication loading
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Deploying with |
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs | tanstack-com | 148105c | Commit Preview URL Branch Preview URL | Aug 04 2026, 02:13 PM |
Uh oh!
There was an error while loading. Please reload this page.
Evidence
PR #1105 added
MobileNavbarAuthControlsinside the mobile menu.CollapsibleContentkeeps its children mounted while closed, so the new lazy component started importing on every page render rather than when the menu opened.The production client graph maps that dynamic path to 10 assets totaling 231,759 uncompressed bytes before cache reuse. Mounting the component also calls
useCurrentUserQuery, so a closed mobile menu could start auth work that the existing desktop navbar intentionally defers until interaction.Follow-up to #1105 and the implementation of #1090.
Change
Keep the existing signed-out link mounted while the mobile menu is closed. Mount
MobileNavbarAuthControlsonly aftermobileMenuOpenbecomes true.Authenticated mobile behavior is unchanged once the menu opens.
Impact
Avoids eager auth chunk loading and current-user query work for visitors who do not open the mobile menu.
Validation
pnpm test— 144 passed, 1 intentional skip; TypeScript and lint cleanpnpm build— passedgit diff --check— passedRisk
Low. The closed menu still renders the same Sign In fallback, and opening the menu preserves the existing Suspense fallback while auth state loads.
Summary by CodeRabbit