Uh oh!
There was an error while loading. Please reload this page.
Load AI dock on first open - #1122
Merged
Merged
Conversation
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe AI dock entry points now mark search as loaded before opening the dock or submitting a question. ChangesAI dock search initialization
Estimated code review effort: 1 (Trivial) | ~3 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Deploying with |
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs | tanstack-com | 79186fb | Commit Preview URL Branch Preview URL | Aug 05 2026, 03:11 PM |
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Evidence
SearchProviderrenderedLazySearchModalonly afterhasLoadedSearchbecame true.openSearchset that flag, butopenAiDockandaskAiDockdid not, so a first direct Ask AI action could set the dock state without mounting the component that renders it. This matches the missing sidebar reported in #1116 and is independent of extension behavior.Impact
The desktop and mobile Ask AI actions now render the dock on first use while keeping the search/AI bundle lazy until the user invokes it.
Validation
pnpm test(144 pass, 1 intentional skip; TypeScript and lint clean)pnpm testsuccessfullygit diff --checkRisk
Low. The change only flips the existing lazy-mount flag in the two AI entry points; subsequent opens and normal Search behavior are unchanged.
Fixes#1116
Summary by CodeRabbit