Skip to content

Show loading feedback for Charts catalog details#1147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tannerlinsley merged 3 commits into from
Aug 15, 2026
Merged

Show loading feedback for Charts catalog details #1147

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
99f76f0
Show pending state for Charts catalog details
GregorGabric Aug 14, 2026
673bb38
Strengthen catalog pending-state regression
GregorGabric Aug 14, 2026
0beeee6
Remove catalog pending-state test
GregorGabric Aug 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions src/components/charts/ChartsCatalogPages.tsx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -135,6 +135,20 @@ export function ChartsCatalogDetail({
)
}

export function ChartsCatalogDetailPending() {
return (
<CatalogSurface wide>
<p
aria-live="polite"
className="rounded-lg border border-gray-200 p-6 text-sm text-gray-500 dark:border-gray-800"
role="status"
>
Loading chart example…
</p>
</CatalogSurface>
)
}

function CatalogWorkbenchFallback({
catalogCase,
}: {
Expand Down
7 changes: 6 additions & 1 deletion src/routes/_library/charts.catalog.charts.$caseId.tsx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,8 @@
import { createFileRoute, notFound } from '@tanstack/react-router'
import { ChartsCatalogDetail } from '~/components/charts/ChartsCatalogPages'
import {
ChartsCatalogDetail,
ChartsCatalogDetailPending,
} from '~/components/charts/ChartsCatalogPages'
import { getChartsCatalogCase } from '~/utils/charts-catalog.functions'
import { seo } from '~/utils/seo'

Expand All@@ -14,6 +17,8 @@ export const Route = createFileRoute('/_library/charts/catalog/charts/$caseId')(
if (!data) throw notFound()
return data
},
pendingComponent: ChartsCatalogDetailPending,
pendingMs: 250,
component: ChartsCatalogCaseRoute,
head: ({ loaderData }) => ({
meta: seo({
Expand Down