Skip to content

Add ShadCN Charts catalog collection - #1156

Merged
tannerlinsley merged 1 commit into
mainfrom
taren/charts-shadcn-collection
Aug 14, 2026
Merged

Add ShadCN Charts catalog collection#1156
tannerlinsley merged 1 commit into
mainfrom
taren/charts-shadcn-collection

Conversation

@tannerlinsley

@tannerlinsleytannerlinsley commented Aug 14, 2026

Copy link
Copy Markdown
Member

Summary

  • add a native Charts catalog collection route
  • expose the ShadCN collection in the catalog and sitemap
  • keep collection/detail navigation within the Examples tab

Validation

  • pnpm test
  • local visual audit of collection and detail routes

Summary by CodeRabbit

  • New Features
    • Added chart collections to the catalog, including collection pages with headings, descriptions, breadcrumbs, and example counts.
    • Added the “shadcn” collection and navigation to browse its charts.
    • Added collection-specific sitemap entries and SEO metadata.
  • Bug Fixes
    • Unknown or empty collections now return a not-found result instead of displaying incomplete content.
  • Tests
    • Added coverage for collection parsing, navigation, sitemap generation, and catalog behavior.

@coderabbitai

coderabbitaiBot commented Aug 14, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 96ffad3c-efe5-47e1-9e50-26bb5a18b413

📥 Commits

Reviewing files that changed from the base of the PR and between 9d5b12e and 150d050.

📒 Files selected for processing (9)
  • src/components/charts/ChartsCatalogPages.tsx
  • src/routeTree.gen.ts
  • src/routes/_library/charts.catalog.collections.$collectionId.tsx
  • src/utils/charts-catalog-index.ts
  • src/utils/charts-catalog.functions.ts
  • src/utils/charts-catalog.ts
  • tests/charts-catalog-index.test.ts
  • tests/charts-catalog-site-contracts.test.ts
  • tests/charts-sidebar-navigation.test.ts

📝 Walkthrough

Walkthrough

The chart catalog now supports collections. It validates collection metadata, retrieves published cases by collection, adds collection routes and sitemap entries, and renders collection-specific headings, links, counts, SEO metadata, and breadcrumbs.

Changes

Chart catalog collections

Layer / File(s)Summary
Collection data and sitemap contracts
src/utils/charts-catalog.ts, src/utils/charts-catalog-index.ts, tests/charts-catalog-index.test.ts, tests/charts-catalog-site-contracts.test.ts
Catalog cases accept optional collection IDs. The shadcn collection is defined and resolved. Sitemap generation includes populated collection paths. Tests cover parsing and sitemap output.
Collection catalog retrieval
src/utils/charts-catalog.functions.ts
getChartsCatalogCollection() validates the collection ID, filters published cases, returns collection metadata and revision, and returns null for missing or empty collections.
Collection route and route-tree wiring
src/routes/_library/charts.catalog.collections.$collectionId.tsx, src/routeTree.gen.ts
The new collection route loads data, handles missing collections, configures SEO metadata, and renders ChartsCatalog. Generated route declarations expose the collection path.
Collection-aware catalog views
src/components/charts/ChartsCatalogPages.tsx, tests/charts-sidebar-navigation.test.ts
List and detail views render collection headings, counts, links, and breadcrumbs. Navigation tests recognize the collection route.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Merge Risk:⚪ Minimal · up to 150d0

The PR adds the Charts catalog collection and related navigation with no actionable merge-blocking risk remaining after normal checks and review.

Sequence Diagram(s)

sequenceDiagram
participant Browser
participant CollectionRoute
participant CatalogEndpoint
participant ChartsCatalog
Browser->>CollectionRoute: Request collection URL
CollectionRoute->>CatalogEndpoint: Load collectionId
CatalogEndpoint->>ChartsCatalog: Return collection cases and revision
ChartsCatalog->>Browser: Render collection catalog
Loading
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly identifies the main change: adding the ShadCN Charts catalog collection and its supporting catalog route.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch taren/charts-shadcn-collection

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cloudflare-workers-and-pages

cloudflare-workers-and-pagesBot commented Aug 14, 2026

Copy link
Copy Markdown

Deploying with Cloudflare Workers Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

StatusNameLatest CommitPreview URLUpdated (UTC)
✅ Deployment successful!
View logs
tanstack-com150d050Commit Preview URL

Branch Preview URL
Aug 14 2026, 04:03 PM

@tannerlinsley
tannerlinsley merged commit b5fce06 into mainAug 14, 2026
7 checks passed
@tannerlinsley
tannerlinsley deleted the taren/charts-shadcn-collection branch August 14, 2026 16:05
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@tannerlinsley