Uh oh!
There was an error while loading. Please reload this page.
Tests: ComboBox - Recreate test suite for new implementation - #86
Merged
nicolas-jaussaud merged 10 commits intoAug 14, 2026
Merged
Conversation
Picks up MultiCombobox (searchable multi-select — needed for the combo-box field migration's multiple+async case), Chip onRemove, and the Combobox aria-describedby/invalid/required forwarding fix. Compat: TUI 0.2.0's Button dropped the `iconSize` prop (icons size intrinsically now) — removed it from the base Button wrapper + its story. tsc error count unchanged from 0.1.x (422 pre-existing); rebuilt bundle. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Replace the react-aria/react-stately select-field internals with TUI's Select (single) and MultiSelect (multiple), in the TUI Field idiom. Static-only (select has no async), so the contract is simple and preserved — verified live: - single: hidden input = the key - multiple: hidden input = "a,b,c"; onChange([...keys]) (array, as before) New: Single.tsx (TUI Select + hidden input for form submission, replacing react-aria HiddenSelect), Multiple.tsx (TUI MultiSelect, display=chips), renderOptions.tsx (flat/grouped/disabledKeys). Removed MultipleSelect.tsx. Note: select/Select.tsx (the react-aria Select) is KEPT — it's still an internal building block for the gradient / dimensions / simple-dimension fields; only the select FIELD TYPE stops using it. Its .tf-select styles stay; the migrated field uses a distinct .tf-select-field class. tsc 422 -> 414; rebuilt bundle. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…input value to label
…tests to new implementation
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #80, we modified existing tests to run them for the deprecated combo-box only
This PR adapt the legacy tests and to run them for the new combo-box implementation