Skip to content

🔒 Fix SQL Injection vulnerability in sqlite queries#48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Tcode-Motion merged 2 commits into from
Aug 25, 2026
Merged

🔒 Fix SQL Injection vulnerability in sqlite queries #48

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7986cb0
fix: prevent SQL injection in sqlite execute and query
google-labs-jules[bot] Aug 25, 2026
3517750
Merge branch 'main' into fix-sqlite-sql-injection-16742585625164495187
Tcode-Motion Aug 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
72 changes: 46 additions & 26 deletions stdlib/src/sqlite.rs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -12,6 +12,17 @@ thread_local! {

static NEXT_ID: AtomicI64 = AtomicI64::new(1);

fn runtime_to_sql_value(v: &RuntimeValue) -> rusqlite::types::Value {
match v {
RuntimeValue::Null => rusqlite::types::Value::Null,
RuntimeValue::Bool(b) => rusqlite::types::Value::Integer(if *b { 1 } else { 0 }),
RuntimeValue::Int(i) => rusqlite::types::Value::Integer(*i),
RuntimeValue::Float(f) => rusqlite::types::Value::Real(*f),
RuntimeValue::Str(s) => rusqlite::types::Value::Text(s.clone()),
_ => rusqlite::types::Value::Text(v.to_string()),
}
}

impl StdlibRegistry {
pub fn register_sqlite(&mut self) {
let mut exports: HashMap<String, Rc<dyn techscript_runtime::function::Callable>> =
Expand DownExpand Up@@ -62,35 +73,27 @@ impl StdlibRegistry {
Vec::new()
};

let params: Vec<rusqlite::types::Value> = if let Some(arg) = args.get(2) {
if let RuntimeValue::List { items, .. } = arg {
items.borrow().iter().map(runtime_to_sql_value).collect()
} else {
return Err(RuntimeError::new(
RuntimeErrorKind::TypeMismatch {
expected: "list".to_string(),
found: arg.runtime_type().to_string(),
},
None,
None,
));
}
} else {
Vec::new()
};

CONNECTIONS.with(|m| {
let mut map = m.borrow_mut();
if let Some(conn) = map.get_mut(&id) {
let params_converted: Vec<rusqlite::types::Value> = params_list
.iter()
.map(|p| match p {
RuntimeValue::Null => rusqlite::types::Value::Null,
RuntimeValue::Bool(b) => {
rusqlite::types::Value::Integer(if *b { 1 } else { 0 })
}
RuntimeValue::Int(i) => rusqlite::types::Value::Integer(*i),
RuntimeValue::Float(f) => rusqlite::types::Value::Real(*f),
RuntimeValue::Str(s) => rusqlite::types::Value::Text(s.clone()),
_ => rusqlite::types::Value::Null,
})
.collect();

let params_refs: Vec<&dyn rusqlite::types::ToSql> = params_converted
.iter()
.map(|p| p as &dyn rusqlite::types::ToSql)
.collect();

conn.execute(&sql, params_refs.as_slice()).map_err(|e| {
RuntimeError::new(
RuntimeErrorKind::InvalidOperation(e.to_string()),
None,
None,
)
})?;
Ok(())
} else {
Err(RuntimeError::new(
Expand DownExpand Up@@ -131,6 +134,23 @@ impl StdlibRegistry {
Vec::new()
};

let params: Vec<rusqlite::types::Value> = if let Some(arg) = args.get(2) {
if let RuntimeValue::List { items, .. } = arg {
items.borrow().iter().map(runtime_to_sql_value).collect()
} else {
return Err(RuntimeError::new(
RuntimeErrorKind::TypeMismatch {
expected: "list".to_string(),
found: arg.runtime_type().to_string(),
},
None,
None,
));
}
} else {
Vec::new()
};

let rows = CONNECTIONS.with(|m| {
let mut map = m.borrow_mut();
if let Some(conn) = map.get_mut(&id) {
Expand DownExpand Up@@ -167,7 +187,7 @@ impl StdlibRegistry {

let mut rows = Vec::new();
let row_iter = stmt
.query_map(params_refs.as_slice(), |row| {
<<<<<
let mut map = IndexMap::new();
for i in 0..col_count {
let name = col_names[i].clone();
Expand Down
Loading