Uh oh!
There was an error while loading. Please reload this page.
Fix handling of plane YZ in Pauli flow - #297
Merged
thierry-martinez merged 1 commit intoJun 6, 2025
Merged
Conversation
@Newtech66 reported that the plane YZ was not handled correctly in Pauli flow (TeamGraphix#279 (comment)): | It's because the `get_pauli_nodes` method in `gflow.py` is | incorrect. See here. Specifically, the cases for the Y Z plane are | switched. Test cases were written following the same incorrect convention and failed to detect the issue. This commit fixes the test cases and uses the `PauliMeasurement.try_from` constructor instead of reimplementing the Pauli axis computation, ensuring the convention is defined in one place and for all.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@## master #297 +/- ##
==========================================
- Coverage 79.86% 79.83% -0.04%
==========================================
Files 36 36 Lines 5433 5429 -4 ==========================================
- Hits 4339 4334 -5 - Misses 1094 1095 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
shinich1
approved these changes
Jun 6, 2025
shinich1
left a comment
Contributor
There was a problem hiding this comment.
LGTM, may I ask @Newtech66 also to take a quick look?
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@Newtech66 reported that the plane YZ was not handled correctly in Pauli flow (#279 (comment)):
Test cases were written following the same incorrect convention and failed to detect the issue. This commit fixes the test cases and uses the
PauliMeasurement.try_fromconstructor instead of reimplementing the Pauli axis computation, ensuring the convention is defined in one place and for all.