Uh oh!
There was an error while loading. Please reload this page.
Branch selection - #300
Conversation
This commit adds an abstract class `BranchSelector` and the following branch selection strategies: - `RandomBranchSelector`, which corresponds to the strategy that was already implemented. - `FixedBranchSelector`, for a selector where a dictionary sets the outcome for each measurement. - `ConstBranchSelector`, for a selector that always returns the same outcome, whatever the measurement is.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@## master #300 +/- ##
==========================================
- Coverage 79.36% 79.28% -0.08%
==========================================
Files 39 40 +1 Lines 5733 5794 +61 ==========================================
+ Hits 4550 4594 +44 - Misses 1183 1200 +17 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
EarlMilktea
commented
Jun 26, 2025
@thierry-martinez I'm not against the concept of this PR but I cannot sure whether it is appropriate to introduce this feature to the untyped/obsolete simulators. |
thierry-martinez
commented
Jul 6, 2025
Granted. I just opened #312, which will hopefully help unblock this. |
thierry-martinez
commented
Jul 25, 2025
Branch selection is now ready for review with the typed simulator! |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
thierry-martinez
commented
Jul 30, 2025
Thanks, @EarlMilktea, for your review! @shinich1, I updated the documentation. Could you take a look at this PR and let us know what you think? Thanks! |
shinich1
left a comment
There was a problem hiding this comment.
Sorry for the delay, looks great.
This commit adds an abstract class
BranchSelectorand the following branch selection strategies:RandomBranchSelector, which corresponds to the strategy that was already implemented.FixedBranchSelector, for a selector where a dictionary sets the outcome for each measurement.ConstBranchSelector, for a selector that always returns the same outcome, whatever the measurement is.