Uh oh!
There was an error while loading. Please reload this page.
Fix reverse dependency in noxfile.py: use temporary directory - #303
Merged
thierry-martinez merged 6 commits intoJul 5, 2025
Merged
Conversation
This commit updates `noxfile.py` to use a temporary directory when cloning the reverse dependency `graphix-symbolic`. @EarlMilkea [suggested](TeamGraphix#302 (comment)) extracting this specific change from TeamGraphix#302, as it is unrelated to the rest of that PR. Previously, `noxfile.py` cloned `graphix-symbolic` directly into the working directory without cleanup. As a result, the `graphix-symbolic` directory persisted after running `nox`, causing subsequent calls to `pytest` to fail due to multiple `conftest.py` files being present (one in `tests/`, and another in `graphix-symbolic/tests/`).
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@## master #303 +/- ##
=======================================
Coverage 79.97% 79.97% =======================================
Files 35 35 Lines 5398 5398 =======================================
Hits 4317 4317 Misses 1081 1081 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
thierry-martinez
commented
Jun 13, 2025
CollaboratorAuthor
This changes the template for #285. |
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit updates
noxfile.pyto use a temporary directory when cloning the reverse dependencygraphix-symbolic.@EarlMilkteasuggested extracting this specific change from #302, as it is unrelated to the rest of that PR.
Previously,
noxfile.pyclonedgraphix-symbolicdirectly into the working directory without cleanup. As a result, thegraphix-symbolicdirectory persisted after runningnox, causing subsequent calls topytestto fail due to multipleconftest.pyfiles being present (one intests/, and another ingraphix-symbolic/tests/).