Uh oh!
There was an error while loading. Please reload this page.
fix(visualization): keep layer arrow in frame for linear flows - #536
fix(visualization): keep layer arrow in frame for linear flows#536shantoshdurai wants to merge 1 commit into
Conversation
Set preliminary plot limits before drawing layer annotations so point-based offsets map correctly when all nodes share one y row. Expand ymin for layer label height and enforce a minimum vertical axis span for degenerate layouts. Fixes#535
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@## master #536 +/- ##
==========================================
- Coverage 88.85% 88.83% -0.03%
==========================================
Files 49 49 Lines 7135 7146 +11 ==========================================
+ Hits 6340 6348 +8 - Misses 795 798 +3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
matulni
commented
Jun 13, 2026
Hi @shantoshdurai, thanks for your contribution! In addition, to clear up any possible confusion, note that this issue is not part of UnitaryHack 2026, and there is no bounty on it. |
thierry-martinez
commented
Jun 16, 2026
The CI is broken because of a new Matplotlib release. It was fixed in #541, which has now been merged. Could you merge the current master into your branch? |
matulni
commented
Jul 13, 2026
Subsumed by #559 |
Fixes#535
Linear open graphs place every node on one row, so
ymin == ymax. Layer labels use fixed point offsets belowplot_lims.ymin, but the ymin adjustment in_draw_layersran before axis limits were set, so the data/display transform was degenerate and the "Layer" arrow ended up below the plot frame.Changes
_draw_layersso point-based offsets map correctlyyminto include layer label height (va='top') plus padding_set_plot_limswhen node rows collapse to one linetest_linear_causal_flow_layer_label_in_frameVerify