Skip to content

fix: wrong cobblemon apricorn texture paths - #29

Merged
Motschen merged 3 commits into
TeamMidnightDust:mainfrom
hudsonm62:main
Jun 4, 2026
Merged

fix: wrong cobblemon apricorn texture paths#29
Motschen merged 3 commits into
TeamMidnightDust:mainfrom
hudsonm62:main

Conversation

@hudsonm62

Copy link
Copy Markdown
Contributor

They probably were in much earlier versions, but the texture path for apricorn logs/stripped logs are incorrect and was causing null textures as seen in #21

Changing model textures to "cobblemon:block/wood/*"fixes#21

Reference

https://gitlab.com/cable-mc/cobblemon/-/tree/main/common/src/main/resources/assets/cobblemon/textures/block/wood

Tested Result

image

Note: tested in both 1.20.1 and 1.21.1

--

FYI was unsure if I was supposed to edit the ./input/assets too, but I did anyway as I would like to get this merged asap -- perhaps a contributing guide would be nice for future potential maintainers!

They probably were in earlier versions, but the texture path for apricorn logs are incorrect and was causing null textures
Changing model textures to `"cobblemon:block/wood/*"` fixes issue #21https://gitlab.com/cable-mc/cobblemon/-/tree/main/common/src/main/resources/assets/cobblemon/textures/block/wood
CopilotAI review requested due to automatic review settings June 1, 2026 12:00

CopilotAI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Updates Round Trees to v8.3 by correcting Cobblemon apricorn log model texture paths and reflecting the change in metadata and changelog.

Changes:

  • Bump pack description version from 8.2 to 8.3
  • Fix Cobblemon apricorn log / stripped apricorn log model texture paths to use cobblemon:block/wood/...
  • Add v8.3 entry to the changelog

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
FileDescription
pack.mcmetaUpdates displayed pack version to 8.3
input/assets/cobblemon/models/block/apricorn_log.jsonPoints model textures to cobblemon:block/wood/...
input/assets/cobblemon/models/block/stripped_apricorn_log.jsonPoints model textures to cobblemon:block/wood/...
assets/cobblemon/models/block/apricorn_log.jsonPoints model textures to cobblemon:block/wood/...
assets/cobblemon/models/block/stripped_apricorn_log.jsonPoints model textures to cobblemon:block/wood/...
CHANGELOG.mdDocuments the texture-path fix in v8.3

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment threadpack.mcmeta Outdated
"min_format": 15,
"max_format": 255,
"description": "§2Version 8.2\n§e©Motschen 2026 | MIT Licence"
"description": "§2Version 8.3\n§e©Motschen 2026 | MIT Licence"
@hudsonm62

Copy link
Copy Markdown
ContributorAuthor

that should make copilot happy 😆

@hudsonm62
hudsonm62 requested a review from CopilotJune 1, 2026 12:05

CopilotAI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated no new comments.

@hudsonm62

hudsonm62 commented Jun 1, 2026

Copy link
Copy Markdown
ContributorAuthor

@Motschen I would appreciate a review at your earliest convenience :) its been tested in both major supported versions of Cobblemon

@Motschen

Copy link
Copy Markdown
Member

Awesome – thanks a lot!
There is currently no contributor guide, as the build process is quite similar to Better Leaves, but I'll make sure to create a dedicated wiki page soon.
As you figured, it is very important to modify the files in input/, as they are used actually build the pack and generate the asset files.
I'm sorry you had to deal with Copilot here, I never even enabled that crap.

@Motschen
Motschen merged commit f665eff into TeamMidnightDust:mainJun 4, 2026
1 check passed
@hudsonm62

Copy link
Copy Markdown
ContributorAuthor

Hahahah Microsoft/GitHub been pushing Copilot on everyone, these days it's an opt-out not opt-in thing

Appreciate the merge homie, have a good Friday and weekend

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cobblemon 1.7.1 (Neoforge 1.21.1)

3 participants

@hudsonm62@Motschen