Skip to content

deprecate usage of ShareDbMongo as a function - #2

Open
dcharbonnier wants to merge 1 commit into
Teamwork:masterfrom
dcharbonnier:feature/deprecate-no-new
Open

deprecate usage of ShareDbMongo as a function#2
dcharbonnier wants to merge 1 commit into
Teamwork:masterfrom
dcharbonnier:feature/deprecate-no-new

Conversation

@dcharbonnier

Copy link
Copy Markdown

Anticipate the es6 class

@coveralls

coveralls commented Jul 13, 2018

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 14

  • 1 of 1(100.0%) changed or added relevant line in 1 file are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.1%) to 89.814%

Files with Coverage ReductionNew Missed Lines%
index.js389.81%
TotalsCoverage Status
Change from base Build 12:0.1%
Covered Lines:650
Relevant Lines:700

💛 - Coveralls

@gkubisa
gkubisa self-requested a review July 13, 2018 14:51

@gkubisagkubisa left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@curran

Copy link
Copy Markdown

Looks great! Will require a major version bump though, to respect semver.

Related #3

@gkubisa

Copy link
Copy Markdown

This is just a console.warn, so a patch version is fine. We'll need to bump the major version when we actually start throwing errors.

@curran

Copy link
Copy Markdown

Good call!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@dcharbonnier@coveralls@curran@gkubisa