Update XSeries to 13.7.1 and relocate its package to fix plugin confl… - #16
Open
tommasov03 wants to merge 2 commits into
Open
Update XSeries to 13.7.1 and relocate its package to fix plugin confl…#16tommasov03 wants to merge 2 commits into
tommasov03 wants to merge 2 commits into
Conversation
…icts XMaterial's static initializer threw NumberFormatException while parsing newer Minecraft version strings (up to 26.2), which the old bundled XSeries 6.0.1 couldn't handle. Because the com.cryptomorin.xseries package was shaded unrelocated, Bukkit's cross-plugin class resolution let other plugins (e.g. UltraCoinFlip) pick up HomeGUI's broken XMaterial class via Class.forName, crashing their enable and disabling their commands too. Bumping to XSeries 13.7.1 (tested against Spigot 26.2) restores support for the full 1.8-26.2 range, and relocating the shaded package to com.technovision.homegui.libs.xseries isolates it so it can no longer leak into or collide with other plugins' classloading.
…sk I/O InventoryClickEvent was only cancelled when the clicked slot held an item, and InventoryDragEvent was never handled at all, so a player could drag or click a real item into an empty HomeGUI/ChangeIconGUI slot; with no InventoryCloseEvent to return it, the item was simply lost. Both GUIs now cancel every click and drag unconditionally. Also removed the per-home YAML file reload in PlayerDataReader.getItem (it was reading the player's icon data file from disk once per home in the /home GUI) in favor of loading it once per GUI open, hoisted the repeated config lookups out of HomeGUI's item loop, guarded against a null Material lookup that could NPE, and simplified the redundant modulo loop in calculateSize().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…icts
XMaterial's static initializer threw NumberFormatException while parsing newer Minecraft version strings (up to 26.2), which the old bundled XSeries 6.0.1 couldn't handle. Because the com.cryptomorin.xseries package was shaded unrelocated, Bukkit's cross-plugin class resolution let other plugins (e.g. UltraCoinFlip) pick up HomeGUI's broken XMaterial class via Class.forName, crashing their enable and disabling their commands too.
Bumping to XSeries 13.7.1 (tested against Spigot 26.2) restores support for the full 1.8-26.2 range, and relocating the shaded package to com.technovision.homegui.libs.xseries isolates it so it can no longer leak into or collide with other plugins' classloading.