FEATURE: ReportSys test for SLES pallet patch - #825

Open
megkido wants to merge 4 commits into
developfrom
feature/test_sles_patches
Open

FEATURE: ReportSys test for SLES pallet patch#825
megkido wants to merge 4 commits into
developfrom
feature/test_sles_patches

Conversation

@megkido

@megkidomegkido commented Aug 24, 2020•
edited
Loading

Copy link
Copy Markdown

Output

frontend-0-0:/opt/stack/lib/python3.8/site-packages/stack/commands/report/system/tests # stack report system
====================================== test session starts ======================================
platform linux -- Python 3.8.3, pytest-6.0.1, py-1.9.0, pluggy-0.13.1 -- /opt/stack/bin/python3
cachedir: .pytest_cache
rootdir: /opt/stack/lib/python3.8/site-packages/stack/commands/report/system
plugins: testinfra-1.16.0
collected 35 items
tests/test_stacki.py::test_stack_list[local-box] PASSED
tests/test_stacki.py::test_stack_list[local-pallet] PASSED
tests/test_stacki.py::test_stack_list[local-cart] PASSED
tests/test_stacki.py::test_stack_list[local-network] PASSED
tests/test_stacki.py::test_stack_list[local-host] PASSED
tests/test_stacki.py::test_stack_list[local-host interface] PASSED
tests/test_stacki.py::test_stacki_pallets_sane[local] PASSED
tests/test_stacki.py::test_stacki_central_server[local] PASSED
tests/test_stacki.py::test_stacki_ca_correct[local] PASSED
tests/test_services.py::test_service_enabled_and_running[local-dhcpd] PASSED
tests/test_services.py::test_service_enabled_and_running[local-named] SKIPPED
tests/test_services.py::test_service_enabled_and_running[local-rsyslog] PASSED
tests/test_services.py::test_service_enabled_and_running[local-smq-processor] PASSED
tests/test_services.py::test_service_enabled_and_running[local-smq-producer] PASSED
tests/test_services.py::test_service_enabled_and_running[local-smq-publisher] PASSED
tests/test_services.py::test_service_enabled_and_running[local-sshd] PASSED
tests/test_services.py::test_service_enabled_and_running[local-chronyd] PASSED
tests/test_services.py::test_service_enabled_and_running[local-apache2] PASSED
tests/test_services.py::test_service_enabled_and_running[local-mysql] PASSED
tests/test_services.py::test_tftpd_enabled_and_running[local] PASSED
tests/test_services.py::test_logrotate_service_enabled[local] PASSED
tests/test_services.py::test_logrotate_configuration_valid[local] PASSED
tests/test_services.py::test_stacki_logrotate_file_exists[local] PASSED
tests/test_restapi.py::test_restapi_list_host PASSED
tests/test_backend_installs.py::TestBackendInstalls::test_backend[backend-0-0] PASSED
tests/test_partitions.py::TestStoragePartition::test_storage_partition[paramiko://backend-0-0] SKIPPED
tests/test_backend_link.py::TestLinkUp::test_link_status[paramiko://backend-0-0] PASSED
tests/test_other_dhcp.py::test_other_dhcp_server[eth1] PASSED
tests/test_networks.py::test_hosts_in_correct_networks PASSED
tests/test_df.py::test_slash_not_full[local] PASSED
tests/test_df.py::test_export_not_full[local] PASSED
tests/test_df.py::test_var_not_full[local] PASSED
tests/test_sles_patch.py::test_sles_pallet_patched[local] PASSED
tests/test_pkgs.py::test_rpms_are_clean[local] PASSED
tests/test_pkgs.py::test_no_duplicate_rpms[local] PASSED
======================================= warnings summary ========================================
tests/test_partitions.py::TestStoragePartition::test_storage_partition[paramiko://backend-0-0]
/opt/stack/lib/python3.8/site-packages/paramiko/client.py:835: UserWarning: Unknown ssh-ed25519 host key for backend-0-0: b'f6d43303ee51d55add2c3ac4b0f8fac3'
warnings.warn(
-- Docs: https://docs.pytest.org/en/stable/warnings.html
========================================= Cluster Data ==========================================
------------------------------------------- list box --------------------------------------------
NAME OS PALLETS CARTS REPOS
11sp3 sles SLES-11sp3-sles11 stacki-5.6.1-sles11 ------- -----
12sp3 sles stacki-5.6.1-sles12 SLES-12sp3-sles12 stacki-5.6rc5-sles12 ------- -----
15sp1 sles SLES-15sp1-sles15 Packages-1-15sp1-sles15 stacki-5.6.1-sles15 ------- -----
default sles stacki-5.6.1-sles12 SLES-12sp3-sles12 vagrant -----
frontend sles stacki-5.6.1-sles12 SLES-12sp3-sles12 ------- -----
------------------------------------------ list pallet ------------------------------------------
NAME VERSION RELEASE ARCH OS BOXES
stacki 5.6.1 sles12 x86_64 sles default frontend 12sp3
SLES 12sp3 sles12 x86_64 sles default frontend 12sp3
SLES 15sp1 sles15 x86_64 sles 15sp1
Packages-1 15sp1 sles15 x86_64 sles 15sp1
SLES 11sp3 sles11 x86_64 sles 11sp3
stacki 5.6.1 sles15 x86_64 sles 15sp1
stacki 5.6.1 sles11 x86_64 sles 11sp3
stacki 5.6rc5 sles12 x86_64 sles 12sp3
------------------------------------------- list cart -------------------------------------------
NAME BOXES
vagrant default
----------------------------------------- list network ------------------------------------------
NETWORK ADDRESS MASK GATEWAY MTU ZONE DNS PXE
private 192.168.0.0 255.255.255.0 192.168.121.1 --- ---- False True
------------------------------------------- list host -------------------------------------------
HOST RACK RANK APPLIANCE OS BOX ENVIRONMENT OSACTION INSTALLACTION COMMENT
frontend-0-0 0 0 frontend sles frontend ----------- default default -------
backend-0-0 0 0 backend sles default ----------- default default -------
-------------------------------------- list host interface --------------------------------------
HOST INTERFACE DEFAULT NETWORK MAC IP NAME MODULE VLAN OPTIONS CHANNEL
frontend-0-0 eth1 True private 52:54:00:e3:a0:a8 192.168.0.2 frontend-0-0 ------ ---- ------- -------
backend-0-0 eth0 ------- ------- 52:54:00:75:5c:ff ----------- ------------ ------ ---- ------- -------
backend-0-0 eth1 True private 52:54:00:00:00:03 192.168.0.1 backend-0-0 ------ ---- ------- -------
----------------------------------- SLES pallet patch source ------------------------------------
stacki-5.6rc5-sles12-sles-x86_64
----------------------------------- SLES pallet patch source ------------------------------------
stacki-5.6.1-sles15-sles-x86_64
==================================== short test summary info ====================================
SKIPPED [1] tests/test_services.py:38: named should only be running if a network is set to dns=true
SKIPPED [1] tests/test_partitions.py:37: Using default stacki partition config for host backend-0-0
=========================== 33 passed, 2 skipped, 1 warning in 12.02s ===========================

@megkido
megkido requested a review from bsandersAugust 24, 2020 22:54
megkido
megkido commented Aug 25, 2020
View reviewed changes
Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py Outdated
bsanders
bsanders suggested changes Aug 25, 2020
View reviewed changes
Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py Outdated
Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py Outdated
Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py Outdated
Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py Outdated
Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py Outdated
Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py Outdated
Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py Outdated
Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py Outdated
Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py Outdated
megkido
megkido commented Aug 27, 2020
View reviewed changes
Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py
@megkido
megkidoforce-pushed the feature/test_sles_patches branch from 8d88199 to 76c8041CompareSeptember 1, 2020 19:31
bsanders
bsanders reviewed Sep 1, 2020
View reviewed changes
Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py Outdated
@megkido
megkidoforce-pushed the feature/test_sles_patches branch 2 times, most recently from 9d66b6e to 6c8fea4CompareSeptember 2, 2020 03:57
@megkido
megkido requested a review from caladdSeptember 16, 2020 00:01
caladd
caladd suggested changes Sep 16, 2020
View reviewed changes

@caladdcaladd left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make the recommended code changes and re-examine the code logic. I'm not sure this is actually testing that all the files in all the RPMs have the correct hashes.

Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py Outdated
Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py Outdated
Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py Outdated
Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py Outdated
Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py Outdated
Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py Outdated
Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py
assert sles_flavors

# Find out where is stack-sles*images*.rpm file(s)
result = host.run('find /export/stack/pallets/stacki/ -name "*stack-sles-*.rpm"')

@caladdcaladdSep 16, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pattern should have a \ before the .:

"*stack-sles-*\.rpm"

@megkidomegkidoOct 6, 2020

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

having \ before . broke the code.

Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py Outdated
Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py Outdated
@megkido

megkido commented Oct 6, 2020•
edited
Loading

Copy link
Copy Markdown
Author

Updated output

Failure case

--------------------------------- SLES12sp3 pallet patch source NOT found ----------------------------------
/opt/stack/pallet-patches/SLES-12sp3-sles12-sles-x86_64/add-stacki-squashfs/content
-------------------------------------- SLES15sp1 pallet patch source ---------------------------------------
stacki-5.6.1-sles15-sles-x86_64
-------------------------------------- SLES11sp3 pallet patch source ---------------------------------------
stacki-5.6rc5-sles12-sles-x86_64

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@caladdcaladdcaladd requested changes
@bsandersbsandersbsanders requested changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@megkido@caladd@bsanders
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
FEATURE: ReportSys test for SLES pallet patch - #825
Open
megkido wants to merge 4 commits into
developfrom 
feature/test_sles_patches
Open
FEATURE: ReportSys test for SLES pallet patch#825
megkido wants to merge 4 commits into
developfrom 
feature/test_sles_patches
Conversation
@megkido
@megkidomegkido
commented
Aug 24, 2020•

edited

Loading

Copy link


Copy Markdown

Output
frontend-0-0:/opt/stack/lib/python3.8/site-packages/stack/commands/report/system/tests # stack report system
====================================== test session starts ======================================
platform linux -- Python 3.8.3, pytest-6.0.1, py-1.9.0, pluggy-0.13.1 -- /opt/stack/bin/python3
cachedir: .pytest_cache
rootdir: /opt/stack/lib/python3.8/site-packages/stack/commands/report/system
plugins: testinfra-1.16.0
collected 35 items
tests/test_stacki.py::test_stack_list[local-box] PASSED
tests/test_stacki.py::test_stack_list[local-pallet] PASSED
tests/test_stacki.py::test_stack_list[local-cart] PASSED
tests/test_stacki.py::test_stack_list[local-network] PASSED
tests/test_stacki.py::test_stack_list[local-host] PASSED
tests/test_stacki.py::test_stack_list[local-host interface] PASSED
tests/test_stacki.py::test_stacki_pallets_sane[local] PASSED
tests/test_stacki.py::test_stacki_central_server[local] PASSED
tests/test_stacki.py::test_stacki_ca_correct[local] PASSED
tests/test_services.py::test_service_enabled_and_running[local-dhcpd] PASSED
tests/test_services.py::test_service_enabled_and_running[local-named] SKIPPED
tests/test_services.py::test_service_enabled_and_running[local-rsyslog] PASSED
tests/test_services.py::test_service_enabled_and_running[local-smq-processor] PASSED
tests/test_services.py::test_service_enabled_and_running[local-smq-producer] PASSED
tests/test_services.py::test_service_enabled_and_running[local-smq-publisher] PASSED
tests/test_services.py::test_service_enabled_and_running[local-sshd] PASSED
tests/test_services.py::test_service_enabled_and_running[local-chronyd] PASSED
tests/test_services.py::test_service_enabled_and_running[local-apache2] PASSED
tests/test_services.py::test_service_enabled_and_running[local-mysql] PASSED
tests/test_services.py::test_tftpd_enabled_and_running[local] PASSED
tests/test_services.py::test_logrotate_service_enabled[local] PASSED
tests/test_services.py::test_logrotate_configuration_valid[local] PASSED
tests/test_services.py::test_stacki_logrotate_file_exists[local] PASSED
tests/test_restapi.py::test_restapi_list_host PASSED
tests/test_backend_installs.py::TestBackendInstalls::test_backend[backend-0-0] PASSED
tests/test_partitions.py::TestStoragePartition::test_storage_partition[paramiko://backend-0-0] SKIPPED
tests/test_backend_link.py::TestLinkUp::test_link_status[paramiko://backend-0-0] PASSED
tests/test_other_dhcp.py::test_other_dhcp_server[eth1] PASSED
tests/test_networks.py::test_hosts_in_correct_networks PASSED
tests/test_df.py::test_slash_not_full[local] PASSED
tests/test_df.py::test_export_not_full[local] PASSED
tests/test_df.py::test_var_not_full[local] PASSED
tests/test_sles_patch.py::test_sles_pallet_patched[local] PASSED
tests/test_pkgs.py::test_rpms_are_clean[local] PASSED
tests/test_pkgs.py::test_no_duplicate_rpms[local] PASSED
======================================= warnings summary ========================================
tests/test_partitions.py::TestStoragePartition::test_storage_partition[paramiko://backend-0-0]
/opt/stack/lib/python3.8/site-packages/paramiko/client.py:835: UserWarning: Unknown ssh-ed25519 host key for backend-0-0: b'f6d43303ee51d55add2c3ac4b0f8fac3'
warnings.warn(
-- Docs: https://docs.pytest.org/en/stable/warnings.html
========================================= Cluster Data ==========================================
------------------------------------------- list box --------------------------------------------
NAME OS PALLETS CARTS REPOS
11sp3 sles SLES-11sp3-sles11 stacki-5.6.1-sles11 ------- -----
12sp3 sles stacki-5.6.1-sles12 SLES-12sp3-sles12 stacki-5.6rc5-sles12 ------- -----
15sp1 sles SLES-15sp1-sles15 Packages-1-15sp1-sles15 stacki-5.6.1-sles15 ------- -----
default sles stacki-5.6.1-sles12 SLES-12sp3-sles12 vagrant -----
frontend sles stacki-5.6.1-sles12 SLES-12sp3-sles12 ------- -----
------------------------------------------ list pallet ------------------------------------------
NAME VERSION RELEASE ARCH OS BOXES
stacki 5.6.1 sles12 x86_64 sles default frontend 12sp3
SLES 12sp3 sles12 x86_64 sles default frontend 12sp3
SLES 15sp1 sles15 x86_64 sles 15sp1
Packages-1 15sp1 sles15 x86_64 sles 15sp1
SLES 11sp3 sles11 x86_64 sles 11sp3
stacki 5.6.1 sles15 x86_64 sles 15sp1
stacki 5.6.1 sles11 x86_64 sles 11sp3
stacki 5.6rc5 sles12 x86_64 sles 12sp3
------------------------------------------- list cart -------------------------------------------
NAME BOXES
vagrant default
----------------------------------------- list network ------------------------------------------
NETWORK ADDRESS MASK GATEWAY MTU ZONE DNS PXE
private 192.168.0.0 255.255.255.0 192.168.121.1 --- ---- False True
------------------------------------------- list host -------------------------------------------
HOST RACK RANK APPLIANCE OS BOX ENVIRONMENT OSACTION INSTALLACTION COMMENT
frontend-0-0 0 0 frontend sles frontend ----------- default default -------
backend-0-0 0 0 backend sles default ----------- default default -------
-------------------------------------- list host interface --------------------------------------
HOST INTERFACE DEFAULT NETWORK MAC IP NAME MODULE VLAN OPTIONS CHANNEL
frontend-0-0 eth1 True private 52:54:00:e3:a0:a8 192.168.0.2 frontend-0-0 ------ ---- ------- -------
backend-0-0 eth0 ------- ------- 52:54:00:75:5c:ff ----------- ------------ ------ ---- ------- -------
backend-0-0 eth1 True private 52:54:00:00:00:03 192.168.0.1 backend-0-0 ------ ---- ------- -------
----------------------------------- SLES pallet patch source ------------------------------------
stacki-5.6rc5-sles12-sles-x86_64
----------------------------------- SLES pallet patch source ------------------------------------
stacki-5.6.1-sles15-sles-x86_64
==================================== short test summary info ====================================
SKIPPED [1] tests/test_services.py:38: named should only be running if a network is set to dns=true
SKIPPED [1] tests/test_partitions.py:37: Using default stacki partition config for host backend-0-0
=========================== 33 passed, 2 skipped, 1 warning in 12.02s ===========================

@megkido
megkido
requested a review
from bsandersAugust 24, 2020 22:54
megkido
megkido
commented
Aug 25, 2020
View reviewed changes
Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Outdated

bsanders
bsanders
suggested changes
Aug 25, 2020
View reviewed changes
Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Outdated

Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Outdated

Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Outdated

Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Outdated

Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Outdated

Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Outdated

Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Outdated

Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Outdated

Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Outdated

megkido
megkido
commented
Aug 27, 2020
View reviewed changes
Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py
@megkido
megkidoforce-pushed
the
feature/test_sles_patches
branch
from
8d88199 to
76c8041CompareSeptember 1, 2020 19:31
bsanders
bsanders
reviewed
Sep 1, 2020
View reviewed changes
Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Outdated

@megkido
megkidoforce-pushed
the
feature/test_sles_patches
branch
2 times, most recently
from
9d66b6e to
6c8fea4CompareSeptember 2, 2020 03:57
@megkido
megkido
requested a review
from caladdSeptember 16, 2020 00:01
caladd
caladd
suggested changes
Sep 16, 2020
View reviewed changes
@caladdcaladd
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make the recommended code changes and re-examine the code logic. I'm not sure this is actually testing that all the files in all the RPMs have the correct hashes.
Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Outdated

Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Outdated

Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Outdated

Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Outdated

Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Outdated

Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Outdated

Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py
	assert sles_flavors

	# Find out where is stack-sles*images*.rpm file(s)
	result = host.run('find /export/stack/pallets/stacki/ -name "*stack-sles-*.rpm"')
@caladdcaladdSep 16, 2020

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pattern should have a \ before the .:
"*stack-sles-*\.rpm"

@megkidomegkidoOct 6, 2020

Copy link


Copy Markdown

Author
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

having \ before . broke the code.
Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Outdated

Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Outdated

@megkido
megkido
commented
Oct 6, 2020•

edited

Loading

Copy link


Copy Markdown

Author
Updated output
Failure case
--------------------------------- SLES12sp3 pallet patch source NOT found ----------------------------------
/opt/stack/pallet-patches/SLES-12sp3-sles12-sles-x86_64/add-stacki-squashfs/content
-------------------------------------- SLES15sp1 pallet patch source ---------------------------------------
stacki-5.6.1-sles15-sles-x86_64
-------------------------------------- SLES11sp3 pallet patch source ---------------------------------------
stacki-5.6rc5-sles12-sles-x86_64

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


2 more reviewers

@caladdcaladdcaladd requested changes
@bsandersbsandersbsanders requested changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@megkido@caladd@bsanders

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
FEATURE: ReportSys test for SLES pallet patch - #825
Open
megkido wants to merge 4 commits into
developfrom 
feature/test_sles_patches
Open
FEATURE: ReportSys test for SLES pallet patch#825
megkido wants to merge 4 commits into
developfrom 
feature/test_sles_patches
Conversation
@megkido
@megkidomegkido
commented
Aug 24, 2020•

edited

Loading

Copy link


Copy Markdown

Output
frontend-0-0:/opt/stack/lib/python3.8/site-packages/stack/commands/report/system/tests # stack report system
====================================== test session starts ======================================
platform linux -- Python 3.8.3, pytest-6.0.1, py-1.9.0, pluggy-0.13.1 -- /opt/stack/bin/python3
cachedir: .pytest_cache
rootdir: /opt/stack/lib/python3.8/site-packages/stack/commands/report/system
plugins: testinfra-1.16.0
collected 35 items
tests/test_stacki.py::test_stack_list[local-box] PASSED
tests/test_stacki.py::test_stack_list[local-pallet] PASSED
tests/test_stacki.py::test_stack_list[local-cart] PASSED
tests/test_stacki.py::test_stack_list[local-network] PASSED
tests/test_stacki.py::test_stack_list[local-host] PASSED
tests/test_stacki.py::test_stack_list[local-host interface] PASSED
tests/test_stacki.py::test_stacki_pallets_sane[local] PASSED
tests/test_stacki.py::test_stacki_central_server[local] PASSED
tests/test_stacki.py::test_stacki_ca_correct[local] PASSED
tests/test_services.py::test_service_enabled_and_running[local-dhcpd] PASSED
tests/test_services.py::test_service_enabled_and_running[local-named] SKIPPED
tests/test_services.py::test_service_enabled_and_running[local-rsyslog] PASSED
tests/test_services.py::test_service_enabled_and_running[local-smq-processor] PASSED
tests/test_services.py::test_service_enabled_and_running[local-smq-producer] PASSED
tests/test_services.py::test_service_enabled_and_running[local-smq-publisher] PASSED
tests/test_services.py::test_service_enabled_and_running[local-sshd] PASSED
tests/test_services.py::test_service_enabled_and_running[local-chronyd] PASSED
tests/test_services.py::test_service_enabled_and_running[local-apache2] PASSED
tests/test_services.py::test_service_enabled_and_running[local-mysql] PASSED
tests/test_services.py::test_tftpd_enabled_and_running[local] PASSED
tests/test_services.py::test_logrotate_service_enabled[local] PASSED
tests/test_services.py::test_logrotate_configuration_valid[local] PASSED
tests/test_services.py::test_stacki_logrotate_file_exists[local] PASSED
tests/test_restapi.py::test_restapi_list_host PASSED
tests/test_backend_installs.py::TestBackendInstalls::test_backend[backend-0-0] PASSED
tests/test_partitions.py::TestStoragePartition::test_storage_partition[paramiko://backend-0-0] SKIPPED
tests/test_backend_link.py::TestLinkUp::test_link_status[paramiko://backend-0-0] PASSED
tests/test_other_dhcp.py::test_other_dhcp_server[eth1] PASSED
tests/test_networks.py::test_hosts_in_correct_networks PASSED
tests/test_df.py::test_slash_not_full[local] PASSED
tests/test_df.py::test_export_not_full[local] PASSED
tests/test_df.py::test_var_not_full[local] PASSED
tests/test_sles_patch.py::test_sles_pallet_patched[local] PASSED
tests/test_pkgs.py::test_rpms_are_clean[local] PASSED
tests/test_pkgs.py::test_no_duplicate_rpms[local] PASSED
======================================= warnings summary ========================================
tests/test_partitions.py::TestStoragePartition::test_storage_partition[paramiko://backend-0-0]
/opt/stack/lib/python3.8/site-packages/paramiko/client.py:835: UserWarning: Unknown ssh-ed25519 host key for backend-0-0: b'f6d43303ee51d55add2c3ac4b0f8fac3'
warnings.warn(
-- Docs: https://docs.pytest.org/en/stable/warnings.html
========================================= Cluster Data ==========================================
------------------------------------------- list box --------------------------------------------
NAME OS PALLETS CARTS REPOS
11sp3 sles SLES-11sp3-sles11 stacki-5.6.1-sles11 ------- -----
12sp3 sles stacki-5.6.1-sles12 SLES-12sp3-sles12 stacki-5.6rc5-sles12 ------- -----
15sp1 sles SLES-15sp1-sles15 Packages-1-15sp1-sles15 stacki-5.6.1-sles15 ------- -----
default sles stacki-5.6.1-sles12 SLES-12sp3-sles12 vagrant -----
frontend sles stacki-5.6.1-sles12 SLES-12sp3-sles12 ------- -----
------------------------------------------ list pallet ------------------------------------------
NAME VERSION RELEASE ARCH OS BOXES
stacki 5.6.1 sles12 x86_64 sles default frontend 12sp3
SLES 12sp3 sles12 x86_64 sles default frontend 12sp3
SLES 15sp1 sles15 x86_64 sles 15sp1
Packages-1 15sp1 sles15 x86_64 sles 15sp1
SLES 11sp3 sles11 x86_64 sles 11sp3
stacki 5.6.1 sles15 x86_64 sles 15sp1
stacki 5.6.1 sles11 x86_64 sles 11sp3
stacki 5.6rc5 sles12 x86_64 sles 12sp3
------------------------------------------- list cart -------------------------------------------
NAME BOXES
vagrant default
----------------------------------------- list network ------------------------------------------
NETWORK ADDRESS MASK GATEWAY MTU ZONE DNS PXE
private 192.168.0.0 255.255.255.0 192.168.121.1 --- ---- False True
------------------------------------------- list host -------------------------------------------
HOST RACK RANK APPLIANCE OS BOX ENVIRONMENT OSACTION INSTALLACTION COMMENT
frontend-0-0 0 0 frontend sles frontend ----------- default default -------
backend-0-0 0 0 backend sles default ----------- default default -------
-------------------------------------- list host interface --------------------------------------
HOST INTERFACE DEFAULT NETWORK MAC IP NAME MODULE VLAN OPTIONS CHANNEL
frontend-0-0 eth1 True private 52:54:00:e3:a0:a8 192.168.0.2 frontend-0-0 ------ ---- ------- -------
backend-0-0 eth0 ------- ------- 52:54:00:75:5c:ff ----------- ------------ ------ ---- ------- -------
backend-0-0 eth1 True private 52:54:00:00:00:03 192.168.0.1 backend-0-0 ------ ---- ------- -------
----------------------------------- SLES pallet patch source ------------------------------------
stacki-5.6rc5-sles12-sles-x86_64
----------------------------------- SLES pallet patch source ------------------------------------
stacki-5.6.1-sles15-sles-x86_64
==================================== short test summary info ====================================
SKIPPED [1] tests/test_services.py:38: named should only be running if a network is set to dns=true
SKIPPED [1] tests/test_partitions.py:37: Using default stacki partition config for host backend-0-0
=========================== 33 passed, 2 skipped, 1 warning in 12.02s ===========================

@megkido
megkido
requested a review
from bsandersAugust 24, 2020 22:54
megkido
megkido
commented
Aug 25, 2020
View reviewed changes
Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Outdated

bsanders
bsanders
suggested changes
Aug 25, 2020
View reviewed changes
Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Outdated

Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Outdated

Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Outdated

Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Outdated

Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Outdated

Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Outdated

Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Outdated

Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Outdated

Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Outdated

megkido
megkido
commented
Aug 27, 2020
View reviewed changes
Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py
@megkido
megkidoforce-pushed
the
feature/test_sles_patches
branch
from
8d88199 to
76c8041CompareSeptember 1, 2020 19:31
bsanders
bsanders
reviewed
Sep 1, 2020
View reviewed changes
Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Outdated

@megkido
megkidoforce-pushed
the
feature/test_sles_patches
branch
2 times, most recently
from
9d66b6e to
6c8fea4CompareSeptember 2, 2020 03:57
@megkido
megkido
requested a review
from caladdSeptember 16, 2020 00:01
caladd
caladd
suggested changes
Sep 16, 2020
View reviewed changes
@caladdcaladd
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make the recommended code changes and re-examine the code logic. I'm not sure this is actually testing that all the files in all the RPMs have the correct hashes.
Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Outdated

Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Outdated

Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Outdated

Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Outdated

Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Outdated

Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Outdated

Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py
	assert sles_flavors

	# Find out where is stack-sles*images*.rpm file(s)
	result = host.run('find /export/stack/pallets/stacki/ -name "*stack-sles-*.rpm"')
@caladdcaladdSep 16, 2020

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pattern should have a \ before the .:
"*stack-sles-*\.rpm"

@megkidomegkidoOct 6, 2020

Copy link


Copy Markdown

Author
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

having \ before . broke the code.
Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Outdated

Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Outdated

@megkido
megkido
commented
Oct 6, 2020•

edited

Loading

Copy link


Copy Markdown

Author
Updated output
Failure case
--------------------------------- SLES12sp3 pallet patch source NOT found ----------------------------------
/opt/stack/pallet-patches/SLES-12sp3-sles12-sles-x86_64/add-stacki-squashfs/content
-------------------------------------- SLES15sp1 pallet patch source ---------------------------------------
stacki-5.6.1-sles15-sles-x86_64
-------------------------------------- SLES11sp3 pallet patch source ---------------------------------------
stacki-5.6rc5-sles12-sles-x86_64

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


2 more reviewers

@caladdcaladdcaladd requested changes
@bsandersbsandersbsanders requested changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@megkido@caladd@bsanders

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
FEATURE: ReportSys test for SLES pallet patch - #825
Open
megkido wants to merge 4 commits into
developfrom 
feature/test_sles_patches
Open
FEATURE: ReportSys test for SLES pallet patch#825
megkido wants to merge 4 commits into
developfrom 
feature/test_sles_patches
Conversation
@megkido
@megkidomegkido
commented
Aug 24, 2020•

edited

Loading

Copy link


Copy Markdown

Output
frontend-0-0:/opt/stack/lib/python3.8/site-packages/stack/commands/report/system/tests # stack report system
====================================== test session starts ======================================
platform linux -- Python 3.8.3, pytest-6.0.1, py-1.9.0, pluggy-0.13.1 -- /opt/stack/bin/python3
cachedir: .pytest_cache
rootdir: /opt/stack/lib/python3.8/site-packages/stack/commands/report/system
plugins: testinfra-1.16.0
collected 35 items
tests/test_stacki.py::test_stack_list[local-box] PASSED
tests/test_stacki.py::test_stack_list[local-pallet] PASSED
tests/test_stacki.py::test_stack_list[local-cart] PASSED
tests/test_stacki.py::test_stack_list[local-network] PASSED
tests/test_stacki.py::test_stack_list[local-host] PASSED
tests/test_stacki.py::test_stack_list[local-host interface] PASSED
tests/test_stacki.py::test_stacki_pallets_sane[local] PASSED
tests/test_stacki.py::test_stacki_central_server[local] PASSED
tests/test_stacki.py::test_stacki_ca_correct[local] PASSED
tests/test_services.py::test_service_enabled_and_running[local-dhcpd] PASSED
tests/test_services.py::test_service_enabled_and_running[local-named] SKIPPED
tests/test_services.py::test_service_enabled_and_running[local-rsyslog] PASSED
tests/test_services.py::test_service_enabled_and_running[local-smq-processor] PASSED
tests/test_services.py::test_service_enabled_and_running[local-smq-producer] PASSED
tests/test_services.py::test_service_enabled_and_running[local-smq-publisher] PASSED
tests/test_services.py::test_service_enabled_and_running[local-sshd] PASSED
tests/test_services.py::test_service_enabled_and_running[local-chronyd] PASSED
tests/test_services.py::test_service_enabled_and_running[local-apache2] PASSED
tests/test_services.py::test_service_enabled_and_running[local-mysql] PASSED
tests/test_services.py::test_tftpd_enabled_and_running[local] PASSED
tests/test_services.py::test_logrotate_service_enabled[local] PASSED
tests/test_services.py::test_logrotate_configuration_valid[local] PASSED
tests/test_services.py::test_stacki_logrotate_file_exists[local] PASSED
tests/test_restapi.py::test_restapi_list_host PASSED
tests/test_backend_installs.py::TestBackendInstalls::test_backend[backend-0-0] PASSED
tests/test_partitions.py::TestStoragePartition::test_storage_partition[paramiko://backend-0-0] SKIPPED
tests/test_backend_link.py::TestLinkUp::test_link_status[paramiko://backend-0-0] PASSED
tests/test_other_dhcp.py::test_other_dhcp_server[eth1] PASSED
tests/test_networks.py::test_hosts_in_correct_networks PASSED
tests/test_df.py::test_slash_not_full[local] PASSED
tests/test_df.py::test_export_not_full[local] PASSED
tests/test_df.py::test_var_not_full[local] PASSED
tests/test_sles_patch.py::test_sles_pallet_patched[local] PASSED
tests/test_pkgs.py::test_rpms_are_clean[local] PASSED
tests/test_pkgs.py::test_no_duplicate_rpms[local] PASSED
======================================= warnings summary ========================================
tests/test_partitions.py::TestStoragePartition::test_storage_partition[paramiko://backend-0-0]
/opt/stack/lib/python3.8/site-packages/paramiko/client.py:835: UserWarning: Unknown ssh-ed25519 host key for backend-0-0: b'f6d43303ee51d55add2c3ac4b0f8fac3'
warnings.warn(
-- Docs: https://docs.pytest.org/en/stable/warnings.html
========================================= Cluster Data ==========================================
------------------------------------------- list box --------------------------------------------
NAME OS PALLETS CARTS REPOS
11sp3 sles SLES-11sp3-sles11 stacki-5.6.1-sles11 ------- -----
12sp3 sles stacki-5.6.1-sles12 SLES-12sp3-sles12 stacki-5.6rc5-sles12 ------- -----
15sp1 sles SLES-15sp1-sles15 Packages-1-15sp1-sles15 stacki-5.6.1-sles15 ------- -----
default sles stacki-5.6.1-sles12 SLES-12sp3-sles12 vagrant -----
frontend sles stacki-5.6.1-sles12 SLES-12sp3-sles12 ------- -----
------------------------------------------ list pallet ------------------------------------------
NAME VERSION RELEASE ARCH OS BOXES
stacki 5.6.1 sles12 x86_64 sles default frontend 12sp3
SLES 12sp3 sles12 x86_64 sles default frontend 12sp3
SLES 15sp1 sles15 x86_64 sles 15sp1
Packages-1 15sp1 sles15 x86_64 sles 15sp1
SLES 11sp3 sles11 x86_64 sles 11sp3
stacki 5.6.1 sles15 x86_64 sles 15sp1
stacki 5.6.1 sles11 x86_64 sles 11sp3
stacki 5.6rc5 sles12 x86_64 sles 12sp3
------------------------------------------- list cart -------------------------------------------
NAME BOXES
vagrant default
----------------------------------------- list network ------------------------------------------
NETWORK ADDRESS MASK GATEWAY MTU ZONE DNS PXE
private 192.168.0.0 255.255.255.0 192.168.121.1 --- ---- False True
------------------------------------------- list host -------------------------------------------
HOST RACK RANK APPLIANCE OS BOX ENVIRONMENT OSACTION INSTALLACTION COMMENT
frontend-0-0 0 0 frontend sles frontend ----------- default default -------
backend-0-0 0 0 backend sles default ----------- default default -------
-------------------------------------- list host interface --------------------------------------
HOST INTERFACE DEFAULT NETWORK MAC IP NAME MODULE VLAN OPTIONS CHANNEL
frontend-0-0 eth1 True private 52:54:00:e3:a0:a8 192.168.0.2 frontend-0-0 ------ ---- ------- -------
backend-0-0 eth0 ------- ------- 52:54:00:75:5c:ff ----------- ------------ ------ ---- ------- -------
backend-0-0 eth1 True private 52:54:00:00:00:03 192.168.0.1 backend-0-0 ------ ---- ------- -------
----------------------------------- SLES pallet patch source ------------------------------------
stacki-5.6rc5-sles12-sles-x86_64
----------------------------------- SLES pallet patch source ------------------------------------
stacki-5.6.1-sles15-sles-x86_64
==================================== short test summary info ====================================
SKIPPED [1] tests/test_services.py:38: named should only be running if a network is set to dns=true
SKIPPED [1] tests/test_partitions.py:37: Using default stacki partition config for host backend-0-0
=========================== 33 passed, 2 skipped, 1 warning in 12.02s ===========================

@megkido
megkido
requested a review
from bsandersAugust 24, 2020 22:54
megkido
megkido
commented
Aug 25, 2020
View reviewed changes
Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Outdated

bsanders
bsanders
suggested changes
Aug 25, 2020
View reviewed changes
Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Outdated

Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Outdated

Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Outdated

Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Outdated

Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Outdated

Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Outdated

Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Outdated

Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Outdated

Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Outdated

megkido
megkido
commented
Aug 27, 2020
View reviewed changes
Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py
@megkido
megkidoforce-pushed
the
feature/test_sles_patches
branch
from
8d88199 to
76c8041CompareSeptember 1, 2020 19:31
bsanders
bsanders
reviewed
Sep 1, 2020
View reviewed changes
Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Outdated

@megkido
megkidoforce-pushed
the
feature/test_sles_patches
branch
2 times, most recently
from
9d66b6e to
6c8fea4CompareSeptember 2, 2020 03:57
@megkido
megkido
requested a review
from caladdSeptember 16, 2020 00:01
caladd
caladd
suggested changes
Sep 16, 2020
View reviewed changes
@caladdcaladd
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make the recommended code changes and re-examine the code logic. I'm not sure this is actually testing that all the files in all the RPMs have the correct hashes.
Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Outdated

Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Outdated

Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Outdated

Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Outdated

Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Outdated

Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Outdated

Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py
	assert sles_flavors

	# Find out where is stack-sles*images*.rpm file(s)
	result = host.run('find /export/stack/pallets/stacki/ -name "*stack-sles-*.rpm"')
@caladdcaladdSep 16, 2020

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pattern should have a \ before the .:
"*stack-sles-*\.rpm"

@megkidomegkidoOct 6, 2020

Copy link


Copy Markdown

Author
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

having \ before . broke the code.
Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Outdated

Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Outdated

@megkido
megkido
commented
Oct 6, 2020•

edited

Loading

Copy link


Copy Markdown

Author
Updated output
Failure case
--------------------------------- SLES12sp3 pallet patch source NOT found ----------------------------------
/opt/stack/pallet-patches/SLES-12sp3-sles12-sles-x86_64/add-stacki-squashfs/content
-------------------------------------- SLES15sp1 pallet patch source ---------------------------------------
stacki-5.6.1-sles15-sles-x86_64
-------------------------------------- SLES11sp3 pallet patch source ---------------------------------------
stacki-5.6rc5-sles12-sles-x86_64

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


2 more reviewers

@caladdcaladdcaladd requested changes
@bsandersbsandersbsanders requested changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@megkido@caladd@bsanders

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
FEATURE: ReportSys test for SLES pallet patch - #825
Open
megkido wants to merge 4 commits into
developfrom 
feature/test_sles_patches
Open
FEATURE: ReportSys test for SLES pallet patch#825
megkido wants to merge 4 commits into
developfrom 
feature/test_sles_patches
Conversation
@megkido
@megkidomegkido
commented
Aug 24, 2020•

edited

Loading

Copy link


Copy Markdown

Output
frontend-0-0:/opt/stack/lib/python3.8/site-packages/stack/commands/report/system/tests # stack report system
====================================== test session starts ======================================
platform linux -- Python 3.8.3, pytest-6.0.1, py-1.9.0, pluggy-0.13.1 -- /opt/stack/bin/python3
cachedir: .pytest_cache
rootdir: /opt/stack/lib/python3.8/site-packages/stack/commands/report/system
plugins: testinfra-1.16.0
collected 35 items
tests/test_stacki.py::test_stack_list[local-box] PASSED
tests/test_stacki.py::test_stack_list[local-pallet] PASSED
tests/test_stacki.py::test_stack_list[local-cart] PASSED
tests/test_stacki.py::test_stack_list[local-network] PASSED
tests/test_stacki.py::test_stack_list[local-host] PASSED
tests/test_stacki.py::test_stack_list[local-host interface] PASSED
tests/test_stacki.py::test_stacki_pallets_sane[local] PASSED
tests/test_stacki.py::test_stacki_central_server[local] PASSED
tests/test_stacki.py::test_stacki_ca_correct[local] PASSED
tests/test_services.py::test_service_enabled_and_running[local-dhcpd] PASSED
tests/test_services.py::test_service_enabled_and_running[local-named] SKIPPED
tests/test_services.py::test_service_enabled_and_running[local-rsyslog] PASSED
tests/test_services.py::test_service_enabled_and_running[local-smq-processor] PASSED
tests/test_services.py::test_service_enabled_and_running[local-smq-producer] PASSED
tests/test_services.py::test_service_enabled_and_running[local-smq-publisher] PASSED
tests/test_services.py::test_service_enabled_and_running[local-sshd] PASSED
tests/test_services.py::test_service_enabled_and_running[local-chronyd] PASSED
tests/test_services.py::test_service_enabled_and_running[local-apache2] PASSED
tests/test_services.py::test_service_enabled_and_running[local-mysql] PASSED
tests/test_services.py::test_tftpd_enabled_and_running[local] PASSED
tests/test_services.py::test_logrotate_service_enabled[local] PASSED
tests/test_services.py::test_logrotate_configuration_valid[local] PASSED
tests/test_services.py::test_stacki_logrotate_file_exists[local] PASSED
tests/test_restapi.py::test_restapi_list_host PASSED
tests/test_backend_installs.py::TestBackendInstalls::test_backend[backend-0-0] PASSED
tests/test_partitions.py::TestStoragePartition::test_storage_partition[paramiko://backend-0-0] SKIPPED
tests/test_backend_link.py::TestLinkUp::test_link_status[paramiko://backend-0-0] PASSED
tests/test_other_dhcp.py::test_other_dhcp_server[eth1] PASSED
tests/test_networks.py::test_hosts_in_correct_networks PASSED
tests/test_df.py::test_slash_not_full[local] PASSED
tests/test_df.py::test_export_not_full[local] PASSED
tests/test_df.py::test_var_not_full[local] PASSED
tests/test_sles_patch.py::test_sles_pallet_patched[local] PASSED
tests/test_pkgs.py::test_rpms_are_clean[local] PASSED
tests/test_pkgs.py::test_no_duplicate_rpms[local] PASSED
======================================= warnings summary ========================================
tests/test_partitions.py::TestStoragePartition::test_storage_partition[paramiko://backend-0-0]
/opt/stack/lib/python3.8/site-packages/paramiko/client.py:835: UserWarning: Unknown ssh-ed25519 host key for backend-0-0: b'f6d43303ee51d55add2c3ac4b0f8fac3'
warnings.warn(
-- Docs: https://docs.pytest.org/en/stable/warnings.html
========================================= Cluster Data ==========================================
------------------------------------------- list box --------------------------------------------
NAME OS PALLETS CARTS REPOS
11sp3 sles SLES-11sp3-sles11 stacki-5.6.1-sles11 ------- -----
12sp3 sles stacki-5.6.1-sles12 SLES-12sp3-sles12 stacki-5.6rc5-sles12 ------- -----
15sp1 sles SLES-15sp1-sles15 Packages-1-15sp1-sles15 stacki-5.6.1-sles15 ------- -----
default sles stacki-5.6.1-sles12 SLES-12sp3-sles12 vagrant -----
frontend sles stacki-5.6.1-sles12 SLES-12sp3-sles12 ------- -----
------------------------------------------ list pallet ------------------------------------------
NAME VERSION RELEASE ARCH OS BOXES
stacki 5.6.1 sles12 x86_64 sles default frontend 12sp3
SLES 12sp3 sles12 x86_64 sles default frontend 12sp3
SLES 15sp1 sles15 x86_64 sles 15sp1
Packages-1 15sp1 sles15 x86_64 sles 15sp1
SLES 11sp3 sles11 x86_64 sles 11sp3
stacki 5.6.1 sles15 x86_64 sles 15sp1
stacki 5.6.1 sles11 x86_64 sles 11sp3
stacki 5.6rc5 sles12 x86_64 sles 12sp3
------------------------------------------- list cart -------------------------------------------
NAME BOXES
vagrant default
----------------------------------------- list network ------------------------------------------
NETWORK ADDRESS MASK GATEWAY MTU ZONE DNS PXE
private 192.168.0.0 255.255.255.0 192.168.121.1 --- ---- False True
------------------------------------------- list host -------------------------------------------
HOST RACK RANK APPLIANCE OS BOX ENVIRONMENT OSACTION INSTALLACTION COMMENT
frontend-0-0 0 0 frontend sles frontend ----------- default default -------
backend-0-0 0 0 backend sles default ----------- default default -------
-------------------------------------- list host interface --------------------------------------
HOST INTERFACE DEFAULT NETWORK MAC IP NAME MODULE VLAN OPTIONS CHANNEL
frontend-0-0 eth1 True private 52:54:00:e3:a0:a8 192.168.0.2 frontend-0-0 ------ ---- ------- -------
backend-0-0 eth0 ------- ------- 52:54:00:75:5c:ff ----------- ------------ ------ ---- ------- -------
backend-0-0 eth1 True private 52:54:00:00:00:03 192.168.0.1 backend-0-0 ------ ---- ------- -------
----------------------------------- SLES pallet patch source ------------------------------------
stacki-5.6rc5-sles12-sles-x86_64
----------------------------------- SLES pallet patch source ------------------------------------
stacki-5.6.1-sles15-sles-x86_64
==================================== short test summary info ====================================
SKIPPED [1] tests/test_services.py:38: named should only be running if a network is set to dns=true
SKIPPED [1] tests/test_partitions.py:37: Using default stacki partition config for host backend-0-0
=========================== 33 passed, 2 skipped, 1 warning in 12.02s ===========================

@megkido
megkido
requested a review
from bsandersAugust 24, 2020 22:54
megkido
megkido
commented
Aug 25, 2020
View reviewed changes
Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Outdated

bsanders
bsanders
suggested changes
Aug 25, 2020
View reviewed changes
Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Outdated

Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Outdated

Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Outdated

Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Outdated

Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Outdated

Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Outdated

Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Outdated

Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Outdated

Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Outdated

megkido
megkido
commented
Aug 27, 2020
View reviewed changes
Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py
@megkido
megkidoforce-pushed
the
feature/test_sles_patches
branch
from
8d88199 to
76c8041CompareSeptember 1, 2020 19:31
bsanders
bsanders
reviewed
Sep 1, 2020
View reviewed changes
Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Outdated

@megkido
megkidoforce-pushed
the
feature/test_sles_patches
branch
2 times, most recently
from
9d66b6e to
6c8fea4CompareSeptember 2, 2020 03:57
@megkido
megkido
requested a review
from caladdSeptember 16, 2020 00:01
caladd
caladd
suggested changes
Sep 16, 2020
View reviewed changes
@caladdcaladd
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make the recommended code changes and re-examine the code logic. I'm not sure this is actually testing that all the files in all the RPMs have the correct hashes.
Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Outdated

Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Outdated

Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Outdated

Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Outdated

Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Outdated

Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Outdated

Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py
	assert sles_flavors

	# Find out where is stack-sles*images*.rpm file(s)
	result = host.run('find /export/stack/pallets/stacki/ -name "*stack-sles-*.rpm"')
@caladdcaladdSep 16, 2020

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pattern should have a \ before the .:
"*stack-sles-*\.rpm"

@megkidomegkidoOct 6, 2020

Copy link


Copy Markdown

Author
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

having \ before . broke the code.
Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Outdated

Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Outdated

@megkido
megkido
commented
Oct 6, 2020•

edited

Loading

Copy link


Copy Markdown

Author
Updated output
Failure case
--------------------------------- SLES12sp3 pallet patch source NOT found ----------------------------------
/opt/stack/pallet-patches/SLES-12sp3-sles12-sles-x86_64/add-stacki-squashfs/content
-------------------------------------- SLES15sp1 pallet patch source ---------------------------------------
stacki-5.6.1-sles15-sles-x86_64
-------------------------------------- SLES11sp3 pallet patch source ---------------------------------------
stacki-5.6rc5-sles12-sles-x86_64

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


2 more reviewers

@caladdcaladdcaladd requested changes
@bsandersbsandersbsanders requested changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@megkido@caladd@bsanders

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
FEATURE: ReportSys test for SLES pallet patch - #825
Open
megkido wants to merge 4 commits into
developfrom 
feature/test_sles_patches
Open
FEATURE: ReportSys test for SLES pallet patch#825
megkido wants to merge 4 commits into
developfrom 
feature/test_sles_patches
Conversation
@megkido
@megkidomegkido
commented
Aug 24, 2020•

edited

Loading

Copy link


Copy Markdown

Output
frontend-0-0:/opt/stack/lib/python3.8/site-packages/stack/commands/report/system/tests # stack report system
====================================== test session starts ======================================
platform linux -- Python 3.8.3, pytest-6.0.1, py-1.9.0, pluggy-0.13.1 -- /opt/stack/bin/python3
cachedir: .pytest_cache
rootdir: /opt/stack/lib/python3.8/site-packages/stack/commands/report/system
plugins: testinfra-1.16.0
collected 35 items
tests/test_stacki.py::test_stack_list[local-box] PASSED
tests/test_stacki.py::test_stack_list[local-pallet] PASSED
tests/test_stacki.py::test_stack_list[local-cart] PASSED
tests/test_stacki.py::test_stack_list[local-network] PASSED
tests/test_stacki.py::test_stack_list[local-host] PASSED
tests/test_stacki.py::test_stack_list[local-host interface] PASSED
tests/test_stacki.py::test_stacki_pallets_sane[local] PASSED
tests/test_stacki.py::test_stacki_central_server[local] PASSED
tests/test_stacki.py::test_stacki_ca_correct[local] PASSED
tests/test_services.py::test_service_enabled_and_running[local-dhcpd] PASSED
tests/test_services.py::test_service_enabled_and_running[local-named] SKIPPED
tests/test_services.py::test_service_enabled_and_running[local-rsyslog] PASSED
tests/test_services.py::test_service_enabled_and_running[local-smq-processor] PASSED
tests/test_services.py::test_service_enabled_and_running[local-smq-producer] PASSED
tests/test_services.py::test_service_enabled_and_running[local-smq-publisher] PASSED
tests/test_services.py::test_service_enabled_and_running[local-sshd] PASSED
tests/test_services.py::test_service_enabled_and_running[local-chronyd] PASSED
tests/test_services.py::test_service_enabled_and_running[local-apache2] PASSED
tests/test_services.py::test_service_enabled_and_running[local-mysql] PASSED
tests/test_services.py::test_tftpd_enabled_and_running[local] PASSED
tests/test_services.py::test_logrotate_service_enabled[local] PASSED
tests/test_services.py::test_logrotate_configuration_valid[local] PASSED
tests/test_services.py::test_stacki_logrotate_file_exists[local] PASSED
tests/test_restapi.py::test_restapi_list_host PASSED
tests/test_backend_installs.py::TestBackendInstalls::test_backend[backend-0-0] PASSED
tests/test_partitions.py::TestStoragePartition::test_storage_partition[paramiko://backend-0-0] SKIPPED
tests/test_backend_link.py::TestLinkUp::test_link_status[paramiko://backend-0-0] PASSED
tests/test_other_dhcp.py::test_other_dhcp_server[eth1] PASSED
tests/test_networks.py::test_hosts_in_correct_networks PASSED
tests/test_df.py::test_slash_not_full[local] PASSED
tests/test_df.py::test_export_not_full[local] PASSED
tests/test_df.py::test_var_not_full[local] PASSED
tests/test_sles_patch.py::test_sles_pallet_patched[local] PASSED
tests/test_pkgs.py::test_rpms_are_clean[local] PASSED
tests/test_pkgs.py::test_no_duplicate_rpms[local] PASSED
======================================= warnings summary ========================================
tests/test_partitions.py::TestStoragePartition::test_storage_partition[paramiko://backend-0-0]
/opt/stack/lib/python3.8/site-packages/paramiko/client.py:835: UserWarning: Unknown ssh-ed25519 host key for backend-0-0: b'f6d43303ee51d55add2c3ac4b0f8fac3'
warnings.warn(
-- Docs: https://docs.pytest.org/en/stable/warnings.html
========================================= Cluster Data ==========================================
------------------------------------------- list box --------------------------------------------
NAME OS PALLETS CARTS REPOS
11sp3 sles SLES-11sp3-sles11 stacki-5.6.1-sles11 ------- -----
12sp3 sles stacki-5.6.1-sles12 SLES-12sp3-sles12 stacki-5.6rc5-sles12 ------- -----
15sp1 sles SLES-15sp1-sles15 Packages-1-15sp1-sles15 stacki-5.6.1-sles15 ------- -----
default sles stacki-5.6.1-sles12 SLES-12sp3-sles12 vagrant -----
frontend sles stacki-5.6.1-sles12 SLES-12sp3-sles12 ------- -----
------------------------------------------ list pallet ------------------------------------------
NAME VERSION RELEASE ARCH OS BOXES
stacki 5.6.1 sles12 x86_64 sles default frontend 12sp3
SLES 12sp3 sles12 x86_64 sles default frontend 12sp3
SLES 15sp1 sles15 x86_64 sles 15sp1
Packages-1 15sp1 sles15 x86_64 sles 15sp1
SLES 11sp3 sles11 x86_64 sles 11sp3
stacki 5.6.1 sles15 x86_64 sles 15sp1
stacki 5.6.1 sles11 x86_64 sles 11sp3
stacki 5.6rc5 sles12 x86_64 sles 12sp3
------------------------------------------- list cart -------------------------------------------
NAME BOXES
vagrant default
----------------------------------------- list network ------------------------------------------
NETWORK ADDRESS MASK GATEWAY MTU ZONE DNS PXE
private 192.168.0.0 255.255.255.0 192.168.121.1 --- ---- False True
------------------------------------------- list host -------------------------------------------
HOST RACK RANK APPLIANCE OS BOX ENVIRONMENT OSACTION INSTALLACTION COMMENT
frontend-0-0 0 0 frontend sles frontend ----------- default default -------
backend-0-0 0 0 backend sles default ----------- default default -------
-------------------------------------- list host interface --------------------------------------
HOST INTERFACE DEFAULT NETWORK MAC IP NAME MODULE VLAN OPTIONS CHANNEL
frontend-0-0 eth1 True private 52:54:00:e3:a0:a8 192.168.0.2 frontend-0-0 ------ ---- ------- -------
backend-0-0 eth0 ------- ------- 52:54:00:75:5c:ff ----------- ------------ ------ ---- ------- -------
backend-0-0 eth1 True private 52:54:00:00:00:03 192.168.0.1 backend-0-0 ------ ---- ------- -------
----------------------------------- SLES pallet patch source ------------------------------------
stacki-5.6rc5-sles12-sles-x86_64
----------------------------------- SLES pallet patch source ------------------------------------
stacki-5.6.1-sles15-sles-x86_64
==================================== short test summary info ====================================
SKIPPED [1] tests/test_services.py:38: named should only be running if a network is set to dns=true
SKIPPED [1] tests/test_partitions.py:37: Using default stacki partition config for host backend-0-0
=========================== 33 passed, 2 skipped, 1 warning in 12.02s ===========================

@megkido
megkido
requested a review
from bsandersAugust 24, 2020 22:54
megkido
megkido
commented
Aug 25, 2020
View reviewed changes
Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Outdated

bsanders
bsanders
suggested changes
Aug 25, 2020
View reviewed changes
Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Outdated

Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Outdated

Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Outdated

Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Outdated

Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Outdated

Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Outdated

Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Outdated

Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Outdated

Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Outdated

megkido
megkido
commented
Aug 27, 2020
View reviewed changes
Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py
@megkido
megkidoforce-pushed
the
feature/test_sles_patches
branch
from
8d88199 to
76c8041CompareSeptember 1, 2020 19:31
bsanders
bsanders
reviewed
Sep 1, 2020
View reviewed changes
Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Outdated

@megkido
megkidoforce-pushed
the
feature/test_sles_patches
branch
2 times, most recently
from
9d66b6e to
6c8fea4CompareSeptember 2, 2020 03:57
@megkido
megkido
requested a review
from caladdSeptember 16, 2020 00:01
caladd
caladd
suggested changes
Sep 16, 2020
View reviewed changes
@caladdcaladd
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make the recommended code changes and re-examine the code logic. I'm not sure this is actually testing that all the files in all the RPMs have the correct hashes.
Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Outdated

Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Outdated

Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Outdated

Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Outdated

Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Outdated

Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Outdated

Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py
	assert sles_flavors

	# Find out where is stack-sles*images*.rpm file(s)
	result = host.run('find /export/stack/pallets/stacki/ -name "*stack-sles-*.rpm"')
@caladdcaladdSep 16, 2020

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pattern should have a \ before the .:
"*stack-sles-*\.rpm"

@megkidomegkidoOct 6, 2020

Copy link


Copy Markdown

Author
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

having \ before . broke the code.
Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Outdated

Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Outdated

@megkido
megkido
commented
Oct 6, 2020•

edited

Loading

Copy link


Copy Markdown

Author
Updated output
Failure case
--------------------------------- SLES12sp3 pallet patch source NOT found ----------------------------------
/opt/stack/pallet-patches/SLES-12sp3-sles12-sles-x86_64/add-stacki-squashfs/content
-------------------------------------- SLES15sp1 pallet patch source ---------------------------------------
stacki-5.6.1-sles15-sles-x86_64
-------------------------------------- SLES11sp3 pallet patch source ---------------------------------------
stacki-5.6rc5-sles12-sles-x86_64

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


2 more reviewers

@caladdcaladdcaladd requested changes
@bsandersbsandersbsanders requested changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@megkido@caladd@bsanders

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
FEATURE: ReportSys test for SLES pallet patch - #825
Open
megkido wants to merge 4 commits into
developfrom 
feature/test_sles_patches
Open
FEATURE: ReportSys test for SLES pallet patch#825
megkido wants to merge 4 commits into
developfrom 
feature/test_sles_patches
Conversation
@megkido
@megkidomegkido
commented
Aug 24, 2020•

edited

Loading

Copy link


Copy Markdown

Output
frontend-0-0:/opt/stack/lib/python3.8/site-packages/stack/commands/report/system/tests # stack report system
====================================== test session starts ======================================
platform linux -- Python 3.8.3, pytest-6.0.1, py-1.9.0, pluggy-0.13.1 -- /opt/stack/bin/python3
cachedir: .pytest_cache
rootdir: /opt/stack/lib/python3.8/site-packages/stack/commands/report/system
plugins: testinfra-1.16.0
collected 35 items
tests/test_stacki.py::test_stack_list[local-box] PASSED
tests/test_stacki.py::test_stack_list[local-pallet] PASSED
tests/test_stacki.py::test_stack_list[local-cart] PASSED
tests/test_stacki.py::test_stack_list[local-network] PASSED
tests/test_stacki.py::test_stack_list[local-host] PASSED
tests/test_stacki.py::test_stack_list[local-host interface] PASSED
tests/test_stacki.py::test_stacki_pallets_sane[local] PASSED
tests/test_stacki.py::test_stacki_central_server[local] PASSED
tests/test_stacki.py::test_stacki_ca_correct[local] PASSED
tests/test_services.py::test_service_enabled_and_running[local-dhcpd] PASSED
tests/test_services.py::test_service_enabled_and_running[local-named] SKIPPED
tests/test_services.py::test_service_enabled_and_running[local-rsyslog] PASSED
tests/test_services.py::test_service_enabled_and_running[local-smq-processor] PASSED
tests/test_services.py::test_service_enabled_and_running[local-smq-producer] PASSED
tests/test_services.py::test_service_enabled_and_running[local-smq-publisher] PASSED
tests/test_services.py::test_service_enabled_and_running[local-sshd] PASSED
tests/test_services.py::test_service_enabled_and_running[local-chronyd] PASSED
tests/test_services.py::test_service_enabled_and_running[local-apache2] PASSED
tests/test_services.py::test_service_enabled_and_running[local-mysql] PASSED
tests/test_services.py::test_tftpd_enabled_and_running[local] PASSED
tests/test_services.py::test_logrotate_service_enabled[local] PASSED
tests/test_services.py::test_logrotate_configuration_valid[local] PASSED
tests/test_services.py::test_stacki_logrotate_file_exists[local] PASSED
tests/test_restapi.py::test_restapi_list_host PASSED
tests/test_backend_installs.py::TestBackendInstalls::test_backend[backend-0-0] PASSED
tests/test_partitions.py::TestStoragePartition::test_storage_partition[paramiko://backend-0-0] SKIPPED
tests/test_backend_link.py::TestLinkUp::test_link_status[paramiko://backend-0-0] PASSED
tests/test_other_dhcp.py::test_other_dhcp_server[eth1] PASSED
tests/test_networks.py::test_hosts_in_correct_networks PASSED
tests/test_df.py::test_slash_not_full[local] PASSED
tests/test_df.py::test_export_not_full[local] PASSED
tests/test_df.py::test_var_not_full[local] PASSED
tests/test_sles_patch.py::test_sles_pallet_patched[local] PASSED
tests/test_pkgs.py::test_rpms_are_clean[local] PASSED
tests/test_pkgs.py::test_no_duplicate_rpms[local] PASSED
======================================= warnings summary ========================================
tests/test_partitions.py::TestStoragePartition::test_storage_partition[paramiko://backend-0-0]
/opt/stack/lib/python3.8/site-packages/paramiko/client.py:835: UserWarning: Unknown ssh-ed25519 host key for backend-0-0: b'f6d43303ee51d55add2c3ac4b0f8fac3'
warnings.warn(
-- Docs: https://docs.pytest.org/en/stable/warnings.html
========================================= Cluster Data ==========================================
------------------------------------------- list box --------------------------------------------
NAME OS PALLETS CARTS REPOS
11sp3 sles SLES-11sp3-sles11 stacki-5.6.1-sles11 ------- -----
12sp3 sles stacki-5.6.1-sles12 SLES-12sp3-sles12 stacki-5.6rc5-sles12 ------- -----
15sp1 sles SLES-15sp1-sles15 Packages-1-15sp1-sles15 stacki-5.6.1-sles15 ------- -----
default sles stacki-5.6.1-sles12 SLES-12sp3-sles12 vagrant -----
frontend sles stacki-5.6.1-sles12 SLES-12sp3-sles12 ------- -----
------------------------------------------ list pallet ------------------------------------------
NAME VERSION RELEASE ARCH OS BOXES
stacki 5.6.1 sles12 x86_64 sles default frontend 12sp3
SLES 12sp3 sles12 x86_64 sles default frontend 12sp3
SLES 15sp1 sles15 x86_64 sles 15sp1
Packages-1 15sp1 sles15 x86_64 sles 15sp1
SLES 11sp3 sles11 x86_64 sles 11sp3
stacki 5.6.1 sles15 x86_64 sles 15sp1
stacki 5.6.1 sles11 x86_64 sles 11sp3
stacki 5.6rc5 sles12 x86_64 sles 12sp3
------------------------------------------- list cart -------------------------------------------
NAME BOXES
vagrant default
----------------------------------------- list network ------------------------------------------
NETWORK ADDRESS MASK GATEWAY MTU ZONE DNS PXE
private 192.168.0.0 255.255.255.0 192.168.121.1 --- ---- False True
------------------------------------------- list host -------------------------------------------
HOST RACK RANK APPLIANCE OS BOX ENVIRONMENT OSACTION INSTALLACTION COMMENT
frontend-0-0 0 0 frontend sles frontend ----------- default default -------
backend-0-0 0 0 backend sles default ----------- default default -------
-------------------------------------- list host interface --------------------------------------
HOST INTERFACE DEFAULT NETWORK MAC IP NAME MODULE VLAN OPTIONS CHANNEL
frontend-0-0 eth1 True private 52:54:00:e3:a0:a8 192.168.0.2 frontend-0-0 ------ ---- ------- -------
backend-0-0 eth0 ------- ------- 52:54:00:75:5c:ff ----------- ------------ ------ ---- ------- -------
backend-0-0 eth1 True private 52:54:00:00:00:03 192.168.0.1 backend-0-0 ------ ---- ------- -------
----------------------------------- SLES pallet patch source ------------------------------------
stacki-5.6rc5-sles12-sles-x86_64
----------------------------------- SLES pallet patch source ------------------------------------
stacki-5.6.1-sles15-sles-x86_64
==================================== short test summary info ====================================
SKIPPED [1] tests/test_services.py:38: named should only be running if a network is set to dns=true
SKIPPED [1] tests/test_partitions.py:37: Using default stacki partition config for host backend-0-0
=========================== 33 passed, 2 skipped, 1 warning in 12.02s ===========================

@megkido
megkido
requested a review
from bsandersAugust 24, 2020 22:54
megkido
megkido
commented
Aug 25, 2020
View reviewed changes
Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Outdated

bsanders
bsanders
suggested changes
Aug 25, 2020
View reviewed changes
Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Outdated

Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Outdated

Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Outdated

Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Outdated

Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Outdated

Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Outdated

Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Outdated

Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Outdated

Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Outdated

megkido
megkido
commented
Aug 27, 2020
View reviewed changes
Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py
@megkido
megkidoforce-pushed
the
feature/test_sles_patches
branch
from
8d88199 to
76c8041CompareSeptember 1, 2020 19:31
bsanders
bsanders
reviewed
Sep 1, 2020
View reviewed changes
Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Outdated

@megkido
megkidoforce-pushed
the
feature/test_sles_patches
branch
2 times, most recently
from
9d66b6e to
6c8fea4CompareSeptember 2, 2020 03:57
@megkido
megkido
requested a review
from caladdSeptember 16, 2020 00:01
caladd
caladd
suggested changes
Sep 16, 2020
View reviewed changes
@caladdcaladd
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make the recommended code changes and re-examine the code logic. I'm not sure this is actually testing that all the files in all the RPMs have the correct hashes.
Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Outdated

Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Outdated

Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Outdated

Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Outdated

Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Outdated

Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Outdated

Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py
	assert sles_flavors

	# Find out where is stack-sles*images*.rpm file(s)
	result = host.run('find /export/stack/pallets/stacki/ -name "*stack-sles-*.rpm"')
@caladdcaladdSep 16, 2020

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pattern should have a \ before the .:
"*stack-sles-*\.rpm"

@megkidomegkidoOct 6, 2020

Copy link


Copy Markdown

Author
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

having \ before . broke the code.
Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Outdated

Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Outdated

@megkido
megkido
commented
Oct 6, 2020•

edited

Loading

Copy link


Copy Markdown

Author
Updated output
Failure case
--------------------------------- SLES12sp3 pallet patch source NOT found ----------------------------------
/opt/stack/pallet-patches/SLES-12sp3-sles12-sles-x86_64/add-stacki-squashfs/content
-------------------------------------- SLES15sp1 pallet patch source ---------------------------------------
stacki-5.6.1-sles15-sles-x86_64
-------------------------------------- SLES11sp3 pallet patch source ---------------------------------------
stacki-5.6rc5-sles12-sles-x86_64

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


2 more reviewers

@caladdcaladdcaladd requested changes
@bsandersbsandersbsanders requested changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@megkido@caladd@bsanders

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
FEATURE: ReportSys test for SLES pallet patch - #825
Open
megkido wants to merge 4 commits into
developfrom 
feature/test_sles_patches
Open
FEATURE: ReportSys test for SLES pallet patch#825
megkido wants to merge 4 commits into
developfrom 
feature/test_sles_patches
Conversation
@megkido
@megkidomegkido
commented
Aug 24, 2020•

edited

Loading

Copy link


Copy Markdown

Output
frontend-0-0:/opt/stack/lib/python3.8/site-packages/stack/commands/report/system/tests # stack report system
====================================== test session starts ======================================
platform linux -- Python 3.8.3, pytest-6.0.1, py-1.9.0, pluggy-0.13.1 -- /opt/stack/bin/python3
cachedir: .pytest_cache
rootdir: /opt/stack/lib/python3.8/site-packages/stack/commands/report/system
plugins: testinfra-1.16.0
collected 35 items
tests/test_stacki.py::test_stack_list[local-box] PASSED
tests/test_stacki.py::test_stack_list[local-pallet] PASSED
tests/test_stacki.py::test_stack_list[local-cart] PASSED
tests/test_stacki.py::test_stack_list[local-network] PASSED
tests/test_stacki.py::test_stack_list[local-host] PASSED
tests/test_stacki.py::test_stack_list[local-host interface] PASSED
tests/test_stacki.py::test_stacki_pallets_sane[local] PASSED
tests/test_stacki.py::test_stacki_central_server[local] PASSED
tests/test_stacki.py::test_stacki_ca_correct[local] PASSED
tests/test_services.py::test_service_enabled_and_running[local-dhcpd] PASSED
tests/test_services.py::test_service_enabled_and_running[local-named] SKIPPED
tests/test_services.py::test_service_enabled_and_running[local-rsyslog] PASSED
tests/test_services.py::test_service_enabled_and_running[local-smq-processor] PASSED
tests/test_services.py::test_service_enabled_and_running[local-smq-producer] PASSED
tests/test_services.py::test_service_enabled_and_running[local-smq-publisher] PASSED
tests/test_services.py::test_service_enabled_and_running[local-sshd] PASSED
tests/test_services.py::test_service_enabled_and_running[local-chronyd] PASSED
tests/test_services.py::test_service_enabled_and_running[local-apache2] PASSED
tests/test_services.py::test_service_enabled_and_running[local-mysql] PASSED
tests/test_services.py::test_tftpd_enabled_and_running[local] PASSED
tests/test_services.py::test_logrotate_service_enabled[local] PASSED
tests/test_services.py::test_logrotate_configuration_valid[local] PASSED
tests/test_services.py::test_stacki_logrotate_file_exists[local] PASSED
tests/test_restapi.py::test_restapi_list_host PASSED
tests/test_backend_installs.py::TestBackendInstalls::test_backend[backend-0-0] PASSED
tests/test_partitions.py::TestStoragePartition::test_storage_partition[paramiko://backend-0-0] SKIPPED
tests/test_backend_link.py::TestLinkUp::test_link_status[paramiko://backend-0-0] PASSED
tests/test_other_dhcp.py::test_other_dhcp_server[eth1] PASSED
tests/test_networks.py::test_hosts_in_correct_networks PASSED
tests/test_df.py::test_slash_not_full[local] PASSED
tests/test_df.py::test_export_not_full[local] PASSED
tests/test_df.py::test_var_not_full[local] PASSED
tests/test_sles_patch.py::test_sles_pallet_patched[local] PASSED
tests/test_pkgs.py::test_rpms_are_clean[local] PASSED
tests/test_pkgs.py::test_no_duplicate_rpms[local] PASSED
======================================= warnings summary ========================================
tests/test_partitions.py::TestStoragePartition::test_storage_partition[paramiko://backend-0-0]
/opt/stack/lib/python3.8/site-packages/paramiko/client.py:835: UserWarning: Unknown ssh-ed25519 host key for backend-0-0: b'f6d43303ee51d55add2c3ac4b0f8fac3'
warnings.warn(
-- Docs: https://docs.pytest.org/en/stable/warnings.html
========================================= Cluster Data ==========================================
------------------------------------------- list box --------------------------------------------
NAME OS PALLETS CARTS REPOS
11sp3 sles SLES-11sp3-sles11 stacki-5.6.1-sles11 ------- -----
12sp3 sles stacki-5.6.1-sles12 SLES-12sp3-sles12 stacki-5.6rc5-sles12 ------- -----
15sp1 sles SLES-15sp1-sles15 Packages-1-15sp1-sles15 stacki-5.6.1-sles15 ------- -----
default sles stacki-5.6.1-sles12 SLES-12sp3-sles12 vagrant -----
frontend sles stacki-5.6.1-sles12 SLES-12sp3-sles12 ------- -----
------------------------------------------ list pallet ------------------------------------------
NAME VERSION RELEASE ARCH OS BOXES
stacki 5.6.1 sles12 x86_64 sles default frontend 12sp3
SLES 12sp3 sles12 x86_64 sles default frontend 12sp3
SLES 15sp1 sles15 x86_64 sles 15sp1
Packages-1 15sp1 sles15 x86_64 sles 15sp1
SLES 11sp3 sles11 x86_64 sles 11sp3
stacki 5.6.1 sles15 x86_64 sles 15sp1
stacki 5.6.1 sles11 x86_64 sles 11sp3
stacki 5.6rc5 sles12 x86_64 sles 12sp3
------------------------------------------- list cart -------------------------------------------
NAME BOXES
vagrant default
----------------------------------------- list network ------------------------------------------
NETWORK ADDRESS MASK GATEWAY MTU ZONE DNS PXE
private 192.168.0.0 255.255.255.0 192.168.121.1 --- ---- False True
------------------------------------------- list host -------------------------------------------
HOST RACK RANK APPLIANCE OS BOX ENVIRONMENT OSACTION INSTALLACTION COMMENT
frontend-0-0 0 0 frontend sles frontend ----------- default default -------
backend-0-0 0 0 backend sles default ----------- default default -------
-------------------------------------- list host interface --------------------------------------
HOST INTERFACE DEFAULT NETWORK MAC IP NAME MODULE VLAN OPTIONS CHANNEL
frontend-0-0 eth1 True private 52:54:00:e3:a0:a8 192.168.0.2 frontend-0-0 ------ ---- ------- -------
backend-0-0 eth0 ------- ------- 52:54:00:75:5c:ff ----------- ------------ ------ ---- ------- -------
backend-0-0 eth1 True private 52:54:00:00:00:03 192.168.0.1 backend-0-0 ------ ---- ------- -------
----------------------------------- SLES pallet patch source ------------------------------------
stacki-5.6rc5-sles12-sles-x86_64
----------------------------------- SLES pallet patch source ------------------------------------
stacki-5.6.1-sles15-sles-x86_64
==================================== short test summary info ====================================
SKIPPED [1] tests/test_services.py:38: named should only be running if a network is set to dns=true
SKIPPED [1] tests/test_partitions.py:37: Using default stacki partition config for host backend-0-0
=========================== 33 passed, 2 skipped, 1 warning in 12.02s ===========================

@megkido
megkido
requested a review
from bsandersAugust 24, 2020 22:54
megkido
megkido
commented
Aug 25, 2020
View reviewed changes
Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Outdated

bsanders
bsanders
suggested changes
Aug 25, 2020
View reviewed changes
Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Outdated

Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Outdated

Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Outdated

Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Outdated

Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Outdated

Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Outdated

Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Outdated

Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Outdated

Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Outdated

megkido
megkido
commented
Aug 27, 2020
View reviewed changes
Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py
@megkido
megkidoforce-pushed
the
feature/test_sles_patches
branch
from
8d88199 to
76c8041CompareSeptember 1, 2020 19:31
bsanders
bsanders
reviewed
Sep 1, 2020
View reviewed changes
Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Outdated

@megkido
megkidoforce-pushed
the
feature/test_sles_patches
branch
2 times, most recently
from
9d66b6e to
6c8fea4CompareSeptember 2, 2020 03:57
@megkido
megkido
requested a review
from caladdSeptember 16, 2020 00:01
caladd
caladd
suggested changes
Sep 16, 2020
View reviewed changes
@caladdcaladd
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make the recommended code changes and re-examine the code logic. I'm not sure this is actually testing that all the files in all the RPMs have the correct hashes.
Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Outdated

Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Outdated

Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Outdated

Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Outdated

Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Outdated

Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Outdated

Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py
	assert sles_flavors

	# Find out where is stack-sles*images*.rpm file(s)
	result = host.run('find /export/stack/pallets/stacki/ -name "*stack-sles-*.rpm"')
@caladdcaladdSep 16, 2020

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pattern should have a \ before the .:
"*stack-sles-*\.rpm"

@megkidomegkidoOct 6, 2020

Copy link


Copy Markdown

Author
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

having \ before . broke the code.
Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Outdated

Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Comment threadcommon/src/stack/report-system/command/report/system/tests/test_sles_patch.py
Outdated

@megkido
megkido
commented
Oct 6, 2020•

edited

Loading

Copy link


Copy Markdown

Author
Updated output
Failure case
--------------------------------- SLES12sp3 pallet patch source NOT found ----------------------------------
/opt/stack/pallet-patches/SLES-12sp3-sles12-sles-x86_64/add-stacki-squashfs/content
-------------------------------------- SLES15sp1 pallet patch source ---------------------------------------
stacki-5.6.1-sles15-sles-x86_64
-------------------------------------- SLES11sp3 pallet patch source ---------------------------------------
stacki-5.6rc5-sles12-sles-x86_64

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


2 more reviewers

@caladdcaladdcaladd requested changes
@bsandersbsandersbsanders requested changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@megkido@caladd@bsanders