Uh oh!
There was an error while loading. Please reload this page.
Add Terminal49 TypeScript CLI (production-ready) - #310
Conversation
The SDK moved to 0.3.0 on main while this branch was open. The CLI's package.json still pinned ^0.2.0, so npm installed a separate published copy instead of resolving the in-repo workspace package, hiding the new resource surface (webhooks, vessels, ports, custom fields, etc.) from the CLI's type checker. Regenerate package-lock.json accordingly. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
- config.ts: `config list`, `clear`, `auth-status`, and `client-check` were wired as `async (command: Command) => ...`, but Commander calls zero-positional-arg actions as `(options, command)`. The first runtime argument was the parsed options object, not the Command, so `command.optsWithGlobals()` threw. Add the missing options parameter and read globals off the real command argument. - custom-field-options.ts: `get <definition-id> <option-id>` had the same bug — missing the options parameter before `command`, so `command` was actually the options object and `optsWithGlobals()` threw on every call. - config.ts (root config module): when `XDG_CONFIG_HOME` is set, nest the config file under a `terminal49/` subdirectory instead of writing `config.json` directly at the XDG root, avoiding collisions with other apps' config files. - containers.ts (SDK): `demurrage()` read `data.data.attributes` assuming a raw JSON:API document, but `this.get()` honors the manager's configured default format. Force `format: 'raw'` so the fields are populated regardless of client format configuration. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Exposes client/mappers (mapTrackingRequest, etc.) from the package entry so the CLI can normalize create/infer responses to mapped output. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Public repo: sanitize captured API fixtures (synthetic company names, fake UUIDs/container/BOL numbers with referential consistency) and delete the committed live table renders (used by no test). Gitignore the table fixture dir and coverage output so live captures cannot be re-committed. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…avior bugs
Collapse the per-command formatter/client/error boilerplate into one typed
action()/listAction() helper, eliminating the drift it caused. Fixes:
- --fields now projects list rows ({items:[...]}) instead of returning {}
- usage errors exit 2 with the JSON envelope; NetworkError->9, AuthError->3
- drop filter flags the API silently ignores (--carrier/--port/--status/
--updated-after); add supported --number/--tracking-stopped; map
tracking-requests --status to filter[status]
- honor global --format everywhere, incl. create/infer (mapped/raw/both)
- --type override now beats SDK inference
- single strict JSON payload parser (errors on non-object; supports '-' stdin)
- config: reject unknown keys (exit 2), redact token, surface corrupt files
- richer 't49 commands --json' metadata (args, required, choices, globals)
- expose SDK coverage: --all iteration, --account-id, --timeout, --include
- table output: per-command columns + key-value detail panel
Remove dead surface (--quiet/--verbose/--no-color, polling/pagination utils).
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>Fix main/types to dist/src, add exports map, publishConfig.access, LICENSE, repository metadata, engines>=20. Migrate lint/format from Biome to oxlint/oxfmt (matching the SDK), drop the unused chalk dependency and regenerate the root lockfile, strengthen prepublishOnly, and add a cli job to CI that builds the SDK first then builds/tests/lints the CLI. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Align container/shipment setCustomField POST bodies with the OpenAPI schema so CLI set-custom-field calls are accepted by the API. Co-authored-by: Akshay Dodeja <dodeja@gmail.com>
Brand list envelopes explicitly, keep --format raw intact (included/ links/meta), switch fixture capture to npm, and pin the workspace SDK dependency to 0.3.1. Co-authored-by: Akshay Dodeja <dodeja@gmail.com>
Wire @terminal49/cli into release automation and bump its SDK dependency when the SDK releases. Co-authored-by: Akshay Dodeja <dodeja@gmail.com>
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Preview deployment for your docs. Learn more about Mintlify Previews.
|
| "type": "json", | ||
| "path": "sdks/typescript-sdk-cli/package.json", | ||
| "jsonpath": "$.dependencies['@terminal49/sdk']" | ||
| } | ||
| ] |
There was a problem hiding this comment.
When release-please bumps the SDK, this entry updates the CLI package's @terminal49/sdk dependency without updating the corresponding CLI workspace dependency in the root lockfile. The subsequent root-level npm ci used by CLI CI and publishing rejects the inconsistent manifest and lockfile, preventing the CLI from building or publishing.
Knowledge Base Used:Repo Tooling and CI
Prompt To Fix With AI
This is a comment left during a code review.
Path: .release-please-config.json
Line: 34-38
Comment:
**CLI lockfile dependency stays stale**
When release-please bumps the SDK, this entry updates the CLI package's `@terminal49/sdk` dependency without updating the corresponding CLI workspace dependency in the root lockfile. The subsequent root-level `npm ci` used by CLI CI and publishing rejects the inconsistent manifest and lockfile, preventing the CLI from building or publishing.
**Knowledge Base Used:**[Repo Tooling and CI](https://app.greptile.com/terminal49/-/custom-context/knowledge-base/terminal49/api/-/docs/repo-tooling-ci.md)---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit:35cb5b7f3f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| run_json() { | ||
| local out="$1" | ||
| shift | ||
| run_dev "$@" --json > "$API_FIXTURES/$out" |
There was a problem hiding this comment.
When this script runs with a real account token, run_json writes the complete API response—including customer names, reference numbers, and resource identifiers—directly into a tracked fixture directory. The comment and final reminder do not perform sanitization, so a routine fixture refresh can accidentally publish customer data; scrub deterministically before writing or capture outside the worktree and validate before copying.
AGENTS.md reference: AGENTS.md:L3-L3
Useful? React with 👍 / 👎.
| { | ||
| "type": "json", | ||
| "path": "sdks/typescript-sdk-cli/package.json", | ||
| "jsonpath": "$.dependencies['@terminal49/sdk']" |
There was a problem hiding this comment.
When Release Please bumps the SDK, this updater changes the CLI's exact @terminal49/sdk dependency but does not update the corresponding dependency under packages['sdks/typescript-sdk-cli'] in the authoritative root lockfile. The resulting release PR and CLI publish tag run root npm ci, which rejects the package/lock mismatch before building; add an adjacent root-lock extra-files updater for that dependency.
AGENTS.md reference: AGENTS.md:L11-L11
Useful? React with 👍 / 👎.
| "sdks/typescript-sdk-cli": { | ||
| "package-name": "@terminal49/cli", | ||
| "release-type": "node", | ||
| "changelog-path": "CHANGELOG.md", | ||
| "bump-minor-pre-major": true, |
There was a problem hiding this comment.
When Release Please increments the CLI package version, this package configuration has no updater for package-lock.json's packages['sdks/typescript-sdk-cli'].version. Because the publish workflow checks out that tag and runs root npm ci, every such CLI release will fail on the stale workspace version before it reaches npm publish; include the root lock entry in extra-files.
AGENTS.md reference: AGENTS.md:L11-L11
Useful? React with 👍 / 👎.
| format: ResponseFormat | undefined, | ||
| mapper: Mapper, | ||
| ): unknown { | ||
| if (!format || format === 'raw') return raw; |
There was a problem hiding this comment.
For tracking-requests create, infer, create-from-infer, and track without an explicit --format, createClient resolves the configured/default format to mapped, but these helpers receive only globals.format; undefined is therefore treated as raw. The raw-only SDK create/infer methods consequently emit JSON:API documents despite the CLI's mapped default, and a configured defaultFormat: both is also ignored; pass the effective resolved format into this formatter.
Useful? React with 👍 / 👎.
| if (format === 'both') return { raw, mapped: client.deserialize(raw) }; | ||
| if (format === 'raw') return raw; | ||
| return client.deserialize(raw); |
There was a problem hiding this comment.
When a user sets defaultFormat to raw or both in the CLI config and runs t49 search without --format, this helper receives undefined rather than the format resolved by createClient and always deserializes the response. Thus the documented persistent format setting has no effect on search output; use the effective configured format instead of interpreting a missing flag as mapped.
Useful? React with 👍 / 👎.
Uh oh!
There was an error while loading. Please reload this page.
Summary
Production-ready follow-up to #223. Rebases the TypeScript CLI onto current
main, fixes the remaining Codex review blockers, and wires@terminal49/cliinto release automation.sdks/typescript-sdk-cli(t49/@terminal49/cli@0.1.0) on sharedaction()/listAction()helpers@terminal49/sdkwith the resource surface the CLI needs (webhooks, vessels, ports, terminals, parties, metro areas, custom fields, container map/custom fields/demurrage, shipment custom fields) plus mapper re-exportsmainand add acliCI jobsetCustomFieldPOST body to OpenAPI shape (data.attributes.api_slug/value)--format rawno longer stripped by a loose{ data }envelope check (brandedcliEnvelope)npm(waspnpm)publish_typescript_cli.yml; bump CLI’s SDK dep when the SDK releasesSupersedes conflicted #223 (
codex/update-typescript-sdk-cli-current).Release order after merge
@terminal49/sdk@0.3.1)0.1.0(depends on the new SDK version)Verification
npm run test --workspace @terminal49/sdk -- --run— 106 passednpm run test --workspace @terminal49/cli— 22 passednpm run test --workspace @terminal49/mcp -- --run— 149 passednode sdks/typescript-sdk-cli/dist/bin/t49.js --version→0.1.0Review notes
Addresses outstanding Codex comments on #223:
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Greptile Summary
The PR adds a production TypeScript CLI, expands the SDK resource surface it consumes, and wires both packages into CI and release automation.
@terminal49/cli.Confidence Score: 4/5
The release configuration should be fixed before merging because the next SDK bump can leave the CLI workspace lockfile inconsistent and block CLI CI and publication.
The SDK release now edits the CLI's SDK dependency, while both CLI CI and publishing consume a root lockfile whose matching workspace dependency is not included in release-please's updates.
Files Needing Attention: .release-please-config.json and package-lock.json
Important Files Changed
Flowchart
%%{init: {'theme': 'neutral'}}%% flowchart LR User[t49 CLI user] --> CLI["@terminal49/cli"] CLI --> SDK["@terminal49/sdk"] SDK --> API[Terminal49 API] RP[release-please] --> SDKManifest[SDK package version] RP --> CLIManifest[CLI SDK dependency] CLIManifest --> Lockfile[Root package-lock.json] Lockfile --> CI[CLI CI and publish npm ci] CI --> NPM[npm registry]Prompt To Fix All With AI
Reviews (1): Last reviewed commit: "chore(cli): add release-please package a..." | Re-trigger Greptile
Context used (3)
@terminal49/sdk)