Uh oh!
There was an error while loading. Please reload this page.
feat: Added GetFileNameWithoutExtension() extension method to IFileInfo - #74
Open
Blaisor wants to merge 3 commits into
Open
feat: Added GetFileNameWithoutExtension() extension method to IFileInfo#74Blaisor wants to merge 3 commits into
Blaisor wants to merge 3 commits into
Conversation
gigi81
commented
Feb 28, 2025
Collaborator
Hi @Blaisor |
gigi81
requested changes
Jan 3, 2026
gigi81
left a comment
Collaborator
There was a problem hiding this comment.
Can you please apply the changes suggested. Sorry it took so long
| } | ||
| /// <inheritdoc cref="IPath.GetFileNameWithoutExtension(string?)"/> | ||
| public static string GetFileNameWithoutExtension(this IFileInfo file) |
Collaborator
There was a problem hiding this comment.
Suggested change
| publicstaticstringGetFileNameWithoutExtension(thisIFileInfofile) | |
| publicstaticstringNameWithoutExtension(thisIFileInfofile) |
Author
There was a problem hiding this comment.
I'd go with GetFileNameWithoutExtension, as it starts with a verb. However, if we used C# 14, we could add a nice extension property with the name NameWithoutExtension.
| var file = current.File(fileName); | ||
| //act | ||
| var name = file.GetFileNameWithoutExtension(); |
Collaborator
There was a problem hiding this comment.
Suggested change
| varname=file.GetFileNameWithoutExtension(); | |
| varname=file.NameWithoutExtension(); |
| [TestCase("test.extension", "test")] | ||
| [TestCase("noextension", "noextension")] | ||
| [TestCase(".extensiononly", "")] | ||
| public void GetFileNameWithoutExtension_WithValidFileName_ReturnsNameWithoutExtension(string fileName, string expectedName) |
Collaborator
There was a problem hiding this comment.
Suggested change
| publicvoidGetFileNameWithoutExtension_WithValidFileName_ReturnsNameWithoutExtension(stringfileName,stringexpectedName) | |
| publicvoidNameWithoutExtension_WithValidFileName_ReturnsNameWithoutExtension(stringfileName,stringexpectedName) |
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Luigi Grilli <luigi.grilli@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.