Skip to content

fix: use full path in Directory.SetCurrentDirectory - #1028

Merged
mergify[bot] merged 2 commits into
TestableIO:mainfrom
vbreuss:topic/vb/setcurrentdirectory-should-set-absolute-path
Aug 22, 2023
Merged

fix: use full path in Directory.SetCurrentDirectory#1028
mergify[bot] merged 2 commits into
TestableIO:mainfrom
vbreuss:topic/vb/setcurrentdirectory-should-set-absolute-path

Conversation

@vbreuss

Copy link
Copy Markdown
Member

The current directory should always be a rooted path, even if the directory is set to a relative directory.

@fgreinacher
fgreinacher enabled auto-merge (squash) August 22, 2023 13:43
@mergify
mergifyBot merged commit 4c5b0c1 into TestableIO:mainAug 22, 2023
@github-actions

Copy link
Copy Markdown

This is addressed in release v19.2.63.

@github-actionsgithub-actionsBot added the state: released Issues that are released label Aug 22, 2023
vbreuss referenced this pull request in Testably/Testably.Abstractions Aug 22, 2023
…19.2.64 (#370)
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)
This PR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
|
[TestableIO.System.IO.Abstractions](https://togithub.com/TestableIO/System.IO.Abstractions)
| nuget | patch | `19.2.61` -> `19.2.64` |
---
### Release Notes
<details>
<summary>TestableIO/System.IO.Abstractions
(TestableIO.System.IO.Abstractions)</summary>
###
[`v19.2.64`](https://togithub.com/TestableIO/System.IO.Abstractions/releases/tag/v19.2.64)
##### What's Changed
- feat: add `Null` to MockFileStream to shadow the static `Stream.Null`
field by [@&#8203;vbreuss](https://togithub.com/vbreuss) in
[https://github.com/TestableIO/System.IO.Abstractions/pull/1025](https://togithub.com/TestableIO/System.IO.Abstractions/pull/1025)
**Full Changelog**:
TestableIO/System.IO.Abstractions@v19.2.63...v19.2.64
###
[`v19.2.63`](https://togithub.com/TestableIO/System.IO.Abstractions/releases/tag/v19.2.63)
#### What's Changed
- refactor: use `CommonExceptions` to create exceptions by
[@&#8203;vbreuss](https://togithub.com/vbreuss) in
[https://github.com/TestableIO/System.IO.Abstractions/pull/1027](https://togithub.com/TestableIO/System.IO.Abstractions/pull/1027)
- fix: use full path in `Directory.SetCurrentDirectory` by
[@&#8203;vbreuss](https://togithub.com/vbreuss) in
[https://github.com/TestableIO/System.IO.Abstractions/pull/1028](https://togithub.com/TestableIO/System.IO.Abstractions/pull/1028)
**Full Changelog**:
TestableIO/System.IO.Abstractions@v19.2.61...v19.2.63
</details>
---
### Configuration
📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).
🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.
♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.
🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box
---
This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/Testably/Testably.Abstractions).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi40My4yIiwidXBkYXRlZEluVmVyIjoiMzYuNDMuMiIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

state: releasedIssues that are released

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@vbreuss@fgreinacher