Skip to content

refactor: update supported frameworks - #1060

Merged
mergify[bot] merged 8 commits into
TestableIO:mainfrom
vbreuss:topic/update-framework-to-462
Dec 5, 2023
Merged

refactor: update supported frameworks#1060
mergify[bot] merged 8 commits into
TestableIO:mainfrom
vbreuss:topic/update-framework-to-462

Conversation

@vbreuss

@vbreussvbreuss commented Dec 4, 2023

Copy link
Copy Markdown
Member

Update frameworks in preparation to support nunit v4:

  • Update .NET Framework 4.6.1 to .NET Framework 4.6.2
  • Remove no longer supported version .NET 5
  • Remove .NET Core 3.1 from test project

Related to #1058

BREAKING CHANGE: .NET Framework 4.6.1 and .NET 5 targets are not available anymore because they are out of support.

@fgreinacherfgreinacher left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thanks @vbreuss.

Just two minor things I noticed

Comment threadsrc/System.IO.Abstractions/System.IO.Abstractions.csproj Outdated
@vbreuss
vbreussforce-pushed the topic/update-framework-to-462 branch from 7c04982 to 261188dCompareDecember 4, 2023 12:12
@fgreinacher

fgreinacher commented Dec 5, 2023

Copy link
Copy Markdown
Contributor

I bumped the version to 20.0 and added the breaking change trailer to the description.

Furthermore I tried to fix the release commenter workflow by adding a dedicated token, as suggested in see https://docs.github.com/en/actions/using-workflows/triggering-a-workflow#triggering-a-workflow-from-a-workflow.

@fgreinacherfgreinacher left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a ton @vbreuss 🙇

@mergify
mergifyBot merged commit 1433878 into TestableIO:mainDec 5, 2023
@github-actions

Copy link
Copy Markdown

This is addressed in release v20.0.4.

@github-actionsgithub-actionsBot added the state: released Issues that are released label Dec 5, 2023
mergifyBot referenced this pull request in Testably/Testably.Abstractions Dec 6, 2023
…20.0.4 (#433)
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)
This PR contains the following updates:
| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[TestableIO.System.IO.Abstractions](https://togithub.com/TestableIO/System.IO.Abstractions)
| `20.0.1` -> `20.0.4` |
[![age](https://developer.mend.io/api/mc/badges/age/nuget/TestableIO.System.IO.Abstractions/20.0.4?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/nuget/TestableIO.System.IO.Abstractions/20.0.4?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/nuget/TestableIO.System.IO.Abstractions/20.0.1/20.0.4?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/nuget/TestableIO.System.IO.Abstractions/20.0.1/20.0.4?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
---
### Release Notes
<details>
<summary>TestableIO/System.IO.Abstractions
(TestableIO.System.IO.Abstractions)</summary>
###
[`v20.0.4`](https://togithub.com/TestableIO/System.IO.Abstractions/releases/tag/v20.0.4)
##### What's Changed
- refactor: update supported frameworks by
[@&#8203;vbreuss](https://togithub.com/vbreuss) in
[https://github.com/TestableIO/System.IO.Abstractions/pull/1060](https://togithub.com/TestableIO/System.IO.Abstractions/pull/1060)
- fix(ci): make push step idempotent by
[@&#8203;fgreinacher](https://togithub.com/fgreinacher) in
[https://github.com/TestableIO/System.IO.Abstractions/pull/1062](https://togithub.com/TestableIO/System.IO.Abstractions/pull/1062)
- fix: combine ci and release workflows by
[@&#8203;fgreinacher](https://togithub.com/fgreinacher) in
[https://github.com/TestableIO/System.IO.Abstractions/pull/1063](https://togithub.com/TestableIO/System.IO.Abstractions/pull/1063)
- fix: use correct release commenter version by
[@&#8203;fgreinacher](https://togithub.com/fgreinacher) in
[https://github.com/TestableIO/System.IO.Abstractions/pull/1064](https://togithub.com/TestableIO/System.IO.Abstractions/pull/1064)
**Full Changelog**:
TestableIO/System.IO.Abstractions@v19.2.91...v20.0.4
</details>
---
### Configuration
📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).
🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.
♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.
🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box
---
This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/Testably/Testably.Abstractions).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy44MS4zIiwidXBkYXRlZEluVmVyIjoiMzcuODEuMyIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

state: releasedIssues that are released

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@vbreuss@fgreinacher