Skip to content

fix: Add missing lock around files dictionary - #1260

Merged
vbreuss merged 1 commit into
TestableIO:mainfrom
wimoy:wimoy-patch-1
Apr 8, 2025
Merged

fix: Add missing lock around files dictionary#1260
vbreuss merged 1 commit into
TestableIO:mainfrom
wimoy:wimoy-patch-1

Conversation

@wimoy

@wimoywimoy commented Apr 6, 2025

Copy link
Copy Markdown
Contributor

The files dictionary could be modified and resized by another thread. Without the lock, the read is not synchronized and can cause a KeyNotFoundException.

@wimoywimoy changed the title Add missing lock around files variablefix: Add missing lock around files variableApr 6, 2025
@wimoywimoy changed the title fix: Add missing lock around files variablefix: Add missing lock around files dictionaryApr 6, 2025
@wimoy
Add missing lock around files variable
eb91e30
The files dictionary could be modified and resized by another thread. Without the lock, the read is not synchronized and can cause a KeyNotFoundException.
@vbreuss
vbreuss requested a review from CopilotApril 8, 2025 06:24
CopilotAI reviewed Apr 8, 2025
View reviewed changes

CopilotAI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

Comment threadsrc/TestableIO.System.IO.Abstractions.TestingHelpers/MockFileSystem.cs
@vbreuss
vbreuss merged commit 4e3c7df into TestableIO:mainApr 8, 2025
@vbreuss

vbreuss commented Apr 8, 2025

Copy link
Copy Markdown
Member

Thanks, @wimoy

@github-actions

github-actionsBot commented Apr 18, 2025

Copy link
Copy Markdown

This is addressed in release v22.0.14.

@github-actionsgithub-actionsBot added the state: released Issues that are released label Apr 18, 2025
This was referenced Aug 1, 2025
Closed
Closed
Closed
This was referenced Aug 11, 2025
Closed
Closed
Closed
This was referenced Aug 19, 2025
Closed
Closed
This was referenced Sep 1, 2025
Closed
Closed
Closed
This was referenced Sep 8, 2025
Closed
Closed
Open
Open
This was referenced Sep 21, 2025
Closed
Closed
Closed
Closed
@dependabotdependabotBot mentioned this pull request Sep 29, 2025
Closed
This was referenced Jan 12, 2026
Closed
Closed
Open
Closed
Closed
This was referenced Feb 1, 2026
Closed
Closed
Closed
@dependabotdependabotBot mentioned this pull request Feb 17, 2026
Merged
@dependabotdependabotBot mentioned this pull request Apr 2, 2026
Closed
This was referenced Apr 10, 2026
Open
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Apr 28, 2026
Open
Closed
@dependabotdependabotBot mentioned this pull request May 11, 2026
Open
This was referenced Jun 16, 2026
Closed
Merged
This was referenced Jun 25, 2026
Closed
Closed
This was referenced Jul 13, 2026
Closed
Closed
Open
@dependabotdependabotBot mentioned this pull request Aug 10, 2026
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments

Assignees

No one assigned

Labels

state: releasedIssues that are released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wimoy@vbreuss