Skip to content

fix: MockFileSystem's File.WriteAllText, File.ReadAllText, Directory.GetFiles, Directory.Create fail with \\?\C:\foo style paths - #1305

Merged
vbreuss merged 6 commits into
TestableIO:mainfrom
mostynb:path_verifier_extended_length_paths
Jul 8, 2025
Merged

fix: MockFileSystem's File.WriteAllText, File.ReadAllText, Directory.GetFiles, Directory.Create fail with \\?\C:\foo style paths#1305
vbreuss merged 6 commits into
TestableIO:mainfrom
mostynb:path_verifier_extended_length_paths

Conversation

@mostynb

@mostynbmostynb commented Jul 2, 2025

Copy link
Copy Markdown
Contributor

This is an attempt to fix#1304.

@vbreuss

vbreuss commented Jul 3, 2025

Copy link
Copy Markdown
Member

@mostynb : Thanks for the PR. Could you please check the failing actions?

What happens on the real file system when you use Directory.GetFiles when the directory is prefixed with \\?\? Are the returned strings also prefixed with \\?\?

@mostynbmostynb changed the title Make MockFileSystems Directory.Create work with \\?\C:\foo style pathsfix: MockFileSystems Directory.Create fails with \\?\C:\foo style pathsJul 4, 2025
@mostynb
mostynbforce-pushed the path_verifier_extended_length_paths branch from c8ba403 to b9d59a2CompareJuly 4, 2025 12:12
@mostynb

mostynb commented Jul 4, 2025•
edited by vbreuss
Loading

Copy link
Copy Markdown
ContributorAuthor

Pushed an update which added braces to the if block, and updated the PR title.

What happens on the real file system when you use Directory.GetFiles when the directory is prefixed with \?? Are the returned strings also prefixed with \??

If I give System.IO.Directory.GetFiles() a \?\ style path on windows, it returns \?\ style paths.

@vbreuss

vbreuss commented Jul 6, 2025

Copy link
Copy Markdown
Member

@mostynb

If I give System.IO.Directory.GetFiles() a \\?\ style path on windows, it returns \\?\ style paths.

But this does not work on the MockFileSystem, even after this pull request, right?

@mostynbmostynb changed the title fix: MockFileSystems Directory.Create fails with \\?\C:\foo style pathsfix: MockFileSystem's File.WriteAllText, File.ReadAllText, Directory.GetFiles, Directory.Create fail with \\?\C:\foo style pathsJul 6, 2025
@mostynb

mostynb commented Jul 6, 2025•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

@mostynb

If I give System.IO.Directory.GetFiles() a \\?\ style path on windows, it returns \\?\ style paths.

But this does not work on the MockFileSystem, even after this pull request, right?

It did not, so I pushed some changes to make it work, assuming that you always use \\?\ style paths.

However, extended length paths aren't normalised internally in MockFileSystem. eg if I create \\?\C:\foo\bar.txt then I can read \\?\C:\foo\bar.txt, but C:\foo\bar.txt does not appear to exist.

vbreuss
vbreuss reviewed Jul 6, 2025
View reviewed changes
Comment threadtests/TestableIO.System.IO.Abstractions.TestingHelpers.Tests/MockDirectoryTests.cs Outdated
@mostynb
Make MockFileSystem's File.WriteAllText, File.ReadAllText and Directo…
0918171
…ry.GetFiles support extended length paths too
@mostynb
mostynbforce-pushed the path_verifier_extended_length_paths branch from eeb83c3 to 0918171CompareJuly 6, 2025 18:32
@vbreuss
vbreuss merged commit 2ad3fd6 into TestableIO:mainJul 8, 2025
9 checks passed
@vbreuss

vbreuss commented Jul 8, 2025

Copy link
Copy Markdown
Member

Thanks @mostynb, will publish v22.0.15 shortly!

@github-actions

github-actionsBot commented Jul 8, 2025

Copy link
Copy Markdown

This is addressed in release v22.0.15.

@github-actionsgithub-actionsBot added the state: released Issues that are released label Jul 8, 2025
@mostynb
mostynb deleted the path_verifier_extended_length_paths branch July 8, 2025 12:35
This was referenced Jul 29, 2025
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Merged
Closed
Merged
This was referenced Jan 12, 2026
Closed
Open
Closed
Closed
This was referenced Feb 1, 2026
Closed
Closed
Closed
@dependabotdependabotBot mentioned this pull request Feb 17, 2026
Merged
@dependabotdependabotBot mentioned this pull request Mar 3, 2026
Open
@dependabotdependabotBot mentioned this pull request Apr 2, 2026
Closed
This was referenced Apr 10, 2026
Open
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Apr 28, 2026
Open
Closed
@dependabotdependabotBot mentioned this pull request May 11, 2026
Open
This was referenced Jun 16, 2026
Closed
Merged
This was referenced Jun 25, 2026
Closed
Closed
This was referenced Jul 13, 2026
Closed
Closed
Open
@dependabotdependabotBot mentioned this pull request Aug 10, 2026
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vbreussvbreussvbreuss left review comments

Assignees

No one assigned

Labels

state: releasedIssues that are released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

MockFileSystem's IDirectoryInfo.Create implementation fails with \\?\C:\Foo style paths

2 participants

@mostynb@vbreuss