Skip to content

fix: make MockFile.Exists handle empty string - #811

Merged
fgreinacher merged 4 commits into
TestableIO:mainfrom
masood-haloratech:bug/file-exists-empty-string
Feb 17, 2022
Merged

fix: make MockFile.Exists handle empty string#811
fgreinacher merged 4 commits into
TestableIO:mainfrom
masood-haloratech:bug/file-exists-empty-string

Conversation

@masood-haloratech

@masood-haloratechmasood-haloratech commented Feb 10, 2022

Copy link
Copy Markdown
Contributor

PR created in relation to #810

Added check for path.Length in MockFile and added corresponding unit test.

I am a bit new to contributing so please let me know if I have missed anything :)

Comment threadsrc/System.IO.Abstractions.TestingHelpers/MockFile.cs
Comment threadsrc/System.IO.Abstractions.TestingHelpers/MockFile.cs

@fgreinacherfgreinacher left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a ton!

@fgreinacher
fgreinacher merged commit 3b8ecbd into TestableIO:mainFeb 17, 2022
@github-actions

Copy link
Copy Markdown

This is addressed in release v16.1.11.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

state: releasedIssues that are released

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@masood-haloratech@fgreinacher@siprbaum@mas-dude