Skip to content

fix: consider readonly files when deleting directories - #863

Merged
mergify[bot] merged 5 commits into
TestableIO:mainfrom
VictorLlanir:issue/849
Jul 15, 2022
Merged

fix: consider readonly files when deleting directories#863
mergify[bot] merged 5 commits into
TestableIO:mainfrom
VictorLlanir:issue/849

Conversation

@VictorLlanir

@VictorLlanirVictorLlanir commented Jul 3, 2022•
edited by fgreinacher
Loading

Copy link
Copy Markdown

Closes#849 by implementing directory validation for ReadOnly files when trying to delete directory recursively

On the RemoveFile method, there was no validation to check if there is a ReadOnly file inside the directory berfore trying to remove. This PR implements this validation.

@VictorLlanirVictorLlanir changed the title #849 - Implementing directory validation for ReadOnly filesfix: #849 - Implementing directory validation for ReadOnly filesJul 3, 2022
@VictorLlanirVictorLlanir mentioned this pull request Jul 3, 2022
Closed
@fgreinacher
fgreinacher self-requested a review July 11, 2022 20:59
fgreinacher
fgreinacher reviewed Jul 11, 2022
View reviewed changes

@fgreinacherfgreinacher left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @VictorLlanir, I have a small question/suggestion, let me know what you think.

Comment threadsrc/System.IO.Abstractions.TestingHelpers/MockFileSystem.cs Outdated
Comment threadsrc/System.IO.Abstractions.TestingHelpers/MockFileSystem.cs Outdated
@VictorLlanir

VictorLlanir commented Jul 14, 2022

Copy link
Copy Markdown
Author

You're right, @fgreinacher. I'm going to fix this and update this PR.

@fgreinacherfgreinacher changed the title fix: #849 - Implementing directory validation for ReadOnly filesfix: consider readonly files when deleting directoriesJul 15, 2022
fgreinacher
fgreinacher approved these changes Jul 15, 2022
View reviewed changes

@fgreinacherfgreinacher left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looking great now!

@mergify
mergifyBot merged commit fc2d041 into TestableIO:mainJul 15, 2022
This was referenced Jul 15, 2022
Merged
Merged
Merged
@github-actions

github-actionsBot commented Jul 19, 2022

Copy link
Copy Markdown

This is addressed in release v17.0.23.

@github-actionsgithub-actionsBot added the state: released Issues that are released label Jul 19, 2022
This was referenced Jan 29, 2026
Closed
Closed
This was referenced Feb 12, 2026
Closed
Closed
Closed
This was referenced Feb 19, 2026
Closed
Closed
This was referenced Feb 26, 2026
Closed
Closed
Closed
@dependabotdependabotBot mentioned this pull request Mar 12, 2026
Closed
This was referenced Mar 12, 2026
Closed
Closed
Closed
@dependabotdependabotBot mentioned this pull request Mar 26, 2026
Closed
This was referenced Apr 2, 2026
Closed
Closed
This was referenced Apr 16, 2026
Closed
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@fgreinacherfgreinacherfgreinacher approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@VictorLlanirVictorLlanir

Labels

state: releasedIssues that are released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Recursively delete a directory with readonly file results in inconsistent state

2 participants

@VictorLlanir@fgreinacher