Skip to content

fix: correctly handle access when moving a file - #873

Merged
mergify[bot] merged 1 commit into
TestableIO:mainfrom
vbreuss:bugfix/870-move-file-with-readonly-attribute
Aug 15, 2022
Merged

fix: correctly handle access when moving a file#873
mergify[bot] merged 1 commit into
TestableIO:mainfrom
vbreuss:bugfix/870-move-file-with-readonly-attribute

Conversation

@vbreuss

@vbreussvbreuss commented Aug 9, 2022

Copy link
Copy Markdown
Member

Fixes#870:
Change the order when moving files:

  1. Remove the previous file (throws an exception, if the file access is not sufficient)
  2. Add the moved file on the new location

Also added a unit test to verify the behavior.

@vbreuss
vbreussforce-pushed the bugfix/870-move-file-with-readonly-attribute branch from c757dbb to 3de0256CompareAugust 10, 2022 17:57
@vbtig
fix:TestableIO#870Moving a readonly file duplicates the file
a008c15
Fix function call order also in second `Move` method
@vbreuss
vbreussforce-pushed the bugfix/870-move-file-with-readonly-attribute branch from 3de0256 to a008c15CompareAugust 11, 2022 06:01
fgreinacher
fgreinacher reviewed Aug 11, 2022
View reviewed changes
Comment threadsrc/System.IO.Abstractions.TestingHelpers/MockFile.cs
@fgreinacherfgreinacher changed the title fix: #870 Moving a readonly file duplicates the filefix: correctly handle access when moving a fileAug 15, 2022
@fgreinacher

fgreinacher commented Aug 15, 2022

Copy link
Copy Markdown
Contributor

Thanks a ton @vbreuss!

@mergify
mergifyBot merged commit df30ba4 into TestableIO:mainAug 15, 2022
@github-actions

github-actionsBot commented Aug 15, 2022

Copy link
Copy Markdown

This is addressed in release v17.0.28.

@github-actionsgithub-actionsBot added the state: released Issues that are released label Aug 15, 2022
This was referenced Aug 15, 2022
Merged
Merged
Merged
vbreuss added a commit to vbreuss/System.IO.Abstractions that referenced this pull request Aug 26, 2022
@vbreuss@vbtig
fix:TestableIO#870Moving a readonly file duplicates the file (Testa…
1fd96ca
…bleIO#873)
Fix function call order also in second `Move` method
Co-authored-by: Valentin Breuß <v.breuss@tig.at>
This was referenced Jan 29, 2026
Closed
Closed
This was referenced Feb 12, 2026
Closed
Closed
Closed
This was referenced Feb 19, 2026
Closed
Closed
This was referenced Feb 26, 2026
Closed
Closed
Closed
This was referenced Mar 12, 2026
Closed
Closed
This was referenced Mar 19, 2026
Closed
Closed
Closed
@dependabotdependabotBot mentioned this pull request Apr 2, 2026
Closed
@dependabotdependabotBot mentioned this pull request Apr 9, 2026
Closed
This was referenced Apr 16, 2026
Closed
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@fgreinacherfgreinacherfgreinacher approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

state: releasedIssues that are released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Move a readonly file results in inconsistent state

3 participants

@vbreuss@fgreinacher@vbtig